Re: [PATCH v3 0/5] Fix LoongArch coverity error and cpu name bug

2022-07-18 Thread Richard Henderson
On 7/15/22 11:37, Xiaojuan Yang wrote: This series fix some coverity errors and loongarch_cpu_class_by_name function for LoongArch virt machine. Only the loongarch_pch_pic patch(number 2/5) need to be reviewed in this v3 verison, and other patches have been reviewed. Changes for v3: 1. In loon

Re: [PATCH] roms/opensbi: Upgrade from v1.0 to v1.1

2022-07-18 Thread Alistair Francis
On Wed, Jul 13, 2022 at 7:06 PM Bin Meng wrote: > > Upgrade OpenSBI from v1.0 to v1.1 and the pre-built bios images. > > The v1.1 release includes the following commits: > > 5b99603 lib: utils/ipi: Fix size check in aclint_mswi_cold_init() > 6dde435 lib: utils/sys: Extend HTIF library to allow cus

Re: [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking functionality for RISC-V

2022-07-18 Thread Alistair Francis
On Sun, Jul 17, 2022 at 8:17 PM Alexey Baturo wrote: > > From: Alexey Baturo > > Signed-off-by: Alexey Baturo Fixes: 4302bef9e178 ("target/riscv: Calculate address according to XLEN") Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c | 2 +- > 1 file changed, 1 insert

Re: [PATCH v3 1/5] target/loongarch/cpu: Fix cpu_class_by_name function

2022-07-18 Thread Richard Henderson
On 7/19/22 12:16, Richard Henderson wrote: On 7/15/22 11:37, Xiaojuan Yang wrote: In loongarch_cpu_class_by_name(char *cpu_model) function, the argument cpu_model already has the suffix '-loongarch-cpu', so we should remove the LOONGARCH_CPU_TYPE_NAME(cpu_model) macro. And add the assertion that

Re: [PATCH] roms/opensbi: Upgrade from v1.0 to v1.1

2022-07-18 Thread Alistair Francis
On Wed, Jul 13, 2022 at 7:06 PM Bin Meng wrote: > > Upgrade OpenSBI from v1.0 to v1.1 and the pre-built bios images. > > The v1.1 release includes the following commits: > > 5b99603 lib: utils/ipi: Fix size check in aclint_mswi_cold_init() > 6dde435 lib: utils/sys: Extend HTIF library to allow cus

Re: [PATCH v3 1/5] target/loongarch/cpu: Fix cpu_class_by_name function

2022-07-18 Thread Richard Henderson
On 7/15/22 11:37, Xiaojuan Yang wrote: In loongarch_cpu_class_by_name(char *cpu_model) function, the argument cpu_model already has the suffix '-loongarch-cpu', so we should remove the LOONGARCH_CPU_TYPE_NAME(cpu_model) macro. And add the assertion that 'cpu_model' resolves to a class of the appr

Re: [PATCH v4 16/19] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-18 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 7:42 AM Eugenio Perez Martin wrote: > > On Tue, Jul 19, 2022 at 4:39 AM Jason Wang wrote: > > > > > > 在 2022/7/18 18:29, Eugenio Pérez 写道: > > > Introduce the control virtqueue support for vDPA shadow virtqueue. This > > > is needed for advanced networking features like rx

Re: [PATCH v4 16/19] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-18 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 4:39 AM Jason Wang wrote: > > > 在 2022/7/18 18:29, Eugenio Pérez 写道: > > Introduce the control virtqueue support for vDPA shadow virtqueue. This > > is needed for advanced networking features like rx filtering. > > > > Virtio-net control VQ copies the descriptors to qemu's

Re: [PATCH v1] target/loongarch/cpu: Fix cpucfg default value

2022-07-18 Thread Richard Henderson
On 7/15/22 12:18, Xiaojuan Yang wrote: We should config cpucfg[20] to set value for the scache's ways, sets, and size arguments when loongarch cpu init. However, the old code wirte 'sets argument' twice, so we change one of them to 'size argument'. Signed-off-by: Xiaojuan Yang --- target/loon

Re: [PATCH v3 2/5] hw/intc/loongarch_pch_pic: Fix bugs for update_irq function

2022-07-18 Thread Richard Henderson
On 7/15/22 11:37, Xiaojuan Yang wrote: Fix such errors: 1. We should not use 'unsigned long' type as argument when we use find_first_bit(), and we use ctz64() to replace find_first_bit() to fix this bug. 2. It is not standard to use '1ULL << irq' to generate a irq mask. So, we replace it with 'MA

Re: [PATCH] tests/docker/dockerfiles: Add debian-loongarch-cross.docker

2022-07-18 Thread Richard Henderson
On 7/4/22 12:38, Richard Henderson wrote: Use the pre-packaged toolchain provided by Loongson via github. Signed-off-by: Richard Henderson --- configure | 5 tests/docker/Makefile.include | 2 ++ .../dockerfiles/debian-loongarch-cro

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2022-07-18 Thread Alexey Kardashevskiy
I just pushed another update to SLOF but before I do pull request - I usually wait for it to sync up with git.qemu.org but the syncing does not seem happening this time, is that still supposed to work like that with gitlab too? On 10/01/2022 16:04, Alexey Kardashevskiy wrote: The following c

Re: [PATCH 1/8] hmat acpi: Don't require initiator value in -numa

2022-07-18 Thread Liu, Jingqi
On 7/18/2022 1:43 PM, Brice Goglin wrote: Le 18/07/2022 à 05:17, Liu, Jingqi a écrit : On 7/11/2022 6:44 PM, Hesham Almatary via wrote: From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently al

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-18 Thread Robert Hoo
Ping... On Fri, 2022-07-01 at 17:23 +0800, Robert Hoo wrote: > On Thu, 2022-06-16 at 14:32 +0200, Igor Mammedov wrote: > > On Mon, 30 May 2022 11:40:45 +0800 > > Robert Hoo wrote: > > > > > Recent ACPI spec [1] has defined NVDIMM Label Methods _LS{I,R,W}, > > > which > > > depricates correspondin

Re: [PATCH] acpi/nvdimm: Define trace events for NVDIMM and substitute nvdimm_debug()

2022-07-18 Thread Robert Hoo
On Mon, 2022-07-18 at 15:41 +0200, Igor Mammedov wrote: > On Mon, 18 Jul 2022 15:12:03 +0800 > Robert Hoo wrote: > [...] > > BTW, during the unit test, I met some bios-table test error, > > https://gitlab.com/qemu-project/qemu/-/issues/1098, perhaps related > > to > > your patches in June. > > ht

Re: [PATCH v4 16/19] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-18 Thread Jason Wang
在 2022/7/18 18:29, Eugenio Pérez 写道: Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like rx filtering. Virtio-net control VQ copies the descriptors to qemu's VA, so we avoid TOCTOU with the guest's or device's memory every tim

Re: [PATCH v4 18/19] vdpa: Add device migration blocker

2022-07-18 Thread Jason Wang
在 2022/7/18 18:29, Eugenio Pérez 写道: Since the vhost-vdpa device is exposing _F_LOG, adding a migration blocker if it uses CVQ. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 1 + hw/virtio/vhost-vdpa.c | 14 ++ 2 files changed, 15 insertions(+) di

Re: [RFC PATCH v5 1/4] target/riscv: Add smstateen support

2022-07-18 Thread Weiwei Li
在 2022/7/18 下午11:37, Mayuresh Chitale 写道: On Fri, 2022-07-08 at 07:44 +0800, Weiwei Li wrote: 在 2022/7/8 上午12:53, Mayuresh Chitale 写道: On Sat, 2022-07-02 at 18:19 +0800, angell1518 wrote: At 2022-06-04 00:04:22, "Mayuresh Chitale" < mchit...@ventanamicro.com wrote: Smstateen extension speci

Re: [PATCH V3 0/6] Improve the U/S/H extension related check

2022-07-18 Thread Alistair Francis
On Mon, Jul 18, 2022 at 11:10 PM Weiwei Li wrote: > > This patchset tries to improve the U/S/H related check: > * add check for the supported privilege modes conbinations: only supporting M, > S mode is not a suggested combination > * add check for "H extension depends on I extension" > * add chec

Re: [PATCH] util: Fix broken build on Haiku

2022-07-18 Thread John Snow
On Mon, Jul 18, 2022 at 1:20 PM Thomas Huth wrote: > > A recent commit moved some Haiku-specific code parts from oslib-posix.c > to cutils.c, but failed to move the corresponding header #include > statement, too, so "make vm-build-haiku.x86_64" is currently broken. > Fix it by moving the header #i

Re: [PATCH v4 00/12] Improve reliability of VM tests

2022-07-18 Thread John Snow
On Mon, Jul 18, 2022 at 4:17 AM Thomas Huth wrote: > > On 08/07/2022 17.34, John Snow wrote: > > Note: patches 10-12 are included for testing simplicity, they shouldn't > > be merged. They will be included in a forthcoming block PR. > > > > V4: > > > > - Addressed concern by Marc-Andre in patch 01

[PATCH v5 2/2] ui/gtk: a new array param monitor to specify the target displays

2022-07-18 Thread Dongwon Kim
New integer array parameter, 'monitor' is for specifying the target monitors where individual GTK windows are placed upon launching. Monitor numbers in the array are associated with virtual consoles in the order of [VC0, VC1, VC2 ... VCn]. Every GTK window containing each VC will be placed in the

[PATCH v5 1/2] ui/gtk: detach VCs for additional guest displays

2022-07-18 Thread Dongwon Kim
Detaching any addtional guest displays in case multiple displays are assigned to the guest OS (e.g. max_outputs=n) so that all of them are visible upon lauching. Cc: Daniel P. Berrangé Cc: Markus Armbruster Cc: Philippe Mathieu-Daudé Cc: Paolo Bonzini Cc: Gerd Hoffmann Cc: Vivek Kasireddy Si

[PATCH v5 0/2] handling guest multiple displays

2022-07-18 Thread Dongwon Kim
This patch seires is for adding some useful features for the guest os with multi-displays. First patch is to make all of guest displays visible when guest os is launched using "detach". Second patch is for providing a method to assign each guest display to specific physical monitor, which would be

Re: [PATCH V3 5/6] target/riscv: Fix checks in hmode/hmode32

2022-07-18 Thread Alistair Francis
On Mon, Jul 18, 2022 at 11:13 PM Weiwei Li wrote: > > Add check for the implicit dependence between H and S > > Csrs only existed in RV32 will not trigger virtual instruction fault > when not in RV32 based on section 8.6.1 of riscv-privileged spec > (draft-20220717) > > Signed-off-by: Weiwei Li >

[PATCH 3/3] Hexagon (tests/tcg/hexagon) reference file for float_convd

2022-07-18 Thread Taylor Simpson
The test is in tests/tcg/multiarch/float_convd.c Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/float_convd.ref | 988 ++ 1 file changed, 988 insertions(+) create mode 100644 tests/tcg/hexagon/float_convd.ref diff --git a/tests/tcg/hexagon/float_convd.ref b/te

[PATCH 0/3] Hexagon bug fixes and test improvements

2022-07-18 Thread Taylor Simpson
1) Fixes a bug in qemu-hexagon 2) Fixes a bug in a test case 3) Adds reference file for float_convd test case Taylor Simpson (3): Hexagon (target/hexagon) make VyV operands use a unique temp Hexagon (tests/tcg/hexagon) Fix alignment in load_unpack.c Hexagon (tests/tcg/hexagon) reference file

[PATCH 1/3] Hexagon (target/hexagon) make VyV operands use a unique temp

2022-07-18 Thread Taylor Simpson
VyV operand is only used in the vshuff and vdeal instructions. These instructions write to both VyV and VxV operands. In the case where both operands are the same register, we need a separate location for VyV. We use the existing vtmp field in CPUHexagonState. Test case added in tests/tcg/hexag

[PATCH 2/3] Hexagon (tests/tcg/hexagon) Fix alignment in load_unpack.c

2022-07-18 Thread Taylor Simpson
The increment used in :brev tests was causing unaligned addresses Change the increment and the relevant expected values Signed-off-by: Taylor Simpson --- tests/tcg/hexagon/load_unpack.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/hexagon/load_unpa

[PULL 1/2] Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load

2022-07-18 Thread Taylor Simpson
Call the CHECK_NOSHUF macro multiple times: once in the fGEN_TCG_PRED_LOAD() and again in fLOAD(). Before this commit, a packet with a store and a predicated load with mem_noshuf that gets encoded like this: { P0 = cmp.eq(R17,#0x0) memw(R18+#0x0) = R2 if (!P0.new) R3 = memw(R17+#0

[PULL 2/2] Hexagon (target/hexagon) fix bug in mem_noshuf load exception

2022-07-18 Thread Taylor Simpson
The semantics of a mem_noshuf packet are that the store effectively happens before the load. However, in cases where the load raises an exception, we cannot simply execute the store first. This change adds a probe to check that the load will not raise an exception before executing the store. If

[PULL 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf

2022-07-18 Thread Taylor Simpson
The following changes since commit 24f01d220f56eab3268538ef10655b4fb2453fdf: Merge https://github.com/qemu/qemu into tip (2022-07-18 11:16:39 -0700) are available in the Git repository at: https://github.com/quic/qemu tags/pull-hex-20220718 for you to fetch changes up to

Re: [PATCH] hw/riscv: virt: pass random seed to fdt

2022-07-18 Thread Alistair Francis
On Thu, Jul 14, 2022 at 3:29 AM Jason A. Donenfeld wrote: > > Hi again, > > On Mon, Jul 11, 2022 at 06:45:42PM +0200, Jason A. Donenfeld wrote: > > I've reproduced the problem and determined the root cause. This is a > > generic issue with the mmio get_cycles() implementation before 5.9 on > > no-

Re: [PATCH] i386: Disable BTS and PEBS

2022-07-18 Thread Sean Christopherson
On Mon, Jul 18, 2022, Paolo Bonzini wrote: > This needs to be fixed in the kernel because old QEMU/new KVM is supported. I can't object to adding a quirk for this since KVM is breaking userspace, but on the KVM side we really need to stop "sanitizing" userspace inputs unless it puts the host at r

Re: [PATCH] linux-user: Unconditionally use pipe2() syscall

2022-07-18 Thread Laurent Vivier
Le 18/07/2022 à 18:34, Helge Deller a écrit : The pipe2() syscall is available on all Linux platforms since kernel 2.6.27, so use it unconditionally to emulate pipe() and pipe2(). Signed-off-by: Helge Deller diff --git a/linux-user/syscall.c b/linux-user/syscall.c index dbebfa4a8b..b27a6552aa

[PULL 38/40] pckbd: don't use legacy ps2_mouse_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 mouse device within KBDState using object_initialize_child() in i8042_initfn() and i8042_mmio_init() and realize it in i8042_realizefn() and i8042_mmio_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Ma

Re: [PATCH] tests: migration-test: Allow test to run without uffd

2022-07-18 Thread Peter Xu
Hi, Thomas, On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote: > On 07/07/2022 20.46, Peter Xu wrote: > > We used to stop running all tests if uffd is not detected. However > > logically that's only needed for postcopy not the rest of tests. > > > > Keep running the rest when still pos

[PULL 35/40] pckbd: introduce new vmstate_kbd_mmio VMStateDescription for the I8042_MMIO device

2022-07-18 Thread Mark Cave-Ayland
This enables us to register the VMStateDescription using the DeviceClass vmsd property rather than having to call vmstate_register() from i8042_mmio_realize(). Note that this is a migration break for the MIPS magnum machine which is the only user of the I8042_MMIO device. Signed-off-by: Mark Ca

Re: [PATCH v2] linux-user/hppa: Fix segfaults on page zero

2022-07-18 Thread Laurent Vivier
Le 18/07/2022 à 18:40, Helge Deller a écrit : This program: int main(void) { asm("bv %r0(%r0)"); return 0; } produces on real hppa hardware the expected segfault: SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0x3} --- killed by SIGSEGV +++ Segmentation fault But

[PULL 32/40] lasips2: don't use legacy ps2_kbd_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 keyboard device within LASIPS2KbdPort using object_initialize_child() in lasips2_kbd_port_init() and realize it in lasips2_kbd_port_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <

Re: [PATCH] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

2022-07-18 Thread Thomas Huth
On 11/07/2022 22.30, John Snow wrote: On Mon, Jul 11, 2022 at 5:57 AM Thomas Huth wrote: 'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions"). Signed-off-by: Thomas Huth --- python/qemu/qmp/legacy.py

[PULL 31/40] lasips2: switch register memory region to DEVICE_BIG_ENDIAN

2022-07-18 Thread Mark Cave-Ayland
The LASI device (and so also the LASIPS2 device) are only used for the HPPA B160L machine which is a big endian architecture. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-32-mark.cave-ayl...@ilande.co

[PULL 40/40] pckbd: remove legacy i8042_mm_init() function

2022-07-18 Thread Mark Cave-Ayland
This legacy function is only used during the initialisation of the MIPS magnum machine, so inline its functionality directly into mips_jazz_init() and then remove it. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712

[python-qemu-qmp MR #9] qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

2022-07-18 Thread GitLab Bot
Author: Thomas Huth - https://gitlab.com/thuth Merge Request: https://gitlab.com/qemu-project/python-qemu-qmp/-/merge_requests/9 ... from: thuth/python-qemu-qmp:fixes ... into: qemu-project/python-qemu-qmp:main 'returns-whitelist' has been renamed to 'command-returns-exceptions' in QEMU commit b8

[PULL 21/40] lasips2: introduce lasips2_kbd_port_class_init() and lasips2_kbd_port_realize()

2022-07-18 Thread Mark Cave-Ayland
Introduce a new lasips2_kbd_port_class_init() function which uses a new lasips2_kbd_port_realize() function to initialise the PS2 keyboard device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-22-mark.

[PULL 39/40] ps2: remove unused legacy ps2_mouse_init() function

2022-07-18 Thread Mark Cave-Ayland
Now that the legacy ps2_mouse_init() function is no longer used, it can be completely removed along with its associated trace-event. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-40-mark.cave-ayl...@i

[PULL 33/40] lasips2: don't use legacy ps2_mouse_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 mouse device within LASIPS2MousePort using object_initialize_child() in lasips2_mouse_port_init() and realize it in lasips2_mouse_port_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id

[PULL 30/40] lasips2: standardise on lp name for LASIPS2Port variables

2022-07-18 Thread Mark Cave-Ayland
This is shorter to type and keeps the naming convention consistent within the LASIPS2 device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-31-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathi

[PULL 18/40] lasips2: introduce new LASIPS2_MOUSE_PORT QOM type

2022-07-18 Thread Mark Cave-Ayland
This will be soon be used to hold the underlying PS2_MOUSE_DEVICE object. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-19-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé --- hw/in

[PULL 37/40] ps2: remove unused legacy ps2_kbd_init() function

2022-07-18 Thread Mark Cave-Ayland
Now that the legacy ps2_kbd_init() function is no longer used, it can be completely removed along with its associated trace-event. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-38-mark.cave-ayl...@ila

[PULL 36/40] pckbd: don't use legacy ps2_kbd_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 keyboard device within KBDState using object_initialize_child() in i8042_initfn() and i8042_mmio_init() and realize it in i8042_realizefn() and i8042_mmio_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter

[PULL 16/40] lasips2: QOMify LASIPS2Port

2022-07-18 Thread Mark Cave-Ayland
This becomes an abstract QOM type which will be a parent type for separate keyboard and mouse port types. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-17-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Ph

[PULL 29/40] lasips2: rename LASIPS2Port parent pointer to lasips2

2022-07-18 Thread Mark Cave-Ayland
This makes it clearer that the pointer is a reference to the LASIPS2 container device rather than an implied part of the QOM hierarchy. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-30-mark.cave-ayl...

[PULL 26/40] lasips2: add named input gpio to port for downstream PS2 device IRQ

2022-07-18 Thread Mark Cave-Ayland
The named input gpio is to be connected to the IRQ output of the downstream PS2 device and used to drive the port IRQ. Initialise the named input gpio in lasips2_port_init() and add new lasips2_port_class_init() and lasips2_port_realize() functions to connect the PS2 device output gpio to the new n

[PULL 34/40] lasips2: update VMStateDescription for LASIPS2 device

2022-07-18 Thread Mark Cave-Ayland
Since this series has already introduced a migration break for the HPPA B160L machine, we can use this opportunity to improve the VMStateDescription for the LASIPS2 device. Add the new int_status field to the VMStateDescription and remodel the ports as separate VMSTATE_STRUCT instances representin

[PULL 25/40] lasips2: introduce LASIPS2PortDeviceClass for the LASIPS2_PORT device

2022-07-18 Thread Mark Cave-Ayland
This will soon be used to store the reference to the LASIPS2_PORT parent device for LASIPS2_KBD_PORT and LASIPS2_MOUSE_PORT. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-26-mark.cave-ayl...@ilande.co.

[PULL 24/40] lasips2: introduce port IRQ and new lasips2_port_init() function

2022-07-18 Thread Mark Cave-Ayland
Introduce a new lasips2_port_init() QOM init function for the LASIPS2_PORT type and use it to initialise a new gpio for use as a port IRQ. Add a new qemu_irq representing the gpio as a new irq field within LASIPS2Port. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Delle

[PULL 17/40] lasips2: introduce new LASIPS2_KBD_PORT QOM type

2022-07-18 Thread Mark Cave-Ayland
This will be soon be used to hold the underlying PS2_KBD_DEVICE object. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-18-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé --- hw/inpu

[PULL 28/40] lasips2: switch to using port-based IRQs

2022-07-18 Thread Mark Cave-Ayland
Now we can implement port-based IRQs by wiring the PS2 device IRQs to the LASI2Port named input gpios rather than directly to the LASIPS2 device, and generate the LASIPS2 output IRQ from the int_status bitmap representing the individual port IRQs instead of the birq boolean. This enables us to rem

[PULL 14/40] lasips2: remove legacy lasips2_initfn() function

2022-07-18 Thread Mark Cave-Ayland
There is only one user of the legacy lasips2_initfn() function which is in machine_hppa_init(), so inline its functionality into machine_hppa_init() and then remove it. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <202207

[PULL 22/40] lasips2: introduce lasips2_mouse_port_class_init() and lasips2_mouse_port_realize()

2022-07-18 Thread Mark Cave-Ayland
Introduce a new lasips2_mouse_port_class_init() function which uses a new lasips2_mouse_port_realize() function to initialise the PS2 mouse device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-23-mark

[PULL 12/40] lasips2: don't use vmstate_register() in lasips2_realize()

2022-07-18 Thread Mark Cave-Ayland
Since lasips2 is a qdev device then vmstate_ps2_mouse can be registered using the DeviceClass vmsd field instead. Note that due to the use of the base parameter in the original vmstate_register() function call, this is actually a migration break for the HPPA B160L machine. Signed-off-by: Mark Ca

[PULL 27/40] lasips2: add named input gpio to handle incoming port IRQs

2022-07-18 Thread Mark Cave-Ayland
The LASIPS2 device named input gpio is soon to be connected to the port output IRQs. Add a new int_status field to LASIPS2State which is a bitmap representing the port input IRQ status which will be enabled in the next patch. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helg

[PULL 13/40] lasips2: remove the qdev base property and the lasips2_properties array

2022-07-18 Thread Mark Cave-Ayland
The base property was only needed for use by vmstate_register() in order to preserve migration compatibility. Now that the lasips2 migration state is registered through the DeviceClass vmsd field, the base property and also the lasips2_properties array can be removed completely as they are no longe

[PULL 20/40] lasips2: move mouse port initialisation to new lasips2_mouse_port_init() function

2022-07-18 Thread Mark Cave-Ayland
Move the initialisation of the mouse port from lasips2_init() to a new lasips2_mouse_port_init() function which will be invoked using object_initialize_child() during the LASIPS2 device init. Update LASIPS2State so that it now holds the new LASIPS2MousePort child object and ensure that it is real

[PULL 10/40] pl050: don't use legacy ps2_kbd_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 keyboard device within PL050KbdState using object_initialize_child() in pl050_kbd_init() and realize it in pl050_kbd_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.

[PULL 15/40] lasips2: change LASIPS2State dev pointer from void to PS2State

2022-07-18 Thread Mark Cave-Ayland
This allows the compiler to enforce that the PS2 device pointer is always of type PS2State. Update the name of the pointer from dev to ps2dev to emphasise this type change. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20

[PULL 23/40] lasips2: rename LASIPS2Port irq field to birq

2022-07-18 Thread Mark Cave-Ayland
The existing boolean irq field in LASIPS2Port will soon be replaced by a proper qemu_irq, so rename the field to birq to allow the upcoming qemu_irq to use the irq name. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220

[PULL 05/40] pl050: introduce new PL050_MOUSE_DEVICE QOM type

2022-07-18 Thread Mark Cave-Ayland
This will be soon be used to hold the underlying PS2_MOUSE_DEVICE object. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-6-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé --- hw/inp

[PULL 09/40] pl050: introduce pl050_mouse_class_init() and pl050_mouse_realize()

2022-07-18 Thread Mark Cave-Ayland
Introduce a new pl050_mouse_class_init() function containing a call to device_class_set_parent_realize() which calls a new pl050_mouse_realize() function to initialise the PS2 mouse device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell

[PULL 08/40] pl050: introduce pl050_kbd_class_init() and pl050_kbd_realize()

2022-07-18 Thread Mark Cave-Ayland
Introduce a new pl050_kbd_class_init() function containing a call to device_class_set_parent_realize() which calls a new pl050_kbd_realize() function to initialise the PS2 keyboard device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell

[PULL 19/40] lasips2: move keyboard port initialisation to new lasips2_kbd_port_init() function

2022-07-18 Thread Mark Cave-Ayland
Move the initialisation of the keyboard port from lasips2_init() to a new lasips2_kbd_port_init() function which will be invoked using object_initialize_child() during the LASIPS2 device init. Update LASIPS2State so that it now holds the new LASIPS2KbdPort child object and ensure that it is realis

[PULL 03/40] pl050: change PL050State dev pointer from void to PS2State

2022-07-18 Thread Mark Cave-Ayland
This allows the compiler to enforce that the PS2 device pointer is always of type PS2State. Update the name of the pointer from dev to ps2dev to emphasise this type change. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20

[PULL 11/40] pl050: don't use legacy ps2_mouse_init() function

2022-07-18 Thread Mark Cave-Ayland
Instantiate the PS2 mouse device within PL050MouseState using object_initialize_child() in pl050_mouse_init() and realize it in pl050_mouse_realize() accordingly. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <202207122152

[PULL 06/40] pl050: move logic from pl050_realize() to pl050_init()

2022-07-18 Thread Mark Cave-Ayland
The logic for initialising the register memory region and the sysbus output IRQ does not depend upon any device properties and so can be moved from pl050_realize() to pl050_init(). Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message

[PULL 01/40] pl050: move PL050State from pl050.c to new pl050.h header file

2022-07-18 Thread Mark Cave-Ayland
This allows the QOM types in pl050.c to be used elsewhere by simply including pl050.h. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-2-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé

[PULL 00/40] qemu-sparc queue 20220718

2022-07-18 Thread Mark Cave-Ayland
The following changes since commit 782378973121addeb11b13fd12a6ac2e69faa33f: Merge tag 'pull-target-arm-20220718' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-18 16:29:32 +0100) are available in the Git repository at: https://github.com/mcayland/qem

[PULL 07/40] pl050: introduce PL050DeviceClass for the PL050 device

2022-07-18 Thread Mark Cave-Ayland
This will soon be used to store the reference to the PL050 parent device for PL050_KBD_DEVICE and PL050_MOUSE_DEVICE. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-8-mark.cave-ayl...@ilande.co.uk> Revi

[PULL 02/40] pl050: rename pl050_keyboard_init() to pl050_kbd_init()

2022-07-18 Thread Mark Cave-Ayland
This is for consistency with all of the other devices that use the PS2 keyboard device. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-3-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daud

[PULL 04/40] pl050: introduce new PL050_KBD_DEVICE QOM type

2022-07-18 Thread Mark Cave-Ayland
This will be soon be used to hold the underlying PS2_KBD_DEVICE object. Signed-off-by: Mark Cave-Ayland Tested-by: Helge Deller Acked-by: Helge Deller Reviewed-by: Peter Maydell Message-Id: <20220712215251.7944-5-mark.cave-ayl...@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé --- hw/input

Re: [PATCH v4 2/3] target/ppc: Implement hashst and hashchk

2022-07-18 Thread Lucas Mateus Martins Araujo e Castro
On 15/07/2022 17:54, Víctor Colombo wrote: Implementation for instructions hashst and hashchk, which were added in Power ISA 3.1B. It was decided to implement the hash algorithm from ground up in this patch exactly as described in Power ISA. Signed-off-by: Víctor Colombo --- target/ppc/excp_

Re: [PATCH v2 00/40] PS2 device QOMification - part 2

2022-07-18 Thread Mark Cave-Ayland
On 12/07/2022 22:52, Mark Cave-Ayland wrote: Here is the follow-on series from part 1 which completes the work to remove the legacy global device init functions for PS2 devices. Now that part 1 has been applied, the hard part to remove the PS2 function callback and argument has been completed an

Re: [PATCH] tests: migration-test: Allow test to run without uffd

2022-07-18 Thread Thomas Huth
On 07/07/2022 20.46, Peter Xu wrote: We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running the rest when still possible. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 11 +-- 1 f

Re: [PATCH v4 3/3] target/ppc: Implement hashstp and hashchkp

2022-07-18 Thread Lucas Mateus Martins Araujo e Castro
Reviewed-by: Lucas Mateus Castro On 15/07/2022 17:54, Víctor Colombo wrote: Implementation for instructions hashstp and hashchkp, the privileged versions of hashst and hashchk, which were added in Power ISA 3.1B. Signed-off-by: Víctor Colombo --- target/ppc/excp_helper.c |

Re: [PATCH v2 1/1] python/machine: Fix AF_UNIX path too long on macOS

2022-07-18 Thread Peter Delevoryas
On Mon, Jul 18, 2022 at 09:56:17AM +0100, Daniel P. Berrangé wrote: > On Sat, Jul 16, 2022 at 10:34:34AM -0700, Peter Delevoryas wrote: > > On macOS, private $TMPDIR's are the default. These $TMPDIR's are > > generated from a user's unix UID and UUID [1], which can create a > > relatively long path

Re: [PATCH v4 1/3] target/ppc: Add HASHKEYR and HASHPKEYR SPRs

2022-07-18 Thread Lucas Mateus Martins Araujo e Castro
On 15/07/2022 17:54, Víctor Colombo wrote: Add the Special Purpose Registers HASHKEYR and HASHPKEYR, which were introduced by the Power ISA 3.1B. They are used by the new instructions hashchk(p) and hashst(p). The ISA states that the Operating System should generate the value for these registers

[PATCH v2] aspeed: qcom: add block backed FRU devices

2022-07-18 Thread Jae Hyun Yoo
From: Graeme Gregory The FRU devices for dc-scm-v1 and firework on bus IF_NONE. -drive file=$DC_SCM_FRU,format=raw,if=none,unit=0 -drive file=$FIREWORK_FRU,format=raw,if=none,unit=1 file must match FRU size of 128k Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun Yoo Reviewed-by: C�dric

Re: [PATCH v4 1/1] target/riscv: Add Zihintpause support

2022-07-18 Thread Dao Lu
ping On Tue, Jul 5, 2022 at 10:49 AM Dao Lu wrote: > > Added support for RISC-V PAUSE instruction from Zihintpause extension, > enabled by default. > > Tested-by: Heiko Stuebner > Signed-off-by: Dao Lu > --- > target/riscv/cpu.c | 2 ++ > target/riscv/cpu.h

[PULL 27/30] target/ppc: check tb_env != 0 before printing TBU/TBL/DECR

2022-07-18 Thread Daniel Henrique Barboza
From: Matheus Ferst When using "-machine none", env->tb_env is not allocated, causing the segmentation fault reported in issue #85 (launchpad bug #811683). To avoid this problem, check if the pointer != NULL before calling the methods to print TBU/TBL/DECR. Resolves: https://gitlab.com/qemu-proj

[PULL 28/30] ppc: Check partition and process table alignment

2022-07-18 Thread Daniel Henrique Barboza
From: Leandro Lupori Check if partition and process tables are properly aligned, in their size, according to PowerISA 3.1B, Book III 6.7.6 programming note. Hardware and KVM also raise an exception in these cases. Signed-off-by: Leandro Lupori Reviewed-by: Fabiano Rosas Message-Id: <2022062813

Re: [PATCH] util: Fix broken build on Haiku

2022-07-18 Thread Marc-André Lureau
On Mon, Jul 18, 2022 at 9:22 PM Thomas Huth wrote: > A recent commit moved some Haiku-specific code parts from oslib-posix.c > to cutils.c, but failed to move the corresponding header #include > statement, too, so "make vm-build-haiku.x86_64" is currently broken. > Fix it by moving the header #in

[PULL 30/30] target/ppc: Check page dir/table base alignment

2022-07-18 Thread Daniel Henrique Barboza
From: Leandro Lupori According to PowerISA 3.1B, Book III 6.7.6 programming note, the page directory base addresses are expected to be aligned to their size. Real hardware seems to rely on that and will access the wrong address if they are misaligned. This results in a translation failure even if

[PULL 24/30] target/ppc: Move slbfee to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-10-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

[PULL 20/30] target/ppc: Move slbia to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-6-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

[PULL 25/30] target/ppc: Move slbsync to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-11-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/insn32.decode | 2 ++ target/ppc/translate.c |

[PULL 21/30] target/ppc: Move slbmte to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-7-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

[PULL 23/30] target/ppc: Move slbmfee to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-9-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

[PULL 19/30] target/ppc: Move slbieg to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-5-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

[PULL 14/30] target/ppc: Move tlbie[l] to decode tree

2022-07-18 Thread Daniel Henrique Barboza
From: Leandro Lupori Also decode RIC, PRS and R operands. Signed-off-by: Leandro Lupori Reviewed-by: Daniel Henrique Barboza Message-Id: <20220712193741.59134-2-leandro.lup...@eldorado.org.br> [danielhb: mark bit 31 in @X_tlbie pattern as ignored] Signed-off-by: Daniel Henrique Barboza --- t

[PULL 22/30] target/ppc: Move slbmfev to decodetree

2022-07-18 Thread Daniel Henrique Barboza
From: Lucas Coutinho Reviewed-by: Leandro Lupori Signed-off-by: Lucas Coutinho Message-Id: <20220701133507.740619-8-lucas.couti...@eldorado.org.br> Signed-off-by: Daniel Henrique Barboza --- target/ppc/helper.h | 2 +- target/ppc/insn32.decode |

  1   2   3   4   >