[PATCH qemu v6 00/10] Add mask agnostic behavior for rvv instructions

2022-06-19 Thread ~eopxd
According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There are multiple possibility for agnos

[PATCH qemu v6 06/10] target/riscv: rvv: Add mask agnostic for vector fix-point arithmetic instructions

2022-06-19 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c inde

[PATCH qemu v6 10/10] target/riscv: rvv: Add option 'rvv_ma_all_1s' to enable optional mask agnostic behavior

2022-06-19 Thread ~eopxd
From: eopXD According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There are multiple possibi

[PATCH qemu v6 02/10] target/riscv: rvv: Add mask agnostic for vector load / store instructions

2022-06-19 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 5 target/riscv/vector_helper.c| 35 + 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/ta

[PATCH qemu v6 03/10] target/riscv: rvv: Add mask agnostic for vx instructions

2022-06-19 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 2 ++ target/riscv/vector_helper.c| 3 +++ 2 files changed, 5 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/tar

[PATCH qemu v6 07/10] target/riscv: rvv: Add mask agnostic for vector floating-point instructions

2022-06-19 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 12 target/riscv/vector_helper.c| 26 + 2 files changed, 38 insertions(+) diff --git a/target/risc

[PATCH qemu v6 04/10] target/riscv: rvv: Add mask agnostic for vector integer shift instructions

2022-06-19 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/

Re: [PATCH 4/4] hw/riscv: use qemu_fdt_setprop_strings() in sifive_u.c

2022-06-19 Thread Alistair Francis
On Sun, Jun 19, 2022 at 6:14 AM Ben Dooks wrote: > > Use the qemu_fdt_setprop_strings() in sifve_u.c to simplify > the code. > > Signed-off-by: Ben Dooks Do you mind updating the other machines as well? Reviewed-by: Alistair Francis Alistair > --- > hw/riscv/sifive_u.c | 18 +---

Re: [PATCH 3/4] device_tree: add qemu_fdt_setprop_strings() helper

2022-06-19 Thread Alistair Francis
On Sun, Jun 19, 2022 at 6:20 AM Ben Dooks wrote: > > Add a helper to set a property from a set of strings > to reduce the following code: > > static const char * const clint_compat[2] = { > "sifive,clint0", "riscv,clint0" > }; > > qemu_fdt_setprop_string_array(fdt, nodename, "c

Re: [PATCH 2/4] hw/riscv: use qemu_fdt_setprop_reg64_map() in sifive_u.c

2022-06-19 Thread Alistair Francis
On Mon, Jun 20, 2022 at 4:42 PM Alistair Francis wrote: > > On Sun, Jun 19, 2022 at 6:14 AM Ben Dooks wrote: > > > > Use the qemu_fdt_setprop_reg64_map() to replace the code > > that sets the property manually. > > > > Signed-off-by: Ben Dooks > > Reviewed-by: Alistair Francis > > Alistair > >

Re: [PATCH 2/4] hw/riscv: use qemu_fdt_setprop_reg64_map() in sifive_u.c

2022-06-19 Thread Alistair Francis
On Sun, Jun 19, 2022 at 6:14 AM Ben Dooks wrote: > > Use the qemu_fdt_setprop_reg64_map() to replace the code > that sets the property manually. > > Signed-off-by: Ben Dooks Reviewed-by: Alistair Francis Alistair > -- > v2: > - changed to qemu_fdt_setprop_reg64_map() from previous > --- > hw

Re: [PATCH 1/4] device_tree: add qemu_fdt_setprop_reg64_map helper

2022-06-19 Thread Alistair Francis
On Sun, Jun 19, 2022 at 6:15 AM Ben Dooks wrote: > > Add a macro qemu_fdt_setprop_reg64_map() to set the given > node's reg property directly from the memory map entry > to avoid open coding of the following: > > qemu_fdt_setprop_cells(fdt, nodename, "reg", > 0x0, memmap[SIFIVE_U_DEV_O

Re: [PATCH qemu v2 2/2] ppc/spapr: Implement H_WATCHDOG

2022-06-19 Thread Cédric Le Goater
On 6/20/22 05:13, Alexey Kardashevskiy wrote: On 6/18/22 21:01, Cédric Le Goater wrote: On 6/17/22 08:07, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a proposed driver for pseries uses:

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-19 Thread Cédric Le Goater
On 6/20/22 05:37, Alexey Kardashevskiy wrote: On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy ---

RE: [RFC PATCH 01/12] configure: Add iovisor/ubpf project as a submodule for QEMU

2022-06-19 Thread Zhang, Chen
> -Original Message- > From: Daniel P. Berrangé > Sent: Friday, June 17, 2022 4:05 PM > To: Zhang, Chen > Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Paolo Bonzini ; Eduardo > Habkost ; Eric Blake ; Markus > Armbruster ; Peter Maydell > ; Thomas Huth ; Laurent > Vivier ; Yuri Benditov

[PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-19 Thread Leonardo Bras
When originally implemented, zero_copy_send was designed as a Migration paramenter. But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability. Taking into account how

[PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-19 Thread Leonardo Bras
Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad as causing a corruption

Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-19 Thread Leonardo Bras Soares Passos
CC: Jiri Denemark On Mon, Jun 20, 2022 at 2:40 AM Leonardo Bras wrote: > > When originally implemented, zero_copy_send was designed as a Migration > paramenter. > > But taking into account how is that supposed to work, and how > the difference between a capability and a parameter, it only makes

[PATCH v4 0/4] MSG_ZEROCOPY fixes & improvements

2022-06-19 Thread Leonardo Bras
Patches 1 & 2 are about a fix needed to make zero-copy flush work. The code that incremented the sendmsg counter ended up missing in the last versions of the patchset, causing the flush to never happen. Patch 3 is about an improvement on flushing that improves sending performance. Patch 4 is abo

[PATCH v4 3/4] migration: zero-copy flush only at the end of bitmap scanning

2022-06-19 Thread Leonardo Bras
When sending memory pages with MSG_ZEROCOPY, it's necessary to flush to make sure all dirty pages are sent before a future version of them happens to be sent. Currently, the flush happens every time at the end of ram_save_iterate(), which usually happens around 20x per second, due to a timeout. C

[PATCH v4 1/4] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-19 Thread Leonardo Bras
During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were introduced, particularly at qio_channel_socket_writev(). Rewrite some of those changes so it's easier to read. Also, introduce an assert to help detect incorrect zero-copy usage is when it's disabled on build. Signed-off-by: Le

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-19 Thread Jason Wang
On Fri, Jun 17, 2022 at 4:17 PM Eugenio Perez Martin wrote: > > On Fri, Jun 17, 2022 at 3:29 AM Jason Wang wrote: > > > > On Wed, Jun 15, 2022 at 6:03 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Jun 15, 2022 at 5:04 AM Jason Wang wrote: > > > > > > > > On Tue, Jun 14, 2022 at 5:32 PM

Re: [PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-19 Thread Alexey Kardashevskiy
On 6/18/22 02:50, Daniel Henrique Barboza wrote: On 6/17/22 03:07, Alexey Kardashevskiy wrote: It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy --- Reviewed-by: Daniel Henrique Barboza so

[RFC v2] Adding block layer APIs resembling Linux ZoneBlockDevice ioctls.

2022-06-19 Thread Sam Li
Fix some mistakes before. It can report a range of zones now. Signed-off-by: Sam Li --- block/block-backend.c | 22 block/coroutines.h| 5 + block/file-posix.c| 182 ++ block/io.c| 23 i

Re: [PATCH qemu v2 2/2] ppc/spapr: Implement H_WATCHDOG

2022-06-19 Thread Alexey Kardashevskiy
On 6/18/22 21:01, Cédric Le Goater wrote: On 6/17/22 08:07, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a proposed driver for pseries uses: https://patchwork.ozlabs.org/project/linuxppc

[RFC v1] Add support for zoned device

2022-06-19 Thread Sam Li
This patch series adds support for zoned device to virtio-blk emulation. Zoned storage can support sequential writes, which reduces write amplification in SSD, leading to higher write throughput and increased capacity. v1: - add block layer APIs resembling Linux ZoneBlockDevice ioctls. By adding

Re: [PULL 00/11] Bsd user syscall 2022q2 patches

2022-06-19 Thread Richard Henderson
On 6/19/22 11:05, Warner Losh wrote: The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11 21:13:27 -0700) are available in the Git repository at: ssh://g...@github.com/qemu-bsd-u

Re: [PATCH] hw/pci-host/i440fx: Remove unused parameter from i440fx_init()

2022-06-19 Thread B
Am 12. Juni 2022 19:28:00 UTC schrieb Bernhard Beschow : >pi440fx_state is an out-parameter which is never read by the caller. > >Signed-off-by: Bernhard Beschow Ping >--- > hw/i386/pc_piix.c| 3 --- > hw/pci-host/i440fx.c | 4 +--- > include/hw/pci-host/i440fx.h | 1 - > 3 f

[PULL 08/11] bsd-user: Implement rmdir and undocumented __getcwd

2022-06-19 Thread Warner Losh
Implemenet rmdir and __getcwd. __getcwd is the undocumented back end to getcwd(3). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 29 + bsd-user/freebsd/os-syscall.c

[PULL 11/11] bsd-user: Implement acct and sync

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 23 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 31 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index fda368

[PULL 07/11] bsd-user: Implement mkdir and mkdirat

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 27 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 35 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index 93

[PULL 09/11] bsd-user: Implement dup and dup2

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 12 bsd-user/freebsd/os-syscall.c | 8 2 files changed, 20 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index 8ec53145894..0215

[PULL 05/11] bsd-user: Implement rename and renameat

2022-06-19 Thread Warner Losh
Plus the helper LOCK_PATH2 and UNLOCK_PATH2 macros. Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 45 +++ bsd-user/freebsd/os-syscall.c | 8 +++ 2 files ch

[PULL 10/11] bsd-user: Implement trunctate and ftruncate

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 29 + bsd-user/freebsd/os-syscall.c | 8 2 files changed, 37 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index

[PULL 03/11] bsd-user: Implement revoke, access, eaccess and faccessat

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 53 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 69 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file

[PULL 06/11] bsd-user: Implement link, linkat, unlink and unlinkat

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 54 +++ bsd-user/freebsd/os-syscall.c | 16 +++ 2 files changed, 70 insertions(+) diff --git a/bsd-user/bs

[PULL 04/11] bsd-user: Implement chdir and fchdir

2022-06-19 Thread Warner Losh
Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 19 +++ bsd-user/freebsd/os-syscall.c | 8 2 files changed, 27 insertions(+) diff --git a/bsd-user/bsd-file.h b/bsd-user/bsd-file.h index 6ff2be24e3

[PULL 02/11] bsd-user: Implement fdatasync, fsync and close_from

2022-06-19 Thread Warner Losh
Implement fdatasync(2), fsync(2) and close_from(2). Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 19 +++ bsd-user/freebsd/os-syscall.c | 12 2 files changed, 31 i

[PULL 01/11] bsd-user: Implement open, openat and close

2022-06-19 Thread Warner Losh
Add the open, openat and close system calls. We need to lock paths, so implmenent that as well. Signed-off-by: Stacey Son Signed-off-by: Jung-uk Kim Signed-off-by: Kyle Evans Signed-off-by: Warner Losh Reviewed-by: Richard Henderson --- bsd-user/bsd-file.h | 49

[PULL 00/11] Bsd user syscall 2022q2 patches

2022-06-19 Thread Warner Losh
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11 21:13:27 -0700) are available in the Git repository at: ssh://g...@github.com/qemu-bsd-user/qemu-bsd-user.git tags/bsd-user-sysc

Re: [PATCH 00/21] aspeed: Extend ast2600 I2C model with new mode

2022-06-19 Thread Cédric Le Goater
Hello Corey, On 6/6/22 17:07, Cédric Le Goater wrote: Hello, Here is a series aggregating recent changes proposed on the Aspeed ast2600 I2C controller model. First comes a large set of changes converting the model to use the registerfield interface and adding the I2C new register mode (Joe). S

Re: [PATCH 0/1] hw: m25p80: fix aspeed_smc tests failure when run in isolation

2022-06-19 Thread Cédric Le Goater
On 6/18/22 01:07, Iris Chen wrote: Hey everyone, I discovered that some of the tests in tests/qtest/aspeed_smc-test.c were failing when run in isolation due to dependencies between the tests. For example, one test would test the reading of a block of memory written in the test before it. I thin

Re: A new qemu acpi test with bios bits

2022-06-19 Thread Ani Sinha
On Fri, Jun 17, 2022 at 10:44 PM Ani Sinha wrote: > > oops, Phil's redhat email bounced! > > On Fri, Jun 17, 2022 at 10:41 PM Ani Sinha wrote: > > > > Hi : > > I am trying to write a new ACPI/smbios test framework that uses bios > > bits (https://biosbits.org/ ). > > This test will effectively: >

Re: [PATCH] ui/cocoa: Fixed modeswitching glitch in zoomed fullscreen mode

2022-06-19 Thread Imran Yusuff
Hi, Many thanks for the feedback. Actually I have investigated this by writing printfs in between statements to print out the 'self rect' values, and apparently the statement [normalWindow setFrame:NSMakeRect([normalWindow frame].origin.x, ... modifies this 'self rect' values, for reason I am not

[PATCH] ui/cocoa: Fixed modeswitching glitch in zoomed fullscreen mode

2022-06-19 Thread Imran Yusuff
This applies only on macOS using cocoa UI library. In zoom-to-fit fullscreen mode, upon graphics mode switch, the viewport size is wrong, and the usual consequence is only a part of the screen is visible. One have to exit and reenter fullscreen mode to fix this. This is reproducible by setting up

Re: [PATCH v2 7/9] ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[]

2022-06-19 Thread Cédric Le Goater
On 6/18/22 13:02, Daniel Henrique Barboza wrote: It's inneficient to scroll all child objects when we have all PHBs available in chip8->phbs[]. pnv_chip_power8_pic_print_info_child() ended up folded into pic_print_info() for simplicity. Reviewed-by: Frederic Barrat Signed-off-by: Daniel Henriq

Re: [PATCH] aspeed/hace: Add missing newlines to unimp messages

2022-06-19 Thread Cédric Le Goater
On 6/18/22 11:01, Joel Stanley wrote: Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thanks, C. --- hw/misc/aspeed_hace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 4b5997e18fad..731234b78c4c 1

Re: [PATCH v2 6/9] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]

2022-06-19 Thread Cédric Le Goater
On 6/18/22 13:01, Daniel Henrique Barboza wrote: pnv_ics_resend() is scrolling through all the child objects of the chip to search for the PHBs. It's faster and simpler to just use the phbs[] array. pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too simple to justify its own

Re: [PATCH v2 5/9] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array

2022-06-19 Thread Cédric Le Goater
On 6/18/22 13:01, Daniel Henrique Barboza wrote: The function is working today by getting all the child objects of the chip, interacting with each of them to check whether the child is a PHB, and then doing what needs to be done. We have all the chip PHBs in the phbs[] array so interacting with

Re: [PATCH 2/2] qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all

2022-06-19 Thread Idan Horowitz
On Wed, 26 Jan 2022 at 23:43, Richard Henderson wrote: > > Reviewed-by: Richard Henderson > > r~ Hey, I believe this patch might have accidentally been missed? Thanks, Idan Horowitz