Re: [PATCH] block/nvme: separate nvme_get_free_req cases for coroutine/non-coroutine context

2022-05-15 Thread Alberto Faria
On Sat, May 14, 2022 at 11:31 AM Paolo Bonzini wrote: > > nvme_get_free_req has very difference semantics when called in > coroutine context (when it waits) and in non-coroutine context > (when it doesn't). Split the two cases to make it clear what > is being requested. > > Cc: qemu-bl...@nongnu.

[PATCH v2 5/5] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Peter Delevoryas
Background: AspeedMachineClass.uart_default specifies the serial console UART, which usually corresponds to the "stdout-path" in the device tree. The default value is UART5, since most boards use UART5 for this: amc->uart_default = ASPEED_DEV_UART5; Users can override AspeedMachineClass.uar

[PATCH v2 2/5] hw: aspeed: Add uarts_num SoC attribute

2022-05-15 Thread Peter Delevoryas
AST2400 and AST2500 have 5 UART's, while the AST2600 and AST1030 have 13. Signed-off-by: Peter Delevoryas --- hw/arm/aspeed_ast10x0.c | 1 + hw/arm/aspeed_ast2600.c | 1 + hw/arm/aspeed_soc.c | 2 ++ include/hw/arm/aspeed_soc.h | 1 + 4 files changed, 5 insertions(+) diff --git

[PATCH v2 0/5] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Peter Delevoryas
v2: - Rebased on Cedric's irq proposal. [1] - Added "Introduce common UART init function" patch - Added "Add uarts_num SoC attribute" patch - Rewrote last commit's message for clarity I tried testing this by running acceptance tests, particularly the boot_linux_console.py file, but I had to disabl

[PATCH v2 3/5] hw: aspeed: Ensure AST1030 respects uart-default

2022-05-15 Thread Peter Delevoryas
The AST1030 machine initialization was not respecting the Aspeed SoC property "uart-default", which specifies which UART should be connected to the first serial device, it was just always connecting UART5. This doesn't change any behavior, because the default value for "uart-default" is UART5, but

[PATCH v2 1/5] hw: aspeed: Add missing UART's

2022-05-15 Thread Peter Delevoryas
This adds the missing UART memory and IRQ mappings for the AST2400, AST2500, AST2600, and AST1030. This also includes the new UART interfaces added in the AST2600 and AST1030 from UART6 to UART13. The addresses and interrupt numbers for these two later chips are identical. Signed-off-by: Peter De

[PATCH v2 4/5] hw: aspeed: Introduce common UART init function

2022-05-15 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/arm/aspeed_ast10x0.c | 7 ++- hw/arm/aspeed_ast2600.c | 7 ++- hw/arm/aspeed_soc.c | 16 include/hw/arm/aspeed_soc.h | 1 + 4 files changed, 17 insertions(+), 14 deletions(-) diff --git a/hw/arm/aspeed_ast10x0.c b

Re: [PATCH v2] aspeed: Introduce a get_irq AspeedSoCClass method

2022-05-15 Thread Peter Delevoryas
> On May 15, 2022, at 10:56 PM, Cédric Le Goater wrote: > > and make routine aspeed_soc_get_irq() common to all SoCs. This will be > useful to share code. Looks good, I just tested that I could rebase my changes on it and recompile/etc. Reviewed-by: Peter Delevoryas > > Cc: Jamin Lin > C

Re: [PATCH] aspeed: Introduce a get_irq AspeedSoCClass method

2022-05-15 Thread Cédric Le Goater
On 5/16/22 01:01, Peter Delevoryas wrote: On May 15, 2022, at 2:10 PM, Cédric Le Goater wrote: and make routine aspeed_soc_get_irq() common to all SoCs. This will be useful to share code. Cc: Jamin Lin Cc: Peter Delevoryas Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h |

Re: [PATCH v2 03/15] tests: make libqmp buildable for win32

2022-05-15 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, May 5, 2022 at 2:52 PM Markus Armbruster wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Signed-off-by: Marc-André Lureau >> > Reviewed-by: Thomas Huth >> > --- >> > tests/qtest/libqmp.h | 2 ++ >> > tests

[PATCH v2] aspeed: Introduce a get_irq AspeedSoCClass method

2022-05-15 Thread Cédric Le Goater
and make routine aspeed_soc_get_irq() common to all SoCs. This will be useful to share code. Cc: Jamin Lin Cc: Peter Delevoryas Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 3 +++ hw/arm/aspeed_ast10x0.c | 5 +++-- hw/arm/aspeed_ast2600.c | 5 +++-- hw/arm/aspee

Re: [PATCH] qapi/pragma: Tidy up comments

2022-05-15 Thread Markus Armbruster
Markus Armbruster writes: > Commit 05ebf841ef "qapi: Enforce command naming rules" inserted new > code between a comment and the code it applies to. Move the comment > back to its code, and add one for the new code. > > Signed-off-by: Markus Armbruster Queued.

Re: [PATCH 0/2] qapi: Minor fixes around feature names

2022-05-15 Thread Markus Armbruster
Queued.

Re: [PATCH v2 0/8] qapi: Primarily whitespace tweaks

2022-05-15 Thread Markus Armbruster
Andrea Bolognani writes: > If patch 8/8 is accepted, 7/8 should be squashed into it to reduce > churn. Done & queued. Thanks!

Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments

2022-05-15 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On Tue, May 03, 2022 at 09:37:37AM +0200, Andrea Bolognani wrote: >>> Perfectly aligned things look pretty, but keeping them that >>> way as the schema evolves requires churn, and in some cases >>> newly-added lines are not aligned properly. >>

[PATCH 1/2] target/riscv: check 'I' and 'E' after checking 'G' in riscv_cpu_realize

2022-05-15 Thread Weiwei Li
- setting ext_g will implicitly set ext_i Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- slirp | 2 +- target/riscv/cpu.c | 23 --- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp b/slirp index 9d59bb775d..a88d9ace23 16 --

[PATCH 2/2] target/riscv: disable zb* extensions by default

2022-05-15 Thread Weiwei Li
- enable zb* extensions by default will make cpu types(such as sifive-u34) implicitly support zb* extensions Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/ris

Re: [PATCH v2 5/5] target/riscv: Move/refactor ISA extension checks

2022-05-15 Thread Weiwei Li
在 2022/5/15 上午10:56, Tsukasa OI 写道: We should separate "check" and "configure" steps as possible. This commit separates both steps except vector/Zfinx-related checks. Signed-off-by: Tsukasa OI --- target/riscv/cpu.c | 31 --- 1 file changed, 16 insertions(+), 15

Re: CPUs supported by the sbsa-ref board

2022-05-15 Thread Itaru Kitayama
With the latest, manually built TF-A, I was able to boot a72, but not max. Since `max` type is supported by TF-A, I think it might be a Qemu issue. On Mon, May 16, 2022 at 8:21 AM Itaru Kitayama wrote: > > Leif, > > I've so far only booted sbsa-ref with cortex-a57, is this only CPU > type support

Re: [PULL 0/4] OpenRISC fixes for QEMU 2022-05-15

2022-05-15 Thread Stafford Horne
u into > > staging (2022-05-03 09:13:17 -0700) > > > > are available in the Git repository at: > > > >https://github.com/stffrdhrn/qemu.git tags/or1k-pull-request-20220515 > > > > for you to fetch changes up to e8f0ab0cd674241cbab7231ce05ac1bfa0b4f5

CPUs supported by the sbsa-ref board

2022-05-15 Thread Itaru Kitayama
Leif, I've so far only booted sbsa-ref with cortex-a57, is this only CPU type supported by the board? I'm using TF-A's latest branch, but the PLAT=qemu_sbsa is at this moment, kind of outdated. Itaru.

Re: [PULL 0/4] OpenRISC fixes for QEMU 2022-05-15

2022-05-15 Thread Richard Henderson
github.com/stffrdhrn/qemu.git tags/or1k-pull-request-20220515 for you to fetch changes up to e8f0ab0cd674241cbab7231ce05ac1bfa0b4f5ed: target/openrisc: Do not reset delay slot flag on early tb exit (2022-05-15 10:33:01 +0900) Open

Re: [PATCH] aspeed: Introduce a get_irq AspeedSoCClass method

2022-05-15 Thread Peter Delevoryas
> On May 15, 2022, at 2:10 PM, Cédric Le Goater wrote: > > and make routine aspeed_soc_get_irq() common to all SoCs. This will be > useful to share code. > > Cc: Jamin Lin > Cc: Peter Delevoryas > Signed-off-by: Cédric Le Goater > --- > include/hw/arm/aspeed_soc.h | 3 +++ > hw/arm/aspeed_as

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Peter Delevoryas
> On May 15, 2022, at 2:19 PM, Cédric Le Goater wrote: > > [ ... ] > >>> The problem is that it is breaking compatibility with previous QEMUs. >> It is? We can still run things the old way too, I specifically >> wrote this with the intention that it would support backwards >> compatibility. >

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-15 Thread Cédric Le Goater
[ ... ] The problem is that it is breaking compatibility with previous QEMUs. It is? We can still run things the old way too, I specifically wrote this with the intention that it would support backwards compatibility. You are right. Let's start with your patchset. We can add the "uart" machi

[PATCH] aspeed: Introduce a get_irq AspeedSoCClass method

2022-05-15 Thread Cédric Le Goater
and make routine aspeed_soc_get_irq() common to all SoCs. This will be useful to share code. Cc: Jamin Lin Cc: Peter Delevoryas Signed-off-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 3 +++ hw/arm/aspeed_ast10x0.c | 3 ++- hw/arm/aspeed_ast2600.c | 3 ++- hw/arm/aspeed_so

Re: [PATCH v2 4/5] target/riscv: FP extension requirements

2022-05-15 Thread Weiwei Li
在 2022/5/15 下午10:45, Tsukasa OI 写道: On 2022/05/15 23:37, Weiwei Li wrote: 在 2022/5/15 上午10:56, Tsukasa OI 写道: QEMU allowed inconsistent configurations that made floating point arithmetic effectively unusable. This commit adds certain checks for consistent FP arithmetic: -   F requires Zicsr

Re: [PATCH v2 4/5] target/riscv: FP extension requirements

2022-05-15 Thread Tsukasa OI
On 2022/05/15 23:37, Weiwei Li wrote: > > 在 2022/5/15 上午10:56, Tsukasa OI 写道: >> QEMU allowed inconsistent configurations that made floating point >> arithmetic effectively unusable. >> >> This commit adds certain checks for consistent FP arithmetic: >> >> -   F requires Zicsr >> -   Zfinx require

Re: [PATCH v2 4/5] target/riscv: FP extension requirements

2022-05-15 Thread Weiwei Li
在 2022/5/15 上午10:56, Tsukasa OI 写道: QEMU allowed inconsistent configurations that made floating point arithmetic effectively unusable. This commit adds certain checks for consistent FP arithmetic: - F requires Zicsr - Zfinx requires Zicsr - Zfh/Zfhmin require F - D requires F - V re

[PATCH v3] qga: add guest-get-diskstats command for Linux guests

2022-05-15 Thread luzhipeng
Add a new 'guest-get-diskstats' command for report disk io statistics for Linux guests. This can be usefull for getting io flow or handling IO fault, no need to enter guests. Signed-off-by: luzhipeng --- Changes v2->v3: bugfix for memory leak Changes v1->v2: v1:https://patchew.org/QEMU/20220512

QEMU 6.2.0: Segfault while calling address_space_init from emulated device

2022-05-15 Thread Karthik Poduval
Hi All, I am trying to create a virtual mem2mem scaler device in QEMU (for the purposes of writing a mem2mem driver tutorial). I created the mem2mem device as shown here. https://github.com/karthikpoduval/qemu/blob/scaler-bringup/hw/misc/m2m_scaler.c I added this MMIO device to the arm virt.c (as