Re: [PATCH] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

2022-03-10 Thread Alistair Francis
On Fri, Mar 11, 2022 at 2:58 PM Weiwei Li wrote: > > > 在 2022/3/11 上午10:58, Alistair Francis 写道: > > On Wed, Mar 2, 2022 at 11:50 PM Weiwei Li wrote: > >> For csrrs and csrrc, if rs1 specifies a register other than x0, > >> holding > >> a zero value, the instruction will still attemp

[PATCH] tcg/arm: Don't emit UNPREDICTABLE LDRD with Rm == Rt or Rt+1

2022-03-10 Thread Richard Henderson
The LDRD (register) instruction is UNPREDICTABLE if the Rm register is the same as either Rt or Rt+1 (the two registers being loaded to). We weren't making sure we avoided this, with the result that on some host CPUs like the Cortex-A7 we would get a SIGILL because the CPU chooses to UNDEF for this

Re: [RFC PATCH] hw/i386/e820: remove legacy reserved entries for e820

2022-03-10 Thread Ani Sinha
On Thu, Mar 10, 2022 at 10:12 PM Igor Mammedov wrote: > > On Thu, 10 Mar 2022 11:51:37 +0530 > Ani Sinha wrote: > > > On Mon, Feb 28, 2022 at 8:56 PM Ani Sinha wrote: > > > > > > e820 reserved entries were used before the dynamic entries with fw config > > > files > > > were intoduced into qemu

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

2022-03-10 Thread Cédric Le Goater
On 3/11/22 08:45, Thomas Huth wrote: On 11/03/2022 08.43, Cédric Le Goater wrote: Xive2EndSource objects can only be instantiated through a Xive2Router (PnvXive2). Suggested-by: Thomas Huth Signed-off-by: Cédric Le Goater ---   hw/intc/xive2.c | 1 +   1 file changed, 1 insertion(+) diff --gi

Re: [PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

2022-03-10 Thread Thomas Huth
On 11/03/2022 08.43, Cédric Le Goater wrote: Xive2EndSource objects can only be instantiated through a Xive2Router (PnvXive2). Suggested-by: Thomas Huth Signed-off-by: Cédric Le Goater --- hw/intc/xive2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c

[PATCH] ppc/xive2: Make type Xive2EndSource not user creatable

2022-03-10 Thread Cédric Le Goater
Xive2EndSource objects can only be instantiated through a Xive2Router (PnvXive2). Suggested-by: Thomas Huth Signed-off-by: Cédric Le Goater --- hw/intc/xive2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c index b6452f14784b..3aff42a69ef5 100644 --- a/hw/

Re: [PATCH v4 01/18] ppc/xive2: Introduce a XIVE2 core framework

2022-03-10 Thread Cédric Le Goater
+static const TypeInfo xive2_end_source_info = { +    .name  = TYPE_XIVE2_END_SOURCE, +    .parent    = TYPE_DEVICE, +    .instance_size = sizeof(Xive2EndSource), +    .class_init    = xive2_end_source_class_init, +}; This device can be used to crash QEMU: $ ./qemu-system-ppc64 -nog

Re: [PATCH v8 09/14] target/riscv: rvk: add support for sha512 related instructions for RV32 in zknh extension

2022-03-10 Thread Alistair Francis
On Tue, Mar 1, 2022 at 10:01 PM Weiwei Li wrote: > > - add sha512sum0r, sha512sig0l, sha512sum1r, sha512sig1l, sha512sig0h and > sha512sig1h instructions > > Co-authored-by: Zewen Ye > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- >

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

2022-03-10 Thread Erik Skultety
On Wed, Mar 09, 2022 at 12:47:26PM +0530, Ani Sinha wrote: > > > On Tue, 8 Mar 2022, Michael S. Tsirkin wrote: > > > On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > > > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Mar 08, 2022 at 10:15:11

Re: [PATCH v4 07/18] ppc/pnv: Add a HOMER model to POWER10

2022-03-10 Thread Cédric Le Goater
On 3/11/22 07:05, Alexey Kardashevskiy wrote: What is that HOMER thing anyway? I don't remember what the acronym stands for, I think "HOst MEmory Region". Vaidy or Mahesh could tell. skiboot and qemu mention it a lot but I cannot find traces in any available spec. It is really deep deep un

Re: [PATCH v8 08/14] target/riscv: rvk: add support for sha256 related instructions in zknh extension

2022-03-10 Thread Alistair Francis
On Tue, Mar 1, 2022 at 10:09 PM Weiwei Li wrote: > > - add sha256sig0, sha256sig1, sha256sum0 and sha256sum1 instructions > > Co-authored-by: Zewen Ye > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 2/3] tcg/s390x: Fix INDEX_op_bitsel_vec vs VSEL

2022-03-10 Thread Thomas Huth
On 10/03/2022 21.27, Richard Henderson wrote: The operands are output in the wrong order: the tcg selector argument is first, whereas the s390x selector argument is last. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/898 Fixes: 9bca986df88 ("tcg/s390x: Implement TCG_TARGET_HAS_bitsel_v

Re: [PATCH v4 07/18] ppc/pnv: Add a HOMER model to POWER10

2022-03-10 Thread Alexey Kardashevskiy
What is that HOMER thing anyway? skiboot and qemu mention it a lot but I cannot find traces in any available spec. On 3/1/22 02:52, Cédric Le Goater wrote: Reviewed-by: David Gibson Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv.h | 10 ++ include/hw/ppc/pnv_homer.h | 3

[PATCH v2 11/11] MAINTAINERS: take edk2

2022-03-10 Thread Gerd Hoffmann
Cc: Philippe Mathieu-Daudé Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 68adaac373c7..ad1c9a7ea133 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3144,7 +3144,

[PATCH v2 10/11] edk2/docker: use ubuntu 18.04

2022-03-10 Thread Gerd Hoffmann
Upstream CI uses ubuntu 18.04 too, so pick that version (instead of something newer). Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée --- .gitlab-ci.d/edk2/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/edk2/Dockerfile b/.gitlab-ci.d/edk2/Docke

[PATCH v2 08/11] tests/acpi: disallow virt memory hotplug changes

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index e569098abddc..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

[PATCH v2 07/11] tests/acpi: update expected data files

2022-03-10 Thread Gerd Hoffmann
The switch to edk2 RELEASE builds changes the memory layout a bit, resulting in a acpi table change. DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) { Scope (\_SB) { Device (NVDR) { Name (_HID, "ACPI0012" /* NVDIMM Root Device */) // _HID

[PATCH v2 09/11] edk2/docker: install python3

2022-03-10 Thread Gerd Hoffmann
python2 is not supported any more, so go install python3 instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée --- .gitlab-ci.d/edk2/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/edk2/Dockerfile b/.gitlab-ci.d/edk2/Dockerfile index 13029310

[PATCH v2 04/11] edk2: .git can be a file

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile.edk2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2 index 3d75a842a4df..6801ea62e8f1 100644 --- a/roms/Makefile.edk2 +++ b/roms/Makefile.edk2 @@ -51,7 +51,7 @@ all: $(foreach flashdev,$(fl

[PATCH v2 02/11] edk2: update submodule to stable202202

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée --- roms/edk2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/edk2 b/roms/edk2 index 06dc822d045c..b24306f15daa 16 --- a/roms/edk2 +++ b/roms/edk2 @@ -1 +1 @@ -Subproject commit 06dc822d045c2bb42e49748793548530248

[PATCH v2 05/11] edk2: add microvm build

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- roms/Makefile.edk2 | 11 +++ 1 file changed, 11 insertions(+) diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2 index 6801ea62e8f1..485f2244b159 100644 --- a/roms/Makefile.edk2 +++ b/roms/Makefile.edk2 @@ -33,6 +33,

[PATCH v2 03/11] edk2: switch to release builds

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée --- roms/Makefile.edk2 | 17 + roms/edk2-build.sh | 2 +- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/roms/Makefile.edk2 b/roms/Makefile.edk2 index fdae0b511f59..3d75a8

[PATCH v2 00/11] edk2: update to stable202202

2022-03-10 Thread Gerd Hoffmann
While being at it switch to RELEASE builds, which in turn needs acpi test data updates. Add microvm build. Update MAINTAINERS. Some build/ci tweaks. Also available here: https://gitlab.com/kraxel/qemu/-/commits/edk2 v2: - tweaked .git check - updated acpi table commit messages. - picked up

[PATCH v2 01/11] tests/acpi: allow virt memory hotplug changes

2022-03-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Alex Bennée --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..e569098abddc 100644 --- a/tests

Re: [PATCH] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

2022-03-10 Thread Weiwei Li
在 2022/3/11 上午10:58, Alistair Francis 写道: On Wed, Mar 2, 2022 at 11:50 PM Weiwei Li wrote: For csrrs and csrrc, if rs1 specifies a register other than x0, holding a zero value, the instruction will still attempt to write the unmodified value back to the csr and will cause si

Re: [PULL V2 00/15] Net patches

2022-03-10 Thread Jason Wang
On Fri, Mar 11, 2022 at 1:07 AM Peter Maydell wrote: > On Thu, 10 Mar 2022 at 02:39, Jason Wang wrote: > > > > The following changes since commit > d9ccf33f9479201e5add8db0af68ca9ca8da358b: > > > > Merge remote-tracking branch > 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' int

Re: [PATCH v8 04/14] target/riscv: rvk: add support for zbkx extension

2022-03-10 Thread Alistair Francis
On Tue, Mar 1, 2022 at 10:06 PM Weiwei Li wrote: > > - add xperm4 and xperm8 instructions > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Acked-by: Alistair Francis Alistair > --- > target/riscv/bitmanip_helper.c | 27 +

Re: [PATCH v3 1/4] target/ppc: Fix masked PVR matching

2022-03-10 Thread Alexey Kardashevskiy
On 3/7/22 17:55, Nicholas Piggin wrote: The pvr_match for a CPU class is not supposed to just match for any CPU in the family, but rather whether this particular CPU class is the best match in the family. Prior to this fix, e.g., a POWER9 DD2.3 KVM host matches to the power9_v1.0 class (becau

Re: [PATCH] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

2022-03-10 Thread Alistair Francis
On Wed, Mar 2, 2022 at 11:50 PM Weiwei Li wrote: > > For csrrs and csrrc, if rs1 specifies a register other than x0, holding > a zero value, the instruction will still attempt to write the unmodified > value back to the csr and will cause side effects > > Signed-off-by: Weiwei Li >

Re: [PATCH v8 07/14] target/riscv: rvk: add support for zkne/zknd extension in RV64

2022-03-10 Thread Alistair Francis
On Tue, Mar 1, 2022 at 10:03 PM Weiwei Li wrote: > > - add aes64dsm, aes64ds, aes64im, aes64es, aes64esm, aes64ks2, aes64ks1i > instructions > > Co-authored-by: Ruibo Lu > Co-authored-by: Zewen Ye > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Ac

Re: [PATCH v8 06/14] target/riscv: rvk: add support for zknd/zkne extension in RV32

2022-03-10 Thread Alistair Francis
On Tue, Mar 1, 2022 at 10:08 PM Weiwei Li wrote: > > - add aes32esmi, aes32esi, aes32dsmi and aes32dsi instructions > > Co-authored-by: Zewen Ye > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > targe

Re: QEMU device refcounting when device creates a container MR

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 01:45:31PM +, Peter Maydell wrote: > The other theory I had was "maybe if you put an MR into another > MR and they both have the same owner then don't bump the refcount" > but I haven't thought that through at all. Maybe it'll work, it just sounds a bit more tricky. >

Re: [PATCH v5 0/5] user creatable pnv-phb4 devices

2022-03-10 Thread Daniel Henrique Barboza
On 3/10/22 15:49, Thomas Huth wrote: On 11/01/2022 14.10, Daniel Henrique Barboza wrote: Hi, This version implements Cedric's review suggestions from v4. No drastic design changes were made. Changes from v4: - patches 1,3,5: unchanged - patch 2:    * renamed function to pnv_phb4_xscom_reali

Re: [RFC PATCH v6 00/29] Add LoongArch softmmu support

2022-03-10 Thread yangxiaojuan
Ping !!! On 2022/2/25 下午4:02, Xiaojuan Yang wrote: This series patch add softmmu support for LoongArch. The latest kernel: * https://github.com/loongson/linux/tree/loongarch-next The latest uefi: * https://github.com/loongson/edk2 * https://github.com/loongson/edk2-platforms The manual:

Re: [PATCH v2 00/18] tests: introduce testing coverage for TLS with migration

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:03PM +, Daniel P. Berrangé wrote: > This significantly expands the migration test suite to cover testing > with TLS over TCP and UNIX sockets, with both PSK (pre shared keys) > and x509 credentials, and for both single and multifd scenarios. > > It identified one

Re: [PATCH v2 10/18] tests: switch migration FD passing test to use common precopy helper

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:13PM +, Daniel P. Berrangé wrote: > The combination of the start and finish hooks allow the FD passing > code to use the precopy helper > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v2 08/18] tests: merge code for UNIX and TCP migration pre-copy tests

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:11PM +, Daniel P. Berrangé wrote: > The test cases differ only in the URI they provide to the migration > commands, and the ability to set the dirty_ring mode. This code is > trivially merged into a common helper. > > Signed-off-by: Daniel P. Berrangé Reviewed-b

Re: [PATCH v2 11/18] tests: expand the migration precopy helper to support failures

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:14PM +, Daniel P. Berrangé wrote: > The migration precopy testing helper function always expects the > migration to run to a completion state. There will be test scenarios > for TLS where expect either the client or server to fail the migration. > This expands the

Re: [PATCH v2 14/18] tests: convert XBZRLE migration test to use common helper

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:17PM +, Daniel P. Berrangé wrote: > Most of the XBZRLE migration test logic is common with the rest of the > precopy tests, so it can use the helper with just one small tweak. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v2 15/18] tests: convert multifd migration tests to use common helper

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:18PM +, Daniel P. Berrangé wrote: > Most of the multifd migration test logic is common with the rest of the > precopy tests, so it can use the helper without difficulty. The only > exception of the multifd cancellation test which tries to run multiple > migrations

Re: [PATCH v2 09/18] tests: introduce ability to provide hooks for migration precopy test

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:12PM +, Daniel P. Berrangé wrote: > There are alot of different scenarios to test with migration due to the > wide number of parameters and capabilities available. To enable sharing > of the basic precopy test scenario, we need to be able to set arbitrary > paramet

Re: [PATCH v2 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:07PM +, Daniel P. Berrangé wrote: > The QMP commands have a trailing newline, but the response does not. > This makes the qtest logs hard to follow as the next QMP command > appears in the same line as the previous QMP response. > > Reviewed-by: Thomas Huth > Sig

Re: [PATCH v2 07/18] tests: switch MigrateStart struct to be stack allocated

2022-03-10 Thread Peter Xu
On Thu, Mar 10, 2022 at 05:18:10PM +, Daniel P. Berrangé wrote: > There's no compelling reason why the MigrateStart struct needs to be > heap allocated. Using stack allocation and static initializers is > simpler. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH] target/ppc: fix xxspltw for big endian hosts

2022-03-10 Thread Richard Henderson
On 3/10/22 09:20, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Fix a typo in the host endianness macro and add a simple test to detect regressions. Fixes: 9bb0048ec6f8 ("target/ppc: convert xxspltw to vector operations") Signed-off-by: Matheus Ferst --- target/ppc/translate/vsx-im

Re: [PATCH v4] target/riscv: Add isa extenstion strings to the device tree

2022-03-10 Thread Frank Chang
On Fri, Mar 11, 2022 at 2:42 AM Atish Kumar Patra wrote: > On Wed, Mar 9, 2022 at 5:47 AM Frank Chang wrote: > > > > Atish Patra 於 2022年3月9日 週三 上午8:53寫道: > >> > >> The Linux kernel parses the ISA extensions from "riscv,isa" DT > >> property. It used to parse only the single letter base extensio

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

2022-03-10 Thread Daniel Henrique Barboza
On 3/10/22 16:51, Fabiano Rosas wrote: Fabiano Rosas writes: QEMU reports MMU support to the guest via the ibm,architecture-vec-5 property of the /chosen node. Byte number 26 specifies Radix Table Expansions, currently only GTSE (Guest Translation Shootdown Enable). This feature determines

Re: [PATCH 0/9] --disable-tcg avocado fixes for ppc-softmmu

2022-03-10 Thread Murilo Opsfelder Araújo
On 3/10/22 15:30, Daniel Henrique Barboza wrote: Hi, These are more test fixes that I missed from my first series [1]. Thanks Murilo Opsfelder and Fabiano for letting me know that we still had broken tests to deal with. All these tests were either a case of 'this needs kvm_pr' or 'this needs kv

Re: [PATCH v5 03/13] mm/shmem: Support memfile_notifier

2022-03-10 Thread Dave Chinner
On Thu, Mar 10, 2022 at 10:09:01PM +0800, Chao Peng wrote: > From: "Kirill A. Shutemov" > > It maintains a memfile_notifier list in shmem_inode_info structure and > implements memfile_pfn_ops callbacks defined by memfile_notifier. It > then exposes them to memfile_notifier via > shmem_get_memfile

Re: [PATCH 8/9] avocado/ppc_prep_40p.py: check TCG accel in all tests

2022-03-10 Thread Philippe Mathieu-Daudé
On 10/3/22 19:30, Daniel Henrique Barboza wrote: All tests in the file times out when running in an IBM POWER host and --disable-tcg with an error like the following: Command: ./qemu-system-ppc -display none -vga none (...) -machine 40p (...) Output: qemu-system-ppc: Register s

Re: [PATCH-for-7.0] linux-user: Fix missing space in error message

2022-03-10 Thread Philippe Mathieu-Daudé
On 10/3/22 20:21, Patrick Venture wrote: From: Fergus Henderson Signed-off-by: Fergus Henderson Signed-off-by: Patrick Venture --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9628a38361..c45da4d6

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

2022-03-10 Thread Alex Williamson
On Thu, 10 Mar 2022 14:55:50 -0500 Steven Sistare wrote: > On 3/10/2022 1:35 PM, Alex Williamson wrote: > > On Thu, 10 Mar 2022 10:00:29 -0500 > > Steven Sistare wrote: > > > >> On 3/7/2022 5:16 PM, Alex Williamson wrote: > >>> On Wed, 22 Dec 2021 11:05:24 -0800 > >>> Steve Sistare wrote:

Re: [PATCH-for-7.0] softmmu: List CPU types again

2022-03-10 Thread Max Filippov
On Thu, Mar 10, 2022 at 3:55 AM Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daudé > > Commit e0220bb5b2 made cpus.c target-agnostic but didn't notice > the cpu_list() function is only defined in target-specific code > in "cpu.h". Extract list_cpus() from the generic cpus.c into a > n

Re: [PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-10 Thread Daniel Henrique Barboza
On 3/10/22 17:05, Murilo Opsfelder Araujo wrote: Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user ... $ make -j

Re: [PATCH] linux-user: Fix missing space in error message

2022-03-10 Thread Peter Maydell
On Thu, 10 Mar 2022 at 19:29, Patrick Venture wrote: > > From: Fergus Henderson > > Signed-off-by: Fergus Henderson > Signed-off-by: Patrick Venture > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 2/3] tcg/s390x: Fix INDEX_op_bitsel_vec vs VSEL

2022-03-10 Thread Richard Henderson
The operands are output in the wrong order: the tcg selector argument is first, whereas the s390x selector argument is last. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/898 Fixes: 9bca986df88 ("tcg/s390x: Implement TCG_TARGET_HAS_bitsel_vec") Signed-off-by: Richard Henderson --- tcg/

[PATCH 1/3] tcg/s390x: Fix tcg_out_dupi_vec vs VGM

2022-03-10 Thread Richard Henderson
The immediate operands to VGM were in the wrong order, producing an inverse mask. Signed-off-by: Richard Henderson --- tcg/s390x/tcg-target.c.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/s390x/tcg-target.c.inc b/tcg/s390x/tcg-target.c.inc index 6e65828c09..508f

[PATCH 3/3] tcg/s390x: Fix tcg_out_dup_vec vs general registers

2022-03-10 Thread Richard Henderson
We copied the data from the general register input to the vector register output, but have not yet replicated it. We intended to fall through into the vector-vector case, but failed to redirect the input register. This is caught by an assertion failure in tcg_out_insn_VRIc, which diagnosed the inc

[PATCH 0/3] tcg/s390x vector fixes

2022-03-10 Thread Richard Henderson
These 3 issues were found by running risu on arm neon test cases. In the meantime, Thomas encountered one of the same with the new tests of vectorized sha512. r~ Richard Henderson (3): tcg/s390x: Fix tcg_out_dupi_vec vs VGM tcg/s390x: Fix INDEX_op_bitsel_vec vs VSEL tcg/s390x: Fix tcg_out

Re: [PULL 00/12] Hexagon (target/hexagon) queue

2022-03-10 Thread Alex Bennée
Taylor Simpson writes: > My apologies. I'll investigate the mismatch between the toolchain I'm > using and the one CI is using. I don't recall seeing a new binary docker since the previous one had ABI issues with signal handling. -- Alex Bennée

Re: [PATCH experiment 00/35] stackless coroutine backend

2022-03-10 Thread Paolo Bonzini
On 3/10/22 18:42, Stefan Hajnoczi wrote: There are a lot of details to decide on in the translator tool and runtime to optimize the code. I think the way the stack frames are organized in this patch series is probably for convenience rather than performance. Yes, sometimes the optimizations are

[PATCH] block-qdict: Fix -Werror=maybe-uninitialized build failure

2022-03-10 Thread Murilo Opsfelder Araujo
Building QEMU on Fedora 37 (Rawhide Prerelease) ppc64le failed with the following error: $ ../configure --prefix=/usr/local/qemu-disabletcg --target-list=ppc-softmmu,ppc64-softmmu --disable-tcg --disable-linux-user ... $ make -j$(nproc) ... FAILED: libqemuutil.a.p/qobject_bloc

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

2022-03-10 Thread Steven Sistare
On 3/10/2022 1:35 PM, Alex Williamson wrote: > On Thu, 10 Mar 2022 10:00:29 -0500 > Steven Sistare wrote: > >> On 3/7/2022 5:16 PM, Alex Williamson wrote: >>> On Wed, 22 Dec 2021 11:05:24 -0800 >>> Steve Sistare wrote: @@ -1878,6 +1908,18 @@ static int vfio_init_container(VFIOContainer >>>

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

2022-03-10 Thread Fabiano Rosas
Fabiano Rosas writes: > QEMU reports MMU support to the guest via the ibm,architecture-vec-5 > property of the /chosen node. Byte number 26 specifies Radix Table > Expansions, currently only GTSE (Guest Translation Shootdown > Enable). This feature determines whether the tlbie instruction (and >

[PATCH] linux-user: Fix missing space in error message

2022-03-10 Thread Patrick Venture
From: Fergus Henderson Signed-off-by: Fergus Henderson Signed-off-by: Patrick Venture --- linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 9628a38361..c45da4d633 100644 --- a/linux-user/elfload.c +++ b/li

Re: [PATCH v5 0/5] user creatable pnv-phb4 devices

2022-03-10 Thread Thomas Huth
On 11/01/2022 14.10, Daniel Henrique Barboza wrote: Hi, This version implements Cedric's review suggestions from v4. No drastic design changes were made. Changes from v4: - patches 1,3,5: unchanged - patch 2: * renamed function to pnv_phb4_xscom_realize() * pnv4_phb4_xscom_realize() is no

Re: [PATCH v5 11/48] target/nios2: Do not zero the general registers on reset

2022-03-10 Thread Richard Henderson
On 3/10/22 04:21, Peter Maydell wrote: On Thu, 10 Mar 2022 at 11:27, Richard Henderson wrote: The bulk of the general register set is undefined on reset. They might be architecturally undefined, but for QEMU's purposes we want the state of the CPU on reset to be identical to the state it is

Re: [PATCH v4] target/riscv: Add isa extenstion strings to the device tree

2022-03-10 Thread Atish Kumar Patra
On Wed, Mar 9, 2022 at 5:47 AM Frank Chang wrote: > > Atish Patra 於 2022年3月9日 週三 上午8:53寫道: >> >> The Linux kernel parses the ISA extensions from "riscv,isa" DT >> property. It used to parse only the single letter base extensions >> until now. A generic ISA extension parsing framework was proposed

Re: [PATCH V7 19/29] vfio-pci: cpr part 1 (fd and dma)

2022-03-10 Thread Alex Williamson
On Thu, 10 Mar 2022 10:00:29 -0500 Steven Sistare wrote: > On 3/7/2022 5:16 PM, Alex Williamson wrote: > > On Wed, 22 Dec 2021 11:05:24 -0800 > > Steve Sistare wrote: > >> @@ -1878,6 +1908,18 @@ static int vfio_init_container(VFIOContainer > >> *container, int group_fd, > >> { > >> int io

[PATCH 3/9] avocado/ppc_405.py: remove test_ppc_taihu()

2022-03-10 Thread Daniel Henrique Barboza
Running this test gives us a deprecation warning telling that this machine type is no longer supported: Output: qemu-system-ppc: Machine type 'taihu' is deprecated: incomplete, use 'ref405ep' instead Moreover, this test fails to pass running in an IBM POWER host when building QEMU with --

[PATCH 9/9] avocado/ppc_virtex_ml507.py: check TCG accel in test_ppc_virtex_ml507()

2022-03-10 Thread Daniel Henrique Barboza
This test times out when running in an IBM POWER host and --disable-tcg. Signed-off-by: Daniel Henrique Barboza --- tests/avocado/ppc_virtex_ml507.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/ppc_virtex_ml507.py b/tests/avocado/ppc_virtex_ml507.py index a6912ee579..6b0

[PATCH 2/9] avocado/boot_linux_console.py: check TCG accel in test_ppc_mac99()

2022-03-10 Thread Daniel Henrique Barboza
This test breaks when run in an IBM POWER host with a QEMU compiled with --disable-tcg and the ppc-softmmu target in a similar manner as test_ppc_g3beige did. There's also an observation made about kvm_pr in the error message: Command: ./qemu-system-ppc -display none -vga none (...) -machine mac9

[PATCH 8/9] avocado/ppc_prep_40p.py: check TCG accel in all tests

2022-03-10 Thread Daniel Henrique Barboza
All tests in the file times out when running in an IBM POWER host and --disable-tcg with an error like the following: Command: ./qemu-system-ppc -display none -vga none (...) -machine 40p (...) Output: qemu-system-ppc: Register sync failed... If you're using kvm-hv.ko, only "-cpu h

[PATCH 6/9] avocado/ppc_bamboo.py: check TCG accel in test_ppc_bamboo()

2022-03-10 Thread Daniel Henrique Barboza
This tests times out in an IBM POWER host when compiled with --disable-tcg. Signed-off-by: Daniel Henrique Barboza --- tests/avocado/ppc_bamboo.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/ppc_bamboo.py b/tests/avocado/ppc_bamboo.py index 40629e3478..102ff252df 100644 -

[PATCH 1/9] avocado/boot_linux_console.py: check TCG accel in test_ppc_g3beige()

2022-03-10 Thread Daniel Henrique Barboza
This test breaks when run in an IBM POWER host with a QEMU compiled with --disable-tcg and the ppc-softmmu target. One thing to note is that the error message explictly mentions kvm_pr support: Command: ./qemu-system-ppc -display none -vga none (...) -machine g3beige (...) Output: ioctl(K

[PATCH 7/9] avocado/ppc_mpc8544ds.py: check TCG accel in test_ppc_mpc8544ds()

2022-03-10 Thread Daniel Henrique Barboza
This tests times out in an IBM POWER host when compiled with --disable-tcg. Signed-off-by: Daniel Henrique Barboza --- tests/avocado/ppc_mpc8544ds.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/avocado/ppc_mpc8544ds.py b/tests/avocado/ppc_mpc8544ds.py index 886f967b15..8d6a749201

[PATCH 5/9] avocado/ppc_74xx.py: check TCG accel for all tests

2022-03-10 Thread Daniel Henrique Barboza
All tests of this file, when running in an IBM POWER host and with --disable-tcg, fail in a similar manner: Command: ./qemu-system-ppc -display none -vga none (...) -cpu 7400 (...) Output: ioctl(KVM_CREATE_VM) failed: 22 Invalid argument PPC KVM module is not loaded. Try modprobe k

[PATCH 4/9] avocado/ppc_405.py: check TCG accel in test_ppc_ref405ep()

2022-03-10 Thread Daniel Henrique Barboza
Running this test without TCG support in an IBM POWER server results in the following error: Command: ./qemu-system-ppc -display none -vga none (...) -machine ref405ep (...) Output: qemu-system-ppc: Register sync failed... If you're using kvm-hv.ko, only "-cpu host" is possible qem

[PATCH 0/9] --disable-tcg avocado fixes for ppc-softmmu

2022-03-10 Thread Daniel Henrique Barboza
Hi, These are more test fixes that I missed from my first series [1]. Thanks Murilo Opsfelder and Fabiano for letting me know that we still had broken tests to deal with. All these tests were either a case of 'this needs kvm_pr' or 'this needs kvm_hv'. Since avocado doesn't have yet a way of dete

Re: [PATCH V7 10/29] machine: memfd-alloc option

2022-03-10 Thread Steven Sistare
On 3/10/2022 12:28 PM, Steven Sistare wrote: > On 3/10/2022 11:00 AM, Igor Mammedov wrote: >> On Thu, 10 Mar 2022 10:36:08 -0500 >> Steven Sistare wrote: >> >>> On 3/8/2022 2:20 AM, Igor Mammedov wrote: On Tue, 8 Mar 2022 01:50:11 -0500 "Michael S. Tsirkin" wrote: > On Mon,

Re: [PATCH v3] target/arm: Fix sve2 ldnt1 and stnt1

2022-03-10 Thread Peter Maydell
On Tue, 8 Mar 2022 at 11:56, Peter Maydell wrote: > > Anyway > Reviewed-by: Peter Maydell ...and applied to target-arm.next. -- PMM

Re: [PATCH v4 01/18] ppc/xive2: Introduce a XIVE2 core framework

2022-03-10 Thread Thomas Huth
On 28/02/2022 16.52, Cédric Le Goater wrote: The XIVE2 interrupt controller of the POWER10 processor as the same logic as on POWER9 but its SW interface has been largely reworked. The interrupt controller has a new register interface, different BARs, extra VSDs. These will be described when we ad

Re: [PATCH-for-6.2 0/2] hw/block/fdc: Fix CVE-2021-3507

2022-03-10 Thread Jon Maloy
On 3/10/22 12:14, Thomas Huth wrote: On 06/02/2022 20.19, Jon Maloy wrote: Trying again with correct email address. ///jon On 2/6/22 14:15, Jon Maloy wrote: On 1/27/22 15:14, Jon Maloy wrote: On 11/18/21 06:57, Philippe Mathieu-Daudé wrote: Trivial fix for CVE-2021-3507. Philippe Mathi

Re: [PATCH v5 14/48] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields

2022-03-10 Thread Richard Henderson
On 3/10/22 04:26, Peter Maydell wrote: +FIELD(CR_EXCEPTION, CAUSE, 2, 5) +FIELD(CR_EXCEPTION, ECCFTL, 31, 1) + Is this definitely the right bit for ECCFTL? The copy of the manual I have has "ECCFTL" as an extra bit to the left of bit 31 (!). I'm guessing that's a docs formatting error, though..

Re: [PATCH] tests/avocado: Cancel BootLinux tests in case there is no free port

2022-03-10 Thread Cleber Rosa
Thomas Huth writes: > The BootLinux tests are currently failing with an ugly python > stack trace on my RHEL8 system since they cannot get a free port > (likely due to the firewall settings on my system). Let's properly > check the return value of find_free_port() instead and cancel the > test

Re: [PATCH v3 1/4] target/ppc: Fix masked PVR matching

2022-03-10 Thread Cédric Le Goater
Hello Nick, On 3/7/22 07:55, Nicholas Piggin wrote: The pvr_match for a CPU class is not supposed to just match for any CPU in the family, but rather whether this particular CPU class is the best match in the family. Prior to this fix, e.g., a POWER9 DD2.3 KVM host matches to the power9_v1.0

Re: [PATCH experiment 00/35] stackless coroutine backend

2022-03-10 Thread Stefan Hajnoczi
On Thu, Mar 10, 2022 at 01:43:38PM +0100, Paolo Bonzini wrote: > Here is an experiment with using stackless coroutines in QEMU. It > only compiles enough code to run tests/unit/test-coroutine, but at > least it proves that it's possible to quickly test ideas in the > area of coroutine runtimes. A

Re: [PATCH V7 10/29] machine: memfd-alloc option

2022-03-10 Thread Steven Sistare
On 3/10/2022 11:00 AM, Igor Mammedov wrote: > On Thu, 10 Mar 2022 10:36:08 -0500 > Steven Sistare wrote: > >> On 3/8/2022 2:20 AM, Igor Mammedov wrote: >>> On Tue, 8 Mar 2022 01:50:11 -0500 >>> "Michael S. Tsirkin" wrote: >>> On Mon, Mar 07, 2022 at 09:41:44AM -0500, Steven Sistare wrote

Re: [PATCH-for-7.0] tulip: Assign default MAC address if not specified

2022-03-10 Thread Philippe Mathieu-Daudé
On 10/3/22 17:55, Helge Deller wrote: The MAC of the tulip card is stored in the EEPROM and at startup tulip_fill_eeprom() is called to initialize the EEPROM with the MAC address given on the command line, e.g.: -device tulip,mac=00:11:22:33:44:55 In case the mac address was not given on th

[PATCH] target/ppc: fix xxspltw for big endian hosts

2022-03-10 Thread matheus . ferst
From: Matheus Ferst Fix a typo in the host endianness macro and add a simple test to detect regressions. Fixes: 9bb0048ec6f8 ("target/ppc: convert xxspltw to vector operations") Signed-off-by: Matheus Ferst --- target/ppc/translate/vsx-impl.c.inc | 2 +- tests/tcg/ppc64/Makefile.target |

[PATCH v2 16/18] tests: add multifd migration tests of TLS with PSK credentials

2022-03-10 Thread Daniel P . Berrangé
This validates that we correctly handle multifd migration success and failure scenarios when using TLS with pre shared keys. Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-test.c | 60 +--- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git

[PATCH v2 04/18] tests: print newline after QMP response in qtest logs

2022-03-10 Thread Daniel P . Berrangé
The QMP commands have a trailing newline, but the response does not. This makes the qtest logs hard to follow as the next QMP command appears in the same line as the previous QMP response. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/qtest/libqtest.c | 5 - 1 file ch

[PATCH v2 18/18] tests: ensure migration status isn't reported as failed

2022-03-10 Thread Daniel P . Berrangé
Various methods in the migration test call 'query_migrate' to fetch the current status and then access a particular field. Almost all of these cases expect the migration to be in a non-failed state. In the case of 'wait_for_migration_pass' in particular, if the status is 'failed' then it will get i

[PATCH v2 07/18] tests: switch MigrateStart struct to be stack allocated

2022-03-10 Thread Daniel P . Berrangé
There's no compelling reason why the MigrateStart struct needs to be heap allocated. Using stack allocation and static initializers is simpler. Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-test.c | 134 +++ 1 file changed, 56 insertions(+), 78 delet

[PATCH v2 15/18] tests: convert multifd migration tests to use common helper

2022-03-10 Thread Daniel P . Berrangé
Most of the multifd migration test logic is common with the rest of the precopy tests, so it can use the helper without difficulty. The only exception of the multifd cancellation test which tries to run multiple migrations in a row. Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-tes

[PATCH v2 11/18] tests: expand the migration precopy helper to support failures

2022-03-10 Thread Daniel P . Berrangé
The migration precopy testing helper function always expects the migration to run to a completion state. There will be test scenarios for TLS where expect either the client or server to fail the migration. This expands the helper to cope with these scenarios. Signed-off-by: Daniel P. Berrangé ---

[PATCH v2 17/18] tests: add multifd migration tests of TLS with x509 credentials

2022-03-10 Thread Daniel P . Berrangé
This validates that we correctly handle multifd migration success and failure scenarios when using TLS with x509 certificates. There are quite a few different scenarios that matter in relation to hostname validation, but we skip a couple as we can assume that the non-multifd coverage applies to som

[PATCH v2 10/18] tests: switch migration FD passing test to use common precopy helper

2022-03-10 Thread Daniel P . Berrangé
The combination of the start and finish hooks allow the FD passing code to use the precopy helper Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-test.c | 57 +--- 1 file changed, 21 insertions(+), 36 deletions(-) diff --git a/tests/qtest/migration-te

[PATCH v2 13/18] tests: add migration tests of TLS with x509 credentials

2022-03-10 Thread Daniel P . Berrangé
This validates that we correctly handle migration success and failure scenarios when using TLS with x509 certificates. There are quite a few different scenarios that matter in relation to hostname validation. Signed-off-by: Daniel P. Berrangé --- meson.build | 1 + tests/qtest

[PATCH v2 14/18] tests: convert XBZRLE migration test to use common helper

2022-03-10 Thread Daniel P . Berrangé
Most of the XBZRLE migration test logic is common with the rest of the precopy tests, so it can use the helper with just one small tweak. Signed-off-by: Daniel P. Berrangé --- tests/qtest/migration-test.c | 67 ++-- 1 file changed, 25 insertions(+), 42 deletions(-

[PATCH v2 00/18] tests: introduce testing coverage for TLS with migration

2022-03-10 Thread Daniel P . Berrangé
This significantly expands the migration test suite to cover testing with TLS over TCP and UNIX sockets, with both PSK (pre shared keys) and x509 credentials, and for both single and multifd scenarios. It identified one bug in handling PSK credentials with UNIX sockets, but other than that everyth

  1   2   3   4   >