Re: [PATCH v1 0/4] HyperV: Synthetic Debugging device

2022-02-12 Thread Jon Doron
On 04/02/2022, Jon Doron wrote: Ping This patchset adds support for the synthetic debugging device. HyperV supports a special transport layer for the kernel debugger when running in HyperV. This patchset add supports for this device so you could have a setup fast windows kernel debugging. At

Re: [PULL 18/38] hw/arm/virt: Honor highmem setting when computing the memory map

2022-02-12 Thread Akihiko Odaki
On 2022/01/20 21:36, Peter Maydell wrote: From: Marc Zyngier Even when the VM is configured with highmem=off, the highest_gpa field includes devices that are above the 4GiB limit. Similarily, nothing seem to check that the memory is within the limit set by the highmem=off option. This leads to

[PATCH v2] target/arm: Support PSCI 1.1 and SMCCC 1.0

2022-02-12 Thread Akihiko Odaki
Support the latest PSCI on TCG and HVF. A 64-bit function called from AArch32 now returns NOT_SUPPORTED, which is necessary to adhere to SMC Calling Convention 1.0. It is still not compliant with SMCCC 1.3 since they do not implement mandatory functions. Signed-off-by: Akihiko Odaki --- hw/arm/b

[PATCH 6/6] Revert "ui: factor out qemu_console_set_display_gl_ctx()"

2022-02-12 Thread Akihiko Odaki
This reverts commit 4f4181499170dcf80182745b319607802ea32896. This eliminates the situation where a display is registered as a GL context provider but not as a listener. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 3 --- ui/console.c | 22 -- 2 files chan

[PATCH 2/6] Revert "console: save current scanout details"

2022-02-12 Thread Akihiko Odaki
This reverts commit ebced091854517f063c46ce8e522ebc45e9bccdf. This fixes the compatibility between egl-headless and displays using console_select, most importantly vnc. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 27 --- ui/console.c | 165 ++

[PATCH 4/6] Revert "ui: dispatch GL events to all listeners"

2022-02-12 Thread Akihiko Odaki
This reverts commit 7cc712e9862ffdbe4161dbdf3bbf41bcbe547472. Signed-off-by: Akihiko Odaki --- ui/console.c | 58 +++- 1 file changed, 16 insertions(+), 42 deletions(-) diff --git a/ui/console.c b/ui/console.c index 13c0d001c09..6f21007737e 100644

[PATCH 5/6] Revert "ui: associate GL context outside of display listener registration"

2022-02-12 Thread Akihiko Odaki
This reverts commit ac32b2fff127843355b4f7e7ac9f93dd4a395adf. Signed-off-by: Akihiko Odaki --- ui/console.c | 7 ++- ui/egl-headless.c | 1 - ui/gtk.c | 3 --- ui/sdl2.c | 3 --- ui/spice-display.c | 3 --- 5 files changed, 2 insertions(+), 15 deletions(-) diff --g

[PATCH 1/6] ui/dbus: Share one listener for a console

2022-02-12 Thread Akihiko Odaki
This fixes surface texture double free with multiple connections and out-of-sync display size with multiple displays. This also reduces resource usage a little and allows to remove code to support multiple listeners for OpenGL displays. Signed-off-by: Akihiko Odaki --- ui/dbus-console.c | 109

[PATCH 3/6] Revert "ui: split the GL context in a different object"

2022-02-12 Thread Akihiko Odaki
This reverts commit 5e79d516e8ac818d2a90aae9f787775055434ee9. Signed-off-by: Akihiko Odaki --- include/ui/console.h | 34 -- include/ui/egl-context.h | 6 +++--- include/ui/gtk.h | 11 +-- include/ui/sdl2.h | 7 +++ include

[PATCH 0/6] ui/dbus: Share one listener for a console

2022-02-12 Thread Akihiko Odaki
ui/dbus required to have multiple DisplayChangeListeners (possibly with OpenGL) for a console but that caused several problems: - It broke egl-headless, an unusual display which implements OpenGL rendering for non-OpenGL displays. The code to support multiple DisplayChangeListeners does not con

[PATCH] softmmu/qdev-monitor: Add virtio-gpu-gl aliases

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- softmmu/qdev-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 01f3834db57..a0df820b9de 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qdev-monitor.c @@ -83,6 +83,8 @@ static const QDevAlias qd

[PATCH] edid: Fix clock of Detailed Timing Descriptor

2022-02-12 Thread Akihiko Odaki
The clock field is 16-bits in EDID Detailed Timing Descriptor, but edid_desc_timing assumed it is 32-bit. Write the 16-bit value if it fits in 16-bit. Write DisplayID otherwise. Signed-off-by: Akihiko Odaki --- hw/display/edid-generate.c | 66 ++ 1 file change

[PATCH] ui/cocoa: Do not alert even without block devices

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01..271a2676026 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1715,11 +1715,6 @@ static void addRemovableDevicesMenuItems(void) currentDevice = qmp_quer

[PATCH] ui/cocoa: Fix the leak of qemu_console_get_label

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01..fdf52a7c2f7 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1680,7 +1680,10 @@ static void create_initial_menus(void) /* Returns a name for

[PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-12 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2fd74c46426..5aefb5b431a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c Core Audio framework backend M: Gerd Hoffmann R: Ch

[PATCH] target/arm: Support PSCI 1.1 and SMCCC 1.0

2022-02-12 Thread Akihiko Odaki
Support the latest PSCI on TCG and HVF. It has optional functions and none of them are implemented. Unimplemented functions now return NOT_SUPPORTED, which automatically makes TCG compliant to SMC Calling Convention 1.0. HVF had already complied to SMCCC 1.0 for the compatibility with Windows and

Re: [PULL 00/28] testing and plugin updates

2022-02-12 Thread Peter Maydell
On Wed, 9 Feb 2022 at 14:15, Alex Bennée wrote: > > The following changes since commit 0a301624c2f4ced3331ffd5bce85b4274fe132af: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20220208' into staging (2022-02-08 > 11:40:08 +) > > are available in the Git repositor

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread Bernhard Beschow
Am 12. Februar 2022 19:30:43 MEZ schrieb Peter Maydell : >On Sat, 12 Feb 2022 at 17:02, BALATON Zoltan wrote: >> >> On Sat, 12 Feb 2022, Peter Maydell wrote: >> > On Sat, 12 Feb 2022 at 13:42, BALATON Zoltan wrote: >> >> By the way the corresponding member in struct PIIXState in >> >> include/hw

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread BB
Am 12. Februar 2022 19:30:43 MEZ schrieb Peter Maydell : >On Sat, 12 Feb 2022 at 17:02, BALATON Zoltan wrote: >> >> On Sat, 12 Feb 2022, Peter Maydell wrote: >> > On Sat, 12 Feb 2022 at 13:42, BALATON Zoltan wrote: >> >> By the way the corresponding member in struct PIIXState in >> >> include

[PATCH] net/eth: Don't consider ESP to be an IPv6 option header

2022-02-12 Thread Thomas Jansen
The IPv6 option headers all have in common that they start with some common fields, in particular the type of the next header followed by the extention header length. This is used to traverse the list of the options. The ESP header does not follow that format, which can break the IPv6 option header

Re: [RFC PATCH 14/25] virtio-snd: Add VIRTIO_SND_R_PCM_INFO handler

2022-02-12 Thread Laurent Vivier
Le 11/02/2022 à 23:13, Shreyansh Chouhan a écrit : Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 88 ++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index aec3e86db2..a53a6be

Re: [RFC PATCH 12/25] virtio-snd: Add VIRTIO_SND_R_JACK_INFO handler

2022-02-12 Thread Laurent Vivier
Le 11/02/2022 à 23:13, Shreyansh Chouhan a écrit : Signed-off-by: Shreyansh Chouhan --- hw/audio/virtio-snd.c | 81 +-- 1 file changed, 79 insertions(+), 2 deletions(-) diff --git a/hw/audio/virtio-snd.c b/hw/audio/virtio-snd.c index a87922f91b..c2af26

Re: [RFC PATCH v2 00/25] Virtio Sound card Implementation

2022-02-12 Thread Laurent Vivier
Le 11/02/2022 à 23:12, Shreyansh Chouhan a écrit : The second RFC for implementing the VirtIO Sound card as described in the virtio specs. Sorry for the absence of activity on this. The output from the sound card works. What remains to be done: - Features defined in PCM features. (Eg message po

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread Peter Maydell
On Sat, 12 Feb 2022 at 17:02, BALATON Zoltan wrote: > > On Sat, 12 Feb 2022, Peter Maydell wrote: > > On Sat, 12 Feb 2022 at 13:42, BALATON Zoltan wrote: > >> By the way the corresponding member in struct PIIXState in > >> include/hw/southbridge/piix.h has a comment saying: > >> > >> /* This

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-12 Thread Christian Schoenebeck
On Samstag, 12. Februar 2022 18:27:18 CET Christian Schoenebeck wrote: > On Samstag, 12. Februar 2022 16:23:49 CET Akihiko Odaki wrote: > > On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: > > > When building on macOS 12 we get: > > >audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElem

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-12 Thread Christian Schoenebeck
On Samstag, 12. Februar 2022 16:23:49 CET Akihiko Odaki wrote: > On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: > > When building on macOS 12 we get: > >audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > >deprecated: first deprecated in macOS 12.0 > >[-Werror

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Peter Maydell wrote: On Sat, 12 Feb 2022 at 13:42, BALATON Zoltan wrote: By the way the corresponding member in struct PIIXState in include/hw/southbridge/piix.h has a comment saying: /* This member isn't used. Just for save/load compatibility */ int32_t pci_irq_

Re: [PATCH v2 1/5] malta: Move PCI interrupt handling from gt64xxx to piix4

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, BALATON Zoltan wrote: On Sat, 12 Feb 2022, Bernhard Beschow wrote: Handling PCI interrupts in piix4 increases cohesion and reduces differences between piix4 and piix3. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Sorry for being late in commenting

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread Peter Maydell
On Sat, 12 Feb 2022 at 13:42, BALATON Zoltan wrote: > By the way the corresponding member in struct PIIXState in > include/hw/southbridge/piix.h has a comment saying: > > /* This member isn't used. Just for save/load compatibility */ > int32_t pci_irq_levels_vmstate[PIIX_NUM_PIRQS]; > >

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Peter Maydell
On Sat, 12 Feb 2022 at 13:27, BALATON Zoltan wrote: > > On Sat, 12 Feb 2022, Bernhard Beschow wrote: > > Passing own DeviceState rather than just the IRQs allows for resolving > > global variables. > > Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? > > > Signed-off-by: Be

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just the IRQs allows for resolving global variables. Do you mean pci_set_irq_fn instead of pci_map_irq_fn in

Re: [PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 14:19:51 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx to piix4" where i8259[] was moved from MaltaState to PIIX4State to ma

Re: [PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, BALATON Zoltan wrote: On Sat, 12 Feb 2022, Bernhard Beschow wrote: Am 12. Februar 2022 14:19:51 MEZ schrieb BALATON Zoltan : On Sat, 12 Feb 2022, Bernhard Beschow wrote: This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx to piix4" where i8259[] w

Re: [PATCH v5 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO

2022-02-12 Thread Peter Maydell
On Fri, 11 Feb 2022 at 16:18, Philippe Mathieu-Daudé wrote: > For user-mode, this patch makes sense. For system-mode it is > not obvious to make sense of SYS_HEAPINFO (except focusing in > cores targeting embedded systems eventually). The main user of semihosting in system mode is standalone bina

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-12 Thread Akihiko Odaki
On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^~~

Re: [PATCH v4 01/13] lcitool: refresh

2022-02-12 Thread Akihiko Odaki
On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/ubuntu1804.docker | 2 -- tests/docker/dockerfiles/ubuntu2004.docker | 2 -- 2 files changed, 4 deletions(-) diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/te

Re: [PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread BB
Am 12. Februar 2022 14:19:51 MEZ schrieb BALATON Zoltan : >On Sat, 12 Feb 2022, Bernhard Beschow wrote: >> This is a follow-up on patch "malta: Move PCI interrupt handling from >> gt64xxx to piix4" where i8259[] was moved from MaltaState to PIIX4State >> to make the code movement more obvious. H

Re: [PULL 0/7] nbd: handle AioContext change correctly

2022-02-12 Thread Christian Schoenebeck
On Freitag, 11. Februar 2022 14:04:44 CET Vladimir Sementsov-Ogievskiy wrote: > 11.02.2022 15:52, Peter Maydell wrote: > > On Wed, 9 Feb 2022 at 14:03, Vladimir Sementsov-Ogievskiy > > > > wrote: > >> The following changes since commit 0a301624c2f4ced3331ffd5bce85b4274fe132af: > >>Merge remo

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Bernhard Beschow
Am 12. Februar 2022 14:27:32 MEZ schrieb BALATON Zoltan : >On Sat, 12 Feb 2022, Bernhard Beschow wrote: >> Passing own DeviceState rather than just the IRQs allows for resolving >> global variables. > >Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? I'm referring to the ty

Re: [PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread Bernhard Beschow
Am 12. Februar 2022 14:19:51 MEZ schrieb BALATON Zoltan : >On Sat, 12 Feb 2022, Bernhard Beschow wrote: >> This is a follow-up on patch "malta: Move PCI interrupt handling from >> gt64xxx to piix4" where i8259[] was moved from MaltaState to PIIX4State >> to make the code movement more obvious. Howe

Re: [PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Now that pci_irq_levels[] is part of PIIX4State, the PCI IRQ levels can be saved and restored via the VMState mechanism. This fixes migrated VMs to start with PCI IRQ levels zeroed, which is a bug. Suggested-by: Peter Maydell Suggested-by: Philippe M

Re: [PATCH v4 0/6] Introduce CanoKey QEMU

2022-02-12 Thread Hongren (Zenithal) Zheng
Hi, Is there any further feedback on this patch set. Regards, Zenithal

Re: [PATCH v4 09/13] block/file-posix: Remove a deprecation warning on macOS 12

2022-02-12 Thread Christian Schoenebeck
On Freitag, 11. Februar 2022 17:34:30 CET Philippe Mathieu-Daudé via wrote: > When building on macOS 12 we get: > > block/file-posix.c:3335:18: warning: 'IOMasterPort' is deprecated: first > deprecated in macOS 12.0 [-Wdeprecated-declarations] kernResult = > IOMasterPort( MACH_PORT_NULL, &master

Re: [PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Passing own DeviceState rather than just the IRQs allows for resolving global variables. Do you mean pci_set_irq_fn instead of pci_map_irq_fn in the patch title? Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Philippe Mat

Re: [PATCH v4 12/13] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-12 Thread Christian Schoenebeck
On Freitag, 11. Februar 2022 17:34:33 CET Philippe Mathieu-Daudé via wrote: > setAllowedFileTypes is deprecated in macOS 12. > > Per Akihiko Odaki [*]: > > An image file, which is being chosen by the panel, can be a > raw file and have a variety of file extensions and many are not > covered

Re: [PATCH v2 1/5] malta: Move PCI interrupt handling from gt64xxx to piix4

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: Handling PCI interrupts in piix4 increases cohesion and reduces differences between piix4 and piix3. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Sorry for being late in commenting, I've missed the first round. Apologies if

Re: [PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread BALATON Zoltan
On Sat, 12 Feb 2022, Bernhard Beschow wrote: This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx to piix4" where i8259[] was moved from MaltaState to PIIX4State to make the code movement more obvious. However, i8259[] seems redundant to *isa, so remove it. Should this

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-12 Thread Christian Schoenebeck
On Freitag, 11. Februar 2022 17:34:31 CET Philippe Mathieu-Daudé via wrote: > When building on macOS 12 we get: > > audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is > deprecated: first deprecated in macOS 12.0 > [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElement

[PATCH] multifd: ensure multifd threads are terminated before cleanup params

2022-02-12 Thread Wang Xin via
In multifd_save_cleanup(), we terminate all multifd threads and destroy the 'p->mutex', while the mutex may still be held by multifd send thread, this causes qemu to crash. It's because the multifd_send_thread maybe scheduled out after setting 'p->running' to false. To reproduce the problem, we pu

[PATCH v2 5/5] isa/piix4: Resolve redundant i8259[] attribute

2022-02-12 Thread Bernhard Beschow
This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx to piix4" where i8259[] was moved from MaltaState to PIIX4State to make the code movement more obvious. However, i8259[] seems redundant to *isa, so remove it. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 7 +--

[PATCH v2 4/5] isa/piix4: Fix PCI IRQ levels to be preserved in VMState

2022-02-12 Thread Bernhard Beschow
Now that pci_irq_levels[] is part of PIIX4State, the PCI IRQ levels can be saved and restored via the VMState mechanism. This fixes migrated VMs to start with PCI IRQ levels zeroed, which is a bug. Suggested-by: Peter Maydell Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Bernhard Beschow

[PATCH v2 3/5] isa/piix4: Resolve global variables

2022-02-12 Thread Bernhard Beschow
Now that piix4_set_irq's opaque parameter references own PIIX4State, piix4_dev becomes redundant and pci_irq_levels can be moved into PIIX4State. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c| 22 +- include/hw/southbr

[PATCH v2 2/5] pci: Always pass own DeviceState to pci_map_irq_fn's

2022-02-12 Thread Bernhard Beschow
Passing own DeviceState rather than just the IRQs allows for resolving global variables. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 6 +++--- hw/pci-host/sh_pci.c| 6 +++--- hw/pci-host/versatile.c | 6 +++---

[PATCH v2 1/5] malta: Move PCI interrupt handling from gt64xxx to piix4

2022-02-12 Thread Bernhard Beschow
Handling PCI interrupts in piix4 increases cohesion and reduces differences between piix4 and piix3. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 58 +++ hw/mips/gt64xxx_pci.c | 62 -

[PATCH v2 0/5] malta: Fix PCI IRQ levels to be preserved during migration

2022-02-12 Thread Bernhard Beschow
The intention behind v1 [1] was just to remove some global variables from gt64xxx and piix4. During review it was noticed that the Malta board misses to preserve the PCI IRQ levels during migration. Since the patch series offered an easy fix v2 was born. Furthermore, i8259[] was moved to PIIX4Stat

[PATCH v2] hw/net: e1000e: Clear ICR on read when using non MSI-X interrupts

2022-02-12 Thread Nick Hudson
In section 7.4.3 of the 82574 datasheet it states that "In systems that do not support MSI-X, reading the ICR register clears it's bits..." Some OSes rely on this. Signed-off-by: Nick Hudson --- hw/net/e1000e_core.c | 5 + hw/net/trace-events | 1 + 2 files changed, 6 insertions(