Re: [PATCH 29/31] vdpa: Make ncs autofree

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Simplifying memory management. Signed-off-by: Eugenio Pérez To reduce the size of this series. This can be sent as an separate patch if I was not wrong. Thanks --- net/vhost-vdpa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) di

Re: [PATCH 30/31] vdpa: Move vhost_vdpa_get_iova_range to net/vhost-vdpa.c

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Since it's a device property, it can be done in net/. This helps SVQ to allocate the rings in vdpa device initialization, rather than delay that. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 15 --- net/vhost-vdpa.c | 32

Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: SVQ is able to log the dirty bits by itself, so let's use it to not block migration. Also, ignore set and clear of VHOST_F_LOG_ALL on set_features if SVQ is enabled. Even if the device supports it, the reports would be nonsense because SVQ memory is in the

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: @@ -272,6 +590,28 @@ void vhost_svq_set_svq_kick_fd(VhostShadowVirtqueue *svq, int svq_kick_fd) void vhost_svq_stop(VhostShadowVirtqueue *svq) { event_notifier_set_handler(&svq->svq_kick, NULL); +g_autofree VirtQueueElement *next_avail_elem =

Re: [PATCH 23/31] vdpa: Add custom IOTLB translations to SVQ

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Use translations added in VhostIOVATree in SVQ. Only introduce usage here, not allocation and deallocation. As with previous patches, we use the dead code paths of shadow_vqs_enabled to avoid commiting too many changes at once. These are impossible to take

Re: [PATCH 22/31] vhost: Add VhostIOVATree

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: This tree is able to look for a translated address from an IOVA address. At first glance it is similar to util/iova-tree. However, SVQ working on devices with limited IOVA space need more capabilities, So did the IOVA tree (e.g l2 vtd can only work in t

Re: [PATCH 21/31] util: Add iova_tree_alloc

2022-01-29 Thread Jason Wang
在 2022/1/24 下午5:20, Eugenio Perez Martin 写道: On Mon, Jan 24, 2022 at 5:33 AM Peter Xu wrote: On Fri, Jan 21, 2022 at 09:27:23PM +0100, Eugenio Pérez wrote: +int iova_tree_alloc(IOVATree *tree, DMAMap *map, hwaddr iova_begin, I forgot to s/iova_tree_alloc/iova_tree_alloc_map/ here. +

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There is no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices use forced IOMMU, this means that SVQ is not usable at this

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: First half of the buffers forwarding part, preparing vhost-vdpa callbacks to SVQ to offer it. QEMU cannot enable it at this moment, so this is effectively dead code at the moment, but it helps to reduce patch size. Signed-off-by: Eugenio Pérez --- hw/vi

Re: [PATCH v13 2/7] net/vmnet: add vmnet backends to qapi/net

2022-01-29 Thread Roman Bolshakov
On Tue, Jan 25, 2022 at 01:14:27PM +0900, Akihiko Odaki wrote: > On Tue, Jan 25, 2022 at 8:00 AM Roman Bolshakov wrote: > > > > On Mon, Jan 24, 2022 at 08:14:31PM +, Peter Maydell wrote: > > > On Mon, 24 Jan 2022 at 17:49, Roman Bolshakov wrote: > > > > I'm not sure why blocks are Objective-C

[PATCH] linux-user/syscall: Translate TARGET_RLIMIT_RTTIME

2022-01-29 Thread Serge Belyshev
Signed-off-by: Serge Belyshev --- linux-user/generic/target_resource.h | 1 + linux-user/syscall.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/linux-user/generic/target_resource.h b/linux-user/generic/target_resource.h index f04c93b125..539d8c4677 100644 --- a/linux-

[PATCH] linux-user: Move generic TARGET_RLIMIT* definitions to generic/target_resource.h

2022-01-29 Thread Serge Belyshev
Signed-off-by: Serge Belyshev --- Compile tested, and also verified that target definitions did not change. linux-user/aarch64/target_resource.h| 1 + linux-user/alpha/target_resource.h | 21 ++ linux-user/arm/target_resource.h| 1 + linux-user/cris/target_resource.h

Re: [PATCH] linux-user/alpha: Fix target rlimits for alpha and rearrange for clarity

2022-01-29 Thread Serge Belyshev
Laurent Vivier writes: > > Reviewed-by: Laurent Vivier > Applied to my linux-user-for-7.0 branch. Thanks! > perhaps you could also add RLIMIT_RTTIME (15) and update > target_to_host_resource()? > > The next step would be to move the generic definitions to a new file > in linux-user/generic/t

Re: [PATCH] linux-user/syscall: Do not ignore info.si_pid == 0 in waitid()

2022-01-29 Thread Serge Belyshev
Laurent Vivier writes: > ... > > According to wait(2), it sounds a little bit more complicated than that. > >If WNOHANG was specified in options and there were no children in a > waitable state, then >waitid() returns 0 immediately and the state of the siginfo_t > structure po

Re: [PATCH 07/31] vhost: dd vhost_svq_get_svq_call_notifier

2022-01-29 Thread Eugenio Perez Martin
On Sat, Jan 29, 2022 at 8:57 AM Jason Wang wrote: > > > 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > > This allows vhost-vdpa device to retrieve device -> svq call eventfd. > > > > Signed-off-by: Eugenio Pérez > > > What did 'dd' mean in the title? > It was intended to be "add" but I missed the first

Re: [PULL 00/32] target-arm queue

2022-01-29 Thread Peter Maydell
On Fri, 28 Jan 2022 at 15:30, Peter Maydell wrote: > > The following changes since commit b367db48126d4ee14579af6cf5cdbffeb9496627: > > Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20220127' into > staging (2022-01-28 11:05:29 +) > > are available in the Git repository at: >

build-oss-fuzz CI job often times out

2022-01-29 Thread Peter Maydell
Hi; the build-oss-fuzz gitlab CI job seems to intermittently but quite commonly hit the 1 hour timeout mark and get killed. Examples from the last couple of days: https://gitlab.com/qemu-project/qemu/-/jobs/2030815488 https://gitlab.com/qemu-project/qemu/-/jobs/2029246068 https://gitlab.com/qemu-p

Re: [PATCH] tests/9pfs: Use g_autofree and g_autoptr where possible

2022-01-29 Thread Christian Schoenebeck
On Freitag, 28. Januar 2022 12:49:58 CET Christian Schoenebeck wrote: > On Mittwoch, 26. Januar 2022 18:11:36 CET Greg Kurz wrote: > > The template pointer in virtio_9p_create_local_test_dir() is leaked. > > Add the g_autofree annotation to fix that. While here, convert the > > rest of the virtio 9

[RFC PATCH 1/1] i386: Remove features from Epyc-Milan cpu

2022-01-29 Thread Leonardo Bras
While trying to bring a VM with EPYC-Milan cpu on a host with EPYC-Milan cpu (EPYC 7313), the following warning can be seen: qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.erms [bit 9] qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.

[PATCH v1 1/1] target/i386: Mask xstate_bv based on the cpu enabled features

2022-01-29 Thread Leonardo Bras
The following steps describe a migration bug: 1 - Bring up a VM with -cpu EPYC on a host with EPYC-Milan cpu 2 - Migrate to a host with EPYC-Naples cpu The guest kernel crashes shortly after the migration. The crash happens due to a fault caused by XRSTOR: A set bit in XSTATE_BV is not set in XCR

Re: [PATCH 00/20] tcg: vector improvements

2022-01-29 Thread Richard Henderson
Ping? Patch 1 is now upstream, but only patches 2-4 have reviews. It applies cleanly to master... r~ On 12/19/21 06:42, Richard Henderson wrote: Add some opcodes for compound logic operations that were so far marked as TODO. Implement those for PPC and S390X. We do not want to implement 512

Re: [PATCH 16/31] vhost: pass queue index to vhost_vq_get_addr

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Doing that way allows vhost backend to know what address to return. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 7b03efccec..64b

Re: [PATCH 15/31] vdpa: Add vhost_svq_get_num

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: This reports the guest's visible SVQ effective length, not the device's one. I think we need to explain if there could be a case that the SVQ size is not equal to the device queue size. Thanks Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-sh

Re: [PATCH 11/31] vhost: Add vhost_svq_valid_device_features to shadow vq

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: This allows SVQ to negotiate features with the device. For the device, SVQ is a driver. While this function needs to bypass all non-transport features, it needs to disable the features that SVQ does not support when forwarding buffers. This includes packed

Re: [PATCH 07/31] vhost: dd vhost_svq_get_svq_call_notifier

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: This allows vhost-vdpa device to retrieve device -> svq call eventfd. Signed-off-by: Eugenio Pérez What did 'dd' mean in the title? Thanks --- hw/virtio/vhost-shadow-virtqueue.h | 2 ++ hw/virtio/vhost-shadow-virtqueue.c | 12 2 f

Re: [PATCH 09/31] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2022-01-29 Thread Jason Wang
在 2022/1/22 上午4:27, Eugenio Pérez 写道: Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 18de14f0fb..029f98feee 100644 --- a/hw/virtio/vhost-v

Re: [PATCH 4/4] target/arm: Use CPTR_TFP with CPTR_EL3 in fp_exception_el

2022-01-29 Thread Zenghui Yu via
On 2022/1/27 14:34, Richard Henderson wrote: Use the named bit rather than a bare extract32. Signed-off-by: Richard Henderson Reviewed-by: Zenghui Yu