Thanks for this feedback Peter!
I ended up reading/replying the e-mails in thread order, so I may have
been redundant
with your argument, sorry about that.
I will add my comments inline, but I will add references to the
previous mail I sent
Daniel, so please read it too.
On Tue, Aug 31, 2021 at
Hi,
> -Original Message-
> From: Eric Auger [mailto:eric.au...@redhat.com]
> Sent: Wednesday, September 01, 2021 6:23 PM
> To: Li, Chunming; chunming; peter.mayd...@linaro.org
> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wen, Jianxian; Liu,
> Renwei
> Subject: Re: [PATCH v5 4/4] hw/ar
Hello Daniel, thank you for the feedback!
Comments inline.
On Tue, Aug 31, 2021 at 9:57 AM Daniel P. Berrangé wrote:
>
> On Tue, Aug 31, 2021 at 08:02:38AM -0300, Leonardo Bras wrote:
> > MSG_ZEROCOPY is a feature that enables copy avoidance in TCP/UDP socket
> > send calls. It does so by avoidi
HI,
I has two QOM model，A and B， When A‘s register changed，B’s register will
should also be change .
I dont konw how to change B's reg in A device .
On Fri, 27 Aug 2021 16:45:15 -0500
Eric DeVolder wrote:
> Igor,
> I'm not sure if I should post v7 with the correction to the tables,
> or await your guidance/feedback on v6.
Hopefully, I'll be back to reviewing patches (including yours) next week.
> Thanks,
> eric
>
>
> On 8/6/21 12:16 PM, E
On Thu, Sep 02, 2021 at 08:28:49AM +0200, Cédric Le Goater wrote:
> On 9/2/21 3:37 AM, David Gibson wrote:
> > On Wed, Sep 01, 2021 at 11:41:50AM +0200, Cédric Le Goater wrote:
> >> Signed-off-by: Cédric Le Goater
> >
> > Uh.. I thought the proposed assert was about making it clear there
> > woul
On 9/2/21 3:37 AM, David Gibson wrote:
> On Wed, Sep 01, 2021 at 11:41:50AM +0200, Cédric Le Goater wrote:
>> Signed-off-by: Cédric Le Goater
>
> Uh.. I thought the proposed assert was about making it clear there
> wouldn't be a divide by zero, which would want > 1, not < 2.
This is very wrong :
Per Peter Maydell [*]:
'info mtree' monitor command was designed on the assumption that
there's really only one or two interesting address spaces, and
with more recent developments that's just not the case any more.
Similarly about how the FlatView are sorted using a GHashTable,
sort the Ad
While mtree_info() handles both ASes and flatviews cases,
the two cases share basically no code. Split mtree_info()
as mtree_info_flatview() + mtree_info_as() to simplify.
Suggested-by: Peter Maydell
Reviewed-by: David Hildenbrand
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/memory.c | 87
Follow Peter Maydell suggestions:
- Split mtree_info() as mtree_info_flatview() + mtree_info_as()
- Remove duplicated Address Space information
Since v4:
- Merged patches 1 & 2 (David)
- Remove unnecessary return void (David)
- Added David R-b
Since v3:
- Fix typos
- Split mtree_info_flatview() +
Hi,
> I decided to bisect the merge in order to identify the commit that causes the
> issue - and much to my surprise, it is this particular commit:
> https://github.com/qemu/qemu/commit/bbd8323d3196c9979385cba1b8b38859836e63c3
Hmm, that is rather strange indeed.
> Given this doesn't seem to
On 9/2/21 8:09 AM, Philippe Mathieu-Daudé wrote:
> On 9/1/21 5:27 AM, Bin Meng wrote:
>> Read or write to uart registers when unclocked or in reset should be
>> ignored. Add the check there, and as a result of this, the check in
>> uart_write_tx_fifo() is now unnecessary.
>>
>> Signed-off-by: Bin M
On 9/1/21 10:32 AM, Edgar E. Iglesias wrote:
> On Wed, Sep 01, 2021 at 11:27:24AM +0800, Bin Meng wrote:
>> Read or write to uart registers when unclocked or in reset should be
>> ignored. Add the check there, and as a result of this, the check in
>> uart_write_tx_fifo() is now unnecessary.
>
> Hi
On 9/1/21 5:27 AM, Bin Meng wrote:
> Read or write to uart registers when unclocked or in reset should be
> ignored. Add the check there, and as a result of this, the check in
> uart_write_tx_fifo() is now unnecessary.
>
> Signed-off-by: Bin Meng
>
> ---
>
> Changes in v2:
> - new patch: hw/cha
On 9/1/21 5:27 AM, Bin Meng wrote:
> Currently the clock/reset check is done in uart_receive(), but we
> can move the check to uart_can_receive() which is earlier.
>
> Signed-off-by: Bin Meng
>
> ---
>
> Changes in v2:
> - avoid declaring variables mid-scope
>
> hw/char/cadence_uart.c | 17 ++
在 2021/8/4 上午11:48, Jason Wang 写道:
Hi:
We currently try to enable device IOTLB when iommu_platform is
set. This may lead unnecessary trasnsactions between qemu and vhost
when vIOMMU is not used (which is the typical case for the encrypted
VM).
So patch tries to use transport specific method t
When mergeable buffer is enabled, we try to set the num_buffers after
the virtqueue elem has been unmapped. This will lead several issues,
E.g a use after free when the descriptor has an address which belongs
to the non direct access region. In this case we use bounce buffer
that is allocated durin
On Wed, Sep 01, 2021 at 08:45:15PM +0800, Bin Meng wrote:
> As of today, when booting upstream U-Boot for Xilinx Zynq, the UART
> does not receive anything. Debugging shows that the UART input clock
> frequency is zero which prevents the UART from receiving anything as.
> per the logic in uart_rece
On Thu, Sep 2, 2021 at 11:57 AM Bin Meng wrote:
>
> On Thu, Sep 2, 2021 at 8:40 AM Alistair Francis
> wrote:
> >
> > From: Alistair Francis
> >
> > Update the ePMP CSRs to match the 0.9.3 ePMP spec
> > https://github.com/riscv/riscv-tee/blob/61455747230a26002d741f64879dd78cc9689323/Smepmp/Smepmp
On Wed, 1 Sep 2021 14:58:00 +0200
Thomas Huth wrote:
> The PAGE_SIZE macro is causing trouble on Alpine Linux since it
> clashes with a macro from a system header there. We already have
> the TARGET_PAGE_SIZE, TARGET_PAGE_MASK and TARGET_PAGE_BITS macros
> in QEMU anyway, so let's simply replace
On Wed, Sep 01, 2021 at 11:41:53AM +0200, Cédric Le Goater wrote:
> This to avoid possible conflicts with the "id" property of QOM objects.
>
> Signed-off-by: Cédric Le Goater
Applied to ppc-for-6.2, thanks.
> ---
> include/hw/ppc/pnv_core.h | 2 +-
> hw/ppc/pnv.c | 4 ++--
> hw/p
Thanks for the comment. I will submit another patch.
Best regards,
Eugene
From: Marc-André Lureau
Sent: Monday, August 30, 2021 7:01 AM
To: Eugene Huang ; Gerd Hoffmann
Cc: QEMU
Subject: Re: [PATCH 1/2] Use EGL device extension in display initialization.
External email: Use caution opening li
On Wed, Sep 01, 2021 at 11:41:52AM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater
Applied to ppc-for-6.2
> ---
> include/hw/ppc/xive.h | 5 +
> hw/intc/xive.c| 5 -
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/hw/ppc/xive.h b/inc
On Wed, Sep 01, 2021 at 11:41:47AM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater
Applied to ppc-for-6.2, thanks.
> ---
> hw/ppc/spapr_cpu_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 4f316a6f9d31..5
On Wed, Sep 01, 2021 at 11:41:51AM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater
Applied to ppc-for-6.2.
> ---
> include/hw/ppc/xive.h | 11 +++
> hw/intc/xive.c| 21 ++---
> 2 files changed, 17 insertions(+), 15 deletions(-)
>
> diff --git a/
On Tue, Aug 31, 2021 at 01:39:55PM -0300, Luis Pires wrote:
> From: Bruno Larsen
>
> Move REQUIRE_ALTIVEC to translate.c and rename it to REQUIRE_VECTOR.
>
> Signed-off-by: Bruno Larsen
> Signed-off-by: Matheus Ferst
> Signed-off-by: Fernando Valle
> Signed-off-by: Luis Pires
Acked-by: Davi
On Wed, Sep 01, 2021 at 11:41:49AM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater
Applied to ppc-for-6.2.
> ---
> hw/ppc/pnv.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 2f5358b70c95..a62e90b15e27 100644
On Wed, Sep 01, 2021 at 11:41:48AM +0200, Cédric Le Goater wrote:
> On P10, the chip id is calculated from the "Primary topology table
> index". See skiboot commits for more information [1].
>
> This information is extracted from the hdata on real systems which
> QEMU needs to emulate. Add this pr
On Wed, Sep 01, 2021 at 11:41:50AM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater
Uh.. I thought the proposed assert was about making it clear there
wouldn't be a divide by zero, which would want > 1, not < 2.
> ---
> hw/ppc/pnv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>
On Sep 1, 2021, at 23:05, Philippe Mathieu-Daudé
mailto:f4...@amsat.org>> wrote:
On 8/20/21 10:04 AM, Philippe Mathieu-Daudé wrote:
These authors have some incorrect author email field.
For each of them, there is one commit with the replaced
entry.
Cc: Alex Chen mailto:alex.c...@huawei.com>>
C
On Wed, Sep 1, 2021 at 10:49 PM Bin Meng wrote:
>
> Read or write to uart registers when unclocked or in reset should be
> ignored. Add the check there, and as a result of this, the check in
> uart_write_tx_fifo() is now unnecessary.
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Al
On Wed, Sep 1, 2021 at 10:52 PM Bin Meng wrote:
>
> We've got SW that expects FSBL (Bootlooader) to setup clocks and
> resets. It's quite common that users run that SW on QEMU without
> FSBL (FSBL typically requires the Xilinx tools installed). That's
> fine, since users can stil use -device loade
On Wed, Sep 1, 2021 at 10:46 PM Bin Meng wrote:
>
> This converts uart_read() and uart_write() to memop_with_attrs() ops.
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Alistair
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - new patch: hw/char: cadence_uart: Convert to me
On Wed, Sep 1, 2021 at 10:49 PM Bin Meng wrote:
>
> Currently the clock/reset check is done in uart_receive(), but we
> can move the check to uart_can_receive() which is earlier.
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Alistair
>
> ---
>
> (no changes since v2)
>
> Changes i
On Thu, Sep 2, 2021 at 11:59 AM Bin Meng wrote:
>
> On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote:
> >
> >
> > On 2021/9/1 下午9:05, Bin Meng wrote:
> > > On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote:
> > >> These variables should be target_ulong. If truncated to int,
> > >> the bool conditio
On Thu, Sep 2, 2021 at 10:44 AM LIU Zhiwei wrote:
>
>
> On 2021/9/2 上午9:59, Bin Meng wrote:
> > On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote:
> >>
> >> On 2021/9/1 下午9:05, Bin Meng wrote:
> >>> On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote:
> These variables should be target_ulong. If
On 2021/9/2 上午9:59, Bin Meng wrote:
On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote:
On 2021/9/1 下午9:05, Bin Meng wrote:
On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote:
These variables should be target_ulong. If truncated to int,
the bool conditions they indicate will be wrong.
As satp
On Wed, Sep 1, 2021 at 1:30 PM Bin Meng wrote:
>
> This converts uart_read() and uart_write() to memop_with_attrs() ops.
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Alistair
>
> ---
>
> Changes in v2:
> - new patch: hw/char: cadence_uart: Convert to memop_with_attrs() ops
>
> h
On Wed, Sep 1, 2021 at 1:28 PM Bin Meng wrote:
>
> Currently the clock/reset check is done in uart_receive(), but we
> can move the check to uart_can_receive() which is earlier.
>
> Signed-off-by: Bin Meng
Reviewed-by: Alistair Francis
Alistair
>
> ---
>
> Changes in v2:
> - avoid declaring v
On Mon, Aug 30, 2021 at 9:22 PM Philipp Tomsich
wrote:
>
> With the addition of Zb[abcs], we also need to add disassembler
> support for these new instructions.
>
> Signed-off-by: Philipp Tomsich
Acked-by: Alistair Francis
Alistair
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Fix
On Fri, Aug 27, 2021 at 1:16 AM Ruinland Chuan-Tzu Tsai
wrote:
>
> From: Ruinland ChuanTzu Tsai
>
> During my modification on my previous patch series for custom CSR support, I
> believe this issue deserves its own discussion (or debate) because it's _not_
> as simple as "just put those options i
Hi,
thank you for your response.
As you say
> "
> *End of interrupt handling is entirely dependent on what the*
> *guest hardware being emulated is. Usually the guest software*
> *will indicate "interrupt handled" back to the interrupt*
> *controller (perhaps by writing a register; depend
Hi,
> -Original Message-
> From: Eric Auger [mailto:eric.au...@redhat.com]
> Sent: Wednesday, September 01, 2021 8:05 PM
> To: Li, Chunming; chunming; peter.mayd...@linaro.org
> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Wen, Jianxian; Liu,
> Renwei
> Subject: Re: [PATCH v5 2/4] hw/ar
On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote:
>
>
> On 2021/9/1 下午9:05, Bin Meng wrote:
> > On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote:
> >> These variables should be target_ulong. If truncated to int,
> >> the bool conditions they indicate will be wrong.
> >>
> >> As satp is very importa
On Thu, Sep 2, 2021 at 8:40 AM Alistair Francis
wrote:
>
> From: Alistair Francis
>
> Update the ePMP CSRs to match the 0.9.3 ePMP spec
> https://github.com/riscv/riscv-tee/blob/61455747230a26002d741f64879dd78cc9689323/Smepmp/Smepmp.pdf
>
> Signed-off-by: Alistair Francis
> ---
> target/riscv/c
> -Original Message-
> From: Eric Auger [mailto:eric.au...@redhat.com]
> Sent: Wednesday, September 01, 2021 9:14 PM
> To: Liu, Renwei; Peter Maydell
> Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org; Li, Chunming; Wen,
> Jianxian
> Subject: Re: [PATCH v2] hw/arm/smmuv3: Simplify range inval
On 2021/9/1 下午9:05, Bin Meng wrote:
On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote:
These variables should be target_ulong. If truncated to int,
the bool conditions they indicate will be wrong.
As satp is very important for Linux, this bug almost fails every boot.
Could you please describe
From: Alistair Francis
Update the ePMP CSRs to match the 0.9.3 ePMP spec
https://github.com/riscv/riscv-tee/blob/61455747230a26002d741f64879dd78cc9689323/Smepmp/Smepmp.pdf
Signed-off-by: Alistair Francis
---
target/riscv/cpu_bits.h | 4 ++--
target/riscv/cpu.c | 1 +
2 files changed, 3 in
From: Peter Delevoryas
This adds a new machine type "fuji-bmc" that's equivalent to
"ast2600-evb" except that it uses MAC3 and UART1. It might be
appropriate to change other aspects of this machine type in the future,
but so far this is all the specificity necessary to get a Fuji OpenBMC
image bo
From: Peter Delevoryas
Adding a new Aspeed AST2600 machine type, uses MAC3 for ethernet1 and
UART1 for the serial console, which is different than the existing
ast2600-evb. Otherwise though, my usage so far hasn't required a
different set of hardware strap registers or anything, so I just
inherit
On Wed, 1 Sep 2021, Laurent Vivier wrote:
> Le 26/08/2021 à 07:21, Finn Thain a écrit :
> > On Wed, 25 Aug 2021, Mark Cave-Ayland wrote:
> >
> >> On 24/08/2021 11:09, Finn Thain wrote:
> >>
> >>> The Synertek datasheet says, "A write to T1L-H loads an 8-bit count value
> >>> into the latch. A rea
Hello!
Sending to the list because I was directed here after asking on IRC.
Background: I've forked QEMU for a project and am in the process of
implementing a more complete STM32F4xx stack as a secondary task.
To resolve recent GCC11 build errors, I attempted to merge with upstream QEMU
v6 (co
Change the data type of the ioctl _request_ argument from 'int' to
'unsigned long' for the kvm ioctl wrappers.
POSIX defines the request argument as 'int' but the glibc defines the ioctl
call as follows
int ioctl (int fd, unsigned long int request, ...);
Requests with the 0x8000_ bit set
Adding this callback provides a way to resume the processing of
cmds in fenceq and cmdq that were not processed because the UI
was waiting on a fence and blocked cmd processing.
Cc: Gerd Hoffmann
Reviewed-by: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu.c | 32 +++
Instead of immediately drawing and submitting, queue and wait
for the draw signal if the dmabuf submitted is a blob.
Cc: Gerd Hoffmann
Reviewed-by: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/gtk.h | 2 ++
ui/gtk-egl.c | 15 +++
ui/gtk.c | 2 +-
3 file
These egl helpers would be used for creating and waiting on
a sync object.
Cc: Gerd Hoffmann
Reviewed-by: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/console.h | 2 ++
include/ui/egl-helpers.h | 2 ++
ui/egl-helpers.c | 26 ++
3 files chang
Create sync objects and fences only for dmabufs that are blobs. Once a
fence is created (after glFlush) and is signalled,
graphic_hw_gl_flushed() will be called and virtio-gpu cmd processing
will be resumed.
Cc: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
hw/display/virtio-gpu-udmabuf.c |
Since the texture release mechanism is same for both gtk-egl
and gtk-glarea, move the helper from gtk-egl to common gtk
code so that it can be shared by both gtk backends.
Cc: Gerd Hoffmann
Reviewed-by: Gerd Hoffmann
Signed-off-by: Vivek Kasireddy
---
include/ui/gtk.h | 2 --
ui/gtk-egl.c
When the Guest and Host are using Blob resources, there is a chance
that they may use the underlying storage associated with a Blob at
the same time leading to glitches such as flickering or tearing.
To prevent these from happening, the Host needs to ensure that it
waits until its Blit is completed
On Tue, Aug 31, 2021 at 08:02:37AM -0300, Leonardo Bras wrote:
> Some syscalls used for writting, such as sendmsg(), accept flags that
> can modify their behavior, even allowing the usage of features such as
> MSG_ZEROCOPY.
>
> Change qio_channel_write*() interface to allow passing down flags,
> a
On Wed, Sep 01, 2021 at 09:17:07PM +0100, Peter Maydell wrote:
> On Wed, 1 Sept 2021 at 19:51, Richard W.M. Jones wrote:
> >
> > On Wed, Sep 01, 2021 at 07:41:21PM +0100, Peter Maydell wrote:
> > > Is the failure case short enough to allow -d ... logging to
> > > be taken? That's usually the most
On Mon, Aug 30, 2021 at 10:15 PM Peter Maydell wrote:
> I think I would vote for following the type used by the ioctl()
> function as declared in the headers for both Linux and the BSDs,
> and using 'unsigned long'.
> (We should change KVMState::irq_set_ioctl too, to match.)
I would agree to 'uns
On Wed, 1 Sept 2021 at 19:51, Richard W.M. Jones wrote:
>
> On Wed, Sep 01, 2021 at 07:41:21PM +0100, Peter Maydell wrote:
> > Is the failure case short enough to allow -d ... logging to
> > be taken? That's usually the most useful info, but it's so huge
> > it's often not feasible.
>
> I can try
Hello Peter,
On Tue, Aug 31, 2021 at 6:24 PM Peter Xu wrote:
>
> On Tue, Aug 31, 2021 at 08:02:36AM -0300, Leonardo Bras wrote:
> > Results:
> > So far, the resource usage of __sys_sendmsg() reduced 15 times, and the
> > overall migration took 13-18% less time, based in synthetic workload.
>
> Le
On Wed, Sep 01, 2021 at 07:41:21PM +0100, Peter Maydell wrote:
> Is the failure case short enough to allow -d ... logging to
> be taken? That's usually the most useful info, but it's so huge
> it's often not feasible.
I can try -- what exact -d option would be useful?
Rich.
--
Richard Jones, Vi
On Wed, 1 Sept 2021 at 19:30, Richard W.M. Jones wrote:
>
> On Wed, Sep 01, 2021 at 07:18:03PM +0100, Peter Maydell wrote:
> > On Wed, 1 Sept 2021 at 18:01, Richard W.M. Jones wrote:
> > >
> > > This avoids the following assertion when the kernel initializes X.509
> > > certificates:
> > >
> > >
On Wed, Sep 01, 2021 at 07:18:03PM +0100, Peter Maydell wrote:
> On Wed, 1 Sept 2021 at 18:01, Richard W.M. Jones wrote:
> >
> > This avoids the following assertion when the kernel initializes X.509
> > certificates:
> >
> > [7.315373] Loading compiled-in X.509 certificates
> > qemu-system-arm
On Wed, 1 Sept 2021 at 18:01, Richard W.M. Jones wrote:
>
> This avoids the following assertion when the kernel initializes X.509
> certificates:
>
> [7.315373] Loading compiled-in X.509 certificates
> qemu-system-arm: ../tcg/tcg.c:3063: temp_allocate_frame: Assertion `align <=
> TCG_TARGET_S
On Wed, Sep 01, 2021 at 05:58:57PM +0200, Lukas Straub wrote:
> When introducing yank functionality in the migration code I forgot
> to cover the multifd send side.
>
> Signed-off-by: Lukas Straub
> Tested-by: Leonardo Bras
> Reviewed-by: Leonardo Bras
> ---
>
> -v2:
> -add Tested-by and Revi
On Mittwoch, 1. September 2021 18:47:21 CEST Greg Kurz wrote:
> On Wed, 1 Sep 2021 18:15:10 +0200
>
> Christian Schoenebeck wrote:
> > v9fs_walk() utilizes the v9fs_co_run_in_worker({...}) macro to run the
> > supplied fs driver code block on a background worker thread.
> >
> > When either the '
On 01.09.21 18:19, Philippe Mathieu-Daudé wrote:
Per Peter Maydell [*]:
'info mtree' monitor command was designed on the assumption that
there's really only one or two interesting address spaces, and
with more recent developments that's just not the case any more.
Similarly about how t
On 01.09.21 18:19, Philippe Mathieu-Daudé wrote:
While mtree_info() handles both ASes and flatviews cases,
the two cases share basically no code. Split mtree_info_as()
out of mtree_info() to simplify.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/memory.c | 17
On 01.09.21 18:19, Philippe Mathieu-Daudé wrote:
While mtree_info() handles both ASes and flatviews cases,
the two cases share basically no code. Split mtree_info_flatview()
out of mtree_info() to simplify.
Note: Patch easier to review using 'git-diff --color-moved=blocks'.
Suggested-by: Peter
On Wed, Sep 1, 2021 at 8:13 PM Peter Maydell
wrote:
> Fix a typo in the help message printed by vhost-user-bridge.
>
> Signed-off-by: Peter Maydell
>
Reviewed-by: Marc-André Lureau
---
> tests/vhost-user-bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/
On Wed, Sep 1, 2021 at 8:36 PM Peter Maydell
wrote:
> The vhost-user-bridge binary accepts a UNIX socket path on
> the command line. Sanity check that this is short enough to
> fit into a sockaddr_un before copying it in.
>
> Fixes: Coverity CID 1432866
> Signed-off-by: Peter Maydell
>
Reviewed
available in the Git repository at:
>
> git://git.kraxel.org/qemu tags/usb-20210901-pull-request
>
> for you to fetch changes up to ae420c957aff2871b8a1af9cf9ee1a7a75b3552b:
>
> hw/usb: Fix typo in comments and print (2021-09-01 06:37:13 +0200)
>
> ---
On Wed, 1 Sep 2021 18:15:10 +0200
Christian Schoenebeck wrote:
> v9fs_walk() utilizes the v9fs_co_run_in_worker({...}) macro to run the
> supplied fs driver code block on a background worker thread.
>
> When either the 'Twalk' client request was interrupted or if the client
> requested fid for t
https://www.mail-archive.com/qemu-devel@nongnu.org/msg833146.html
I tested this patch which simply increases the stack alignment to 16
bytes and it fixes the assertion failure and otherwise appears to work
(in as far as it boots the libguestfs appliance). However I've no
idea if this is the right
> On Sep 1, 2021, at 9:19 AM, Cédric Le Goater wrote:
>
> On 9/1/21 5:36 PM, p...@fb.com wrote:
>> From: Peter Delevoryas
>>
>> When you run QEMU with an Aspeed machine and a single serial device
>> using stdio like this:
>>
>>qemu -machine ast2600-evb -drive ... -serial stdio
>>
>> The
On 9/1/21 6:47 PM, Daniel P. Berrangé wrote:
> On Wed, Sep 01, 2021 at 06:27:37PM +0200, Cédric Le Goater wrote:
>> On 9/1/21 6:24 PM, Philippe Mathieu-Daudé wrote:
>>> On 9/1/21 5:53 PM, Daniel P. Berrangé wrote:
On Wed, Sep 01, 2021 at 05:35:42PM +0200, Philippe Mathieu-Daudé wrote:
> On
This avoids the following assertion when the kernel initializes X.509
certificates:
[7.315373] Loading compiled-in X.509 certificates
qemu-system-arm: ../tcg/tcg.c:3063: temp_allocate_frame: Assertion `align <=
TCG_TARGET_STACK_ALIGN' failed.
Fixes: commit c1c091948ae
Resolves: https://bugzi
v9fs_walk() utilizes the v9fs_co_run_in_worker({...}) macro to run the
supplied fs driver code block on a background worker thread.
When either the 'Twalk' client request was interrupted or if the client
requested fid for that 'Twalk' request caused a stat error then that
fs driver code block was
On Wed, Sep 01, 2021 at 06:27:37PM +0200, Cédric Le Goater wrote:
> On 9/1/21 6:24 PM, Philippe Mathieu-Daudé wrote:
> > On 9/1/21 5:53 PM, Daniel P. Berrangé wrote:
> >> On Wed, Sep 01, 2021 at 05:35:42PM +0200, Philippe Mathieu-Daudé wrote:
> >>> On 9/1/21 5:21 PM, Daniel P. Berrangé wrote:
> >>>
On Wed, 01 Sep 2021 18:07:39 +0200
Christian Schoenebeck wrote:
> On Mittwoch, 1. September 2021 17:41:02 CEST Greg Kurz wrote:
> > On Wed, 01 Sep 2021 16:21:06 +0200
> >
> > Christian Schoenebeck wrote:
> > > On Mittwoch, 1. September 2021 14:49:37 CEST Christian Schoenebeck wrote:
> > > > > >
On 9/1/21 6:24 PM, Philippe Mathieu-Daudé wrote:
> On 9/1/21 5:53 PM, Daniel P. Berrangé wrote:
>> On Wed, Sep 01, 2021 at 05:35:42PM +0200, Philippe Mathieu-Daudé wrote:
>>> On 9/1/21 5:21 PM, Daniel P. Berrangé wrote:
On Wed, Sep 01, 2021 at 04:17:48PM +0100, Peter Maydell wrote:
> On We
On 9/1/21 5:27 PM, Peter Maydell wrote:
> Fix a typo in the help message printed by vhost-user-bridge.
>
> Signed-off-by: Peter Maydell
> ---
> tests/vhost-user-bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
On 9/1/21 6:38 PM, Peter Delevoryas wrote:
>
>> On Sep 1, 2021, at 9:19 AM, Cédric Le Goater wrote:
>>
>> On 9/1/21 5:36 PM, p...@fb.com wrote:
>>> From: Peter Delevoryas
>>>
>>> When you run QEMU with an Aspeed machine and a single serial device
>>> using stdio like this:
>>>
>>>qemu -mach
While mtree_info() handles both ASes and flatviews cases,
the two cases share basically no code. Split mtree_info_flatview()
out of mtree_info() to simplify.
Note: Patch easier to review using 'git-diff --color-moved=blocks'.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
---
On 9/1/21 6:27 PM, Cédric Le Goater wrote:
> On 9/1/21 6:24 PM, Philippe Mathieu-Daudé wrote:
>> On 9/1/21 5:53 PM, Daniel P. Berrangé wrote:
>>> On Wed, Sep 01, 2021 at 05:35:42PM +0200, Philippe Mathieu-Daudé wrote:
On 9/1/21 5:21 PM, Daniel P. Berrangé wrote:
> On Wed, Sep 01, 2021 at 0
On Mittwoch, 1. September 2021 17:41:02 CEST Greg Kurz wrote:
> On Wed, 01 Sep 2021 16:21:06 +0200
>
> Christian Schoenebeck wrote:
> > On Mittwoch, 1. September 2021 14:49:37 CEST Christian Schoenebeck wrote:
> > > > > And it triggered, however I am not sure if some of those functions I
> > > >
When introducing yank functionality in the migration code I forgot
to cover the multifd send side.
Signed-off-by: Lukas Straub
Tested-by: Leonardo Bras
Reviewed-by: Leonardo Bras
---
-v2:
-add Tested-by and Reviewed-by tags
migration/multifd.c | 6 +-
migration/multifd.h | 2 ++
2 files
On 9/1/21 5:36 PM, p...@fb.com wrote:
> From: Peter Delevoryas
>
> v1: https://lore.kernel.org/qemu-devel/20210831233140.2659116-1-p...@fb.com/
> v2:
> - Replaced AspeedMachineClass "serial_hd0" with "uart_default"
> - Removed "qdev_get_machine()" usage
> - Removed unnecessary aspeed.h (machine c
Follow Peter Maydell suggestions:
- Split mtree_info() as mtree_info_flatview() + mtree_info_as()
- Remove duplicated Address Space information
Since v3:
- Fix typos
- Split mtree_info_flatview() + mtree_info_as() first
- Rebased last patch keeping Peter's R-b tag
Philippe Mathieu-Daudé (3):
me
On Wed, Sep 01, 2021 at 09:50:56AM +0100, Daniel P. Berrangé wrote:
> On Tue, Aug 31, 2021 at 04:27:04PM -0400, Peter Xu wrote:
> > On Tue, Aug 31, 2021 at 01:57:33PM +0100, Daniel P. Berrangé wrote:
> > > On Tue, Aug 31, 2021 at 08:02:38AM -0300, Leonardo Bras wrote:
> > > > MSG_ZEROCOPY is a feat
On 9/1/21 5:21 PM, Daniel P. Berrangé wrote:
> On Wed, Sep 01, 2021 at 04:17:48PM +0100, Peter Maydell wrote:
>> On Wed, 1 Sept 2021 at 15:59, Daniel P. Berrangé wrote:
>>>
>>> On Wed, Sep 01, 2021 at 04:52:29PM +0200, Philippe Mathieu-Daudé wrote:
Properly escape git-describe 'match' pattern
On 8/23/21 11:20 AM, David Hildenbrand wrote:
> On 23.08.21 10:54, Philippe Mathieu-Daudé wrote:
>> Per Peter Maydell [*]:
>>
>> 'info mtree' monitor command was designed on the assumption that
>> there's really only one or two interesting address spaces, and
>> with more recent developmen
The vhost-user-bridge binary accepts a UNIX socket path on
the command line. Sanity check that this is short enough to
fit into a sockaddr_un before copying it in.
Fixes: Coverity CID 1432866
Signed-off-by: Peter Maydell
---
tests/vhost-user-bridge.c | 5 +
1 file changed, 5 insertions(+)
d
On Thu, Aug 26, 2021 at 07:26:58PM +0200, Philippe Mathieu-Daudé wrote:
Both virtqueue_packed_get_avail_bytes() and
virtqueue_split_get_avail_bytes() access the region cache, but
their caller also does. Simplify by having virtqueue_get_avail_bytes
calling both with RCU lock held, and passing the
On Wed, Sep 01, 2021 at 04:44:30PM +0100, Daniel P. Berrangé wrote:
> QEMU has mptcp support already:
>
> commit 8bd1078aebcec5eac196a83ef1a7e74be0ba67b7
> Author: Dr. David Alan Gilbert
> Date: Wed Apr 21 12:28:34 2021 +0100
>
> sockets: Support multipath TCP
>
> Multipath
On 9/1/21 4:39 PM, Peter Maydell wrote:
> Coverity points out that we aren't checking the return value
> from curl_easy_setopt().
>
> Fixes: Coverity CID 1458895
> Signed-off-by: Peter Maydell
> ---
> contrib/elf2dmp/download.c | 28 +---
> 1 file changed, 17 insertions(+
1 - 100 of 380 matches
Mail list logo
