[Bug 1885350] Re: RISCV dynamic rounding mode is not behaving correctly

2021-07-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885350 Title: RISCV dynam

[Bug 1886306] Re: qemu running slow when the window is in background

2021-07-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1886306 Title: qemu runnin

[Bug 1924738] Re: Failed to restore domain - error load load virtio-balloon:virtio

2021-07-16 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1924738 Title: Failed to r

Re: [PATCH 00/17] target/riscv: Use tcg_constant_*

2021-07-16 Thread LIU Zhiwei
On 2021/7/16 上午12:15, Richard Henderson wrote: On 7/15/21 4:21 AM, LIU Zhiwei wrote: Also on a side note, could you give me some advice for the following question? I have been supporting  running 32bit application on qemu-riscv64. After this patch set, it is hard to define a  method,  such a

Re: [PATCH v6 2/2] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

2021-07-16 Thread Hyman
在 2021/7/17 3:36, Peter Xu 写道: On Fri, Jul 16, 2021 at 07:13:47PM +0800, huang...@chinatelecom.cn wrote: +static void calculate_dirtyrate_dirty_bitmap(struct DirtyRateConfig config) +{ +int64_t msec = 0; +int64_t start_time; +DirtyPageRecord dirty_pages; [1] + +dirtyrate_g

[PATCH 1/2] python/qmp: add send_fd_scm directly to QEMUMonitorProtocol

2021-07-16 Thread John Snow
It turns out you can do this directly from Python ... and because of this, you don't need to worry about setting the fds, or spawning another process. Doing this is helpful because it allows QEMUMonitorProtocol to keep its file descriptor and socket object as private implementation details, which

[PATCH 2/2] python, iotests: remove socket_scm_helper

2021-07-16 Thread John Snow
It's not used anymore, now. Signed-off-by: John Snow --- tests/qemu-iotests/socket_scm_helper.c | 136 - python/qemu/machine/machine.py | 3 - python/qemu/machine/qtest.py | 2 - tests/Makefile.include | 1 - tests/meson.build

[PATCH 0/2] remove socket_scm_helper

2021-07-16 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-socket-scm-helper CI: https://gitlab.com/jsnow/qemu/-/pipelines/338595177 19 insertions(+) 208 deletions(-) Seems good to me ...? --js John Snow (2): python/qmp: add send_fd_scm directly to QEMUMonitorProtocol python, iotests: remove so

[PATCH v2 11/11] accel/tcg: Push trace info building into atomic_common.c.inc

2021-07-16 Thread Richard Henderson
Use trace_mem_get_info instead of trace_mem_build_info, using the TCGMemOpIdx that we already have. Do this in the atomic_trace_*_pre function as common subroutines. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 48 +-- accel/tcg/atomic_com

[PATCH v2 10/11] trace: Fold mem-internal.h into mem.h

2021-07-16 Thread Richard Henderson
Since the last thing that mem.h does is include mem-internal.h, the symbols are not actually private. Signed-off-by: Richard Henderson --- trace/mem-internal.h | 50 trace/mem.h | 50 ++-- 2 files chang

[PATCH v2 09/11] accel/tcg: Expand ATOMIC_MMU_LOOKUP_*

2021-07-16 Thread Richard Henderson
Unify the parameters of atomic_mmu_lookup between cputlb.c and user-exec.c. Call the function directly, and remove the macros. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 41 + accel/tcg/cputlb.c | 7 +-- accel/tcg/user-ex

[PATCH v2 05/11] tcg: Rename helper_atomic_*_mmu and provide for user-only

2021-07-16 Thread Richard Henderson
Always provide the atomic interface using TCGMemOpIdx oi and uintptr_t retaddr. Rename from helper_* to cpu_* so as to (mostly) match the exec/cpu_ldst.h functions, and to emphasize that they are not callable from TCG directly. Signed-off-by: Richard Henderson --- include/tcg/tcg.h

[PATCH v2 06/11] accel/tcg: Standardize atomic helpers on softmmu api

2021-07-16 Thread Richard Henderson
Reduce the amount of code duplication by always passing the TCGMemOpIdx argument to helper_atomic_*. This is not currently used for user-only, but it's easy to ignore. Signed-off-by: Richard Henderson --- accel/tcg/tcg-runtime.h | 46 --- accel/tcg/cputlb.c

[PATCH v2 04/11] qemu/atomic: Add aligned_{int64,uint64}_t types

2021-07-16 Thread Richard Henderson
Use it to avoid some clang-12 -Watomic-alignment errors, forcing some structures to be aligned and as a pointer when we have ensured that the address is aligned. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 4 ++-- include/qemu/atomic.h | 14 +- include/q

[PATCH v2 07/11] accel/tcg: Fold EXTRA_ARGS into atomic_template.h

2021-07-16 Thread Richard Henderson
All instances of EXTRA_ARGS are now identical. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 36 accel/tcg/cputlb.c | 1 - accel/tcg/user-exec.c | 1 - 3 files changed, 20 insertions(+), 18 deletions(-) diff --git a/acce

[PATCH v2 02/11] qemu/atomic: Simplify typeof_strip_qual

2021-07-16 Thread Richard Henderson
The right-hand side of the comma operator has the type quals stripped without also undergoing implicit promotion. Signed-off-by: Richard Henderson --- include/qemu/atomic.h | 41 - 1 file changed, 4 insertions(+), 37 deletions(-) diff --git a/include/qemu

[PATCH v2 01/11] qemu/atomic: Use macros for CONFIG_ATOMIC64

2021-07-16 Thread Richard Henderson
Clang warnings about questionable atomic usage get localized to the inline function in atomic.h. By using a macro, we get the full traceback to the original use that caused the warning. Signed-off-by: Richard Henderson --- include/qemu/atomic.h | 25 + 1 file changed, 5

[PATCH v2 00/11] Atomic cleanup + clang-12 build fix

2021-07-16 Thread Richard Henderson
This is intended to fix building with clang-12 on i386. Version 2 bears little relation to version 1, in that I no longer turn off the warning, which merely hid the problem until link time failed to find libatomic symbols. In the process, I found bugs wrt handling of guest memory in target/ with

[PATCH v2 08/11] accel/tcg: Remove ATOMIC_MMU_DECLS

2021-07-16 Thread Richard Henderson
All definitions are now empty. Signed-off-by: Richard Henderson --- accel/tcg/atomic_template.h | 12 accel/tcg/cputlb.c | 1 - accel/tcg/user-exec.c | 1 - 3 files changed, 14 deletions(-) diff --git a/accel/tcg/atomic_template.h b/accel/tcg/atomic_template.h inde

[PATCH v2 03/11] qemu/atomic: Remove pre-C11 atomic fallbacks

2021-07-16 Thread Richard Henderson
We now require c11, so the fallbacks are now dead code Signed-off-by: Richard Henderson --- configure | 7 -- include/qemu/atomic.h | 204 +++--- 2 files changed, 10 insertions(+), 201 deletions(-) diff --git a/configure b/configure index 4d0a2b

[PATCH v2 22/24] python/aqmp: add asyncio_run compatibility wrapper

2021-07-16 Thread John Snow
As a convenience. It isn't used by the library itself, but it is used by the test suite. It will also come in handy for users of the library still on Python 3.6. Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/python/

[PATCH v2 23/24] python/aqmp: add scary message

2021-07-16 Thread John Snow
Add a warning whenever AQMP is used to steer people gently away from using it for the time-being. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 14 ++ 1 file changed, 14 insertions(+) diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py index ef2903

[PATCH v2 21/24] python/aqmp: add _raw() execution interface

2021-07-16 Thread John Snow
This is added in anticipation of wanting it for a synchronous wrapper for the iotest interface. Normally, execute() and execute_msg() both raise QMP errors in the form of Python exceptions. Many iotests expect the entire reply as-is. To reduce churn there, add a private execution interface that wi

[PATCH v2 20/24] python/aqmp: add execute() interfaces

2021-07-16 Thread John Snow
Add execute() and execute_msg(). _execute() is split into _issue() and _reply() halves so that hypothetical subclasses of QMP that want to support different execution paradigms can do so. I anticipate a synchronous interface may have need of separating the send/reply phases. However, I do not wis

[PATCH v2 17/24] python/aqmp: add QMP protocol support

2021-07-16 Thread John Snow
The star of our show! Add most of the QMP protocol, sans support for actually executing commands. No problem, that happens in the next several commits. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 2 + python/qemu/aqmp/qmp_client.py | 264 + 2

[PATCH v2 19/24] python/aqmp: Add message routing to QMP protocol

2021-07-16 Thread John Snow
Add the ability to handle and route messages in qmp_protocol.py. The interface for actually sending anything still isn't added until next commit. Signed-off-by: John Snow --- python/qemu/aqmp/qmp_client.py | 122 - 1 file changed, 120 insertions(+), 2 deletions(-)

[PATCH v2 11/24] python/aqmp: add _cb_inbound and _cb_inbound logging hooks

2021-07-16 Thread John Snow
Add hooks designed to log/filter incoming/outgoing messages. The primary intent for these is to be able to support iotests which may want to log messages with specific filters for reproducible output. Another use is for plugging into Urwid frameworks; all messages in/out can be automatically added

[PATCH v2 24/24] python/aqmp: add AsyncProtocol unit tests

2021-07-16 Thread John Snow
This tests most of protocol.py -- From a hacked up Coverage.py run, it's at about 86%. There's a few error cases that aren't very well tested yet, they're hard to induce artificially so far. I'm working on it. Signed-off-by: John Snow --- python/tests/null_proto.py | 67 ++ python/tests/pro

[PATCH v2 14/24] python/aqmp: add well-known QMP object models

2021-07-16 Thread John Snow
The QMP spec doesn't define very many objects that are iron-clad in their format, but there are a few. This module makes it trivial to validate them without relying on an external third-party library. Signed-off-by: John Snow --- python/qemu/aqmp/models.py | 133 +

[PATCH v2 10/24] python/aqmp: add configurable read buffer limit

2021-07-16 Thread John Snow
QMP can transmit some pretty big messages, and the default limit of 64KB isn't sufficient. Make sure that we can configure it. Reported-by: G S Niteesh Babu Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff

[PATCH v2 16/24] python/pylint: disable too-many-function-args

2021-07-16 Thread John Snow
too-many-function-args seems prone to failure when considering things like Method Resolution Order, which mypy gets correct. When dealing with multiple inheritance, pylint doesn't seem to understand which method will actually get called, while mypy does. Remove the less powerful, redundant check.

[PATCH v2 15/24] python/aqmp: add QMP event support

2021-07-16 Thread John Snow
This class was designed as a "mix-in" primarily so that the feature could be given its own treatment in its own python module. It gets quite a bit too long otherwise. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 2 + python/qemu/aqmp/events.py | 706 ++

[PATCH v2 08/24] python/aqmp: add logging to AsyncProtocol

2021-07-16 Thread John Snow
Give the connection and the reader/writer tasks nicknames, and add logging statements throughout. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 71 1 file changed, 64 insertions(+), 7 deletions(-) diff --git a/python/qemu/aqmp/protocol.py b/pyt

[PATCH v2 04/24] python/aqmp: add asyncio compatibility wrappers

2021-07-16 Thread John Snow
Python 3.6 does not have all of the goodies that Python 3.7 does, and I need to support both. Add some compatibility wrappers needed for this purpose. (Note: Python 3.6 is EOL December 2021.) Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 106 +++ 1

[PATCH v2 13/24] python/aqmp: add QMP Message format

2021-07-16 Thread John Snow
The Message class is here primarily to serve as a solid type to use for mypy static typing for unambiguous annotation and documentation. We can also stuff JSON serialization and deserialization into this class itself so it can be re-used even outside this infrastructure. Signed-off-by: John Snow

[PATCH v2 18/24] python/pylint: disable no-member check

2021-07-16 Thread John Snow
mypy handles this better -- but we only need the workaround because pylint under Python 3.6 does not understand that a MutableMapping really does have a .get() method attached. We could remove this again once 3.7 is our minimum. Signed-off-by: John Snow --- python/setup.cfg | 1 + 1 file change

[PATCH v2 05/24] python/aqmp: add generic async message-based protocol support

2021-07-16 Thread John Snow
This is the bare minimum that you need to establish a full-duplex async message-based protocol with Python's asyncio. The features to be added in forthcoming commits are: - Runstate tracking - Logging - Support for incoming connections via accept() - _cb_outbound, _cb_inbound message hooks - _rea

[PATCH v2 03/24] python/pylint: Add exception for TypeVar names ('T')

2021-07-16 Thread John Snow
'T' is a common TypeVar name, allow its use. See also https://github.com/PyCQA/pylint/issues/3401 -- In the future, we might be able to have a separate list of acceptable names for TypeVars exclusively. Signed-off-by: John Snow --- python/setup.cfg | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH v2 01/24] python/aqmp: add asynchronous QMP (AQMP) subpackage

2021-07-16 Thread John Snow
For now, it's empty! Soon, it won't be. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 27 +++ python/qemu/aqmp/py.typed| 0 python/setup.cfg | 1 + 3 files changed, 28 insertions(+) create mode 100644 python/qemu/aqmp/__init__.py create m

[PATCH v2 12/24] python/aqmp: add AsyncProtocol._readline() method

2021-07-16 Thread John Snow
This is added as a courtesy: many protocols are line-based, including QMP. Putting it in AsyncProtocol lets us keep the QMP class implementation just a pinch more abstract. (And, if we decide to add a QTEST implementation later, it will need this, too. (Yes, I have a QTEST implementation.)) Signe

[PATCH v2 07/24] python/aqmp: Add logging utility helpers

2021-07-16 Thread John Snow
Signed-off-by: John Snow --- python/qemu/aqmp/util.py | 56 1 file changed, 56 insertions(+) diff --git a/python/qemu/aqmp/util.py b/python/qemu/aqmp/util.py index 88abfc9eb22..70ef94ad600 100644 --- a/python/qemu/aqmp/util.py +++ b/python/qemu/aqmp/util.

[PATCH v2 06/24] python/aqmp: add runstate state machine to AsyncProtocol

2021-07-16 Thread John Snow
This serves a few purposes: 1. Protect interfaces when it's not safe to call them (via @require) 2. Add an interface by which an async client can determine if the state has changed, for the purposes of connection management. Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 5 +- p

[PATCH v2 02/24] python/aqmp: add error classes

2021-07-16 Thread John Snow
Signed-off-by: John Snow --- python/qemu/aqmp/__init__.py | 4 +++ python/qemu/aqmp/error.py| 50 2 files changed, 54 insertions(+) create mode 100644 python/qemu/aqmp/error.py diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py ind

[PATCH v2 09/24] python/aqmp: add AsyncProtocol.accept() method

2021-07-16 Thread John Snow
It's a little messier than connect, because it wasn't designed to accept *precisely one* connection. Such is life. Signed-off-by: John Snow --- python/qemu/aqmp/protocol.py | 89 ++-- 1 file changed, 85 insertions(+), 4 deletions(-) diff --git a/python/qemu/aqmp/

[PATCH v2 00/24] python: introduce Asynchronous QMP package

2021-07-16 Thread John Snow
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-async-qmp-aqmp CI: https://gitlab.com/jsnow/qemu/-/pipelines/338508045 Docs: https://people.redhat.com/~jsnow/sphinx/html/qemu.aqmp.html Hi! This patch series adds an Asynchronous QMP package to the Python library. It offers a few improvement

[PATCH 1/2 v4] Configure script for Haiku

2021-07-16 Thread Richard Zak
This refers to the email from a few weeks ago, regarding TPM & Haiku. It seems the assertion failure isn't really about the TPM, but about disabling PIE and adding -fPIC. There's discussion on the Haiku forum[1] about the incompatibility with PIE, and this fixes the assertion failure without alteri

Uninitialized variables err during dev

2021-07-16 Thread Kenneth Adam Miller
Hello all, I'm getting a strange error while doing some system target development. In the periphery of the qemu internals (things specifically other than the target), I'm getting uninitialized variable errors. I'm pretty sure I can't submit a patch to modify those internals, so I was wondering how

RE: [PATCH 4/4] ui/gtk-egl: guest fb texture needs to be regenerated when reinitializing egl

2021-07-16 Thread Kasireddy, Vivek
> > If guest fb is backed by dmabuf (blob-resource), the texture bound to the old > context needs > to be recreated in case the egl is re-initialized (e.g. > new window for vc is created in case of detaching/reattaching of the tab) > > Signed-off-by: Dongwon Kim > --- > ui/gtk-egl.c | 4 >

RE: [PATCH 2/3] ui/gtk-egl: make sure the right context is set as the current

2021-07-16 Thread Kasireddy, Vivek
Acknowledged-by: Vivek Kasireddy > -Original Message- > From: Qemu-devel On > Behalf Of Dongwon Kim > Sent: Friday, July 02, 2021 5:28 PM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon > Subject: [PATCH 2/3] ui/gtk-egl: make sure the right context is set as the > current > > Making t

Re: [PATCH for-6.2 19/34] target/arm: Move 'x' and 'a' bit definitions into vmlaldav formats

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: All the users of the vmlaldav formats have an 'x bit in bit 12 and an 'a' bit in bit 5; move these to the format rather than specifying them in each insn pattern. Signed-off-by: Peter Maydell --- Not sure why I didn't write it this way in the first place;

Re: [PATCH for-6.2 18/34] target/arm: Implement MVE shift-by-scalar

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE instructions which perform shifts by a scalar. These are VSHL T2, VRSHL T2, VQSHL T1 and VQRSHL T2. They take the shift amount in a general purpose register and shift every element in the vector by that amount. Mostly we can reuse the h

Re: [PATCH for-6.2 17/34] target/arm: Implement MVE VMLAS

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE VMLAS insn, which multiplies a vector by a vector and adds a scalar. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 31

RE: [PATCH 1/3] ui/gtk-egl: un-tab and re-tab should destroy egl surface and context

2021-07-16 Thread Kasireddy, Vivek
Reviewed-by: Vivek Kasireddy > -Original Message- > From: Qemu-devel On > Behalf Of Dongwon Kim > Sent: Friday, July 02, 2021 5:28 PM > To: qemu-devel@nongnu.org > Cc: Romli, Khairul Anuar ; Kim, Dongwon > > Subject: [PATCH 1/3] ui/gtk-egl: un-tab and re-tab should destroy egl surface

Re: [PATCH for-6.2 16/34] target/arm: Implement MVE VPSEL

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE VPSEL insn, which sets each byte of the destination vector Qd to the byte from either Qn or Qm depending on the value of the corresponding bit in VPR.P0. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 2 ++ target/arm/

Re: [PATCH for-6.2 15/34] target/arm: Implement MVE integer vector-vs-scalar comparisons

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE integer vector comparison instructions that compare each element against a scalar from a general purpose register. These are "VCMP (vector)" encodings T4, T5 and T6 and "VPT (vector)" encodings T4, T5 and T6. We have to move the decodet

RE: [PATCH 3/3] ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound

2021-07-16 Thread Kasireddy, Vivek
Reviewed-by: Vivek Kasireddy > -Original Message- > From: Qemu-devel On > Behalf Of Dongwon Kim > Sent: Friday, July 02, 2021 5:28 PM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon > Subject: [PATCH 3/3] ui/gtk: gd_draw_event returns FALSE when no cairo > surface is > bound > > gd_dr

Re: [PATCH for-6.2 14/34] target/arm: Implement MVE integer vector comparisons

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE integer vector comparison instructions. These are "VCMP (vector)" encodings T1, T2 and T3, and "VPT (vector)" encodings T1, T2 and T3. These insns compare corresponding elements in each vector, and update the VPR.P0 predicate bits with

Re: [PATCH v5 3/5] block/nbd: refactor nbd_recv_coroutines_wake_all()

2021-07-16 Thread Eric Blake
On Wed, Jul 14, 2021 at 07:59:14PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Split out nbd_recv_coroutine_wake(), as it will be used in separate. s/in separate/separately/ > Also add a possibility to wake only first found sleeping coroutine. > > Signed-off-by: Vladimir Sementsov-Ogievskiy >

Re: [PATCH for-6.2 13/34] target/arm: Factor out gen_vpst()

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Factor out the "generate code to update VPR.MASK01/MASK23" part of trans_VPST(); we are going to want to reuse it for the VPT insns. Signed-off-by: Peter Maydell --- target/arm/translate-mve.c | 31 +-- 1 file changed, 17 in

Re: [PATCH V5 17/25] vfio-pci: cpr part 2

2021-07-16 Thread Alex Williamson
On Wed, 7 Jul 2021 10:20:26 -0700 Steve Sistare wrote: > Finish cpr for vfio-pci by preserving eventfd's and vector state. > > Signed-off-by: Steve Sistare > --- > hw/vfio/pci.c | 118 > +- > 1 file changed, 116 insertions(+), 2 deletio

Re: [PATCH v5 2/5] block/nbd: move nbd_recv_coroutines_wake_all() up

2021-07-16 Thread Eric Blake
On Wed, Jul 14, 2021 at 07:59:13PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We are going to use it in nbd_channel_error(), so move it up. Note, > that we are going also refactor and rename > nbd_recv_coroutines_wake_all() in future anyway, so keeping it where it > is and making forward declarat

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2021 21:47, Vladimir Sementsov-Ogievskiy wrote: 16.07.2021 19:21, Vladimir Sementsov-Ogievskiy wrote: 15.07.2021 23:00, Vladimir Sementsov-Ogievskiy wrote: 03.07.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: +Permission bytes. If permission byte is rd-locked, it means that some process

Re: [PATCH v5 1/5] block/nbd: nbd_channel_error() shutdown channel unconditionally

2021-07-16 Thread Eric Blake
On Wed, Jul 14, 2021 at 07:59:12PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Don't rely on connection being totally broken in case of -EIO. More > safe and correct just shutdown the channel anyway, as we change the > state and going to reconnect. > > Signed-off-by: Vladimir Sementsov-Ogievskiy

[Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

2021-07-16 Thread Thomas Huth
Ok, thanks, then let's close this (and open new tickets on gitlab if it happens again) ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1889

Re: QEMU System and User targets

2021-07-16 Thread Kenneth Adam Miller
After checking around, I don't see any _user_ss in any target directory. And I only see *_user_ss in the linux-user subdirectory. Were you talking about that meson.build in linux-user? On Fri, Jul 16, 2021 at 1:20 PM Kenneth Adam Miller < kennethadammil...@gmail.com> wrote: > Right, that's what I

Re: [PATCH for-6.2 12/34] target/arm: Implement MVE incrementing/decrementing dup insns

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: +#define DO_VIDUP(OP, ESIZE, TYPE, FN) \ +uint32_t HELPER(mve_##OP)(CPUARMState *env, void *vd, \ + uint32_t offset, uint32_t imm) \ +{

Re: [PATCH v6 2/2] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation

2021-07-16 Thread Peter Xu
On Fri, Jul 16, 2021 at 07:13:47PM +0800, huang...@chinatelecom.cn wrote: > +static void calculate_dirtyrate_dirty_bitmap(struct DirtyRateConfig config) > +{ > +int64_t msec = 0; > +int64_t start_time; > +DirtyPageRecord dirty_pages; [1] > + > +dirtyrate_global_dirty_log_start();

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-16 Thread Vladimir Sementsov-Ogievskiy
16.07.2021 19:21, Vladimir Sementsov-Ogievskiy wrote: 15.07.2021 23:00, Vladimir Sementsov-Ogievskiy wrote: 03.07.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: +Permission bytes. If permission byte is rd-locked, it means that some process +uses corresponding permission on that file. + +Byte  

Re: QEMU System and User targets

2021-07-16 Thread Kenneth Adam Miller
Right, that's what I was thinking, that I shouldn't be building that for the system target. That's why I started out with the question that I did, because I was thinking that it probably hard codes it to user emulation. Currently though, understanding qemu internals is not so clear to me as I'm jus

Re: QEMU System and User targets

2021-07-16 Thread Peter Maydell
On Fri, 16 Jul 2021 at 18:50, Kenneth Adam Miller wrote: > There's a lot of files and I don't want to muddy up the discussion with too > many details. If you don't provide details, you get vague answers. Your choice :-) > And for sure, this is not a problem with the upstream qemu. I'm working o

Re: QEMU System and User targets

2021-07-16 Thread Kenneth Adam Miller
There's a lot of files and I don't want to muddy up the discussion with too many details. And for sure, this is not a problem with the upstream qemu. I'm working on adding a target, and this is just what I'm experiencing. As for my target, it has includes that correspond to finds within sub-direct

Re: [PULL v3 00/19] pc,pci,virtio: lots of new features

2021-07-16 Thread Peter Maydell
On Fri, 16 Jul 2021 at 16:15, Michael S. Tsirkin wrote: > > The following changes since commit bd306cfeeececee73ff2cdb3de1229ece72f3b28: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210714.0' > into staging (2021-07-15 21:39:04 +0100) > > are available in the Git reposi

Re: [PATCH V5 16/25] vfio-pci: cpr part 1

2021-07-16 Thread Alex Williamson
On Wed, 7 Jul 2021 10:20:25 -0700 Steve Sistare wrote: > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index 9220e64..40c882f 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -31,6 +31,7 @@ > #include "exec/memory.h" > #include "exec/ram_addr.h" > #include "hw/hw.h" > +#inclu

[Bug 1892761] Re: Heap-use-after-free through double-fetch in ehci

2021-07-16 Thread Thomas Huth
Ok, let's close this one since it was not reproducible. If you find a reproducer, please open a new ticket in the gitlab tracker instead. ** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

[Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

2021-07-16 Thread Alexander Bulekov
I believe these were all taken care of by edfe2eb436 ("hw/intc/arm_gic: Fix interrupt ID in GICD_SGIR register") 09bbdb89bc ("hw/intc/arm_gic: Allow to use QTest without crashing") -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Bug 1918975] Re: [Feature request] Propagate interpreter to spawned processes

2021-07-16 Thread Thomas Huth
*** This bug is a duplicate of bug 1912107 *** https://bugs.launchpad.net/bugs/1912107 I think one ticket should be enough to track this problem, so let's continue the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/306 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issue

[Bug 1889621] Re: ARM Highbank Crashes Realted to GIC

2021-07-16 Thread Thomas Huth
Can you still reproduce one of these issues with the current master branch of QEMU? For me, all three reproduces do not seem to cause any trouble anymore... ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml

Re: [PATCH for-6.2 11/34] target/arm: Implement MVE VMULL (polynomial)

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: Implement the MVE VMULL (polynomial) insn. Unlike Neon, this comes in two flavours: 8x8->16 and a 16x16->32. Also unlike Neon, the inputs are in either the low or the high half of each double-width element. The assembler for this insn indicates the size

Re: [PATCH for-6.2 10/34] target/arm: Fix VLDRB/H/W for predicated elements

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: For vector loads, predicated elements are zeroed, instead of retaining their previous values (as happens for most data processing operations). This means we need to distinguish "beat not executed due to ECI" (don't touch destination element) from "beat exe

Re: [PATCH for-6.2 08/34] target/arm: Fix VPT advance when ECI is non-zero

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: if (mask01 > 8) { -/* high bit set, but not 0b1000: invert the relevant half of P0 */ -vpr ^= 0xff; +if (eci == ECI_NONE) { +/* high bit set, but not 0b1000: invert the relevant half of P0 */ +vpr ^= 0x

Re: [PATCH for-6.2 09/34] target/arm: Factor out mve_eci_mask()

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: In some situations we need a mask telling us which parts of the vector correspond to beats that are not being executed because of ECI, separately from the combined "which bytes are predicated away" mask. Factor this mask calculation out of mve_element_mas

Re: [PATCH for-6.2 08/34] target/arm: Fix VPT advance when ECI is non-zero

2021-07-16 Thread Richard Henderson
On 7/13/21 6:37 AM, Peter Maydell wrote: We were not paying attention to the ECI state when advancing the VPT state. Architecturally, VPT state advance happens for every beat (see the pseudocode VPTAdvance()), so on every beat the 4 bits of VPR.P0 corresponding to the current beat are inverted i

Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts

2021-07-16 Thread Peter Maydell
On Fri, 16 Jul 2021 at 17:34, Richard Henderson wrote: > > On 7/13/21 6:36 AM, Peter Maydell wrote: > > -return (1ULL << 47) - (src >= 0); > > +return sextract64((1ULL << 47) - (src >= 0), 0, 48); > > Clearer as > >return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17); Ye

Re: [PATCH for-6.2 07/34] target/arm: Fix calculation of LTP mask when LR is 0

2021-07-16 Thread Richard Henderson
On 7/13/21 6:36 AM, Peter Maydell wrote: In mve_element_mask(), we calculate a mask for tail predication which should have a number of 1 bits based on the value of LR. However, our MAKE_64BIT_MASK() macro has undefined behaviour when passed a zero length. Special case this to give the all-zeroe

Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts

2021-07-16 Thread Richard Henderson
On 7/13/21 6:36 AM, Peter Maydell wrote: -return (1ULL << 47) - (src >= 0); +return sextract64((1ULL << 47) - (src >= 0), 0, 48); Clearer as return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17); ? Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH for-6.2 05/34] target/arm: Fix mask handling for MVE narrowing operations

2021-07-16 Thread Richard Henderson
On 7/13/21 6:36 AM, Peter Maydell wrote: In the MVE helpers for the narrowing operations (DO_VSHRN and DO_VSHRN_SAT) we were using the wrong bits of the predicate mask for the 'top' versions of the insn. This is because the loop works over the double-sized input elements and shifts the predicate

Re: [PATCH for-6.2 03/34] target/arm: Fix MVE VSLI by 0 and VSRI by

2021-07-16 Thread Richard Henderson
On 7/13/21 6:36 AM, Peter Maydell wrote: if (shift == 0 || shift == ESIZE * 8) { \ /* \ * Only VSLI can shift by 0; only VSRI can shift by . \ * The generic log

Re: [PATCH v2] docs: document file-posix locking protocol

2021-07-16 Thread Vladimir Sementsov-Ogievskiy
15.07.2021 23:00, Vladimir Sementsov-Ogievskiy wrote: 03.07.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: +Permission bytes. If permission byte is rd-locked, it means that some process +uses corresponding permission on that file. + +Byte    Operation +100 read +  Lock holder can re

Re: [PATCH v2 05/21] contrib/gitdm: add some new aliases to fix up commits

2021-07-16 Thread Richard Henderson
On 7/14/21 11:20 AM, Alex Bennée wrote: Signed-off-by: Alex Bennée Cc: Yuval Shaia Message-Id:<20210714093638.21077-6-alex.ben...@linaro.org> --- contrib/gitdm/aliases | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 04/21] configure: remove needless if leg

2021-07-16 Thread Richard Henderson
On 7/14/21 11:20 AM, Alex Bennée wrote: It was pointed out in review of the previous patch that the if leg isn't needed as the for loop will not enter on an empty $device_archs. Fixes: d1d5e9eefd ("configure: allow the selection of alternate config in the build") Signed-off-by: Alex Bennée Mess

Re: [PATCH v3 1/2] Hexagon (target/hexagon) remove put_user_*/get_user_*

2021-07-16 Thread Richard Henderson
On 7/15/21 2:22 PM, Taylor Simpson wrote: Replace put_user_* with cpu_st*_data_ra Replace get_user_* with cpu_ld*_data_ra Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/op_helper.c | 39 ++- 1 file changed, 18 insertions(+)

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Richard Henderson
On 7/16/21 8:31 AM, Christian Borntraeger wrote: On 16.07.21 16:58, Christian Borntraeger wrote: On 16.07.21 16:51, Richard Henderson wrote: On 7/16/21 4:28 AM, Christian Borntraeger wrote:   --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now" Full configure line is ../configu

Re: [PATCH] qtest/hyperv: Introduce a simple hyper-v test

2021-07-16 Thread Andrew Jones
On Fri, Jul 16, 2021 at 02:55:28PM +0200, Vitaly Kuznetsov wrote: > For the beginning, just test 'hv-passthrough' and a couple of custom > Hyper-V enlightenments configurations through QMP. Later, it would > be great to complement this by checking CPUID values from within the > guest. > > Signed-

Re: QEMU System and User targets

2021-07-16 Thread Peter Maydell
On Fri, 16 Jul 2021 at 16:16, Kenneth Adam Miller wrote: > > When I go to build the qemu softmmu target the shared files - the i386_ss of > my arch - gives problems where the build system isn't specifying the include > headers for the compiler to find the surrounding headers that belong to > di

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Christian Borntraeger
On 16.07.21 16:58, Christian Borntraeger wrote: On 16.07.21 16:51, Richard Henderson wrote: On 7/16/21 4:28 AM, Christian Borntraeger wrote:   --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now" Full configure line is ../configure --prefix=/usr --libdir=/usr/lib64

Re: QEMU System and User targets

2021-07-16 Thread Kenneth Adam Miller
When I go to build the qemu softmmu target the shared files - the i386_ss of my arch - gives problems where the build system isn't specifying the include headers for the compiler to find the surrounding headers that belong to different parts of the qemu library. I was able to edit my own source onl

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-16 Thread Kevin Wolf
Am 13.07.2021 um 15:10 hat Stefan Hajnoczi geschrieben: > AIO_WAIT_WHILE() requires that AioContext is acquired according to its > documentation, but I'm not sure that's true anymore. Thread-safe/atomic > primitives are used by AIO_WAIT_WHILE(), so as long as the condition > being waited for is thr

[PULL v3 19/19] vhost-vsock: SOCK_SEQPACKET feature bit support

2021-07-16 Thread Michael S. Tsirkin
From: Arseny Krasnov This adds processing of VIRTIO_VSOCK_F_SEQPACKET features bit. Guest negotiates it with vhost, thus both will know that SOCK_SEQPACKET supported by peer. Signed-off-by: Arseny Krasnov Message-Id: <20210622144747.2949134-1-arseny.kras...@kaspersky.com> Reviewed-by: Stefano G

[PULL v3 16/19] hw/i386/acpi-build: Add DMAR support to bypass iommu

2021-07-16 Thread Michael S. Tsirkin
From: Xingang Wang In DMAR table, the drhd is set to cover all PCI devices when intel_iommu is on. To support bypass iommu feature, we need to walk the PCI bus with bypass_iommu disabled and add explicit scope data in DMAR drhd structure. /mnt/sdb/wxg/qemu-next/qemu/build/x86_64-softmmu/qemu-sys

[PULL v3 18/19] docs: Add documentation for iommu bypass

2021-07-16 Thread Michael S. Tsirkin
From: Xingang Wang Signed-off-by: Xingang Wang Message-Id: <1625748919-52456-10-git-send-email-wangxinga...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/bypass-iommu.txt | 89 +++ 1 file changed, 89 insertions(+

  1   2   3   >