On 19/05/2021 23.32, John Snow wrote:
Copied from Peter Krempa's libvirt template, feature.md.
CC: Peter Krempa
Signed-off-by: John Snow
---
.gitlab/issue_templates/feature_request.md | 13 +
1 file changed, 13 insertions(+)
create mode 100644 .gitlab/issue_templates/feature_r
Such comments make reviewing this file somehow easier.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/virtio/virtio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index e02544b2df7..2b4c6c4b875 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.
On Wed, May 19, 2021 at 06:46:01AM -0700, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20210519125148.27720-1-da...@gibson.dropbear.id.au/
So, these style warnings are actually existing style problems just
being triggered in checkpatch by code motion. Yes we'd like to cle
On Wed, May 19, 2021 at 17:32:01 -0400, John Snow wrote:
> Based loosely on libvirt's template, written by Peter Krempa.
>
> CC: Peter Krempa
> Signed-off-by: John Snow
> ---
> .gitlab/issue_templates/bug.md | 52 ++
> 1 file changed, 52 insertions(+)
> create m
Hi Gerd,
> > +#ifdef CONFIG_LINUX
>
> > +void virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
>
> > +#else
>
> > +void *virtio_gpu_init_udmabuf(struct virtio_gpu_simple_resource *res)
> > +{
> > +/* nothing (stub) */
> > +return NULL
> > +}
>
> Fails to build for !linu
On 19/05/2021 20.45, Philippe Mathieu-Daudé wrote:
'nproc' is not available on FreeBSD:
$ JOBS=$(expr $(nproc) + 1)
bash: line 119: nproc: command not found
expr: syntax error
Instead, use 'sysctl -n hw.ncpu'.
Could we maybe use "getconf _NPROCESSORS_ONLN" instead? ... that might wor
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, May 18, 2021 4:39 AM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster ;
> Daniel P. Berrangé ; Gerd Hoffmann
> ; Li Zhijian ; Zhang Chen
>
> Subject: R
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, May 18, 2021 4:35 AM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster ;
> Daniel P. Berrangé ; Gerd Hoffmann
> ; Li Zhijian ; Zhang Chen
>
> Subject: Re
Save the MSRs being used on source machine and restore them
on destination machine.
Signed-off-by: Yang Weijiang
---
target/i386/machine.c | 161 ++
1 file changed, 161 insertions(+)
diff --git a/target/i386/machine.c b/target/i386/machine.c
index 137604d
CET states are divided into user-mode and supervisor-mode states,
MSR_KVM_GUEST_SSP holds current SHSTK pointer in use, MSR_IA32_U_CET and
MSR_IA32_PL3_SSP are for user-mode states, others are for supervisor-mode
states. Expose access according to current CET supported bits in CPUID
and XSS.
Signe
CET SHSTK and IBT feature are enumerated via CPUID.(EAX=07H,ECX=0H):ECX[bit 7]
and EDX[bit 20]. CET state load/restore at vmentry/vmexit are enabled via
VMX_ENTRY_CTLS[bit 20] and VMX_EXIT_CTLS[bit 28].
Signed-off-by: Yang Weijiang
---
target/i386/cpu.c | 8
1 file changed, 4 insertions
Rename XSAVE related feature-words for introducing XSAVES related
feature-words.
Signed-off-by: Yang Weijiang
---
target/i386/cpu.c | 24
target/i386/cpu.h | 4 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
i
CET Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT) are enumerated
via CPUID.(EAX=07H,ECX=0H):ECX[bit 7] and EDX[bit 20] respectively.
Two CET bits (bit 11 and 12) are defined in MSR_IA32_XSS for XSAVES.
They correspond to CET states in user and supervisor mode respectively.
Signed-off-by: Y
Currently, CPUID.(EAX=0DH,ECX=01H) doesn't enumerate features in XSS
properly, so enable the support. XCR0 bits indicate user-mode XSAVE
components, and XSS bits indicate supervisor-mode XSAVE components.
Signed-off-by: Yang Weijiang
---
target/i386/cpu.c | 68 +++
Control-flow Enforcement Technology (CET) provides protection against
Return/Jump-Oriented Programming (ROP/JOP). It includes two features:
Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT).
This patch series is to enable CET related CPUID report, XSAVES/XRSTORS
support and MSR access etc. for
If the user provides an ELF file that's been linked to a wrong
address, we try to load it, fails, and keep going silently.
Instead,
Display a warning instead, but keep going to not disrupt users
accidentally relying on this 'continues-anyway' behaviour.
Signed-off-by: Philippe Mathieu-Daudé
---
It is more useful to trace the event which will happen,
rather than missing an event that failed. So move the
'write_rom' trace event earlier.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/loader.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/core/loader.c b/hw/co
If a address_space_write() call fails while calling
set_kernel_args(), the guest kernel will boot using
crap data. Avoid that by aborting if this ever occurs.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/boot.c | 53 ---
1 file changed, 42 inse
Various places ignore the MemTxResult indicator of
transaction failed. Fix the easy places.
The rest are the DMA devices, which require deeper
analysis.
Since v2:
- Dropped "accel/kvm: Let KVM_EXIT_MMIO return error"
- Addressed Peter's review comments
Since v1:
- Dropped "exec/memory: Emit warni
On 20/05/2021 04.40, Philippe Mathieu-Daudé wrote:
On 5/14/21 12:25 PM, Thomas Huth wrote:
On 14/05/2021 12.22, Philippe Mathieu-Daudé wrote:
On 5/9/21 6:05 PM, Thomas Huth wrote:
On 07/05/2021 14.41, Paolo Bonzini wrote:
On 07/05/21 11:45, Thomas Huth wrote:
diff --git a/Makefile b/Makefi
On 20-05-21, 05:03, Trilok Soni wrote:
> Thanks Viresh.
>
> Top posting since somehow I am not getting rust-vmm group emails on my
> open-source email ID subscription. I have received Vatsa's email on the
> Hypervisor crate on rust-vmm mailing list but not this one.
> I am not sure you
> are rec
Thanks Viresh.
Top posting since somehow I am not getting rust-vmm group emails on my
open-source email ID subscription. I have received Vatsa's email on the
Hypervisor crate on rust-vmm mailing list but not this one. I am not sure you
are receiving the rust-vmm bi-weekly meeting invites, i2c
On 29-04-21, 12:39, Viresh Kumar wrote:
> On 28-04-21, 17:13, Trilok Soni wrote:
> > Viresh,
> >
> > For rust-vmm, you need to create the new issue in the right project.
> > You can probably pick up vmm-reference project at rust-vmm and ask
> > for the new crate.
>
> Done.
>
> https://github.com
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, May 18, 2021 4:07 AM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster ;
> Daniel P. Berrangé ; Gerd Hoffmann
> ; Li Zhijian ; Zhang Chen
>
> Subject: R
On 5/14/21 12:25 PM, Thomas Huth wrote:
> On 14/05/2021 12.22, Philippe Mathieu-Daudé wrote:
>> On 5/9/21 6:05 PM, Thomas Huth wrote:
>>> On 07/05/2021 14.41, Paolo Bonzini wrote:
On 07/05/21 11:45, Thomas Huth wrote:
>
>
> diff --git a/Makefile b/Makefile
> index bcbbec71a1..3
> -Original Message-
> From: Lukas Straub
> Sent: Tuesday, May 18, 2021 4:04 AM
> To: Zhang, Chen
> Cc: Jason Wang ; qemu-dev de...@nongnu.org>; Eric Blake ; Dr. David Alan
> Gilbert ; Markus Armbruster ;
> Daniel P. Berrangé ; Gerd Hoffmann
> ; Li Zhijian ; Zhang Chen
>
> Subject: R
On Wed, 19 May 2021, John Snow wrote:
On 5/18/21 7:05 PM, BALATON Zoltan wrote:
On Tue, 18 May 2021, Philippe Mathieu-Daudé wrote:
IDE bus depends on ISA bus for IRQ/DMA.
Add an ISABus reference in PCIIDEState, and add link properties
to it in the PIIX and VIA objects (which inherit PCI_IDE).
On 5/19/21 3:37 PM, Richard Henderson wrote:
On 5/18/21 9:52 PM, David Gibson wrote:
I've applied 1..15, still looking at the rest.
Please dequeue. I want to create a new mmu-internal.h, which affects all the
patches from #1.
Alternately, don't. I can move the function later, and it may b
On Fri, 7 May 2021 05:25:09 -0700
Steve Sistare wrote:
> Export vfio_address_spaces and vfio_listener_skipped_section.
> Add optional eventfd arg to vfio_add_kvm_msi_virq.
> Refactor vector use into a helper vfio_vector_init.
> All for use by cpr in a subsequent patch. No functional change.
>
On Wed, May 19, 2021 at 03:08:17PM -0600, Alex Williamson wrote:
> > +VFIO_USER_DMA_MAP
> > +-
> > +
> > +Message Format
> > +^^
> > +
> > ++--++
> > +| Name | Value |
> > ++==+
On 5/18/21 7:05 PM, BALATON Zoltan wrote:
On Tue, 18 May 2021, Philippe Mathieu-Daudé wrote:
IDE bus depends on ISA bus for IRQ/DMA.
Add an ISABus reference in PCIIDEState, and add link properties
to it in the PIIX and VIA objects (which inherit PCI_IDE).
Signed-off-by: Philippe Mathieu-Daudé
On 5/19/21 12:34 PM, Philippe Mathieu-Daudé wrote:
Hi,
The floppy disc controllers pulls in irrelevant devices (sysbus in
an ISA-only machine, ISA bus + isa devices on a sysbus-only machine).
This series clean that by extracting each device in its own file,
adding the corresponding Kconfig symb
Copied from Peter Krempa's libvirt template, feature.md.
CC: Peter Krempa
Signed-off-by: John Snow
---
.gitlab/issue_templates/feature_request.md | 13 +
1 file changed, 13 insertions(+)
create mode 100644 .gitlab/issue_templates/feature_request.md
diff --git a/.gitlab/issue_templ
Based loosely on libvirt's template, written by Peter Krempa.
CC: Peter Krempa
Signed-off-by: John Snow
---
.gitlab/issue_templates/bug.md | 52 ++
1 file changed, 52 insertions(+)
create mode 100644 .gitlab/issue_templates/bug.md
diff --git a/.gitlab/issue_tem
Add "Bug" and "Feature Request" templates to the Gitlab interface to
help improve the quality of newly reported issues.
To see what this looks like, I've temporarily allowed my Gitlab fork to
diverge with these files merged. See my fork's "new issue" page to see
it in action: https://gitlab.com/j
On Wed, 14 Apr 2021 04:41:22 -0700
Thanos Makatos wrote:
> +
> +VFIO_USER_DMA_MAP
> +-
> +
> +Message Format
> +^^
> +
> ++--++
> +| Name | Value |
> ++==++
> +| Message ID
Patchew URL: https://patchew.org/QEMU/20210519202253.76782-1-ag...@csgraf.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210519202253.76782-1-ag...@csgraf.de
Subject: [PATCH v8 00/19] hvf: Implement Apple Silicon
On 5/18/21 9:52 PM, David Gibson wrote:
On Tue, May 18, 2021 at 03:11:22PM -0500, Richard Henderson wrote:
This attempts the cleanup I've been talking about with Bruno.
On the way, there's a lot of MMUAccessType cleanup, to get the
code into the form I wanted the interface to share. There's a
On Wed, May 19, 2021 at 09:49:57AM -0700, Titus Rwantare wrote:
> Hello,
>
> This patch series adds an interface to start supporting PMBus devices in QEMU.
> I’ve included two PMBus devices: MAX34451 and ADM1272.
>
Ok, I've added this to my next tree. I moved the files to the sensor
directory,
Now that we have all logic in place that we need to handle Hypervisor.framework
on Apple Silicon systems, let's add CONFIG_HVF for aarch64 as well so that we
can build it.
Signed-off-by: Alexander Graf
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov (x86 only)
---
v1 -> v2:
- Fix b
With Apple Silicon available to the masses, it's a good time to add support
for driving its virtualization extensions from QEMU.
This patch adds all necessary architecture specific code to get basic VMs
working. It's still pretty raw, but definitely functional.
Known limitations:
- Vtimer ackn
The hooks we have that call us after reset, init and loadvm really all
just want to say "The reference of all register state is in the QEMU
vcpu struct, please push it".
We already have a working pushing mechanism though called cpu->vcpu_dirty,
so we can just reuse that for all of the above, synci
We need to handle PSCI calls. Most of the TCG code works for us,
but we can simplify it to only handle aa64 mode and we need to
handle SUSPEND differently.
This patch takes the TCG code as template and duplicates it in HVF.
To tell the guest that we support PSCI 0.2 now, update the check in
arm_c
Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives
in the trusted application call number space, but its purpose is unknown.
In our current SMC implementation, we inject a UDEF for unknown SMC calls,
including this one. However, Windows breaks on boot when we do this. Instead
The hvf accel synchronize functions are only used as input for local
callback functions, so we can make them static.
Signed-off-by: Alexander Graf
---
accel/hvf/hvf-accel-ops.c | 6 +++---
accel/hvf/hvf-accel-ops.h | 3 ---
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/accel/hvf
Now that we have working system register sync, we push more target CPU
properties into the virtual machine. That might be useful in some
situations, but is not the typical case that users want.
So let's add a -cpu host option that allows them to explicitly pass all
CPU capabilities of their host C
Until now, Hypervisor.framework has only been available on x86_64 systems.
With Apple Silicon shipping now, it extends its reach to aarch64. To
prepare for support for multiple architectures, let's start moving common
code out into its own accel directory.
This patch splits the vcpu init and destr
Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives
in the trusted application call number space, but its purpose is unknown.
In our current SMC implementation, we inject a UDEF for unknown SMC calls,
including this one. However, Windows breaks on boot when we do this. Instead
We will need more than a single field for hvf going forward. To keep
the global vcpu struct uncluttered, let's allocate a special hvf vcpu
struct, similar to how hax does it.
Signed-off-by: Alexander Graf
Reviewed-by: Roman Bolshakov
Tested-by: Roman Bolshakov
Reviewed-by: Alex Bennée
---
v4
Now that Apple Silicon is widely available, people are obviously excited
to try and run virtualized workloads on them, such as Linux and Windows.
This patch set implements a fully functional version to get the ball
going on that. With this applied, I can successfully run both Linux and
Windows as
There is no reason to call the hvf specific hvf_cpu_synchronize_state()
when we can just use the generic cpu_synchronize_state() instead. This
allows us to have less dependency on internal function definitions and
allows us to make hvf_cpu_synchronize_state() static.
Signed-off-by: Alexander Graf
We can move the definition of hvf_vcpu_exec() into our internal
hvf header, obsoleting the need for hvf-accel-ops.h.
Signed-off-by: Alexander Graf
---
accel/hvf/hvf-accel-ops.c | 2 --
accel/hvf/hvf-accel-ops.h | 17 -
include/sysemu/hvf_int.h | 1 +
target/i386/hvf/hvf.c
From: Peter Collingbourne
Sleep on WFI until the VTIMER is due but allow ourselves to be woken
up on IPI.
In this implementation IPI is blocked on the CPU thread at startup and
pselect() is used to atomically unblock the signal and begin sleeping.
The signal is sent unconditionally so there's no
The hvf_set_phys_mem() function is only called within the same file.
Make it static.
Signed-off-by: Alexander Graf
---
accel/hvf/hvf-accel-ops.c | 2 +-
include/sysemu/hvf_int.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-
Until now, Hypervisor.framework has only been available on x86_64 systems.
With Apple Silicon shipping now, it extends its reach to aarch64. To
prepare for support for multiple architectures, let's start moving common
code out into its own accel directory.
This patch moves the vCPU thread loop ove
The ARM version of Hypervisor.framework no longer defines these two
types, so let's just revert to standard ones.
Signed-off-by: Alexander Graf
---
accel/hvf/hvf-accel-ops.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-
Until now, Hypervisor.framework has only been available on x86_64 systems.
With Apple Silicon shipping now, it extends its reach to aarch64. To
prepare for support for multiple architectures, let's start moving common
code out into its own accel directory.
This patch moves assert_hvf_ok() and intr
Until now, Hypervisor.framework has only been available on x86_64 systems.
With Apple Silicon shipping now, it extends its reach to aarch64. To
prepare for support for multiple architectures, let's start moving common
code out into its own accel directory.
This patch moves a few internal struct an
Until now, Hypervisor.framework has only been available on x86_64 systems.
With Apple Silicon shipping now, it extends its reach to aarch64. To
prepare for support for multiple architectures, let's start moving common
code out into its own accel directory.
This patch moves CPU and memory operation
When using a binary built using --without-default-devices we get:
$ qemu-system-arm -M xilinx-zynq-a9
**
ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type != NULL)
Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed:
(type != NULL)
Looking at the st
Currently the TYPE_CHIPIDEA model is only built when the IMX
machines are built. Since it is not specific to IMX, add its
symbol to allow other machines to use it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/Kconfig | 4
hw/usb/Kconfig | 3 +++
hw/usb/meson.build | 2 +-
3 file
We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX
USB Phy support") and had the FSL_IMX6 machine select it, however
this machine did not use the IMX_USBPHY until commit 49cd55789bb
("hw/arm/fsl-imx6: Wire up USB controllers"). Commit 17372bd812d
("hw/arm/fsl-imx6ul: Wire up USB con
Fix 2 more issues when using --without-default-devices builds
(xilinx-zynq-a9 and mcimx6ul-evk machines).
In an ideal world we'd have infinite compute power and would
run all tests, but in this one I only test this configuration
manually from time to time. We might start using it more...
Philippe
On Tue, 18 May 2021 at 12:32, Kevin Wolf wrote:
>
> The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92:
>
> Merge remote-tracking branch
> 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging
> (2021-05-17 16:44:47 +0100)
>
> are available in the Git
On 5/19/21 9:20 PM, Richard Henderson wrote:
> On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
>> The series is decomposed as:
>> - cleanups (1-6)
>> - clean ldst API using macros (7-13)
>> - add aligned ldst methods (14)
>> - add aligned memory methods (15-16)
>> - similar changes in virtio (17-
On 5/19/21 9:26 PM, Willian Rampazzo wrote:
> On Wed, May 19, 2021 at 3:55 PM Philippe Mathieu-Daudé
> wrote:
>>
>> From: Philippe Mathieu-Daudé
>>
>> The acceptance tests aren't accepting anything,
>> rename them as integration tests.
>
> Kind of related, I'm missing a patch changing the name
On Wed, May 19, 2021 at 3:55 PM Philippe Mathieu-Daudé wrote:
>
> From: Philippe Mathieu-Daudé
>
> The acceptance tests aren't accepting anything,
> rename them as integration tests.
Kind of related, I'm missing a patch changing the name of the
directory from `acceptance` to `integration`, but w
On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:
The series is decomposed as:
- cleanups (1-6)
- clean ldst API using macros (7-13)
- add aligned ldst methods (14)
- add aligned memory methods (15-16)
- similar changes in virtio (17-24)
- use the new methods on vring aligned values (25)
There a
Annotations do not change runtime behavior.
This commit adds mostly annotations, but uses a TYPE_CHECKING runtime
check to conditionally import dependencies, which only triggers during
runs of mypy.
Signed-off-by: John Snow
---
TopLevelExpr, an idea from previous drafts, makes a return here in
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> Add system/user emulation jobs on FreeBSD host.
>
> To build these jobs, you need to add a FreeBSD runner and
> add 'freebsd' to the QEMU_CUSTOM_RUNNER variable in your
> GitLab project.
>
> Reviewed by: Warner Losh
> Signed-off-by
(Addresses a pylint warning.)
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 06167ed3e0a..b3a468504fc 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser
Signed-off-by: John Snow
---
scripts/qapi/mypy.ini | 5 -
1 file changed, 5 deletions(-)
diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
index 54ca4483d6d..66253564297 100644
--- a/scripts/qapi/mypy.ini
+++ b/scripts/qapi/mypy.ini
@@ -3,11 +3,6 @@ strict = True
disallow_untyped_c
Signed-off-by: John Snow
---
scripts/qapi/pylintrc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index c5275d5f59b..1a633b2b88e 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -2,8 +2,7 @@
# Add files or di
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/buildtest-template.yml | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Willian Rampazzo
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> If a runner has ccache installed, use it and display statistics
> at the end of the build.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/buildtest-template.yml | 5 +
> 1 file changed, 5 insertions(+)
>
Revie
This is part five (b), and focuses on QAPIDoc in parser.py.
gitlab: https://gitlab.com/jsnow/qemu/-/commits/python-qapi-cleanup-pt5b
Requirements:
- Python 3.6+
- mypy >= 0.770
- pylint >= 2.6.0 (2.7.0+ when using Python 3.9+)
Every commit should pass with:
- `isort -c qapi/`
- `flake8 qapi/`
Eh. Two properties, a bool method and a public method are non-trivial
enough for me. (Especially in typed python!)
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index fefe4c37f44..36d4bd17
Patchew URL:
https://patchew.org/QEMU/20210519183050.875453-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210519183050.875453-1-richard.hender...@linaro.org
Subject: [PULL 00/50] targ
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> 'nproc' is not available on FreeBSD:
>
> $ JOBS=$(expr $(nproc) + 1)
> bash: line 119: nproc: command not found
> expr: syntax error
>
> Instead, use 'sysctl -n hw.ncpu'.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gi
Extract the build stages used by our job templates to a new file
(stages.yml) to be able to include it with the other templates,
without having to run all the jobs included in the default
.gitlab-ci.yml, which are mainly useful for mainstream CI.
Reviewed-by: Willian Rampazzo
Signed-off-by: Phili
It simplifies the typing to say that _section is always a
QAPIDoc.Section().
To accommodate this change, we must allow for this object to evaluate to
False for functions like _end_section which behave differently based on
whether or not a Section has been started.
Signed-off-by: John Snow
---
Extract the DCO / checkpatch jobs to a new file (static_checks.yml)
to be able to run them without having to run all the jobs included
in the default .gitlab-ci.yml, which are mainly useful for the
mainstream CI.
Reviewed-by: Willian Rampazzo
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci
** Changed in: qemu
Status: Incomplete => New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1887604
Title:
Forward host UNIX socket to guest TCP port
Status in QEMU:
New
Bug description:
From: Philippe Mathieu-Daudé
'extends' is an alternative to using YAML anchors
and is a little more flexible and readable. See:
https://docs.gitlab.com/ee/ci/yaml/#extends
Reviewed-by: Wainer dos Santos Moschetta
Reviewed-by: Willian Rampazzo
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab
Extract the crossbuild job templates to a new file
(crossbuild-template.yml) to be able to reuse them
without having to run all the jobs included, which
are mainly useful for mainstream CI.
Reviewed-by: Willian Rampazzo
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/crossbuild-template.
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> To be able to set the same environment variables to multiple jobs,
> extract what we currently have as a template.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> .gitlab-ci.d/buildtest-template.yml | 7 +--
> 1 file changed
From: Philippe Mathieu-Daudé
The acceptance tests aren't accepting anything,
rename them as integration tests.
Reviewed-by: Wainer dos Santos Moschetta
Reviewed-by: Willian Rampazzo
Acked-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.yml | 20 ++--
1 f
On Wed, May 19, 2021 at 3:46 PM Philippe Mathieu-Daudé wrote:
>
> Add the $MAKE variable to call GNU make, and set it to 'gmake'
> on FreeBSD to avoid:
>
> $ make -j"$JOBS"
> make: Unknown modifier ','
> make: "/builds/dTyar424/0/qemu/build/Makefile" line 3: Need an operator
> make: "/buil
On 18/05/2021 17:11, Richard Henderson wrote:
Create one common dispatch for all of the ppc_*_xlate functions.
Use ppc64_v3_radix to directly dispatch between ppc_radix64_xlate
and ppc_hash64_xlate.
Remove the separate *_handle_mmu_fault and *_get_phys_page_debug
functions, using common code fo
TypeGuards wont exist in Python proper until 3.10. Ah well. We can hack
up our own by declaring this function to return the type we claim it
checks for and using this to safely downcast object -> List[str].
In so doing, I bring this function under _pragma so it can use the
'info' object in its clo
Extract the container job template to a new file
(container-template.yml) to be able to reuse it
without having to run all the jobs included, which
are mainly useful for mainstream CI.
Reviewed-by: Willian Rampazzo
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/container-template.yml |
On 3/13/20 2:45 AM, Guenter Roeck wrote:
> Add basic USB PHY support as implemented in i.MX23, i.MX28, i.MX6,
> and i.MX7 SoCs.
>
> The only support really needed - at least to boot Linux - is support
> for soft reset, which needs to reset various registers to their initial
> value. Otherwise, jus
Add the $MAKE variable to call GNU make, and set it to 'gmake'
on FreeBSD to avoid:
$ make -j"$JOBS"
make: Unknown modifier ','
make: "/builds/dTyar424/0/qemu/build/Makefile" line 3: Need an operator
make: "/builds/dTyar424/0/qemu/build/Makefile" line 4: Missing dependency
operator
Signe
Instead of using get_expr nested=False, allow get_expr to always return
any expression. In exchange, add a new error message to the top-level
parser that explains the semantic error: Top-level expressions must
always be JSON objects.
This helps mypy understand the rest of this function which assum
To allow forks to easily decide which jobs they want to run,
but without disrupting the current default, move the current
set of jobs to a new file corresponding to the jobs run by
the mainstream project CI:
https://gitlab.com/qemu-project/qemu/-/pipelines
Reviewed-by: Willian Rampazzo
Signed-off
Series fully reviewed.
Hi,
Gitlab recommends to use job templates. To be able to re-use /
include templates, they can not use YAML anchors. All current jobs
has first to be converted to use the 'extends' keyworkd.
This is the first part of this series (already reviewed).
The second part extracts
With the QAPISourceInfo(None, None, None) construct gone, there's no
longer any reason to have to specify that a file starts on the first
line. Remove it from the initializer and default it to 1.
Remove the last vestiges where we check for 'line' being unset, that
can't happen, now.
Signed-off-by
It is not possible to use the previously extracted templates
without this set of core containers. Extract them into a new
file (container-core.yml) to be able to build them without
having to build all the other containers by default.
Reviewed-by: Thomas Huth
Reviewed-by: Willian Rampazzo
Signed-
We can have a two-letter variable name, as a treat.
Signed-off-by: John Snow
--
I don't want to use 'chr' or 'char', and in context 'ch' works well
enough. I will assume that any possible future uses will also be obvious
enough.
Signed-off-by: John Snow
---
scripts/qapi/pylintrc | 1 +
1 fil
Add system/user emulation jobs on FreeBSD host.
To build these jobs, you need to add a FreeBSD runner and
add 'freebsd' to the QEMU_CUSTOM_RUNNER variable in your
GitLab project.
Reviewed by: Warner Losh
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest-freebsd.yml | 59
1 - 100 of 420 matches
Mail list logo
