[Bug 1922252] Re: [feature request] webcam support

2021-05-14 Thread promeneur
I use -device usb-host,vendorid=0x046d,productid=0x081b But in this case the webcam belongs to the guest and the host can't use the webcam. I want a dynamical sharing like the mouse sharing for example. Thanks -- You received this bug notification because you are a member of qemu- devel-ml, w

Re: Best approach for supporting snapshots for QEMU's gdbstub?

2021-05-14 Thread Pavel Dovgalyuk
On 14.05.2021 19:06, Alex Bennée wrote: Hi, I've been playing around with QEMU's reverse debugging support which I have working with Pavel's latest patches for supporting virtio with record/replay. Once you get the right command line it works well enough although currently each step backwards re

Re: [RFC PATCH v2] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

2021-05-14 Thread Vaibhav Jain
Thanks for looking into this patch David David Gibson writes: > On Thu, May 06, 2021 at 08:19:24AM +0530, Vaibhav Jain wrote: >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for >> spapr nvdimms. This enables guest to fetch performance stats[2] like >> expected life of an nvdimm ('Me

[Bug 1921092] Re: gdbstub debug of multi-cluster machines is undocumented and confusing

2021-05-14 Thread Martin Schönstedt
It can be closed. The added documentation is very helpful. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921092 Title: gdbstub debug of multi-cluster machines is undocumented and confusing Status

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

2021-05-14 Thread John Snow
On 5/6/21 5:57 AM, Kashyap Chamarthy wrote: TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' feature. I tried to dig a bit, but failed :/ Markus, could you please help with it? At least by advice? Oho, I see. OK, I'm not M

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-14 Thread Emanuele Giuseppe Esposito
we want to get from shres here, after possible call to block_copy_task_shrink(), as task->bytes may be reduced. Ah right, I missed that. So I guess if we want the caller to protect co-shared-resource, get_from_shres stays where it is, and put_ instead can still go into task_end (with a bool

[Bug 1921061] Re: Corsair iCUE Install Fails, qemu VM Reboots

2021-05-14 Thread Russell Morris
** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921061 Title: Corsair iCUE Install Fails, qemu VM Reboots Status in QEMU: Confirmed Bug

Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx

2021-05-14 Thread Paolo Bonzini
On 14/05/21 19:27, Roman Kagan wrote: AFAICS your patch has basically the same effect as Vladimir's patch "util/async: aio_co_enter(): do aio_co_schedule in general case" (https://lore.kernel.org/qemu-devel/20210408140827.332915-4-vsement...@virtuozzo.com/). That one was found to break e.g. aio=

Re: [RFC PATCH 2/9] replace machine phase_check with machine_is_initialized/ready calls

2021-05-14 Thread Paolo Bonzini
On 14/05/21 15:13, Mirela Grujic wrote: However, if you believe it should rather be just renamed I can do so. I am just not sure it's such an advantage to replace phase_check with separate functions. The rename is a constraint of QAPI, so we have to live with the long names. Paolo

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-14 Thread Vladimir Sementsov-Ogievskiy via
14.05.2021 20:28, Emanuele Giuseppe Esposito wrote: On 14/05/2021 17:30, Vladimir Sementsov-Ogievskiy wrote: 14.05.2021 17:32, Emanuele Giuseppe Esposito wrote: On 14/05/2021 16:26, Vladimir Sementsov-Ogievskiy wrote: 14.05.2021 17:10, Emanuele Giuseppe Esposito wrote: On 12/05/2021 17:

Re: [PATCH v2 2/3] docs/interop/bitmaps: use blockdev-backup

2021-05-14 Thread John Snow
On 5/5/21 9:58 AM, Vladimir Sementsov-Ogievskiy wrote: We are going to deprecate drive-backup, so use modern interface here. In examples where target image creation is shown, show blockdev-add as well. If target creation omitted, omit blockdev-add as well. Signed-off-by: Vladimir Sementsov-Ogiev

Re: [PATCH v2 1/3] docs/block-replication: use blockdev-backup

2021-05-14 Thread John Snow
On 5/5/21 9:58 AM, Vladimir Sementsov-Ogievskiy wrote: We are going to deprecate drive-backup, so don't mention it here. Moreover, blockdev-backup seems more correct in the context. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/block-replication.txt | 4 ++--

Re: [PATCH v3 10/15] qemu_iotests: extent QMP socket timeout when using valgrind

2021-05-14 Thread John Snow
On 5/14/21 4:16 AM, Emanuele Giuseppe Esposito wrote: On 13/05/2021 20:47, John Snow wrote: On 4/14/21 1:03 PM, Emanuele Giuseppe Esposito wrote: As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout timeout too soon. Signed-off-by: Emanuele Giuseppe Esposi

[Bug 1912934] Re: QEMU emulation of fmadds instruction on powerpc64le is buggy

2021-05-14 Thread Bruno Haible
The situation is still the same in QEMU 6.0.0. $ powerpc64le-linux-gnu-gcc-5 test-fmadds.c -static $ ~/inst-qemu/6.0.0/bin/qemu-ppc64le ./a.out ; echo $? 32 ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, wh

[Bug 1705118] Re: qemu user mode: rt signals not implemented for sparc guests

2021-05-14 Thread Bruno Haible
The situation in version 6.0.0 is the same as in version 2.11.0: The cases ppc, ppc64, ppc64le, s390x are fixed, but the sparc64 executable still crashes. ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which

[Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2021-05-14 Thread Bruno Haible
The issue seems to be fixed, even without the symlink for /usr/-linux-gnu/etc/ld.so.cache. For m68k: since version 2.10.0. For s390x: since version 2.11.0. For the other platforms, already since 2.9.0 (strange, this contradicts my original report...). ** Changed in: qemu Status: Incomplet

Re: [PATCH 0/3] tests/acceptance: Handle tests with "cpu" tag

2021-05-14 Thread John Snow
On 4/9/21 10:53 AM, Wainer dos Santos Moschetta wrote: Hi, On 4/7/21 5:01 PM, Eduardo Habkost wrote: On Tue, Mar 23, 2021 at 05:01:09PM -0400, John Snow wrote: On 3/17/21 3:16 PM, Wainer dos Santos Moschetta wrote: Added John and Eduardo, On 3/9/21 3:52 PM, Cleber Rosa wrote: On Wed, Feb 24

[Bug 1908515] Re: assertion failure in lsi53c810 emulator

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/305 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1912224] Re: qemu may freeze during drive-mirroring on fragmented FS

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/307 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1912107] Re: Option to constrain linux-user exec() to emulated CPU only

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/306 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1908513] Re: assertion failure in mptsas1068 emulator

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/304 ** Changed in: qemu Status: Confirmed => Expired ** Bug

[Bug 1913969] Re: unable to migrate non shared storage when TLS is used

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/310 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1913873] Re: QEMU: net: vmxnet: integer overflow may crash guest

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/308 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1907042] Re: assert issue locates in hw/usb/core.c:727: usb_ep_get: Assertion `pid == USB_TOKEN_IN || pid == USB_TOKEN_OUT' failed

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/303 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1913923] Re: assert issue locates in hw/net/vmxnet3.c:1793:vmxnet3_io_bar1_write: code should not be reach

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/309 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1918975] Re: [Feature request] Propagate interpreter to spawned processes

2021-05-14 Thread Thomas Huth
Also, is this a duplicate of https://bugs.launchpad.net/qemu/+bug/1912107 or do you mean something different here? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918975 Title: [Feature request] Pro

[Bug 1912780] Re: QEMU: Null Pointer Failure in fdctrl_read() in hw/block/fdc.c

2021-05-14 Thread Thomas Huth
** Changed in: qemu Status: New => In Progress ** Changed in: qemu Importance: Undecided => High -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912780 Title: QEMU: Null Pointer Failure i

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-14 Thread John Snow
On 5/14/21 3:23 PM, Thomas Huth wrote: On 23/01/2021 11.03, P J P wrote: From: Prasad J Pandit While processing ioport command in 'fdctrl_write_dor', device controller may select a drive which is not initialised with a block device. This may result in a NULL pointer dereference. Add checks to

[Bug 1913510] Re: [Fuzz] qemu-system-i386 virtio-mouse: Assertion in address_space_lduw_le_cached failed

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/302 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-14 Thread Thomas Huth
On 23/01/2021 11.03, P J P wrote: From: Prasad J Pandit While processing ioport command in 'fdctrl_write_dor', device controller may select a drive which is not initialised with a block device. This may result in a NULL pointer dereference. Add checks to avoid it. Fixes: CVE-2021-20196 Reporte

[Bug 1921280] Re: OpenIndiana stuck in boot loop when using hvf

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH 07/10] iotests: use subprocess.run where possible

2021-05-14 Thread John Snow
On 5/12/21 5:46 PM, John Snow wrote: pylint 2.8.x adds warnings whenever we use Popen calls without using 'with', so it's desirable to convert synchronous calls to run() invocations where applicable. (Though, this trades one pylint warning for another due to a pylint bug, which I've silenced wit

[Bug 1921082] Re: VM crash when process broadcast MCE

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1915063] Re: Windows 10 wil not install using qemu-system-x86_64

2021-05-14 Thread Thomas Huth
The patch for QEMU that has been mentioned in comment #38 has been merged already, so I'm marking this as Fix-Released there. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Bug 1921061] Re: Corsair iCUE Install Fails, qemu VM Reboots

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

2021-05-14 Thread John Snow
On 5/14/21 10:08 AM, Wainer dos Santos Moschetta wrote: Now it might throw a CalledProcessError given that `check=True`. Shouldn't it capture the exception and (possible) re-throw as an QEMUMachineError? I lied to you again. The existing callers all check for failure explicitly, so in the int

[Bug 1922102] Re: Broken tap networking on macOS host

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1922252] Re: [feature request] webcam support

2021-05-14 Thread Thomas Huth
Have you already tried to simply pass the host USB webcam through to the guest? ... that's likely easier and faster than adding software emulation... ** Changed in: qemu Status: New => Incomplete ** Tags added: feature-request usb ** Changed in: qemu Importance: Undecided => Wishlist

[Bug 1921444] Re: Q35 doesn't support to hot add the 2nd PCIe device to KVM guest

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1921635] Re: ESP SCSI adapter not working with DOS ASPI drivers

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1921092] Re: gdbstub debug of multi-cluster machines is undocumented and confusing

2021-05-14 Thread Thomas Huth
Is there still anything to do here or could we close the ticket now? ** Changed in: qemu Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921092 Title: gdbstub

[Bug 1918975] Re: [Feature request] Propagate interpreter to spawned processes

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH 05/10] python/machine: Disable pylint warning for open() in _pre_launch

2021-05-14 Thread John Snow
On 5/14/21 10:42 AM, Wainer dos Santos Moschetta wrote: Hi, On 5/12/21 6:46 PM, John Snow wrote: Shift the open() call later so that the pylint pragma applies *only* to that one open() call. Add a note that suggests why this is safe: the resource is unconditionally cleaned up in _post_shutdown(

[Bug 1920871] Re: netperf UDP_STREAM high packet loss on QEMU tap network

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1920013] Re: Unable to pass-through PCIe devices from a ppc64le host to an x86_64 guest

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1920211] Re: shrink option for discard (for bad host-filesystems and -backup solutions)

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH 03/10] python/machine: use subprocess.run instead of subprocess.Popen

2021-05-14 Thread John Snow
On 5/14/21 10:08 AM, Wainer dos Santos Moschetta wrote: Hi, On 5/12/21 6:46 PM, John Snow wrote: use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow ---   python/qemu/machine.py | 15 +--   1 file

[Bug 1908062] Re: qemu-system-i386 virtio-vga: Assertion in address_space_stw_le_cached failed again

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/300 ** Changed in: qemu Status: Incomplete => Expired ** Bu

[Bug 1918149] Re: qemu-user reports wrong fault_addr in signal handler

2021-05-14 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1910941] Re: Assertion `addr < cache->len && 2 <= cache->len - addr' in virtio-blk

2021-05-14 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/301 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1918084] Re: Build fails on macOS 11.2.2

2021-05-14 Thread Thomas Huth
So is this working now with the final release of v6.0 ? ** Changed in: qemu Status: Triaged => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1918084 Title: Build fails on macOS 1

Re: [PATCH v6 59/82] target/arm: Implement SVE mixed sign dot product (indexed)

2021-05-14 Thread Richard Henderson
On 5/13/21 7:57 AM, Peter Maydell wrote: Maybe we should macroify this, as unless I'm misreading them gvec_sdot_idx_b, gvec_udot_idx_b, gvec_sudot_idx_b and gvec_usdot_idx_b only differ in the types of the index and the data. Done. r~

Re: [PULL v3 0/1] Rtd patches

2021-05-14 Thread Peter Maydell
On Fri, 14 May 2021 at 12:13, wrote: > > From: Marc-André Lureau > > The following changes since commit 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' > into staging (2021-05-13 20:13:24 +0100) > > are available in the Git

Re: [RFC PATCH 0/9] Initial support for machine creation via QMP

2021-05-14 Thread Paolo Bonzini
Il ven 14 mag 2021, 18:20 Daniel P. Berrangé ha scritto: > My gut feeling though is accel-set would be more logical being done > first, as that also influences the set of features available in other > areas of QEMU configuration. Was there a reason you listed it after > machine-set ? > That was

Re: [PATCH v6 55/82] target/arm: Implement SVE2 saturating multiply-add (indexed)

2021-05-14 Thread Richard Henderson
On 5/13/21 7:42 AM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 22:07, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/helper-sve.h| 9 + target/arm/sve.decode | 18 ++ target/arm/sve_helper.c| 30 +

Re: [RFC PATCH 10/11] target/ppc: created tcg-stub.c file

2021-05-14 Thread Bruno Piazera Larsen
On 12/05/2021 15:39, Richard Henderson wrote: On 5/12/21 9:08 AM, Bruno Larsen (billionai) wrote: +++ b/target/ppc/tcg-stub.c @@ -0,0 +1,33 @@ + +#include "qemu/osdep.h" All files get copyright boilerplate. +#include "exec/hwaddr.h" +#include "cpu.h" +#include "hw/ppc/spapr.h" + +hwaddr ppc

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-14 Thread Paolo Bonzini
Il ven 14 mag 2021, 16:10 Emanuele Giuseppe Esposito ha scritto: > > I'm not sure I like it since callers may still need coarser grained > > locks to protect their own state or synchronize access to multiple > > items of data. Also, some callers may not need thread-safety. > > > > Can the caller

Re: [PATCH v2 49/50] target/i386: Move helper_check_io to sysemu

2021-05-14 Thread Richard Henderson
On 5/14/21 10:13 AM, Richard Henderson wrote: --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -193,6 +193,7 @@ typedef struct DisasContext { { qemu_build_not_reached(); } #ifdef CONFIG_USER_ONLY +STUB_HELPER(check_io, TCGv_env env, TCGv_i32 port, TCGv_i32 size)

Re: [PATCH v2 12/12] configure: bump min required CLang to 6.0 / XCode 10.0

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:06 AM Daniel P. Berrangé wrote: > > Several distros have been dropped since the last time we bumped the > minimum required CLang version. > > Per repology, currently shipping versions are: > > RHEL-8: 10.0.1 > Debian Buster: 7.0.1 > openSUSE Leap 15.2:

Re: [PATCH 5/6] co-shared-resource: protect with a mutex

2021-05-14 Thread Emanuele Giuseppe Esposito
On 14/05/2021 17:30, Vladimir Sementsov-Ogievskiy wrote: 14.05.2021 17:32, Emanuele Giuseppe Esposito wrote: On 14/05/2021 16:26, Vladimir Sementsov-Ogievskiy wrote: 14.05.2021 17:10, Emanuele Giuseppe Esposito wrote: On 12/05/2021 17:44, Stefan Hajnoczi wrote: On Mon, May 10, 2021 at 1

Re: [PATCH v6 82/82] target/arm: Enable SVE2 and related extensions

2021-05-14 Thread Richard Henderson
On 5/13/21 2:35 PM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 22:37, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/arm/cpu.c | 1 + target/arm/cpu64.c | 13 + 2 files changed, 14 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index

Re: [PATCH v2 11/12] configure: bump min required GCC to 7.5.0

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:05 AM Daniel P. Berrangé wrote: > > Several distros have been dropped since the last time we bumped the > minimum required GCC version. > > Per repology, currently shipping versions are: > > RHEL-8: 8.3.1 > Debian Buster: 8.3.0 > openSUSE Leap 15.2: 7.

Re: [PATCH v2 10/12] configure: bump min required glib version to 2.56

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:05 AM Daniel P. Berrangé wrote: > > The glib version was not previously constrained by RHEL-7 since it > rebases fairly often. Instead SLES 12 and Ubuntu 16.04 were the > constraints in 00f2cfbbec63fb6f5a7789797a62ccedd22466ea. Both of > these are old enough that they are

[PULL 18/19] test-write-threshold: drop extra TestStruct structure

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy We don't need this extra logic: it doesn't make code simpler. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-Id: <20210506090621.11848-8-vsement...@virtuozzo.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Reitz --- tests/u

Re: [PATCH v6 80/82] target/arm: Implement integer matrix multiply accumulate

2021-05-14 Thread Richard Henderson
On 5/13/21 2:49 PM, Peter Maydell wrote: On Fri, 30 Apr 2021 at 22:36, Richard Henderson wrote: This is {S,U,US}MMLA for both AArch64 AdvSIMD and SVE, and V{S,U,US}MMLA.S8 for AArch32 NEON. Signed-off-by: Richard Henderson --- target/arm/helper.h | 7 target/arm/neon-share

[PATCH 4/4] sasl: remove comment about obsolete kerberos versions

2021-05-14 Thread Daniel P . Berrangé
This is not relevant to any OS distro that QEMU currently targets. Signed-off-by: Daniel P. Berrangé --- qemu.sasl | 4 1 file changed, 4 deletions(-) diff --git a/qemu.sasl b/qemu.sasl index abdfc686be..851acc7e8f 100644 --- a/qemu.sasl +++ b/qemu.sasl @@ -29,10 +29,6 @@ mech_list: gssapi

Re: [PATCH v2 08/12] tests/vm: convert centos VM recipe to CentOS 8

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:05 AM Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > tests/vm/centos | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/tests/vm/centos b/tests/vm/centos > index efe3dbbb36..5c7bc1c1a9 100755 > --- a/tests

[PATCH 3/4] docs: recommend SCRAM-SHA-256 SASL mech instead of SHA-1 variant

2021-05-14 Thread Daniel P . Berrangé
The SHA-256 variant better meats modern security expectations. Also warn that the password file is storing entries in clear text. Signed-off-by: Daniel P. Berrangé --- docs/system/vnc-security.rst | 7 --- qemu.sasl| 11 ++- 2 files changed, 10 insertions(+), 8 d

[PULL 13/19] block/write-threshold: don't use write notifiers

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy write-notifiers are used only for write-threshold. New code for such purpose should create filters. Let's better special-case write-threshold and drop write notifiers at all. (Actually, write-threshold is special-cased anyway, as the only user of write-notifier

[PATCH 2/4] docs: document usage of the authorization framework

2021-05-14 Thread Daniel P . Berrangé
The authorization framework provides a way to control access to network services after a client has been authenticated. This documents how to actually use it. Signed-off-by: Daniel P. Berrangé --- docs/system/authz.rst | 263 ++ docs/system/index.rst | 1

[PATCH 1/4] docs: document how to pass secret data to QEMU

2021-05-14 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/system/index.rst | 1 + docs/system/secrets.rst | 162 2 files changed, 163 insertions(+) create mode 100644 docs/system/secrets.rst diff --git a/docs/system/index.rst b/docs/system/index.rst index b05af716a

[PULL 10/19] Document qemu-img options data_file and data_file_raw

2021-05-14 Thread Max Reitz
From: Connor Kuehl The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original wording and tweaked it accor

Re: [PATCH v2 03/12] crypto: bump min nettle to 3.4, dropping RHEL-7 support

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:04 AM Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > platform build policy, we no longer need to support RHEL-7 as a build > target. This lets us increment the minimum required nettle version and > drop a lot of back

[PATCH 0/4] docs: add user facing docs for secret passing and authorization controls

2021-05-14 Thread Daniel P . Berrangé
These are an important of the overall QEMU network backend security controls but never previously documented aside from in blog posts. Daniel P. Berrangé (4): docs: document how to pass secret data to QEMU docs: document usage of the authorization framework docs: recommend SCRAM-SHA-256 SASL

[PULL 08/19] qemu-iotests: let "check" spawn an arbitrary test command

2021-05-14 Thread Max Reitz
From: Paolo Bonzini Right now there is no easy way for "check" to print a reproducer command. Because such a reproducer command line would be huge, we can instead teach check to start a command of our choice. This can be for example a Python unit test with arguments to only run a specific subtes

Re: [PATCH v3 06/33] util/async: aio_co_schedule(): support reschedule in same ctx

2021-05-14 Thread Roman Kagan
On Thu, May 13, 2021 at 11:04:37PM +0200, Paolo Bonzini wrote: > On 12/05/21 09:15, Vladimir Sementsov-Ogievskiy wrote: > > > > > > > > > > I don't understand.  Why doesn't aio_co_enter go through the ctx != > > > qemu_get_current_aio_context() branch and just do aio_co_schedule? > > > That was a

[PULL 19/19] write-threshold: deal with includes

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy "qemu/typedefs.h" is enough for include/block/write-threshold.h header with forward declaration of BlockDriverState. Also drop extra includes from block/write-threshold.c and tests/unit/test-write-threshold.c Signed-off-by: Vladimir Sementsov-Ogievskiy Message

[PULL 09/19] qemu-iotests: fix case of SOCK_DIR already in the environment

2021-05-14 Thread Max Reitz
From: Paolo Bonzini Due to a typo, in this case the SOCK_DIR was not being created. Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Tested-by: Emanuele Giuseppe Esposito Message-Id: <20210323181928.311862-6-pbonz...@redhat.com> Message-Id: <20210503110110.476887-6-pbonz

[PULL 17/19] test-write-threshold: drop extra tests

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Testing set/get of one 64bit variable doesn't seem necessary. We have a lot of such variables. Also remaining tests do test set/get anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-Id: <20210506090621.11848-7-vsement...@virtu

[PULL 05/19] qemu-iotests: do not buffer the test output

2021-05-14 Thread Max Reitz
From: Paolo Bonzini Instead of buffering the test output into a StringIO, patch it on the fly by wrapping sys.stdout's write method. This can be done unconditionally, even if using -d, which makes execute_unittest a bit simpler. Signed-off-by: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogie

[PULL 15/19] test-write-threshold: rewrite test_threshold_(not_)trigger tests

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy These tests use bdrv_write_threshold_exceeded() API, which is used only for test (since pre-previous commit). Better is testing real API, which is used in block.c as well. So, let's call bdrv_write_threshold_check_write(), and check is bs->write_threshold_offse

[PULL 07/14] tests/qtest: add multi-queue test case to vhost-user-blk-test

2021-05-14 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Message-Id: <20210309094106.196911-4-stefa...@redhat.com> Signed-off-by: Kevin Wolf Message-Id: <20210322092327.150720-3-stefa...@redhat.com> Signed-off-by: Kevin Wolf --- tests/qtest/vhost-user-blk-test.c | 81 +

[PULL 14/19] block: drop write notifiers

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy They are unused now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-Id: <20210506090621.11848-3-vsement...@virtuozzo.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Reitz --- include/block/block_int.h | 12 blo

[PULL 12/19] qemu-iotests: fix pylint 2.8 consider-using-with error

2021-05-14 Thread Max Reitz
From: Emanuele Giuseppe Esposito pylint 2.8 introduces consider-using-with error, suggesting to use the 'with' block statement when possible. Modify all subprocess.Popen call to use the 'with' statement, except the one in __init__ of QemuIoInteractive class, since it is assigned to a class field

[PULL 14/14] vhost-user-blk: Check that num-queues is supported by backend

2021-05-14 Thread Kevin Wolf
Creating a device with a number of queues that isn't supported by the backend is pointless, the device won't work properly and the error messages are rather confusing. Just fail to create the device if num-queues is higher than what the backend supports. Since the relationship between num-queues

[PULL 11/19] block/copy-on-read: use bdrv_drop_filter() and drop s->active

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Now, after huge update of block graph permission update algorithm, we don't need this workaround with active state of the filter. Drop it and use new smart bdrv_drop_filter() function. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210506194143.394

[PULL 08/14] vhost-user-blk-test: test discard/write zeroes invalid inputs

2021-05-14 Thread Kevin Wolf
From: Stefan Hajnoczi Exercise input validation code paths in block/export/vhost-user-blk-server.c. Signed-off-by: Stefan Hajnoczi Message-Id: <20210309094106.196911-5-stefa...@redhat.com> Signed-off-by: Kevin Wolf Message-Id: <20210322092327.150720-4-stefa...@redhat.com> Signed-off-by: Kevin

[PULL 07/19] qemu-iotests: move command line and environment handling from TestRunner to TestEnv

2021-05-14 Thread Max Reitz
From: Paolo Bonzini In the next patch, "check" will learn how to execute a test script without going through TestRunner. To enable this, keep only the text output and subprocess handling in the TestRunner; move into TestEnv the logic to prepare for running a subprocess. Reviewed-by: Vladimir Se

[PULL 03/14] block: Fix Transaction leak in bdrv_reopen_multiple()

2021-05-14 Thread Kevin Wolf
Like other error paths, this one needs to call tran_finalize() and clean up the BlockReopenQueue, too. Fixes: CID 1452772 Fixes: 72373e40fbc7e4218061a8211384db362d3e7348 Signed-off-by: Kevin Wolf Message-Id: <20210503110555.24001-3-kw...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Sign

[PULL 03/19] monitor: hmp_qemu_io: acquire aio contex, fix crash

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Max reported the following bug: $ ./qemu-img create -f raw src.img 1G $ ./qemu-img create -f raw dst.img 1G $ (echo ' {"execute":"qmp_capabilities"} {"execute":"blockdev-mirror", "arguments":{"job-id":"mirror", "device":"source",

Re: [PATCH v2 04/12] crypto: drop back compatibility typedefs for nettle

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:04 AM Daniel P. Berrangé wrote: > > Now that we only support modern nettle, we don't need to have local > typedefs to mask the real nettle types. > > Reviewed-by: Thomas Huth > Reviewed-by: Richard Henderson > Signed-off-by: Daniel P. Berrangé > --- > crypto/cipher-ne

[PULL 05/14] block/export: improve vu_blk_sect_range_ok()

2021-05-14 Thread Kevin Wolf
From: Stefan Hajnoczi The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is equal to BDRV_SECTOR_SIZE. This is true, but let's add a QEMU_BUILD_BUG_ON() to make it explicit. We might as well check that the request buffer size is a multiple of VIRTIO_BLK_SECTOR_SIZE while we're at

[PULL 04/16] virtio-blk: Constify VirtIOFeature feature_sizes[]

2021-05-14 Thread Michael S. Tsirkin
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20210511104157.2880306-3-phi...@redhat.com> --- hw/block/virtio-blk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index d28979efb8..f139cd7cc9 10

[PULL 16/19] block/write-threshold: drop extra APIs

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy bdrv_write_threshold_exceeded() is unused. bdrv_write_threshold_is_set() is used only to double check the value of bs->write_threshold_offset in tests. No real sense in it (both tests do check real value with help of bdrv_write_threshold_get()) Signed-off-by:

[PULL 06/19] qemu-iotests: allow passing unittest.main arguments to the test scripts

2021-05-14 Thread Max Reitz
From: Paolo Bonzini Python test scripts that use unittest consist of multiple tests. unittest.main allows selecting which tests to run, but currently this is not possible because the iotests wrapper ignores sys.argv. unittest.main command line options also allow the user to pick the desired opti

Re: [PATCH v2 06/12] crypto: bump min gnutls to 3.5.18, dropping RHEL-7 support

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:04 AM Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > platform build policy, we no longer need to support RHEL-7 as a build > target. This lets us increment the minimum required gnutls version > > Per repology, curren

Re: [PATCH v3 3/4] migrate-bitmaps-test: Fix pylint warnings

2021-05-14 Thread Vladimir Sementsov-Ogievskiy
14.05.2021 18:43, Max Reitz wrote: There are a couple of things pylint takes issue with: - The "time" import is unused - The import order (iotests should come last) - get_bitmap_hash() doesn't use @self and so should be a function - Semicolons at the end of some lines - Parentheses after "if" - S

Re: [PATCH v2 01/12] gitlab: drop linux user build job for CentOS 7

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:04 AM Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > platform build policy, we no longer need to support RHEL-7 as a build > target. > > The build-user-centos7 job was to detect a failure specific to CentOS > 7 and t

[PULL 04/19] mirror: stop cancelling in-flight requests on non-force cancel in READY

2021-05-14 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy If mirror is READY than cancel operation is not discarding the whole result of the operation, but instead it's a documented way get a point-in-time snapshot of source disk. So, we should not cancel any requests if mirror is READ and force=false. Let's fix that

Re: [PATCH v2 02/12] patchew: move quick build job from CentOS 7 to CentOS 8 container

2021-05-14 Thread Willian Rampazzo
On Fri, May 14, 2021 at 9:04 AM Daniel P. Berrangé wrote: > > It has been over two years since RHEL-8 was released, and thus per the > platform build policy, we no longer need to support RHEL-7 as a build > target. > > Signed-off-by: Daniel P. Berrangé > --- > .patchew.yml | 6 +++--- > 1 file c

  1   2   3   4   >