[Bug 1885175] Re: memory.c range assertion hit at full invalidating

2021-05-06 Thread Eugenio Pérez
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885175 Title: memory.c range assertion hit at full invalidating Status in QEMU: Fix R

[Bug 1884719] Re: Function not implemented when using libaio

2021-05-06 Thread Thomas Huth
Bug has been re-opened here: https://gitlab.com/qemu-project/qemu/-/issues/210 Thanks for copying it over, Martin! ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #210 https://gitlab.com/qemu-project/qemu/-/issues/210 ** Changed in: qemu Status: Incomplete => Invalid -- You

Re: [PATCH] scripts: add a script to list virtio devices in a system

2021-05-06 Thread Laurent Vivier
On 06/05/2021 21:50, Philippe Mathieu-Daudé wrote: > On 5/6/21 9:33 PM, Laurent Vivier wrote: >> Add "lsvirtio" that lists all virtio devices in a system >> the same way lspci does for the PCI cards. >> >> For instance: >> >> $ ./lsvirtio >> :01:00.0 virtio0 Red Hat, Inc. (PCI) Virtio Network

Re: [PATCH v7 2/6] target/i386: Enable XSS feature enumeration for CPUID

2021-05-06 Thread Yang Weijiang
On Thu, May 06, 2021 at 06:16:47PM -0400, Eduardo Habkost wrote: > On Fri, Feb 26, 2021 at 10:20:54AM +0800, Yang Weijiang wrote: > > Currently, CPUID.(EAX=0DH,ECX=01H) doesn't enumerate features in > > XSS properly, add the support here. XCR0 bits indicate user-mode XSAVE > > components, and XSS b

Re: [RESEND PATCH 01/32] memory: Add RAM_PROTECTED flag to skip IOMMU mappings

2021-05-06 Thread Yang Zhong
On Mon, May 03, 2021 at 07:01:27PM +0200, Paolo Bonzini wrote: > On 30/04/21 08:24, Yang Zhong wrote: > >From: Sean Christopherson > > > >Add a new RAMBlock flag to denote "protected" memory, i.e. memory that > >looks and acts like RAM but is inaccessible via normal mechanisms, > >including DMA.

[Bug 1887306] Re: qemu-user deadlocks when forked in a multithreaded process

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1887604] Re: Forward host UNIX socket to guest TCP port

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1888303] Re: Intermittent buggines with user mode emulation of x86-64 on aarch64

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1888467] Re: qemu-img http convert bug

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1888417] Re: Latest QEMU git build on Arch linux causes PCI Passthrough host to hang on guest reboot.

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1873339] Re: Qemu DOS Quake - 640x480 and above resolutions - Unable to load VESA palette in dos prompt and game crashing are not working

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

Re: [PATCH v3 1/4] hw/ppc: moved hcalls that depend on softmmu

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 01:39:38PM -0300, Lucas Mateus Castro (alqotel) wrote: > The hypercalls h_enter, h_remove, h_bulk_remove, h_protect, and h_read, > have been moved to spapr_softmmu.c with the functions they depend on. The > functions is_ram_address and push_sregs_to_kvm_pr are not static any

Re: [PATCH v3 4/4] hw/ppc: Altered calls from oea_read to read

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 01:39:41PM -0300, Lucas Mateus Castro (alqotel) wrote: > Changed spapr.c and pnv.c from calls of ppc_spr_t.oea_read to > ppc_spr_t.name as oea_read is not available in !TCG builds. This is correct, but I think we can do it a little more cleanly. This logic is identical to

Re: [PATCH v3 2/4] target/ppc: moved function out of mmu-hash64

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 01:39:39PM -0300, Lucas Mateus Castro (alqotel) wrote: > The function ppc_hash64_filter_pagesizes has been moved from a function > with prototype in mmu-hash64.h and implemented in mmu-hash64.c to > a static function in hw/ppc/spapr_caps.c as it's only used in that file. >

Re: [PATCH v3 3/4] target/ppc: moved ppc_store_lpcr to misc_helper.c

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 01:39:40PM -0300, Lucas Mateus Castro (alqotel) wrote: > Moved the function ppc_store from mmu-hash64.c to misc_helper.c and the > prototype from mmu-hash64.h to cpu.h as it is a more appropriate place, > but it will have to have its implementation moved to a new file as > m

[Bug 1885247] Re: Build error in Intel 32-bit hosts

2021-05-06 Thread Thomas Huth
Fix had been included here: https://gitlab.com/qemu-project/qemu/-/commit/8b39aa90e90 ... thus closing this ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

[Bug 1885553] Re: make-check test failed with "Segmentation fault"

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1885827] Re: building plugin failed on Windows with mingw

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1885332] Re: Error in user-mode calculation of ELF aux vector's AT_PHDR

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1886155] Re: error: argument 2 of ‘__atomic_load’ discards ‘const’ qualifier

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1886097] Re: Error in user-mode calculation of ELF program's brk

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1884684] Re: QEMU 5.0: Guest VM hangs/freeze when unplugging USB device

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1886285] Re: Provide SMB option to support Windows 2000

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting the bug state to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then plea

[Bug 1884017] Re: Intermittently erratic mouse under Windows 95

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1885175] Re: memory.c range assertion hit at full invalidating

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1884719] Re: Function not implemented when using libaio

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1884831] Re: qemu-nbd fails to discard bigger chunks

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

Re: [RESEND PATCH v5 2/4] target/ppc: move SPR R/W callbacks to translate.c

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 04:08:37PM -0300, Bruno Larsen (billionai) wrote: > Moved all read and write callbacks for SPRs away from > translate_init.c.inc and into translate.c; these functions are > TCG only, so this motion is required to enable building with > the flag disable-tcg > > Signed-off-by

Re: [PATCH v2 9/9] target/ppc/kvm: Replace alloca() by g_malloc()

2021-05-06 Thread David Gibson
On Thu, May 06, 2021 at 03:37:58PM +0200, Philippe Mathieu-Daudé wrote: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace it by a g_malloc() call. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/kvm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH v5 4/4] target/ppc: isolated cpu init from translation logic

2021-05-06 Thread David Gibson
On Wed, May 05, 2021 at 12:53:10PM -0300, Bruno Larsen (billionai) wrote: > finished isolation of CPU initialization logic from > translation logic. CPU initialization now only has common code > and may or may not call accelerator-specific code, as the > build options require. > > Signed-off-by: B

Re: [PATCH v5 3/4] target/ppc: turned SPR R/W callbacks not static

2021-05-06 Thread David Gibson
On Wed, May 05, 2021 at 12:53:09PM -0300, Bruno Larsen (billionai) wrote: > To be able to compile translate_init.c.inc as a standalone file, > we have to make the callbacks accessible outside of translate.c; > This patch does exactly that > > Signed-off-by: Bruno Larsen (billionai) > This no lon

[Bug 1883784] Re: [ppc64le] qemu behavior differs from ppc64le hardware

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-05-06 Thread Thomas Huth
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923497 Title: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

[Bug 1870039] Re: windows qemu-img fails to convert vhdx, assertion failure

2021-05-06 Thread Rafael Rivera
Still a bug, resetting status per new bug tracker guidance. Also, re-tested with v6.0.0-11869-g800a25ea45-dirty. Results in error: ERROR:../../../util/oslib-win32.c:61:qemu_try_memalign: assertion failed: (is_power_of_2(alignment)) ** Changed in: qemu Status: Incomplete => New -- You

[Bug 1863200] Re: Reconnect failed with loopback virtio1.1 server mode test

2021-05-06 Thread xuan
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863200 Title: Reconnect failed with loopback virtio1.1 server mode test Status in QEMU: New B

[Bug 1877015] Re: virtio only support packed ring size power of 2

2021-05-06 Thread xuan
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877015 Title: virtio only support packed ring size power of 2 Status in QEMU: New Bug descrip

Re: [PATCH 16/22] qapi/parser: add docstrings

2021-05-06 Thread John Snow
On 4/25/21 9:27 AM, Markus Armbruster wrote: Another ignorant doc string markup question... how am I supposed to see that exprs and docs are attributes, and not global variables? The syntax is apparently supposed to be :py:attr:`MyClass.attr`. Though, it doesn't seem to be working for me. I

Re: [PATCH v5 1/4] target/ppc: renamed SPR registration functions

2021-05-06 Thread David Gibson
On Wed, May 05, 2021 at 12:53:07PM -0300, Bruno Larsen (billionai) wrote: > Renamed all gen_spr_* and gen_* functions specifically related to > registering SPRs to register_*_sprs and register_*, to avoid future > confusion with other TCG related code. > > Signed-off-by: Bruno Larsen (billionai)

Re: [PATCH v7 2/6] target/i386: Enable XSS feature enumeration for CPUID

2021-05-06 Thread Eduardo Habkost
On Fri, Feb 26, 2021 at 10:20:54AM +0800, Yang Weijiang wrote: > Currently, CPUID.(EAX=0DH,ECX=01H) doesn't enumerate features in > XSS properly, add the support here. XCR0 bits indicate user-mode XSAVE > components, and XSS bits indicate supervisor-mode XSAVE components. > > Signed-off-by: Yang W

Re: [PATCH 2/2] vhost-vdpa: doorbell mapping support

2021-05-06 Thread Si-Wei Liu
On 5/5/2021 7:17 PM, Jason Wang wrote: 在 2021/5/1 上午6:32, Si-Wei Liu 写道: On 4/15/2021 1:04 AM, Jason Wang wrote: This patch implements the doorbell mapping support for vhost-vDPA. This is simply done by using mmap()/munmap() for the vhost-vDPA fd during device start/stop. For the device w

[Bug 1927530] Re: qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
*** This bug is a duplicate of bug 1921948 *** https://bugs.launchpad.net/bugs/1921948 ** Attachment added: "libgcc_s.so.1" https://bugs.launchpad.net/qemu/+bug/1927530/+attachment/5495299/+files/libgcc_s.so.1 -- You received this bug notification because you are a member of qemu- devel

[Bug 1927530] Re: qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
*** This bug is a duplicate of bug 1921948 *** https://bugs.launchpad.net/bugs/1921948 Sorry, I didn't think about rpath when I tried to execute what I had extracted. Here are the additional libstdc++.so.6 and libgcc_s.so.1. I am using a more recent qemu version than 6.0, almost head: d45a527

Re: [Virtio-fs] [PULL 01/12] virtiofsd: Fix side-effect in assert()

2021-05-06 Thread Edward McClanahan
Very nice catch David... Countless times I've gotten bit by this one! Get Outlook for Android From: virtio-fs-boun...@redhat.com on behalf of Dr. David Alan Gilbert (git) Sent: Thursday, May 6, 2021 1:56:30 PM To: qemu-devel@nongnu.org ;

Re: [PATCH] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic

2021-05-06 Thread John Snow
On 5/6/21 3:43 PM, Peter Maydell wrote: Coverity notes that when calculating the 64-bit iso_size value in ahci_test_cdrom() we actually only do it with 32-bit arithmetic. This doesn't matter for the current test code because nsectors is always small; but adding the cast avoids the coverity compla

Re: [PATCH] virtio-blk: Convert QEMUBH callback to "bitops.h" API

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 9:42 PM, Philippe Mathieu-Daudé wrote: > On 5/6/21 8:22 PM, Richard Henderson wrote: >> On 5/6/21 8:54 AM, Philippe Mathieu-Daudé wrote: >>>   static void notify_guest_bh(void *opaque) >>>   { >>>   VirtIOBlockDataPlane *s = opaque; >>> -    unsigned nvqs = s->conf->num_queues; >>> - 

Re: [PATCH] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 9:43 PM, Peter Maydell wrote: > Coverity notes that when calculating the 64-bit iso_size value in > ahci_test_cdrom() we actually only do it with 32-bit arithmetic. > This doesn't matter for the current test code because nsectors is > always small; but adding the cast avoids the coverity

Re: [PATCH] scripts: add a script to list virtio devices in a system

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 9:33 PM, Laurent Vivier wrote: > Add "lsvirtio" that lists all virtio devices in a system > the same way lspci does for the PCI cards. > > For instance: > > $ ./lsvirtio > :01:00.0 virtio0 Red Hat, Inc. (PCI) Virtio Network Card >Subsystem: virtio >Modalias: virtio

[PATCH] tests/qtest/ahci-test.c: Calculate iso_size with 64-bit arithmetic

2021-05-06 Thread Peter Maydell
Coverity notes that when calculating the 64-bit iso_size value in ahci_test_cdrom() we actually only do it with 32-bit arithmetic. This doesn't matter for the current test code because nsectors is always small; but adding the cast avoids the coverity complaints. Fixes: Coverity CID 1432343 Signed-

[PATCH] block/copy-on-read: use bdrv_drop_filter() and drop s->active

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
Now, after huge update of block graph permission update algorithm, we don't need this workaround with active state of the filter. Drop it and use new smart bdrv_drop_filter() function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/copy-on-read.c | 33 + 1

Re: [PATCH] virtio-blk: Convert QEMUBH callback to "bitops.h" API

2021-05-06 Thread Philippe Mathieu-Daudé
On 5/6/21 8:22 PM, Richard Henderson wrote: > On 5/6/21 8:54 AM, Philippe Mathieu-Daudé wrote: >>   static void notify_guest_bh(void *opaque) >>   { >>   VirtIOBlockDataPlane *s = opaque; >> -    unsigned nvqs = s->conf->num_queues; >> -    unsigned long bitmap[BITS_TO_LONGS(nvqs)]; >> -    uns

[PATCH] scripts: add a script to list virtio devices in a system

2021-05-06 Thread Laurent Vivier
Add "lsvirtio" that lists all virtio devices in a system the same way lspci does for the PCI cards. For instance: $ ./lsvirtio :01:00.0 virtio0 Red Hat, Inc. (PCI) Virtio Network Card Subsystem: virtio Modalias: virtio:d0001v1AF4 Status: ACKNOWLEDGE DRIVER

Re: [PATCH v2 6/9] gdbstub: Only call cmd_parse_params() with non-NULL command schema

2021-05-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Move the NULL check on command schema buffer from the callee > cmd_parse_params() to the single caller, process_string_cmd(). > > This simplifies the process_string_cmd() logic. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex Benn

Re: [PATCH v2 7/9] gdbstub: Replace alloca() + memset(0) by g_new0()

2021-05-06 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > The ALLOCA(3) man-page mentions its "use is discouraged". > > Replace the alloca() and memset(0) calls by g_new0(). > > Signed-off-by: Philippe Mathieu-Daudé Please see: Subject: [ALT PATCH] gdbstub: Replace GdbCmdContext with plain g_array() Date: Thu,

[PATCH] tests/qtest/migration-test: Use g_autofree to avoid leaks on error paths

2021-05-06 Thread Peter Maydell
Coverity notices that several places in the migration-test code fail to free memory in error-exit paths. This is pretty unimportant in test case code, but we can avoid having to manually free the memory entirely by using g_autofree. The places where Coverity spotted a leak were relating to early

[PULL 10/12] virtiofsd: Changed allocations of fv_VuDev & its internals to GLib functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Changed the allocations of fv_VuDev structs, VuDev structs, and fv_QueueInfo strcuts from using calloc()/realloc() & free() to using the equivalent functions from GLib. In instances, removed the pair of allocation and assertion for non-NULL checking with a GLib function tha

Re: [PATCH] Add missing coroutine_fn function signature to functions

2021-05-06 Thread cennedee
Thank you for the feedback. Here is an updated patch. Added more functions related to do_sgio() as suggested. Also found one related to prh_co_entry() I have removed (edits on) two files as there are many more functions I found in those. So I think another thread might be more appropriate (where

[PULL 12/12] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Replaced the allocation of local variables from malloc() to GLib allocation functions. In one instance, dropped the usage to an assert after a malloc() call and used g_malloc() instead. Signed-off-by: Mahmoud Mandour Reviewed-by: Stefan Hajnoczi Message-Id: <202104201546

Re: [PATCH v5 2/4] target/ppc: move SPR R/W callbacks to translate.c

2021-05-06 Thread Bruno Piazera Larsen
On 06/05/2021 15:57, Richard Henderson wrote: On 5/5/21 8:53 AM, Bruno Larsen (billionai) wrote: +/* SPR READ/RITE CALLBACKS */ Missed the spelling fix reported against v4. And my r-b tags. r~ :facepalm: sorry, resending it now -- Bruno Piazera Larsen Instituto de Pesquisas ELDORADO

[RESEND PATCH v5 2/4] target/ppc: move SPR R/W callbacks to translate.c

2021-05-06 Thread Bruno Larsen (billionai)
Moved all read and write callbacks for SPRs away from translate_init.c.inc and into translate.c; these functions are TCG only, so this motion is required to enable building with the flag disable-tcg Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard Henderson --- target/ppc/translate

Re: [PATCH v5 2/4] target/ppc: move SPR R/W callbacks to translate.c

2021-05-06 Thread Richard Henderson
On 5/5/21 8:53 AM, Bruno Larsen (billionai) wrote: +/* SPR READ/RITE CALLBACKS */ Missed the spelling fix reported against v4. And my r-b tags. r~

[PULL 07/12] virtiofsd: Changed allocations of iovec to GLib's functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Replaced the calls to malloc()/calloc() and their respective calls to free() of iovec structs with GLib's allocation and deallocation functions and used g_autofree when appropriate. Replaced the allocation of in_sg_cpy to g_new() instead of a call to calloc() and a null-che

[Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-05-06 Thread Ed Davison
Sorry, this has not recurred since you asked for the stack trace. Not sure what "fixed" it. Closing the bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923497 Title: bios_linker_loader_add_che

[Bug 1923497] Re: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed

2021-05-06 Thread Ed Davison
I guess I should say, you may close the bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1923497 Title: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed Statu

[PULL 04/12] virtiofs: Fixup printf args

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Fixup some fuse_log printf args for 32bit compatibility. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20210428110100.27757-2-dgilb...@redhat.com> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Stefan Hajnoczi --- tools/virtiofsd/passthrough_ll.c | 21

[PULL 11/12] virtiofsd/passthrough_ll.c: Changed local allocations to GLib functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Changed the allocations of some local variables to GLib's allocation functions, such as g_try_malloc0(), and annotated those variables as g_autofree. Subsequently, I was able to remove the calls to free(). Signed-off-by: Mahmoud Mandour Reviewed-by: Stefan Hajnoczi Messag

[PULL 09/12] virtiofsd: Changed allocation of lo_map_elems to GLib's functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Replaced (re)allocation of lo_map_elem structs from realloc() to GLib's g_try_realloc_n() and replaced the respective free() call with a g_free(). Signed-off-by: Mahmoud Mandour Reviewed-by: Stefan Hajnoczi Message-Id: <20210420154643.58439-5-ma.mando...@gmail.com> Signed

[PULL 08/12] virtiofsd: Changed allocations of fuse_session to GLib's functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Replaced the allocation and deallocation of fuse_session structs from calloc() and free() calls to g_try_new0() and g_free(). Signed-off-by: Mahmoud Mandour Reviewed-by: Stefan Hajnoczi Message-Id: <20210420154643.58439-4-ma.mando...@gmail.com> Signed-off-by: Dr. David Al

[PULL 00/12] virtiofs queue

2021-05-06 Thread Dr. David Alan Gilbert (git)
s://gitlab.com/dagrh/qemu.git tags/pull-virtiofs-20210506 for you to fetch changes up to 67a010f64cc9e33ba19ab389dedaa52013a9de8a: virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib (2021-05-06 19:47:44 +0100) virti

[PULL 05/12] virtiofsd: Don't assume header layout

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" virtiofsd incorrectly assumed a fixed set of header layout in the virt queue; assuming that the fuse and write headers were conveniently separated from the data; the spec doesn't allow us to take that convenience, so fix it up to deal with it the hard way. Signed-

[PULL 06/12] virtiofsd: Changed allocations of fuse_req to GLib functions

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Mahmoud Mandour Replaced the allocation and deallocation of fuse_req structs using calloc()/free() call pairs to a GLib's g_try_new0() and g_free(). Signed-off-by: Mahmoud Mandour Reviewed-by: Stefan Hajnoczi Message-Id: <20210420154643.58439-2-ma.mando...@gmail.com> Signed-off-by: Dr. D

[PULL 03/12] virtiofsd: Add help for -o xattr-mapping

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Carlos Venegas The option is not documented in help. Add small help about the option. Signed-off-by: Carlos Venegas Message-Id: <20210414201207.3612432-3-jose.carlos.venegas.mu...@intel.com> Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl --- tools/virtiofsd/helper.c |

[PULL 01/12] virtiofsd: Fix side-effect in assert()

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Greg Kurz It is bad practice to put an expression with a side-effect in assert() because the side-effect won't happen if the code is compiled with -DNDEBUG. Use an intermediate variable. Consolidate this in an macro to have proper line numbers when the assertion is hit. virtiofsd: ../../t

[PULL 02/12] virtiofsd: Allow use "-o xattrmap" without "-o xattr"

2021-05-06 Thread Dr. David Alan Gilbert (git)
From: Carlos Venegas When -o xattrmap is used, it will not work unless xattr is enabled. This patch enables xattr when -o xattrmap is used. Signed-off-by: Carlos Venegas Message-Id: <20210414201207.3612432-2-jose.carlos.venegas.mu...@intel.com> Signed-off-by: Dr. David Alan Gilbert Reviewed-b

[Bug 1927530] Re: qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Richard Henderson
*** This bug is a duplicate of bug 1921948 *** https://bugs.launchpad.net/bugs/1921948 You missed including libstdc++.so.6. I ran with whatever libstdc++ I had lying around. With qemu head, this terminates with ~/qemu/bld/qemu-aarch64 -L . ./bitfield-2.exe *** stack smashing detected ***: t

[Bug 1921948] Re: MTE tags not checked properly for unaligned accesses at EL1

2021-05-06 Thread Richard Henderson
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1921948 Title: MTE tags not checked properly for unaligned accesses at EL1 Status in Q

Re: [PATCH] virtio-blk: Convert QEMUBH callback to "bitops.h" API

2021-05-06 Thread Richard Henderson
On 5/6/21 8:54 AM, Philippe Mathieu-Daudé wrote: static void notify_guest_bh(void *opaque) { VirtIOBlockDataPlane *s = opaque; -unsigned nvqs = s->conf->num_queues; -unsigned long bitmap[BITS_TO_LONGS(nvqs)]; -unsigned j; -memcpy(bitmap, s->batch_notify_vqs, sizeof(bi

Re: [PATCH 09/10] pckbd: correctly disable PS/2 communication

2021-05-06 Thread Volker Rümelin
Hi Volker, On 5/5/21 9:21 PM, Volker Rümelin wrote: Currently the PS/2 controller command KBD_CCMD_MOUSE_DISABLE doesn't disable the PS/2 mouse communication at all, and the PS/2 controller commands KBD_CCMD_KBD_DISABLE and KBD_CCMD_KBD_ENABLE disable and enable the keyboard interrupt, which is

Re: [PATCH v5 00/10] numa/exec/migration: Fix resizing RAM blocks while migrating

2021-05-06 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Thu, Apr 29, 2021 at 01:26:58PM +0200, David Hildenbrand wrote: > > v4 has been floating around for a while. Let's see if we can find someone > > to merge this; or at least give some more feedback ... all patches have > > at least one RB. > > Ack

Re: [PATCH] target/mips: Fix potential integer overflow (CID 1452921)

2021-05-06 Thread Richard Henderson
On 5/5/21 2:51 PM, Philippe Mathieu-Daudé wrote: Use the BIT_ULL() macro to ensure we use 64-bit arithmetic. This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN): CID 1452921: Integer handling issues: Potentially overflowing expression "1 << w" with type "int" (32 bits,

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2021-05-06 Thread Christophe Lyon
I have re-tested at commit d45a5270d075ea589f0b0ddcf963a5fea1f500ac, and the build succeeded, so it looks like the problem has been fixed. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

Re: [PATCH v5 00/10] numa/exec/migration: Fix resizing RAM blocks while migrating

2021-05-06 Thread Eduardo Habkost
On Thu, Apr 29, 2021 at 01:26:58PM +0200, David Hildenbrand wrote: > v4 has been floating around for a while. Let's see if we can find someone > to merge this; or at least give some more feedback ... all patches have > at least one RB. Acked-by: Eduardo Habkost David Gilbert: I assume this shoul

Re: [PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

2021-05-06 Thread Warner Losh
On Thu, May 6, 2021 at 11:51 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 5/6/21 10:38 AM, Warner Losh wrote: > > The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. > 0xe is > > used by Linux and represents the intel hardware trap vector. The BSD > kernels, >

Re: [PULL 00/46] ppc-for-6.1 queue 20210504

2021-05-06 Thread Peter Maydell
On Tue, 4 May 2021 at 06:53, David Gibson wrote: > > The following changes since commit 15106f7dc3290ff3254611f265849a314a93eb0e: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-hex-20210502' > into staging (2021-05-02 16:23:05 +0100) > > are available in the Git repository at: >

Re: [PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

2021-05-06 Thread Richard Henderson
On 5/6/21 10:38 AM, Warner Losh wrote: The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe is used by Linux and represents the intel hardware trap vector. The BSD kernels, however, translate this to T_PAGEFLT in their Xpage, Xtrap0e, Xtrap14, etc fault handlers. This is true

[Bug 1878348] Re: --static build fails in v5.0 (since 5010cec2bc87dafab39b3913c8ca91f88df9c540)

2021-05-06 Thread Peter Maydell
FWIW, a configure line that works for me for static system-emulation builds on Ubuntu 18.04 with QEMU 6.0 is: '../../configure' '--target-list=arm-softmmu' '--enable-debug' '-- static' '--disable-tools' '--disable-sdl' '--disable-gtk' '--disable- vnc' '--disable-virtfs' '--disable-attr' '--disable

Re: [PATCH 7/7] virtiofsd: use GDateTime for formatting timestamp for debug messages

2021-05-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > The GDateTime APIs provided by GLib avoid portability pitfalls, such > > > as some platforms where 'struct timeval.tv_sec' field

[Bug 1873335] Re: Dos Keypad is not working for numbers - numlock is not working

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/204 ** Changed in: qemu Status: New => Expired ** Bug watch

[Bug 1927530] [NEW] qemu-aarch64 MTE fails to report tag mismatch

2021-05-06 Thread Christophe Lyon
Public bug reported: Hi, While running the GCC testsuite with qemu-6.0 as simulator, I noticed several errors in the hwasan testsuite (output pattern tests). I am attaching: bitfield-2.exe ld-linux-aarch64.so.1 libc.so.6 libdl.so.2 libhwasan.so.0 libm.so.6 libpthread.so.0 librt.so.1 The testcas

[Bug 1873338] Re: Dos on the fly CD image replacement is not Working with DOS

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/206 ** Changed in: qemu Status: New => Expired ** Bug watch

[PATCH v2] tcg: Use correct trap number for page faults on *BSD systems

2021-05-06 Thread Warner Losh
The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe is used by Linux and represents the intel hardware trap vector. The BSD kernels, however, translate this to T_PAGEFLT in their Xpage, Xtrap0e, Xtrap14, etc fault handlers. This is true for i386 and x86_64, though the name of

[Bug 1873337] Re: Arrow keys press is double in some programs in Dos

2021-05-06 Thread Thomas Huth
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'expired' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/205 ** Changed in: qemu Status: New => Expired ** Bug watch

Re: [PATCH] tcg: Use correct trap number for page faults on *BSD systems

2021-05-06 Thread Warner Losh
On Thu, May 6, 2021 at 10:43 AM Warner Losh wrote: > The trap number for a page fault on BSD systems is T_PAGEFLT not 0xe. 0xe > is > used by Linux and represents the intel hardware trap vector. The BSD > kernels, > however, translate this to T_PAGEFLT in their Xpage, Xtrap0e, Xtrap14, etc > faul

[Bug 1882241] Re: file transfer over cifs to 64bit guest corrupts large files

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1881506] Re: TCG doesn't support a lot of features that should be supported

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1881729] Re: target_read_memory in disas.c ignores possible errors

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1880763] Re: Missing page crossing check in use_goto_tb() for rx target

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1880722] Re: Problems related to checking page crossing in use_goto_tb()

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1879590] Re: Using qemu-system-sparc64 no network interface seems to exist

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1880066] Re: Microphone input dies in guest when switching evdev input

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

[Bug 1883593] Re: Windows XP takes much longer to boot in TCG mode since 5.0

2021-05-06 Thread Thomas Huth
The QEMU project is currently moving its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If the bug has already been fixed in the latest upstream version of QEMU, then please

  1   2   3   4   >