[PATCH] MAINTAINERS: Drop the line with Xiang Zheng

2021-03-31 Thread Thomas Huth
When sending a mail with CC: to zhengxia...@huawei.com I got a mail back saying: Your message couldn't be delivered The message you sent to zhengxia...@huawei.com couldn't be delivered due to: Recipient email address is possibly incorrect. Further information 5.1.1 : Recipient address reje

Re: [PATCH] MAINTAINERS: replace Huawei's email to personal one

2021-03-31 Thread Thomas Huth
On 23/03/2021 05.04, Dongjiu Geng wrote: ping... sorry for the noise. On 3/11/2021 19:29,Dongjiu Geng wrote: In order to conveniently receive email, replace the Huawei email address with my personal one. Signed-off-by: Dongjiu Geng --- MAI

Re: Status update for maintainers file

2021-03-31 Thread Thomas Huth
On 31/03/2021 19.42, Sarah Harris wrote: Hi all, I was added as a reviewer (in MAINTAINERS) for the AVR target for the duration of my research work using it. The funding for my project expires in the middle of April, so I will not be able to provide time for reviewing patches from that point.

[PATCH] MAINTAINERS: Drop the lines with Sarah Harris

2021-03-31 Thread Thomas Huth
In a mail to the qemu-devel mailing list, Sarah wrote: "I was added as a reviewer (in MAINTAINERS) for the AVR target for the duration of my research work using it. The funding for my project expires in the middle of April, so I will not be able to provide time for reviewing patches from that p

Re: [PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-31 Thread Greg Kurz
On Thu, 1 Apr 2021 13:26:11 +1100 David Gibson wrote: > On Thu, Apr 01, 2021 at 06:35:19AM +0530, Vaibhav Jain wrote: > > Add support for H_SCM_HEALTH hcall described at [1] for spapr > > nvdimms. This enables guest to detect the 'unarmed' status of a > > specific spapr nvdimm identified by its D

[PATCH] docs: Fix typo in the default name of the qemu-system-x86_64 binary

2021-03-31 Thread Thomas Huth
It's a '-' between 'qemu' and 'system', not a '_'. Fixes: 324b2298fe ("docs/system: convert Texinfo documentation to rST") Signed-off-by: Thomas Huth --- docs/defs.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/defs.rst.inc b/docs/defs.rst.inc index 48d05aaf33..

Re: [PATCH v3 2/4] block: check for sys/disk.h

2021-03-31 Thread Joelle van Dyne
On Mon, Mar 15, 2021 at 11:03 AM Joelle van Dyne wrote: > > Some BSD platforms do not have this header. > > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Joelle van Dyne Please bear with me as I am still new to this, but what happens to the three patches tha

Re: [PATCH] gitlab-ci.yml: Use unrecoverable address sanitizer

2021-03-31 Thread Thomas Huth
On 31/03/2021 18.36, Alexander Bulekov wrote: On 210331 1805, Thomas Huth wrote: Make sure that errors don't go unnoticed by using the unrecoverable sanitizer switch here, too. Signed-off-by: Thomas Huth --- I thought sanitizer recovery is disabled by default for ASan. I've only seen it enab

Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR

2021-03-31 Thread David Gibson
On Tue, Mar 30, 2021 at 11:31:25PM -0700, Richard Henderson wrote: > On 3/30/21 10:47 PM, David Gibson wrote: > > Richard - the remaining possible problem with the hflags stuff seems > > to manifest with the assert failing in the last patch. However, I'm > > guess that's just exposing some more su

Re: [RFC PATCH] i386: Add ratelimit for bus locks acquired in guest

2021-03-31 Thread Chenyi Qiang
Hi Paolo, Do we have any comment for this Bus lock VM exit QEMU patch? On 3/17/2021 4:47 PM, Chenyi Qiang wrote: Virtual Machines can exploit bus locks to degrade the performance of system. To address this kind of performance DOS attack, bus lock VM exit is introduced in KVM and it will report

[PATCH v2 08/21] Hexagon (target/hexagon) change type of softfloat_roundingmodes

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/arch.c b/target/hexagon/arch.c index 699e2cf..bb51f19 100644 --- a/target/hexagon/arch.c +++

[PATCH v2 16/21] Hexagon (target/hexagon) add A4_addp_c/A4_subp_c

2021-03-31 Thread Taylor Simpson
Rdd32 = add(Rss32, Rtt32, Px4):carry Add with carry Rdd32 = sub(Rss32, Rtt32, Px4):carry Sub with carry Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 37 target/hexagon/genptr.c | 1

[PATCH v2 20/21] Hexagon (target/hexagon) load into shifted register instructions

2021-03-31 Thread Taylor Simpson
The following instructions are added L2_loadalignb_io Ryy32 = memb_fifo(Rs32+#s11:1) L2_loadalignh_io Ryy32 = memh_fifo(Rs32+#s11:1) L4_loadalignb_ur Ryy32 = memb_fifo(Rt32<<#u2+#U6) L4_loadalignh_ur Ryy32 = memh_fifo(Rt32<<#u2+#U6) L4_loadali

[PATCH v2 21/21] Hexagon (target/hexagon) CABAC decode bin

2021-03-31 Thread Taylor Simpson
The following instruction is added S2_cabacdecbinRdd32=decbin(Rss32,Rtt32) Test cases added to tests/tcg/hexagon/misc.c Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 91 +++ target/hexagon/arch.h | 4 ++

[PATCH v2 18/21] Hexagon (target/hexagon) bit reverse (brev) addressing

2021-03-31 Thread Taylor Simpson
The following instructions are added L2_loadrub_pbr Rd32 = memub(Rx32++Mu2:brev) L2_loadrb_pbr Rd32 = memb(Rx32++Mu2:brev) L2_loadruh_pbr Rd32 = memuh(Rx32++Mu2:brev) L2_loadrh_pbr Rd32 = memh(Rx32++Mu2:brev) L2_loadri_pbr Rd32 = m

[PATCH v2 01/21] Hexagon (target/hexagon) TCG generation cleanup

2021-03-31 Thread Taylor Simpson
Simplify TCG generation of hex_reg_written Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/genptr.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 7481f4c..87f5d92 100644

[PATCH v2 12/21] Hexagon (target/hexagon) add F2_sfrecipa instruction

2021-03-31 Thread Taylor Simpson
Rd32,Pe4 = sfrecipa(Rs32, Rt32) Recripocal approx Test cases in tests/tcg/hexagon/multi_result.c FP exception tests added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 31 +++-- target/hexagon/arch.h | 1 +

[PATCH v2 03/21] Hexagon (target/hexagon) use env_archcpu and env_cpu

2021-03-31 Thread Taylor Simpson
Remove hexagon_env_get_cpu and replace with env_archcpu Replace CPU(hexagon_env_get_cpu(env)) with env_cpu(env) Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- linux-user/hexagon/cpu_loop.c | 2 +- target/hexagon/cpu.c | 4 ++-- target/hexagon/cpu.h | 5 -

[PATCH v2 17/21] Hexagon (target/hexagon) circular addressing

2021-03-31 Thread Taylor Simpson
The following instructions are added L2_loadrub_pci Rd32 = memub(Rx32++#s4:0:circ(Mu2)) L2_loadrb_pci Rd32 = memb(Rx32++#s4:0:circ(Mu2)) L2_loadruh_pci Rd32 = memuh(Rx32++#s4:1:circ(Mu2)) L2_loadrh_pci Rd32 = memh(Rx32++#s4:1:circ(Mu2)) L2_l

[PATCH v2 13/21] Hexagon (target/hexagon) add F2_sfinvsqrta

2021-03-31 Thread Taylor Simpson
Rd32,Pe4 = sfinvsqrta(Rs32) Square root approx The helper packs the 2 32-bit results into a 64-bit value, and the fGEN_TCG override unpacks them into the proper results. Test cases in tests/tcg/hexagon/multi_result.c FP exception tests added to tests/tcg/hexagon/fpstuff.c Signed-off-by: Tayl

[PATCH v2 19/21] Hexagon (target/hexagon) load and unpack bytes instructions

2021-03-31 Thread Taylor Simpson
The following instructions are added L2_loadbzw2_io Rd32 = memubh(Rs32+#s11:1) L2_loadbzw4_io Rdd32 = memubh(Rs32+#s11:1) L2_loadbsw2_io Rd32 = membh(Rs32+#s11:1) L2_loadbsw4_io Rdd32 = membh(Rs32+#s11:1) L4_loadbzw2_ur Rd32 = memubh

[PATCH v2 09/21] Hexagon (target/hexagon) use softfloat default NaN and tininess

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- fpu/softfloat-specialize.c.inc | 3 +++ target/hexagon/cpu.c | 5 + target/hexagon/op_helper.c | 47 -- 3 files changed, 8 insertions(+), 47 deletions(-) diff --git a/fp

[PATCH v2 00/21] Hexagon (target/hexagon) update

2021-03-31 Thread Taylor Simpson
This patch series is a significant update for the Hexagon target The first 10 patches address feedback from Richard Henderson The next 6 patches add the remaining instructions for the Hexagon scalar core The patches are logically independent but are organized as a series to avoid

[PATCH v2 04/21] Hexagon (target/hexagon) properly generate TB end for DISAS_NORETURN

2021-03-31 Thread Taylor Simpson
When exiting a TB, generate all the code before returning from hexagon_tr_translate_packet so that nothing needs to be done in hexagon_tr_tb_stop. Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/translate.c | 62 -- ta

[PATCH v2 15/21] Hexagon (target/hexagon) add A6_vminub_RdP

2021-03-31 Thread Taylor Simpson
Rdd32,Pe4 = vminub(Rtt32, Rss32) Vector min of bytes Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 27 +++ target/hexagon/genptr.c | 22 ++ target/hexagon/imp

[PATCH v2 05/21] Hexagon (target/hexagon) decide if pred has been written at TCG gen time

2021-03-31 Thread Taylor Simpson
Multiple writes to the same preg are and'ed together. Rather than generating a runtime check, we can determine at TCG generation time if the predicate has previously been written in the packet. Test added to tests/tcg/hexagon/misc.c Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson

[PATCH v2 11/21] Hexagon (target/hexagon) use softfloat for float-to-int conversions

2021-03-31 Thread Taylor Simpson
Use the proper return for helpers that convert to unsigned Remove target/hexagon/conv_emu.[ch] Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/conv_emu.c | 177 target/hexagon/conv_emu.h | 31 target/hex

[PATCH v2 02/21] Hexagon (target/hexagon) remove unnecessary inline directives

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/cpu.c | 9 - target/hexagon/decode.c| 6 +++--- target/hexagon/fma_emu.c | 39 --- target/hexagon/op_helper.c | 37 ++--- tar

[PATCH v2 06/21] Hexagon (target/hexagon) change variables from int to bool when appropriate

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/cpu_bits.h | 2 +- target/hexagon/decode.c| 80 +++--- target/hexagon/insn.h | 21 ++--

[PATCH v2 07/21] Hexagon (target/hexagon) remove unused carry_from_add64 function

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 13 - target/hexagon/arch.h | 1 - target/hexagon/macros.h | 2 -- 3 files changed, 16 deletions(-) diff --git a/target/hexagon/arch.c b/target/hexagon/arc

[PATCH v2 14/21] Hexagon (target/hexagon) add A5_ACS (vacsh)

2021-03-31 Thread Taylor Simpson
Rxx32,Pe4 = vacsh(Rss32, Rtt32) Add compare and select elements of two vectors Test cases in tests/tcg/hexagon/multi_result.c Signed-off-by: Taylor Simpson --- target/hexagon/gen_tcg.h | 5 +++ target/hexagon/helper.h | 2 ++ target/hexagon/imported/alu.idef

[PATCH v2 10/21] Hexagon (target/hexagon) replace float32_mul_pow2 with float32_scalbn

2021-03-31 Thread Taylor Simpson
Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Taylor Simpson --- target/hexagon/arch.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/target/hexagon/arch.c b/target/hexagon/arch.c index bb51f19..40b6e3d 100644 -

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-31 Thread David Gibson
On Thu, Apr 01, 2021 at 11:17:39AM +1100, Alexey Kardashevskiy wrote: > > > On 31/03/2021 12:03, David Gibson wrote: > > On Thu, Mar 25, 2021 at 02:25:33PM +1100, Alexey Kardashevskiy wrote: > > > > > > > > > On 25/03/2021 13:52, David Gibson wrote: > > > > On Tue, Mar 23, 2021 at 01:58:30PM +1

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 05:18:45PM +0200, Cédric Le Goater wrote: > On 3/31/21 2:57 AM, David Gibson wrote: > > On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: > >> > >> > >> On 3/29/21 12:32 PM, Cédric Le Goater wrote: > >>> On 3/29/21 6:20 AM, David Gibson wrote: > O

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 05:22:39PM +0200, Cédric Le Goater wrote: > On 3/31/21 6:58 AM, Michael Ellerman wrote: > > David Gibson writes: > >> On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: > > ... > >> > >>> We assign ibm,chip-id=0x0 to CPUs 0-3, but CPUs 2-3 are located

Re: [PATCH 2/2] spapr.c: always pulse guest IRQ in spapr_core_unplug_request()

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 09:04:37PM -0300, Daniel Henrique Barboza wrote: > Commit 47c8c915b162 fixed a problem where multiple spapr_drc_detach() > requests were breaking QEMU. The solution was to just spapr_drc_detach() > once, and use spapr_drc_unplug_requested() to filter whether we already > det

Re: [PATCH qemu] spapr: Rename RTAS_MAX_ADDR to FDT_MAX_ADDR

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 01:51:23PM +1100, Alexey Kardashevskiy wrote: > SLOF instantiates RTAS since > 744a928ccee9 ("spapr: Stop providing RTAS blob") > so the max address applies to the FDT only. > > This renames the macro and fixes up the comment. > > This should not cause any behavioral chang

[PATCH v2 6/8] hw/intc: GICv3 redistributor ITS processing

2021-03-31 Thread Shashi Mallela
Implemented lpi processing at redistributor to get lpi config info from lpi configuration table,determine priority,set pending state in lpi pending table and forward the lpi to cpuif.Added logic to invoke redistributor lpi processing with translated LPI which set/clear LPI from ITS device as part o

[PATCH v2 5/8] hw/intc: GICv3 ITS Feature enablement

2021-03-31 Thread Shashi Mallela
Added properties to enable ITS feature and define qemu system address space memory in gicv3 common,setup distributor and redistributor registers to indicate LPI support. Signed-off-by: Shashi Mallela --- hw/intc/arm_gicv3_common.c | 16 hw/intc/arm_gicv3_dist.c

[PATCH v2 8/8] hw/arm/virt: add ITS support in virt GIC

2021-03-31 Thread Shashi Mallela
Included creation of ITS as part of virt platform GIC initialization.This Emulated ITS model now co-exists with kvm ITS and is enabled in absence of kvm irq kernel support in a platform. Signed-off-by: Shashi Mallela --- hw/arm/virt.c| 10 -- target/arm/kvm_arm.h | 4 ++-- 2 fil

[PATCH v2 4/8] hw/intc: GICv3 ITS Command processing

2021-03-31 Thread Shashi Mallela
Added ITS command queue handling for MAPTI,MAPI commands,handled ITS translation which triggers an LPI via INT command as well as write to GITS_TRANSLATER register,defined enum to differentiate between ITS command interrupt trigger and GITS_TRANSLATER based interrupt trigger. Each of these commands

[PATCH v2 7/8] hw/arm/sbsa-ref: add ITS support in SBSA GIC

2021-03-31 Thread Shashi Mallela
Included creation of ITS as part of SBSA platform GIC initialization. Signed-off-by: Shashi Mallela --- hw/arm/sbsa-ref.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 88dfb2284c..d05cbcae48 100644 ---

[PATCH v2 3/8] hw/intc: GICv3 ITS command queue framework

2021-03-31 Thread Shashi Mallela
Added functionality to trigger ITS command queue processing on write to CWRITE register and process each command queue entry to identify the command type and handle commands like MAPD,MAPC,SYNC. Signed-off-by: Shashi Mallela --- hw/intc/arm_gicv3_its.c | 347

[PATCH v2 1/8] hw/intc: GICv3 ITS initial framework

2021-03-31 Thread Shashi Mallela
Added register definitions relevant to ITS,implemented overall ITS device framework with stubs for ITS control and translater regions read/write,extended ITS common to handle mmio init between existing kvm device and newer qemu device. Signed-off-by: Shashi Mallela --- hw/intc/arm_gicv3_its.c

[PATCH v2 2/8] hw/intc: GICv3 ITS register definitions added

2021-03-31 Thread Shashi Mallela
Defined descriptors for ITS device table,collection table and ITS command queue entities.Implemented register read/write functions, extract ITS table parameters and command queue parameters,extended gicv3 common to capture qemu address space(which host the ITS table platform memories required for s

[PATCH v2 0/8] GICv3 LPI and ITS feature implementation

2021-03-31 Thread Shashi Mallela
This patchset implements qemu device model for enabling physical LPI support and ITS functionality in GIC as per GICv3 specification. Both flat table and 2 level tables are implemented.The ITS commands for adding/deleting ITS table entries,trigerring LPI interrupts are implemented.Translated LPI i

Re: [PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-31 Thread David Gibson
On Thu, Apr 01, 2021 at 06:35:19AM +0530, Vaibhav Jain wrote: > Add support for H_SCM_HEALTH hcall described at [1] for spapr > nvdimms. This enables guest to detect the 'unarmed' status of a > specific spapr nvdimm identified by its DRC and if its unarmed, mark > the region backed by the nvdimm as

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 11:49:14AM +0200, Igor Mammedov wrote: > On Wed, 31 Mar 2021 10:46:49 +1100 > David Gibson wrote: > > > On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: > > > On Wed, 24 Mar 2021 16:09:59 -0300 > > > Daniel Henrique Barboza wrote: > > > > > > > On 3/23/21

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread David Gibson
On Wed, Mar 31, 2021 at 04:47:14PM -0300, Daniel Henrique Barboza wrote: > > > On 3/30/21 8:46 PM, David Gibson wrote: > > On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: > > > On Wed, 24 Mar 2021 16:09:59 -0300 > > > Daniel Henrique Barboza wrote: > > > > > > > On 3/23/21 10:40

[PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

2021-03-31 Thread Vaibhav Jain
Add support for H_SCM_HEALTH hcall described at [1] for spapr nvdimms. This enables guest to detect the 'unarmed' status of a specific spapr nvdimm identified by its DRC and if its unarmed, mark the region backed by the nvdimm as read-only. The patch adds h_scm_health() to handle the H_SCM_HEALTH

Re: [PATCH qemu v16] spapr: Implement Open Firmware client interface

2021-03-31 Thread Alexey Kardashevskiy
On 31/03/2021 12:03, David Gibson wrote: On Thu, Mar 25, 2021 at 02:25:33PM +1100, Alexey Kardashevskiy wrote: On 25/03/2021 13:52, David Gibson wrote: On Tue, Mar 23, 2021 at 01:58:30PM +1100, Alexey Kardashevskiy wrote: The PAPR platform which describes an OS environment that's presente

[PATCH 2/2] spapr.c: always pulse guest IRQ in spapr_core_unplug_request()

2021-03-31 Thread Daniel Henrique Barboza
Commit 47c8c915b162 fixed a problem where multiple spapr_drc_detach() requests were breaking QEMU. The solution was to just spapr_drc_detach() once, and use spapr_drc_unplug_requested() to filter whether we already detached it or not. The commit also tied the hotplug request to the guest in the sam

[PATCH 1/2] spapr: rollback 'unplug timeout' for CPU hotunplugs

2021-03-31 Thread Daniel Henrique Barboza
The pseries machines introduced the concept of 'unplug timeout' for CPU hotunplugs. The idea was to circunvent a deficiency in the pSeries specification (PAPR), that currently does not define a proper way for the hotunplug to fail. If the guest refuses to release the CPU (see [1] for an example) th

[PATCH 0/2] pSeries: revert CPU unplug timeout

2021-03-31 Thread Daniel Henrique Barboza
Hi, This series reverts the CPU hotunplug timeout mechanism that was added during the 6.0.0 cycle. See patch 1 for the reasoning behind this decision. Patch 2 is a re-post of a patch that allows CPU hotunplug events to be re-send to the guest [1], regardless of any existing hotunplug pending stat

Re: [PATCH v1 2/8] hw/intc: GICv3 ITS register definitions added

2021-03-31 Thread Richard Henderson
On 3/31/21 9:48 AM, shashi.mall...@linaro.org wrote: +if (!(s->ctlr & GITS_CTLR_ENABLED)) { +s->cbaser = value; +if (!extract_cmdq_params(s)) { +qemu_log_mask(LOG_GUEST_ERROR, + "%s: error extracting GITS_CBASER parameters " +

Re: Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Eric Blake
On 3/31/21 3:26 PM, Lukas Straub wrote: >> Per docs/system/removed-features.rst, the change was intentional: >> >>> ``object-add`` option ``props`` (removed in 6.0) >>> >>> >>> Specify the properties for the object as top-level arguments instead.

Re: [PATCH] block/export: improve vu_blk_sect_range_ok()

2021-03-31 Thread Eric Blake
On 3/31/21 9:27 AM, Stefan Hajnoczi wrote: > The checks in vu_blk_sect_range_ok() assume VIRTIO_BLK_SECTOR_SIZE is > equal to BDRV_SECTOR_SIZE. This is true, but let's add a > QEMU_BUILD_BUG_ON() to make it explicit. > > We might as well check that the request buffer size is a multiple of > VIRTIO

Re: [PATCH] iotests: Test mirror-top filter permissions

2021-03-31 Thread Eric Blake
On 3/31/21 7:28 AM, Max Reitz wrote: > Add a test accompanying commit 53431b9086b2832ca1aeff0c55e186e9ed79bd11 > ("block/mirror: Fix mirror_top's permissions"). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/tests/mirror-top-perms | 121 ++ > tests/qemu-iotests/tests

Re: Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Lukas Straub
On Wed, 31 Mar 2021 15:16:18 -0500 Eric Blake wrote: > On 3/31/21 3:00 PM, Lukas Straub wrote: > > Hi, > > This qmp command that used to work: > > {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id": > > "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",

Re: Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Eric Blake
On 3/31/21 3:00 PM, Lukas Straub wrote: > Hi, > This qmp command that used to work: > {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id": > "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0", > "vnet_hdr_support": false}}} > now fails with the following err

[PATCH v6 2/4] Add NVMM accelerator: x86 CPU support

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- target/i386/meson.build |1 + target/i386/nvmm/meson.build |4 + target/i386/nvmm/nvmm-accel-ops.c | 111 +++ target/i386/nvmm/nvmm-accel-ops.h | 25 + target/i386/nvmm/nvmm-all.c | 1231 +

[PATCH v6 4/4] Add NVMM Accelerator: add maintainers for NetBSD/NVMM

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 554be84b32..cf9d81ea7c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -510,6 +510,15 @@ F: accel/stubs/hax-stub.c F: in

[PATCH v6 0/4] Implements the NetBSD Virtual Machine Monitor accelerator

2021-03-31 Thread Reinoud Zandijk
The NetBSD team has been working hard on a new user-mode API for our hypervisor that will be released as part of the upcoming NetBSD 9.0. The NetBSD team has implemented its new hypervisor called NVMM. It has been included since NetBSD 9.0 and has been in use now for quite some time. NVMM adds use

[PATCH v6 1/4] Add NVMM accelerator: configure and build logic

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- accel/Kconfig | 3 +++ configure | 12 +--- meson.build | 23 --- meson_options.txt | 2 ++ qemu-options.hx | 8 5 files changed, 38 insertions(+), 10 deletions(-) dif

[PATCH v6 3/4] Add NVMM accelerator: acceleration enlightenments

2021-03-31 Thread Reinoud Zandijk
Signed-off-by: Reinoud Zandijk Signed-off-by: Kamil Rytarowski --- include/sysemu/hw_accel.h | 1 + include/sysemu/nvmm.h | 26 ++ target/i386/helper.c | 2 +- 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 include/sysemu/nvmm.h diff --g

Bug: object-add qmp command that used to work fails now

2021-03-31 Thread Lukas Straub
Hi, This qmp command that used to work: {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id": "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0", "vnet_hdr_support": false}}} now fails with the following error: {"error": {"class": "GenericError", "desc": "Par

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Daniel Henrique Barboza
On 3/30/21 8:46 PM, David Gibson wrote: On Tue, Mar 30, 2021 at 01:28:31AM +0200, Igor Mammedov wrote: On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: On 3/23/21 10:40 PM, David Gibson wrote: On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: On

Re: [PATCH 0/4] DEVICE_NOT_DELETED/DEVICE_UNPLUG_ERROR QAPI events

2021-03-31 Thread Daniel Henrique Barboza
On 3/29/21 8:28 PM, Igor Mammedov wrote: On Wed, 24 Mar 2021 16:09:59 -0300 Daniel Henrique Barboza wrote: On 3/23/21 10:40 PM, David Gibson wrote: On Tue, Mar 23, 2021 at 02:10:22PM -0300, Daniel Henrique Barboza wrote: On 3/22/21 10:12 PM, David Gibson wrote: On Fri, Mar 12, 2021 at

Re: [PATCH] migration: Remove time_t cast for OpenBSD

2021-03-31 Thread Brad Smith
On 3/13/2021 6:33 PM, Brad Smith wrote: On 3/11/2021 1:39 PM, Daniel P. Berrangé wrote: On Thu, Mar 11, 2021 at 06:28:57PM +, Dr. David Alan Gilbert wrote: * Laurent Vivier (laur...@vivier.eu) wrote: Le 08/03/2021 à 12:46, Thomas Huth a écrit : On 22/02/2021 08.28, Brad Smith wrote: OpenB

Re: [PATCH] gitlab-ci.yml: Test the dtrace backend in one of the jobs

2021-03-31 Thread Alex Bennée
Thomas Huth writes: > We are using the dtrace backend in downstream RHEL, so testing this > in the CentOS 8 task seems to be a good fit. > > Signed-off-by: Thomas Huth Queued to for-6.0/fixes-for-rc2, thanks. -- Alex Bennée

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread Alex Bennée
Paolo Bonzini writes: > + > +This isn't an exhaustive list of things that you can't do. Rather, take > +it in the spirit in which it's intended—a guide to make it easier to > +be excellent to each other. I think a colon might work better here: Rather, take it in the spirit in which it's in

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-31 Thread Catalin Marinas
On Wed, Mar 31, 2021 at 11:41:20AM +0100, Steven Price wrote: > On 31/03/2021 10:32, David Hildenbrand wrote: > > On 31.03.21 11:21, Catalin Marinas wrote: > > > On Wed, Mar 31, 2021 at 09:34:44AM +0200, David Hildenbrand wrote: > > > > On 30.03.21 12:30, Catalin Marinas wrote: > > > > > On Mon, Ma

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread Andrey Gruzdev
On 31.03.2021 20:37, David Hildenbrand wrote: On 31.03.21 19:33, David Hildenbrand wrote: On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPRO

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread Andrey Gruzdev
On 31.03.2021 20:33, David Hildenbrand wrote: On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for that

Status update for maintainers file

2021-03-31 Thread Sarah Harris
Hi all, I was added as a reviewer (in MAINTAINERS) for the AVR target for the duration of my research work using it. The funding for my project expires in the middle of April, so I will not be able to provide time for reviewing patches from that point. I'm not sure what the process is for remov

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-31 Thread Cédric Le Goater
On 3/31/21 7:29 PM, Daniel Henrique Barboza wrote: > > On 3/31/21 12:18 PM, Cédric Le Goater wrote: >> On 3/31/21 2:57 AM, David Gibson wrote: >>> On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: On 3/29/21 12:32 PM, Cédric Le Goater wrote: > On 3/29/21 6

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread David Hildenbrand
On 31.03.21 19:33, David Hildenbrand wrote: On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for that p

Re: [PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread David Hildenbrand
On 31.03.21 19:28, Andrey Gruzdev wrote: This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for that page, thereby loosing WP setting for it. So w

Re: [PATCH 1/2] spapr: number of SMP sockets must be equal to NUMA nodes

2021-03-31 Thread Daniel Henrique Barboza
On 3/31/21 12:18 PM, Cédric Le Goater wrote: On 3/31/21 2:57 AM, David Gibson wrote: On Mon, Mar 29, 2021 at 03:32:37PM -0300, Daniel Henrique Barboza wrote: On 3/29/21 12:32 PM, Cédric Le Goater wrote: On 3/29/21 6:20 AM, David Gibson wrote: On Thu, Mar 25, 2021 at 09:56:04AM +0100, Cédr

[PATCH for-6.0 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

2021-03-31 Thread Andrey Gruzdev
Added missing qemu_fflush() on buffer file holding precopy device state. Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs. Typical configurations often require >200KB for device state and VMDESC. Signed-off-by: Andrey Gruzdev --- migration/migration.c | 8 +++- 1 file

[PATCH for-6.0 0/3] migration: Fixes to the 'background-snapshot' code

2021-03-31 Thread Andrey Gruzdev
This patch series contains: * Fix to the issue with occasionally truncated non-iterable device state * Solution to compatibility issues with virtio-balloon device * Fix to the issue when discarded or never populated pages miss UFFD write protection and get into migration stream in dirty state

[PATCH for-6.0 3/3] migration: Pre-fault memory before starting background snasphot

2021-03-31 Thread Andrey Gruzdev
This commit solves the issue with userfault_fd WP feature that background snapshot is based on. For any never poluated or discarded memory page, the UFFDIO_WRITEPROTECT ioctl() would skip updating PTE for that page, thereby loosing WP setting for it. So we need to pre-fault pages for each RAM bloc

[PATCH for-6.0 2/3] migration: Inhibit virtio-balloon for the duration of background snapshot

2021-03-31 Thread Andrey Gruzdev
The same thing as for incoming postcopy - we cannot deal with concurrent RAM discards when using background snapshot feature in outgoing migration. Signed-off-by: Andrey Gruzdev Reviewed-by: David Hildenbrand --- hw/virtio/virtio-balloon.c | 8 ++-- include/migration/misc.h | 2 ++ migrat

Re: [PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

2021-03-31 Thread Andrey Gruzdev
On 31.03.2021 19:02, Peter Xu wrote: On Wed, Mar 31, 2021 at 06:48:06PM +0300, Andrey Gruzdev wrote: Changes v1->v2: * Added comment over the overlooked qemu_flush() in bg_migration_thread Changes v0->v1: * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host page size in

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread David Edmondson
On Wednesday, 2021-03-31 at 17:05:27 +02, Paolo Bonzini wrote: > In an ideal world, we would all get along together very well, always be > polite and never end up in huge conflicts. And even if there are conflicts, > we would always handle each other fair and respectfully. Unfortunately, > this is

Re: [PATCH v1 2/8] hw/intc: GICv3 ITS register definitions added

2021-03-31 Thread shashi . mallela
On Thu, 2021-03-25 at 19:34 +, Alex Bennée wrote: > Shashi Mallela writes: > > > Defined descriptors for ITS device table,collection table and ITS > > command queue entities.Implemented register read/write functions, > > extract ITS table parameters and command queue parameters,extended > > g

[PATCH v4 cxl-2.0-doe 3/3] PCIe standard header for DOE

2021-03-31 Thread Chris Browy
From: hchkuo Signed-off-by: hchkuo --- include/hw/pci/pci_ids.h | 2 ++ include/hw/pci/pcie_regs.h| 3 +++ include/standard-headers/linux/pci_regs.h | 3 ++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/

[PATCH v4 cxl-2.0-doe 2/3] CXL Data Object Exchange implementation

2021-03-31 Thread Chris Browy
From: hchkuo Signed-off-by: hchkuo --- hw/cxl/cxl-cdat.c | 220 + hw/cxl/meson.build | 1 + hw/mem/cxl_type3.c | 200 +++ include/hw/cxl/cxl_cdat.h | 149 include/hw/cxl/cxl_

Re: [PATCH] gitlab-ci.yml: Use unrecoverable address sanitizer

2021-03-31 Thread Alexander Bulekov
On 210331 1805, Thomas Huth wrote: > Make sure that errors don't go unnoticed by using the unrecoverable > sanitizer switch here, too. > > Signed-off-by: Thomas Huth > --- I thought sanitizer recovery is disabled by default for ASan. I've only seen it enabled by default for UBSan. The docs seem

[PATCH v4 cxl-2.0-doe 1/3] PCIe Data Object Exchange implementation

2021-03-31 Thread Chris Browy
From: hchkuo Signed-off-by: hchkuo --- MAINTAINERS | 7 + hw/pci/meson.build| 1 + hw/pci/pcie_doe.c | 356 ++ include/hw/pci/pcie.h | 1 + include/hw/pci/pcie_doe.h | 123 5 files changed, 488

Re: [RFC 3/8] virtio: Add API to batch set host notifiers

2021-03-31 Thread Greg Kurz
On Wed, 31 Mar 2021 15:47:45 +0100 Stefan Hajnoczi wrote: > On Tue, Mar 30, 2021 at 04:17:32PM +0200, Greg Kurz wrote: > > On Tue, 30 Mar 2021 14:55:42 +0100 > > Stefan Hajnoczi wrote: > > > > > On Tue, Mar 30, 2021 at 12:17:40PM +0200, Greg Kurz wrote: > > > > On Mon, 29 Mar 2021 18:10:57 +010

[PATCH 2/3] pcie_chassis: add slot_max field

2021-03-31 Thread Tom Yan
Keep track of the largested allocated slot number when adding slot. Signed-off-by: Tom Yan --- hw/pci/pcie_port.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c index 40fd80c4da..1e2348250c 100644 --- a/hw/pci/pcie_por

Re: [PATCH] gitlab-ci.yml: Test the dtrace backend in one of the jobs

2021-03-31 Thread Willian Rampazzo
On Wed, Mar 31, 2021 at 1:04 PM Thomas Huth wrote: > > We are using the dtrace backend in downstream RHEL, so testing this > in the CentOS 8 task seems to be a good fit. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.yml | 2 +- > tests/docker/dockerfiles/centos8.dock

[PATCH v4 cxl-2.0-doe 0/3] QEMU PCIe DOE for PCIe and CXL2.0

2021-03-31 Thread Chris Browy
Version 4 patch series for PCIe DOE for PCIe and CXL 2.0 completes all planned functionality. Based on QEMU version: https://gitlab.com/bwidawsk/qemu/-/tree/cxl-2.0v4 Summary of changes: 1: PCIe DOE support for Discovery - Fix the alignment error in DOE config write - Fix the interr

[PATCH] gitlab-ci.yml: Use unrecoverable address sanitizer

2021-03-31 Thread Thomas Huth
Make sure that errors don't go unnoticed by using the unrecoverable sanitizer switch here, too. Signed-off-by: Thomas Huth --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4c43dd2570..846d3932cf 100644 --- a/.gitlab-ci

[PATCH 1/3] pcie_chassis: use an available slot number if not explicity set

2021-03-31 Thread Tom Yan
Currently pcie_chassis_add_slot() simply fails if the requested slot number is already used. Make it find and use an available slot number if the requested one does not appear to be explicitly set (i.e. is 0). This allows slot numbers to be enumerated automatically. Maintain the current behaviour

Re: [PATCH] docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document

2021-03-31 Thread Paolo Bonzini
Il mer 31 mar 2021, 17:48 Thomas Huth ha scritto: > > +This isn't an exhaustive list of things that you can't do. Rather, take > > +it in the spirit in which it's intended—a guide to make it easier to > > s/intended—a/intended — a/ > It looks ugly in monospace but it's the way em dashes are typi

Re: [PATCH v2 0/3] migration: Fixes to the 'background-snapshot' code

2021-03-31 Thread Peter Xu
On Wed, Mar 31, 2021 at 06:48:06PM +0300, Andrey Gruzdev wrote: > Changes v1->v2: > * Added comment over the overlooked qemu_flush() in bg_migration_thread > > Changes v0->v1: > * Using qemu_real_host_page_size instead of TARGET_PAGE_SIZE for host >page size in ram_block_populate_pages() >

Re: [PATCH 1/8] hw/riscv: sifive_u: Switch to use qemu_fdt_setprop_string_array() helper

2021-03-31 Thread Richard Henderson
On 3/29/21 10:08 AM, Bin Meng wrote: -char ethclk_names[] = "pclk\0hclk"; +const char *ethclk_names[2] = { "pclk", "hclk" }; static const char * const ethclk_names[2] r~

[PATCH 3/3] pcie_root_port: reorder procedures in realize()

2021-03-31 Thread Tom Yan
There are a bunch of pcie_cap_*_init() in the realize method of the pcie root port devices that do not have return value. They can probably be called after the slot is successfully added to an created chassis (i.e. the slot number to use is final). of them makes use of the slot number. Signed-off-

  1   2   3   >