[PATCH] hw: Do not include qemu/log.h if it is not necessary

2021-03-27 Thread Thomas Huth
Many files include qemu/log.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth --- hw/arm/aspeed.c | 1 - hw/arm/aspeed_ast2600.c | 1 - hw/arm/aspeed_soc.c | 1 - hw/arm/exynos4210.c | 1 -

[PATCH] Revert "qom: use qemu_printf to print help for user-creatable objects"

2021-03-27 Thread Thomas Huth
This reverts commit 6d9abb6de9cc53a508823db0283061824f2f98a2. The real code change had already been added by Kevin's commit da0a932bbf ("hmp: QAPIfy object_add") and commit 6d9abb6d just added a duplicated include statement as a left-over of a rebase. Signed-off-by: Thomas Huth --- qom/object_i

Re: [PATCH V3] target/riscv: Align the data type of reset vector address

2021-03-27 Thread Alistair Francis
On Fri, Mar 26, 2021 at 7:11 AM Peter Maydell wrote: > > On Fri, 26 Mar 2021 at 10:21, Dylan Jhong wrote: > > Currently, there is no structure like "qdev_prop_target_ulong". > > So, we still need to use an if-else condition to determine the attributes > > of the 5th parameter. > > Something like

Re: [PATCH] hw: Do not include hw/irq.h if it is not necessary

2021-03-27 Thread Alistair Francis
On Sat, Mar 27, 2021 at 1:02 AM Thomas Huth wrote: > > Many files include hw/irq.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth Reviewed-by: Alistair Francis Alistair > --- > hw/arm/msf2-soc.c | 1 - > hw/i386/kvm/ioapic.c|

Re: [RFC PATCH-for-6.1 00/10] hw/misc: Add memory_region_add_subregion_aliased() helper

2021-03-27 Thread Mark Cave-Ayland
On 26/03/2021 00:27, Philippe Mathieu-Daudé wrote: Hi, This series introduce the memory_region_add_subregion_aliased() helper which basically create a device which maps a subregion multiple times. Examples are easier, so having a subregion aliased every @span_size then mapped onto a container

Re: [PATCH v3 0/5] memory: Add 'priority' property setter

2021-03-27 Thread Peter Maydell
On Sat, 27 Mar 2021 at 18:44, Philippe Mathieu-Daudé wrote: > > On 3/27/21 5:58 PM, Peter Maydell wrote: > > On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé > > wrote: > >> > >> The first patch is an old fix, it would be nice to get it > >> merged eventually, but not a problem during years,

Re: [PATCH v3 0/5] memory: Add 'priority' property setter

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 5:58 PM, Peter Maydell wrote: > On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé wrote: >> >> The first patch is an old fix, it would be nice to get it >> merged eventually, but not a problem during years, so can >> also wait 6.1. >> >> The second patch add the memory_region_set_pri

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 7:35 PM, Philippe Mathieu-Daudé wrote: > On 3/27/21 7:19 PM, Thomas Huth wrote: >> On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, >>> >>> 6 more candidates? >> >> No, since those use TYPE_SYS_BUS_DEVICE and thus require hw/sysbus.h. > > Ah indeed, this line matches y

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 7:19 PM, Thomas Huth wrote: > On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 3/27/21 9:28 AM, Thomas Huth wrote: >>> Many files include hw/sysbus.h without needing it. Remove the >>> superfluous >>> include statements. >>> >>> Signed-off-by: Thomas Huth >>>

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Thomas Huth
On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: Hi Thomas, On 3/27/21 9:28 AM, Thomas Huth wrote: Many files include hw/sysbus.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth --- hw/arm/cubieboard.c | 1 - hw/arm/orangepi.c |

Re: [PATCH v3 0/5] memory: Add 'priority' property setter

2021-03-27 Thread Peter Maydell
On Sat, 27 Mar 2021 at 14:34, Philippe Mathieu-Daudé wrote: > > The first patch is an old fix, it would be nice to get it > merged eventually, but not a problem during years, so can > also wait 6.1. > > The second patch add the memory_region_set_priority() helper > useful to memory controller devi

Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature

2021-03-27 Thread Catalin Marinas
On Fri, Mar 12, 2021 at 03:18:58PM +, Steven Price wrote: > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 77cb2d28f2a4..b31b7a821f90 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -879,6 +879,22 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, > phy

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
Hi Thomas, On 3/27/21 9:28 AM, Thomas Huth wrote: > Many files include hw/sysbus.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/cubieboard.c | 1 - > hw/arm/orangepi.c | 1 - > hw/char/riscv_htif.c| 1 -

[PATCH-for-6.1 v3 5/5] memory: Add setter for MemoryRegion object 'priority' property

2021-03-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- softmmu/memory.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 1a5b8a62eb9..371e52b300e 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1227,6 +1227,18 @@ static void

[PATCH-for-6.1 v3 4/5] memory: Add setter for MemoryRegion object 'size' property

2021-03-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- softmmu/memory.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 3f4cd4e85d7..1a5b8a62eb9 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -1237,6 +1237,18 @@ static void

[PATCH-for-6.1 v3 2/5] memory: Add memory_region_set_priority()

2021-03-27 Thread Philippe Mathieu-Daudé
Add an helper to change the priority of a memory region at runtime. Suggested-by: Alexey Kardashevskiy Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 10 ++ softmmu/memory.c | 11 +++ 2 files changed, 21 insertions(+) diff --git a/include/exec/memory.h b

[PATCH-for-6.1 v3 3/5] memory: Rename MemoryRegion object getters

2021-03-27 Thread Philippe Mathieu-Daudé
We want to add the corresponding object setters, but the memory_region_set_size() / memory_region_set_priority() functions already exist. Rename the getters so match with the setters we are going to add in the next patches. Signed-off-by: Philippe Mathieu-Daudé --- softmmu/memory.c | 19

[PATCH-for-6.0 v3 1/5] memory: Fix memory_region 'priority' property sign

2021-03-27 Thread Philippe Mathieu-Daudé
Priorities can be negative, fix this limitation. Fixes: d33382da9ab ("memory: MemoryRegion: Add may-overlap and priority props") Signed-off-by: Philippe Mathieu-Daudé --- softmmu/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/memory.c b/softmmu/memory.c inde

[PATCH v3 0/5] memory: Add 'priority' property setter

2021-03-27 Thread Philippe Mathieu-Daudé
The first patch is an old fix, it would be nice to get it merged eventually, but not a problem during years, so can also wait 6.1. The second patch add the memory_region_set_priority() helper useful to memory controller devices. The rest add the 'size'/'priority' object setters. Supersedes: <201

Re: [PATCH v2 3/4] memory: Fix memory_region 'priority' property sign

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 2:57 PM, Philippe Mathieu-Daudé wrote: > ping? Bah this doesn't apply anymore (memory.c moved to softmmu/). I'll respin. > On Thu, Apr 5, 2018 at 3:23 AM Philippe Mathieu-Daudé wrote: >> >> Priorities can be negative, fix this limitation. >> >> Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 3/4] memory: Fix memory_region 'priority' property sign

2021-03-27 Thread Philippe Mathieu-Daudé
ping? On Thu, Apr 5, 2018 at 3:23 AM Philippe Mathieu-Daudé wrote: > > Priorities can be negative, fix this limitation. > > Signed-off-by: Philippe Mathieu-Daudé > --- > memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/memory.c b/memory.c > index e77f9e4036..eaa

Re: [RFC v11 47/55] target/arm: make is_aa64 and arm_el_is_aa64 a macro for !TARGET_AARCH64

2021-03-27 Thread Richard Henderson
On 3/26/21 1:05 PM, Claudio Fontana wrote: On 3/25/21 8:03 PM, Richard Henderson wrote: On 3/23/21 9:46 AM, Claudio Fontana wrote: +#define is_a64(env) (false) ... +#define arm_el_is_aa64(env, el) (false) Why a define and not have the ifdef inside the static inline? This define is causing

Re: [PATCH v5 10/10] target/ppc: Validate hflags with CONFIG_DEBUG_TCG

2021-03-27 Thread Richard Henderson
On 3/26/21 6:41 AM, Richard Henderson wrote: On 3/25/21 2:47 AM, David Gibson wrote: On Wed, Mar 24, 2021 at 11:12:20AM +1100, David Gibson wrote: On Tue, Mar 23, 2021 at 12:43:40PM -0600, Richard Henderson wrote: Verify that hflags was updated correctly whenever we change cpu state that is us

Re: [PATCH v2] linux-user: allow NULL msg in recvfrom

2021-03-27 Thread Laurent Vivier
Le 27/03/2021 à 03:11, Zach Reizner a écrit : > The kernel allows a NULL msg in recvfrom so that he size of the next > message may be queried before allocating a correctly sized buffer. This > change allows the syscall translator to pass along the NULL msg pointer > instead of returning early with

[PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Thomas Huth
Many files include hw/sysbus.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth --- hw/arm/cubieboard.c | 1 - hw/arm/orangepi.c | 1 - hw/char/riscv_htif.c| 1 - hw/char/sifive_uart.c | 1 - hw/char/virtio-serial-bus.c | 1