On Fri, Feb 12, 2021 at 01:37:18PM -0800, Alistair Francis wrote:
> On Thu, Feb 11, 2021 at 12:36 AM Sai Pavan Boddu
> wrote:
> >
> > Configuring SDHCI-0 to act as eMMC controller.
> >
> > Signed-off-by: Sai Pavan Boddu
>
> Reviewed-by: Alistair Francis
>
> Alistair
Hi Sai,
It would be gre
2021年2月13日(土) 12:20 Programmingkid :
> I am also an M1 Mac owner. I don't know very much about graphics cards but I
> would be happy to help if you need a tester.
I don't need a tester now because I have not fixed even likely-obvious
performance and compatibility problems which I can find out eas
When qemu is built with modules, but a given module doesn't load
qemu should handle that gracefully. When ui-spice-core.so isn't
able to be loaded and qemu is invoked with -display spice-app or
-spice, qemu will dereference a null pointer. With this change we
check the pointer before dereferencing
> On Feb 12, 2021, at 4:25 AM, qemu-devel-requ...@nongnu.org wrote:
>
> Message: 2
> Date: Fri, 12 Feb 2021 12:52:21 +0900
> From: 小田喜陽彦
> To: qemu-devel@nongnu.org, virglrenderer-de...@lists.freedesktop.org
> Subject: Virgil 3D renderer on macOS
> Message-ID:
>
> Content-Type: text/pla
On 2/12/21 4:26 PM, Philippe Mathieu-Daudé wrote:
> Simplify the PCPYH (Parallel Copy Halfword) instruction by using
> multiple calls to deposit_i64() which can be optimized by some
> TCG backends.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> v2: Send the Halfword version :)
> ---
> target/
On Thu, Feb 11, 2021 at 11:48 AM Peter Maydell
wrote:
> On Thu, 11 Feb 2021 at 11:34, Peter Maydell
> wrote:
> >
> > On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote:
> > >
> > > This is a 10/100 ethernet device that has several features.
> > > Only the ones needed by the Linux driver have been im
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Reviewed-by: Peter Maydell
Signed-off-by: Doug Evans
---
Differences from v3:
- handle big endian hosts, tested on sparc64
Differences from v2:
- remove use of C99 mixed decls/statements
tests/qtest/meson.build| 1 +
tests/qtest/npcm7xx
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Reviewed-by: Peter Maydell
Signed-off-by: Doug Evans
---
Differences
Simplify the PCPYH (Parallel Copy Halfword) instruction by using
multiple calls to deposit_i64() which can be optimized by some
TCG backends.
Signed-off-by: Philippe Mathieu-Daudé
---
v2: Send the Halfword version :)
---
target/mips/translate.c | 36 ++--
1 file c
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Doug Evans (3):
hw/net: Add npcm7xx emc model
hw/arm: Add npcm7xx emc model
tests/qtests: Add npcm7xx emc model
This is a 10/100 ethernet device that has several features.
Only the ones needed by the Linux driver have been implemented.
See npcm7xx_emc.c for a list of unimplemented features.
Reviewed-by: Hao Wu
Reviewed-by: Avi Fishman
Reviewed-by: Peter Maydell
Signed-off-by: Doug Evans
---
Differences
On 2/13/21 1:19 AM, Philippe Mathieu-Daudé wrote:
> Simplify the PCPYH (Parallel Copy Halfword) instruction by using
> multiple calls to deposit_i64() which can be optimized by some
> TCG backends.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/mips/translate.c | 36 ++-
Simplify the PCPYH (Parallel Copy Halfword) instruction by using
multiple calls to deposit_i64() which can be optimized by some
TCG backends.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/translate.c | 36 ++--
1 file changed, 6 insertions(+), 30 deletions
From: Peter Krempa
Verify that the modification of the bitmap persistence over migration
which is controlled via BitmapMigrationBitmapAliasTransform works
properly.
Based on TestCrossAliasMigration
Signed-off-by: Peter Krempa
Message-Id:
Reviewed-by: Eric Blake
[eblake: Adjust test for expl
From: Vladimir Sementsov-Ogievskiy
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Message-Id: <20210202124956.63146-3-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block.c
From: Peter Krempa
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so pass a copy of the whole
BitmapMigrationBitmapAlias QAPI struct into the map.
Signed-off-by: Pete
From: Peter Krempa
Bitmap's source persistence is transported over the migration stream and
the destination mirrors it. In some cases the destination might want to
persist bitmaps which are not persistent on the source (e.g. the result
of merging bitmaps from a number of layers on the source when
From: Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.
Choose int return status,
The following changes since commit eac92d316351b855ba79eb374dd21cc367f1f9c1:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20210211-1' into staging (2021-02-11
19:57:50 +)
are available in the Git repository at:
https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-
On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> This patch is generated by cocci script:
>
> @@
> symbol bdrv_open_child, errp, local_err;
> expression file;
> @@
>
> file = bdrv_open_child(...,
> -&local_err
> +errp
>
> On Feb 12, 2021, at 12:23 PM, Jonathan Cameron
> wrote:
>
> On Tue, 9 Feb 2021 15:36:03 -0500
> Chris Browy wrote:
>
> Split this into two patches for v3. CDAT in one, compliance mode in the
> other.
>
Compliance mode is an optional feature. We’ll split it out.
> I'd also move the a
On 2/2/21 6:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> Set errp always on failure. Generic bdrv_open_driver supports driver
> functions which can return negative value and forget to set errp.
> That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
> this way. This allows to simpli
On Thu, Feb 11, 2021 at 12:15 AM Sai Pavan Boddu
wrote:
>
> From: Joel Stanley
>
> This assumes a specially constructued image:
>
> dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M
> dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc
> dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc c
On Thu, Feb 11, 2021 at 12:34 AM Sai Pavan Boddu
wrote:
>
> Embedded device slots should be allowed as support of eMMC is available.
>
> Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/sd/sdhci.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/
On Thu, Feb 11, 2021 at 12:25 AM Sai Pavan Boddu
wrote:
>
> From: Joel Stanley
>
> The userdata size is derived from the file the user passes on the
> command line, but we must take into account the boot areas.
>
> Signed-off-by: Joel Stanley
> Signed-off-by: Cédric Le Goater
Acked-by: Alistai
On Thu, Feb 11, 2021 at 12:30 AM Sai Pavan Boddu
wrote:
>
> CID structure is little different for eMMC, w.r.t to product name and
> manufacturing date.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
> ---
> hw/sd/sd.c | 52 +++--
On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu
wrote:
>
> Add CMD35 and CMD36 which sets the erase start and end.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
> ---
> hw/sd/sd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index
On Thu, Feb 11, 2021 at 12:18 AM Sai Pavan Boddu
wrote:
>
> eMMC is expected to be in idle-state post CMD1. Ready state is an
> intermediate stage which we don't come across in Device identification
> mode.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Acked-by: Alistair
On Thu, Feb 11, 2021 at 12:17 AM Sai Pavan Boddu
wrote:
>
> Add support to Power up the card and send response r3 in case of eMMC.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Acked-by: Alistair Francis
Alistair
> ---
> hw/sd/sd.c | 10 +-
> 1 file changed,
On Fri, Jan 22, 2021 at 4:32 AM Bin Meng wrote:
>
> From: Bin Meng
>
> This series does the following clean-ups:
> - Drop 'struct MemmapEntry'
> - virt: Drop the 'link_up' parameter of gpex_pcie_init()
>
> It also adds the following small enhancement to 'virt' machine:
> - Limit RAM size in a 32-
> On Feb 12, 2021, at 11:24 AM, Jonathan Cameron
> wrote:
>
> On Tue, 9 Feb 2021 15:35:49 -0500
> Chris Browy wrote:
>
> Run ./scripts/checkpatch.pl over the patches and fix all the warnings before
> posting. It will save time by clearing out most of the minor formatting
> issues
> and si
Max Reitz writes:
> From the cancel message, it is not entirely clear why this parameter is
> mandatory now, or that it will be optional in the future. Add such a
> more detailed explanation as a comment in the test source file.
>
> Suggested-by: Alex Bennée
> Signed-off-by: Max Reitz
Than
On Fri, Jan 22, 2021 at 4:35 AM Bin Meng wrote:
>
> From: Bin Meng
>
> Some peripherals require 64-bit PCI address, so let's map the high
> mmio space for PCIe.
>
> For RV32, the address is hardcoded to below 4 GiB from the highest
> accessible physical address. For RV64, the base address depends
On Thu, Jan 21, 2021 at 7:15 AM Andreas K. Hüttel wrote:
>
> Am Mittwoch, 20. Januar 2021, 22:12:30 EET schrieb Andreas K. Hüttel:
> > > This patch just passes the waitid status directly back to the guest.
> >
> > This works at least as well as the previous versions, so ++ from me.
> >
> > Will do
On Thu, Feb 11, 2021 at 9:20 AM Alex Bennée wrote:
>
> Signed-off-by: Alex Bennée
> Message-Id: <20201105175153.30489-7-alex.ben...@linaro.org>
Reviewed-by: Alistair Francis
Alistair
>
> ---
> v2
> - add docs and MAINTAINERS
> ---
> docs/system/guest-loader.rst | 54 +++
On Thu, Feb 11, 2021 at 9:21 AM Alex Bennée wrote:
>
> We might as well surface this useful information in the manual so
> users can find it easily. It is a fairly simple conversion to rst with
> the only textual fixes being QemuOps to QemuOpts.
>
> Signed-off-by: Alex Bennée
> Message-Id: <20201
On Thu, Feb 11, 2021 at 12:36 AM Sai Pavan Boddu
wrote:
>
> Configuring SDHCI-0 to act as eMMC controller.
>
> Signed-off-by: Sai Pavan Boddu
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/arm/xlnx-versal-virt.c | 16 +++-
> hw/arm/xlnx-versal.c | 14 --
> 2 f
On Thu, Feb 11, 2021 at 12:22 AM Sai Pavan Boddu
wrote:
>
> OCR.CARD_CAPACITY field is only valid for sd cards, So skip it for eMMC.
>
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Edgar E. Iglesias
Reviewed-by: Alistair Francis
Alistair
> ---
> hw/sd/sd.c | 3 ++-
> 1 file changed, 2 i
On Thu, Feb 11, 2021 at 12:15 AM Sai Pavan Boddu
wrote:
>
> From: Vincent Palatin
>
> Add new block device type.
>
> Signed-off-by: Vincent Palatin
> [SPB: Rebased over 5.1 version]
> Signed-off-by: Sai Pavan Boddu
> Signed-off-by: Joel Stanley
> Signed-off-by: Cédric Le Goater
Reviewed-by:
From: Lucien Murray-Pitts
Add CPU class detection for each CR type in the m68k_move_to/from helpers,
so that it throws and exception if an unsupported register is requested
for that CPU class.
Reclassified MOVEC insn. as only supported from 68010.
Signed-off-by: Lucien Murray-Pitts
Signed-off-
From: Lucien Murray-Pitts
The m680XX_cpu_initfn functions have been rearranged to cascade starting from
the base 68000, so that the 68010 then inherits from this, and so on until the
68060.
This makes it simpler to track features since in most cases the m68k were
product enhancements on each oth
From: Lucien Murray-Pitts
On m68k there are two varities of stack pointers: USP with SSP or ISP/MSP.
Only the 68020/30/40 support the MSP register the stack swap helpers don't
support this feature.
This patch adds this support, as well as comments to CPUM68KState to
make it clear how stacks are
Copy bootinfo.h and bootinfo-mac.h from arch/m68k/include/uapi/asm/
to include/standard-headers/asm-m68k/
Imported from linux v5.9 but didn't change since v4.14 (header update)
and since v4.10 (content update).
Signed-off-by: Laurent Vivier
Message-Id: <20201220112615.933036-2-laur...@vivier.eu>
From: Lucien Murray-Pitts
Add more detailed comments to each case of m68k_move_to/from helpers to list
the supported CPUs for that CR as they were wrong in some cases, and
missing some cpu classes in other cases.
Signed-off-by: Lucien Murray-Pitts
Signed-off-by: BALATON Zoltan
Message-Id:
Si
From: Lucien Murray-Pitts
Improvement in comments for the instantiation functions.
This is to highlight what each cpu class, in the 68000 series, contains
in terms of instructions/features.
Signed-off-by: Lucien Murray-Pitts
Signed-off-by: BALATON Zoltan
Message-Id:
<2dfe32672ee6ddce4b54c6bcf
From: Lucien Murray-Pitts
The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper
functions were also missing a decode for the 68060 M68K_CR_CAAR CR register.
Added missing defines, and respective decodes for all three CR registers to
the helpers.
Although this patch define
8k-for-6.0-pull-request
for you to fetch changes up to 382d71af7d61620ffb023962f83cc4786303c60d:
m68k: import bootinfo headers from linux (2021-02-11 21:56:42 +0100)
Pull request m68k-20210212
Move bootinfo headers to include/standa
On Fri, Feb 12, 2021 at 12:20 PM Max Reitz wrote:
>
> From the cancel message, it is not entirely clear why this parameter is
> mandatory now, or that it will be optional in the future. Add such a
> more detailed explanation as a comment in the test source file.
>
> Suggested-by: Alex Bennée
> S
On Fri, Feb 12, 2021 at 04:40:38PM +0100,
Igor Mammedov wrote:
> On Wed, 10 Feb 2021 22:46:43 -0800
> Isaku Yamahata wrote:
>
> > Declare PNP0C01 device to reserve MMCONFIG region to conform to the
> > spec better and play nice with guest BIOSes/OSes.
> >
> > According to PCI Firmware Specific
Hi Cleber,
On 2/12/21 7:58 PM, Cleber Rosa wrote:
> On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote:
>> From the cancel message, it is not entirely clear why this parameter is
>> mandatory now, or that it will be optional in the future. Add such a
>> more detailed explanation as a comme
On 2/12/21 7:48 PM, Richard Henderson wrote:
> These functions are not small, except for unlock_user
> without debugging enabled. Move them out of line, and
> add missing braces on the way.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> linux-user/qemu.h| 45
On 2/12/21 7:48 PM, Richard Henderson wrote:
> For copy_*_user, only 0 and -TARGET_EFAULT are returned; no need
> to involve abi_long. Use size_t for lengths. Use bool for the
> lock_user copy argument. Use ssize_t for target_strlen, because
> we can't overflow the host memory space.
>
> Review
On Wed, Feb 3, 2021 at 2:25 PM Cleber Rosa wrote:
>
> Signed-off-by: Cleber Rosa
> ---
> docs/devel/testing.rst | 26 ++
> 1 file changed, 26 insertions(+)
>
Reviewed-by: Willian Rampazzo
From: Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-10-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/backup.c | 10 ++
1 file cha
On Fri, 12 Feb 2021, Peter Maydell wrote:
For a long time now the UI layer has guaranteed that the console
surface is always 32 bits per pixel RGB, but some older display device
models still have the code to handle other formats. This patchset
cleans up that dead code for the sm501 device, which
From: Vladimir Sementsov-Ogievskiy
We are going to cancel in-flight requests on mirror nbd target on job
cancel. Still nbd is often used not directly but as raw-format child.
So, add pass-through handler here.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <202
On Thu, Feb 11, 2021 at 7:09 PM Niek Linnenbank
wrote:
>
> Currently the automated acceptance tests for the Orange Pi PC and cubieboard
> machines are disabled by default. The tests for both machines require
> artifacts
> that are stored on the apt.armbian.com domain. Unfortunately, some of these
From: Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-11-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/264 | 2
From: Vladimir Sementsov-Ogievskiy
It will be used to stop retrying NBD requests on mirror cancel.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-2-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
include/block/block.h | 3 +
From: Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-9-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/264 | 38
From: Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-6-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/mirror.c | 9 +
1 file change
From: Vladimir Sementsov-Ogievskiy
We are going to add more test cases, so use the library supporting test
cases.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-7-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotest
From: Max Reitz
Commit 69b55e03f has changed an error message, adjust the reference
output to account for it.
Fixes: 69b55e03f7e65a36eb954d0b7d4698b258df2708
("block: refactor bdrv_check_request: add errp")
Signed-off-by: Max Reitz
Message-Id: <20210209181923.497688-1-mre...@redhat.com>
From: Vladimir Sementsov-Ogievskiy
To not interfere with other qemu_nbd_popen() calls in same test.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-8-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
tests/qemu-iotests/iotests.py |
The following changes since commit eac92d316351b855ba79eb374dd21cc367f1f9c1:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20210211-1' into staging (2021-02-11
19:57:50 +)
are available in the Git repository at:
https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2021
This gives us better feature parity with QMP nbd-server-start, where
max-connections defaults to 0 for unlimited.
Signed-off-by: Eric Blake
Message-Id: <20210209152759.209074-3-ebl...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
docs/tools/qemu-nbd.rst | 4 ++--
qemu-nbd.c | 6 +
From: Vladimir Sementsov-Ogievskiy
Just stop waiting for connection in existing requests.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20210205163720.887197-3-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/nbd.c | 15 +++
1 file
From: Jagannathan Raman
Using error_prepend() in qio_channel_readv_full_all() causes a segfault
as errp is not set when ret is 0. This results in the failure of iotest
83. Replacing with error_setg() fixes the problem.
Additionally, removes a full stop at the end of error message
Reported-by: M
From: Vladimir Sementsov-Ogievskiy
To be used in mirror in the following commit to cancel in-flight io on
target to not waste the time.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20210205163720.887197-5-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
Signed-off-by: Eric Blake
Our default of a backlog of 1 connection is rather puny; it gets in
the way when we are explicitly allowing multiple clients (such as
qemu-nbd -e N [--shared], or nbd-server-start with its default
"max-connections":0 for unlimited), but is even a problem when we
stick to qemu-nbd's default of only
On Thu, Feb 11, 2021 at 8:28 PM Cleber Rosa wrote:
>
> This version (and 84.0) contain improvements that address specific
> QEMU use cases, including:
>
> * Being able to download and use Fedora 31 images and thus
>re-activate the "boot_linux.py" tests
>
> * Being able to register local asse
On 2/5/21 5:52 AM, Vladimir Sementsov-Ogievskiy wrote:
> 05.02.2021 14:43, Alberto Garcia wrote:
>> On Tue 02 Feb 2021 01:49:50 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>> -Qcow2BitmapInfoList *qcow2_get_bitmap_info_list(BlockDriverState *bs,
>>> -
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote:
> We are going to switch the 'null-co' default 'read-zeroes' value
> from FALSE to TRUE in the next commit. First explicit the FALSE
> value when it is not set.
>
> Suggested-by: Eric Blake
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> +++ b/t
Patchew URL:
https://patchew.org/QEMU/20210212184902.1251044-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210212184902.1251044-1-richard.hender...@linaro.org
Subject: [PATCH v7 00/31
On Fri, Feb 12, 2021 at 04:16:49PM +0100, Max Reitz wrote:
> From the cancel message, it is not entirely clear why this parameter is
> mandatory now, or that it will be optional in the future. Add such a
> more detailed explanation as a comment in the test source file.
>
> Suggested-by: Alex Benn
On 2/12/21 7:48 PM, Richard Henderson wrote:
> This is more descriptive than 'unsigned long'.
> No functional change, since these match on all linux+bsd hosts.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> include/exec/cpu-all.h | 2 +-
> bsd-user/main.c| 4 +
On 2/12/21 7:48 PM, Richard Henderson wrote:
> Return bool not int; pass abi_ulong not 'unsigned long'.
> All callers use abi_ulong already, so the change in type
> has no effect.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> include/exec/cpu_ldst.h | 2 +-
> 1 file
On 2/12/21 7:02 AM, LIU Zhiwei wrote:
> The overflow predication ((a - b) ^ a) & (a ^ b) & INT64_MIN is right.
> However, when the predication is ture and a is 0, it should return maximum.
>
> Signed-off-by: LIU Zhiwei
> ---
> target/riscv/vector_helper.c | 8
> 1 file changed, 4 insert
A proper syndrome is required to fill in the proper si_code.
Use page_get_flags to determine permission vs translation for user-only.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/cpu_loop.c | 24 +---
target/arm/tlb_helper.c | 15 +
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
tests/tcg/aarch64/mte.h | 60 +++
tests/tcg/aarch64/mte-1.c | 28 +++
tests/tcg/aarch64/mte-2.c | 45 +++
tests/tcg/aarch64/mte-3.c | 51 +
On 2/12/21 11:34 AM, Peter Krempa wrote:
> See 2/2 for explanation.
>
> Peter Krempa (3):
> migration: dirty-bitmap: Convert alias map inner members to
> BitmapMigrationBitmapAlias
> migration: dirty-bitmap: Allow control of bitmap persistence
> qemu-iotests: 300: Add test case for modif
The real kernel collects _TIF_MTE_ASYNC_FAULT into the current thread's
state on any kernel entry (interrupt, exception etc), and then delivers
the signal in advance of resuming the thread.
This means that while the signal won't be delivered immediately, it will
not be delayed forever -- at minimu
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/cpu.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 70cfcbc918..b8bc89e71f 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -209,6 +209,21 @@ static
On 2/12/21 11:34 AM, Peter Krempa wrote:
> Verify that the modification of the bitmap persistence over migration
> which is controlled via BitmapMigrationBitmapAliasTransform works
> properly.
>
> Based on TestCrossAliasMigration
>
> Signed-off-by: Peter Krempa
> ---
> tests/qemu-iotests/300
Resolve the untagged address once, using thread_cpu.
Tidy the DEBUG_REMAP code using glib routines.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/uaccess.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/linux-user/u
Use simple arithmetic instead of a conditional
move when tbi0 != tbi1.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/translate-a64.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/a
On 2/12/21 7:48 PM, Richard Henderson wrote:
> This is more descriptive than 'unsigned long'.
> No functional change, since these match on all linux+bsd hosts.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> include/exec/cpu_ldst.h | 6 +++---
> 1 file changed, 3 inser
Remember the PROT_MTE bit as PAGE_MTE/PAGE_TARGET_2.
Otherwise this does not yet have effect.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h| 1 +
linux-user/syscall_defs.h | 1 +
target/arm/cpu.h | 1 +
linux-user/mmap.c | 22
Use the now-saved PAGE_ANON and PAGE_MTE bits,
and the per-page saved data.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
target/arm/mte_helper.c | 29 +++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/target/arm/mte_helper.c b/target
On 2/12/21 7:48 PM, Richard Henderson wrote:
> Move everything related to syndromes to a new file,
> which can be shared with linux-user.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Richard Henderson
> ---
> target/arm/internals.h | 245 +---
> target/arm/syn
For copy_*_user, only 0 and -TARGET_EFAULT are returned; no need
to involve abi_long. Use size_t for lengths. Use bool for the
lock_user copy argument. Use ssize_t for target_strlen, because
we can't overflow the host memory space.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
-
On 2/12/21 11:34 AM, Peter Krempa wrote:
> Bitmap's source persistence is transported over the migration stream and
> the destination mirrors it. In some cases the destination might want to
> persist bitmaps which are not persistent on the source (e.g. the result
> of merge of bitmaps from a number
These prctl fields are required for the function of MTE.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_syscall.h | 9 ++
linux-user/syscall.c| 43 +
2 files changed, 52 insertions(+)
diff --git a/linux
Provide an identity fallback for target that do not
use tagged addresses.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/exec/cpu_ldst.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index e62f4fba00..d9dc1d
On 2/12/21 7:02 AM, LIU Zhiwei wrote:
> +static void tcg_gen_simd_add16(TCGv d, TCGv a, TCGv b)
> +{
> +TCGv t1 = tcg_temp_new();
> +TCGv t2 = tcg_temp_new();
> +
> +tcg_gen_andi_tl(t1, a, ~0x);
> +tcg_gen_add_tl(t2, a, b);
> +tcg_gen_add_tl(t1, t1, b);
> +tcg_gen_deposi
We were fudging TBI1 enabled to speed up the generated code.
Now that we've improved the code generation, remove this.
Also, tidy the comment to reflect the current code.
The pauth test was testing a kernel address (-1) and making
incorrect assumptions about TBI1; stick to userland addresses.
Rev
This is the prctl bit that controls whether syscalls accept tagged
addresses. See Documentation/arm64/tagged-address-abi.rst in the
linux kernel.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_syscall.h | 4
target/arm/cpu-param.h |
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/qemu.h | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
On 2/9/21 8:30 PM, Mark Cave-Ayland wrote:
> The MacOS toolbox ROM performs 4 byte reads/writes when transferring data to
> and from the target. Since the SCSI bus is 16-bits wide, use the memory API
> to split a 4 byte access into 2 x 2 byte accesses.
>
> Signed-off-by: Mark Cave-Ayland
> ---
>
These functions are not small, except for unlock_user
without debugging enabled. Move them out of line, and
add missing braces on the way.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
---
linux-user/qemu.h| 45 ++-
linux-user/uaccess.c
1 - 100 of 297 matches
Mail list logo