Re: [PATCH] linux-user/syscall: Silence warning from the undefined behavior sanitizer

2021-02-11 Thread Thomas Huth
On 12/02/2021 01.35, Laurent Vivier wrote: Le 11/02/2021 à 22:28, Laurent Vivier a écrit : Le 11/02/2021 à 14:29, Thomas Huth a écrit : When compiling QEMU with -fsanitize=undefined, there is a warning when running "make check-tcg": TESTlinux-test on m68k ../linux-user/syscall.c:10499:3

Re: [PATCH] linux-user/syscall: Silence warning from the undefined behavior sanitizer

2021-02-11 Thread Thomas Huth
On 11/02/2021 22.28, Laurent Vivier wrote: Le 11/02/2021 à 14:29, Thomas Huth a écrit : When compiling QEMU with -fsanitize=undefined, there is a warning when running "make check-tcg": TESTlinux-test on m68k ../linux-user/syscall.c:10499:34: runtime error: member access within misalign

Re: [PATCH v4 03/24] python: create qemu packages

2021-02-11 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:35PM -0500, John Snow wrote: > move python/qemu/*.py to python/qemu/[machine, qmp]/*.py and update import > directives across the tree. > > This is done to create a PEP420 namespace package, in which we may > create subpackages. To do this, the namespace directory ("q

Re: [PATCH v4 02/24] iotests/297: add --namespace-packages to mypy arguments

2021-02-11 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:34PM -0500, John Snow wrote: > mypy is kind of weird about how it handles imports. For legacy reasons, > it won't load PEP 420 namespaces, because of logic implemented prior to > that becoming a standard. > > So, if you plan on using any, you have to pass > --namespac

Re: [PATCH v4 01/24] python/console_socket: avoid one-letter variable

2021-02-11 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:33PM -0500, John Snow wrote: > Fixes pylint warnings. > > Signed-off-by: John Snow > --- > python/qemu/console_socket.py | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Cleber Rosa signature.asc Description: PGP signature

Virgil 3D renderer on macOS

2021-02-11 Thread 小田喜陽彦
Hi, I would like to introduce my Virgil 3D renderer port to macOS. Some patches which are made in the process are useful even without Virgil 3D renderer, and already submitted to upstreams: - [PATCH] ui/cocoa: Support unique keys of JIS keyboards - [PATCH] ui/cocoa: Remove the uses of full screen

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread Peter Xu
On Thu, Feb 11, 2021 at 10:09:58PM +0100, David Hildenbrand wrote: > The issue is when the discard happened before starting the snapshot. > Write-protection won‘t work and the zeroed content won‘t be retained in the > snapshot. I see what you mean now, and iiuc it will only be a problem if init_

Re: [PATCH v4 00/24] python: create installable package

2021-02-11 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 01:58:32PM -0500, John Snow wrote: > This series factors the python/qemu directory as an installable > package. It does not yet actually change the mechanics of how any other > python source in the tree actually consumes it (yet), beyond the import > path. (some import state

Re: runaway avocado

2021-02-11 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 12:59:23AM +0100, Philippe Mathieu-Daudé wrote: > On 2/11/21 8:21 PM, Peter Maydell wrote: > > On Thu, 11 Feb 2021 at 18:47, Cleber Rosa wrote: > >> On Thu, Feb 11, 2021 at 05:37:20PM +, Peter Maydell wrote: > >>> I wonder if we could have avocado run all our acceptance

[PATCH] ui/cocoa: Do not copy members of pixman image

2021-02-11 Thread Akihiko Odaki
The old CocoaView had an idea of synchronizing the host window configuration and the guest screen configuration. Here, the guest screen actually means pixman image given ui/cocoa display implementation. However, [CocoaView -drawRect:] directly interacts with the pixman image buffer in reality. The

[PATCH] ui/cocoa: Remove the uses of full screen APIs

2021-02-11 Thread Akihiko Odaki
The detections of full screen APIs were wrong. A detection is coded as: [NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)] but it should be: [NSView instancesRespondToSelector:@selector(exitFullScreenModeWithOptions:)] The uses of full screen APIs were also incorrect, and if you

[PATCH] ui/cocoa: Interpret left button down as is when command is pressed

2021-02-11 Thread Akihiko Odaki
Old Macs were not equipped with mice with an ability to perform "right clicks" and ui/cocoa interpreted left button down with left command key pressed as right button down as a workaround. The workaround has an obvious downside: you cannot tell the guest that the left button is down while the left

[PATCH] ui/cocoa: Support unique keys of JIS keyboards

2021-02-11 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 13fba8103e1..78fcfeaf04b 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -240,6 +240,13 @@ static bool bool_with_iothread_lock(BoolCodeBlock block) [kVK_F14] = Q_K

Re: [PATCH 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

2021-02-11 Thread Cleber Rosa
On Thu, Feb 11, 2021 at 11:00:54PM +0100, Niek Linnenbank wrote: > Currently the automated acceptance tests for the Orange Pi PC and cubieboard > machines are disabled by default. The tests for both machines require > artifacts > that are stored on the apt.armbian.com domain. Unfortunately, some o

Re: [PATCH v8 07/13] confidential guest support: Introduce cgs "ready" flag

2021-02-11 Thread David Gibson
On Wed, Feb 10, 2021 at 10:25:30AM -0600, Venu Busireddy wrote: > On 2021-02-02 15:13:09 +1100, David Gibson wrote: > > The platform specific details of mechanisms for implementing > > confidential guest support may require setup at various points during > > initialization. Thus, it's not really f

[PATCH] qom/object.c: Fix typo

2021-02-11 Thread Doug Evans via
A simple typo (noticed by inspection). commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee Author: Doug Evans Date: Thu Feb 11 16:29:13 2021 -0800 qom/object.c: Fix typo Signed-off-by: Doug Evans diff --git a/qom/object.c b/qom/object.c index 491823db4a..6a01d56546 100644 --- a/qom/

Re: [PATCH v2 20/21] accel/tcg: allow plugin instrumentation to be disable via cflags

2021-02-11 Thread Aaron Lindsay via
On Feb 10 22:10, Alex Bennée wrote: > When icount is enabled and we recompile an MMIO access we end up > double counting the instruction execution. To avoid this we introduce > the CF_NOINSTR cflag which disables instrumentation for the next TB. > As this is part of the hashed compile flags we will

Re: [PATCH] linux-user/syscall: Silence warning from the undefined behavior sanitizer

2021-02-11 Thread Laurent Vivier
Le 11/02/2021 à 22:28, Laurent Vivier a écrit : > Le 11/02/2021 à 14:29, Thomas Huth a écrit : >> When compiling QEMU with -fsanitize=undefined, there is a warning when >> running "make check-tcg": >> >> TESTlinux-test on m68k >> ../linux-user/syscall.c:10499:34: runtime error: member access

Re: [PATCH v8 09/35] Hexagon (target/hexagon) architecture types

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/8/21 6:45 AM, Taylor Simpson wrote: > Define types used in files imported from the Hexagon architecture library > > Signed-off-by: Taylor Simpson > --- > target/hexagon/hex_arch_types.h | 38 ++ > 1 file changed, 38 insertions(+) > create mode 100644 tar

Re: [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/8/21 6:46 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/fma_emu.h | 36 +++ > target/hexagon/fma_emu.c | 702 > +++ > 2 files changed, 738 insertions(+) > create mode 100644 target/hexagon/fma_emu.h > create m

Re: [PATCH v8 23/35] Hexagon (target/hexagon) opcode data structures

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/8/21 6:46 AM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/opcodes.h | 58 +++ > target/hexagon/opcodes.c | 142 > +++ > 2 files changed, 200 insertions(+) > create mode 100644 target/hexagon/opcod

Re: [PATCH v8 26/35] Hexagon (target/hexagon) TCG generation

2021-02-11 Thread Philippe Mathieu-Daudé
Hi Taylor, On 2/8/21 6:46 AM, Taylor Simpson wrote: > Include the generated files and set up the data structures > > Signed-off-by: Taylor Simpson > --- > target/hexagon/genptr.h | 25 > target/hexagon/genptr.c | 331 > > 2 files changed,

Re: RFC Qemu mipssim patches

2021-02-11 Thread Philippe Mathieu-Daudé
Hi Reinoud, On 2/11/21 4:37 PM, Reinoud Zandijk wrote: > Hi, > > i'd like to get the following simple patches to the MIPS/mipssim target adding > virtio-mmio devices to it. This makes the target a lot more usefull as microvm > for kernel developement. It currently lives in our qemu extensions pat

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-11 Thread Cleber Rosa
On Fri, Feb 12, 2021 at 12:35:26AM +0100, Philippe Mathieu-Daudé wrote: > On 2/11/21 11:01 PM, Cleber Rosa wrote: > > Each instance of qemu.machine.QEMUMachine currently has a "test > > directory", which may not have any relation to a "test", and it's > > really a temporary directory. > > > > User

Re: runaway avocado

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 8:21 PM, Peter Maydell wrote: > On Thu, 11 Feb 2021 at 18:47, Cleber Rosa wrote: >> On Thu, Feb 11, 2021 at 05:37:20PM +, Peter Maydell wrote: >>> I wonder if we could have avocado run all our acceptance cases >>> under a 'ulimit -f' setting that restricts the amount of disk >>> spa

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:40 PM, Eric Blake wrote: > On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: >> We are going to switch the 'null-co' default 'read-zeroes' value >> from FALSE to TRUE in the next commit. First explicit the FALSE >> value when it is not set. > > Grammar suggestion, along with a sugges

Re: [PATCH] docs/user: Remove outdated 'Quick Start' section

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 9:27 PM, Laurent Vivier wrote: > Le 11/02/2021 à 18:02, Peter Maydell a écrit : >> Laurent: Ping^2 ? Somebody on IRC just now was getting confused by this >> ancient documentation and its references to nonexistent tarballs.. > > Sorry, I didn't see your mail. > > I agree with the chang

Re: [PATCH 1/1] Acceptance Tests: bump Avocado version requirement to 85.0

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/12/21 12:28 AM, Cleber Rosa wrote: > This version (and 84.0) contain improvements that address specific > QEMU use cases, including: > > * Being able to download and use Fedora 31 images and thus >re-activate the "boot_linux.py" tests > > * Being able to register local assets via "avoc

Re: [PATCH 6/6] tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:01 PM, Cleber Rosa wrote: "Preserve log" ... > At location already prepared for keeping the test's log files. > > While at it, log info about its location (in the main test log > file), instead of printing it out. > > Reference: > https://avocado-framework.readthedocs.io/en/85.0/a

Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:01 PM, Cleber Rosa wrote: > Each instance of qemu.machine.QEMUMachine currently has a "test > directory", which may not have any relation to a "test", and it's > really a temporary directory. > > Users instantiating the QEMUMachine class will be able to set the > location of the dire

Re: [PATCH 2/2] hw/net/allwinner-sun8i-emac: traverse transmit queue using TX_CUR_DESC register value

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 11:00 PM, Niek Linnenbank wrote: > Currently the emulated EMAC for sun8i always traverses the transmit queue > from the head when transferring packets. It searches for a list of consecutive > descriptors whichs are flagged as ready for processing and transmits their > payloads > accordi

[PATCH 1/1] Acceptance Tests: bump Avocado version requirement to 85.0

2021-02-11 Thread Cleber Rosa
This version (and 84.0) contain improvements that address specific QEMU use cases, including: * Being able to download and use Fedora 31 images and thus re-activate the "boot_linux.py" tests * Being able to register local assets via "avocado assets register" and use them in tests Signed-

[PATCH 0/1] Acceptance Tests: bump Avocado version requirement to 85.0

2021-02-11 Thread Cleber Rosa
This is being proposed as a separate single patch simply to show that no known regressions have been introduced as far as the acceptance tests/jobs are related. CI job: https://gitlab.com/cleber.gnu/qemu/-/pipelines/255122420 This version (and 84.0) contain improvements that address specific

Re: [RFC PATCH 03/10] target/hexagon: make helper functions non-static

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/12/21 12:04 AM, Philippe Mathieu-Daudé wrote: > On 2/11/21 10:50 PM, Alessandro Di Federico via wrote: >> From: Paolo Montesel >> >> Move certain helper functions required by code generated by the >> idef-parser available outside genptr.c, moving them into macros.h. >> > > ^ OK > >> This

Re: [RFC PATCH 04/10] target/hexagon: introduce new helper functions

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 10:50 PM, Alessandro Di Federico via wrote: > From: Niccolò Izzo > > These helpers will be employed by the idef-parser generated code. > Shouldn't this be signed by Niccolò too? > Signed-off-by: Alessandro Di Federico > --- > target/hexagon/genptr.c | 224 +

Re: [RFC PATCH 03/10] target/hexagon: make helper functions non-static

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 10:50 PM, Alessandro Di Federico via wrote: > From: Paolo Montesel > > Move certain helper functions required by code generated by the > idef-parser available outside genptr.c, moving them into macros.h. > ^ OK > This patch also introduces the gen_cancel and gen_fbrev helper which >

Re: [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 9:44 PM, Eric Blake wrote: > Supporting '0x20M' looks odd, particularly since we have a 'B' suffix > that is ambiguous for bytes, as well as a less-frequently-used 'E' > suffix for extremely large exibytes. In practice, people using hex > inputs are specifying values in bytes (and would

[PATCH v3 3/7] spapr_drc.c: use spapr_drc_release() in isolate_physical/set_unusable

2021-02-11 Thread Daniel Henrique Barboza
When moving a physical DRC to "Available", drc_isolate_physical() will move the DRC state to STATE_PHYSICAL_POWERON and, if the DRC is marked for unplug, call spapr_drc_detach(). For physical DRCs, drck->empty_state is STATE_PHYSICAL_POWERON, meaning that we're sure that spapr_drc_detach() will end

[PATCH v3 7/7] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state

2021-02-11 Thread Daniel Henrique Barboza
Handling errors in memory hotunplug in the pSeries machine is more complex than any other device type, because there are all the complications that other devices has, and more. For instance, determining a timeout for a DIMM hotunplug must consider if it's a Hash-MMU or a Radix-MMU guest, because H

[PATCH v3 6/7] spapr_drc.c: add hotunplug timeout for CPUs

2021-02-11 Thread Daniel Henrique Barboza
There is a reliable way to make a CPU hotunplug fail in the pseries machine. Hotplug a CPU A, then offline all other CPUs inside the guest but A. When trying to hotunplug A the guest kernel will refuse to do it, because A is now the last online CPU of the guest. PAPR has no 'error callback' in this

[PATCH v3 2/7] spapr_pci.c: simplify spapr_pci_unplug_request() function handling

2021-02-11 Thread Daniel Henrique Barboza
When hotunplugging a PCI function we'll branch out the logic in two cases, function zero and non-zero. If non-zero, we'll call spapr_drc_detach() and nothing else. If it's function zero, we'll loop it once between all the functions in the slot to call spapr_drc_detach() on them, and afterwards we'l

[PATCH v3 5/7] spapr_drc.c: introduce unplug_timeout_timer

2021-02-11 Thread Daniel Henrique Barboza
The LoPAR spec provides no way for the guest kernel to report failure of hotplug/hotunplug events. This wouldn't be bad if those operations were granted to always succeed, but that's far for the reality. What ends up happening is that, in the case of a failed hotunplug, regardless of whether it wa

[PATCH v3 4/7] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request()

2021-02-11 Thread Daniel Henrique Barboza
spapr_drc_detach() is not the best name for what the function does. The function does not detach the DRC, it makes an uncommited attempt to do it. It'll mark the DRC as pending unplug, via the 'unplug_request' flag, and only if the DRC state is drck->empty_state it will detach the DRC, via spapr_dr

[PATCH v3 1/7] spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical()

2021-02-11 Thread Daniel Henrique Barboza
drc_isolate_logical() is used to move the DRC from the "Configured" to the "Available" state, erroring out if the DRC is in the unexpected "Unisolate" state and doing nothing (with RTAS_OUT_SUCCESS) if the DRC is already in "Available" or in "Unusable" state. When moving from "Configured" to "Avai

[PATCH v3 0/7] CPU unplug timeout/LMB unplug cleanup in DRC reconfiguration

2021-02-11 Thread Daniel Henrique Barboza
Hi, This is marked as a v3 as it started as a result of discussions that followed the v2 [1]. The idea with this series is to add CPU hotunplug timeout to avoid the situations where the kernel refuses to release the CPU. The reasoning for a timeout approach is described in patch 05. While inves

Re: [PATCH v2 1/2] block: Explicit null-co uses 'read-zeroes=false'

2021-02-11 Thread Eric Blake
On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: > We are going to switch the 'null-co' default 'read-zeroes' value > from FALSE to TRUE in the next commit. First explicit the FALSE > value when it is not set. Grammar suggestion, along with a suggestion for an additional sentence to make the inte

[PATCH 2/6] Python: expose QEMUMachine's temporary directory

2021-02-11 Thread Cleber Rosa
Each instance of qemu.machine.QEMUMachine currently has a "test directory", which may not have any relation to a "test", and it's really a temporary directory. Users instantiating the QEMUMachine class will be able to set the location of the directory that will *contain* the QEMUMachine unique tem

[PATCH 4/6] Acceptance Tests: log information when creating QEMUMachine

2021-02-11 Thread Cleber Rosa
Including its base temporary directory, given that information useful for debugging can be put there. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/avocado_qemu/__init__.py b/te

[PATCH 5/6] Acceptance Tests: distinguish between temp and logs dir

2021-02-11 Thread Cleber Rosa
Logs can be very important to debug issues, and currently QEMUMachine instances will remove logs that are created under the temporary directories. With this change, the stdout and stderr generated by the QEMU process started by QEMUMachine will always be kept along the test results directory. Sig

[PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it

2021-02-11 Thread Cleber Rosa
Closing a file that is open for writing, and then reading from it sounds like a better idea than the opposite, given that the content will be flushed. Reference: https://docs.python.org/3/library/io.html#io.IOBase.close Signed-off-by: Cleber Rosa --- python/qemu/machine.py | 4 ++-- 1 file chang

[PATCH 0/2] Allwinner H3 fixes for EMAC and acceptance tests

2021-02-11 Thread Niek Linnenbank
The following are maintenance patches for the Allwinner H3. The first patch is a proposal to relocate the binary artifacts of the acceptance tests away from the apt.armbian.com domain. In the past we had problems with artifacts being removed, and now the recently added Armbian 20.08.1 image has be

[PATCH 3/6] Acceptance Tests: use the job work directory for created VMs

2021-02-11 Thread Cleber Rosa
The QEMUMachine uses a base temporary directory for all temporary needs. By setting it to the Avocado's workdir, it's possible to keep the temporary files during debugging sessions much more easily by setting the "--keep-tmp" command line option. Reference: https://avocado-framework.readthedocs.

[PATCH 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

2021-02-11 Thread Niek Linnenbank
Currently the automated acceptance tests for the Orange Pi PC and cubieboard machines are disabled by default. The tests for both machines require artifacts that are stored on the apt.armbian.com domain. Unfortunately, some of these artifacts have been removed from apt.armbian.com and it is uncert

[RFC PATCH 05/10] target/hexagon: expose next PC in DisasContext

2021-02-11 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico --- target/hexagon/translate.c | 4 +++- target/hexagon/translate.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index eeaad5f8ba..a59db485a3 100644 --- a/t

[PATCH 6/6] tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log

2021-02-11 Thread Cleber Rosa
At location already prepared for keeping the test's log files. While at it, log info about its location (in the main test log file), instead of printing it out. Reference: https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.logdir Signed-off-by: Cleber Rosa ---

[PATCH 2/2] hw/net/allwinner-sun8i-emac: traverse transmit queue using TX_CUR_DESC register value

2021-02-11 Thread Niek Linnenbank
Currently the emulated EMAC for sun8i always traverses the transmit queue from the head when transferring packets. It searches for a list of consecutive descriptors whichs are flagged as ready for processing and transmits their payloads accordingly. The controller stops processing once it finds a

[PATCH 0/6] Python / Acceptance Tests: improve logging

2021-02-11 Thread Cleber Rosa
The location and amount of information kept while using QEMUMachine in Acceptance Tests is currently not optimal. This improves the situation by using the Test's log directory (an Avocado standard feature) as the default location to keep logs, instead of the temporary directory currently used. Us

[RFC PATCH 10/10] target/hexagon: import additional tests

2021-02-11 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico --- tests/tcg/hexagon/Makefile.target | 35 - tests/tcg/hexagon/crt.S| 28 + tests/tcg/hexagon/first.S | 24 ++-- tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexa

[RFC PATCH 03/10] target/hexagon: make helper functions non-static

2021-02-11 Thread Alessandro Di Federico via
From: Paolo Montesel Move certain helper functions required by code generated by the idef-parser available outside genptr.c, moving them into macros.h. This patch also introduces the gen_cancel and gen_fbrev helper which will be used by idef-parser. Signed-off-by: Alessandro Di Federico --- t

[RFC PATCH 04/10] target/hexagon: introduce new helper functions

2021-02-11 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico --- target/hexagon/genptr.c | 224 target/hexagon/genptr.h | 19 2 files changed, 243 insertions(+) diff --git a/target/hex

[RFC PATCH 08/10] target/hexagon: import parser for idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/idef-parser.y| 1248 target/hexagon/idef-parser/parser-helpers.c | 1925 +++ target/hexagon/idef-parser/parser-helpers.h | 293 +++ target/hexagon/meson.build

[RFC PATCH 02/10] target/hexagon: import README for idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/README | 5 + target/hexagon/idef-parser/README.rst | 446 ++ 2 files changed, 451 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[RFC PATCH 07/10] target/hexagon: import lexer for idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/idef-lexer.lex | 648 ++ target/hexagon/idef-parser/idef-parser.h | 245 target/hexagon/meson.build| 4 + 3 files changed, 897 insertions(+) create mode 100

[RFC PATCH 06/10] target/hexagon: prepare input for the idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 target/hexagon/idef-parser/macros.inc | 166 ++

[RFC PATCH 01/10] target/hexagon: update MAINTAINERS for idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 41300089b2..029f96d3bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -192,11 +192,19 @@ Hexagon TCG CPUs M: Taylor Simp

[RFC PATCH 00/10] target/hexagon: introduce idef-parser

2021-02-11 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It is based on "[PATCH v8 00/35] Hexagon patch series". `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny code generator frontend for Hexagon. Th

[RFC PATCH 09/10] target/hexagon: call idef-parser functions

2021-02-11 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_tcg_funcs.py | 28 ++-- target/hexagon/hex_common.py | 10

[PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-11 Thread Nathan Chancellor
fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), which violates clang's CFI checking because fw_cfg_showrev()'s second parameter is 'struct attribute', whereas the ->show() member of 'struct kobj_structure' expects the second parameter to be of type 'struct kobj_attribute'. $ ca

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-11 Thread Sami Tolvanen
Hi Nathan, On Thu, Feb 11, 2021 at 11:43 AM Nathan Chancellor wrote: > > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > which violates clang's CFI checking because fw_cfg_showrev()'s second > parameter is 'struct attribute', whereas the ->show() member of 'struct > kobj_str

Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls

2021-02-11 Thread Laurent Vivier
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > o32 ABI syscalls start at offset 4000. > > Signed-off-by: Philippe Mathieu-Daudé > --- > linux-user/mips64/syscall_nr.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/linux-user/mips64/syscall_nr.h b/linux-u

Re: [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI

2021-02-11 Thread Laurent Vivier
Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : > 64-bit MIPS targets lost setup_frame() during the refactor in commit > 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be > able to build the o32 ABI target. > > Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c p

Re: [PATCH] linux-user/syscall: Silence warning from the undefined behavior sanitizer

2021-02-11 Thread Laurent Vivier
Le 11/02/2021 à 14:29, Thomas Huth a écrit : > When compiling QEMU with -fsanitize=undefined, there is a warning when > running "make check-tcg": > > TESTlinux-test on m68k > ../linux-user/syscall.c:10499:34: runtime error: member access within > misaligned address 0x8006df3c for type '

Re: [PATCH] hw/sd: sdhci: Do not transfer any data when command fails

2021-02-11 Thread Alexander Bulekov
On 210211 1154, Alexander Bulekov wrote: ... > I applied this along with <20210208193450.2689517-1-f4...@amsat.org> > "hw/sd/sdhci: Do not modify BlockSizeRegister if transaction in progress" > > I ran through the entire OSS-Fuzz corpus, and could not reproduce the > crash. > > Tested-by: Alexand

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread David Hildenbrand
> Am 11.02.2021 um 22:05 schrieb Peter Xu : > > On Thu, Feb 11, 2021 at 09:44:07PM +0100, David Hildenbrand wrote: >> Let‘s take a look at init-on-free. >> >> The guest zeroes a page and puts it onto a buddy freelist. Free page >> reporting code takes it off that list and reports it to the hy

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread Peter Xu
On Thu, Feb 11, 2021 at 09:44:07PM +0100, David Hildenbrand wrote: > Let‘s take a look at init-on-free. > > The guest zeroes a page and puts it onto a buddy freelist. Free page > reporting code takes it off that list and reports it to the hypervisor. The > hypervisor discards the physical page a

Re: USB pass through into Mac OS 9.x with qemu-system-ppc

2021-02-11 Thread Programmingkid
> On Feb 8, 2021, at 8:29 AM, qemu-devel-requ...@nongnu.org wrote: > > Message: 15 > Date: Mon, 8 Feb 2021 14:29:06 +0100 > From: Howard Spoelstra > To: qemu-devel qemu-devel , Gerd Hoffmann > > Subject: USB pass through into Mac OS 9.x with qemu-system-ppc > Message-ID: > > Cont

[PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes

2021-02-11 Thread Eric Blake
The value '1.1k' is inexact; 1126.4 bytes is not possible, so we happen to truncate it to 1126. Our use of fractional sizes is intended for convenience, but when a user specifies a fraction that is not a clean translation to binary, truncating/rounding behind their backs can cause confusion. Bett

[PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision

2021-02-11 Thread Eric Blake
We have multiple clients of qemu_strtosz (qemu-io, the opts visitor, the keyval visitor), and it gets annoying that edge-case testing is impacted by implicit rounding to 53 bits of precision due to parsing with strtod(). As an example posted by Rich Jones: $ nbdkit memory $(( 2**63 - 2**30 )) --r

[PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes

2021-02-11 Thread Eric Blake
Supporting '0x20M' looks odd, particularly since we have a 'B' suffix that is ambiguous for bytes, as well as a less-frequently-used 'E' suffix for extremely large exibytes. In practice, people using hex inputs are specifying values in bytes (and would have written 0x200, or possibly relied on

[PATCH v2 1/4] utils: Enhance testsuite for do_strtosz()

2021-02-11 Thread Eric Blake
Enhance our testsuite coverage of do_strtosz() to cover some things we know that existing users want to continue working (hex bytes), as well as some things that accidentally work but shouldn't (hex fractions) or accidentally fail but that users want to work (64-bit precision on byte values). This

[PATCH v2 0/4] improve do_strtosz precision

2021-02-11 Thread Eric Blake
Parsing sizes with only 53 bits of precision is surprising; it's time to fix it to use a full 64 bits of precision. v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01800.html Since then: - split testsuite improvements from code changes [Vladimir] - more tests for more corner

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread David Hildenbrand
> Am 11.02.2021 um 21:31 schrieb Peter Xu : > > On Thu, Feb 11, 2021 at 08:01:29PM +0100, David Hildenbrand wrote: >>> On 11.02.21 19:28, Andrey Gruzdev wrote: >>> On 11.02.2021 20:32, Peter Xu wrote: On Thu, Feb 11, 2021 at 07:19:47PM +0300, Andrey Gruzdev wrote: > On 09.02.2021 22:06

Re: [PATCH] docs/user: Remove outdated 'Quick Start' section

2021-02-11 Thread Laurent Vivier
Le 11/02/2021 à 18:02, Peter Maydell a écrit : > Laurent: Ping^2 ? Somebody on IRC just now was getting confused by this > ancient documentation and its references to nonexistent tarballs.. Sorry, I didn't see your mail. I agree with the change. Acked-by: Laurent Vivier > -- PMM > > On Tue, 1

Re: [PATCH 2/2] file-posix: Cache next hole

2021-02-11 Thread Vladimir Sementsov-Ogievskiy
11.02.2021 20:22, Max Reitz wrote: We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are slow on certain filesystems and/or under certain circumstances. That is why we generally try to avoid it (which is why bdrv_co_block_status() has the @want_zero parameter, and which is why qco

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread Peter Xu
On Thu, Feb 11, 2021 at 08:01:29PM +0100, David Hildenbrand wrote: > On 11.02.21 19:28, Andrey Gruzdev wrote: > > On 11.02.2021 20:32, Peter Xu wrote: > > > On Thu, Feb 11, 2021 at 07:19:47PM +0300, Andrey Gruzdev wrote: > > > > On 09.02.2021 22:06, David Hildenbrand wrote: > > > > > > > Hi, > > >

Re: [PATCH 2/2] travis: remove travis configuration and all references to Travis CI

2021-02-11 Thread Wainer dos Santos Moschetta
Hi, On 2/9/21 11:32 AM, Thomas Huth wrote: On 09/02/2021 14.50, Daniel P. Berrangé wrote: The Travis CI system QEMU has been using has removed the unlimited free usage model, replacing it with a one-time only grant of CI minutes that is not renewed. The QEMU CI jobs quickly exhaust maintainer's

Re: [PATCH] hw/sd/sdhci: Do not modify BlockSizeRegister if transaction in progress

2021-02-11 Thread Alexander Bulekov
On 210211 2045, Philippe Mathieu-Daudé wrote: > Hi Alexander, > > On 2/11/21 6:04 PM, Alexander Bulekov wrote: > > On 210208 2034, Philippe Mathieu-Daudé wrote: > >> Per the "SD Host Controller Simplified Specification Version 2.00" > >> spec. 'Table 2-4 : Block Size Register': > >> > >> Transfe

Re: [PATCH v2 17/21] accel/tcg: cache single instruction TB on pending replay exception

2021-02-11 Thread Alex Bennée
Richard Henderson writes: > On 2/10/21 2:10 PM, Alex Bennée wrote: >> Again there is no reason to jump through the nocache hoops to execute >> a single instruction block. We do have to add an additional wrinkle to >> the cpu_handle_interrupt case to ensure we let through a TB where we >> have s

Re: [PATCH 1/2] vfio: Do not register any IOMMU_NOTIFIER_DEVIOTLB_UNMAP notifier

2021-02-11 Thread Alex Williamson
On Tue, 9 Feb 2021 22:32:32 +0100 Eric Auger wrote: > In an attempt to fix smmu/virtio-iommu - vhost regression, commit > 958ec334bca3 ("vhost: Unbreak SMMU and virtio-iommu on dev-iotlb support") > broke virtio-iommu integration. This is due to the fact VFIO registers > IOMMU_NOTIFIER_ALL notif

Re: [PATCH 0/6] m68k: Overhaul of MOVEC instruction to support exception/MSP

2021-02-11 Thread Laurent Vivier
Le 01/02/2021 à 01:01, BALATON Zoltan a écrit : > Hello, > > This is Lucien's m68k series rebased on and fixed up to work with > current master as per previous discussion: > https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg02840.html > > I've left previous Reviewed-by tags for reference b

Re: [PATCH 10/24] DAX: virtiofsd: Add setup/remove mappings fuse commands

2021-02-11 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Thu, Feb 11, 2021 at 04:39:22PM +, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Tue, Feb 09, 2021 at 07:02:10PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > +static void do_removemapping(fuse

Re: [PATCH 10/24] DAX: virtiofsd: Add setup/remove mappings fuse commands

2021-02-11 Thread Vivek Goyal
On Thu, Feb 11, 2021 at 07:50:37PM +, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > On Thu, Feb 11, 2021 at 04:39:22PM +, Dr. David Alan Gilbert wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > On Tue, Feb 09, 2021 at 07:02:10PM +, Dr. D

[PULL v2 00/11] target-arm queue

2021-02-11 Thread Peter Maydell
l-request' into staging (2021-02-10 15:42:20 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210211-1 for you to fetch changes up to d3c1183ffeb71ca3a783eae3d7e1c51e71e8a621: target/arm: Correctly initialize MDCR_

Re: [PATCH 2/2] file-posix: Cache next hole

2021-02-11 Thread Eric Blake
On 2/11/21 11:22 AM, Max Reitz wrote: > We have repeatedly received reports that SEEK_HOLE and SEEK_DATA are > slow on certain filesystems and/or under certain circumstances. That is > why we generally try to avoid it (which is why bdrv_co_block_status() > has the @want_zero parameter, and which i

Re: [PATCH v2 21/21] tests/acceptance: add a new tests to detect counting errors

2021-02-11 Thread Wainer dos Santos Moschetta
On 2/10/21 7:10 PM, Alex Bennée wrote: The insn plugin has a simple heuristic to detect if an instruction is detected running twice in a row. Check the plugin log after the run and pass accordingly. Signed-off-by: Alex Bennée Message-Id: <20210209182749.31323-13-alex.ben...@linaro.org> ---

Re: [PATCH v13 0/5] UFFD write-tracking migration/snapshots

2021-02-11 Thread David Hildenbrand
On 09.02.21 19:38, Andrey Gruzdev wrote: On 09.02.2021 15:37, David Hildenbrand wrote: On 21.01.21 16:24, andrey.gruzdev--- via wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Curr

Re: [PATCH v2 18/21] accel/tcg: re-factor non-RAM execution code

2021-02-11 Thread Richard Henderson
On 2/10/21 2:10 PM, Alex Bennée wrote: > There is no real need to use CF_NOCACHE here. As long as the TB isn't > linked to other TBs or included in the QHT or jump cache then it will > only get executed once. > > Signed-off-by: Alex Bennée > Message-Id: <20210209182749.31323-10-alex.ben...@linaro

Re: [PATCH] hw/sd: sdhci: Do not transfer any data when command fails

2021-02-11 Thread Philippe Mathieu-Daudé
On 2/11/21 9:52 AM, Mauro Matteo Cascella wrote: > Hello, > > On Wed, Feb 10, 2021 at 11:27 PM Alistair Francis > wrote: >> >> On Tue, Feb 9, 2021 at 2:55 AM Bin Meng wrote: >>> >>> At the end of sdhci_send_command(), it starts a data transfer if >>> the command register indicates a data is ass

Re: [PATCH v6 00/31] target-arm: Implement ARMv8.5-MemTag, user mode

2021-02-11 Thread Peter Maydell
On Thu, 11 Feb 2021 at 10:44, Peter Maydell wrote: > > On Wed, 10 Feb 2021 at 00:02, Richard Henderson > wrote: > > > > Changes for v6: > > * Drop the change to probe_access. The cpu_untagged_addr function > > isn't correct, since that's specifically for syscalls. The uses > > of prob

Re: [PATCH v3 0/3] Add npcm7xx emc model

2021-02-11 Thread Peter Maydell
On Thu, 11 Feb 2021 at 11:34, Peter Maydell wrote: > > On Tue, 9 Feb 2021 at 01:55, Doug Evans wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features.

  1   2   3   4   5   >