Re: [PATCH] cpu-throttle: Remove timer_mod() from cpu_throttle_set()

On 31/12/20 14:13, Utkarsh Tripathi wrote: During migrations, after each iteration, cpu_throttle_set() is called, which irrespective of input, re-arms the timer according to value of new_throttle_pct. This causes cpu_throttle_thread() to be delayed in getting scheduled and consqeuntly lets guest

[PATCH v4 09/18] migration/rdma: add multifd_rdma_load_setup() to setup multifd rdma

Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 52 1 file changed, 52 insertions(+) diff --git a/migration/rdma.c b/migration/rdma.c index e0ea86d..996afb0 100644 --- a/migration/rdma.c +++ b/migration/r

Re: [PATCH] blockjob: Fix crash with IOthread when block commit after snapshot

subject should start with [PATCH v5] 03.02.2021 05:40, 08005...@163.com wrote: From: Michael Qiu v5: reformat the commit log with backtrace of main thread Add a boolean variable to make main thread could re-acquire aio_context on success path. v4: rebase to latest code v3: reformat

[PATCH v4 16/18] migration/rdma: add rdma_channel into Migrationstate field

Multifd RDMA is need to poll when we send data, record it. Signed-off-by: Chuan Zheng --- migration/migration.c | 1 + migration/migration.h | 1 + migration/rdma.c | 14 ++ 3 files changed, 16 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index b8f

[PATCH v4 08/18] migration/rdma: export getQIOChannel to get QIOchannel in rdma

Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/qemu-file.c | 5 + migration/qemu-file.h | 1 + 2 files changed, 6 insertions(+) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index be21518..37f6201 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file

[PATCH v4 17/18] migration/rdma: send data for both rdma-pin-all and NOT rdma-pin-all mode

Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/rdma.c | 65 1 file changed, 61 insertions(+), 4 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 2097839..c19a91f 100644 --- a/migration/rdma.c +++ b/

[PATCH v4 10/18] migration/rdma: Create the multifd recv channels for RDMA

We still don't transmit anything through them, and we only build the RDMA connections. Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/rdma.c | 69 ++-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a/migrati

[PATCH v4 02/18] migration/rdma: judge whether or not the RDMA is used for migration

Add enabled_rdma_migration into MigrationState to judge whether or not the RDMA is used for migration. Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/migration.c | 13 + migration/migration.h | 6 ++ 2 files changed, 19 insertions(+) diff --git a/migration

[PATCH v4 14/18] migration/rdma: register memory for multifd RDMA channels

Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/multifd.c | 3 ++ migration/rdma.c| 92 +++-- 2 files changed, 93 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 919a414..1186246

[PATCH v4 07/18] migration/rdma: add rdma field into multifd send/recv param

Note we do want to export any rdma struct, take void * instead. Signed-off-by: Chuan Zheng --- migration/multifd.h | 8 1 file changed, 8 insertions(+) diff --git a/migration/multifd.h b/migration/multifd.h index d57756c..b17a2c1 100644 --- a/migration/multifd.h +++ b/migration/multifd

[PATCH v4 11/18] migration/rdma: record host_port for multifd RDMA

Signed-off-by: Chuan Zheng --- migration/migration.c | 1 + migration/migration.h | 3 +++ migration/rdma.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 129c81a..b8f4844 100644 --- a/migration/migration.c +++ b/migration/migratio

[PATCH v4 05/18] migration/rdma: do not need sync main for rdma

Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/multifd.c | 8 1 file changed, 8 insertions(+) diff --git a/migration/multifd.c b/migration/multifd.c index 4820702..5d34950 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -583,6 +583,10 @@ void multifd_

[PATCH v4 15/18] migration/rdma: only register the memory for multifd channels

All data is sent by multifd Channels, so we only register its for multifd channels and main channel don't register its. Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/rdma.c | 8 1 file changed, 8 insertions(+) diff --git a/migration/rdma.c b/migration/rdma.c inde

[PATCH v4 13/18] migration/rdma: Add the function for dynamic page registration

Add the 'qemu_rdma_registration' function, multifd send threads call it to register memory. Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/rdma.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/migration/rdma.c b/migr

[PATCH v4 18/18] migration/rdma: RDMA cleanup for multifd migration

Signed-off-by: Chuan Zheng --- migration/multifd.c | 6 ++ migration/multifd.h | 1 + migration/rdma.c| 16 +++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/migration/multifd.c b/migration/multifd.c index 1186246..4031648 100644 --- a/migration/multifd.c +

[PATCH v4 03/18] migration/rdma: create multifd_setup_ops for Tx/Rx thread

Create multifd_setup_ops for TxRx thread, no logic change. Signed-off-by: Chuan Zheng --- migration/multifd.c | 44 +++- migration/multifd.h | 7 +++ 2 files changed, 46 insertions(+), 5 deletions(-) diff --git a/migration/multifd.c b/migration/multi

[PATCH v4 06/18] migration/rdma: export MultiFDSendParams/MultiFDRecvParams

MultiFDSendParams and MultiFDRecvParams is need for rdma, export it Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng --- migration/multifd.c | 26 ++ migration/multifd.h | 2 ++ 2 files changed, 28 insertions(+) diff --git a/migration/multifd.c b/migration/multifd

[PATCH v4 12/18] migration/rdma: Create the multifd send channels for RDMA

Signed-off-by: Chuan Zheng --- migration/multifd.c | 4 ++-- migration/multifd.h | 2 ++ migration/rdma.c| 57 + 3 files changed, 61 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index ae0b7f0..919a4

[PATCH v4 00/18] Support Multifd for RDMA migration

The RDMA bandwidth is not fully utilized for over 25Gigabit NIC because of single channel for RDMA migration. This patch series is going to support multifd for RDMA migration based on multifd framework. Comparsion is between origion and multifd RDMA migration is re-tested for v3. The VM specificat

[PATCH v4 04/18] migration/rdma: add multifd_setup_ops for rdma

Signed-off-by: Chuan Zheng --- migration/multifd.c | 6 + migration/multifd.h | 5 migration/rdma.c| 71 + 3 files changed, 82 insertions(+) diff --git a/migration/multifd.c b/migration/multifd.c index cb1fc01..4820702 100644 ---

[PATCH v4 01/18] migration/rdma: add the 'migrate_rdma_pin_all' function

Signed-off-by: Zhimin Feng Signed-off-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 9 + migration/migration.h | 1 + 2 files changed, 10 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 1986cb8..447dfb9 100644 --- a/migra

Re: [PATCH] replay: rng-builtin support

On 03/02/21 07:00, Pavel Dovgalyuk wrote: This patch enables using rng-builtin with record/replay by making the callbacks deterministic. Signed-off-by: Pavel Dovgalyuk --- backends/rng-builtin.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backends/rng-builtin.c b

[PATCH] replay: rng-builtin support

This patch enables using rng-builtin with record/replay by making the callbacks deterministic. Signed-off-by: Pavel Dovgalyuk --- backends/rng-builtin.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c index f38dff117d..f367

[Bug 1914353] Re: QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID

CVE requested. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914353 Title: QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID Status in QEMU: New Bug description: Via [qemu-security]

Re: [PATCH v4 01/23] tcg: Introduce target-specific page data for user-only

On 2/2/21 4:40 PM, Richard Henderson wrote: > Well, here's the thing: this appears to be v3, reposted. > > All of the work I did for v4 has gone missing. I went to go fix the single > use > of current_cpu, and it wasn't where I expected it to be, and that's when I > noticed. I'm grepping blobs

[Bug 1914353] [NEW] QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID

*** This bug is a security vulnerability *** Public security bug reported: Via [qemu-security] list +-- On Sun, 31 Jan 2021, Philippe Mathieu-Daudé wrote --+ | On 1/31/21 11:34 AM, Philippe Mathieu-Daudé wrote: | > Per the ARM Generic Interrupt Controller Architecture specification | > (document

[Bug 1914353] Re: QEMU: aarch64: :GIC: out-of-bounds access via interrupt ID

Upstream patch: -> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg00709.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914353 Title: QEMU: aarch64: :GIC: out-of-bounds access via i

Re: [PATCH] cpu-throttle: Remove timer_mod() from cpu_throttle_set()

PING From: Utkarsh Tripathi Date: Thursday, 31 December 2020 at 6:43 PM To: qemu-devel@nongnu.org Cc: Utkarsh Tripathi , Paolo Bonzini Subject: [PATCH] cpu-throttle: Remove timer_mod() from cpu_throttle_set() During migrations, after each iteration, cpu_throttle_set() is called, which irrespec

[PATCH v4 4/4] target/arm: Set ID_PFR0.DIT to 1 for "max" 32-bit CPU

Enable FEAT_DIT for the "max" 32-bit CPU. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 40142ac141e5..c98f44624423 100644 --- a/target/arm/cpu.c +++ b/target/arm/c

[PATCH v4 3/4] target/arm: Set ID_AA64PFR0.DIT and ID_PFR0.DIT to 1 for "max" AA64 CPU

Enable FEAT_DIT for the "max" AARCH64 CPU. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/cpu64.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 5e851028c592..9a5cfd4fc632 100644 --- a/target/arm/cpu64.c +++ b/ta

[PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate

cpsr has been treated as being the same as spsr, but it isn't. Since PSTATE_SS isn't in cpsr, remove it and move it into env->pstate. This allows us to add support for CPSR_DIT, adding helper functions to merge SPSR_ELx to and from CPSR. Signed-off-by: Rebecca Cran --- target/arm/helper-a64.c |

[PATCH v4 1/4] target/arm: Add support for FEAT_DIT, Data Independent Timing

Add support for FEAT_DIT. DIT (Data Independent Timing) is a required feature for ARMv8.4. Since virtual machine execution is largely nondeterministic and TCG is outside of the security domain, it's implemented as a NOP. Signed-off-by: Rebecca Cran Reviewed-by: Richard Henderson --- target/arm/

[PATCH v4 0/4] target/arm: Add support for FEAT_DIT, Data Independent Timing

Add support for FEAT_DIT. DIT (Data Independent Timing) is a required feature for ARMv8.4. Changes from v3 to v4: o Fixed AA32 DIT/PSTATE_SS patch following review feedback. Rebecca Cran (4): target/arm: Add support for FEAT_DIT, Data Independent Timing target/arm: Support AA32 DIT by moving

Re: [PATCH v8 12/13] confidential guest support: Alter virtio default properties for protected guests

On Tue, Feb 02, 2021 at 06:06:34PM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 02, 2021 at 03:13:14PM +1100, David Gibson wrote: > > The default behaviour for virtio devices is not to use the platforms normal > > DMA paths, but instead to use the fact that it's running in a hypervisor > > to dir

[Bug 1906156] Re: Host OS Reboot Required, for Guest kext to Load (Fully)

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906156 Title: Host OS Reb

ARM Snapshots Not Backwards-Compatible

Hello, I'm attempting to restore an AArch64 snapshot taken on QEMU 4.1.0 on QEMU 5.2.0, using system mode. My previous impression, possibly from https://wiki.qemu.org/Features/Migration/Troubleshooting#Basics was that this ought to work: > Note that QEMU supports migrating forward between QEMU ve

Re: [PATCH v4 01/23] tcg: Introduce target-specific page data for user-only

On 2/2/21 4:29 AM, Peter Maydell wrote: > On Thu, 28 Jan 2021 at 22:41, Richard Henderson > wrote: >> >> This data can be allocated by page_alloc_target_data() and >> released by page_set_flags(start, end, prot | PAGE_RESET). >> >> This data will be used to hold tag memory for AArch64 MTE. >> >> S

[PATCH] blockjob: Fix crash with IOthread when block commit after snapshot

From: Michael Qiu v5: reformat the commit log with backtrace of main thread Add a boolean variable to make main thread could re-acquire aio_context on success path. v4: rebase to latest code v3: reformat the commit log, remove duplicate content Currently, if guest has workloads, IO thr

Re: [PULL 00/24] tcg patch queue

Patchew URL: https://patchew.org/QEMU/20210203021550.375058-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210203021550.375058-1-richard.hender...@linaro.org Subject: [PULL 00/24] tcg

[PULL 23/24] tcg/tci: Split out constraint sets to tcg-target-con-set.h

This requires finishing the conversion to tcg_target_op_def. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tci/tcg-target-con-set.h | 25 tcg/tci/tcg-target.h | 2 + tcg/tci/tcg-target.c.inc | 279 +-- 3 files changed, 16

[PULL 24/24] tcg: Remove TCG_TARGET_CON_SET_H

All backends have now been converted to tcg-target-con-set.h, so we can remove the fallback code. Reviewed-by: Peter Maydell Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 - tcg/arm/tcg-target.h | 1 - tcg/i386/tcg-target.h| 1 - tcg

[PULL 21/24] tcg/s390: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/s390/tcg-target-con-set.h | 29 tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.c.inc | 121 ++ 3 files changed, 81 insertions(+), 70 deletions(-) create mode 100644 tcg/

[PULL 20/24] tcg/riscv: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-con-set.h | 30 tcg/riscv/tcg-target.h | 1 + tcg/riscv/tcg-target.c.inc | 83 ++ 3 files changed, 54 insertions(+), 60 de

[PULL 17/24] tcg/arm: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target-con-set.h | 35 ++ tcg/arm/tcg-target.h | 1 + tcg/arm/tcg-target.c.inc | 94 3 files changed, 68 insertions(+), 62 deletions(-) create mode 100644 tc

[PULL 16/24] tcg/aarch64: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target-con-set.h | 36 + tcg/aarch64/tcg-target.h | 1 + tcg/aarch64/tcg-target.c.inc | 86 +++- 3 files changed, 65 insertions(+), 58 deletions(-) create mode 10

[PULL 19/24] tcg/ppc: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target-con-set.h | 42 +++ tcg/ppc/tcg-target.h | 1 + tcg/ppc/tcg-target.c.inc | 136 +++ 3 files changed, 99 insertions(+), 80 deletions(-) create mode 100644 tcg

[PULL 15/24] tcg/i386: Split out constraint sets to tcg-target-con-set.h

This exports the constraint sets from tcg_target_op_def to a place we will be able to manipulate more in future. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/i386/tcg-target-con-set.h | 55 ++ tcg/i386/tcg-target.h | 1 + tcg/tcg.c |

[PULL 18/24] tcg/mips: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/mips/tcg-target-con-set.h | 36 + tcg/mips/tcg-target.h | 1 + tcg/mips/tcg-target.c.inc | 96 +++ 3 files changed, 66 insertions(+), 67 deletions(-) create mode 100644 t

[PULL 11/24] tcg/riscv: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/riscv/tcg-target-con-str.h | 21 ++ tcg/riscv/tcg-target.h | 1 + tcg/riscv/tcg-target.c.inc | 52 +- 3 files changed, 35 insertions(+), 39 deletions(-) create mode 10064

[PULL 13/24] tcg/sparc: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target-con-str.h | 23 ++ tcg/sparc/tcg-target.h | 5 +-- tcg/sparc/tcg-target.c.inc | 81 +- 3 files changed, 55 insertions(+),

[PULL 14/24] tcg: Remove TCG_TARGET_CON_STR_H

All backends have now been converted to tcg-target-con-str.h, so we can remove the fallback code. Reviewed-by: Peter Maydell Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 1 - tcg/arm/tcg-target.h | 1 - tcg/i386/tcg-target.h| 1 - tcg

[PULL 22/24] tcg/sparc: Split out constraint sets to tcg-target-con-set.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target-con-set.h | 32 +++ tcg/sparc/tcg-target.h | 1 + tcg/sparc/tcg-target.c.inc | 75 +++--- 3 files changed, 56 insertions(+), 52 deletions(-) create mode 1006

[PULL 10/24] tcg/mips: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/mips/tcg-target-con-str.h | 24 +++ tcg/mips/tcg-target.h | 1 + tcg/mips/tcg-target.c.inc | 77 ++- 3 files changed, 46 insertions(+), 56

[PULL 09/24] tcg/tci: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tci/tcg-target-con-str.h | 11 +++ tcg/tci/tcg-target.h | 2 ++ tcg/tci/tcg-target.c.inc | 14 -- 3 files changed, 13 insertions(+), 14 deletions(-) create m

[PULL 07/24] tcg/aarch64: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target-con-str.h | 24 +++ tcg/aarch64/tcg-target.h | 1 + tcg/aarch64/tcg-target.c.inc | 51 +--- 3 files changed, 33 insertions(+), 43 deletions(-) create mode

[PULL 04/24] tcg/i386: Tidy register constraint definitions

Create symbolic constants for all low-byte-addressable and second-byte-addressable registers. Create a symbol for the registers that need reserving for softmmu. There is no functional change for 's', as this letter is only used for i386. The BYTEL name is correct for the action we wish from the

[PULL 08/24] tcg/ppc: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target-con-str.h | 30 +++ tcg/ppc/tcg-target.h | 1 + tcg/ppc/tcg-target.c.inc | 73 3 files changed, 46 insertions(+), 58 deletions(-) create mode 100644 t

[PULL 05/24] tcg/i386: Split out target constraints to tcg-target-con-str.h

This eliminates the target-specific function target_parse_constraint and folds it into the single caller, process_op_defs. Since this is done directly into the switch statement, duplicates are compilation errors rather than silently ignored at runtime. Reviewed-by: Peter Maydell Signed-off-by: R

[PULL 12/24] tcg/s390: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/s390/tcg-target-con-str.h | 28 ++ tcg/s390/tcg-target.h | 1 + tcg/s390/tcg-target.c.inc | 53 +-- 3 files changed, 42 insertions(+), 40 deletions(-) create mode 100

[PULL 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

The opcodes always exist, regardless of whether or not they are enabled. Remove the unnecessary ifdefs. Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 82 1 file changed, 82 deletions(-) diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/t

[PULL 06/24] tcg/arm: Split out target constraints to tcg-target-con-str.h

Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/arm/tcg-target-con-str.h | 22 +++ tcg/arm/tcg-target.h | 1 + tcg/arm/tcg-target.c.inc | 74 +--- 3 files changed, 41 insertions(+), 56 deletions(-) create mode 100644 tcg/a

[PULL 03/24] tcg/i386: Move constraint type check to tcg_target_const_match

Rather than check the type when filling in the constraint, check it when matching the constant. This removes the only use of the type argument to target_parse_constraint. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 28 +---

[PULL 00/24] tcg patch queue

The following changes since commit 77f3804ab7ed94b471a14acb260e5aeacf26193f: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2021-02-02 16:47:51 +) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-2021020

[PULL 01/24] tcg/tci: Drop L and S constraints

These are identical to the 'r' constraint. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tci/tcg-target.c.inc | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tcg/tci/tcg-target.c.inc b/tcg/tci/tcg-target.c.inc index 15981265db..9c45f5f88f 100

Re: [PATCH] target/avr/cpu: Use device_class_set_parent_realize()

On 1/31/21 10:03 PM, Philippe Mathieu-Daudé wrote: > Change generated automatically using the Coccinelle > patch included in commit bf853881690 ("qdev: use > device_class_set_parent_realize/unrealize/reset()") > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/avr/cpu.c | 4 +--- > 1 file

[RFC PATCH v1 00/01] PCIe DOE for PCIe and CXL 2.0

PCIe Data Object Exchange (DOE) protocol for PCIe and CXL is available https://gitlab.com/avery-qemu/cxl2.0-v3-doe/ based on Ben Widawsky's CXL QEMU cxl2.0-v3 gitlab branch https://lore.kernel.org/qemu-devel/20210202005948.241655-1-ben.widaw...@intel.com which is located at https://gitlab.c

Re: [PATCH v3 2/4] target/arm: Add support for FEAT_DIT, Data Independent Timing

On 2/2/21 12:21 PM, Rebecca Cran wrote: > On 1/27/21 10:06 PM, Richard Henderson wrote: >> In particular: CPSR.DIT (bit 21) -> SPSR_EL1.DIT (bit 24), and merging >> PSTATE.SS into SPSR_EL1.SS (bit 21). > > Thanks. I _think_ I'm understanding it better now. Would the following work? I > don't see w

Re: [PATCH v2 2/2] sev: update sev-inject-launch-secret to make gpa optional

On Tue, 2021-01-26 at 12:32 +, Dr. David Alan Gilbert wrote: > * James Bottomley (j...@linux.ibm.com) wrote: > > If the gpa isn't specified, it's value is extracted from the OVMF > > properties table located below the reset vector (and if this > > doesn't > > exist, an error is returned). OVMF

Re: [PATCH v2 1/2] pc: add parser for OVMF reset block

On Tue, 2021-01-26 at 12:22 +, Dr. David Alan Gilbert wrote: > * James Bottomley (j...@linux.ibm.com) wrote: > > OVMF is developing a mechanism for depositing a GUIDed table just > > below the known location of the reset vector. The table goes > > backwards in memory so all entries are of the

Re: [PATCH] hw/net: Add npcm7xx emc model

On Mon, Feb 1, 2021 at 9:11 AM Peter Maydell wrote: > On Fri, 22 Jan 2021 at 00:34, dje--- via wrote: > > > > This is a 10/100 ethernet device that has several features. > > Only the ones needed by the Linux driver have been implemented. > > See npcm7xx_emc.c for a list of unimplemented features

[PATCH v2 3/3] tests/qtests: Add npcm7xx emc model test

Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- tests/qtest/meson.build| 1 + tests/qtest/npcm7xx_emc-test.c | 793 + 2 files changed, 794 insertions(+) create mode 100644 tests/qtest/npcm7xx_emc-test.c diff --git a/tests/qt

[PATCH v2 1/3] hw/net: Add npcm7xx emc model

This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- hw/net/meson.build | 1 + h

[PATCH v2 2/3] hw/arm: Add npcm7xx emc model

This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Reviewed-by: Hao Wu Reviewed-by: Avi Fishman Signed-off-by: Doug Evans --- docs/system/arm/nuvoton.rst | 3 ++- h

[PATCH v2 0/3] Add npcm7xx emc model

This is a 10/100 ethernet device that has several features. Only the ones needed by the Linux driver have been implemented. See npcm7xx_emc.c for a list of unimplemented features. Doug Evans (3): hw/net: Add npcm7xx emc model hw/arm: Add npcm7xx emc model tests/qtests: Add npcm7xx emc model

Re: [RFC PATCH 1/4] include/standard-headers/linux/pci_regs: temp hack to add necessary DOE definitions.

On Tue, Feb 02, 2021 at 07:39:51AM -0800, Ben Widawsky wrote: > On 21-02-01 23:16:26, Jonathan Cameron wrote: > > Signed-off-by: Jonathan Cameron > > --- > > include/standard-headers/linux/pci_regs.h | 33 ++- > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff -

Re: [PULL 00/20] NBD patches for 2021-02-02

Patchew URL: https://patchew.org/QEMU/20210202224529.642055-1-ebl...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210202224529.642055-1-ebl...@redhat.com Subject: [PULL 00/20] NBD patches for 2021-02-02

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

On 2/3/21 1:15 AM, Eric Blake wrote: > On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> 28.01.2021 20:13, Denis V. Lunev wrote: >>> Original specification says that l1 table size if 64 * l1_size, which >>> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes. >>> Thus 64

Re: [PATCH v8 12/13] confidential guest support: Alter virtio default properties for protected guests

On Tue, Feb 02, 2021 at 03:13:14PM +1100, David Gibson wrote: > The default behaviour for virtio devices is not to use the platforms normal > DMA paths, but instead to use the fact that it's running in a hypervisor > to directly access guest memory. That doesn't work if the guest's memory > is pro

[PULL 20/20] nbd: make nbd_read* return -EIO on error

From: Roman Kagan NBD reconnect logic considers the error code from the functions that read NBD messages to tell if reconnect should be attempted or not: it is attempted on -EIO, otherwise the client transitions to NBD_CLIENT_QUIT state (see nbd_channel_error). This error code is propagated from

Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

On 2/2/21 4:50 PM, Denis V. Lunev wrote: > On 2/3/21 1:15 AM, Eric Blake wrote: >> On 1/28/21 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 28.01.2021 20:13, Denis V. Lunev wrote: Original specification says that l1 table size if 64 * l1_size, which is obviously wrong. The size of the

Re: [PULL 0/9] pc,virtio: fixes, features

On Tue, Feb 02, 2021 at 10:44:28PM +, Peter Maydell wrote: > On Tue, 2 Feb 2021 at 15:12, Michael S. Tsirkin wrote: > > > > The following changes since commit 9cd69f1a270235b652766f00b94114f48a2d603f: > > > > Merge remote-tracking branch > > 'remotes/stefanberger/tags/pull-tpm-2021-01-25-1'

[PULL 19/20] block/nbd: only enter connection coroutine if it's present

From: Roman Kagan When an NBD block driver state is moved from one aio_context to another (e.g. when doing a drain in a migration thread), nbd_client_attach_aio_context_bh is executed that enters the connection coroutine. However, the assumption that ->connection_co is always present here appear

[PATCH] acpi: use constants as strncpy limit

gcc is not smart enough to figure out length was validated before use as strncpy limit, resulting in this warning: inlined from ‘virt_set_oem_table_id’ at ../../hw/arm/virt.c:2197:5: /usr/include/aarch64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends o

[PULL 16/20] block/io: support int64_t bytes in read/write wrappers

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

[PULL 18/20] block/nbd: only detach existing iochannel from aio_context

From: Roman Kagan When the reconnect in NBD client is in progress, the iochannel used for NBD connection doesn't exist. Therefore an attempt to detach it from the aio_context of the parent BlockDriverState results in a NULL pointer dereference. The problem is triggerable, in particular, when an

[PULL 15/20] block/io: support int64_t bytes in bdrv_co_p{read, write}v_part()

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

Hi-- On 2/1/21 9:24 AM, Adrian Catangiu wrote: > - Background and problem > > The System Generation ID feature is required in virtualized or > containerized environments by applications that work with local copies > or caches of world-unique data such as random values, uuids, > monotonically incr

[PULL 12/20] block/io: support int64_t bytes in bdrv_aligned_pwritev()

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

[PULL 17/20] block/io: use int64_t bytes in copy_range

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

[PATCH] acpi: use constants as strncpy limit

gcc is not smart enough to figure out length was validated before use as strncpy limit, resulting in this warning: inlined from ‘virt_set_oem_table_id’ at ../../hw/arm/virt.c:2197:5: /usr/include/aarch64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound depends o

[PULL 06/20] block/io: bdrv_pad_request(): support qemu_iovec_init_extended failure

From: Vladimir Sementsov-Ogievskiy Make bdrv_pad_request() honest: return error if qemu_iovec_init_extended() failed. Update also bdrv_padding_destroy() to clean the structure for safety. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201211183934.169161-6-vsement...@virtuozzo.com>

[PULL 08/20] block/io: improve bdrv_check_request: check qiov too

From: Vladimir Sementsov-Ogievskiy Operations with qiov add more restrictions on bytes, let's cover it. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201211183934.169161-8-vsement...@virtuozzo.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- block/io.c | 46 +++

[PULL 07/20] block/throttle-groups: throttle_group_co_io_limits_intercept(): 64bit bytes

From: Vladimir Sementsov-Ogievskiy The function is called from 64bit io handlers, and bytes is just passed to throttle_account() which is 64bit too (unsigned though). So, let's convert intermediate argument to 64bit too. This patch is a first in the 64-bit-blocklayer series, so we are generally

[PULL 05/20] block/io: refactor bdrv_pad_request(): move bdrv_pad_request() up

From: Vladimir Sementsov-Ogievskiy Prepare for the following patch when bdrv_pad_request() will be able to fail. Update the comments. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201211183934.169161-5-vsement...@virtuozzo.com> Reviewed-by: Eric Blake [eblake: grammar tweak] Signe

Re: iotest failures in head [was: [PATCH v4 00/16] 64bit block-layer: part I]

On Tue, 2 Feb 2021 at 17:09, Vladimir Sementsov-Ogievskiy wrote: > Note that 30 is known to crash sometimes. Look at > > "[PATCH RFC 0/5] Fix accidental crash in iotest 30" > > https://patchew.org/QEMU/20201120161622.1537-1-vsement...@virtuozzo.com/ It certainly seems to be the least reliable iot

[PULL 14/20] block/io: support int64_t bytes in bdrv_aligned_preadv()

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

[PULL 03/20] util/iov: make qemu_iovec_init_extended() honest

From: Vladimir Sementsov-Ogievskiy Actually, we can't extend the io vector in all cases. Handle possible MAX_IOV and size_t overflows. For now add assertion to callers (actually they rely on success anyway) and fix them in the following patch. Add also some additional good assertions to qemu_io

[PULL 02/20] block: refactor bdrv_check_request: add errp

From: Vladimir Sementsov-Ogievskiy It's better to pass &error_abort than just assert that result is 0: on crash, we'll immediately see the reason in the backtrace. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20201211183934.169161-2-vsement...@virtuozzo.com> Reviewed-by: Eric Blake

[PULL 13/20] block/io: support int64_t bytes in bdrv_co_do_copy_on_readv()

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

[PULL 09/20] block: use int64_t as bytes type in tracked requests

From: Vladimir Sementsov-Ogievskiy We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t

  1   2   3   4   5   >