Detect whether qmp-shell's standard input is not a TTY; in such case,
assume a non-interactive mode, which suppresses the welcome banner and
the "(QEMU)" prompt. This allows for easier consumption of qmp-shell's
output in scripts.
Example usage before this change:
$ printf "query-status\nque
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1757363
Title:
infinite lo
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1681688
Title:
qemu live m
On Sat, Jan 16, 2021 at 2:32 PM Philippe Mathieu-Daudé wrote:
>
> On 1/16/21 12:00 AM, Alistair Francis wrote:
> > We were accidently passing RISCVHartArrayState by value instead of
> > pointer. The type is 824 bytes long so let's correct that and pass it by
> > pointer instead.
> >
> > Fixes: Cov
On 1/16/21 12:00 AM, Alistair Francis wrote:
> We were accidently passing RISCVHartArrayState by value instead of
> pointer. The type is 824 bytes long so let's correct that and pass it by
> pointer instead.
>
> Fixes: Coverity CID 1438099
> Fixes: Coverity CID 1438100
> Fixes: Coverity CID 143810
On 1/16/21 8:46 PM, BALATON Zoltan wrote:
> On Sat, 16 Jan 2021, Richard Henderson wrote:
>> On 1/16/21 4:38 AM, BALATON Zoltan wrote:
>>>
>>> Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with
>>> constant
>>> folding) seems to break PPC emulation for me:
>>>
>>> Thread 3 "qemu-syst
Keep setting ret close to setting errp and don't merge different error
paths into one. This way it's more obvious that we don't return
error without setting errp.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 11 ---
1 file changed, 8 insert
Set errp always on failure. Generic bdrv_open_driver supports driver
functions which can return negative value and forget to set errp.
That's a strange thing.. Let's improve bdrv_qed_do_open to not behave
this way. This allows to simplify code in
bdrv_qed_co_invalidate_cache().
Signed-off-by: Vlad
qcow2_do_open correctly sets errp on each failure path. So, we can
simplify code in qcow2_co_invalidate_cache() and drop explicit error
propagation.
Add ERRP_GUARD() as mandated by the documentation in
include/qapi/error.h so that error_prepend() is actually called even if
errp is &error_fatal.
S
Don't use error propagation in qcow2_get_specific_info(). For this
refactor qcow2_get_bitmap_info_list, its current interface is rather
weird.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/qcow2.h| 4 ++--
block/qcow2-bitmap.c
It's better to return status together with setting errp. It allows to
reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --gi
Better to return status together with setting errp. It allows to avoid
error propagation in the caller.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
include/block/blockjob.h | 2 +-
blockjob.c | 18 --
2 files
It's better to return status together with setting errp. It makes
possible to avoid error propagation.
While being here, put ERRP_GUARD() to fix error_prepend(errp, ...)
usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment
above ERRP_GUARD() definition in include/qapi/error.h)
Sig
v6:
01: fix uninitialized ret
02,14: add Alberto's r-b
Vladimir Sementsov-Ogievskiy (14):
block: return status from bdrv_append and friends
block: use return status of bdrv_append()
block: check return value of bdrv_open_child and drop error
propagation
blockdev: fix drive_backup_prepa
It's recommended for bool functions with errp to return true on success
and false on failure. Non-standard interfaces don't help to understand
the code. The change is also needed to reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Reviewed-by: Gre
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
scripts/simplebench/bench_block_job.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/simplebench/bench_block_job.py
b/scripts/simplebench/bench_block_job.py
index 9808d696cf..a0dda1dc4e 100755
-
Let's check return value of mirror_start_job to check for failure
instead of local_err.
Rename ret to job, as ret is usually integer variable.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block/mirror.c | 12 +---
1 file changed, 5
Add script to benchmark new backup architecture.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
scripts/simplebench/bench-backup.py | 167
1 file changed, 167 insertions(+)
create mode 100755 scripts/simplebench/bench-backup.py
diff --git a/scripts/simplebench/ben
We leak local_err and don't report failure to the caller. It's
definitely wrong, let's fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
blockdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/backup.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 5522c0f3fe..466608ee55 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -236,7 +236,7 @@
This patch is generated by cocci script:
@@
symbol bdrv_open_child, errp, local_err;
expression file;
@@
file = bdrv_open_child(...,
-&local_err
+errp
);
- if (local_err)
+ if (!file)
{
...
- error_propagate(err
The recommended use of qemu error api assumes returning status together
with setting errp and avoid void functions with errp parameter. Let's
improve bdrv_append and some friends to reduce error-propagation
overhead in further patches.
Choose int return status, because bdrv_replace_node_common() h
The further change of moving backup to be a one block-copy call will
make copying chunk-size and cluster-size two separate things. So, even
with 64k cluster sized qcow2 image, default chunk would be 1M.
Test 219 depends on specified chunk-size. Update it for explicit
chunk-size for backup as for mi
Iotest 257 dumps a lot of in-progress information of backup job, such
as offset and bitmap dirtiness. Further commit will move backup to be
one block-copy call, which will introduce async parallel requests
instead of plain cluster-by-cluster copying. To keep things
deterministic, allow only one wor
bdrv_set_backing_hd now returns status, let's use it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Greg Kurz
Reviewed-by: Alberto Garcia
---
block.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 0951d3b2c1..9483edb500 100644
--- a
Drop unused code.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/block-copy.h | 6 --
block/block-copy.c | 15 ---
2 files changed, 21 deletions(-)
diff --git a/include/block/block-copy.h b/include/block/block-copy.h
index 7821850f
This brings async request handling and block-status driven chunk sizes
to backup out of the box, which improves backup performance.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/backup.c | 187 +++--
1 file changed, 120
Further commit will add a benchmark
(scripts/simplebench/bench-backup.py), which will show that backup
works better with async parallel requests (previous commit) and
disabled copy_range. So, let's disable copy_range by default.
Note: the option was added several commits ago with default to true,
We are going to stop use of this callback in the following commit.
Still the callback handling code will be dropped in a separate commit.
So, for now let's make it optional.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 4 +++-
1 file changed, 3 ins
Now bdrv_append returns status and we can drop all the local_err things
around it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
---
block.c | 6 ++
block/backup-top.c | 23 +++
block/commit.c | 6 ++--
The further change of moving backup to be a one block-copy call will
make copying chunk-size and cluster-size two separate things. So, even
with 64k cluster sized qcow2 image, default chunk would be 1M.
185 test however assumes, that with speed limited to 64K, one iteration
would result in offset=6
After introducing parallel async copy requests instead of plain
cluster-by-cluster copying loop, we'll have to wait for paused status,
as we need to wait for several parallel request. So, let's gently wait
instead of just asserting that job already paused.
Signed-off-by: Vladimir Sementsov-Ogievsk
We are going to directly use one async block-copy operation for backup
job, so we need rate limiter.
We want to maintain current backup behavior: only background copying is
limited and copy-before-write operations only participate in limit
calculation. Therefore we need one rate limiter for block-
Add argument to allow additional block-job options.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
scripts/simplebench/bench-example.py | 2 +-
scripts/simplebench/bench_block_job.py | 11 +++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/scri
We are going to use async block-copy call in backup, so we'll need to
passthrough setting backup speed to block-copy call.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/blockjob_int.h | 2 ++
blockjob.c | 6 ++
2 files changed, 8 inse
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/block-copy.h | 2 +-
block/backup-top.c | 2 +-
block/block-copy.c | 10 ++
3 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/include/block/block-copy.h b/include/block/bl
Add function to cancel running async block-copy call. It will be used
in backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/block-copy.h | 13 +
block/block-copy.c | 24 +++-
2 files changed, 32 insertions(+), 5 d
They will be used for backup.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/block-copy.h | 6 ++
block/block-copy.c | 11 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/include/block/block-copy.h b/include/block/bl
Add new parameters to configure future backup features. The patch
doesn't introduce aio backup requests (so we actually have only one
worker) neither requests larger than one cluster. Still, formally we
satisfy these maximums anyway, so add the parameters now, to facilitate
further patch which will
It simplifies debugging.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/block-copy.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/block/block-copy.c b/block/block-copy.c
index 35213bd832..6bf1735b93 100644
--- a/block/block-copy.c
If main job coroutine called job_yield (while some background process
is in progress), we should give it a chance to call job_pause_point().
It will be used in backup, when moved on async block-copy.
Note, that job_user_pause is not enough: we want to handle
child_job_drained_begin() as well, whic
We'll need async block-copy invocation to use in backup directly.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
include/block/block-copy.h | 29 ++
block/block-copy.c | 81 --
2 files changed, 106 insertions(+), 4
Refactor common path to use BlockCopyCallState pointer as parameter, to
prepare it for use in asynchronous block-copy (at least, we'll need to
run block-copy in a coroutine, passing the whole parameters as one
pointer).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
bloc
Experiments show, that copy_range is not always making things faster.
So, to make experimentation simpler, let's add a parameter. Some more
perf parameters will be added soon, so here is a new struct.
For now, add new backup qmp parameter with x- prefix for the following
reasons:
- We are going
Hi Max!
I applied my series onto yours 129-fixing and found, that 129 fails for backup.
And setting small max-chunk and even max-workers to 1 doesn't help! (setting
speed like in v3 still helps).
And I found, that the problem is that really, the whole backup job goes during
drain, because in new a
12.01.2021 15:14, Max Reitz wrote:
On 26.10.20 18:18, Vladimir Sementsov-Ogievskiy wrote:
After introducing parallel async copy requests instead of plain
cluster-by-cluster copying loop, backup job may finish earlier than
final assertion in do_test_stop. Let's require slow backup explicitly
by s
On Sat, 16 Jan 2021, BALATON Zoltan wrote:
On Sat, 16 Jan 2021, Richard Henderson wrote:
On 1/16/21 4:38 AM, BALATON Zoltan wrote:
Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
folding) seems to break PPC emulation for me:
See also:
https://bugs.launchpad.net/qe
Thanks for reporting it. Just found it as well and reported on the mailing
list. It's currently being investigated. List thread is here:
https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg03936.html
On Sat, 16 Jan 2021, Richard Henderson wrote:
On 1/16/21 4:38 AM, BALATON Zoltan wrote:
Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
folding) seems to break PPC emulation for me:
Thread 3 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault.
[Switching to
On Sat, 16 Jan 2021, Richard Henderson wrote:
On 1/16/21 4:38 AM, BALATON Zoltan wrote:
Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
folding) seems to break PPC emulation for me:
Thread 3 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault.
[Switching to
Done (took a while to figure out how...)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1906193
Title:
riscv32 user mode emulation: fork return values broken
Status in QEMU:
Confirmed
Bug descri
Am Samstag, 19. Dezember 2020, 20:11:13 EET schrieb Alistair Francis:
> When mapping the host waitid status to the target status we previously
> just used decoding information in the status value. This doesn't follow
> what the waitid documentation describes, which instead suggests using
> the si_c
On Fri, Jan 15, 2021 at 3:00 PM Alistair Francis
wrote:
>
> We were accidently passing RISCVHartArrayState by value instead of
> pointer. The type is 824 bytes long so let's correct that and pass it by
> pointer instead.
>
> Fixes: Coverity CID 1438099
> Fixes: Coverity CID 1438100
> Fixes: Coveri
On Fri, Jan 15, 2021 at 9:42 PM Bin Meng wrote:
>
> From: Bin Meng
>
> Now that we have switched to generate the RISC-V CSR XML dynamically,
> remove the built-in hardcoded XML files.
>
> Signed-off-by: Bin Meng
> Reviewed-by: Alistair Francis
Thanks!
Applied to riscv-to-apply.next
Alistair
Similarly to commits ae82adc8e29..7f93879e444, use the
translator_ld*() API introduced in commit 409c1a0bf0f
to fetch the code on the MIPS target.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/tlb_helper.c | 16
target/mips/translate.c | 20 ++--
2 files
On Sat, Jan 16, 2021 at 8:30 AM Bin Meng wrote:
>
> On Sat, Jan 16, 2021 at 7:00 AM Alistair Francis
> wrote:
> >
> > We were accidently passing RISCVHartArrayState by value instead of
> > pointer. The type is 824 bytes long so let's correct that and pass it by
> > pointer instead.
> >
> > Fixes:
On Sat, Jan 16, 2021 at 9:29 AM Richard Henderson
wrote:
>
> On 1/16/21 4:38 AM, BALATON Zoltan wrote:
> >
> > Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
> > folding) seems to break PPC emulation for me:
> >
> > Thread 3 "qemu-system-ppc" received signal SIGSEGV, Se
Public bug reported:
QEMU segfaults to NULL dereference in tcg/optimize.c:212 semi-randomly
after commit 7c79721606be11b5bc556449e5bcbc331ef6867d
Exception Type:EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0020
Exception Note:EXC_CORPSE_NOT
12.01.2021 00:17, Vladimir Sementsov-Ogievskiy wrote:
11.01.2021 19:08, Alberto Garcia wrote:
On Sat 09 Jan 2021 01:58:11 PM CET, Vladimir Sementsov-Ogievskiy wrote:
Keep setting ret close to setting errp and don't merge different error
paths into one. This way it's more obvious that we don't r
On 1/16/21 4:38 AM, BALATON Zoltan wrote:
>
> Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
> folding) seems to break PPC emulation for me:
>
> Thread 3 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x751e7700 (LWP 22636)]
>
On 1/15/21 1:03 PM, Alistair Francis wrote:
> I run QEMU with these arguments:
>
> ./build/riscv32-softmmu/qemu-system-riscv32 \
> -machine virt -serial mon:stdio -serial null -nographic \
> -append "root=/dev/vda rw highres=off console=ttyS0 ip=dhcp
> earlycon=sbi" \
> -device virti
On 1/16/21 4:38 AM, BALATON Zoltan wrote:
> Hello,
>
> Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
> folding) seems to break PPC emulation for me:
>
> Thread 3 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x751e7700 (LWP
On Sat, Jan 16, 2021 at 7:00 AM Alistair Francis
wrote:
>
> We were accidently passing RISCVHartArrayState by value instead of
> pointer. The type is 824 bytes long so let's correct that and pass it by
> pointer instead.
>
> Fixes: Coverity CID 1438099
> Fixes: Coverity CID 1438100
> Fixes: Coveri
On Fri, Jan 15, 2021 at 3:56 PM Richard Henderson <
richard.hender...@linaro.org> wrote:
> These constants are only ever used with access_ok, and friends.
> Rather than translating them to PAGE_* bits, let them equal
> the PAGE_* bits to begin.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Rich
Hi Philippe,
On Sun, Jan 17, 2021 at 12:12 AM Philippe Mathieu-Daudé wrote:
>
> On 1/16/21 4:59 PM, Bin Meng wrote:
> > Hi Philippe,
> >
> > On Sat, Jan 16, 2021 at 11:21 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Hi Bin,
> >>
> >> On 1/16/21 2:57 PM, Bin Meng wrote:
> >>> On Fri, Jan 15, 2
I'm still seeing this with qemu 5.2.0
armv7a-softfp-linux-gnueabi-gcc -O2 -pipe -march=armv7-a -mfpu=vfpv3-d16
-mfloat-abi=softfp -Wl,-O1 -Wl,--as-needed glibc-test.c -o glibc-test
Allocating guest commpage: Operation not permitted
--
You received this bug notification because you are a me
On 1/16/21 4:59 PM, Bin Meng wrote:
> Hi Philippe,
>
> On Sat, Jan 16, 2021 at 11:21 PM Philippe Mathieu-Daudé
> wrote:
>>
>> Hi Bin,
>>
>> On 1/16/21 2:57 PM, Bin Meng wrote:
>>> On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé
>>> wrote:
When the block is disabled, only the
On 1/16/21 2:35 PM, Bin Meng wrote:
> On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé
> wrote:
>>
>> When the block is disabled, it stay it is 'internal reset logic'
>> (internal clocks are gated off). Reading any register returns
>> its reset value. Only update this value if the device i
Hi Philippe,
On Sat, Jan 16, 2021 at 11:21 PM Philippe Mathieu-Daudé wrote:
>
> Hi Bin,
>
> On 1/16/21 2:57 PM, Bin Meng wrote:
> > On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> When the block is disabled, only the ECSPI_CONREG register can
> >> be modified. Setti
Public bug reported:
$ ../configure --disable-system --static
qemu 5.2.50
static build: YES
capstone: system
[...]
$ make qemu-i386
[...]
[478/478] Linking target qemu-i386
FAILED: qemu-i386
cc -o qemu-i386 libcommon.fa.p/hw_core_cpu.c.o
libcommo
Hi Bin,
On 1/16/21 2:57 PM, Bin Meng wrote:
> On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé
> wrote:
>>
>> When the block is disabled, only the ECSPI_CONREG register can
>> be modified. Setting the EN bit enabled the device, clearing it
>
> I don't know how this conclusion came out. T
On Sat, Jan 16, 2021 at 11:07 PM Philippe Mathieu-Daudé wrote:
>
> On 1/16/21 3:03 PM, Bin Meng wrote:
> > Hi Philippe,
> >
> > On Fri, Jan 15, 2021 at 11:31 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Hi,
> >>
> >> This is how I understand the ecSPI reset works, after
> >> looking at the IMX
On 1/16/21 3:03 PM, Bin Meng wrote:
> Hi Philippe,
>
> On Fri, Jan 15, 2021 at 11:31 PM Philippe Mathieu-Daudé
> wrote:
>>
>> Hi,
>>
>> This is how I understand the ecSPI reset works, after
>> looking at the IMX6DQRM.pdf datasheet.
>>
>> This is a respin of Ben's v5 series [*].
>>
>> Since v6:
>
Hi Stefan,
On 1/15/21 8:56 PM, Stefan Berger wrote:
> On 1/15/21 1:40 PM, Stefan Berger wrote:
>> On 1/15/21 11:06 AM, Philippe Mathieu-Daudé wrote:
>>> On 1/15/21 4:53 PM, Stefan Berger wrote:
On 1/15/21 10:52 AM, Philippe Mathieu-Daudé wrote:
> Subject is incorrect, this is not a remova
Hello,
Commit 8fe35e0444be (tcg/optimize: Use tcg_constant_internal with constant
folding) seems to break PPC emulation for me:
Thread 3 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x751e7700 (LWP 22636)]
0x55afd4ee in ts_are_copies (ts2=0x7f
Hi Philippe,
On Fri, Jan 15, 2021 at 11:31 PM Philippe Mathieu-Daudé wrote:
>
> Hi,
>
> This is how I understand the ecSPI reset works, after
> looking at the IMX6DQRM.pdf datasheet.
>
> This is a respin of Ben's v5 series [*].
>
> Since v6:
> - Dropped "Reduce 'change_mask' variable scope" patch
We are going to drop group file. Define group in tests as a preparatory
step.
The patch is generated by
cd tests/qemu-iotests
grep '^[0-9]\{3\} ' group | while read line; do
file=$(awk '{print $1}' <<< "$line");
groups=$(sed -e 's/^... //' <<< "$line");
awk "NR==2
On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé wrote:
>
> When the block is disabled, only the ECSPI_CONREG register can
> be modified. Setting the EN bit enabled the device, clearing it
I don't know how this conclusion came out. The manual only says the
following 2 registers ignore the
Add TestRunner class, which will run tests in a new python iotests
running framework.
There are some differences with current ./check behavior, most
significant are:
- Consider all tests self-executable, just run them, don't run python
by hand.
- Elapsed time is cached in json file
- Elapsed tim
Rename bitmaps migration tests and move them to tests subdirectory to
demonstrate new human-friendly test naming.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0
.../{199.out => tests/migrate-bitmaps-postcopy-test.out}
If you run './check 303', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds qcow2.py on PATH. But
if you run './303' directly, there is nothing to adjust PATH, and if
'.' is not already on your PATH by other means, the test fails because
the executable is n
Just use classes introduced in previous three commits. Behavior
difference is described in these three commits.
Drop group file, as it becomes unused.
Drop common.env: now check is in python, and for tests we use same
python interpreter that runs the check itself. Use build environment
PYTHON in
Add TestEnv class, which will handle test environment in a new python
iotests running framework.
Difference with current ./check interface:
- -v (verbose) option dropped, as it is unused
- -xdiff option is dropped, until somebody complains that it is needed
- same for -n option
- same for looking
Add python script with new logic of searching for tests:
Current ./check behavior:
- tests are named [0-9][0-9][0-9]
- tests must be registered in group file (even if test doesn't belong
to any group, like 142)
Behavior of findtests.py:
- group file is dropped
- tests are all files in test
If you run './check 277', check includes common.config which adjusts
$PATH to include '.' first, and therefore finds nbd-fault-injector.py
on PATH. But if you run './277' directly, there is nothing to adjust
PATH, and if '.' is not already on your PATH by other means, the test
fails because the ex
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
tests/qemu-iotests/294 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/294 b/tests/qemu-iotests/294
index 87da35db49..4c375ed609 100755
--- a/tests/qemu-iotests/294
+++ b/tests/qemu-iotests/294
@@ -1,3
We are going to be stricter about comparing test result with .out
files. So, fix some whitespaces now.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
tests/qemu-iotests/175.out | 2 +-
tests/qemu-iotests/271.out | 12 ++--
tests/qemu-iotests/287.out | 10 +-
All other test files are executable. Fix these.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
---
tests/qemu-iotests/283 | 0
tests/qemu-iotests/298 | 0
tests/qemu-iotests/299 | 0
3 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tests/qemu-i
Hi all!
These series has 3 goals:
- get rid of group file (to forget about rebase and in-list conflicts)
- introduce human-readable names for tests
- rewrite check into python
v7:
- fix wording and grammar
- satisfy python linters
- move argv interfaces all into one in new check script
On Fri, Jan 15, 2021 at 11:37 PM Philippe Mathieu-Daudé wrote:
>
> When the block is disabled, it stay it is 'internal reset logic'
> (internal clocks are gated off). Reading any register returns
> its reset value. Only update this value if the device is enabled.
>
> Ref: i.MX 6DQ Applications Pro
On Fri, 15 Jan 2021 at 13:50, Gerd Hoffmann wrote:
>
> The following changes since commit 45240eed4f064576d589ea60ebadf3c11d7ab891:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-yank-2021-01-13' int=
> o staging (2021-01-13 14:19:24 +)
>
> are available in the Git repository at:
16.01.2021 14:03, Vladimir Sementsov-Ogievskiy wrote:
15.01.2021 16:30, Vladimir Sementsov-Ogievskiy wrote:
15.01.2021 16:20, Kevin Wolf wrote:
Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
15.01.2021 15:45, Kevin Wolf wrote:
Am 15.01.2021 um 13:19 hat Vladimir Sementso
15.01.2021 16:30, Vladimir Sementsov-Ogievskiy wrote:
15.01.2021 16:20, Kevin Wolf wrote:
Am 15.01.2021 um 14:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
15.01.2021 15:45, Kevin Wolf wrote:
Am 15.01.2021 um 13:19 hat Vladimir Sementsov-Ogievskiy geschrieben:
15.01.2021 14:18, Kevin Wolf
Am Fri, 15 Jan 2021 20:12:05 +
schrieb Peter Maydell :
> Add the vmstate for the new NeXTPC devic; this is in theory
> a migration compatibility break, but this machine doesn't have
> working migration currently anyway.
>
> Signed-off-by: Peter Maydell
> ---
> hw/m68k/next-cube.c | 34 +
Am Fri, 15 Jan 2021 20:12:04 +
schrieb Peter Maydell :
> The fields scsi_irq, scsi_dma, scsi_reset and fd_irq in
> NeXTState are all unused, except in commented out
> "this should do something like this" code. Remove the
> unused fields. As and when the functionality that might
> use them is a
Am Fri, 15 Jan 2021 20:12:03 +
schrieb Peter Maydell :
> Move the rtc into the NeXTPC struct. Since this is the last
> use of the 'backdoor' NextState pointer we can now remove that.
>
> Probably the RTC should be its own device at some point: in hardware
> there is a separate MCS1850 RTC chi
Am Fri, 15 Jan 2021 20:12:02 +
schrieb Peter Maydell :
> Make the next_irq function be GPIO inputs to the NEXT_PC
> device, rather than a freestanding set of qemu_irq lines.
>
> This fixes a minor Coverity issue where it correctly points
> out the trivial memory leak of the memory allocated i
Am Fri, 15 Jan 2021 20:12:01 +
schrieb Peter Maydell :
> All the code which accesses int_status and int_mask is now doing
> so via the NeXTPC->NeXTState indirection, so we can move these
> fields into the NeXTPC struct where they belong.
>
> Signed-off-by: Peter Maydell
> ---
> hw/m68k/next
Am Fri, 15 Jan 2021 20:12:00 +
schrieb Peter Maydell :
> Make the next_irq function take a NeXTPC* as its opaque rather than
> the M68kCPU*. This will make it simpler to turn the next_irq
> function into a gpio input line of the NeXTPC device in the next
> commit.
>
> For this to work we hav
Am Fri, 15 Jan 2021 20:11:59 +
schrieb Peter Maydell :
> Move the registers handled by the scr_ops struct into the NeXTPC
> device.
>
> Signed-off-by: Peter Maydell
> ---
> hw/m68k/next-cube.c | 50
> ++--- 1 file changed, 25
> insertions(+), 25 deleti
100 matches
Mail list logo
