[PATCH 12/12] vt82c686: Do not add floppy

2020-12-26 Thread BALATON Zoltan via
The floppy is inaccessible because its ports are shadowed by the config registers of the superio part (switchable on the real chip but we don't model that) so disable adding the floppy matching the existing comment in vt82c686b_isa_realize() as it's not usable. Signed-off-by: BALATON Zoltan ---

[PATCH 10/12] vt82c686: Remove unneeded includes and defines

2020-12-26 Thread BALATON Zoltan via
These are not used or not needed. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 789459bcae..6dff2bc67d 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -12,22 +12,16 @@ #inclu

[PATCH 08/12] vt82c686: Remove vt82c686b_pm_init() function

2020-12-26 Thread BALATON Zoltan via
Also rename VT82C686B_PM to match other device names. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 17 - hw/mips/fuloong2e.c | 5 - include/hw/isa/vt82c686.h | 5 + 3 files changed, 5 insertions(+), 22 deletions(-) diff --git a/hw/isa/vt82c686.c

[PATCH 07/12] vt82c686: Remove vt82c686b_isa_init() function

2020-12-26 Thread BALATON Zoltan via
Also rename VT82C686B type to lower case to match other device names. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 9 - hw/mips/fuloong2e.c | 4 +++- include/hw/isa/vt82c686.h | 3 +-- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/hw/isa/vt82c686.

[PATCH 00/12] Misc vt82c686b clean ups

2020-12-26 Thread BALATON Zoltan via
This series are some small clean ups to the vt82c686b south bridge and superio chip model that is only used by the mips/fuloong2e machine. These are also in preparation to add emulation of the very similar vt8231 later that will be used by ppc/pegasos2. Regards, BALATON Zoltan BALATON Zoltan (12)

[PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros

2020-12-26 Thread BALATON Zoltan via
There's no reason to suffix everything with _DEVICE when the names are already unique without it and shorter names are more readable. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 48 +++ 1 file changed, 23 insertions(+), 25 deletions(-) diff

[PATCH 04/12] vt82c686: Remove vt82c686b_[am]c97_init() functions

2020-12-26 Thread BALATON Zoltan via
These are legacy init functions that are just equivalent to directly calling pci_create_simple so do that instead. Also rename objects to lower case via-ac97 and via-mc97 matching naming of other devices. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 27 --

[PATCH 09/12] vt82c686: Convert debug printf to trace points

2020-12-26 Thread BALATON Zoltan via
Signed-off-by: BALATON Zoltan --- hw/isa/trace-events | 6 ++ hw/isa/vt82c686.c | 51 + 2 files changed, 21 insertions(+), 36 deletions(-) diff --git a/hw/isa/trace-events b/hw/isa/trace-events index 3544c6213c..d267d3e652 100644 --- a/hw/isa/tr

[PATCH 06/12] audio/via-ac97: Simplify code and set user_creatable to false

2020-12-26 Thread BALATON Zoltan via
Remove some unneded, empty code and set user_creatable to false (besides being not implemented yet, so does nothing anyway) it's also normally part of VIA south bridge chips so no need to confuse users showing them these devices. Signed-off-by: BALATON Zoltan --- hw/audio/via-ac97.c | 51 +++

[PATCH 11/12] vt82c686: Rename some functions to better show where they belong

2020-12-26 Thread BALATON Zoltan via
This groups identifiers related to the ISA bridge part and superio part also in their naming. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 48 ++- hw/mips/fuloong2e.c | 2 +- include/hw/isa/vt82c686.h | 2 +- 3 files changed, 24 insert

[PATCH 01/12] vt82c686: Add APM and ACPI dependencies for VT82C686

2020-12-26 Thread BALATON Zoltan via
Compiling vt82c686.c fails without APM and ACPI_PM functions. Add dependency on these in Kconfig to fix this. Signed-off-by: BALATON Zoltan --- hw/isa/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index c7f07854f7..2ca2593ee6 100644 --- a/hw/isa/Kc

[PATCH 05/12] vt82c686: Split off via-[am]c97 into separate file in hw/audio

2020-12-26 Thread BALATON Zoltan via
These supposed to implement audio part used in VIA south bridges so they are better placed under hw/audio. Signed-off-by: BALATON Zoltan --- hw/audio/meson.build | 1 + hw/audio/via-ac97.c | 106 +++ hw/isa/vt82c686.c| 91 --

[PATCH 02/12] vt82c686: Rename AC97/MC97 parts from VT82C686B to VIA

2020-12-26 Thread BALATON Zoltan via
These parts are common between VT82C686B and VT8231 so can be shared in the future. Rename them to VIA prefix accordingly. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw

[Bug 1908369] Re: deleted

2020-12-26 Thread Peter Maydell
** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908369 Title: deleted Status in QEMU: Invalid Bug description: sorry To manage notifications

[Bug 1906193] Re: riscv32 user mode emulation: fork return values broken

2020-12-26 Thread Andreas K . Hüttel
Just as a general remark, while this specific problem seems to be solved, there may still be issues surrounding waitid(). (With this patch applied, in a rather complex environment I see bash processes hanging in an infinite loop, with waitid involved. I am working on isolating the problem and prov

Re: [PATCH 0/8] Fix memory leak of some device state in migration

2020-12-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201226103347.868-1-gaojin...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201226103347.868-1-gaojin...@huawei.com Subject: [PATCH 0/8] Fix memory leak of some devi

[PATCH 6/8] vmbus: Fix memory leak of vmstate_vmbus_chan_req

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of vmbus/vmbus_chan_req, the field(msg) of vmbus/vmbus_chan_req having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has been allocated for SaveStateEntry of vmbus/vmbus_chan_req before dst loads device state, it may re

[PATCH 3/8] spapr: Fix memory leak of vmstate_spapr_event_entry

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of spapr_event_log_entry, the field(extended_log) of spapr_event_log_entry having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has been allocated for SaveStateEntry of spapr_event_log_entry before dst loads device stat

[PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile save VMState of spapr_pci, it may result in memory leak of msi_devs.

[PATCH 8/8] dbus-vmstate: Fix memory leak of dbus_vmstate

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of dbus_vmstate, the field(data) of dbus_vmstate having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has been allocated for SaveStateEntry of dbus_vmstate before dst loads device state, it may result that the pointer o

[PATCH 1/8] vmbus: Fix memory leak of vmstate_gpadl

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of vmbus/gpadl, the field(gfns) of vmbus/ gpadl having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has been allocated for SaveStateEntry of vmbus/gpadl before dst loads device state, it may result that the pointer of

[PATCH 5/8] savevm: Fix memory leak of vmstate_configuration

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of configuration, the fields(name and capabilities) of configuration having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free memory of capabilities in SaveState after save VMState of configuration, or the dst doesn't free memory of name

[PATCH 7/8] tpm_emulator: Fix memory leak of vmstate_tpm_emulator

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of tpm-emulator, the fields(state_blobs. permanent.buffer, state_blobs.volatil.buffer and state_blobs.savestate. buffer) of tpm-emulator having a flag of VMS_ALLOC need to allocate memory. If the dst doesn't free memory which has been allocated for SaveSta

[PATCH 2/8] virtio-net: Fix memory leak of vmstate_virtio_net_rss

2020-12-26 Thread g00517791
From: Jinhao Gao When VM migrate VMState of virtio-net-device/rss, the field(rss_data. indirections_table) of virtio-net-device/rss having a flag of VMS_ALLOC needs to allocate memory. If the dst doesn't free memory which has bee n allocated for SaveStateEntry of virtio-net-device/rss before dst

[PATCH 0/8] Fix memory leak of some device state in migration

2020-12-26 Thread g00517791
From: Jinhao Gao For some device state having some fields of VMS_ALLOC flag, they don't free memory allocated for the fields in vmstate_save_state and vmstate _load_state. We add funcs or sentences of free memory before allocation of memory or after load of memory to avoid memory leak. Jinhao

Re: Deprecation of the LM32 target

2020-12-26 Thread Michael Walle
Hi, Am 2020-12-26 10:06, schrieb John Paul Adrian Glaubitz: Hello! On 12/26/20 9:39 AM, Thomas Huth wrote: the problem is not that the target CPU is old, but rather that according to the (former?) maintainer, there are no users left: https://www.mail-archive.com/qemu-devel@nongnu.org/msg605

Re: Deprecation of the LM32 target

2020-12-26 Thread John Paul Adrian Glaubitz
Hello! On 12/26/20 9:39 AM, Thomas Huth wrote: > the problem is not that the target CPU is old, but rather that according to > the (former?) maintainer, there are no users left: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg605024.html > > So it got marked as deprecated in this com

Re: Deprecation of the LM32 target

2020-12-26 Thread Thomas Huth
On 24/12/2020 10.53, John Paul Adrian Glaubitz wrote: Hello! I was just browsing through the QEMU Christmas Calendar [1] and noticed the announcement for the deprecation of the LM32 target. I'm not sure what the motivation of the deprecation is, but isn't one of the big selling points of QEMU t