[RFC PATCH 3/3] mm: support free hugepage pre zero out

2020-12-21 Thread Liang Li
This patch add support of pre zero out free hugepage, we can use this feature to speed up page population and page fault handing. Cc: Alexander Duyck Cc: Mel Gorman Cc: Andrea Arcangeli Cc: Dan Williams Cc: Dave Hansen Cc: David Hildenbrand Cc: Michal Hocko Cc: Andrew Morton Cc: Alex Wi

[RFC PATCH 2/3] virtio-balloon: add support for providing free huge page reports to host

2020-12-21 Thread Liang Li
Free page reporting only supports buddy pages, it can't report the free pages reserved for hugetlbfs case. On the other hand, hugetlbfs is a good choice for a system with a huge amount of RAM, because it can help to reduce the memory management overhead and improve system performance. This patch a

[RFC PATCH 1/3] mm: support hugetlb free page reporting

2020-12-21 Thread Liang Li
Free page reporting only supports buddy pages, it can't report the free pages reserved for hugetlbfs case. On the other hand, hugetlbfs is a good choice for a system with a huge amount of RAM, because it can help to reduce the memory management overhead and improve system performance. This patch ad

[RFC PATCH 0/3] add support for free hugepage reporting

2020-12-21 Thread Liang Li
A typical usage of hugetlbfs it's to reserve amount of memory when the during kernel booting stage, and the reserved pages are unlikely to return to the buddy system. When application need hugepages, kernel will allocate them from the reserved pool. when application terminates, huge pages will retu

[PATCH v4 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-21 Thread Bin Meng
From: Xuzhou Cheng Auto Address Increment (AAI) Word-Program is a special command of SST flashes. AAI-WP allows multiple bytes of data to be programmed without re-issuing the next sequential address location. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- Changes in v4: - simplify i

[PATCH v4 1/2] hw/block: m25p80: Don't write to flash if write is disabled

2020-12-21 Thread Bin Meng
From: Bin Meng When write is disabled, the write to flash should be avoided in flash_write8(). Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device") Signed-off-by: Bin Meng --- (no changes since v2) Changes in v2: - new patch: honor write enable flag in flash write hw/

Re: [PATCH v3 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-21 Thread Bin Meng
Hi Francisco, On Mon, Dec 21, 2020 at 11:52 PM Francisco Iglesias wrote: > > Hi Bin, > > On [2020 Dec 11] Fri 14:37:20, Bin Meng wrote: > > From: Xuzhou Cheng > > > > Auto Address Increment (AAI) Word-Program is a special command of > > SST flashes. AAI-WP allows multiple bytes of data to be pro

Re: [PATCH 1/2] hw/ssi: imx_spi: Correct the burst length > 32 bit transfer logic

2020-12-21 Thread Bin Meng
On Thu, Dec 17, 2020 at 1:28 PM Bin Meng wrote: > > From: Bin Meng > > For the ECSPIx_CONREG register BURST_LENGTH field, the manual says: > > 0x020 A SPI burst contains the 1 LSB in first word and all 32 bits in second > word. > 0x021 A SPI burst contains the 2 LSB in first word and all 32 bits

Re: [PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2020-12-21 Thread Bin Meng
On Wed, Dec 16, 2020 at 6:24 PM Bin Meng wrote: > > Hi Alistair, Peter, > > On Wed, Dec 2, 2020 at 10:45 PM Bin Meng wrote: > > > > From: Bin Meng > > > > Avoid using a magic number (4) everywhere for the number of chip > > selects supported. > > > > Signed-off-by: Bin Meng > > Reviewed-by: Ali

Re: [PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

2020-12-21 Thread Bin Meng
Hi Atish, On Sat, Dec 19, 2020 at 3:46 AM Atish Patra wrote: > > On Fri, 2020-12-18 at 16:42 +0800, Bin Meng wrote: > > Hi Atish, > > > > On Fri, Dec 18, 2020 at 4:00 PM Atish Patra > > wrote: > > > > > > On Fri, 2020-12-18 at 15:33 +0800, Bin Meng wrote: > > > > Hi Atish, > > > > > > > > On Fri

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-21 Thread Bin Meng
Hi Francisco, On Wed, Dec 16, 2020 at 6:11 PM Bin Meng wrote: > > Hi Francisco, > > On Wed, Dec 16, 2020 at 12:40 AM Francisco Iglesias > wrote: > > > > Hello Bin, > > > > On [2020 Dec 12] Sat 17:44:27, Bin Meng wrote: > > > Hi Francisco, > > > > > > On Sat, Dec 12, 2020 at 5:24 PM Francisco Igl

Re: [PATCH v2 7/8] hw/mips/fuloong2e: Add highmem support

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Tue, Dec 22, 2020 at 4:35 AM Philippe Mathieu-Daudé wrote: > > On 12/19/20 8:23 AM, Jiaxun Yang wrote: > > highmem started from 0x2000. > > "started from" -> "starts at"? > > > Now we can have up to 2G RAM. > > > > Signed-off-by: Jiaxun Yang > > --- > > v2: Handl

[Bug 1885350] Re: RISCV dynamic rounding mode is not behaving correctly

2020-12-21 Thread Alistair Francis
** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1885350 Title: RISCV dynamic rounding mode is not behaving correctly Status in QEMU: Incomplete

Re: [PATCH] tests/acceptance: Test PMON with Loongson-3A1000 CPU

2020-12-21 Thread Jiaxun Yang
在 2020/12/21 下午11:34, Philippe Mathieu-Daudé 写道: On 12/21/20 1:51 PM, Huacai Chen wrote: Hi, Philippe, On Sat, Dec 19, 2020 at 4:51 AM Willian Rampazzo wrote: On 12/16/20 3:17 PM, Philippe Mathieu-Daudé wrote: Test the PMON firmware. As the firmware is not redistributable, it has to be downl

do_fallocate with (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE) is not necessary when allocate a new qcow2 cluster

2020-12-21 Thread ChangLimin
From commit https://git.qemu.org/?p=qemu.git;a=commit;h=c8bb23cbdbe32f5c326365e0a82e1b0e68cdcd8a for qcow2 file in ocfs2 filesystem, do_fallocate with (FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE) will be called when allocate a new cluster. It's not necessary and also cause data error. 1. cr

Re: [PATCH v2 4/8] hw/pci-host/bonito: Fixup pci.lomem mapping

2020-12-21 Thread Jiaxun Yang
在 2020/12/22 上午4:45, Philippe Mathieu-Daudé 写道: On 12/19/20 8:18 AM, Jiaxun Yang wrote: The original mapping had wrong base address. Fix by correct the base adress and merge three alias into a single. Why merge? Beside, typo "address". Hi Philippe, Thanks for your reviewing! Because I can'

Re: [PATCH v2 2/8] hw/mips/fuloong2e: Relpace fault links

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sun, Dec 20, 2020 at 1:52 AM Philippe Mathieu-Daudé wrote: > > On 12/19/20 8:12 AM, Jiaxun Yang wrote: > > Websites are downing, but GitHub may last forever. > > Loongson even doesn't recogonize 2E as their products nowadays.. > > > > Signed-off-by: Jiaxun Yang > > -

Re: [PATCH v2 6/8] hw/mips/fuloong2e: Correct cpuclock env

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sun, Dec 20, 2020 at 2:23 AM Philippe Mathieu-Daudé wrote: > > On 12/19/20 8:21 AM, Jiaxun Yang wrote: > > It was missed in 3ca7639ff00 ("hw/mips/fuloong2e: > > Set CPU frequency to 533 MHz"), we need to tell kernel > > correct clocks. > > > > Fixes: 3ca7639ff00 ("hw/

Re: [PATCH v2 5/8] hw/mips/fuloong2e: Remove unused env entry

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sat, Dec 19, 2020 at 3:22 PM Jiaxun Yang wrote: > > modetty and busclock is not handled by kernel and the parameter > here seems unreasonable. > > Signed-off-by: Jiaxun Yang > --- > hw/mips/fuloong2e.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/mip

Re: [PATCH v2 1/8] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Sat, Dec 19, 2020 at 3:13 PM Jiaxun Yang wrote: > > Seems useless > > Fixes: 051c190bce5 ("MIPS: Initial support of fulong mini pc (machine > construction)") > Signed-off-by: Jiaxun Yang > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/mips/fuloong2e.c | 2 --

Re: [PATCH v2 8/8] tests/acceptance: Test boot_linux_console for fuloong2e

2020-12-21 Thread Huacai Chen
Reviewed-by: Huacai Chen On Tue, Dec 22, 2020 at 5:35 AM Willian Rampazzo wrote: > > On Sat, Dec 19, 2020 at 4:30 AM Jiaxun Yang wrote: > > > > The kernel comes from debian archive so it's trusted. > > > > Signed-off-by: Jiaxun Yang > > --- > > tests/acceptance/boot_linux_console.py | 21

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Peter Collingbourne
Thanks for the patch. I've verified that it fixes the assertion failure with both TCF0=1 and TCF0=2. You can disregard the kernel panic from comment #1 since it turns out that it was from an older build of QEMU that did not have 50244cc76abc. -- You received this bug notification because you are

[Bug 1906193] Re: riscv32 user mode emulation: fork return values broken

2020-12-21 Thread Richard Henderson
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1906193 Title: riscv32 user mode emulation: fork return values broken Status in QEMU: Confirmed

Re: [Bug 1906193] Re: riscv32 user mode emulation: fork return values broken

2020-12-21 Thread Alistair Francis
Great! Thanks for testing that. Do you mind supplying a Tested-by tag that I can apply to the patch? Alistair On Mon, Dec 21, 2020 at 5:36 AM Andreas K. Hüttel <1906...@bugs.launchpad.net> wrote: > > After applying this patch on top of qemu-5.2.0, I can confirm that it > fixes the problem. > > T

Re: [RFC PATCH v2] x86/cpu: initialize the CPU concurrently

2020-12-21 Thread Eduardo Habkost
On Mon, Dec 21, 2020 at 07:36:18PM +0800, Zhenyu Ye wrote: > Providing a optional mechanism to wait for all VCPU threads be > created out of qemu_init_vcpu(), then we can initialize the cpu > concurrently on the x86 architecture. > > This reduces the time of creating virtual machines. For example,

Re: [PATCH v2 8/8] tests/acceptance: Test boot_linux_console for fuloong2e

2020-12-21 Thread Willian Rampazzo
On Sat, Dec 19, 2020 at 4:30 AM Jiaxun Yang wrote: > > The kernel comes from debian archive so it's trusted. > > Signed-off-by: Jiaxun Yang > --- > tests/acceptance/boot_linux_console.py | 21 + > 1 file changed, 21 insertions(+) > Reviewed-by: Willian Rampazzo

Re: [PATCH v2 8/8] tests/acceptance: Test boot_linux_console for fuloong2e

2020-12-21 Thread Wainer dos Santos Moschetta
Hi, On 12/19/20 4:23 AM, Jiaxun Yang wrote: The kernel comes from debian archive so it's trusted. Signed-off-by: Jiaxun Yang --- tests/acceptance/boot_linux_console.py | 21 + 1 file changed, 21 insertions(+) Phillipe has already tested it, so I only reviewed the code.

Re: [PATCH 4/4] fuzz: delay IO until they can't trigger the crash

2020-12-21 Thread Alexander Bulekov
On 201220 0256, Qiuhao Li wrote: > Since programmers usually trigger an IO just before they need it. Try to > delay some IO instructions may help us better understanding the timing > context when debug. > > Tested with Bug 1908062. Refined vs. Original result: > > outl 0xcf8 0x881c

Re: [PATCH v4] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-21 Thread Wainer dos Santos Moschetta
On 12/21/20 11:34 AM, Thomas Huth wrote: This initrd contains a virtio-net and a virtio-gpu kernel module, so we can check that we can set a MAC address for the network device and whether we can hot-plug and -unplug a virtio-crypto device. But the most interesting part is maybe that we can also

Re: [PATCH v2 3/8] hw/pci-host/bonito: Fixup IRQ mapping

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/19/20 8:18 AM, Jiaxun Yang wrote: > Accroading to arch/mips/pci/fixup-fuloong2e.c in kernel, > despites south bridge IRQs needs special care, all other > IRQ pins are mapped by 'LOONGSON_IRQ_BASE + 25 + pin'. > > As south bridge IRQs are all handled by ISA bus, we can simply > remove BONITO_

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Peter Collingbourne
Thanks, I will try that patch. Apologies, the instructions assume some familiarity with building Android. You will find instructions for downloading the "repo" tool and the Android source tree here: https://source.android.com/setup/build/downloading This isn't the first time I've received this k

Re: [PATCH 03/18] target/arm: use arm_is_el2_enabled() where applicable

2020-12-21 Thread Richard Henderson
On 12/18/20 2:37 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > Do not assume that EL2 is available in non-secure context. Just noticed this wording is off. Should be "Do not assume that EL2 is unavailable in a secure context" > That equivalence is broken by ARMv8.4

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Richard Henderson
rebuild_hflags_a64 is not consistent with mte_check_fail, which leads to the assert reported. The instructions for building the android kernel are opaque, assuming tools not in evidence. ** Patch added: "proposed patch" https://bugs.launchpad.net/qemu/+bug/1907137/+attachment/5445650/+files/z

Re: [PATCH v2 4/8] hw/pci-host/bonito: Fixup pci.lomem mapping

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/19/20 8:18 AM, Jiaxun Yang wrote: > The original mapping had wrong base address. > Fix by correct the base adress and merge three alias into > a single. Why merge? Beside, typo "address". > > Signed-off-by: Jiaxun Yang > --- > hw/pci-host/bonito.c | 17 ++--- > 1 file changed

Re: [PATCH 6/6] spapr: Model DR connectors as simple objects

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:34 AM, Greg Kurz wrote: Modeling DR connectors as individual devices raises some concerns, as already discussed a year ago in this thread: https://patchew.org/QEMU/20191017205953.13122-1-chel...@linux.vnet.ibm.com/ First, high maxmem settings creates too many DRC devices. This

[PATCH] target/arm: Fix MTE0_ACTIVE

2020-12-21 Thread Richard Henderson
In 50244cc76abc we updated mte_check_fail to match the ARM pseudocode, using the correct EL to select the TCF field. But we failed to update MTE0_ACTIVE the same way, which led to g_assert_not_reached(). Cc: qemu-sta...@nongnu.org Buglink: https://bugs.launchpad.net/bugs/1907137 Signed-off-by: Ric

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-21 Thread David Hildenbrand
> Am 21.12.2020 um 20:47 schrieb Eduardo Habkost : > > +s390 maintainers, a question about feature groups below: > >> On Mon, Dec 21, 2020 at 02:24:18PM +0100, Igor Mammedov wrote: >> On Fri, 18 Dec 2020 13:07:21 -0500 >> Eduardo Habkost wrote: >> >>> On Fri, Dec 18, 2020 at 06:13:40PM +0100

Re: [PATCH 5/6] spapr: Add drc_ prefix to the DRC realize and unrealize functions

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: Use a less generic name for an easier experience with tools such as cscope or grep. Signed-off-by: Greg Kurz --- Reviewed-by: Daniel Henrique Barboza hw/ppc/spapr_drc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH 3/4] fuzz: setting bits in operand of out/write to zero

2020-12-21 Thread Alexander Bulekov
On 201220 0256, Qiuhao Li wrote: > Simplifying the crash cases by opportunistically setting bits in > operands of > out/write to zero may help to debug, since usually bit one means turn on > or > trigger a function while zero is the default turn-off setting. > > Tested Bug 1908062. Refined vs. Ori

Re: [PATCH 4/6] spapr: Use spapr_drc_reset_all() at machine reset

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: Documentation of object_child_foreach_recursive() clearly stipulates that "it is forbidden to add or remove children from @obj from the @fn callback". But this is exactly what we do during machine reset. The call to spapr_drc_reset() can finalize the hot-u

Re: [PATCH 3/6] spapr: Introduce spapr_drc_reset_all()

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: No need to expose the way DRCs are traversed outside of spapr_drc.c. Signed-off-by: Greg Kurz --- Reviewed-by: Daniel Henrique Barboza include/hw/ppc/spapr_drc.h | 6 ++ hw/ppc/spapr_drc.c | 31 + hw/ppc/

Re: [PATCH v2 7/8] hw/mips/fuloong2e: Add highmem support

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/19/20 8:23 AM, Jiaxun Yang wrote: > highmem started from 0x2000. "started from" -> "starts at"? > Now we can have up to 2G RAM. > > Signed-off-by: Jiaxun Yang > --- > v2: Handle SPD for dual DIMM correctly. > --- > hw/mips/fuloong2e.c | 61

Re: [PATCH 2/6] spapr: Fix reset of transient DR connectors

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: Documentation of object_property_iter_init() clearly stipulates that "it is forbidden to modify the property list while iterating". But this is exactly what we do when resetting transient DR connectors during CAS. The call to spapr_drc_reset() can finalize

Re: [PATCH 3/5] net/tap: tap_set_sndbuf(): return status

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/21/20 8:06 PM, Vladimir Sementsov-Ogievskiy wrote: > It's recommended to return a value indicating success / failure for > functions with errp parameter (see include/qapi/error.h). Let's update > tap_set_sndbuf(). For simple "success/failure" a bool type is enough. Preferably using bool typ

Re: [PATCH 2/4] fuzz: split QTest writes from the rightmost byte

2020-12-21 Thread Alexander Bulekov
Qiuhao Li writes: > Currently, we split the write commands' data from the middle. If it does not > work, try to move the pivot "left" and retry until there is no space left. > But, this is complete for ram writes but not for IO writes. > > For example, there is an IO write command: > > write ad

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Richard Henderson
Ok, I'll have a deeper look as well. ** Changed in: qemu Status: Incomplete => In Progress ** Changed in: qemu Assignee: (unassigned) => Richard Henderson (rth) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bug

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

2020-12-21 Thread Eduardo Habkost
+s390 maintainers, a question about feature groups below: On Mon, Dec 21, 2020 at 02:24:18PM +0100, Igor Mammedov wrote: > On Fri, 18 Dec 2020 13:07:21 -0500 > Eduardo Habkost wrote: > > > On Fri, Dec 18, 2020 at 06:13:40PM +0100, Igor Mammedov wrote: > > > On Wed, 16 Dec 2020 15:52:02 -0500 > >

[PATCH 0/5] net/tap: some fixes and refactorings

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
Hi all. I have a work in progress around net/tap (and not sure, will it be done or we go another way), but some fixes and good refactoring I'd like to post anyway: Vladimir Sementsov-Ogievskiy (5): net/tap: fix net_init_tap(): set ret on failure path net/tap: drop duplicated tap stubs net/ta

Re: QOM address space handling

2020-12-21 Thread Eduardo Habkost
On Mon, Dec 21, 2020 at 08:16:00PM +0100, Paolo Bonzini wrote: > On 21/12/20 19:54, Eduardo Habkost wrote: > > On Sun, Dec 20, 2020 at 10:25:25AM +0100, Paolo Bonzini wrote: > > > On 18/12/20 23:32, Eduardo Habkost wrote: > > > > Who owns the FlatView reference, exactly? > > > > > > The AddressSpa

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Peter Collingbourne
This isn't a fork of qemu, it was an upstream checkout based on commit 944fdc5e27a5b5adbb765891e8e70e88ba9a00ec (well, okay, I did have the ARM HVF series applied to this checkout, but I wouldn't expect that to affect TCG). I verified that 50244cc76abc is present in my checkout. Let me see if I ca

Re: QOM address space handling

2020-12-21 Thread Paolo Bonzini
On 21/12/20 19:54, Eduardo Habkost wrote: On Sun, Dec 20, 2020 at 10:25:25AM +0100, Paolo Bonzini wrote: On 18/12/20 23:32, Eduardo Habkost wrote: Who owns the FlatView reference, exactly? The AddressSpace. The device creates the AddressSpace, which holds a reference to the MemoryRegion thro

[PATCH 3/5] net/tap: tap_set_sndbuf(): return status

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
It's recommended to return a value indicating success / failure for functions with errp parameter (see include/qapi/error.h). Let's update tap_set_sndbuf(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap_int.h | 2 +- net/tap-linux.c | 5 - net/tap-stub.c | 2 +- net/tap.c

[PATCH 5/5] net/tap: net_init_tap_one(): fix net-client leak on failure path

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
net_tap_fd_init() allocates new NetClientState through qemu_new_net_client(). We should free it on failure path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Attention: it's an intuitive patch. I see, that net-client is leaked. May be it's still freed some tricky way? And I don't understand

[PATCH 4/5] net/tap: refactor and improve net_init_tap_one()

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
First, 46d4d36d0bf2b24 changed the logic of net_init_tap_one() so that failure of vhost initialization is ignored (still, warning printed) when vhostforce is not set. Then 894022e616016fe8 updated net_init_tap_one() to use qemu_try_set_nonblock() instead of qemu_set_nonblock(), to not crash, but i

[PATCH 1/5] net/tap: fix net_init_tap(): set ret on failure path

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
We should set ret to -1 on this failure path. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tap.c b/net/tap.c index b7512853f4..75b01d54ee 100644 --- a/net/tap.c +++ b/net/tap.c @@ -880,6 +880,7 @@ int net_init_tap(const Netdev

[PATCH 2/5] net/tap: drop duplicated tap stubs

2020-12-21 Thread Vladimir Sementsov-Ogievskiy
tap-solaris and tap-bsd realize only tap_open() interface and all other functions are duplicated with tap-stub. Let's split tap-stub so that we can reuse all stubs except for tap_open() for solaris and bsd. Signed-off-by: Vladimir Sementsov-Ogievskiy --- net/tap-bsd.c | 53

[Bug 1907137] Re: LDTR not properly emulated when MTE tag checks enabled at EL0

2020-12-21 Thread Richard Henderson
>From the hash id in your patch, it would appear that you are using a fork of qemu. This should be fixed by 50244cc76abc present in the qemu 5.2 release. ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: QOM address space handling

2020-12-21 Thread Eduardo Habkost
On Sun, Dec 20, 2020 at 10:25:25AM +0100, Paolo Bonzini wrote: > On 18/12/20 23:32, Eduardo Habkost wrote: > > Who owns the FlatView reference, exactly? > > The AddressSpace. The device creates the AddressSpace, which holds a > reference to the MemoryRegion through FlatView and AddressSpaceDispat

Re: [PATCH 1/4] fuzz: refine crash detection mechanism

2020-12-21 Thread Alexander Bulekov

Re: [PATCH v3] fuzz: map all BARs and enable PCI devices

2020-12-21 Thread Paolo Bonzini
On 21/12/20 19:12, Alexander Bulekov wrote: Prior to this patch, the fuzzer found inputs to map PCI device BARs and enable the device. While it is nice that the fuzzer can do this, it added significant overhead, since the fuzzer needs to map all the BARs (regenerating the memory topology), at the

[PATCH v3] fuzz: map all BARs and enable PCI devices

2020-12-21 Thread Alexander Bulekov
Prior to this patch, the fuzzer found inputs to map PCI device BARs and enable the device. While it is nice that the fuzzer can do this, it added significant overhead, since the fuzzer needs to map all the BARs (regenerating the memory topology), at the start of each input. With this patch, we do t

Re: [PATCH 1/6] spapr: Call spapr_drc_reset() for all DRCs at CAS

2020-12-21 Thread Daniel Henrique Barboza
On 12/18/20 7:33 AM, Greg Kurz wrote: Non-transient DRCs are either in the empty or the ready state, which means spapr_drc_reset() doesn't change their state. It is thus not needed to do any checking. Call spapr_drc_reset() unconditionally and squash spapr_drc_transient() into its only user, s

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-12-21 Thread none none
When setting "-display gtk,gl=off" things work for GTK and SDL. ## startup command ## qemu-system-x86_64 \ -serial stdio \ -m 8G \ -enable-kvm \ -vga none -device virtio-vga,virgl=on \ -display sdl,gl=off \ -machine q35 \ -cpu host \ -bios /usr/share/OVMF/x64/OVMF_CODE.fd \ -boot order=d \ -drive

Re: [PATCH v2 4/4] block: Close block exports in two steps

2020-12-21 Thread Sergio Lopez
On Tue, Dec 15, 2020 at 04:34:05PM +0100, Kevin Wolf wrote: > Am 14.12.2020 um 18:05 hat Sergio Lopez geschrieben: > > There's a cross-dependency between closing the block exports and > > draining the block layer. The latter needs that we close all export's > > client connections to ensure they won

[Bug 1898490] Re: gtk with virtio and opengl black screen

2020-12-21 Thread none none
I am having the same issue. Tested on Xubuntu 20.10 (qemu 5.0) and ArchLinux (qemu 5.2). Furthermore, SDL is broken too: In principle I get some output with SDL but its broken and not very usable. After some time (after starting the Desktop Env. - as far as I can tell), the screen also turns black

Re: [PATCH v4] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-21 Thread Willian Rampazzo
On Mon, Dec 21, 2020 at 11:34 AM Thomas Huth wrote: > > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and whether we can hot-plug and -unplug a virtio-crypto device. > But the most interesting part is mayb

Re: pxa crashes with qemu v5.2 when executing xscale operations

2020-12-21 Thread Guenter Roeck
Hi Philippe, On 12/21/20 7:24 AM, Philippe Mathieu-Daudé wrote: [ ... ]) > >> Does this mean that there is a bug, that the affected emulations are no >> longer >> supported, that I now have to specify some new option on the qemu command >> line, >> or something else ? > > The command line is l

Re: [PATCH v4] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-21 Thread Cornelia Huck
On Mon, 21 Dec 2020 15:34:23 +0100 Thomas Huth wrote: > This initrd contains a virtio-net and a virtio-gpu kernel module, > so we can check that we can set a MAC address for the network device > and whether we can hot-plug and -unplug a virtio-crypto device. > But the most interesting part is may

Re: Dropped/disabled NVME support in qemu

2020-12-21 Thread Guenter Roeck
Hi Klaus, On 12/21/20 7:17 AM, Klaus Jensen wrote: > On Dec 21 15:11, Philippe Mathieu-Daudé wrote: >> Cc'ing NVMe emulation maintainers. >> >> On 12/21/20 6:12 AM, Guenter Roeck wrote: >>> Hi all, >>> >>> since qemu v5.1, nvme support has been dropped from several architectures. >>> Well, it was

Re: [PATCH v3 2/2] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-21 Thread Francisco Iglesias
Hi Bin, On [2020 Dec 11] Fri 14:37:20, Bin Meng wrote: > From: Xuzhou Cheng > > Auto Address Increment (AAI) Word-Program is a special command of > SST flashes. AAI-WP allows multiple bytes of data to be programmed > without re-issuing the next sequential address location. > > Signed-off-by: Xu

Re: [PATCH v10 0/5] UFFD write-tracking migration/snapshots

2020-12-21 Thread Andrey Gruzdev
On 21.12.2020 18:17, Peter Xu wrote: On Mon, Dec 21, 2020 at 03:44:38PM +0300, Andrey Gruzdev wrote: Hi Peter, I have a question about the Wiki page you've created https://wiki.qemu.org/ToDo/LiveMigration#Features. May we also add to that page/have access rights? Yes. I'll send you another e

Re: [PATCH] Docs/RCU: Correct sample code of qatomic_rcu_set

2020-12-21 Thread Peter Xu
On Mon, Dec 21, 2020 at 08:17:45PM +0800, Keqian Zhu wrote: > Correct sample code to avoid confusing readers. > > Signed-off-by: Keqian Zhu Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v2] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

2020-12-21 Thread Willian Rampazzo
On Mon, Dec 21, 2020 at 10:00 AM Cornelia Huck wrote: > > On Fri, 18 Dec 2020 15:23:32 -0300 > Willian Rampazzo wrote: > > > On 12/17/20 5:53 AM, Thomas Huth wrote: > > > > +# Hot-plug a virtio-crypto device and see whether it gets > > > accepted > > > +self.clear_guest_dmesg() >

[PULL 53/55] meson.build: convert --with-default-devices to meson

2020-12-21 Thread Paolo Bonzini
Pass the boolean option directly instead of writing CONFIG_MINIKCONF_MODE to config-host.mak. Signed-off-by: Paolo Bonzini --- configure | 13 - meson.build | 5 +++-- meson_options.txt | 2 ++ 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/configure

[PULL 48/55] zstd: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 30 -- meson.build | 10 ++ meson_options.txt | 2 ++ migration/meson.build | 2 +- 4 files changed, 13 insertions(+), 31 deletions(-) diff --git a/configure b/configure index 6224279e44.

Re: [PATCH] tests/acceptance: Test PMON with Loongson-3A1000 CPU

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/21/20 1:51 PM, Huacai Chen wrote: > Hi, Philippe, > > On Sat, Dec 19, 2020 at 4:51 AM Willian Rampazzo wrote: >> >> On 12/16/20 3:17 PM, Philippe Mathieu-Daudé wrote: >>> Test the PMON firmware. As the firmware is not redistributable, >>> it has to be downloaded manually first. Then it can

[PULL 47/55] lzfse: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- meson.build | 19 +++ meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 31 deletions(-) diff --git a/configure b/configure index 9166347739..6224279e44 100755 --- a/configur

Re: pxa crashes with qemu v5.2 when executing xscale operations

2020-12-21 Thread Philippe Mathieu-Daudé
On 12/21/20 6:28 AM, Guenter Roeck wrote: > Hi, > > I noticed that booting Linux on PXA emulations no longer works with qemu v5.2. > When trying to boot akita, borzoi, or similar emulations, I get the following > crash. > > [0.965279] Internal error: Oops - undefined instruction: 0 [#1] PREE

[PULL 42/55] libnfs: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 27 --- meson.build | 9 ++--- meson_options.txt | 2 ++ 3 files changed, 12 insertions(+), 26 deletions(-) diff --git a/configure b/configure index 30084af631..9b38368427 100755 --- a/configure +++ b/config

[PULL 26/55] meson: update submodule to 0.56.0

2020-12-21 Thread Paolo Bonzini
Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 2 +- meson | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f470cdbe50..0a6de3b8ef 100755 --- a/configure +++ b/configure @@ -1936,7 +1936,7 @@ python_version=$($pyt

Re: [PATCH v10 0/5] UFFD write-tracking migration/snapshots

2020-12-21 Thread Andrey Gruzdev
On 17.12.2020 19:57, Andrey Gruzdev wrote: Ping This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Currently the only way to make (external) live VM snapshot is using existing dirty page log

[PULL 28/55] meson: fix detection of curses with pkgconfig

2020-12-21 Thread Paolo Bonzini
Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 34ecb93b03..d5d08c8b6b 100644 --- a/meson.build +++ b/meson.build @@ -500,16 +500,16 @@ if have_system and not get

Re: [PATCH v10 0/5] UFFD write-tracking migration/snapshots

2020-12-21 Thread Peter Xu
On Mon, Dec 21, 2020 at 03:44:38PM +0300, Andrey Gruzdev wrote: > Hi Peter, > > I have a question about the Wiki page you've created > https://wiki.qemu.org/ToDo/LiveMigration#Features. > May we also add to that page/have access rights? Yes. I'll send you another email soon for that. Thanks,

[PULL 39/55] glusterfs: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 102 ++ meson.build | 48 -- meson_options.txt | 2 + 3 files changed, 50 insertions(+), 102 deletions(-) diff --git a/configure b/configure index bb6b8eefdb..b7644cfbd9

[PULL 49/55] seccomp: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 32 meson.build| 10 ++ meson_options.txt | 2 ++ softmmu/meson.build| 2 +- softmmu/qemu-seccomp.c | 2 -- tools/meson.build | 4 ++-- 6 files changed, 15 insertions(+

[PULL 40/55] bzip2: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 31 --- meson.build | 18 +++--- meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 30 deletions(-) diff --git a/configure b/configure index b7644cfbd9..3d65c1e196 100755 --- a/configure

[PULL 43/55] libssh: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 45 - meson.build | 22 ++ meson_options.txt | 2 ++ 3 files changed, 24 insertions(+), 45 deletions(-) diff --git a/configure b/configure index 9b38368427..0350b59624 1007

[PULL 55/55] win32: drop fd registration to the main-loop on setting non-block

2020-12-21 Thread Paolo Bonzini
From: Marc-André Lureau Low-level fd users from QEMU use aio_set_fd_handler(), which handles event registration with the main loop; qemu_fd_register() is only needed together with the main loop's poll notifiers, of which SLIRP is the only user. This removes a dependency from oslib-win32.c to mai

Re: Dropped/disabled NVME support in qemu

2020-12-21 Thread Klaus Jensen
On Dec 21 15:11, Philippe Mathieu-Daudé wrote: > Cc'ing NVMe emulation maintainers. > > On 12/21/20 6:12 AM, Guenter Roeck wrote: > > Hi all, > > > > since qemu v5.1, nvme support has been dropped from several architectures. > > Well, it was not exactly dropped, but disabled. > > > > On those ar

[PULL 52/55] libattr: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 45 - meson.build | 38 +++--- meson_options.txt | 2 ++ 3 files changed, 41 insertions(+), 44 deletions(-) diff --git a/configure b/configure index 569396248b.

[PULL 34/55] configure: accept --enable-slirp

2020-12-21 Thread Paolo Bonzini
Meson understands -Dslirp=enabled, so there is no reason not to accept the configure option as well. Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index d5d630c0ee..

[PULL 36/55] brlapi: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- chardev/meson.build | 2 +- configure | 32 meson.build | 20 +--- meson_options.txt | 2 ++ 4 files changed, 24 insertions(+), 32 deletions(-) diff --git a/chardev/meson.build b/chardev/meson

[PULL 27/55] meson: switch minimum meson version to 0.56.0

2020-12-21 Thread Paolo Bonzini
Meson 0.56.0 does not need b_staticpic=$pie anymore, and has stabilized the keyval module. Remove the workaround and use a few replacements for features deprecated in that release cycle. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 5 do

[PULL 37/55] curl: remove compatibility code, require 7.29.0

2020-12-21 Thread Paolo Bonzini
cURL 7.16.0 was released in October 2006. Just remove code that is in all likelihood not being used anywhere, and require the oldest version found in currently supported distros, which is 7.29.0 from CentOS 7. pkg-config is enough for QEMU, since it does not need extra information such as the pat

[PULL 51/55] cap_ng: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 34 -- meson.build | 24 meson_options.txt | 2 ++ tools/meson.build | 4 ++-- 4 files changed, 28 insertions(+), 36 deletions(-) diff --git a/configure b/configure index 46ee3da

[PULL 32/55] configure: remove useless code to check for Xen PCI passthrough

2020-12-21 Thread Paolo Bonzini
meson.build is already doing the same check, so remove it from configure. Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 12 1 file changed, 12 deletions(-) diff --git a/configure b/configure index ce4f365231..ca8496b607 100755 --- a/configure +++ b/co

[PULL 25/55] Makefile: add dummy target for build.ninja dependencies

2020-12-21 Thread Paolo Bonzini
The dummy targets ensure that incremental build can be done after deleting a meson.build file. Signed-off-by: Paolo Bonzini --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 76dbb917f5..fb9923ff22 100644 --- a/Makefile +++ b/Makefile @@ -133,6 +133,7 @@ M

[PULL 50/55] virtfs: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 29 - meson.build | 24 ++-- meson_options.txt | 11 +++ 3 files changed, 33 insertions(+), 31 deletions(-) diff --git a/configure b/configure index ba8c6e74be..46ee3da40e 100755 --

[PULL 54/55] configure: move tests/qemu-iotests/common.env generation to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure| 7 --- tests/qemu-iotests/common.env.in | 3 +++ tests/qemu-iotests/meson.build | 3 +++ 3 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 tests/qemu-iotests/common.env.in diff --git a/configure b/config

[PULL 46/55] snappy: convert to meson

2020-12-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 32 meson.build | 19 +++ meson_options.txt | 2 ++ 3 files changed, 21 insertions(+), 32 deletions(-) diff --git a/configure b/configure index 1574ea8456..9166347739 100755 --- a/configu

  1   2   3   >