Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-18 Thread Thomas Huth
On 18/11/2020 13.13, Philippe Mathieu-Daudé wrote: > On 11/18/20 12:56 PM, Chen Qun wrote: >> According to the glib function requirements, we need initialise >> the variable. Otherwise there will be compilation warnings: >> >> glib-autocleanups.h:28:3: warning: ‘full_name’ may be >> used uninitial

Re: [PATCH] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2020-11-18 Thread AL Yu-Chen Cho
On Tue, 2020-11-17 at 12:51 +0100, Thomas Huth wrote: > On 17/11/2020 07.57, Cho, Yu-Chen wrote: > > Add build-system-opensuse jobs and add opensuse-leap.docker > > dockerfile. > > Use openSUSE Leap 15.2 container image in the gitlab-CI. > > > > Signed-off-by: Cho, Yu-Chen > > --- > > .gitlab-ci

Re: [PATCH v2 0/7] UFFD write-tracking migration/snapshots

2020-11-18 Thread Andrey Gruzdev
On 18.11.2020 17:54, Eric Blake wrote: On 11/18/20 7:20 AM, Andrey Gruzdev wrote: Currently the only way to make (external) live VM snapshot is using existing dirty page logging migration mechanism. The main problem is that it tends to produce a lot of page duplicates while running VM goes on up

Re: [PATCH 1/7] Introduce 'track-writes-ram' migration capability.

2020-11-18 Thread Andrey Gruzdev
On 18.11.2020 17:31, Eric Blake wrote: On 11/18/20 5:22 AM, Andrey Gruzdev wrote: Signed-off-by: Andrey Gruzdev --- migration/migration.c | 96 +++ migration/migration.h | 1 + qapi/migration.json | 7 +++- 3 files changed, 103 insertions(+), 1 d

Re: [PATCH] display/vmware_vga: Fix bad printf format specifiers

2020-11-18 Thread Philippe Mathieu-Daudé
Hi Alex, On 11/19/20 4:01 AM, Alex Chen wrote: > We should use printf format specifier "%u" instead of "%d" for > argument of type "unsigned int". > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > hw/display/vmware_vga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

2020-11-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201119060833.25328-1-...@suse.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201119060833.25328-1-...@suse.com Subject: [PATCH] qga: Correct loop count in qmp_guest_get_vcp

Re: [RFC PATCH 0/5] ARM: reduce the memory consumed when mapping UEFI flash images

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/16/20 2:48 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Hi David, >> >> On 11/16/20 11:42 AM, David Edmondson wrote: >>> Currently ARM UEFI images are typically built as 2MB/768kB flash >>> images for code and variables respectively. These images are both then >>> padd

[PATCH] qga: Correct loop count in qmp_guest_get_vcpus()

2020-11-18 Thread Lin Ma
The guest-get-vcpus returns incorrect vcpu info in case we hotunplug vcpus(not the last one). e.g.: A VM has 4 VCPUs: cpu0 + 3 hotunpluggable online vcpus(cpu1, cpu2 and cpu3). Hotunplug cpu2, Now only cpu0, cpu1 and cpu3 are present & online. ./qmp-shell /tmp/qmp-monitor.sock (QEMU) query-hotplu

Re: [PATCH v2] net/e1000e_core: adjust count if RDH exceeds RDT in e1000e_ring_advance()

2020-11-18 Thread Jason Wang
On 2020/11/18 下午4:53, Mauro Matteo Cascella wrote: On Wed, Nov 18, 2020 at 4:56 AM Jason Wang wrote: On 2020/11/13 下午6:31, Mauro Matteo Cascella wrote: The e1000e_write_packet_to_guest() function iterates over a set of receive descriptors by advancing rx descriptor head register (RDH) from

[PATCH 1/1] vfio: Change default dirty pages tracking behavior during migration

2020-11-18 Thread Kirti Wankhede
By default dirty pages tracking is enabled during iterative phase (pre-copy phase). Added per device opt-out option 'pre-copy-dirty-page-tracking' to disable dirty pages tracking during iterative phase. If the option 'pre-copy-dirty-page-tracking=off' is set for any VFIO device, dirty pages trackin

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-18 Thread Jason Wang
On 2020/11/19 上午4:06, Mike Christie wrote: On 11/18/20 1:54 AM, Jason Wang wrote: On 2020/11/18 下午2:57, Mike Christie wrote: On 11/17/20 11:17 PM, Jason Wang wrote: On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: The following k

[PATCH] display/vmware_vga: Fix bad printf format specifiers

2020-11-18 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c ind

[PATCH] hw/display/qxl: Fix bad printf format specifiers

2020-11-18 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/display/qxl-logger.c | 4 ++-- hw/display/qxl.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/display/qxl-l

[PATCH] hw/usb: Fix bad printf format specifiers

2020-11-18 Thread Alex Chen
We should use printf format specifier "%u" instead of "%d" for argument of type "unsigned int". Reported-by: Euler Robot Signed-off-by: Alex Chen --- hw/usb/ccid-card-passthru.c | 2 +- hw/usb/core.c | 4 ++-- hw/usb/dev-smartcard-reader.c | 8 hw/usb/hcd-ehci.c

Re: [PATCH] hw/arm: Fix bad print format specifiers

2020-11-18 Thread Alex Chen
Kindly ping. On 2020/11/2 17:55, AlexChen wrote: > We should use printf format specifier "%u" instead of "%i" for > argument of type "unsigned int". > > Reported-by: Euler Robot > Signed-off-by: Alex Chen > --- > hw/arm/pxa2xx.c | 2 +- > hw/arm/spitz.c | 2 +- > hw/arm/tosa.c | 2 +- > 3 f

[PATCH v10 7/9] unit-test: The files changed.

2020-11-18 Thread Jiahui Cen
From: Yubo Miao The unit-test is seperated into three patches: 1. The files changed and list in bios-tables-test-allowed-diff.h 2. The unit-test 3. The binary file and clear bios-tables-test-allowed-diff.h The ASL diff would also be listed. Sice there are 1000+lines diff, some changes would be o

[PATCH v10 2/9] fw_cfg: Refactor extra pci roots addition

2020-11-18 Thread Jiahui Cen
Extract extra pci roots addition from pc machine, which could be used by other machines. In order to make uefi get the extra roots, it is necessary to write extra roots into fw_cfg. And only if the uefi knows there are extra roots, the config spaces of devices behind the root could be obtained. S

[PATCH v10 8/9] unit-test: Add testcase for pxb

2020-11-18 Thread Jiahui Cen
From: Yubo Miao Add testcase for pxb to make sure the ACPI table is correct for guest. Signed-off-by: Yubo Miao Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test.c | 58 ++-- 1 file changed, 52 insertions(+), 6 deletions(-) diff --git a/tests/qtest/bios-tables-test.c

[PATCH v10 4/9] acpi: Extract crs build form acpi_build.c

2020-11-18 Thread Jiahui Cen
From: Yubo Miao Extract crs build form acpi_build.c, the function could also be used to build the crs for pxbs for arm. The resources are composed by two parts: 1. The bar space of pci-bridge/pcie-root-ports 2. The resources needed by devices behind PXBs. The base and limit of memory/io are obtai

[PATCH v10 0/9] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-11-18 Thread Jiahui Cen
Changes with v9 v9->v10: Refactor patch2 to drop useless macros and variables. Split patch2 into two patches. Changes with v8 v8->v9: Rebase to master Changes with v7 v7->v8: Fix the error:no member named 'fw_cfg' in 'struct PCMachineState' Changes with v6 v6->v7: Refactor fw_cfg_write_extra_pci

[PATCH v10 9/9] unit-test: Add the binary file and clear diff.h

2020-11-18 Thread Jiahui Cen
From: Yubo Miao Add the binary file DSDT.pxb and clear bios-tables-test-allowed-diff.h Signed-off-by: Yubo Miao Signed-off-by: Jiahui Cen --- tests/data/acpi/virt/DSDT.pxb | Bin 0 -> 7802 bytes tests/qtest/bios-tables-test-allowed-diff.h | 1 - 2 files changed, 1 deletion(-)

[PATCH v10 1/9] acpi/gpex: Extract two APIs from acpi_dsdt_add_pci

2020-11-18 Thread Jiahui Cen
From: Yubo Miao Extract two APIs acpi_dsdt_add_pci_route_table and acpi_dsdt_add_pci_osc from acpi_dsdt_add_pci. The first API is used to specify the pci route table and the second API is used to declare the operation system capabilities. These two APIs would be used to specify the pxb-pcie in DS

[PATCH v10 6/9] acpi: Align the size to 128k

2020-11-18 Thread Jiahui Cen
From: Yubo Miao If table size is changed between virt_acpi_build and virt_acpi_build_update, the table size would not be updated to UEFI, therefore, just align the size to 128kb, which is enough and same with x86. It would warn if 64k is not enough and the align size should be updated. Signed-of

[PATCH v10 5/9] acpi/gpex: Build tables for pxb

2020-11-18 Thread Jiahui Cen
From: Yubo Miao The resources of pxbs are obtained by crs_build and the resources used by pxbs would be moved from the resources defined for host-bridge. The resources for pxb are composed of following two parts: 1. The bar space of the pci-bridge/pcie-root-port behined it 2. The config space of

[PATCH v10 3/9] hw/arm/virt: Write extra pci roots into fw_cfg

2020-11-18 Thread Jiahui Cen
Add bus property to virt machine for primary PCI root bus and use it to add extra pci roots behind it. Signed-off-by: Jiahui Cen Signed-off-by: Yubo Miao --- hw/arm/virt.c | 7 +-- include/hw/arm/virt.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/vir

[PATCH v2] file-posix: Use OFD lock only if the filesystem supports the lock

2020-11-18 Thread Masayoshi Mizuma
From: Masayoshi Mizuma locking=auto doesn't work if the filesystem doesn't support OFD lock. In that situation, following error happens: qemu-system-x86_64: -blockdev driver=qcow2,node-name=disk,file.driver=file,file.filename=/mnt/guest.qcow2,file.locking=auto: Failed to lock byte 100 qemu_

Re: [PATCH RFC v3 23/23] i386: provide simple 'hyperv=on' option to x86 machine types

2020-11-18 Thread Eduardo Habkost
On Fri, Oct 09, 2020 at 02:18:42PM +0200, Vitaly Kuznetsov wrote: > Enabling Hyper-V emulation for a Windows VM is a tiring experience as it > requires listing all currently supported enlightenments ("hv_*" CPU > features) explicitly. We do have a 'hv_passthrough' mode enabling > everything but it

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 08:13:18PM +0100, Paolo Bonzini wrote: > On 18/11/20 18:30, Eduardo Habkost wrote: > > > Adding a layer of indirect calls is not very different from monkey > > > patching > > > though. > > > > I'm a little bothered by monkey patching, but I'm more > > bothered by having to

Re: [PATCH RFC] vfio: Set the priority of VFIO VM state change handler explicitly

2020-11-18 Thread Kirti Wankhede
On 11/17/2020 7:10 AM, Shenming Lu wrote: In VFIO VM state change handler, VFIO devices are transitioned in _SAVING state, which should keep them from sending interrupts. Then we can save the pending states of all interrupts in GIC VM state change handler (on ARM). So we have to set the prior

[PATCH 1/1] Fix to show vfio migration stat in migration status

2020-11-18 Thread Kirti Wankhede
Header file where CONFIG_VFIO is defined is not included in migration.c file. Include config devices header file in migration.c. Fixes: 3710586caa5d ("qapi: Add VFIO devices migration stats in Migration stats") Signed-off-by: Kirti Wankhede --- meson.build | 1 + migration/migration.c

[PATCH v2] Fix build with 64 bits time_t

2020-11-18 Thread Fabrice Fontaine
time element is deprecated on new input_event structure in kernel's input.h [1] This will avoid the following build failure: hw/input/virtio-input-host.c: In function 'virtio_input_host_handle_status': hw/input/virtio-input-host.c:198:28: error: 'struct input_event' has no member named 'time'

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-18 Thread Vivek Goyal
On Thu, Nov 12, 2020 at 10:57:11AM +0100, Miklos Szeredi wrote: [..] > > Another performance issue with virtiofs could be due to the strict > page writeback rules in fuse that are meant to prevent misuse of > kernel memory by unprivileged processes. Since virtiofs isn't > subject to that limitat

Re: [PATCH 00/10] vhost/qemu: thread per IO SCSI vq

2020-11-18 Thread Mike Christie
On 11/18/20 1:54 AM, Jason Wang wrote: On 2020/11/18 下午2:57, Mike Christie wrote: On 11/17/20 11:17 PM, Jason Wang wrote: On 2020/11/18 上午12:40, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 05:18:59PM -0600, Mike Christie wrote: The following kernel patches were made over Michael's vhost b

[PATCH v12 0/4] Introduce Xilinx ZynqMP CAN controller

2020-11-18 Thread Vikram Garhwal
Changelog: v11 -> v12: Change/add new trace events with relevant debug info. Rename val64 to val wherever appropriate. Added new error logs. Corrected xlnx_zynqmp_can_receive function checks. v10 -> v11: Resending the series with correct cc. Replace DB_PRINTS with trace-ev

Re: [Virtio-fs] [PATCH] virtiofsd: Use --thread-pool-size=0 to mean no thread pool

2020-11-18 Thread Vivek Goyal
On Thu, Nov 12, 2020 at 10:06:37AM +0100, Miklos Szeredi wrote: > On Fri, Nov 6, 2020 at 11:35 PM Vivek Goyal wrote: > > > > On Fri, Nov 06, 2020 at 08:33:50PM +, Venegas Munoz, Jose Carlos wrote: > > > Hi Vivek, > > > > > > I have tested with Kata 1.12-apha0, the results seems that are better

Re: Regressions in build process introduced since August

2020-11-18 Thread Stefan Weil
to override the name ? Was this so that you can give distinct names to the Win32 vs Win64 installer exes ? If so, would it be better if QEMU used a distinct filename for the Win32 vs Win64 installers automatically, to avoid need to override at all ? I now use installer names like qemu-w64-setu

[PATCH v12 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-11-18 Thread Vikram Garhwal
The Xilinx ZynqMP CAN controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Example for using single CAN: -object can-bus,id=canbus0 \ -machine xlnx-zcu102.canbus0=canbus0 \

[PATCH v12 3/4] tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller

2020-11-18 Thread Vikram Garhwal
The QTests perform five tests on the Xilinx ZynqMP CAN controller: Tests the CAN controller in loopback, sleep and snoop mode. Tests filtering of incoming CAN messages. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias Signed-off-by: Vikram Garhwal --- tests/qtest/xln

[PATCH v12 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers

2020-11-18 Thread Vikram Garhwal
Connect CAN0 and CAN1 on the ZynqMP. Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- include/hw/arm/xlnx-zynqmp.h | 8 hw/arm/xlnx-zcu102.c | 20 hw/arm/xlnx-zynqmp.c | 34 ++

Re: [PATCH 1/2] file-posix: Use OFD lock only if the filesystem supports the lock

2020-11-18 Thread Masayoshi Mizuma
On Wed, Nov 18, 2020 at 02:10:36PM -0500, Masayoshi Mizuma wrote: > On Wed, Nov 18, 2020 at 04:42:47PM +0100, Kevin Wolf wrote: > > Am 06.11.2020 um 05:01 hat Masayoshi Mizuma geschrieben: > > > From: Masayoshi Mizuma > > > > > > locking=auto doesn't work if the filesystem doesn't support OFD loc

[PATCH v12 4/4] MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller

2020-11-18 Thread Vikram Garhwal
Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Vikram Garhwal --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 63223e1..447b7f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1554,6 +1554,14 @@ F: hw/net/o

Re: [PULL 0/1] ppc-for-5.2 patch queue 2020-11-18

2020-11-18 Thread Greg Kurz
Update version for v5.2.0-rc2 release (2020-11-17 22:58:10 +) > > > > are available in the Git repository at: > > > > https://github.com/gkurz/qemu.git tags/ppc-for-5.2-20201118 > > > > for you to fetch changes up to 6d24795ee7e3199d199d3c415312c93382ad180

Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions

2020-11-18 Thread David Hildenbrand
So it's about the malicious guests. I agree with you that we can try to limit above from happening, e.g. by teaching vfio_get_xlat_addr() to fail when it's going to map some unplugged range of virtio-mem device. Exactly. Or... imho, we may not even need to worry too much on those misuses of

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-18 Thread Paolo Bonzini
On 18/11/20 18:30, Eduardo Habkost wrote: Adding a layer of indirect calls is not very different from monkey patching though. I'm a little bothered by monkey patching, but I'm more bothered by having to: (1) register (module_init()) a function (kvm_cpu_accel_register()) that (2) register (a

Re: [PATCH 1/2] file-posix: Use OFD lock only if the filesystem supports the lock

2020-11-18 Thread Masayoshi Mizuma
On Wed, Nov 18, 2020 at 04:42:47PM +0100, Kevin Wolf wrote: > Am 06.11.2020 um 05:01 hat Masayoshi Mizuma geschrieben: > > From: Masayoshi Mizuma > > > > locking=auto doesn't work if the filesystem doesn't support OFD lock. > > In that situation, following error happens: > > > > qemu-system-x8

Re: [PATCH 1/2] file-posix: Use OFD lock only if the filesystem supports the lock

2020-11-18 Thread Masayoshi Mizuma
On Wed, Nov 18, 2020 at 03:16:53PM +, Daniel P. Berrangé wrote: > On Thu, Nov 05, 2020 at 11:01:01PM -0500, Masayoshi Mizuma wrote: > > From: Masayoshi Mizuma > > > > locking=auto doesn't work if the filesystem doesn't support OFD lock. > > In that situation, following error happens: > > > >

Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions

2020-11-18 Thread Peter Xu
On Wed, Nov 18, 2020 at 06:37:42PM +0100, David Hildenbrand wrote: > > > a) Unplugging plugged virtio-mem blocks while they are mapped via an > > > IOMMU > > > > > > 1. Guest: map memory location X located on a virtio-mem device inside a > > > plugged block into the IOMMU > > > -> QEMU

Re: [PATCH 2/2] tests/test-image-locking: Pass the fd to the argument of qemu_has_ofd_lock()

2020-11-18 Thread Masayoshi Mizuma
On Wed, Nov 18, 2020 at 04:44:56PM +0100, Kevin Wolf wrote: > Am 06.11.2020 um 05:01 hat Masayoshi Mizuma geschrieben: > > From: Masayoshi Mizuma > > > > Pass the file descriptor of /dev/null to qemu_has_ofd_lock() because > > former patch is changed the argument. > > > > Signed-off-by: Masayosh

Re: [PULL 19/92] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:08 PM, Paolo Bonzini wrote: > On 18/11/20 16:40, Peter Maydell wrote: >> On Thu, 24 Sep 2020 at 10:40, Paolo Bonzini wrote: >>> >>> From: Philippe Mathieu-Daudé >>> >>> The serial device has 8 registers, each 8-bit. The MemoryRegionOps >>> 'serial_io_ops' is initialized with max_acc

Re: [PULL 0/1] ppc-for-5.2 patch queue 2020-11-18

2020-11-18 Thread Peter Maydell
rz/qemu.git tags/ppc-for-5.2-20201118 > > for you to fetch changes up to 6d24795ee7e3199d199d3c415312c93382ad1807: > > Revert series "spapr/xive: Allocate vCPU IPIs from the vCPU contexts" > (2020-11-18 11:05:56 +0100) > > --

Re: [PATCH 6/6] configure / meson: Move check for linux/btrfs.h to meson.build

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:10 PM, Thomas Huth wrote: > This check can be done in a much shorter way in meson.build. And while > we're at it, rename the #define to HAVE_BTRFS_H to match the other > HAVE_someheader_H symbols that we already have. > > Signed-off-by: Thomas Huth > --- > configure

Re: [PATCH for-5.2 v3] s390x/pci: fix endianness issues

2020-11-18 Thread Cornelia Huck
On Wed, 18 Nov 2020 11:42:02 +0100 Cornelia Huck wrote: > The zPCI group and function structures are big endian. However, we do > not consistently store them as big endian locally, and are missing some > conversions. > > Let's just store the structures as host endian instead and convert to > big

Re: [RFC v3 9/9] i386: split cpu accelerators from cpu.c

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 11:29:36AM +0100, Claudio Fontana wrote: > split cpu.c into: > > cpu.ccpuid and common x86 cpu functionality > host-cpu.c host x86 cpu functions and "host" cpu type > kvm/cpu.cKVM x86 cpu type > hvf/cpu.cHVF x86 cpu type > tcg/cpu.c

Re: [PATCH 2/6] configure / meson: Move check for pty.h to meson.build

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:10 PM, Thomas Huth wrote: > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 9 - > meson.build | 1 + > 2 files changed, 1 insertion(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/6] configure / meson: Move check for drm.h to meson.build

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:10 PM, Thomas Huth wrote: > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 10 -- > meson.build | 1 + > 2 files changed, 1 insertion(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[Bug 1371915] Re: Make Uninstall Rule Requested

2020-11-18 Thread Peter Maydell
This change is almost sufficient: diff --git a/Makefile b/Makefile index 76dbb917f5c..da01e3cd16a 100644 --- a/Makefile +++ b/Makefile @@ -156,7 +156,7 @@ NINJAFLAGS = $(if $V,-v) $(if $(MAKE.n), -n) $(if $(MAKE.k), -k0) \ ninja-cmd-goals = $(or $(MAKECMDGOALS), all) ninja-cmd-goals += $(foreac

Re: [PATCH 00/11] mirror: cancel nbd reconnect

2020-11-18 Thread Eric Blake
On 11/18/20 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > The problem > > Assume we have mirror job with nbd target node with enabled reconnect. > Connection failed. So, all current requests to nbd node are waiting for > nbd driver to reconnect. And they will wait for reconnect-dela

Re: [PATCH 00/11] mirror: cancel nbd reconnect

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
18.11.2020 21:19, Eric Blake wrote: On 11/18/20 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: Hi all! The problem Assume we have mirror job with nbd target node with enabled reconnect. Connection failed. So, all current requests to nbd node are waiting for nbd driver to reconnect. And they wil

Re: [PATCH] build: add "make uninstall" target

2020-11-18 Thread Peter Maydell
On Wed, 18 Nov 2020 at 16:53, Paolo Bonzini wrote: > > Do not hide the ninja "uninstall" target, so that "make uninstall" forwards > the request to "ninja uninstall". > > Suggested-by: Peter Maydell > Fixes: https://bugs.launchpad.net/qemu/+bug/1371915 > Signed-off-by: Paolo Bonzini Doesn't qui

[PATCH 11/11] iotests/264: add backup-cancel test-case

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264 | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264 index 3c6f29317f..b83

[PATCH 09/11] iotests/264: add mirror-cancel test-case

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Check that cancel doesn't wait for 10s of nbd reconnect timeout. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264 | 38 ++ tests/qemu-iotests/264.out | 4 ++-- 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a/tests/qe

Re: [PATCH 5/6] configure / meson: Move check for sys/signal.h to meson.build

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:27 PM, Eric Blake wrote: > On 11/18/20 11:10 AM, Thomas Huth wrote: > > In the subject: s/signal/kcov/ With the typo fixed: Reviewed-by: Philippe Mathieu-Daudé

[PATCH 06/11] iotests/264: fix style

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Fix long line, extra import and one mypy complaint about incompatible int and float. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264 | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/264 b/tests/qemu-iotests/264 index 666f16

[PATCH 08/11] iotests.py: qemu_nbd_popen: remove pid file after use

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
To note interfere with other qemu_nbd_popen() calls in same test. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index bcd4fe5b6f.

[PATCH 10/11] block/backup: implement .cancel job handler

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/backup.c b/block/backup.c index 9afa0bf3b4..9878594c83 100644 --- a/block/backup.c +++ b/block/backup.c @@ -36

[PATCH 03/11] block/raw-format: implement .bdrv_cancel_in_flight handler

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
We are going to cancel in-flight requests on mirror nbd target on job cancel. Still nbd is often used not directly but as raw-format child. So, add pass-through handler here. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/raw-format.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

Re: [PATCH 4/6] configure / meson: Move check for sys/signal.h to meson.build

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 6:10 PM, Thomas Huth wrote: > This check can be done in a much shorter way in meson.build > > Signed-off-by: Thomas Huth > --- > configure | 10 -- > meson.build | 1 + > 2 files changed, 1 insertion(+), 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 05/11] block/mirror: implement .cancel job handler

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 8e1ad6eceb..9faffe4707 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1179,

[PATCH 07/11] iotests/264: move to python unittest

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
We are going to add more test cases, so use the library supporting test cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/264 | 93 ++ tests/qemu-iotests/264.out | 20 ++-- 2 files changed, 58 insertions(+), 55 deletions(-) dif

[PATCH 01/11] block: add new BlockDriver handler: bdrv_cancel_in_flight

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
It will be used to stop retrying NBD requests on mirror cancel. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block.h | 3 +++ include/block/block_int.h | 9 + block/io.c| 11 +++ 3 files changed, 23 insertions(+) diff --git a/include/block/

[PATCH 02/11] block/nbd: implement .bdrv_cancel_in_flight

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Just stop waiting for connection in existing requests. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/nbd.c b/block/nbd.c index 42536702b6..887410b106 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -2419,6 +24

[PATCH 04/11] job: add .cancel handler for the driver

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
To be used in mirror in the following commit to cancel in-flight io on target to not waste the time. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/job.h | 5 + job.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/qemu/job.h b/include/qemu/job.h in

[PATCH 00/11] mirror: cancel nbd reconnect

2020-11-18 Thread Vladimir Sementsov-Ogievskiy
Hi all! The problem Assume we have mirror job with nbd target node with enabled reconnect. Connection failed. So, all current requests to nbd node are waiting for nbd driver to reconnect. And they will wait for reconnect-delay time specified in nbd blockdev options. This timeout may be long enoug

Re: How to copy data between guest memory and host

2020-11-18 Thread 沈梦姣
By the way, I’m using TCG mode. Thanks > 在 2020年11月18日,下午3:44,沈梦姣 写道: > > Hi, > I’m adding device for one platform(e.g. mps2), and also writing driver for > that device on guest os. There is a buffer allocated in qemu where some data > will be cooked, and driver will update buffer address

Re: [PATCH] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-18 Thread Daniel P . Berrangé
On Wed, Nov 18, 2020 at 05:48:09PM +, Stefan Hajnoczi wrote: > QEMU binaries no longer launch successfully with recent SystemTap > releases. This is because modular QEMU builds link the sdt semaphores > into the main binary instead of into the shared objects where they are > used. The symbol vi

[PATCH] trace: use STAP_SDT_V2 to work around symbol visibility

2020-11-18 Thread Stefan Hajnoczi
QEMU binaries no longer launch successfully with recent SystemTap releases. This is because modular QEMU builds link the sdt semaphores into the main binary instead of into the shared objects where they are used. The symbol visibility of semaphores is 'hidden' and the dynamic linker prints an error

Re: [RFC v3 8/9] module: introduce MODULE_INIT_ACCEL_CPU

2020-11-18 Thread Eduardo Habkost
On Wed, Nov 18, 2020 at 05:22:46PM +0100, Paolo Bonzini wrote: > Il mer 18 nov 2020, 17:11 Eduardo Habkost ha scritto: > > > On Wed, Nov 18, 2020 at 04:43:19PM +0100, Paolo Bonzini wrote: > > > Il mer 18 nov 2020, 16:26 Eduardo Habkost ha > > scritto: > > > > > > > > > > > > The alternative is t

Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions

2020-11-18 Thread David Hildenbrand
virtio-mem + vfio + iommu seems to work. More testing to be done. However, malicious guests can play nasty tricks like a) Unplugging plugged virtio-mem blocks while they are mapped via an IOMMU 1. Guest: map memory location X located on a virtio-mem device inside a plugged block into th

Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized

2020-11-18 Thread Havard Skinnemoen
On Wed, Nov 18, 2020 at 3:57 AM Chen Qun wrote: > > According to the glib function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > glib-autocleanups.h:28:3: warning: ‘full_name’ may be > used uninitialized in this function [-Wmaybe-uninitialized]

Re: [PATCH 5/6] configure / meson: Move check for sys/signal.h to meson.build

2020-11-18 Thread Eric Blake
On 11/18/20 11:10 AM, Thomas Huth wrote: In the subject: s/signal/kcov/ > This check can be done in a much shorter way in meson.build. And while > we're at it, rename the #define to HAVE_SYS_KCOV_H to match the other > HAVE_someheader_H symbols that we already have. > > Signed-off-by: Thomas Hut

[PATCH 6/6] configure / meson: Move check for linux/btrfs.h to meson.build

2020-11-18 Thread Thomas Huth
This check can be done in a much shorter way in meson.build. And while we're at it, rename the #define to HAVE_BTRFS_H to match the other HAVE_someheader_H symbols that we already have. Signed-off-by: Thomas Huth --- configure | 9 - linux-user/syscall.c | 2 +- linu

[PATCH 2/6] configure / meson: Move check for pty.h to meson.build

2020-11-18 Thread Thomas Huth
This check can be done in a much shorter way in meson.build Signed-off-by: Thomas Huth --- configure | 9 - meson.build | 1 + 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/configure b/configure index 6c8f56c514..5a5e486373 100755 --- a/configure +++ b/configure @@ -231

Re: [PATCH-for-5.2? 2/2] tests/qtest: fix memleak in npcm7xx_watchdog_timer-test

2020-11-18 Thread Hao Wu
On Wed, Nov 18, 2020 at 9:14 AM Havard Skinnemoen wrote: > On Wed, Nov 18, 2020 at 3:57 AM Chen Qun wrote: > > > > Properly free resp for get_watchdog_action() to avoid memory leak. > > ASAN shows memory leak stack: > > > > Indirect leak of 12360 byte(s) in 3 object(s) allocated from: > > #0

Re: [PATCH 0/6] configure / meson: Move check for headers to meson.build

2020-11-18 Thread Paolo Bonzini
On 18/11/20 18:10, Thomas Huth wrote: The checks for header files can be done much shorter and nicer in meson.build. Let's move them there. Nice, thanks. Let's route it through qemu-trivial unless Laurent complains. Thanks, Paolo Thomas Huth (6): configure: Remove the obsolete check for

[PATCH 5/6] configure / meson: Move check for sys/signal.h to meson.build

2020-11-18 Thread Thomas Huth
This check can be done in a much shorter way in meson.build. And while we're at it, rename the #define to HAVE_SYS_KCOV_H to match the other HAVE_someheader_H symbols that we already have. Signed-off-by: Thomas Huth --- configure| 9 - linux-user/ioctls.h | 2 +- linux-user/

[PATCH 3/6] configure / meson: Move check for drm.h to meson.build

2020-11-18 Thread Thomas Huth
This check can be done in a much shorter way in meson.build Signed-off-by: Thomas Huth --- configure | 10 -- meson.build | 1 + 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/configure b/configure index 5a5e486373..b3e1052a58 100755 --- a/configure +++ b/configure @@

Re: [PATCH-for-5.2? 2/2] tests/qtest: fix memleak in npcm7xx_watchdog_timer-test

2020-11-18 Thread Havard Skinnemoen
On Wed, Nov 18, 2020 at 3:57 AM Chen Qun wrote: > > Properly free resp for get_watchdog_action() to avoid memory leak. > ASAN shows memory leak stack: > > Indirect leak of 12360 byte(s) in 3 object(s) allocated from: > #0 0x7f41ab6cbd4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e) >

[PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h

2020-11-18 Thread Thomas Huth
The code that used HAVE_IFADDRS_H has been removed in commit 0a27af918b ("io: use bind() to check for IPv4/6 availability"), so we don't need this check in the configure script anymore. Signed-off-by: Thomas Huth --- configure | 11 --- 1 file changed, 11 deletions(-) diff --git a/confi

Re: [PATCH v4 2/2] arm64: kvm: Introduce MTE VCPU feature

2020-11-18 Thread Andrew Jones
On Wed, Nov 18, 2020 at 04:50:01PM +, Catalin Marinas wrote: > On Wed, Nov 18, 2020 at 04:01:20PM +, Steven Price wrote: > > On 17/11/2020 16:07, Catalin Marinas wrote: > > > On Mon, Oct 26, 2020 at 03:57:27PM +, Steven Price wrote: > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64

[PATCH 4/6] configure / meson: Move check for sys/signal.h to meson.build

2020-11-18 Thread Thomas Huth
This check can be done in a much shorter way in meson.build Signed-off-by: Thomas Huth --- configure | 10 -- meson.build | 1 + 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/configure b/configure index b3e1052a58..871e4bb9fb 100755 --- a/configure +++ b/configure @@

[PATCH 0/6] configure / meson: Move check for headers to meson.build

2020-11-18 Thread Thomas Huth
The checks for header files can be done much shorter and nicer in meson.build. Let's move them there. Thomas Huth (6): configure: Remove the obsolete check for ifaddrs.h configure / meson: Move check for pty.h to meson.build configure / meson: Move check for drm.h to meson.build configure

[Bug 1371915] Re: Make Uninstall Rule Requested

2020-11-18 Thread Paolo Bonzini
It already works since "make uninstall" is forwarded to "ninja uninstall" and from there to meson. ** Changed in: qemu Status: New => Fix Committed ** Changed in: qemu Status: Fix Committed => In Progress -- You received this bug notification because you are a member of qemu- deve

Re: [PATCH] hvf: Gate RDTSCP on CPU_BASED2_RDTSCP, not just CPU_BASED_TSC_OFFSET

2020-11-18 Thread Roman Bolshakov
On Mon, Nov 16, 2020 at 08:03:19PM +, Jessica Clarke wrote: > Buglink: https://bugs.launchpad.net/qemu/+bug/1894836 > Signed-off-by: Jessica Clarke > --- > target/i386/hvf/x86_cpuid.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x

Re: [PULL 19/92] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes

2020-11-18 Thread Paolo Bonzini
On 18/11/20 16:40, Peter Maydell wrote: On Thu, 24 Sep 2020 at 10:40, Paolo Bonzini wrote: From: Philippe Mathieu-Daudé The serial device has 8 registers, each 8-bit. The MemoryRegionOps 'serial_io_ops' is initialized with max_access_size=1, and all memory_region_init_io() callers correctly

Re: [PATCH v4 1/2] arm64: kvm: Save/restore MTE registers

2020-11-18 Thread Catalin Marinas
On Wed, Nov 18, 2020 at 04:01:18PM +, Steven Price wrote: > On 17/11/2020 19:20, Marc Zyngier wrote: > > On 2020-10-26 15:57, Steven Price wrote: > > > diff --git a/arch/arm64/include/asm/sysreg.h > > > b/arch/arm64/include/asm/sysreg.h > > > index d52c1b3ce589..7727df0bc09d 100644 > > > --- a/

Re: [PATCH PROTOTYPE 3/6] vfio: Implement support for sparse RAM memory regions

2020-11-18 Thread Peter Xu
On Wed, Nov 18, 2020 at 05:14:22PM +0100, David Hildenbrand wrote: > That did the trick! Thanks!!! Great! At the meantime, I've a few questions majorly about memory unplugging below, which could be naive - I know little on that, please bare with me.. :) > > virtio-mem + vfio + iommu seems to wo

Re: [PATCH 20/29] vl: separate qemu_apply_machine_options

2020-11-18 Thread Igor Mammedov
On Tue, 27 Oct 2020 14:21:35 -0400 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > softmmu/vl.c | 66 +--- > 1 file changed, 37 insertions(+), 29 deletions(-) > > diff --git a/softmmu/vl.c b/softmmu/vl.c

Re: [PATCH 11/29] vl: extract various command line desugaring snippets to a new function

2020-11-18 Thread Igor Mammedov
On Wed, 11 Nov 2020 21:04:53 +0100 Paolo Bonzini wrote: > Il mer 11 nov 2020, 20:57 Igor Mammedov ha scritto: > > > On Tue, 27 Oct 2020 14:21:26 -0400 > > Paolo Bonzini wrote: > > > > > Signed-off-by: Paolo Bonzini > > > --- > > > softmmu/vl.c | 40 ++--

[PATCH] linux-user/elfload: Fix handling of pure BSS segments

2020-11-18 Thread Stephen Long
qemu-user fails to load ELFs with only BSS and no data section Signed-off-by: Ben Hutchings Signed-off-by: Stephen Long --- Submitting this on behalf of Ben Hutchings. Feel free to edit the commit msg. linux-user/elfload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li

[PATCH] build: add "make uninstall" target

2020-11-18 Thread Paolo Bonzini
Do not hide the ninja "uninstall" target, so that "make uninstall" forwards the request to "ninja uninstall". Suggested-by: Peter Maydell Fixes: https://bugs.launchpad.net/qemu/+bug/1371915 Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

  1   2   3   4   >