Re: [PATCH 1/2] ppc/translate: Implement lxvwsx opcode

2020-11-13 Thread David Gibson
On Tue, Nov 10, 2020 at 10:14:23AM +0100, LemonBoy wrote: > Is there any chance for this patch series to be merged for 5.2? No. We are now in hard freeze, and this is not a bugfix. > > On 09/11/20 18:39, Richard Henderson wrote: > > On 11/9/20 1:17 AM, LemonBoy wrote: > >> Implement the "Load V

Re: [PATCH v2-for-5.2] macio: set user_creatable to false in macio_class_init()

2020-11-13 Thread David Gibson
On Tue, Nov 10, 2020 at 10:31:11AM +, Mark Cave-Ayland wrote: > Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the > device" > removed the setting of user_creatable to false on the basis that the > restriction > was due to the use of serial_hd() in macio_instance_init()

Re: [PATCH] hw: add compat machines for 6.0

2020-11-13 Thread David Gibson
On Mon, Nov 09, 2020 at 06:39:28PM +0100, Cornelia Huck wrote: > Add 6.0 machine types for arm/i440fx/q35/s390x/spapr. ppc part Acked-by: David Gibson > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c

[Bug 1770724] Re: e1000 takes a long time (2 seconds) to set link ready

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1799919] Re: IDE HDD emulation random read/write errors

2020-11-13 Thread Thomas Huth
Thanks, Peter! Looking at the bug description again and at the point in time when it happened, this was maybe a bug that we also saw with FreeDOS, caused by the CONFIG_ATA_DMA setting in Seabios, which had been fixed here: https://patchwork.kernel.org/project/qemu-devel/patch/20190318130809.3167

[Bug 1758091] Re: vmxnet3 unable to send IPv6 ESP packets

2020-11-13 Thread Thomas Jansen
** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1758091 Title: vmxnet3 unable to send IPv6 ESP packets Status in QEMU: New Bug description:

[PULL 2/2] intc/ibex_plic: Ensure we don't loose interrupts

2020-11-13 Thread Alistair Francis
If an interrupt occurs between when we claim and complete an interrupt we currently drop the interrupt in ibex_plic_irqs_set_pending(). This somewhat matches hardware that also ignore the interrupt between the claim and complete process. In the case of hardware though the physical interrupt line w

[PULL 0/2] riscv-to-apply queue

2020-11-13 Thread Alistair Francis
The following changes since commit 5ececc3a0b0086c6168e12f4d032809477b30fe5: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20201113' into staging (2020-11-13 13:40:23 +) are available in the Git repository at: g...@github.com:alistair23/qemu.git tags/pull-risc

[PULL 1/2] intc/ibex_plic: Fix some typos in the comments

2020-11-13 Thread Alistair Francis
Signed-off-by: Alistair Francis Message-id: 22d2fb0d7af5ca316c67ac909926368d1bcb7cf5.1605136387.git.alistair.fran...@wdc.com --- hw/intc/ibex_plic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/ibex_plic.c b/hw/intc/ibex_plic.c index 235e6b88ff..db9e0aa25f 1006

[PATCH] tests/vm: update NetBSD to 9.1

2020-11-13 Thread Brad Smith
tests/vm: update NetBSD to 9.1 Signed-off-by: Brad Smith Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann --- tests/vm/netbsd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 447de9747d..596717cc76 100755 --- a/tests/vm/netbsd

[Bug 1904259] Re: include/qemu/atomic.h:495:5: error: misaligned atomic operation may incur significant performance penalty (Clang 11; Ubuntu 16 i686)

2020-11-13 Thread Ivan Serdyuk
Solved by removing -Werror flag ** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1904259 Title: include/qemu/atomic.h:495:5: error:

[Bug 1904259] Re: include/qemu/atomic.h:495:5: error: misaligned atomic operation may incur significant performance penalty (Clang 11; Ubuntu 16 i686)

2020-11-13 Thread Ivan Serdyuk
$ python3.7 ../meson/meson.py --version 0.55.3 $ clang-11 --version Ubuntu clang version 11.0.0-++20200721055954+cebd637c886-1~exp1~20200721161335.13 Target: i686-pc-linux-gnu Thread model: posix $ ninja --version 1.10.0.git.kitware.jobserver-1 $ uname -a Linux laptop 4.15.0-123-generic #126~16

[Bug 1894836] Re: kernel panic using hvf with CPU passthrough

2020-11-13 Thread Jessica Clarke
0f 01 f9 is RDTSCP; use -cpu host,-rdtscp to mask out the feature. KVM couldn't pass the feature through for a while, and HVF currently can't, though HVF should be modified to automatically hide the feature until it can emulate it. -- You received this bug notification because you are a member of

[Bug 1904259] [NEW] include/qemu/atomic.h:495:5: error: misaligned atomic operation may incur significant performance penalty (Clang 11; Ubuntu 16 i686)

2020-11-13 Thread Ivan Serdyuk
Public bug reported: Hello. I haven't found any "official" executables, for emulating RISC-V (32bit; 64bit) so I had to compile those myself. I found that auto-generated build scripts, for Ninja, contained some warnings interpreted as errors: oceanfish81@gollvm:~/Desktop/qemu/build$ ninja -j 1

[PATCH 2/5 v5] KVM: SVM: Fill in conforming svm_x86_ops via macro

2020-11-13 Thread Krish Sadhukhan
The names of some of the svm_x86_ops functions do not have a corresponding 'svm_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini S

[PATCH 3/5 v5] KVM: nSVM: Fill in conforming svm_nested_ops via macro

2020-11-13 Thread Krish Sadhukhan
The names of the nested_svm_ops functions do not have a corresponding 'nested_svm_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini

[PATCH 4/5 v5] KVM: VMX: Fill in conforming vmx_x86_ops via macro

2020-11-13 Thread Krish Sadhukhan
The names of some of the vmx_x86_ops functions do not have a corresponding 'vmx_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini S

[PATCH 1/5 v5] KVM: x86: Change names of some of the kvm_x86_ops functions to make them more semantical and readable

2020-11-13 Thread Krish Sadhukhan
Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo Bonzini Signed-off-by: Sean Christopherson Signed-off-by: Krish Sadhukhan --- arch/arm64/include/asm/kvm_host.h | 2 +- arch/mips/include/asm/kvm_host.h| 2 +- arch/powerpc/include/asm/kvm_host.h | 2 +- arch/s390/kvm/kvm-s390.c

[PATCH 0/5 v5] KVM: x86: Fill in conforming {vmx|svm}_x86_ops and {vmx|svm}_nested_ops via macros

2020-11-13 Thread Krish Sadhukhan
v4 -> v5: 1. The op 'prepare_guest_switch' has been renamed to 'prepare_switch_to_guest'. 2. The following functions were missing the 'static' keyword (reported by kernel test robot ): svm_get_cs_db_l_bits svm_tl

[PATCH 5/5 v5] KVM: nVMX: Fill in conforming vmx_nested_ops via macro

2020-11-13 Thread Krish Sadhukhan
The names of some of the vmx_nested_ops functions do not have a corresponding 'nested_vmx_' prefix. Generate the names using a macro so that the names are conformant. Fixing the naming will help in better readability and maintenance of the code. Suggested-by: Vitaly Kuznetsov Suggested-by: Paolo

Re: [Bug 1904206] Re: install QEMU

2020-11-13 Thread abou
Thank you very much for your answer. I have already watched two tutorials, but it does not work. Do you have a tutorial for me? Thank you Regard Le vendredi 13 novembre 2020 à 16:55:40 UTC+1, Peter Maydell <1904...@bugs.launchpad.net> a écrit : QEMU is working fine, but your guest kernel

Re: [PATCH 14/17] target/arm: set HPFAR_EL2.NS on secure stage 2 faults

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > @@ -3444,6 +3444,9 @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t > value, > target_el = 3; > } else { > env->cp15.hpfar_el2 = extract64(fi.s2addr, 12, 47) << 4; > +

Re: [PATCH 13/17] target/arm: handle VMID change in secure state

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > The VTTBR write callback so far assumes that the underlying VM lies in > non-secure state. This handles the secure state scenario. > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/helper.c | 13 +

Re: [PATCH 11/17] target/arm: do S1_ptw_translate() before address space lookup

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > In the secure stage 2 translation regime, the VSTCR.SW and VTCR.NSW > bits can invert the secure flag for pagetable walks. This patchset > allows S1_ptw_translate() to change the non-secure bit. > > Signed-

Re: [PATCH 10/17] target/arm: add ARMv8.4-SEL2 system registers

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/cpu.h| 2 ++ > target/arm/helper.c | 24 > 2 files changed, 26 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 09/17] target/arm: add MMU stage 1 for Secure EL2

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > This adds the MMU indices for EL2 stage 1 in secure mode. > > To keep code contained, which is largelly identical between secure and > non-secure modes, the MMU indices are reassigned. The new assignments >

Re: [PATCH 01/17] target/arm: remove redundant tests

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > In this context, the HCR value is the effective value, and thus is > zero in secure mode. The tests for HCR.{F,I}MO are sufficient. > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/cpu.c| 8

[PATCH 1/3] quorum: Require WRITE perm with rewrite-corrupted

2020-11-13 Thread Max Reitz
Using rewrite-corrupted means quorum may issue writes to its children just from receiving read requests from its parents. Thus, it must take the WRITE permission when rewrite-corrupted is used. Signed-off-by: Max Reitz --- block/quorum.c | 5 + 1 file changed, 5 insertions(+) diff --git a/

Re: [PATCH 02/17] target/arm: add arm_is_el2_enabled() helper

2020-11-13 Thread Richard Henderson
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote: > From: Rémi Denis-Courmont > > This checks if EL2 is enabled (meaning EL2 registers take effects) in > the current security context. > > Signed-off-by: Rémi Denis-Courmont > --- > target/arm/cpu.h | 16 > 1 file change

[PATCH 3/3] iotests/081: Test rewrite-corrupted without WRITE

2020-11-13 Thread Max Reitz
Test what happens when a rewrite-corrupted quorum node performs such a rewrite, while there is no parent that has taken the WRITE permission. Signed-off-by: Max Reitz --- tests/qemu-iotests/081 | 54 ++ tests/qemu-iotests/081.out | 27 +++

[PATCH 0/3] quorum: Require WRITE perm with rewrite-corrupted

2020-11-13 Thread Max Reitz
Hi, While reviewing Berto’s block-status/write-zeroes series for quorum, I wondered how quorum’s permission code handles rewrite-corrupted. It turns out it doesn’t, and so qemu with a read-only rewrite-corrupted quorum node simply crashes once there is a mismatch that leads to a rewrite. It look

[PATCH 2/3] iotests/081: Filter image format after testdir

2020-11-13 Thread Max Reitz
Otherwise, this breaks whenever the test directory contains the image format (e.g. "/tmp/test-raw-file" is filtered to "/tmp/test-IMGFMT-file" instead of "TEST_DIR"). Signed-off-by: Max Reitz --- tests/qemu-iotests/081 | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/te

Re: [PATCH v4 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 13.11.20 17:52, Alberto Garcia wrote: This simply calls bdrv_co_pwrite_zeroes() in all children. bs->supported_zero_flags is also set to the flags that are supported by all children. Signed-off-by: Alberto Garcia --- block/quorum.c | 36 ++-- t

Re: [PATCH v4 0/2] quorum: Implement bdrv_co_block_status()

2020-11-13 Thread Max Reitz
On 13.11.20 17:52, Alberto Garcia wrote: Following Max's suggestion, this version sets supported_zero_flags. Berto v4: - Set supported_zero_flags in quorum [Max] - Update test to verify the data written before doing 'write -z' [Max] v3: https://lists.gnu.org/archive/html/qemu-block/2020-11/msg

Re: [PATCH v2 7/7] qapi: More complex uses of QAPI_LIST_APPEND

2020-11-13 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > --- > block/gluster.c| 13 +--- > block/qapi.c | 14 +-

Re: [PATCH v7 00/21] preallocate filter

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here is a filter, which does preallocation on write. v7: 01: add Alberto's r-b 07: don't remove sentence from the comment 08: - drop extra "s->file_end = end;" line - improve check/set perm handlers 09: add Max's r-b 10: add Ma

Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Max Reitz
On 13.11.20 19:00, Vladimir Sementsov-Ogievskiy wrote: 13.11.2020 19:24, Max Reitz wrote: On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Benchmark for new preallocate filter. Example usage: ./bench_prealloc.py ../../build/qemu-img \ ssd-ext4:/path/to/mount/point \    

[PATCH for-5.2] qga: update schema for guest-get-disks 'dependents' field

2020-11-13 Thread Michael Roth
The recently-added 'guest-get-disk' command returns a list of GuestDiskInfo entries, which in turn have a 'dependents' field which lists devices these entries are dependent upon. Thus, 'dependencies' is a better name for this field. Address this by renaming the field accordingly. Additionally, 'de

Re: [PULL 0/3] hmp queue

2020-11-13 Thread Peter Maydell
> staging (2020-11-13 11:36:30 +) > > are available in the Git repository at: > > git://github.com/dagrh/qemu.git tags/pull-hmp-20201113 > > for you to fetch changes up to e7cff9c68d4a46343861fbc3cc6b2a0b63b2dbb8: > >

Re: [PATCH 11/13] hmp/char: Use qemu_chr_parse_cli_str() for chardev-change

2020-11-13 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Instead of going through the QemuOpts-based parser, go directly from the > given option string to ChardevOptions. This doesn't only avoid legacy > code, but it also simplifies the implementation. > > Signed-off-by: Kevin Wolf OK, from HMP I think Acked-b

[Bug 1799792] Re: Broken scaling with gtk,gl=on on a hidpi display

2020-11-13 Thread Sebastian Krzyszkowiak
Still happening in QEMU 5.1.0 ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1799792 Title: Broken scaling with gtk,gl=on on a hidpi display St

[PATCH] configure: Force-remove temp dir

2020-11-13 Thread Dan Church
Sometimes the compiler will leave a write-protected .o file in the temp directory, and GNU rm will ask before deleting it unless -f is specified. Signed-off-by: Dan Church --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4cef321d9d..66

Re: [PATCH] scsi-disk: convert more errno values back to SCSI statuses

2020-11-13 Thread Paolo Bonzini
On 12/11/20 16:04, Hannes Reinecke wrote: On 11/12/20 10:52 AM, Paolo Bonzini wrote: Well, ironically I'm currently debugging a customer escalation which touches exactly this area. It revolves more around the SG_IO handling; Technically this patch is for *non* passthrough, but yeah it's a simi

Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Vladimir Sementsov-Ogievskiy
13.11.2020 19:24, Max Reitz wrote: On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Benchmark for new preallocate filter. Example usage: ./bench_prealloc.py ../../build/qemu-img \ ssd-ext4:/path/to/mount/point \ ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4 The ben

Re: [RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs

2020-11-13 Thread Daniel P . Berrangé
On Fri, Nov 13, 2020 at 05:44:04PM +, Alex Bennée wrote: > We don't need running commentary for the CI logs and by keeping it > short we might just see the problem on the first page. While we are at > it flush the previous line so order is maintained between script and > sub process. > > Signe

[RFC PATCH] .gitlab-ci.d/check-patch: tweak output for CI logs

2020-11-13 Thread Alex Bennée
We don't need running commentary for the CI logs and by keeping it short we might just see the problem on the first page. While we are at it flush the previous line so order is maintained between script and sub process. Signed-off-by: Alex Bennée --- .gitlab-ci.d/check-patch.py | 4 ++-- 1 file

[PATCH 1/1] gitlab-ci: Use $CI_REGISTRY instead of hard-coding registry.gitlab.com

2020-11-13 Thread Rebecca Cran
Update containers.yml to use the $CI_REGISTRY variable as other files such as edk2.yml do. Signed-off-by: Rebecca Cran --- .gitlab-ci.d/containers.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml index 11d079ea5810.

[PATCH v4 1/2] quorum: Implement bdrv_co_block_status()

2020-11-13 Thread Alberto Garcia
The quorum driver does not implement bdrv_co_block_status() and because of that it always reports to contain data even if all its children are known to be empty. One consequence of this is that if we for example create a quorum with a size of 10GB and we mirror it to a new image the operation will

[PATCH v4 0/2] quorum: Implement bdrv_co_block_status()

2020-11-13 Thread Alberto Garcia
Following Max's suggestion, this version sets supported_zero_flags. Berto v4: - Set supported_zero_flags in quorum [Max] - Update test to verify the data written before doing 'write -z' [Max] v3: https://lists.gnu.org/archive/html/qemu-block/2020-11/msg00371.html - Fall back to BDRV_BLOCK_DATA i

[PATCH v4 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Alberto Garcia
This simply calls bdrv_co_pwrite_zeroes() in all children. bs->supported_zero_flags is also set to the flags that are supported by all children. Signed-off-by: Alberto Garcia --- block/quorum.c | 36 ++-- tests/qemu-iotests/312 | 11 +++ t

Re: [Bug 1759338] Re: qemu-system-sparc w/ SS-20 ROM does not add processors

2020-11-13 Thread m...@papersolve.com
Yes this can be closed, no problems now using open bios to boot Solaris and it does support multiple processors though this is actually slower than one. Sent from my mobile device On Nov 13, 2020, at 11:41 AM, Peter Maydell <1759...@bugs.launchpad.net> wrote:  Reporter said in comment #1 that t

Re: [PATCH v2 05/11] qapi/introspect.py: add preliminary type hint annotations

2020-11-13 Thread Markus Armbruster
John Snow writes: > The typing of _make_tree and friends is a bit involved, but it can be > done with some stubbed out types and a bit of elbow grease. The > forthcoming patches attempt to make some simplifications, but having the > type hints in advance may aid in review of subsequent patches. >

[Bug 1759338] Re: qemu-system-sparc w/ SS-20 ROM does not add processors

2020-11-13 Thread Peter Maydell
Reporter said in comment #1 that the bug can be closed, so let's close it :-) ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1759338 Tit

[Bug 1799919] Re: IDE HDD emulation random read/write errors

2020-11-13 Thread Peter Maydell
I tried the repro case five times and each time it ran OK to the point of asking for floppy 2. So that suggests we probably fixed whatever it was... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/17999

Re: [PATCH 4/6] migration: Check xbzrle-cache-size more carefully

2020-11-13 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> migrate-set-parameters passes the size to xbzrle_cache_resize(). > >> xbzrle_cache_resize() checks it fits into size_t before it passes it > >> on to cache_i

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 13.11.20 17:26, Alberto Garcia wrote: On Fri 13 Nov 2020 05:11:20 PM CET, Max Reitz wrote: We could set all supported_zero_flags as long as all children support them, right? Sure, I was just thinking that we could set these regardless of whether the children support them, because (on zero-

Re: [PATCH] configure: Force-remove temp dir

2020-11-13 Thread Peter Maydell
On Fri, 13 Nov 2020 at 16:26, Dan Church wrote: > > Sometimes the compiler will leave a write-protected .o file in the temp > directory, and GNU rm will ask before deleting it unless -f is > specified. > > Signed-off-by: Dan Church > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 de

[Bug 1759338] Re: qemu-system-sparc w/ SS-20 ROM does not add processors

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Alberto Garcia
On Fri 13 Nov 2020 05:11:20 PM CET, Max Reitz wrote: >> We could set all supported_zero_flags as long as all children support >> them, right? > > Sure, I was just thinking that we could set these regardless of > whether the children support them, because (on zero-writes) the block > layer will fig

Re: [PATCH v7 21/21] scripts/simplebench: add bench_prealloc.py

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Benchmark for new preallocate filter. Example usage: ./bench_prealloc.py ../../build/qemu-img \ ssd-ext4:/path/to/mount/point \ ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4 The benchmark shows performance improvement

[Bug 1759337] Re: 'Failed to get "write" lock' error when trying to run a VM with disk image file on an SMB share

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v7 18/21] simplebench/results_to_text: improve view of the table

2020-11-13 Thread Vladimir Sementsov-Ogievskiy
13.11.2020 18:59, Max Reitz wrote: On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Move to generic format for floats and percentage for error. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   scripts/simplebench/results_to_text.py | 13 -   1 file changed, 12 insertions(+),

[PATCH] configure: Force-remove temp dir

2020-11-13 Thread Dan Church
Sometimes the compiler will leave a write-protected .o file in the temp directory, and GNU rm will ask before deleting it unless -f is specified. Signed-off-by: Dan Church --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 4cef321d9d..66

Re: [PATCH v7 20/21] simplebench/results_to_text: make executable

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Make results_to_text a tool to dump results saved in JSON file. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/results_to_text.py | 14 ++ 1 file changed, 14 insertions(+) mode change 100644 => 100755 s

Re: [PATCH v7 19/21] simplebench/results_to_text: add difference line to the table

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Performance improvements / degradations are usually discussed in percentage. Let's make the script calculate it for us. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/results_to_text.py | 67 +++---

[Bug 1758091] Re: vmxnet3 unable to send IPv6 ESP packets

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1799919] Re: IDE HDD emulation random read/write errors

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1759333] Re: Illegal Instruction with HVF when encountering SSE instructions in the emulator

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1800401] Re: efifb on Linux guest fails to load when using VGA passthrough

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1799792] Re: Broken scaling with gtk,gl=on on a hidpi display

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1800088] Re: Assertion fail while usb camera redirect

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Max Reitz
On 13.11.20 17:07, Alberto Garcia wrote: On Fri 13 Nov 2020 12:49:04 PM CET, Max Reitz wrote: On 11.11.20 17:53, Alberto Garcia wrote: This simply calls bdrv_co_pwrite_zeroes() in all children Signed-off-by: Alberto Garcia --- block/quorum.c | 18 -- tests/qem

Re: [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes()

2020-11-13 Thread Alberto Garcia
On Fri 13 Nov 2020 12:49:04 PM CET, Max Reitz wrote: > On 11.11.20 17:53, Alberto Garcia wrote: >> This simply calls bdrv_co_pwrite_zeroes() in all children >> >> Signed-off-by: Alberto Garcia >> --- >> block/quorum.c | 18 -- >> tests/qemu-iotests/312 | 7

[Bug 1791763] Re: broken signal handling in nios2 user-mode emulation

2020-11-13 Thread Peter Maydell
A quick eyeball of the patch and the current QEMU tree indicates that at least some of the bugs it's trying to fix still exist (notably a lot of use of "long" in various target_* structures, which should not be using types with a width dependent on the host system.) ** Changed in: qemu Stat

Deprecate the nios2-linux-user target?

2020-11-13 Thread Thomas Huth
Hi all, looking at some bug reports in the launchpad bug tracker: https://bugs.launchpad.net/qemu/+bug/1791763 https://bugs.launchpad.net/qemu/+bug/1791796 ... it seems like the nios2-linux-user target is rather broken and neglected? Is anybody still using it? If not, should we mark it as dep

[Bug 1791796] Re: unimplemented thread syscalls in nios2 user-mode emulation

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

Re: [PATCH v7 18/21] simplebench/results_to_text: improve view of the table

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Move to generic format for floats and percentage for error. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/results_to_text.py | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/scripts/

[Bug 1787002] Re: disas/i386.c compile error

2020-11-13 Thread Thomas Huth
Looking through old bug tickets ... This sounds like it was rather a bug in your toolchain ... is it still reproducible with a newer version of your Linux distro and the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you

[Bug 1788275] Re: -cpu ...,+topoext works only with EPYC CPU model

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1787070] Re: Guests using the qxl-vga are freezing

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1791763] Re: broken signal handling in nios2 user-mode emulation

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1788701] Re: "Zoom to fit" doesn't work with -display gtk -vga virtio

2020-11-13 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1904206] Re: install QEMU

2020-11-13 Thread Peter Maydell
QEMU is working fine, but your guest kernel has crashed. Either your guest kernel is the wrong one for the "versatilepb" machine type, or the kernel wants a dtb file and you are not passing one via QEMU's -dtb argument. Unless you like debugging "board bring-up" issues, I recommend that you find a

Re: [PATCH v7 08/21] block: introduce preallocate filter

2020-11-13 Thread Vladimir Sementsov-Ogievskiy
13.11.2020 17:32, Max Reitz wrote: On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems with slow allocation

[PATCH] io_uring: do not use pointer after free

2020-11-13 Thread Paolo Bonzini
Even though only the pointer value is only printed, it is untidy and Coverity complains. Cc: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- block/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/io_uring.c b/block/io_uring.c index 037af09471..00a3ee9fb8 100

Re: [PATCH v7 17/21] simplebench: move results_to_text() into separate file

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Let's keep view part in separate: this way it's better to improve it in the following commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-example.py | 3 +- scripts/simplebench/bench_write_req.py | 3 +-

Re: [PATCH v7 15/21] scripts/simplebench: use standard deviation for +- error

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Standard deviation is more usual to see after +- than current maximum of deviations. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) R

Re: [PATCH v7 16/21] simplebench: rename ascii() to results_to_text()

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Next patch will use utf8 plus-minus symbol, let's use more generic (and more readable) name. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/bench-example.py | 2 +- scripts/simplebench/bench_write_req.py | 2 +-

[PATCH] python, tests: do not use short-form boolean options

2020-11-13 Thread Paolo Bonzini
They are going to be deprecated, avoid warnings on stdout while the tests run. Signed-off-by: Paolo Bonzini --- python/qemu/machine.py | 2 +- tests/qtest/pflash-cfi02-test.c | 4 ++-- tests/qtest/test-filter-redirector.c | 8 tests/qtest/vhost-user-test.c| 8

Re: [PATCH] Clean up includes

2020-11-13 Thread Michael S. Tsirkin
On Fri, Nov 13, 2020 at 07:12:16AM +0100, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the changes > to the following files manually reverted: >

[PATCH for-5.2] spapr/xive: Create IPIs in KVM on demand

2020-11-13 Thread Greg Kurz
Recent commit acbdb9956fe9 introduced a dedicated path to create IPIs in KVM. This is done from under kvmppc_xive_cpu_connect() with the assumption that the IPI number is equal to the vCPU id. The latter is wrong: the guest chooses an arbitrary LISN from the "ibm,xive-lisn-ranges" and assigns it to

[PATCH v2] json: Fix a memleak in parse_pair()

2020-11-13 Thread Alex Chen
In qobject_type(), NULL is returned when the 'QObject' returned from parse_value() is not of QString type, and this 'QObject' memory will leaked. So we need to first cache the 'QObject' returned from parse_value(), and finally free 'QObject' memory at the end of the function. Also, we add a testca

Re: [PATCH v7 14/21] scripts/simplebench: support iops

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Support benchmarks returning not seconds but iops. We'll use it for further new test. Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 38 ++ 1 file changed, 28 insertions(+

[Bug 1904210] [NEW] Crashed with 'uncaught target signal SIGILL' while program has registered by signal(SIGILL, handler)

2020-11-13 Thread Wang Zhongwei
Public bug reported: This binary is an CTF reverse challenge binary, it registers signal handler via 'signal(SIGILL, 0x1193D);' while 0x1193D is the SIGILL handler. Please see the attachment, the file 'repair' is the binary i mentioned above, the file 'qemu-arm' is an old version qemu at 2.5.0, a

Re: [PATCH] json: Fix a memleak in parse_pair()

2020-11-13 Thread Alex Chen
On 2020/11/12 14:37, Markus Armbruster wrote: > Alex Chen writes: > >> In qobject_type(), NULL is returned when the 'QObject' returned from >> parse_value() is not of QString type, >> and this 'QObject' memory will leaked. >> So we need to first check whether the 'QObject' returned from parse_va

Re: [PATCH v7 13/21] scripts/simplebench: fix grammar: s/successed/succeeded/

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- scripts/simplebench/simplebench.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz

Re: [PATCH v7 12/21] iotests: add 298 to test new preallocate filter driver

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/298 | 186 + tests/qemu-iotests/298.out | 5 + tests/qemu-iotests/group | 1 + 3 files changed, 192 insertions(+) create

Re: [PATCH for-5.2] iotests: Replace deprecated ConfigParser.readfp()

2020-11-13 Thread Eric Blake
On 11/13/20 8:40 AM, Kevin Wolf wrote: > Am 13.11.2020 um 14:47 hat Eric Blake geschrieben: >> On 11/13/20 4:06 AM, Kevin Wolf wrote: >>> iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning >>> changes the output: >>> >>> nbd-fault-injector.py:230: DeprecationWarning: This

Re: [PATCH v7 11/21] iotests.py: execute_setup_common(): add required_fmts argument

2020-11-13 Thread Max Reitz
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote: Add a parameter to skip test if some needed additional formats are not supported (for example filter drivers). Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 9 - 1 file changed, 8 insertions(+),

Re: [PATCH for-5.2] iotests: Replace deprecated ConfigParser.readfp()

2020-11-13 Thread Kevin Wolf
Am 13.11.2020 um 14:47 hat Eric Blake geschrieben: > On 11/13/20 4:06 AM, Kevin Wolf wrote: > > iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning > > changes the output: > > > > nbd-fault-injector.py:230: DeprecationWarning: This method will be > > removed in future

  1   2   3   >