Re: [PATCH v2 01/19] tcg: Enhance flush_icache_range with separate data pointer

2020-10-31 Thread Joelle van Dyne
s->code_ptr and s->code_buf are 4 byte pointers on aarch64 so the cache flush is off by a factor of 4 diff --git a/tcg/tcg.c b/tcg/tcg.c index 44b923f5fe..2c4b66965b 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -4325,7 +4325,8 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) /* flush in

Re: [PATCH v2 14/19] RFC: accel/tcg: Support split-rwx for darwin/iOS with vm_remap

2020-10-31 Thread Joelle van Dyne
There's a compiler warning: warning: incompatible pointer to integer conversion assigning to 'mach_vm_address_t' (aka 'unsigned long long') from 'void *' [-Wint-conversion] buf_rw = tcg_ctx->code_gen_buffer; I changed it to buf_rw = (mach_vm_address_t)tcg_ctx->code_gen_buffer; Also, MAP_

Re: [PATCH v2 18/19] tcg/aarch64: Implement flush_idcache_range manually

2020-10-31 Thread Joelle van Dyne
Unfortunately this crashes on iOS/Apple Silicon macOS. (lldb) bt * thread #19, stop reason = EXC_BAD_INSTRUCTION (code=1, subcode=0xd53b002a) * frame #0: 0x0001169501e0 libqemu-x86_64-softmmu.utm.dylib`tcg_prologue_init + 760 ... (lldb) x/i 0x0001169501e0 -> 0x1169501e0: 0xd53b002a mr

[Bug 1890333] Re: [OSS-Fuzz] Issue 26693: qemu:qemu-fuzz-i386-target-generic-fuzz-xhci: Index-out-of-bounds in xhci_runtime_write Assertion failure in address_space_stw_le_cached through virtio-* devi

2020-10-31 Thread Alexander Bulekov
OSS-Fuzz Report: https://bugs.chromium.org/p/oss- fuzz/issues/detail?id=26797 === Reproducer (build with --enable-sanitizers) === cat << EOF | ./qemu-system-i386 -display none \ -machine accel=qtest, -m 512M -machine q35 \ -device virtio-blk,drive=disk0 \ -drive file=null-co://,id=disk0,if=none,fo

[Bug 1902394] [NEW] Guest stuck in Paused state right after created It

2020-10-31 Thread Tuan Anh
Public bug reported: Im using Centos 8 . I have try to use many Distribution such as : Centos, Ubuntum, Debian,.. on the guest but still all the the VM get into paused state immidiately after using virt-install ( I have tried using virt-manager too ) CPU INFO : Architecture:x86_64 CPU op-

Re: Out-of-Process Device Emulation session at KVM Forum 2020

2020-10-31 Thread Michael S. Tsirkin
On Fri, Oct 30, 2020 at 11:13:59AM +, Stefan Hajnoczi wrote: > > > 3. The device can save/load opaque blobs. This is the initial VFIO > > > approach. > > > > > > I still don't get why it must be opaque. > > If the device state format needs to be in the VMM then each device > needs explicit ena

Re: [PULL v2 01/16] tests/9pfs: fix test dir for parallel tests

2020-10-31 Thread Christian Schoenebeck
On Samstag, 31. Oktober 2020 21:34:31 CET Peter Maydell wrote: > On Sat, 31 Oct 2020 at 13:20, Christian Schoenebeck > > wrote: > > On Freitag, 30. Oktober 2020 13:07:03 CET Christian Schoenebeck wrote: > > > Use mkdtemp() to generate a unique directory for the 9p 'local' tests. > > > > > > This

Re: [PULL v2 01/16] tests/9pfs: fix test dir for parallel tests

2020-10-31 Thread Peter Maydell
On Sat, 31 Oct 2020 at 13:20, Christian Schoenebeck wrote: > > On Freitag, 30. Oktober 2020 13:07:03 CET Christian Schoenebeck wrote: > > Use mkdtemp() to generate a unique directory for the 9p 'local' tests. > > > > This fixes occasional 9p test failures when running 'make check -jN' if > > QEMU

Re: [PULL 0/5] Misc next patches

2020-10-31 Thread Peter Maydell
On Thu, 29 Oct 2020 at 10:04, Daniel P. Berrangé wrote: > > The following changes since commit bbc48d2bcb9711614fbe751c2c5ae13e172fbca8: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/renesas-20201027' = > into staging (2020-10-28 16:25:31 +) > > are available in the Git reposi

Re: [PULL 00/16] migration queue

2020-10-31 Thread Christian Schoenebeck
On Samstag, 31. Oktober 2020 18:46:11 CET Peter Xu wrote: > On Sat, Oct 31, 2020 at 05:26:28PM +, Peter Maydell wrote: > > On Sat, 31 Oct 2020 at 16:12, Christian Schoenebeck > > > > wrote: > > > On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) wrote: > > > > ---

Re: [PULL v3 00/22] Build system + misc changes for 2020-10-16

2020-10-31 Thread Paolo Bonzini
Yup, it works only with --sphix-build which obviously is how I tested it... I will include a fix in my next pull request (I don't really have anything planned, but something will most likely pop up). Paolo Il sab 31 ott 2020, 16:46 Peter Maydell ha scritto: > On Sat, 17 Oct 2020 at 15:50, Paolo

Re: [PULL 00/16] migration queue

2020-10-31 Thread Peter Xu
On Sat, Oct 31, 2020 at 05:26:28PM +, Peter Maydell wrote: > On Sat, 31 Oct 2020 at 16:12, Christian Schoenebeck > wrote: > > > > On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) wrote: > > > > > > migration

Re: [PULL 00/16] migration queue

2020-10-31 Thread Peter Maydell
On Sat, 31 Oct 2020 at 16:12, Christian Schoenebeck wrote: > > On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) wrote: > > > > migration pull: 2020-10-26 > > > > Another go at Peter's postcopy fixes > > > > Clean

Re: [PATCH v3] qom: code hardening - have bound checking while looping with integer value

2020-10-31 Thread Ani Sinha
On Thu, Oct 15, 2020 at 10:22 PM Eduardo Habkost wrote: > > On Mon, Sep 21, 2020 at 03:03:25PM +0530, Ani Sinha wrote: > > Object property insertion code iterates over an integer to get an unused > > index that can be used as an unique name for an object property. This loop > > increments the inte

Re: [PULL 00/16] migration queue

2020-10-31 Thread Christian Schoenebeck
On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit a46e72710566eea0f90f9c673a0f02da0064acce: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201026' into > staging (2020-10-26 14:50:

Re: [PATCH qemu v10] spapr: Implement Open Firmware client interface

2020-10-31 Thread Greg Kurz
On Sat, 31 Oct 2020 16:53:24 +1100 Alexey Kardashevskiy wrote: > Has anyone at least tried this, or everybody is busy KVMforuming? :) > Yeah virtualKVMforuming :) I had tried when you posted this v10 but I didn't get far at the time, because the kernel I was passing didn't want to boot and th

Re: [PULL v3 00/22] Build system + misc changes for 2020-10-16

2020-10-31 Thread Peter Maydell
On Sat, 17 Oct 2020 at 15:50, Paolo Bonzini wrote: > > * Drop ninjatool and just require ninja (Paolo) > * Fix docs build under msys2 (Yonggang) > * HAX snafu fix (Claudio) > * Disable signal handlers during fuzzing (Alex) > * Miscel

Re: [PATCH] util: Remove redundant checks in the openpty()

2020-10-31 Thread Peter Maydell
On Sat, 31 Oct 2020 at 11:04, AlexChen wrote: > > As we can see from the following function call stack, the amaster and the > aslave > cannot be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). > In addition, the amaster and the aslave has been dereferenced at the beginning > of the open

Re: [PATCH 0/2] docs: Fix building with Sphinx 3.2

2020-10-31 Thread Paolo Bonzini
On 30/10/20 21:02, Peter Maydell wrote: > Having actually looked at the current state of the kernel's > kernel-doc script I see somebody has already done the > necessary updates for Sphinx 3 compatibility. So we have > two choices for 5.2: > * take this patch 1 as a minimal fix > * do the sync of

Re: [PULL v2 00/32] VFIO updates 2020-10-28 (for QEMU 5.2 soft-freeze)

2020-10-31 Thread Peter Maydell
On Wed, 28 Oct 2020 at 16:42, Alex Williamson wrote: > > The following changes since commit 33dc9914eac581dea9bdea35dcda4d542531d66a: > > Revert series: virtiofsd: Announce submounts to the guest (2020-10-28 > 13:17:32 +) > > are available in the Git repository at: > > git://github.com/aw

Re: [PULL 00/10] qemu-sparc queue 20201028

2020-10-31 Thread Peter Maydell
On Wed, 28 Oct 2020 at 08:24, Mark Cave-Ayland wrote: > > The following changes since commit cfc1105649947f03134294a2448ce2b2e117456f: > > Merge remote-tracking branch > 'remotes/philmd-gitlab/tags/acceptance-testing-20201026' into staging > (2020-10-27 16:58:39 +) > > are available in the

Re: [PATCH 0/2] KVM: Introduce ioeventfd read support

2020-10-31 Thread Paolo Bonzini
On 20/10/20 19:00, Amey Narkhede wrote: > The first patch updates linux headers to > add ioeventfd read support while the > second patch can be used to test the > ioeventfd read feature with kvm-unit-test > which reads from specified guest addres. > Make sure the address provided in > kvm_set_ioeve

Re: [RFC PATCH-for-5.2] exec: Remove dead code (CID 1432876)

2020-10-31 Thread Paolo Bonzini
On 30/10/20 16:37, Philippe Mathieu-Daudé wrote: > We removed the global_locking field in commit 4174495408a, > leaving dead code around the 'unlocked' variable. Remove it > to fix the DEADCODE issue reported by Coverity (CID 1432876). > > Fixes: 4174495408a ("exec: Remove MemoryRegion::global_loc

[Bug 1902365] [NEW] 3x 100% host CPU core usage while virtual machine is in idle

2020-10-31 Thread Germano Massullo
Public bug reported: My Fedora 33 machine "top" command shows qemu-system-x86_64 process using ~300% CPU, that means 3x CPU cores at 100%. Since the virtual machine (named CentOS 8) is almost in idle (top command inside the VM shows ~0% CPU usage), there must be something wrong. I attach qemu proc

Re: [PATCH 2/2] block: assert that permission commit sets same permissions

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
31.10.2020 15:35, Vladimir Sementsov-Ogievskiy wrote: On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdr

Re: [PULL v2 01/16] tests/9pfs: fix test dir for parallel tests

2020-10-31 Thread Christian Schoenebeck
On Freitag, 30. Oktober 2020 13:07:03 CET Christian Schoenebeck wrote: > Use mkdtemp() to generate a unique directory for the 9p 'local' tests. > > This fixes occasional 9p test failures when running 'make check -jN' if > QEMU was compiled for multiple target architectures, because the individual

[PATCH 2/2] block: assert that permission commit sets same permissions

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
On permission update commit we must set same permissions as on _check_. Let's add assertions. Next step may be to drop permission parameters from _set_. Note that prior to previous commit, fixing bdrv_drop_intermediate(), new assertion in bdrv_child_set_perm() crashes on iotests 30 and 40. Signed

[PATCH 1/2] block: make bdrv_drop_intermediate() less wrong

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
First, permission update loop tries to do iterations transactionally, but the whole update is not transactional: nobody roll-back successful loop iterations when some iteration fails. Second, in the iteration we have nested permission update: c->klass->update_filename may point to bdrv_child_cb_up

[PATCH 0/2] Fix nested permission update

2020-10-31 Thread Vladimir Sementsov-Ogievskiy
Hi! With help of some assertions (patch 2) I've found that bdrv_drop_intermediate() do nested permission update which in my opinion may lead to unpredictable behavior. Vladimir Sementsov-Ogievskiy (2): block: make bdrv_drop_intermediate() less wrong block: assert that permission commit sets sa

[PATCH] util: Remove redundant checks in the openpty()

2020-10-31 Thread AlexChen
As we can see from the following function call stack, the amaster and the aslave cannot be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). In addition, the amaster and the aslave has been dereferenced at the beginning of the openpty(). So the checks on amaster and aslave in the openpty()

Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg)

2020-10-31 Thread Thomas Huth
On 30/10/2020 18.13, Paolo Bonzini wrote: > On 30/10/20 12:35, Eduardo Habkost wrote: >> >> What is necessary to make sure we have a CONFIG_XEN=y job in >> gitlab CI? Maybe just including xen-devel in some of the >> container images is enough? > > Fedora already has it, but build-system-fedora do

Re: [PULL 0/3] tcg patch queue

2020-10-31 Thread Peter Maydell
On Tue, 27 Oct 2020 at 16:51, Richard Henderson wrote: > > The following changes since commit 4a74626970ab4ea475263d155b10fb75c9af0b33: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/tracing-pull-request' into staging (2020-10-27 > 11:28:46 +) > > are available in the Git

Re: [PATCH] hw/display/exynos4210_fimd: Fix potential NULL pointer dereference

2020-10-31 Thread Peter Maydell
On Sat, 31 Oct 2020 at 02:57, AlexChen wrote: > > On 2020/10/30 22:28, Peter Maydell wrote: > > On Fri, 30 Oct 2020 at 10:23, AlexChen wrote: > >> > >> In exynos4210_fimd_update(), the pointer s is dereferenced before > >> being check if it is valid, which may lead to NULL pointer dereference. >

Re: [PATCH 33/36] tests: Use static properties at check-qom-proplist test case

2020-10-31 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:28 AM Eduardo Habkost wrote: > Use static properties for the bool and string properties used at > check-qom-proplist. > > Signed-off-by: Eduardo Habkost > --- > Cc: Paolo Bonzini > Cc: "Daniel P. Berrangé" > Cc: Eduardo Habkost > Cc: qemu-devel@nongnu.org > --- > te

Re: [PATCH 32/36] qdev: Move base property types to qom/property-types.c

2020-10-31 Thread Marc-André Lureau
On Fri, Oct 30, 2020 at 2:26 AM Eduardo Habkost wrote: > Move all property types from qdev-properties.c to > qom/property-types.c. > > Signed-off-by: Eduardo Habkost > Reviewed-by: Marc-André Lureau -- Marc-André Lureau