Re: [PATCH 0/5] spapr: Error handling fixes and cleanups (round 3)

On Sun, Oct 25, 2020 at 10:33:06PM +0100, Greg Kurz wrote: > On Sun, 25 Oct 2020 11:13:40 +0100 > Greg Kurz wrote: > > > On Thu, 22 Oct 2020 15:11:42 +1100 > > David Gibson wrote: > > > > > On Mon, Oct 19, 2020 at 10:47:52AM +0200, Greg Kurz wrote: > > > > Hi, > > > > > > > > This is a followu

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Fri, 23 Oct 2020 09:26:48 +0300 Marcel Apfelbaum wrote: > Hi Michael, > > On Thu, Oct 22, 2020 at 6:01 PM Michael S. Tsirkin wrote: > > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] >

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Fri, 23 Oct 2020 19:27:55 +0200 Igor Mammedov wrote: > On Fri, 23 Oct 2020 11:54:40 -0400 > "Michael S. Tsirkin" wrote: > > [...] > [...] > [...] > [...] > > > > Rather than adding_device_allowed, something like "query slot" > > might be helpful for debugging. That would help us

Re: [PATCH] pci: Refuse to hotplug PCI Devices when the Guest OS is not ready

On Fri, 23 Oct 2020 09:47:14 +0300 Marcel Apfelbaum wrote: > Hi David, > > On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote: > > > On Thu, 22 Oct 2020 11:01:04 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Oct 22, 2020 at 05:50:51PM +0300, Marcel Apfelbaum wrote: > > > [...] >

Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module

Hi, > > commit 501093207eb1ed4845e0a65ee1ce7db7b9676e0b > > Author: Gerd Hoffmann > > Date: Wed Sep 23 11:12:17 2020 +0200 > > > > module: silence errors for module_load_qom_all(). > > > Ok, but that could hide real errors, couldn't it? It should not. If you explicitly ask for an module

Re: [PATCH] ACPI: Avoid infinite recursion when dump-vmstate

On 10/24/2020 2:54 AM, Dr. David Alan Gilbert wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: >> On Mon, 19 Oct 2020 17:31:56 +0800 >> Peng Liang wrote: >> >>> There is a field with vmstate_ghes_state as vmsd in vmstate_ghes_state, >>> which will lead to infinite recursion in dump_vmstate_vm

[PATCH v3] virtio-net: Add check for mac address while peer is vdpa

Sometime vdpa get an all 0 mac address from the hardware, this will cause the traffic down So we add the check for this part. if we get an 0 mac address we will use the default mac address instead Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 7 ++- 1 file changed, 6 insertions(+), 1 de

Re: [PATCH 2/2] riscv: Add sifive test device to sifive_u target

Hi Keith, On Sat, Oct 24, 2020 at 8:17 AM Keith Packard via wrote: > > Alistair Francis writes: > > > I also don't see this in the FU540 memory map. > > Same as for the FE310 -- this is a QEMU-only device. In addition, > OpenSBI expects to use this when built for QEMU. I agree with Alistair. Th

Re: [PATCH 4/6] tests/acceptance: Introduce tesseract_ocr() helper

On 24/10/2020 19.40, Philippe Mathieu-Daudé wrote: > On 10/24/20 9:37 AM, Philippe Mathieu-Daudé wrote: >> On 10/24/20 8:40 AM, Thomas Huth wrote: >>> On 24/10/2020 08.35, Thomas Huth wrote: On 21/10/2020 12.50, Philippe Mathieu-Daudé wrote: > We are going to reuse the tesseract OCR code.

[PATCH v6 1/3] hw/block/nvme: add dulbe support

From: Klaus Jensen Add support for reporting the Deallocated or Unwritten Logical Block Error (DULBE). Rely on the block status flags reported by the block layer and consider any block with the BDRV_BLOCK_ZERO flag to be deallocated. Multiple factors affect when a Write Zeroes command result in

[PATCH v6 3/3] hw/block/nvme: add the dataset management command

From: Klaus Jensen Add support for the Dataset Management command and the Deallocate attribute. Deallocation results in discards being sent to the underlying block device. Whether of not the blocks are actually deallocated is affected by the same factors as Write Zeroes (see previous commit).

[PATCH v6 2/3] nvme: add namespace I/O optimization fields to shared header

From: Klaus Jensen This adds the NPWG, NPWA, NPDG, NPDA and NOWS family of fields to the shared nvme.h header for use by later patches. Signed-off-by: Klaus Jensen Cc: Stefan Hajnoczi Cc: Fam Zheng --- include/block/nvme.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --g

[PATCH v6 0/3] hw/block/nvme: dulbe and dsm support

From: Klaus Jensen This adds support for the Deallocated or Unwritten Logical Block error recovery feature as well as the Dataset Management command. I wanted to add support for the NPDG and NPDA fields such that the host could get a hint on how many blocks to request deallocation of for the dea

Re: [PATCH v2] virtio-net: Add check for mac address while peer is vdpa

Hi jason On Mon, Oct 26, 2020 at 11:20 AM Jason Wang wrote: > > On 2020/10/26 上午10:43, Jason Wang wrote: > > > > On 2020/10/23 下午5:15, Cindy Lu wrote: > >> Sometime vdpa get an all 0 mac address from the hardware, this will > >> cause the traffic down > >> So we add the check for this part. > >

Re: Enable MSI-X support in PCIe device.

I have tried to use msi only, but failed again. Is there and documentation details this? From: Qemu-devel on behalf of Douglas Su Sent: Thursday, October 22, 2020 20:32 To: QEMU Developers Subject: Enable MSI-X support in PCIe device. To use MSI-X interrupt i

Re: [PATCH v3] net: remove an assert call in eth_get_gso_type

On 2020/10/21 下午5:23, P J P wrote: +-- On Wed, 21 Oct 2020, Jason Wang wrote --+ | It should not be a guest error, since guest is allowed to send a packet | other than IPV4(6). * Ah...sigh! :( * I very hesitantly used guest_error mask, since it was g_assert-ing before. To me both guest_err

Re: [PATCH v2] virtio-net: Add check for mac address while peer is vdpa

On 2020/10/26 上午10:43, Jason Wang wrote: On 2020/10/23 下午5:15, Cindy Lu wrote: Sometime vdpa get an all 0 mac address from the hardware, this will cause the traffic down So we add the check for this part. if we get an 0 mac address we will use the default mac address instead Signed-off-by:

Re: [PATCH v2] virtio-net: Add check for mac address while peer is vdpa

On 2020/10/23 下午5:15, Cindy Lu wrote: Sometime vdpa get an all 0 mac address from the hardware, this will cause the traffic down So we add the check for this part. if we get an 0 mac address we will use the default mac address instead Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 7 +++

[PATCH] i386/kvm: fix setting up nested_state for SVM

nested_state->format needs to ne set appropriately for VMX/SVM, otherwise KVM_SET_NESTED_STATE ioctl will fail. Signed-off-by: Marek Marczykowski-Górecki --- target/i386/kvm.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/target/i386/kvm.c b/target/i386/

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

Hi Philippe, On Mon, Oct 26, 2020 at 2:56 AM Philippe Mathieu-Daudé wrote: > > On 10/25/20 4:23 PM, Bin Meng wrote: > > From: Bin Meng > > > > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 > > bytes, hence the READ_BL_LEN field in the CSD register shall be 10 > > instead of

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

On 201025 1351, Joelle van Dyne wrote: > > Finally, I'd like to have this implemented on Linux as well, or I'm afraid > > the > > feature will bit-rot. This can be trivially done by either (1) > > MREMAP_DONTUNMAP or (2) mapping from posix shared memory instead of > > MAP_ANON so > > that you ca

Re: [PATCH 0/5] spapr: Error handling fixes and cleanups (round 3)

On Sun, 25 Oct 2020 11:13:40 +0100 Greg Kurz wrote: > On Thu, 22 Oct 2020 15:11:42 +1100 > David Gibson wrote: > > > On Mon, Oct 19, 2020 at 10:47:52AM +0200, Greg Kurz wrote: > > > Hi, > > > > > > This is a followup to a previous cleanup for the sPAPR code: > > > > > > https://lists.gnu.org/

Re: [PATCH 1/5] pc-dimm: Drop @errp argument of pc_dimm_plug()

On Fri, 23 Oct 2020 21:19:19 +0200 Igor Mammedov wrote: > On Mon, 19 Oct 2020 10:48:04 +0200 > Greg Kurz wrote: > > > pc_dimm_plug() doesn't use it. It only aborts on error. > > > > Drop @errp and adapt the callers accordingly. > > > > Signed-off-by: Greg Kurz > Reviewed-by: Igor Mammedov >

Re: [PATCH v3 1/2] hw/misc: add an EMC141{3,4} device model

On 10/25/20 2:14 PM, John Wang wrote: Largely inspired by the TMP421 temperature sensor, here is a model for the EMC1413/EMC1414 temperature sensors. Specs can be found here : http://ww1.microchip.com/downloads/en/DeviceDoc/20005274A.pdf Signed-off-by: John Wang --- v3: - update the link

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

> Finally, I'd like to have this implemented on Linux as well, or I'm afraid the > feature will bit-rot. This can be trivially done by either (1) > MREMAP_DONTUNMAP or (2) mapping from posix shared memory instead of MAP_ANON > so > that you can map the same memory twice. Thus virtually all of th

[Bug 1901440] [NEW] Instability in IVSHMEM after updating QEMU 4.2 -> 5.0

Public bug reported: Updating Ubuntu from 20.08 to 20.10 which updates QEMU from 4.2 to 5.0 results in the virtual machines freezing when the IVSHMEM interface is active. This workstation typically runs several windows 10 virtual machines that are accessed locally: two using the spice viewer and

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

On 10/25/20 7:56 PM, Philippe Mathieu-Daudé wrote: On 10/25/20 4:23 PM, Bin Meng wrote: From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for t

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

Cc'ing avocado-devel@ On 10/26/20 12:35 AM, Niek Linnenbank wrote: On Sun, Oct 25, 2020 at 3:17 AM Bin Meng > wrote: On Sun, Oct 25, 2020 at 5:01 AM Niek Linnenbank mailto:nieklinnenb...@gmail.com>> wrote: ... > After applying that change, all Orange Pi

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

On Mon, Oct 19, 2020 at 5:20 PM Richard Henderson wrote: > > On 10/19/20 3:39 PM, Joelle van Dyne wrote: > >> Explicit cast may not be needed here so this could be a macro if caling it > >> differently helps or why don't you just use tcg_mirror_prr_rw directly > >> everywhere? > > > > There are qu

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

As the patch stands --cross-prefix="" works but I like having the --enable-cross-compile option because it's more clear of the intention (in logs and such). I've been struggling to come up with a concise modification to the help text for --cross-prefix that explains that empty PREFIX is allowed and

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

On 10/25/20 4:23 PM, Bin Meng wrote: From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for the NetBSD 9.0 test of the Orange Pi PC that has an e

Re: [PATCH 0/6] qemu-storage-daemon: QAPIfy --chardev

Paolo Bonzini writes: > On 23/10/20 15:40, Markus Armbruster wrote: >>> >>> The benefit of the user creatable object approach is that we dont >>> have to add custom CLI args for different types of object, nor write >>> code to populate QOM from QAPI. The downside is that we're divorced >>> from t

Re: [PATCH] tests/acceptance: expand Orange Pi PC SD images for NetBSD, Armbian above nearest power of two

Hi Philippe, I've tested the patch by Bin on the 2G & Sd blocksize issue, see my response there. https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg07318.html So probably we do not need the patch I send here. Regards, Niek On Mon, Oct 26, 2020 at 12:48 AM Niek Linnenbank wrote: > Hel

Re: [PATCH] hw/sd: Fix 2 GiB card CSD register values

Hello Bin, On Sun, Oct 25, 2020 at 4:25 PM Bin Meng wrote: > From: Bin Meng > > Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 > bytes, hence the READ_BL_LEN field in the CSD register shall be 10 > instead of 9. > > This fixes the acceptance test error for the NetBSD 9.0 tes

Re: [PULL 25/33] tests/acceptance: Add a test for the N800 and N810 arm machines

On Fri, 23 Oct 2020 at 20:04, Igor Mammedov wrote: > > On Fri, 23 Oct 2020 19:39:16 +0200 > Philippe Mathieu-Daudé wrote: > > Are you saying arm_boot_info should hold a pointer to MachineState* > > instead of duplicating? > > yep, some parts of it (fdt related) already use MachineState* so it's >

Re: [PATCH] tests/acceptance: expand Orange Pi PC SD images for NetBSD, Armbian above nearest power of two

Hello Philippe, On Sun, Oct 25, 2020 at 1:11 PM Philippe Mathieu-Daudé wrote: > On 10/25/20 2:31 AM, Philippe Mathieu-Daudé wrote: > > Hi Niek, > > > > On 10/24/20 11:52 PM, Niek Linnenbank wrote: > >> The acceptance tests for the Orange Pi PC need to expand the SD card > >> images > >> to a siz

Re: [RFC PATCH 4/4] tests/acceptance: Test U-Boot/Linux from Armbian 20.08 on Orange Pi PC

Hi Bin, On Sun, Oct 25, 2020 at 3:17 AM Bin Meng wrote: > Hi Niek, > > On Sun, Oct 25, 2020 at 5:01 AM Niek Linnenbank > wrote: > > > > Hi Philippe, > > > > I have ran this series with the new Armbian 20.08 test and noticed this > failure: > > > > -console: /dev/mmcblk0p1: The filesystem size (

Re: [PATCH] tests/acceptance: expand Orange Pi PC SD images for NetBSD, Armbian above nearest power of two

On Sun, Oct 25, 2020 at 8:13 PM Philippe Mathieu-Daudé wrote: > > On 10/25/20 2:31 AM, Philippe Mathieu-Daudé wrote: > > Hi Niek, > > > > On 10/24/20 11:52 PM, Niek Linnenbank wrote: > >> The acceptance tests for the Orange Pi PC need to expand the SD card > >> images > >> to a size which is a pow

[PATCH] hw/sd: Fix 2 GiB card CSD register values

From: Bin Meng Per the SD spec, to indicate a 2 GiB card, BLOCK_LEN shall be 1024 bytes, hence the READ_BL_LEN field in the CSD register shall be 10 instead of 9. This fixes the acceptance test error for the NetBSD 9.0 test of the Orange Pi PC that has an expanded SD card image of 2 GiB size. F

Re: [PATCH 4/5] spapr: Pass &error_abort when getting some PC DIMM properties

On Fri, 23 Oct 2020 21:15:09 +0200 Igor Mammedov wrote: > On Mon, 19 Oct 2020 10:48:41 +0200 > Greg Kurz wrote: > > > Both PC_DIMM_SLOT_PROP and PC_DIMM_ADDR_PROP are defined in the > > default property list of the PC DIMM device class: > > > > DEFINE_PROP_UINT64(PC_DIMM_ADDR_PROP, PCDIMMD

Re: [PATCH 0/6] tests/acceptance: Test the Fuloong 2E machine

On Sun, 25 Oct 2020, Philippe Mathieu-Daudé wrote: On 10/25/20 12:18 PM, Mark Cave-Ayland wrote: On 21/10/2020 11:50, Philippe Mathieu-Daudé wrote: This series add tests for the MIPS Fuloong 2E machine. I have been using these tests for over 1 year now. After recent discussions with Huacai an

[PATCH v3 2/2] aspeed: Add support for the g220a-bmc board

G220A is a 2 socket x86 motherboard supported by OpenBMC. Strapping configuration was obtained from hardware. Signed-off-by: John Wang Reviewed-by: Cédric Le Goater Reviewed-by: Joel Stanley --- v3: - No changes v2: - No changes --- hw/arm/aspeed.c | 60

[PATCH v3 1/2] hw/misc: add an EMC141{3,4} device model

Largely inspired by the TMP421 temperature sensor, here is a model for the EMC1413/EMC1414 temperature sensors. Specs can be found here : http://ww1.microchip.com/downloads/en/DeviceDoc/20005274A.pdf Signed-off-by: John Wang --- v3: - update the link to the spec - Rename emc1413.c to emc14

Re: [PATCH 0/6] tests/acceptance: Test the Fuloong 2E machine

On 10/25/20 12:18 PM, Mark Cave-Ayland wrote: On 21/10/2020 11:50, Philippe Mathieu-Daudé wrote: This series add tests for the MIPS Fuloong 2E machine. I have been using these tests for over 1 year now. After recent discussions with Huacai and Mark regarding how to contribute tests for machine

Re: [PATCH] tests/acceptance: expand Orange Pi PC SD images for NetBSD, Armbian above nearest power of two

On 10/25/20 2:31 AM, Philippe Mathieu-Daudé wrote: Hi Niek, On 10/24/20 11:52 PM, Niek Linnenbank wrote: The acceptance tests for the Orange Pi PC need to expand the SD card images to a size which is a power of two. As Qemu uses the size of the SD image file as well for the size of the emulate

Re: [PATCH v3] hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter

On 10/25/20 11:55 AM, Mark Cave-Ayland wrote: On 24/10/2020 21:51, Philippe Mathieu-Daudé wrote: The S24/TCX datasheet is listed as "Unable to locate" on [1]. However the NetBSD revision 1.32 of the driver introduced 64-bit accesses to the stippler and blitter [2]. It is safe to assume these m

Re: [PATCH] sabre: use object_initialize_child() for iommu child object

On 10/25/20 12:11 PM, Mark Cave-Ayland wrote: On 21/10/2020 12:43, Mark Cave-Ayland wrote: Store the child object directly within the sabre object rather than using link properties. Signed-off-by: Mark Cave-Ayland ---   hw/pci-host/sabre.c | 10 --   hw/sparc64/sun4u.c 

Re: [PATCH 0/6] tests/acceptance: Test the Fuloong 2E machine

On 21/10/2020 11:50, Philippe Mathieu-Daudé wrote: This series add tests for the MIPS Fuloong 2E machine. I have been using these tests for over 1 year now. After recent discussions with Huacai and Mark regarding how to contribute tests for machines using private blob, I think it is time to pub

Re: [PATCH] sabre: use object_initialize_child() for iommu child object

On 21/10/2020 12:43, Mark Cave-Ayland wrote: Store the child object directly within the sabre object rather than using link properties. Signed-off-by: Mark Cave-Ayland --- hw/pci-host/sabre.c | 10 -- hw/sparc64/sun4u.c | 8 +--- include/hw/pci-host/sabre.h |

Re: [PATCH v2 0/2] pci: assert that irqnum is between 0 and bus->nirqs in pci_change_irq_level()

On 24/10/2020 21:38, Philippe Mathieu-Daudé wrote: Respin of Mark's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg749459.html Supersedes: <20201011082022.3016-1-mark.cave-ayl...@ilande.co.uk> Mark Cave-Ayland (1): pci: Assert irqnum is between 0 and bus->nirqs in pci_bus

Re: [PATCH] sabre: increase number of PCI bus IRQs from 32 to 64

On 24/10/2020 21:41, Philippe Mathieu-Daudé wrote: On 10/21/20 11:27 AM, Mark Cave-Ayland wrote: On 11/10/2020 09:13, Mark Cave-Ayland wrote: The rework of the sabre IRQs in commit 6864fa3897 "sun4u: update PCI topology to include simba PCI bridges" changed the IRQ routing so that both PCI an

Re: [PATCH v3] hw/display/tcx: Allow 64-bit accesses to framebuffer stippler and blitter

On 24/10/2020 21:51, Philippe Mathieu-Daudé wrote: The S24/TCX datasheet is listed as "Unable to locate" on [1]. However the NetBSD revision 1.32 of the driver introduced 64-bit accesses to the stippler and blitter [2]. It is safe to assume these memory regions are 64-bit accessible. QEMU imple

Re: [PATCH 0/5] spapr: Error handling fixes and cleanups (round 3)

On Thu, 22 Oct 2020 15:11:42 +1100 David Gibson wrote: > On Mon, Oct 19, 2020 at 10:47:52AM +0200, Greg Kurz wrote: > > Hi, > > > > This is a followup to a previous cleanup for the sPAPR code: > > > > https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg04860.html > > > > The last two patc

Re: [PATCH v2 3/6] qapi: Remove wrapper struct for simple unions

I apologize for writing so much. It's the only way I know to figure out how things work. This may feel like I'm trying to shoot down your patch. I'm not! I'm merely trying to understand and maybe improve it. I'd love to get rid of implicit wrapper objects, actually. They complicate things in