Re: [RFC v6 12/13] intel_iommu: Do not notify regular iotlb to device-iotlb notifiers

2020-08-26 Thread Eugenio Perez Martin
On Wed, Aug 26, 2020 at 6:52 PM 罗勇刚(Yonggang Luo) wrote: > > > > On Wed, Aug 26, 2020 at 10:42 PM Eugenio Pérez wrote: >> >> This improves performance in case of netperf with vhost-net: >> * TCP_STREAM: From 9049.59Mbit/s to 9049.59Mbit/s (13%) > > What's improvement ? they are the same > Ouch,

Re: [RFC v6 00/13] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-08-26 Thread Eugenio Perez Martin
On Wed, Aug 26, 2020 at 5:54 PM Peter Xu wrote: > > On Wed, Aug 26, 2020 at 05:00:30PM +0200, Eugenio Perez Martin wrote: > > Hi! > > > > Sending v6 to see if that is on the same page as what you meant. > > Making each setting of "type" explicitly IOMMU_IOTLB_NONE if not used > > in notifications.

[PATCH] meson: fix qxl module build

2020-08-26 Thread Gerd Hoffmann
Drop qxl object from softmmu source set, it is built as module. Also drop CONFIG_QXL condition from qxl_ss.add. First because it is pointless, the whole thing is wrapped into "has_key('CONFIG_QXL')". Second because it doesn't work for some reason. Looks like the source files are not added to the

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread Zheng Chuan
On 2020/8/26 20:35, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Record hash results for each sampled page, crc32 is taken to calculate >> hash results for each sampled 4K-page. >> >> Signed-off-by: Chuan Zheng >> Signed-off-by: YanYing Zhuang >> --- >> migr

Re: [PATCH] meson: move pixman detection to meson

2020-08-26 Thread Paolo Bonzini
Il gio 27 ago 2020, 06:53 Thomas Huth ha scritto: > > -else > > - error_exit "pixman >= 0.21.8 not present." \ > > - "Please install the pixman devel package." > > -fi > > The "else" part now got completely lost, didn't it? It's replaced by "required: have_system" in meson.build. We can a

Re: [PATCH v5 04/12] migration/dirtyrate: Add dirtyrate statistics series functions

2020-08-26 Thread Zheng Chuan
On 2020/8/26 20:09, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> Add dirtyrate statistics to record/update dirtyrate info. >> >> Signed-off-by: Chuan Zheng >> --- >> migration/dirtyrate.c | 29 + >> migration/dirtyrate.h | 10 +

Re: [RFC v6 02/13] memory: Add IOMMUTLBNotificationType to IOMMUTLBEntry

2020-08-26 Thread Eugenio Perez Martin
On Wed, Aug 26, 2020 at 5:42 PM Peter Xu wrote: > > On Wed, Aug 26, 2020 at 04:36:40PM +0200, Eugenio Pérez wrote: > > This way we can tell between MAPs and UNMAP, and potentially avoid to > > send them to a notifier that does not require them. > > > > Signed-off-by: Eugenio Pérez > > --- > > in

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-26 Thread Markus Armbruster
Rohit Shinde writes: > I am just compiling with cflag set to -Wimplicit-fallthrough. I am using > gcc. -Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our -code is not prepared for that. What should work is --Wimplicit-fallthrough=2. If you have patches to make the entire tree

Re: [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-26 Thread Zheng Chuan
On 2020/8/26 19:49, Dr. David Alan Gilbert wrote: > * Chuan Zheng (zhengch...@huawei.com) wrote: >> add DirtyRateStatus to denote calculating status. >> >> Signed-off-by: Chuan Zheng > > With the minor wording changes from David Edmondson: > OK, will fix it in V6. > > Reviewed-by: Dr. David

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Alexander Bulekov
On 200827 0613, Paolo Bonzini wrote: > Il mer 26 ago 2020, 21:34 Peter Maydell ha > scritto: > > > On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > > > > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > > > eaten by Make. > > > > Incidentally, why are we using rpath anyway

[PATCH v2 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recogni

[PATCH v2 6/6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread luoyonggang
From: Yonggang Luo undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/undefsym.py | 57 + scripts/undefsym.sh | 20 3 files changed, 58 insertions(+)

[PATCH v2 3/6] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread luoyonggang
From: Yonggang Luo Fixes this for msys2/mingw64 by remove the include_type for sdl2 discovery in meson Signed-off-by: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..1644bbd83c 100644 --- a/meson.bu

[PATCH v2 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ninjat

[PATCH v2 5/6] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv $cro

[PATCH v2 2/6] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11 +

[PATCH v2 0/6] Fixes msys2 building after the meson convert

2020-08-26 Thread luoyonggang
From: Yonggang Luo These patch series fixes the building of newest qemu under msys2 environment Yonggang Luo (6): meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja meson: fixes relpath may fail on win32. meson: Mingw64 gcc doesn't recognize system include_type

Re: [PATCH] meson: move pixman detection to meson

2020-08-26 Thread Thomas Huth
On 26/08/2020 09.02, Paolo Bonzini wrote: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build of v

[PATCH 5/6] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2

2020-08-26 Thread luoyonggang
From: Yonggang Luo use ninja instead ${build_path}/ninjatool Signed-off-by: Yonggang Luo --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b9e79923d..2ad0c58492 100755 --- a/configure +++ b/configure @@ -8222,7 +8222,7 @@ fi mv $cro

[PATCH 2/6] meson: fixes relpath may fail on win32.

2020-08-26 Thread luoyonggang
From: Yonggang Luo On win32, os.path.relpath would raise exception when do the following relpath: C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail. So we try catch it for stopping it from raise exception on msys2 Signed-off-by: Yonggang Luo --- scripts/mtest2make.py | 11 +

[PATCH 6/6] meson: Convert undefsym.sh to undefsym.py

2020-08-26 Thread luoyonggang
From: Yonggang Luo undefsym.sh are not msys2 compatible, convert it to python script Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/undefsym.py | 57 + scripts/undefsym.sh | 20 3 files changed, 58 insertions(+)

[PATCH 3/6] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread luoyonggang
From: Yonggang Luo Fixes this for msys2/mingw64 by remove the include_type for sdl2 discovery in meson Signed-off-by: Yonggang Luo --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index f0fe5f8799..1644bbd83c 100644 --- a/meson.bu

[PATCH 4/6] configure: Fix include and linkage issue on msys2

2020-08-26 Thread luoyonggang
From: Yonggang Luo On msys2, the -I/e/path/to/qemu -L/e/path/to/qemu are not recognized by the compiler Cause $PWD are result posix style path such as /e/path/to/qemu that can not be recognized by mingw gcc, and `pwd -W` are result Windows style path such as E:/path/to/qemu that can be recogni

[PATCH 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread luoyonggang
From: Yonggang Luo SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the path are start with C:/ and E:/ Signed-off-by: Yonggang Luo --- scripts/ninjatool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ninjat

[PATCH 0/6] *** Fixes msys2 building after the meson convert ***

2020-08-26 Thread luoyonggang
From: Yonggang Luo msys2 environment *** BLURB HERE *** Yonggang Luo (6): meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja meson: fixes relpath may fail on win32. meson: Mingw64 gcc doesn't recognize system include_type for sdl2 configure: Fix include and l

Re: [PATCH 4/8] sclpconsole: Use TYPE_* constants

2020-08-26 Thread Thomas Huth
On 26/08/2020 20.43, Eduardo Habkost wrote: > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Thomas Huth > Cc: "Marc-André Lureau" > Cc: Paolo Bonzini > Cc: qemu

Re: Contributor wanting to get started with simple contributions

2020-08-26 Thread Thomas Huth
On 26/08/2020 17.00, Rohit Shinde wrote: > Hey Thomas, > > I didn't really have any specific questions. I wanted to know if there > was any part of qemu that I could contribute to. Qemu is overwhelmingly > vast and without some pointers, I felt very lost. Ok, that's true - QEMU is really a huge p

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Paolo Bonzini
Il mer 26 ago 2020, 21:34 Peter Maydell ha scritto: > On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > > eaten by Make. > > Incidentally, why are we using rpath anyway? I'm pretty > sure the old build system didn't need it

Re: [RFC PATCH v3 24/34] Hexagon (target/hexagon) opcode data structures

2020-08-26 Thread Richard Henderson
On 8/26/20 4:52 PM, Taylor Simpson wrote: >> And using qemu/bitops.h if possible, as discussed earlier vs attribs.h. > > Do you mean replace the GET_ATTRIB macro with test_bit from qemu/bitops.h? No, just define GET_ATTRIB in terms of test_bit, and define opcode_attribs using BITS_TO_LONGS. r~

[PATCH v3] virtio-gpu: fix unmap the already mapped items

2020-08-26 Thread Li Zhijian
we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider to unmap the 'i'th item as well when the 'i'th item is not nil CC: Li Qiang Signed-off-by: Li Zhijian --- v2: address Gerd's comments v3: leave (*iov)[i].iov_len as the real mapped len (Li Qiang) --- hw/display/virtio

Re: [PATCH v2] virtio-gpu: fix unmap the already mapped items

2020-08-26 Thread Li Zhijian
On 8/26/20 10:54 PM, Li Qiang wrote: Li Zhijian 于2020年8月21日周五 下午7:34写道: we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider to unmap the 'i'th item as well when the 'i'th item is not nil Signed-off-by: Li Zhijian --- v2: address Gerd's comments --- hw/display/v

Re: [PATCH 08/12] migration/colo: Plug memleaks in colo_process_incoming_thread

2020-08-26 Thread Pan Nengyuan
On 2020/8/26 20:37, Li Qiang wrote: > Pan Nengyuan 于2020年8月14日周五 下午6:52写道: >> >> 'local_err' forgot to free in colo_process_incoming_thread error path. >> Fix that. >> >> Reported-by: Euler Robot >> Signed-off-by: Pan Nengyuan >> --- >> Cc: Hailiang Zhang >> Cc: Juan Quintela >> Cc: "Dr. Da

Re: [PATCH] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200825001649.1811-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200825001649.1811-1-luoyongg...@gmail.com Subject: [PATCH] meson: Mingw64 gcc doesn't

Re: [RFC PATCH v3 2/2] hw/riscv: sifive_u: Add write-once protection.

2020-08-26 Thread Bin Meng
On Wed, Aug 19, 2020 at 1:09 AM Green Wan wrote: > > Add array to store the 'written' status for all bit of OTP to block > the write operation to the same bit. Ignore the control register > offset from 0x0 to 0x38 of OTP memory mapping. nits: please remove the ending period in the commit title >

Re: oslib-posix:Fix handle fd leak in qemu_write_pidfile()

2020-08-26 Thread AlexChen
On 2020/8/26 18:18, Daniel P. Berrangé wrote: > On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote: >> > From: alexchen >> > >> > The fd will leak when (a.st_ino == b.st_ino) is true, fix it. > That is *INTENTIONAL*. We're holding a lock on the file and the > lock exists only while the FD

Re: [RFC PATCH v3 1/2] hw/riscv: sifive_u: Add backend drive support

2020-08-26 Thread Bin Meng
On Wed, Aug 19, 2020 at 1:09 AM Green Wan wrote: > > Add '-drive' support to OTP device. Allow users to assign a raw file > as OTP image. > > Signed-off-by: Green Wan > --- > hw/riscv/sifive_u_otp.c | 50 + > include/hw/riscv/sifive_u_otp.h | 2 ++ > 2 fi

Re: [PATCH 8/8] dc390: Use TYPE_DC390_DEVICE constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:44写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Paolo Bonzini > Cc: Fam Zheng > Cc: qemu-devel@nongnu.org > --- > hw/scsi/esp-pci.c | 2 +- > 1 file changed, 1 in

Re: [PATCH 6/8] tosa: Use TYPE_TOSA_MISC_GPIO constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:50写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Andrzej Zaborowski > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/arm/tosa.c

Re: [PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:51写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: David Gibson > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/pci-host/ppce500.c | 2 +- > 1 file c

Re: [PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:48写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost >

Re: [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:47写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.o

Re: [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:46写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: David Gibson > Cc: Jason Wang > Cc: qemu-...@nongnu.org > Cc: qemu-devel@nongnu.org > --- > hw/net/fsl_etsec/etsec

Re: [PATCH 4/8] sclpconsole: Use TYPE_* constants

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:45写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: Thomas Huth > Cc: "Marc-André Lureau" > Cc: Pa

Re: [PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant

2020-08-26 Thread Li Qiang
Eduardo Habkost 于2020年8月27日周四 上午2:44写道: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Li Qiang > --- > Cc: Chris Wulff > Cc: Marek Vasut > Cc: qemu-devel@nongnu.org > --- > hw/intc/nios2_iic.c | 2 +- > 1 file changed, 1

Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

2020-08-26 Thread Rohit Shinde
I am just compiling with cflag set to -Wimplicit-fallthrough. I am using gcc. On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster wrote: > Rohit Shinde writes: > > > Added fallthrough comment on line 270 to prevent the compiler from > > throwing an error while compiling with the -Wimplicit-fallth

RE: [RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:19 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 09/34] Hexagon (t

RE: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:11 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 16/34] Hexagon (t

RE: [RFC PATCH v3 14/34] Hexagon (target/hexagon) instruction/packet decode

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:07 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 14/34] Hexagon (t

RE: [RFC PATCH v3 24/34] Hexagon (target/hexagon) opcode data structures

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:26 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 24/34] Hexagon (t

RE: [RFC PATCH v3 07/34] Hexagon (target/hexagon) scalar core helpers

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:17 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 07/34] Hexagon (t

RE: [RFC PATCH v3 10/34] Hexagon (target/hexagon) instruction and packet types

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:22 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: a...@rev.ng; riku.voi...@iki.fi; laur...@vivier.eu; phi...@redhat.com; > aleksandar.m.m...@gmail.com > Subject: Re: [RFC PATCH v3 10/34] Hexagon (t

RE: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 9:17 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 17/34] Hexagon (t

RE: [RFC PATCH v3 06/34] Hexagon (disas) disassembler

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 7:52 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 06/34] Hexagon (d

RE: [RFC PATCH v3 13/34] Hexagon (target/hexagon) register map

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:36 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 13/34] Hexagon (t

RE: [RFC PATCH v3 11/34] Hexagon (target/hexagon) register fields

2020-08-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 8:30 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 11/34] Hexagon (t

RE: [RFC PATCH v3 04/34] Hexagon (target/hexagon) scalar core definition

2020-08-26 Thread Taylor Simpson
Thanks for the feedback, Richard!! > -Original Message- > From: Richard Henderson > Sent: Wednesday, August 26, 2020 7:36 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject:

Re: [PATCH v2 2/2] linux-user: Add support for utimensat_time64() and semtimedop_time64()

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 15:58, Laurent Vivier a écrit : > Le 25/08/2020 à 16:23, Laurent Vivier a écrit : >> Le 25/08/2020 à 09:18, Laurent Vivier a écrit : >>> Le 25/08/2020 à 00:30, Filip Bozuta a écrit : This patch introduces functionality for following time64 syscalls: *utimensat_time64(

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-08-26 Thread Paul Zimmerman
Hmm, yes agreed. I started a 2-week holiday on Monday, I can work on this after I get back on Sept. 7 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892604 Title: qemu-system-arm: ../hw/usb/hcd-dwc

[REPORT] Nightly Performance Tests - Wednesday, August 26, 2020

2020-08-26 Thread Ahmed Karaman
Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Host Memory : 15.49 GB Start Time (UTC) : 2020-08-26 21:30:02 End Time (UTC) : 2020-08-26 22:03:25 Execution Time : 0:33:22.684015 Status : SUCCESS Note: Changes denoted by '-' are less than 0.01%. -

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 12:49 PM Eduardo Habkost wrote: > > On Tue, Aug 25, 2020 at 10:30:59AM -0700, Alistair Francis wrote: > > Reported-by: Eduardo Habkost > > Signed-off-by: Alistair Francis > > --- > > hw/core/register.c | 31 +-- > > 1 file changed, 13 insertio

Re: [RFC v4 00/70] support vector extension v1.0

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 11:13 AM Frank Chang wrote: > > On Thu, Aug 27, 2020 at 2:03 AM Alistair Francis wrote: >> >> On Wed, Aug 26, 2020 at 10:39 AM Frank Chang wrote: >> > >> > On Thu, Aug 27, 2020 at 12:56 AM Alistair Francis >> > wrote: >> >> >> >> On Tue, Aug 25, 2020 at 1:29 AM Frank Ch

Re: [PATCH 03/10] spapr: robustify NVLink2 NUMA node logic

2020-08-26 Thread Daniel Henrique Barboza
On 8/19/20 11:14 PM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:17PM -0300, Daniel Henrique Barboza wrote: NVLink2 GPUs are allocated in their own NUMA node, at maximum distance from every other resource in the board. The existing logic makes some assumptions that don't scale well: -

[PULL v5 04/12] hw/display/artist.c: fix out of bounds check

2020-08-26 Thread Helge Deller
From: Sven Schnelle Fix the following runtime warning with artist framebuffer: "write outside bounds: wants 1256x1023, max size 1280x1024" Reviewed-by: Richard Henderson Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 24 +++- 1 file cha

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 2:40 AM Philippe Mathieu-Daudé wrote: > > Le mar. 25 août 2020 19:42, Alistair Francis a > écrit : >> >> Reported-by: Eduardo Habkost >> Signed-off-by: Alistair Francis >> --- >> hw/core/register.c | 31 +-- >> 1 file changed, 13 insertions(

[PULL v5 09/12] hw/display/artist: Prevent out of VRAM buffer accesses

2020-08-26 Thread Helge Deller
Simplify various bounds checks by changing parameters like row and column numbers to become unsigned instead of signed. With that we can check if the calculated offset is bigger than the size of the VRAM region and bail out if not. Reported-by: LLVM libFuzzer Reported-by: Alexander Bulekov Buglin

[PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display"

2020-08-26 Thread Helge Deller
This reverts commit b0f6455feac97e41045ee394e11c24d92c370f6e. It's wrong. A line could even be a dot. Signed-off-by: Helge Deller --- hw/display/artist.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/display/artist.c b/hw/display/artist.c index 47de17b9e9..f37aa9eb49 100644 --- a/hw/d

[PULL v5 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

2020-08-26 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. Instead of passing an unsafe pointer to artist_rop8(), pass the vram_buffer and the offset. We can now check if the offset is in range before accessing it. We avoid: Program terminated with signa

Re: [PATCH 05/10] spapr: make ibm,max-associativity-domains scale with user input

2020-08-26 Thread Daniel Henrique Barboza
On 8/19/20 11:55 PM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:19PM -0300, Daniel Henrique Barboza wrote: The ibm,max-associativity-domains is considering that only a single associativity domain can exist in the same NUMA level. This is true today because we do not support any type of

[PULL v5 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run

2020-08-26 Thread Helge Deller
From: Philippe Mathieu-Daudé Invalid I/O writes can craft an offset out of the vram_buffer range. We avoid: Program terminated with signal SIGSEGV, Segmentation fault. 284 *dst &= ~plane_mask; (gdb) bt #0 0x55d5dccdc5c0 in artist_rop8 (s=0x55d5defee510, dst=0x7f8e84ed82

[PULL v5 12/12] hw/display/artist: Fix invalidation of lines near screen border

2020-08-26 Thread Helge Deller
From: Sven Schnelle If parts of the invalidated screen lines are outside of the VRAM buffer, the code skips the whole invalidate. This is incorrect when only parts of the buffer are invisble - which is the case when the mouse cursor is located near the screen border. Signed-off-by: Sven Schnelle

[PULL v5 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources

2020-08-26 Thread Helge Deller
The hppa_hardware.h file is shared with SeaBIOS. Sync it. Acked-by: Richard Henderson Signed-off-by: Helge Deller --- hw/hppa/hppa_hardware.h | 6 ++ hw/hppa/lasi.c | 2 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/hppa/hppa_hardware.h b/hw/hppa/hppa_hardwar

[PULL v5 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line()

2020-08-26 Thread Helge Deller
From: Sven Schnelle The old code didn't invalidate correctly when vertical lines were drawn. Fix this and move the invalidation out of the loop. Signed-off-by: Sven Schnelle Signed-off-by: Helge Deller --- hw/display/artist.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --g

[PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:

2020-08-26 Thread Helge Deller
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200727' into staging (2020-07-28 18:43:48 +0100) are available in the Git repository at: g...@github.com:hdeller/qemu-hppa.git tags/target-hppa-v3-pull-request for you to fetch changes up to 2f8cd515477edab1cbf38ecbdbfa2c

[PULL v5 05/12] hw/hppa/lasi: Don't abort on invalid IMR value

2020-08-26 Thread Helge Deller
NetBSD initializes the LASI IMR value with 0x to disable all LASI interrupts. This triggered an assert() and stopped the emulation. By replacing the check with a warning in the guest log we now allow NetBSD to boot again. Signed-off-by: Helge Deller --- hw/hppa/lasi.c | 8 ++-- 1 fi

[PULL v5 03/12] hw/hppa: Implement proper SeaBIOS version check

2020-08-26 Thread Helge Deller
It's important that the SeaBIOS hppa firmware is at least at a minimal level to ensure proper interaction between qemu and firmware. Implement a proper firmware version check by telling SeaBIOS via the fw_cfg interface which minimal SeaBIOS version is required by this running qemu instance. If the

[PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses

2020-08-26 Thread Helge Deller
Commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") broke the artist driver in a way that the dtwm window manager on HP-UX rendered wrong. Fixes: 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid") Sign

Re: [PULL v2 00/12] target-hppa fixes pull request v2

2020-08-26 Thread Peter Maydell
On Mon, 10 Aug 2020 at 14:24, Helge Deller wrote: > > Please pull from > https://github.com/hdeller/qemu-hppa.git target-hppa > to fix those bugs in target-hppa: > > * Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian > > * Fix the SeaBIOS-hppa firmware to boot NetBSD again > > * Fix m

Re: [PATCH 0/5] hw/avr: Start using the Clock API

2020-08-26 Thread Michael Rolnik
Tested-by: Michael Rolnik On Fri, Aug 14, 2020 at 7:39 PM Philippe Mathieu-Daudé wrote: > In this series we slowly start to use the recently added > Clock API in the AVR ATmega MCU. > > As the Clock Control Unit is not yet modelled, we simply > connect the XTAL sink to the UART and Timer source

Re: [PATCH 08/10] spapr: introduce SpaprMachineClass::numa_assoc_domains

2020-08-26 Thread Daniel Henrique Barboza
On 8/20/20 1:26 AM, David Gibson wrote: On Fri, Aug 14, 2020 at 05:54:22PM -0300, Daniel Henrique Barboza wrote: We can't use the input from machine->numa_state->nodes directly in the pSeries machine because PAPR does not work with raw distance values, like ACPI SLIT does. We need to determin

Help with usb-host hostdevice property

2020-08-26 Thread Diego Viola
Hi, I'm trying to use the new usb-host hostdevice property that was added here: https://git.qemu.org/?p=qemu.git;a=commit;h=9f815e83e983d247a3cd67579d2d9c1765adc644 This is the command line that I am using: qemu-system-x86_64 -enable-kvm -hda arch-zoom.qcow2 -m 4G -device qemu-xhci,id=xhci -dev

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Eduardo Habkost
On Tue, Aug 25, 2020 at 10:30:59AM -0700, Alistair Francis wrote: > Reported-by: Eduardo Habkost > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 31 +-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/r

Re: [PATCH 1/4] sev/i386: Add initial support for SEV-ES

2020-08-26 Thread Tom Lendacky
On 8/26/20 2:07 PM, Connor Kuehl wrote: On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV i

Re: [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Alistair Francis
On Wed, Aug 26, 2020 at 11:47 AM Eduardo Habkost wrote: > > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Alistair Francis Alistair > --- > Cc: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: qemu-...@no

Re: [PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Peter Maydell
On Wed, 26 Aug 2020 at 20:03, Paolo Bonzini wrote: > > Otherwise, dollars (such as in the special $ORIGIN rpath) are > eaten by Make. Incidentally, why are we using rpath anyway? I'm pretty sure the old build system didn't need it, and it's one of those features I have mentally filed away under "

Re: [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES

2020-08-26 Thread Tom Lendacky
On 8/26/20 2:07 PM, Connor Kuehl wrote: On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the A

Re: [PATCH 3/4] sev/i386: Don't allow a system reset under an SEV-ES guest

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky An SEV-ES guest does not allow register state to be altered once it has been measured. When a SEV-ES guest issues a reboot command, Qemu will reset the vCPU state and resume the guest. This will cause failures under SEV-ES, so prevent t

Re: [PATCH 4/4] sev/i386: Enable an SEV-ES guest based on SEV policy

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Update the sev_es_enabled() function return value to be based on the SEV policy that has been specified. SEV-ES is enabled if SEV is enabled and the SEV-ES policy bit is set in the policy object. Signed-off-by: Tom Lendacky --- targ

Re: [PATCH 2/4] sev/i386: Allow AP booting under SEV-ES

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky When SEV-ES is enabled, it is not possible modify the guests register state after it has been initially created, encrypted and measured. Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the hypervisor cannot emulate

Re: [PATCH 1/4] sev/i386: Add initial support for SEV-ES

2020-08-26 Thread Connor Kuehl
On 8/25/20 2:05 PM, Tom Lendacky wrote: From: Tom Lendacky Provide initial support for SEV-ES. This includes creating a function to indicate the guest is an SEV-ES guest (which will return false until all support is in place), performing the proper SEV initialization and ensuring that the guest

[PATCH v2] configure: add --ninja option

2020-08-26 Thread Paolo Bonzini
On Windows it is not possible to invoke a Python script as $NINJA. If ninja is present use it directly, while if it is not we can keep using ninjatool. Reported-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- configure | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-)

[PATCH] ninjatool: quote dollars in variables

2020-08-26 Thread Paolo Bonzini
Otherwise, dollars (such as in the special $ORIGIN rpath) are eaten by Make. Reported-by: Laurent Vivier Signed-off-by: Paolo Bonzini --- scripts/ninjatool.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/ninjatool.py b/scripts/ninjatool.py index cc77d51aa8..c33e

Re: [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Edgar E. Iglesias
On Wed, Aug 26, 2020 at 02:43:31PM -0400, Eduardo Habkost wrote: > This will make future conversion to use OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost Reviewed-by: Edgar E. Iglesias > --- > Cc: Alistair Francis > Cc: "Edgar E. Iglesias" > Cc: Peter Maydell > Cc: qemu-...@non

[PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: David Gibson Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/pci-host/ppce500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/ppce500.c b/hw/pci-host

[PATCH 6/8] tosa: Use TYPE_TOSA_MISC_GPIO constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/tosa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/tosa.c b/hw

[PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: qemu-devel@nongnu.org --- hw/i386/amd_iommu.c | 2 +- 1 file changed, 1 insertion(

[PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/arm/xlnx-zcu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

RE: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode

2020-08-26 Thread Babu Moger
> -Original Message- > From: Dr. David Alan Gilbert > Sent: Wednesday, August 26, 2020 1:34 PM > To: Moger, Babu > Cc: Igor Mammedov ; Daniel P. Berrangé > ; ehabk...@redhat.com; m...@redhat.com; Michal > Privoznik ; qemu-devel@nongnu.org; > pbonz...@redhat.com; r...@twiddle.net > Subj

[PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: David Gibson Cc: Jason Wang Cc: qemu-...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/net/fsl_etsec/etsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/fsl_etsec

[PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Chris Wulff Cc: Marek Vasut Cc: qemu-devel@nongnu.org --- hw/intc/nios2_iic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/nios2_iic.c b/hw/intc/nios2_iic.c ind

[PATCH 4/8] sclpconsole: Use TYPE_* constants

2020-08-26 Thread Eduardo Habkost
This will make future conversion to use OBJECT_DECLARE* easier. Signed-off-by: Eduardo Habkost --- Cc: Cornelia Huck Cc: Halil Pasic Cc: Christian Borntraeger Cc: Thomas Huth Cc: "Marc-André Lureau" Cc: Paolo Bonzini Cc: qemu-s3...@nongnu.org Cc: qemu-devel@nongnu.org --- hw/char/sclpconso

  1   2   3   4   5   >