Does memory hotplug work when VFIO device already attached

Hi, I am trying do memory hotplug(add new memory DIMM) in an VM attached with VFIO device (host running with 4.9 kernel). What I observed is weird: If my original VM is 10G (already occupies 10G RSS at host), and hotplug add 30G DIMM to qemu, the RSS of qemu keeps growing until nearly 39G and su

Re: [PATCH Kernel v21 0/8] Add UAPIs to support migration for VFIO devices

On 5/16/2020 5:17 AM, Tian, Kevin wrote: Hi, Kirti, Will you send out a new version in Qemu side, or previous v16 still applies? v16 doesn't work as now migration capability is added to iommu info chain. I'll send out new version of QEMU side tomorrow, though I'm not able to update QEMU s

Re: [PATCH Kernel v21 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1589656095; bh=+tZ0dBYIJDY6PHAfvMYygljkbJgDRKM2mXYJTiJ5LAU=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Ori

Re: [PATCH v3 18/18] MAINTAINERS: Change Aleksandar Rikalo's email address

On 5/16/20 7:45 PM, Aleksandar Markovic wrote: Aleksandar Rikalo want to use a different email address "wants"? from now on. Signed-off-by: Aleksandar Markovic --- .mailmap| 3 ++- MAINTAINERS | 12 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.mailma

Re: [PATCH v3 17/18] hw/mips: Add some logging for bad register offset cases

On 5/16/20 7:45 PM, Aleksandar Markovic wrote: Log the cases where a guest attempts read or write using bad register offset. Signed-off-by: Aleksandar Markovic CC: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --gi

[PATCH v3 18/18] MAINTAINERS: Change Aleksandar Rikalo's email address

Aleksandar Rikalo want to use a different email address from now on. Signed-off-by: Aleksandar Markovic --- .mailmap| 3 ++- MAINTAINERS | 12 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.mailmap b/.mailmap index 6412067bde..e3628c7a66 100644 --- a/.mailmap +

[PATCH v3 16/18] target/mips: fpu: Refactor conversion from ieee to mips exception flags

The original coversion function is used for regular and MSA floating point instructions handling. Since there are some nuanced differences between regular and MSA floatin point excetion handling, provide two instances of the conversion function, rather than just a common one. Inline both of these f

[PATCH v3 15/18] target/mips: fpu: Name better paired-single variables

Use consistently 'l' and 'h' for low and high halves. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 56ba49104

[PATCH v3 17/18] hw/mips: Add some logging for bad register offset cases

Log the cases where a guest attempts read or write using bad register offset. Signed-off-by: Aleksandar Markovic CC: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c ind

[PATCH v3 14/18] target/mips: fpu: Remove now unused FLOAT_RINT macro

After demacroing RINT., this macro is not needed anymore. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 13 - 1 file changed, 13 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index dae1331f23..56ba49104e 100644 --- a/target/mips/fp

[PATCH v3 12/18] target/mips: fpu: Remove now unused FLOAT_CLASS macro

After demacroing CLASS., this macro is not needed anymore. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index b3903f5357..e227e53f70

[PATCH v3 13/18] target/mips: fpu: Demacro RINT.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/target/mips/fpu_helper.

[PATCH v3 11/18] target/mips: fpu: Demacro CLASS.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 70 ++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/tar

[PATCH v3 07/18] target/mips: fpu: Demacro MSUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/targ

[PATCH v3 10/18] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros

After demacroing ., these macros are not needed anymore. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 50 1 file changed, 50 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 927bac24ac..e8e50e4bc0 1

[PATCH v3 09/18] target/mips: fpu: Demacro NMSUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/targ

[PATCH v3 01/18] target/mips: fpu: Demacro ADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/target

[PATCH v3 05/18] target/mips: fpu: Remove now unused macro FLOAT_BINOP

After demacroing ., this macro is not needed anymore. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c index 2759c9989d..a3a39681f8 10064

[PATCH v3 08/18] target/mips: fpu: Demacro NMADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/targ

[PATCH v3 06/18] target/mips: fpu: Demacro MADD.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 41 +++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/targ

[PATCH v3 02/18] target/mips: fpu: Demacro SUB.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/target/

[PATCH v3 04/18] target/mips: fpu: Demacro DIV.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/target/

[PATCH v3 00/18] target/mips: FPU and other cleanups and improvements

This series contains mostly cosmetic FPU cleanups aimed to make source code recognition easier for tools like gdb, gcov, calgrind, and others. There is also a patch that refactors conversion from ieee to mips fp exception flags. This refactoring will improve the performance of almost all fp-relate

[PATCH v3 03/18] target/mips: fpu: Demacro MUL.

This is just a cosmetic change to enable tools like gcov, gdb, callgrind, etc. to better display involved source code. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/target/

Re: [PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

On 5/16/20 5:58 AM, Peter Maydell wrote: > On Sat, 16 May 2020 at 05:12, Richard Henderson > wrote: >> >> On 5/15/20 2:25 PM, Peter Maydell wrote: You also need to call arm_rebuild_hflags() after modifying CPSR_E otherwise the change doesn't take effect. >>> >>> Hmm. I was expecting cpsr

Re: [PATCH v2] NetBSD/arm build fix

On 5/16/20 8:41 AM, Nick Hudson wrote: > Fix building on NetBSD/arm by extracting the FSR value from the > correct siginfo_t field. > > Signed-off-by: Nick Hudson > --- > accel/tcg/user-exec.c | 16 +--- > 1 file changed, 13 insertions(+), 3 deletions(-) Reviewed-by: Richard Henders

[PATCH v2] NetBSD/arm build fix

Fix building on NetBSD/arm by extracting the FSR value from the correct siginfo_t field. Signed-off-by: Nick Hudson --- accel/tcg/user-exec.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c index 52359949df..bc39

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

I think this PDF describes the same OTC controller as the rpi one: http://rockchip.fr/RK312X%20TRM/chapter-26-usb-otg-2-0.pdf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1772165 Title: arm raspi

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

On Sat, 16 May 2020, Alexander Bulekov wrote: On 200516 1513, BALATON Zoltan wrote: According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #1878134. Signed-off-by: BALATON Zoltan ---

Patch to fix missing Exec field in qemu.desktop

Sent with ProtonMail Secure Email. From 207a1a34accdc5b563d29484292829a4193c35f8 Mon Sep 17 00:00:00 2001 From: Victor Lavaud Date: Sat, 16 May 2020 16:33:00 +0200 Subject: [PATCH] Fix missing Exec field in qemu.desktop Signed-off-by: Victor Lavaud --- ui/qemu.desktop | 1 + 1 file changed,

Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

On Sat, May 16, 2020 at 01:30:23PM +0200, Greg Kurz wrote: > Applied to 9p-next with R-b and Fixes tags, thanks. Great! Thanks for the feedback everyone. Cheers, - Dan signature.asc Description: PGP signature

Re: [PATCH] ati-vga: Do not allow unaligned access via index register

On 200516 1513, BALATON Zoltan wrote: > According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so > unaligned access via this register should not be possible. > This also fixes problems reported in bug #1878134. > > Signed-off-by: BALATON Zoltan > --- Hi Zoltan, I applied this patch and

[Bug 1878136] Re: Assertion failures in ati_reg_read_offs/ati_reg_write_offs

*** This bug is a duplicate of bug 1878134 *** https://bugs.launchpad.net/bugs/1878134 ** This bug has been marked a duplicate of bug 1878134 Assertion failures in ati_reg_read_offs/ati_reg_write_offs -- You received this bug notification because you are a member of qemu- devel-ml, which

[PATCH] virtio-crypto: Convert DPRINTF to trace event

From: Hou Weiying Signed-off-by: Hou Weiying --- hw/virtio/trace-events| 12 hw/virtio/virtio-crypto.c | 26 ++ include/hw/virtio/virtio-crypto.h | 11 --- 3 files changed, 26 insertions(+), 23 deletions(-) diff --git a/hw/virtio

[PATCH] virtio-crypto: Convert DPRINTF to trace event

From: Hou Weiying Signed-off-by: Hou Weiying --- hw/virtio/trace-events| 12 hw/virtio/virtio-crypto.c | 26 ++ include/hw/virtio/virtio-crypto.h | 11 --- 3 files changed, 26 insertions(+), 23 deletions(-) diff --git a/hw/virtio

Re: [Bug 1878134] [NEW] Assertion failures in ati_reg_read_offs/ati_reg_write_offs

Sent patch that should fix this: https://patchew.org/QEMU/20200516132352.39e93745...@zero.eik.bme.hu/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1878134 Title: Assertion failures in ati_reg_read

[PATCH] ati-vga: Do not allow unaligned access via index register

According to docs bits 1 and 0 of MM_INDEX are hard coded to 0 so unaligned access via this register should not be possible. This also fixes problems reported in bug #1878134. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

Re: [PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

On Sat, 16 May 2020 at 05:12, Richard Henderson wrote: > > On 5/15/20 2:25 PM, Peter Maydell wrote: > >> You also need to call arm_rebuild_hflags() after modifying CPSR_E > >> otherwise the change doesn't take effect. > > > > Hmm. I was expecting cpsr_write() to take care of that if we > > updated

Re: [PATCH v6 00/16] acpi: i386 tweaks

Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kra...@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TE

Re: [PATCH 0/4] RISC-V multi-socket support

Patchew URL: https://patchew.org/QEMU/20200516063746.18296-1-anup.pa...@wdc.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200516063746.18296-1-anup.pa...@wdc.com Subject: [PATCH 0/4] RISC-V multi-socket support Type: series

[Bug 1877384] Re: 9pfs file create with mapped-xattr can fail on overlayfs

Yes, that compile error with QEMU + recent kernel headers is a bit annoying, and AFAICS it is not fixed in Debian yet. Would you mind writing a test case for this bug that you fixed, to prevent this accidentally being broken in future again? Please note that 9pfs is currently only been taken care

Re: Null-pointer dereference through virtio-balloon

+David (virtio-balloon maintainer) On Mon, May 11, 2020 at 6:42 AM Alexander Bulekov wrote: > > Hello, > While fuzzing, I found an input that triggers a null-ptr dereference in > aio_bh_enqueue, through virtio-balloon. Based on the stacktrace below, > I am not positive that this is specific to vi

Re: [Bug 1878134] [NEW] Assertion failures in ati_reg_read_offs/ati_reg_write_offs

On Fri, 15 May 2020, Launchpad Bug Tracker wrote: > You have been subscribed to a public bug by Philippe Mathieu-Daudé (philmd): > > Hello, > While fuzzing, I found inputs that trigger assertion failures in > ati_reg_read_offs/ati_reg_write_offs > > uint32_t extract32(uint32_t, int, int): Assertion

Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

On Fri, 15 May 2020 20:30:15 + Dan Robertson wrote: > linux/limits.h should be included for the XATTR_SIZE_MAX definition used > by v9fs_xattrcreate. > > Signed-off-by: Dan Robertson > --- Applied to 9p-next with R-b and Fixes tags, thanks. > hw/9pfs/9p.c | 1 + > 1 file changed, 1 inser

Re: [PATCH 00/10] softfloat: misc cleanups

Patchew URL: https://patchew.org/QEMU/20200515190153.6017-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515190153.6017-1-richard.hender...@linaro.org Subject: [PATCH 00/10] softfloat: misc clea

Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

On Freitag, 15. Mai 2020 22:30:15 CEST Dan Robertson wrote: > linux/limits.h should be included for the XATTR_SIZE_MAX definition used > by v9fs_xattrcreate. > > Signed-off-by: Dan Robertson > --- > hw/9pfs/9p.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

On Sat, May 16, 2020 at 3:51 AM Alistair Francis wrote: > > On Thu, May 14, 2020 at 9:54 PM Bin Meng wrote: > > > > On Fri, May 15, 2020 at 5:51 AM Alistair Francis > > wrote: > > > > > > On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé > > > wrote: > > > > > > > > On 5/7/20 9:13 PM, Al

Re: [PATCH v6 00/16] acpi: i386 tweaks

Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kra...@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TE

[PATCH v2 05/11] ui/gtk: remove unused variable ignore_keys

Since the removal of GTK2 code in commit 89d85cde75 the code around ignore_keys is unused. See commit 1a01716a30 "gtk: Avoid accel key leakage into guest on console switch" why it was only needed for GTK2. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- ui/gtk.c | 9 --

[PATCH v2 09/11] ui/gtk: don't pass on win keys without keyboard grab

Without keyboard grab Windows currently handles the two win keys and the key events are also sent to the guest. This is undesir- able. Only one program should handle key events. This patch ap- plies commit c68f74b02e "win32: do not handle win keys when the keyboard is not grabbed" from project spic

[PATCH v2 11/11] ui: increase min required GTK version to 3.22.0

Based on a mail on the qemu-devel mailing list at https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg02909.html and some internet research the GTK3 versions on supported platforms are: RHEL-7.4: 3.22.10 RHEL-7.5: 3.22.26 Debian (Stretch): 3.22.11 Debian (Buster): 3.24.5

[PATCH v2 07/11] ui/sdl2: start in full screen with grab enabled

QEMU with SDL 1.2 display used to enable keyboard and mouse grab- bing when started in full screen. The SDL 2.0 code tries to do the same but fails to enable grabbing because sdl_grab_start(0) returns early. To do it's work the sdl_grab_start() function needs a pointer to a sdl2_console structure.

[PATCH v2 10/11] ui/gtk: use native keyboard scancodes on Windows

Since GTK 3.22 the function gdk_event_get_scancode() is available. On Windows this function returns keyboard scancodes and some extended flags. These raw keyboard scancodes are much better suited for this use case than the half-cooked win32 virtual-key codes because scancodes report the key positio

[PATCH v2 03/11] ui/gkt: release all keys on grab-broken-event

There is no way to grab the Ctrl-Alt-Del key combination on Windows. This key combination will leave all three keys in a stuck condition. This patch uses the grab-broken-event to release the keys. Signed-off-by: Volker Rümelin --- ui/gtk.c | 21 + 1 file changed, 21 insertion

[PATCH v2 06/11] ui/sdl2: fix handling of AltGr key on Windows

Wire up the keyboard hooking code on Windows to fix the AltGr key and improve keyboard grabbing. Signed-off-by: Volker Rümelin --- ui/sdl2.c | 24 1 file changed, 24 insertions(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 61c7956da3..79c1ea29d2 100644 --- a/ui/sdl2.c +++

[PATCH v2 04/11] ui/gtk: remove unused code

This code was last used before commit 2ec78706d1 "ui: convert GTK and SDL1 frontends to keycodemapdb". Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- ui/gtk.c | 9 - 1 file changed, 9 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 655b26de38..0e9503a0d1 1006

[PATCH v2 01/11] ui/win32-kbd-hook: handle AltGr in a hook procedure

Import win32 keyboard hooking code from project spice-gtk. This patch removes the extra left control key up/down input events inserted by Windows for the right alt key up/down input events with international keyboard layouts. Additionally there's some code to grab the keyboard. The next patches wi

[PATCH v2 08/11] ui/sdl2-input: use trace-events to debug key events

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- ui/sdl2-input.c | 3 +++ ui/trace-events | 3 +++ 2 files changed, 6 insertions(+) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index 1f9fe831b3..f068382209 100644 --- a/ui/sdl2-input.c +++ b/ui/sdl2-input.c @@ -27,6 +27,7

[PATCH v2 02/11] ui/gtk: fix handling of AltGr key on Windows

Wire up the keyboard hooking code on Windows to fix the AltGr key and improve keyboard grabbing. Signed-off-by: Volker Rümelin --- ui/gtk.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 83f2f5d49b..a0b10a1403 100644 -

[PATCH v2 00/11] Patches for ui/gtk and ui/sdl

It's rather difficult to test qemu patches in guests on Windows with important keys missing. These patches mainly fix the guest keyboard on Windows. With best regards, Volker v2: - ui/win32-kbd-hook: handle AltGr in a hook procedure   The boilerplate now mentions where the code comes from.   Stu