[PATCH 4/4] hw/riscv: virt: Allow creating multiple sockets

We extend RISC-V virt machine to allow creating a multi-socket machine. Each RISC-V virt machine socket is a set of HARTs, a CLINT instance, and a PLIC instance. Other peripherals are shared between all RISC-V virt machine sockets. We also update RISC-V virt machine device tree to treat each socket

Re: [PATCH v2 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

Patchew URL: https://patchew.org/QEMU/20200515222032.18838-1-wall...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515222032.18838-1-wall...@linux.ibm.com Subject: [PATCH v2 0/8] s390: Extended-Length SCCB & DI

[PATCH 0/4] RISC-V multi-socket support

This series adds multi-socket support for RISC-V virt machine and RISC-V spike machine. The multi-socket support will help us improve various RISC-V operating systems, firmwares, and bootloader to support RISC-V NUMA systems. These patch can be found in riscv_multi_socket_v1 branch at: https://git

[PATCH 1/4] hw/riscv: Allow creating multiple instances of CLINT

We extend CLINT emulation to allow multiple instances of CLINT in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from CLINT emulation. Signed-off-by: Anup Patel --- hw/riscv/sifive_clint.c | 20 hw/riscv/sifive_e.c | 2 +-

[PATCH 3/4] hw/riscv: Allow creating multiple instances of PLIC

We extend PLIC emulation to allow multiple instances of PLIC in a QEMU RISC-V machine. To achieve this, we remove first HART id zero assumption from PLIC emulation. Signed-off-by: Anup Patel --- hw/riscv/sifive_e.c| 2 +- hw/riscv/sifive_plic.c | 24 +---

[PATCH 2/4] hw/riscv: spike: Allow creating multiple sockets

We extend RISC-V spike machine to allow creating a multi-socket machine. Each RISC-V spike machine socket is a set of HARTs and a CLINT instance. Other peripherals are shared between all RISC-V spike machine sockets. We also update RISC-V spike machine device tree to treat each socket as a NUMA nod

Re: [PULL 0/4] softfloat patch queue

Patchew URL: https://patchew.org/QEMU/20200515184722.31182-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515184722.31182-1-richard.hender...@linaro.org Subject: [PULL 0/4] softfloat patch queue

Re: [PATCH 10/10] softfloat: Return bool from all classification predicates

On 5/15/20 9:01 PM, Richard Henderson wrote: This includes *_is_any_nan, *_is_neg, *_is_inf, etc. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h| 66 +- fpu/softfloat-specialize.inc.c | 16 - 2 files changed, 41 insertions(+), 41

Re: [PATCH 05/10] softfloat: Name compare relation enum

On 5/15/20 9:01 PM, Richard Henderson wrote: Give the previously unnamed enum a typedef name. Use it in the prototypes of compare functions. Use it to hold the results of the compare functions. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 25 +++--

Re: [PATCH 04/10] softfloat: Name rounding mode enum

On 5/15/20 9:01 PM, Richard Henderson wrote: Give the previously unnamed enum a typedef name. Use the packed attribute so that we do not affect the layout of the float_status struct. Use it in the prototypes of relevant functions. Adjust switch statements as necessary to avoid compiler warning

Re: [PATCH 02/10] softfloat: Replace flag with bool

On 5/15/20 9:01 PM, Richard Henderson wrote: We have had this on the to-do list for quite some time. Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 14 +-- include/fpu/softfloat-macros.h | 24 ++-- include/fpu/softfloat-types.h | 14 +-- include/fpu/softfloat.

Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

On 5/15/20 10:30 PM, Dan Robertson wrote: linux/limits.h should be included for the XATTR_SIZE_MAX definition used Maybe rewrite as in subject & description (maintainer could do it for you). by v9fs_xattrcreate. Fixes: 3b79ef2cf48 Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: D

Re: [PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

On 5/15/20 11:26 PM, Richard Henderson wrote: On 5/15/20 11:50 AM, Peter Maydell wrote: Using the MSR instruction to write to CPSR.E is deprecated, but it is required to work from any mode including unprivileged code. We were incorrectly forbidding usermode code from writing it because CPSR_USE

Re: [PATCH v4 0/2] Makefile: libfdt: build only the strict necessary

On Fri, May 15, 2020 at 09:56:25AM +0200, Claudio Fontana wrote: > On 5/15/20 9:50 AM, Philippe Mathieu-Daudé wrote: > > Hi Claudio, > > > > On 5/14/20 9:38 PM, Claudio Fontana wrote: > >> v3 -> v4: NB! only useful when updating to latest dtc (not in QEMU yet) > >> > >> * changed the approach to l

Re: [PATCH v2 0/6] target/ppc: Various clean-up and fixes for radix64

On Fri, May 15, 2020 at 08:58:07AM +0200, Greg Kurz wrote: > On Thu, 14 May 2020 16:52:49 +1000 > David Gibson wrote: > > > On Thu, May 14, 2020 at 12:56:42AM +0200, Greg Kurz wrote: > > > First three patches of this series are simple cleanups. The other > > > ones fix some regressions introduced

Re: [PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

On 5/15/20 2:25 PM, Peter Maydell wrote: >> You also need to call arm_rebuild_hflags() after modifying CPSR_E >> otherwise the change doesn't take effect. > > Hmm. I was expecting cpsr_write() to take care of that if we > updated a cpsr flag that was in the hflags, but it looks like > the rebuild_

Re: [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default

Patchew URL: https://patchew.org/QEMU/20200515170804.5707-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default

Patchew URL: https://patchew.org/QEMU/20200515170804.5707-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v6 3/3] qemu-options: updates for abstract unix sockets

在 2020/5/16 上午11:13, xiaoqiang zhao 写道: add options documents changes for -chardev Signed-off-by: xiaoqiang zhao Reviewed-by: Daniel P. Berrangé --- qemu-options.hx | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e2dca8a4e9

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

Hi, Dima. This abort is what I have mentioned in my previous email. I have triggered this crash without any fix a week ago. And I have written a test patch to let vhost_log_global_start return int and propagate the error to up layer. However, my change is a little large, because the origin callback

[PATCH v6 2/3] tests/util-sockets: add abstract unix socket cases

add cases to test tight and non-tight for abstract address type Signed-off-by: xiaoqiang zhao Reviewed-by: Daniel P. Berrangé --- tests/test-util-sockets.c | 92 +++ 1 file changed, 92 insertions(+) diff --git a/tests/test-util-sockets.c b/tests/test-util-so

[PATCH v6 3/3] qemu-options: updates for abstract unix sockets

add options documents changes for -chardev Signed-off-by: xiaoqiang zhao Reviewed-by: Daniel P. Berrangé --- qemu-options.hx | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e2dca8a4e9..4ee7e6c772 100644 --- a/qemu-options.hx ++

[PATCH v6 1/3] qemu-sockets: add abstract UNIX domain socket support

unix_listen/connect_saddr now support abstract address types two aditional BOOL switches are introduced: tight: whether to set @addrlen to the minimal string length, or the maximum sun_path length. default is TRUE abstract: whether we use abstract address. default is FALSE cli example: -mo

[PATCH v6 0/3] qemu-sockets: add abstract UNIX domain socket support

qemu does not support abstract UNIX domain socket address. Add this ability to make qemu handy when abstract address is needed. Changes since v5: * rebase on master * refine document statement v4 -> v5: * fix typo and coding style problems v3 -> v4: * rebase on master * refine qapi document s

Re: [PATCH v4 3/3] qemu-options: updates for abstract unix sockets

在 2020/5/16 上午1:37, Eric Blake 写道: On 5/14/20 11:32 PM, xiaoqiang zhao wrote: add options documents changes for -chardev Signed-off-by: xiaoqiang zhao Reviewed-by: Daniel P. Berrangé ---   qemu-options.hx | 9 +++--   1 file changed, 7 insertions(+), 2 deletions(-) I'd suggest listing 'a

Re: [PATCH 10/10] target/arm: Convert Neon one-register-and-immediate insns to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c > index f27fe769f85..f4eeb84541f 100644 > --- a/target/arm/translate-neon.inc.c > +++ b/target/arm/translate-neon.inc.c > @@ -1821,3 +1821,154 @@ DO_FP_2SH(VCVT_SF, gen_helper_v

Re: [PATCH 09/10] target/arm: Convert VCVT fixed-point ops to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > +# VCVT fixed<->float conversions > +# TODO: FP16 fixed<->float conversions are opc==0b1100 and 0b1101 > +# We use size=0 for fp32 and size=1 for fp16 to match the 3-same encodings. > +VCVT_SF_2sh 001 0 1 . 1 shift:5 1110 0 . . 1 \ >

Re: [PATCH 08/10] target/arm: Convert Neon VSHLL, VMOVL to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the VSHLL and VMOVL insns from the 2-reg-shift group > to decodetree. Since the loop always has two passes, we unroll > it to avoid the awkward reassignment of one TCGv to another. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.deco

Re: [PATCH 07/10] target/arm: Convert Neon narrowing shifts with op==9 to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the remaining Neon narrowing shifts to decodetree: > * VQSHRN > * VQRSHRN > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 32 ++ > target/arm/translate-neon.inc.c | 15 + > target/arm/translate.c

Re: [PATCH 06/10] target/arm: Convert Neon narrowing shifts with op==8 to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the Neon narrowing shifts where op==8 to decodetree: > * VSHRN > * VRSHRN > * VQSHRUN > * VQRSHRUN > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 32 ++ > target/arm/translate-neon.inc.c | 168 +++

Re: [PATCH v2 0/3] s390x: improve documentation

Patchew URL: https://patchew.org/QEMU/20200515151518.83950-1-coh...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515151518.83950-1-coh...@redhat.com Subject: [PATCH v2 0/3] s390x: improve documentation Type: serie

[PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

linux/limits.h should be included for the XATTR_SIZE_MAX definition used by v9fs_xattrcreate. Signed-off-by: Dan Robertson --- hw/9pfs/9p.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index a2a14b5979..68c2df7333 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@

[PATCH 0/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX

When compliling qemu with `--enable-virtfs` and musl libc, XATTR_SIZE_MAX is undeclared in v9fs_xattrcreate. Things compile fine with glibc as linux/limits.h is indirectly included via dirent.h. Dan Robertson (1): 9pfs: include linux/limits.h for XATTR_SIZE_MAX hw/9pfs/9p.c | 1 + 1 file chang

Re: [PATCH v6 00/16] acpi: i386 tweaks

Patchew URL: https://patchew.org/QEMU/20200515150421.25479-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515150421.25479-1-kra...@redhat.com Subject: [PATCH v6 00/16] acpi: i386 tweaks Type: series === TE

RE: [PATCH Kernel v21 0/8] Add UAPIs to support migration for VFIO devices

Hi, Kirti, Will you send out a new version in Qemu side, or previous v16 still applies? Thanks Kevin > From: Kirti Wankhede > Sent: Saturday, May 16, 2020 5:13 AM > > Hi, > > This patch set adds: > * IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with > respect to IOMMU container rat

Re: [PATCH v2 5/5] scripts/coverity-scan: Remove flex/bison packages

On 5/15/20 6:30 PM, Philippe Mathieu-Daudé wrote: > QEMU does not use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/coverity-scan/coverity-scan.docker | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/scripts/coverity-scan/coverity-scan.docker > b/scrip

Re: [PATCH v2 1/5] tests/docker: Remove flex/bison packages

On 5/15/20 6:30 PM, Philippe Mathieu-Daudé wrote: > QEMU does not use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: use 'does not' (Claudio) > --- > tests/docker/dockerfiles/centos7.docker | 2 -- > tests/docker/dockerfiles/centos8.docker | 2

Re: [PATCH v2 2/5] tests/vm: Remove flex/bison packages

On 5/15/20 6:30 PM, Philippe Mathieu-Daudé wrote: > QEMU does not use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: use 'does not', removed bison in OpenBSD VM (Claudio) > --- > tests/vm/fedora | 1 - > tests/vm/freebsd | 1 - > tests/vm/netbsd | 1 - >

Re: [PATCH 05/10] target/arm: Convert VQSHLU, VQSHL 2-reg-shift insns to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the VQSHLU and QVSHL 2-reg-shift insns to decodetree. > These are the last of the simple shift-by-immediate insns. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 27 > target/arm/translate-neon.inc.c | 108 +

Re: [PATCH 04/10] target/arm: Convert Neon VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree. > (These are the last instructions in the group that are vectorized; > the rest all require looping over each element.) > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.dec

Re: [PATCH 03/10] target/arm: Convert Neon VSHR 2-reg-shift insns to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > +VSHR_S_2sh 001 0 1 . .. 1 . . 1 \ > + @2reg_shift size=3 shift=%neon_rshift_i6 > +VSHR_S_2sh 001 0 1 . 1 . 0 . . 1 \ > + @2reg_shift size=2 shift=%neon_rs

Re: [PATCH 03/10] target/arm: Convert Neon VSHR 2-reg-shift insns to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the VSHR 2-reg-shift insns to decodetree. > > Note that unlike the legacy decoder, we present the right shift > amount to the trans_ function as a positive integer. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 24 +

Re: [PATCH Kernel v21 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

On Sat, 16 May 2020 02:43:20 +0530 Kirti Wankhede wrote: > VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: > - Start dirty pages tracking while migration is active > - Stop dirty pages tracking. > - Get dirty pages bitmap. Its user space application's responsibility to > copy content of

[PATCH v2 1/8] s390/sclp: get machine once during read scp/cpu info

Functions within read scp/cpu info will need access to the machine state. Let's make a call to retrieve the machine state once and pass the appropriate data to the respective functions. Signed-off-by: Collin Walling --- hw/s390x/sclp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH v2 4/8] s390/sclp: read sccb from mem based on sccb length

The header contains the actual length of the SCCB. Instead of using a static 4K size, let's allow for a variable size determined by the value set in the header. The proper checks are already in place to ensure the SCCB length is sufficent to store a full response and that the length does not cross

[PATCH v2 3/8] s390/sclp: rework sclp boundary and length checks

Rework the SCLP boundary check to account for different SCLP commands (eventually) allowing different boundary sizes. Move the length check code into a separate function, and introduce a new function to determine the length of the read SCP data (i.e. the size from the start of the struct to where

[PATCH v2 6/8] s390/sclp: add extended-length sccb support for kvm guest

As more features and facilities are added to the Read SCP Info (RSCPI) response, more space is required to store them. The space used to store these new features intrudes on the space originally used to store CPU entries. This means as more features and facilities are added to the RSCPI response, l

[PATCH v2 5/8] s390/sclp: use cpu offset to locate cpu entries

The start of the CPU entry region in the Read SCP Info response data is denoted by the offset_cpu field. As such, QEMU needs to begin creating entries at this address. Note that the length of the Read SCP Info data (data_len) denotes the same value as the cpu offset. This is in preparation of when

[PATCH v2 7/8] s390/kvm: header sync for diag318

Signed-off-by: Collin Walling --- linux-headers/asm-s390/kvm.h | 4 1 file changed, 4 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 0138ccb0d8..3d85817ec2 100644 --- a/linux-headers/asm-s390/kvm.h +++ b/linux-headers/asm-s390/kvm.h @@ -74,6 +74

[PATCH v2 0/8] s390: Extended-Length SCCB & DIAGNOSE 0x318

Changelog: v2 • QEMU now handles the instruction call - as such, the "enable diag 318" IOCTL has been removed • patch #1 now changes the read scp/cpu info functions to retrieve the machine state once - as such, I have not added any ack's or r-bs since this

[PATCH v2 2/8] s390/sclp: check sccb len before filling in data

The SCCB must be checked for a sufficient length before it is filled with any data. If the length is insufficient, then the SCLP command is suppressed and the proper response code is set in the SCCB header. Fixes: 832be0d8a3bb ("s390x: sclp: Report insufficient SCCB length") Signed-off-by: Collin

[PATCH v2 8/8] s390: guest support for diagnose 0x318

DIAGNOSE 0x318 (diag 318) allows the storage of diagnostic data that is collected by the firmware in the case of hardware/firmware service events. The instruction is invoked in the Linux kernel and is handled, migrated, and reset (modified clear and load normal) by QEMU. KVM assists with the get/s

Re: [PATCH 02/10] target/arm: Convert Neon VSHL and VSLI 2-reg-shift insn to decodetree

On 5/15/20 7:20 AM, Peter Maydell wrote: > Convert the VSHL and VSLI insns from the Neon 2-registers-and-a-shift > group to decodetree. > > Signed-off-by: Peter Maydell > --- > target/arm/neon-dp.decode | 27 +++ > target/arm/translate-neon.inc.c | 38 ++

Re: [PATCH 01/10] target/arm: Remove unused GEN_NEON_INTEGER_OP macro

On 5/15/20 7:20 AM, Peter Maydell wrote: > The GEN_NEON_INTEGER_OP macro is no longer used; remove it. > > Signed-off-by: Peter Maydell > --- > Between Richard's cleanup and mine we deleted all the uses of this, > but since neither series on its own was sufficient to delete all > of them we faile

[PATCH Kernel v21 7/8] vfio iommu: Add migration capability to report supported features

Added migration capability in IOMMU info chain. User application should check IOMMU info chain for migration capability to use dirty page tracking feature provided by kernel module. User application must check page sizes supported and maximum dirty bitmap size returned by this capability structure

[PATCH Kernel v21 8/8] vfio: Selective dirty page tracking if IOMMU backed device pins pages

Added a check such that only singleton IOMMU groups can pin pages. >From the point when vendor driver pins any pages, consider IOMMU group dirty page scope to be limited to pinned pages. To optimize to avoid walking list often, added flag pinned_page_dirty_scope to indicate if all of the vfio_grou

[PATCH Kernel v21 2/8] vfio iommu: Remove atomicity of ref_count of pinned pages

vfio_pfn.ref_count is always updated while holding iommu->lock, using atomic variable is overkill. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Eric Auger Reviewed-by: Cornelia Huck --- drivers/vfio/vfio_iommu_type1.c | 9 + 1 file changed, 5 insertions(+), 4 deleti

[PATCH Kernel v21 1/8] vfio: UAPI for migration interface for device state

- Defined MIGRATION region type and sub-type. - Defined vfio_device_migration_info structure which will be placed at the 0th offset of migration region to get/set VFIO device related information. Defined members of structure and usage on read/write access. - Defined device states and state tr

[PATCH Kernel v21 6/8] vfio iommu: Update UNMAP_DMA ioctl to get dirty bitmap before unmap

DMA mapped pages, including those pinned by mdev vendor drivers, might get unpinned and unmapped while migration is active and device is still running. For example, in pre-copy phase while guest driver could access those pages, host device or vendor driver can dirty these mapped pages. Such pages s

[PATCH Kernel v21 5/8] vfio iommu: Implementation of ioctl for dirty pages tracking

VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations: - Start dirty pages tracking while migration is active - Stop dirty pages tracking. - Get dirty pages bitmap. Its user space application's responsibility to copy content of dirty pages from source to destination during migration. To prevent

[PATCH Kernel v21 3/8] vfio iommu: Cache pgsize_bitmap in struct vfio_iommu

Calculate and cache pgsize_bitmap when iommu->domain_list is updated and iommu->external_domain is set for mdev device. Add iommu->lock protection when cached pgsize_bitmap is accessed. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- drivers/vfio/vfio_iommu_type1.c | 88 +

[PATCH Kernel v21 0/8] Add UAPIs to support migration for VFIO devices

Hi, This patch set adds: * IOCTL VFIO_IOMMU_DIRTY_PAGES to get dirty pages bitmap with respect to IOMMU container rather than per device. All pages pinned by vendor driver through vfio_pin_pages external API has to be marked as dirty during migration. When IOMMU capable device is present in

[PATCH Kernel v21 4/8] vfio iommu: Add ioctl definition for dirty pages tracking

IOMMU container maintains a list of all pages pinned by vfio_pin_pages API. All pages pinned by vendor driver through this API should be considered as dirty during migration. When container consists of IOMMU capable device and all pages are pinned and mapped, then all pages are marked dirty. Added

Re: [PATCH 00/10] target/arm: Convert 2-reg-shift and 1-reg-imm Neon insns to decodetree

Patchew URL: https://patchew.org/QEMU/20200515142056.21346-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200515142056.21346-1-peter.mayd...@linaro.org Subject: [PATCH 00/10] target/arm: Convert 2-reg-

Re: [PULL 0/4] softfloat patch queue

192de113c82ecf849f6943878c453b5d2ba: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-tcg-plugins-150520-2' into staging > (2020-05-15 15:47:47 +0100) > > are available in the Git repository at: > > https://github.com/rth76

Re: [PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

On 5/15/20 11:50 AM, Peter Maydell wrote: > Using the MSR instruction to write to CPSR.E is deprecated, but it is > required to work from any mode including unprivileged code. We were > incorrectly forbidding usermode code from writing it because > CPSR_USER did not include the CPSR_E bit. > > We

Re: [PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

On Fri, 15 May 2020 at 21:41, Amanieu d'Antras wrote: > On Fri, May 15, 2020 at 7:34 PM Peter Maydell > wrote: > > I was just looking at the signal code's handling of CPSR for a different > > reason, and I noticed that at the moment we don't allow CPSR.E to be > > updated from the signal frame w

[PATCH 1/2] target/i386: fix fisttpl, fisttpll handling of out-of-range values

The fist / fistt family of instructions should all store the most negative integer in the destination format when the rounded / truncated integer result is out of range or the input is an invalid encoding, infinity or NaN. The fisttpl and fisttpll implementations (32-bit and 64-bit results, trunca

[PATCH 0/2] target/i386: x87 exceptions fixes

Following (and depending on) my three previous patch series for problems found in the x87 floating-point emulation, this patch series fixes some issues relating to floating-point exceptions. Other issues in that area remain that I hope to address in future patch series. In particular, this patch

[PATCH v4 4/9] iotests: define group in each iotest

We are going to drop group file. Define group in tests as a preparatory step. The patch is generated by cd tests/qemu-iotests grep '^[0-9]\{3\} ' group | while read line; do file=$(awk '{print $1}' <<< "$line"); groups=$(sed -e 's/^... //' <<< "$line"); awk "NR==2

[PATCH 2/2] target/i386: fix IEEE x87 floating-point exception raising

Most x87 instruction implementations fail to raise the expected IEEE floating-point exceptions because they do nothing to convert the exception state from the softfloat machinery into the exception flags in the x87 status word. There is special-case handling of division to raise the divide-by-zero

[PATCH v4 7/9] iotests: add testrunner.py

Add TestRunner class, which will run tests in a new python iotests running framework. There are some differences with current ./check behavior, most significant are: - Consider all tests self-executable, just run them, don't run python by hand. - Elapsed time is cached in json file - Elapsed tim

[PATCH v4 9/9] iotests: rename and move 169 and 199 tests

Rename bitmaps migration tests and move them to tests subdirectory to demonstrate new human-friendly test naming. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0 .../{199.out => tests/migrate-bitmaps-postcopy-test.out}

[PATCH v4 8/9] iotests: rewrite check into python

Just use classes introduced in previous three commits. Behavior difference is described in these three commits. Drop group file, as it becomes unused. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/check | 983 ++- tests/qemu-iotests/group

[PATCH v4 3/9] iotests/283: make executable

All other test files are executable, except for this one. Fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/283 | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/qemu-

[PATCH v4 5/9] iotests: add findtests.py

Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't belong to any group, like 142) Behavior of findtests.py: - group file is dropped - tests are all files in test

[PATCH v4 0/9] Rework iotests/check

Hi all! These series has 3 goals: - get rid of group file - introduce human-readable names for tests - rewrite check into python v4: - human readable tests in ..qemu-iotests/tests subdirectory - add --start-from argument for findtests - add type hinting Vladimir Sementsov-Ogievskiy

[PATCH v4 6/9] iotests: add testenv.py

Add TestEnv class, which will handle test environment in a new python iotests running framework. Difference with current ./check interface: - -v (verbose) option dropped, as it is unused - -xdiff option is dropped, until somebody complains that it is needed - same for -n option Signed-off-by: Vl

[PATCH v4 1/9] iotests/277: use dot slash for nbd-fault-injector.py running

If you run './check 277', check includes common.config which adjusts $PATH to include '.' first, and therefore finds nbd-fault-injector.py on PATH. But if you run './277' directly, there is nothing to adjust PATH, and if '.' is not already on your PATH by other means, the test fails because the ex

[PATCH v4 2/9] iotests: fix some whitespaces in test output files

We are going to be stricter about comparing test result with .out files. So, fix some whitespaces now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/175.out | 2 +- tests/qemu-iotests/267.out | 48 +++--- tests/qemu-iotests/287.out | 10 -

Re: [PATCH v2 4/5] cirrus-ci: Remove flex/bison packages

On Sat, May 16, 2020 at 12:30 AM Philippe Mathieu-Daudé wrote: > > QEMU does not use flex/bison packages. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .cirrus.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.cirrus.yml b/.cirrus.yml > index de0727cb09..ce7850a32

Re: [PATCH] linux-user/arm: Reset CPSR_E when entering a signal handler

On Fri, May 15, 2020 at 7:34 PM Peter Maydell wrote: > > On Thu, 7 May 2020 at 21:25, Amanieu d'Antras wrote: > > > > This fixes signal handlers running with the wrong endianness if the > > interrupted code used SETEND to dynamically switch endianness. > > > > Signed-off-by: Amanieu d'Antras > >

Re: [PULL 00/51] Block layer patches

Patchew URL: https://patchew.org/QEMU/20200515124521.335403-1-kw...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

Re: [PATCH v2 5/9] hw/char: Initial commit of Ibex UART

On Fri, May 15, 2020 at 12:28 AM Philippe Mathieu-Daudé wrote: > > On 5/7/20 9:13 PM, Alistair Francis wrote: > > This is the initial commit of the Ibex UART device. Serial TX is > > working, while RX has been implemeneted but untested. > > > > This is based on the documentation from: > > https://

Re: [PATCH v2 2/9] target/riscv: Don't overwrite the reset vector

On Thu, May 14, 2020 at 9:54 PM Bin Meng wrote: > > On Fri, May 15, 2020 at 5:51 AM Alistair Francis wrote: > > > > On Thu, May 14, 2020 at 10:54 AM Philippe Mathieu-Daudé > > wrote: > > > > > > On 5/7/20 9:13 PM, Alistair Francis wrote: > > > > If the reset vector is set in the init function do

Re: [PATCH v1 7/8] tests/tcg: add new threadcount test

Sure, use it for anything. ср, 13 мая 2020 г. в 20:32, Alex Bennée : > Based on the original testcase by Nikolay Igotti. > > Message-ID: wkhow2xg+zhv...@mail.gmail.com> > Cc: Nikolay Igotti > [Nikolay can we have your signed of by to add the testcase?] > Signed-off-by: Alex Bennée > --- > tes

Re: [PATCH v2 0/5] fix migration with bitmaps and mirror

15.05.2020 20:51, Eric Blake wrote: On 5/15/20 6:15 AM, Vladimir Sementsov-Ogievskiy wrote: Max is trying to tackle the node-name issue: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg03358.html And trying to apply that patch after staging this series hits a conflict in mnigration/b

[PATCH 08/10] softfloat: Inline float128 compare specializations

Replace the float128 compare specializations with inline functions that call the standard float128_compare{,_quiet} functions. Use bool as the return type. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 +++-- fpu/softfloat.c | 238

[PATCH 10/10] softfloat: Return bool from all classification predicates

This includes *_is_any_nan, *_is_neg, *_is_inf, etc. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h| 66 +- fpu/softfloat-specialize.inc.c | 16 - 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/include/fpu/softfloat.

[PATCH 09/10] softfloat: Inline floatx80 compare specializations

Replace the floatx80 compare specializations with inline functions that call the standard floatx80_compare{,_quiet} functions. Use bool as the return type. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 ++-- fpu/softfloat.c | 257 -

[PATCH 06/10] softfloat: Inline float32 compare specializations

Replace the float32 compare specializations with inline functions that call the standard float32_compare{,_quiet} functions. Use bool as the return type. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 +++-- fpu/softfloat.c | 216 --

[PATCH 02/10] softfloat: Replace flag with bool

We have had this on the to-do list for quite some time. Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 14 +-- include/fpu/softfloat-macros.h | 24 ++-- include/fpu/softfloat-types.h | 14 +-- include/fpu/softfloat.h | 10 +- fpu/softfloat-specialize.inc.c

[PATCH 04/10] softfloat: Name rounding mode enum

Give the previously unnamed enum a typedef name. Use the packed attribute so that we do not affect the layout of the float_status struct. Use it in the prototypes of relevant functions. Adjust switch statements as necessary to avoid compiler warnings. Signed-off-by: Richard Henderson --- incl

[PATCH 07/10] softfloat: Inline float64 compare specializations

Replace the float64 compare specializations with inline functions that call the standard float64_compare{,_quiet} functions. Use bool as the return type. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 ++-- fpu/softfloat.c | 220 ---

[PATCH 03/10] softfloat: Change tininess_before_rounding to bool

Slightly tidies the usage within softfloat.c and the representation in float_status. Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 8 ++--- include/fpu/softfloat-types.h | 8 ++--- fpu/softfloat.c | 54 - tests/fp/fp-te

[PATCH 05/10] softfloat: Name compare relation enum

Give the previously unnamed enum a typedef name. Use it in the prototypes of compare functions. Use it to hold the results of the compare functions. Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 25 +++-- target/i386/ops_sse.h | 8 +++ fp

[PATCH 01/10] softfloat: Use post test for floatN_mul

The existing f{32,64}_addsub_post test, which checks for zero inputs, is identical to f{32,64}_mul_fast_test. Which means we can eliminate the fast_test/fast_op hooks in favor of reusing the same post hook. This means we have one fewer test along the fast path for multiply. Signed-off-by: Richar

[PATCH 00/10] softfloat: misc cleanups

This is a grab-bag collection of cleanups, at least one of which have been on the to-do list since day we abandoned compatibility with upstream softfloat. The compare changes have near-zero effect for float32/float64, since that's the way they are implemented now. For float128, it simply removes

[PATCH] target/arm: Allow user-mode code to write CPSR.E via MSR

Using the MSR instruction to write to CPSR.E is deprecated, but it is required to work from any mode including unprivileged code. We were incorrectly forbidding usermode code from writing it because CPSR_USER did not include the CPSR_E bit. We use CPSR_USER in only three places: * as the mask of

[PULL 4/4] softfloat: fix floatx80 pseudo-denormal round to integer

From: Joseph Myers The softfloat function floatx80_round_to_int incorrectly handles the case of a pseudo-denormal where only the high bit of the significand is set, ignoring that bit (treating the number as an exact zero) rather than treating the number as an alternative representation of +/- 2^-

  1   2   3   4   5   >