Re: [PATCH] hw/char/parallel: Convert reset handler to DeviceReset

2020-05-11 Thread Philippe Mathieu-Daudé
ping? On 5/4/20 11:56 AM, Philippe Mathieu-Daudé wrote: As TYPE_ISA_PARALLEL inherits from TYPE_ISA_DEVICE, it also inherits from the DEVICE methods. Convert its reset handler into a proper DeviceReset method. Signed-off-by: Philippe Mathieu-Daudé --- hw/char/parallel.c | 9 - 1 fil

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread David Hildenbrand
On 12.05.20 08:46, Philippe Mathieu-Daudé wrote: > On 5/12/20 8:01 AM, Cornelia Huck wrote: >> On Mon, 11 May 2020 14:21:27 +0200 >> Philippe Mathieu-Daudé wrote: >> >>> On 5/11/20 12:48 PM, Cornelia Huck wrote: On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: >

[PATCH v5 4/7] dwc-hsotg (dwc2) USB host controller emulation

2020-05-11 Thread Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller emulation code. Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. Note that to use this with the dwc-otg driver in the Raspbian kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" on the kernel command line. Emulation of slave mode and of descr

Re: [PATCH] hw/ide/ahci: Log lost IRQs

2020-05-11 Thread Philippe Mathieu-Daudé
ping? On 5/4/20 11:48 AM, Philippe Mathieu-Daudé wrote: One might find interesting to look at AHCI IRQs. Signed-off-by: Philippe Mathieu-Daudé --- hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 13d91e109a..fc82cbd5f1 100644 --- a/hw/ide

Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support

2020-05-11 Thread xiaoqiang.zhao
在 2020/5/12 上午2:01, Eric Blake 写道: On 5/10/20 1:14 AM, xiaoqiang zhao wrote: unix_listen/connect_saddr now support abstract address types two aditional BOOL switches are introduced: tight: whether to set @addrlen to the minimal string length,     or the maximum sun_path length. default is T

[PATCH v5 7/7] raspi2 acceptance test: add test for dwc-hsotg (dwc2) USB host

2020-05-11 Thread Paul Zimmerman
Add a check for functional dwc-hsotg (dwc2) USB host emulation to the Raspi 2 acceptance test Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Paul Zimmerman --- tests/acceptance/boot_linux_console.py | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/acceptanc

[PATCH v5 3/7] dwc-hsotg (dwc2) USB host controller state definitions

2020-05-11 Thread Paul Zimmerman
Add the dwc-hsotg (dwc2) USB host controller state definitions. Mostly based on hw/usb/hcd-ehci.h. Signed-off-by: Paul Zimmerman --- hw/usb/hcd-dwc2.h | 173 ++ 1 file changed, 173 insertions(+) create mode 100644 hw/usb/hcd-dwc2.h diff --git a/hw/us

[PATCH v5 5/7] usb: add short-packet handling to usb-storage driver

2020-05-11 Thread Paul Zimmerman
The dwc-hsotg (dwc2) USB host depends on a short packet to indicate the end of an IN transfer. The usb-storage driver currently doesn't provide this, so fix it. I have tested this change rather extensively using a PC emulation with xhci, ehci, and uhci controllers, and have not observed any regres

[PATCH v5 2/7] dwc-hsotg (dwc2) USB host controller register definitions

2020-05-11 Thread Paul Zimmerman
Import the dwc-hsotg (dwc2) register definitions file from the Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the mainline Linux kernel, the only changes being two instances of 'u32' changed to 'uint32_t' to allow it to compile. Checkpatch throws a boatload of errors due to the tab ind

[PATCH v5 6/7] wire in the dwc-hsotg (dwc2) USB host controller emulation

2020-05-11 Thread Paul Zimmerman
Wire the dwc-hsotg (dwc2) emulation into Qemu Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Paul Zimmerman --- hw/arm/bcm2835_peripherals.c | 21 - include/hw/arm/bcm2835_peripherals.h | 3 ++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/hw/

[PATCH v5 1/7] raspi: add BCM2835 SOC MPHI emulation

2020-05-11 Thread Paul Zimmerman
Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) emulation. It is very basic, only providing the FIQ interrupt needed to allow the dwc-otg USB host controller driver in the Raspbian kernel to function. Signed-off-by: Paul Zimmerman --- hw/arm/bcm2835_peripherals.c | 17 +++

[PATCH v5 0/7] dwc-hsotg (aka dwc2) USB host controller emulation

2020-05-11 Thread Paul Zimmerman
Gerd, Peter, what do you think about accepting this patch series? The only possibly disruptive patch is #5, which modifies the dev-storage.c code a bit, the rest is all new code which shouldn't affect anything else. Felippe Mathieu-Daudé has done quite a bit of review of the patches, and has said h

Re: [PATCH v3 6/9] qemu-img: Add bitmap sub-command

2020-05-11 Thread Max Reitz
On 11.05.20 20:22, Eric Blake wrote: > On 5/11/20 6:10 AM, Max Reitz wrote: >> On 08.05.20 20:03, Eric Blake wrote: >>> Include actions for --add, --remove, --clear, --enable, --disable, and >>> --merge (note that --clear is a bit of fluff, because the same can be >>> accomplished by removing a bit

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/12/20 8:01 AM, Cornelia Huck wrote: On Mon, 11 May 2020 14:21:27 +0200 Philippe Mathieu-Daudé wrote: On 5/11/20 12:48 PM, Cornelia Huck wrote: On Sat, 9 May 2020 15:09:07 +0200 Philippe Mathieu-Daudé wrote: As these declarations are restricted to !CONFIG_USER_ONLY in helper.c, onl

SBSA-REF maintainer email bouncing

2020-05-11 Thread Philippe Mathieu-Daudé
Hello, Radoslaw Biernacki is listed as maintainer for the SBSA-REF board. His radoslaw.bierna...@linaro.org email address no longer works, apparently "Radoslaw Biernacki no longer works for Linaro". SBSA-REF M: Radoslaw Biernacki M: Peter Maydell R: Leif Lindholm L: qemu-...@nongnu

Re: [PATCH v2] tests/acceptance: Add a test for the canon-a1100 machine

2020-05-11 Thread Thomas Huth
On 10/02/2020 17.59, Thomas Huth wrote: > On 29/01/2020 10.04, Thomas Huth wrote: >> The canon-a1100 machine can be used with the Barebox firmware. The >> QEMU Advent Calendar 2018 features a pre-compiled image which we >> can use for testing. >> >> Reviewed-by: Philippe Mathieu-Daudé >> Tested-by

[Bug 1873032] Re: After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with Windows 10 after a while starts to work very slowly

2020-05-11 Thread post-factum
Unofficial x86_64 build of v5.0.0 with those 2 patches for Arch is here: [1]. [1] https://download.opensuse.org/repositories/home:/post- factum/Arch/x86_64/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-11 Thread post-factum
Unofficial x86_64 build of v5.0.0 with those 2 patches for Arch is here: [1]. [1] https://download.opensuse.org/repositories/home:/post- factum/Arch/x86_64/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-11 Thread Max Reitz
On 11.05.20 20:16, Eric Blake wrote: > On 5/11/20 4:21 AM, Max Reitz wrote: >> On 08.05.20 20:03, Eric Blake wrote: >>> Upcoming patches will enhance bitmap support in qemu-img, but in doing >>> so, it turns out to be nice to suppress output when bitmaps make no >>> sense (such as on a qcow2 v2 ima

Re: [PATCH 08/11] target/s390x: Restrict system-mode declarations

2020-05-11 Thread Cornelia Huck
On Mon, 11 May 2020 14:21:27 +0200 Philippe Mathieu-Daudé wrote: > On 5/11/20 12:48 PM, Cornelia Huck wrote: > > On Sat, 9 May 2020 15:09:07 +0200 > > Philippe Mathieu-Daudé wrote: > > > >> As these declarations are restricted to !CONFIG_USER_ONLY in > >> helper.c, only declare them when sys

[Bug 1844635] Re: qemu bug where load linux kernel

2020-05-11 Thread Thomas Huth
** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1844635 Title: qemu bug where load linux kernel Status in QEMU: Fix Released B

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-05-11 Thread Ani Sinha
> On May 12, 2020, at 12:23 AM, Igor Mammedov wrote: > >> >> static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus, >> - bool pcihp_bridge_en) >> + bool pcihp_bridge_en, >> +

[Bug 1878136] [NEW] Assertion failures in ati_reg_read_offs/ati_reg_write_offs

2020-05-11 Thread Alexander Bulekov
Public bug reported: Hello, While fuzzing, I found inputs that trigger assertion failures in ati_reg_read_offs/ati_reg_write_offs uint32_t extract32(uint32_t, int, int): Assertion `start >= 0 && length > 0 && length <= 32 - start' failed #3 0x76866092 in __GI___assert_fail (assertion=0x5

[Bug 1878136] Re: Assertion failures in ati_reg_read_offs/ati_reg_write_offs

2020-05-11 Thread Alexander Bulekov
** Attachment added: "The qtest commands for triggering the assertion in ati_reg_read_offs" https://bugs.launchpad.net/qemu/+bug/1878136/+attachment/5370129/+files/attachment2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

2020-05-11 Thread Yan Zhao
On Mon, May 11, 2020 at 05:53:37PM +0800, Kirti Wankhede wrote: > > > On 5/5/2020 10:07 AM, Alex Williamson wrote: > > On Tue, 5 May 2020 04:48:14 +0530 > > Kirti Wankhede wrote: > > > >> On 3/26/2020 3:33 AM, Alex Williamson wrote: > >>> On Wed, 25 Mar 2020 02:39:07 +0530 > >>> Kirti Wankhede

Re: [PATCH v16 QEMU 09/16] vfio: Add save state functions to SaveVMHandlers

2020-05-11 Thread Yan Zhao
On Mon, May 11, 2020 at 06:22:47PM +0800, Kirti Wankhede wrote: > > > On 5/9/2020 11:01 AM, Yan Zhao wrote: > > On Wed, Mar 25, 2020 at 05:09:07AM +0800, Kirti Wankhede wrote: > >> Added .save_live_pending, .save_live_iterate and > >> .save_live_complete_precopy > >> functions. These functions h

Re: [RESEND PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-05-11 Thread David Gibson
On Mon, May 11, 2020 at 05:02:02PM -0300, Leonardo Bras wrote: > From: Leonardo Bras > > On reboot, all memory that was previously added using object_add and > device_add is placed in this DIMM area. > > The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in > the correct me

[PATCH v3 2/2] char-file: add test for distinct path= and pathin=

2020-05-11 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov --- tests/test-char.c | 96 +++ 1 file changed, 96 insertions(+) diff --git a/tests/test-char.c b/tests/test-char.c index 3afc9b1b8d..6c66fae86a 100644 --- a/tests/test-char.c +++ b/tests/test-char.c @@ -1228,6 +1228,10

[PATCH v3 0/2] Add pathin option to -chardev file

2020-05-11 Thread Alexander Bulekov
This adds a pathin= option to -chardev file, which allows specifying distinct input and output paths for the chardev. This functionaliy was already available through QMP. v3: * char-test: add a stat()-based check to ensure that the pathin= file is not modified during the execution of the tes

[PATCH v3 1/2] chardev: enable distinct input for -chardev file

2020-05-11 Thread Alexander Bulekov
char-file already supports distinct paths for input/output but it was only possible to specify a distinct input through QMP. With this change, we can also specify a distinct input with the -chardev file argument: qemu -chardev file,id=char1,path=/out/file,pathin=/in/file Signed-off-by: Alexand

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-11 Thread Li Feng
Hi, Dima. If vhost_migration_log return < 0, then vhost_log_global_start will trigger a crash. Does your patch have process this abort? If a disconnect happens in the migration stage, the correct operation is to stop the migration, right? 841 static void vhost_log_global_start(MemoryListener *li

Re: [PATCH v8 0/7] reference implementation of RSS and hash report

2020-05-11 Thread Jason Wang
On 2020/5/8 下午8:59, Yuri Benditovich wrote: Support for VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT features in QEMU for reference purpose. Implements Toeplitz hash calculation for incoming packets according to configuration provided by driver. Uses calculated hash for decision on receive vir

Re: [PATCH 0/6] target/ppc: Various clean-up and fixes for radix64

2020-05-11 Thread David Gibson
On Mon, May 11, 2020 at 06:55:21PM +0200, Greg Kurz wrote: > On Mon, 11 May 2020 11:44:26 +1000 > David Gibson wrote: > > > On Thu, May 07, 2020 at 07:26:32PM +0200, Greg Kurz wrote: > > > First three patches of this series are simple cleanups. The other > > > ones fix some regressions introduced

Re: [PATCH v2] e1000e: Added ICR clearing by corresponding IMS bit.

2020-05-11 Thread Jason Wang
On 2020/5/11 下午6:08, Andrew Melnichenko wrote: Yo, So I think we should implement the 82574l behavior?  Well, as I understand it - its already implemented. I've added ICR clearance if ICR & IMS(also need to add ICR_ASSERTED check, my bad, I'll prepare new patch). Yes, but it behave m

Re: [PATCH v2 5/5] vhost: add device started check in migration set log

2020-05-11 Thread Jason Wang
On 2020/5/11 下午5:25, Dima Stepanov wrote: On Mon, May 11, 2020 at 11:15:53AM +0800, Jason Wang wrote: On 2020/4/30 下午9:36, Dima Stepanov wrote: If vhost-user daemon is used as a backend for the vhost device, then we should consider a possibility of disconnect at any moment. If such disconnect

Re: [PATCH v2 4/5] vhost: check vring address before calling unmap

2020-05-11 Thread Jason Wang
On 2020/5/11 下午5:11, Dima Stepanov wrote: On Mon, May 11, 2020 at 11:05:58AM +0800, Jason Wang wrote: On 2020/4/30 下午9:36, Dima Stepanov wrote: Since disconnect can happen at any time during initialization not all vring buffers (for instance used vring) can be intialized successfully. If the

[PATCH 1/4] fuzz: add datadir for oss-fuzz compatability

2020-05-11 Thread Alexander Bulekov
This allows us to keep pc-bios in executable_dir/pc-bios, rather than executable_dir/../pc-bios, which is incompatible with oss-fuzz' file structure. Signed-off-by: Alexander Bulekov --- include/sysemu/sysemu.h | 2 ++ softmmu/vl.c| 2 +- tests/qtest/fuzz/fuzz.c | 15 ++

[PATCH 0/4] fuzz: misc changes for oss-fuzz compatability

2020-05-11 Thread Alexander Bulekov
Hello, With these patches, the fuzzer passes the oss-fuzz build checks. There are also some miscelanous improvement to the fuzzer, in general: * If building for oss-fuzz, check executable_dir/pc-bios for the bios images * Fix a typo in the i440fx-qtest-reboot argument which resulted in an i

RE: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric > Sent: Tuesday, May 12, 2020 8:39 AM > To: Bharat Bhushan ; eric.auger@gmail.com; > qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-phili...@linaro.org; pet...@redhat.com; > arm...@redhat.c

[PATCH v27 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries

2020-05-11 Thread Dongjiu Geng
I and Xiang are willing to review the APEI-related patches and volunteer as the reviewers for the HEST/GHES part. Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- MAINTAINERS | 9 + 1 file changed, 9 insertions

RE: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Bharat Bhushan
Hi Eric, > -Original Message- > From: Auger Eric > Sent: Monday, May 11, 2020 2:19 PM > To: Bharat Bhushan ; eric.auger@gmail.com; > qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-phili...@linaro.org; pet...@redhat.com; > arm...@redhat.co

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread gengdongjiu
On 2020/5/12 3:41, Igor Mammedov wrote: > for future, adding RESEND doesn't make sence here. If you change patches then > just bump version. Igor, Thanks for the reminder, Just now I submitted a new patchset version to avoid this confusion.

[PATCH v27 05/10] ACPI: Build Hardware Error Source Table

2020-05-11 Thread Dongjiu Geng
This patch builds Hardware Error Source Table(HEST) via fw_cfg blobs. Now it only supports ARMv8 SEA, a type of Generic Hardware Error Source version 2(GHESv2) error source. Afterwards, we can extend the supported types if needed. For the CPER section, currently it is memory section because kernel

Re: [EXT] [PATCH v2 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-05-11 Thread Auger Eric
Hi Bharat, On 5/12/20 5:03 AM, Bharat Bhushan wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric >> Sent: Monday, May 11, 2020 2:19 PM >> To: Bharat Bhushan ; eric.auger@gmail.com; >> qemu-devel@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; >> m...@redhat.com;

[PATCH v27 08/10] ACPI: Record Generic Error Status Block(GESB) table

2020-05-11 Thread Dongjiu Geng
kvm_arch_on_sigbus_vcpu() error injection uses source_id as index in etc/hardware_errors to find out Error Status Data Block entry corresponding to error source. So supported source_id values should be assigned here and not be changed afterwards to make sure that guest will write error into expecte

[PATCH v27 06/10] ACPI: Record the Generic Error Status Block address

2020-05-11 Thread Dongjiu Geng
Record the GHEB address via fw_cfg file, when recording a error to CPER, it will use this address to find out Generic Error Data Entries and write the error. In order to avoid migration failure, make hardware error table address to a part of GED device instead of global variable, then this address

[PATCH v27 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2020-05-11 Thread Dongjiu Geng
Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, translates the host VA delivered by host to guest PA, then fills this PA to guest APEI GHES memory, then notifies guest according to the SIGBUS type. When guest accesses the poisoned memory, it will generate a Synchronous Ext

[PATCH v27 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob

2020-05-11 Thread Dongjiu Geng
This patch builds error_block_address and read_ack_register fields in hardware errors table , the error_block_address points to Generic Error Status Block(GESB) via bios_linker. The max size for one GESB is 1kb, For more detailed information, please refer to document: docs/specs/acpi_hest_ghes.rst

[PATCH v27 07/10] KVM: Move hwpoison page related functions into kvm-all.c

2020-05-11 Thread Dongjiu Geng
kvm_hwpoison_page_add() and kvm_unpoison_all() will both be used by X86 and ARM platforms, so moving them into "accel/kvm/kvm-all.c" to avoid duplicate code. For architectures that don't use the poison-list functionality the reset handler will harmlessly do nothing, so let's register the kvm_unpoi

[PATCH v27 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread Dongjiu Geng
The little end UUID is used in many places, so make NVDIMM_UUID_LE to a common macro to convert the UUID to a little end array. Reviewed-by: Xiang Zheng Signed-off-by: Dongjiu Geng --- Change since v25: 1. Address Peter's comments to add a proper doc-comment comment for UUID_LE macros. --- h

[PATCH 2/4] fuzz: fix typo in i440fx-qtest-reboot arguments

2020-05-11 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/i440fx_fuzz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/fuzz/i440fx_fuzz.c b/tests/qtest/fuzz/i440fx_fuzz.c index ab5f112584..90e75ffaea 100644 --- a/tests/qtest/fuzz/i440fx_fuzz.c +++ b/tests/qtest/fuzz/i

[PATCH v27 00/10] Add ARMv8 RAS virtualization support in QEMU

2020-05-11 Thread Dongjiu Geng
In the ARMv8 platform, the CPU error types includes synchronous external abort(SEA) and SError Interrupt (SEI). If exception happens in guest, host does not know the detailed information of guest, so it is expected that guest can do the recovery. For example, if an exception happens in a guest u

[PATCH v27 03/10] docs: APEI GHES generation and CPER record description

2020-05-11 Thread Dongjiu Geng
Add APEI/GHES detailed design document Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov --- docs/specs/acpi_hest_ghes.rst | 110 ++ docs/specs/index.rst | 1 + 2 files changed,

[PATCH v27 02/10] hw/arm/virt: Introduce a RAS machine option

2020-05-11 Thread Dongjiu Geng
RAS Virtualization feature is not supported now, so add a RAS machine option and disable it by default. Reviewed-by: Peter Maydell Signed-off-by: Dongjiu Geng Signed-off-by: Xiang Zheng Reviewed-by: Jonathan Cameron Reviewed-by: Igor Mammedov --- hw/arm/virt.c | 23 ++

[PATCH 3/4] fuzz: add mangled object name to linker script

2020-05-11 Thread Alexander Bulekov
Previously, we relied on "FuzzerTracePC*(.bss*)" to place libfuzzer's fuzzer::TPC object into our contiguous shared-memory region. This does not work for some libfuzzer builds, so this addition identifies the region by its mangled name: *(.bss._ZN6fuzzer3TPCE); Signed-off-by: Alexander Bulekov --

[PATCH 4/4] fuzz: run the main-loop in fork-server process

2020-05-11 Thread Alexander Bulekov
Without this, the time since the last main-loop keeps increasing, as the fuzzer runs. The forked children need to handle all the "past-due" timers, slowing them down, over time. With this change, the parent/fork-server process runs the main-loop, while waiting on the child, ensuring that the timer

Questions about record & replay for RISC-V

2020-05-11 Thread LIU Zhiwei
Hi Pavel, I am developing a profiling tool depending on record & replay feature of QEMU for  RISC-V. Here I'd like to ask you some questions. First, is it possible to record & replay a Linux system by this feature in theory? I mean keep the strict instruction sequence of each process and kern

Re: [PATCH 3/3] plugins: avoid failing plugin when CPU is inited several times

2020-05-11 Thread Emilio G. Cota
On Mon, May 11, 2020 at 18:53:19 +0300, Nikolay Igotti wrote: > Attached to the mail counter.c when running with attached test.c compiled > to Linux standalone binary shows failing assert, unless the patch is > applied. I didn't get the attachment. Can you paste the code at the end of your reply?

Re: [PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-11 Thread Alex Williamson
On Mon, 11 May 2020 15:01:27 -0400 Jon Derrick wrote: > The VMD endpoint provides a real PCIe domain to the guest, including Please define VMD. I'm sure this is obvious to many, but I've had to do some research. The best TL;DR summary I've found is Keith's original commit 185a383ada2e adding t

Re: [PATCH 1/2] xen-9pfs: Fix log messages of reply errors

2020-05-11 Thread Stefano Stabellini
On Sun, 10 May 2020, Christian Schoenebeck wrote: > If delivery of some 9pfs response fails for some reason, log the > error message by mentioning the 9P protocol reply type, not by > client's request type. The latter could be misleading that the > error occurred already when handling the request i

Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size

2020-05-11 Thread Stefano Stabellini
On Sun, 10 May 2020, Christian Schoenebeck wrote: > Commit SHA-1 16724a173049ac29c7b5ade741da93a0f46edff7 introduced > truncating the response to the currently available transport buffer > size, which was supposed to fix an 9pfs error on Xen boot where > transport buffer might still be smaller than

Re: [Bug 1878054] [NEW] Hang with high CPU usage in sdhci_data_transfer

2020-05-11 Thread Philippe Mathieu-Daudé
+Peter who was the previous maintainer. On 5/11/20 7:23 PM, Alexander Bulekov wrote: Public bug reported: Hello, While fuzzing, I found an input that causes QEMU to hang with 100% CPU usage. I have waited several minutes, and QEMU is still unresponsive. Using gdb, It appears that it is stuck in

Re: [PATCH 5/7] audio: Let HWVoice write() handlers take a const buffer

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/6/20 8:22 AM, Volker Rümelin wrote: diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c index 4cdf19ab67..bba6bafda4 100644 --- a/audio/dsoundaudio.c +++ b/audio/dsoundaudio.c @@ -454,7 +454,7 @@ static void *dsound_get_buffer_out(HWVoiceOut *hw, size_t *size) return ret; }

Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-11 Thread Eric Blake
On 5/11/20 1:16 PM, Eric Blake wrote: On 5/11/20 4:21 AM, Max Reitz wrote: +++ b/include/block/block_int.h @@ -560,6 +560,7 @@ struct BlockDriver {    uint64_t parent_perm, uint64_t parent_shared,    uint64_t *nperm, uint64_t *nshared);

Re: [PATCH v2 3/5] virtio-iommu: Handle reserved regions in the translation process

2020-05-11 Thread Peter Xu
On Fri, May 08, 2020 at 07:30:55PM +0200, Eric Auger wrote: > When translating an address we need to check if it belongs to > a reserved virtual address range. If it does, there are 2 cases: > > - it belongs to a RESERVED region: the guest should neither use > this address in a MAP not instruct

[PATCH] hw: Use QEMU_IS_ALIGNED() on parallel flash block size

2020-05-11 Thread Philippe Mathieu-Daudé
Use the QEMU_IS_ALIGNED() macro to verify the flash block size is properly aligned. It is quicker to process when reviewing. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/sbsa-ref.c | 2 +- hw/arm/virt.c | 2 +- hw/block/pflash_cfi01.c | 2 +- hw/block/pflash_cfi02.c | 2 +- h

Re: [PATCH v8] audio/jack: add JACK client audiodev

2020-05-11 Thread Eric Blake
On 4/29/20 12:53 AM, Geoffrey McRae wrote: This commit adds a new audiodev backend to allow QEMU to use JACK as both an audio sink and source. Signed-off-by: Geoffrey McRae --- +++ b/qapi/audio.json @@ -152,6 +152,55 @@ '*out': 'AudiodevPerDirectionOptions', '*latency': 'uint

Re: Qemu, VNC and non-US keymaps

2020-05-11 Thread B3r3n
Hello Daniel, There is no mention here of what VNC client program is being used, which is quite important, as key handling is a big mess in VNC. I tested with TightVNC & noVNC through Apache. Both behaves the same. I did not tested Ultr@VNC. The default VNC protocol passes X11 keysyms over

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-11 Thread Roman Kagan
On Thu, May 07, 2020 at 06:14:25AM +0300, Jon Doron wrote: > Igor it seems like the IRQ being used is 5 and not 7 & 13 like in the > current patch. HyperV using irq 5 doesn't mean QEMU has to too. Especially so as no guest was noticed to use the irqs in ACPI. I'd rather try and test if the guest

Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty

2020-05-11 Thread Philippe Mathieu-Daudé
On 5/11/20 9:24 PM, Igor Mammedov wrote: On Mon, 11 May 2020 18:00:01 +0200 Philippe Mathieu-Daudé wrote: Hi Eduardo, On 5/4/20 5:44 PM, Eduardo Habkost wrote: On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote: Since 5.0 QEMU uses hostmem backend for allocating main guest RAM. T

[RESEND PATCH v3 1/1] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

2020-05-11 Thread Leonardo Bras
From: Leonardo Bras On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area. The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to

Re: [PATCH 2/5] io/channel.c,io/channel-socket.c: Add yank feature

2020-05-11 Thread Lukas Straub
On Mon, 11 May 2020 12:51:46 +0100 Daniel P. Berrangé wrote: > On Mon, May 11, 2020 at 01:14:41PM +0200, Lukas Straub wrote: > > Add qio_channel_set_yank function to channel and to channel-socket, > > which will register a yank function. The yank function calls > > shutdown() on the socket. > >

Re: [PATCH v26 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro

2020-05-11 Thread Igor Mammedov
On Mon, 11 May 2020 22:05:28 +0800 gengdongjiu wrote: > >> +    (node3), (node4), (node5) } > >> + > >>   #define UUID_FMT "%02hhx%02hhx%02hhx%02hhx-" \ > >>    "%02hhx%02hhx-%02hhx%02hhx-" \ > >>    "%02hhx%02hhx-" \ > >> diff --git a/slirp b/slirp > >> index 2faa

Re: [PATCH 0/5] Introduce 'yank' oob qmp command to recover from hanging qemu

2020-05-11 Thread Lukas Straub
On Mon, 11 May 2020 13:17:14 +0100 Daniel P. Berrangé wrote: > On Mon, May 11, 2020 at 01:07:18PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, May 11, 2020 at 01:14:34PM +0200, Lukas Straub wrote: > > > > Hello Everyone, > > > > In m

Re: [PATCH v5 14/15] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-05-11 Thread Igor Mammedov
On Thu, 7 May 2020 15:16:39 +0200 Gerd Hoffmann wrote: > Seems to be unused. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index c1

Re: [PATCH v5 13/15] acpi: drop build_piix4_pm()

2020-05-11 Thread Igor Mammedov
On Thu, 7 May 2020 15:16:38 +0200 Gerd Hoffmann wrote: > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) > is not used any more, remove it from DSDT. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 16 > 1 file changed, 16 deletions(-) > > diff

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-05-11 Thread Jag Raman
> On May 11, 2020, at 10:40 AM, Stefan Hajnoczi wrote: > > Hi, > Have you decided whether to drop the remote device program in favor of > using a softmmu make target? > > Is there anything in this series you'd like me to review before you send > the next revision? Hi Stefan, We are planning

Re: [PATCH v5 12/15] acpi: drop serial/parallel enable bits from dsdt

2020-05-11 Thread Igor Mammedov
On Thu, 7 May 2020 15:16:37 +0200 Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 23 --- > 1 file changed, 23 del

Re: [PATCH v5 03/15] acpi: rtc: use a single crs range

2020-05-11 Thread Igor Mammedov
On Thu, 7 May 2020 15:16:28 +0200 Gerd Hoffmann wrote: > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > hw/rtc/mc146818rtc.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions

Re: [PATCH] hostmem: don't use mbind() if host-nodes is epmty

2020-05-11 Thread Igor Mammedov
On Mon, 11 May 2020 18:00:01 +0200 Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 5/4/20 5:44 PM, Eduardo Habkost wrote: > > On Thu, Apr 30, 2020 at 11:46:06AM -0400, Igor Mammedov wrote: > >> Since 5.0 QEMU uses hostmem backend for allocating main guest RAM. > >> The backend however calls

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-11 Thread Stefan Hajnoczi
Please try this patch series: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg02728.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1877716 Title: Win10 guest unusable after a few minut

[Bug 1873032] Re: After upgrade qemu to 5.0.0-0.3.rc2.fc33 the virtual machine with Windows 10 after a while starts to work very slowly

2020-05-11 Thread Stefan Hajnoczi
Please try this patch series: https://lists.gnu.org/archive/html/qemu- devel/2020-05/msg02728.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1873032 Title: After upgrade qemu to 5.0.0-0.3.rc2.f

[PATCH v2 1/2] PCI: vmd: Filter resource type bits from shadow register

2020-05-11 Thread Jon Derrick
Versions of VMD with the Host Physical Address shadow register use this register to calculate the bus address offset needed to do guest passthrough of the domain. This register shadows the Host Physical Address registers including the resource type bits. After calculating the offset, the extra reso

[PATCH for QEMU v2] hw/vfio: Add VMD Passthrough Quirk

2020-05-11 Thread Jon Derrick
The VMD endpoint provides a real PCIe domain to the guest, including bridges and endpoints. Because the VMD domain is enumerated by the guest kernel, the guest kernel will assign Guest Physical Addresses to the downstream endpoint BARs and bridge windows. When the guest kernel performs MMIO to VMD

[PATCH v2 2/2] PCI: vmd: Use Shadow MEMBAR registers for QEMU/KVM guests

2020-05-11 Thread Jon Derrick
VMD device 28C0 natively assists guest passthrough of the VMD endpoint through the use of shadow registers that provide Host Physical Addresses to correctly assign bridge windows. These shadow registers are only available if VMD config space register 0x70, bit 1 is set. For existing VMD which don'

[PATCH v2 0/2] VMD endpoint passthrough support

2020-05-11 Thread Jon Derrick
This set contains 2 patches for Linux and 1 for QEMU. VMD device 8086:28C0 contains information in registers to assist with direct assignment passthrough. Several other VMD devices don't have this information, but can easily be emulated to offer this feature. The existing VMD devices not supportin

Re: [PATCH] linux-user: support of semtimedop syscall

2020-05-11 Thread Laurent Vivier
Le 11/05/2020 à 18:39, Matus Kysel a écrit : > We should add support of semtimedop syscall as new version of > glibc 2.31 uses semop based on semtimedop (commit: > https://gitlab.com/freedesktop-sdk/mirrors/sourceware/glibc/-/commit/765cdd0bffd77960ae852104fc4ea5edcdb8aed3 > ). > > Signed-off-by

Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-05-11 Thread Igor Mammedov
On Sun, 10 May 2020 17:42:16 + Ani Sinha wrote: > > On Apr 29, 2020, at 9:02 PM, Igor Mammedov wrote: > > > > On Fri, 24 Apr 2020 14:44:48 -0400 > > Eduardo Habkost wrote: > > > >> On Fri, Apr 24, 2020 at 03:23:56PM +, Ani Sinha wrote: > >>> > >>> > On Apr 22, 2020, at 4:

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

2020-05-11 Thread Igor Mammedov
On Tue, 28 Apr 2020 10:16:52 + Ani Sinha wrote: > A new option "use_acpi_unplug" is introduced for PIIX which will > selectively only disable hot unplugging of both hot plugged and > cold plugged PCI devices on non-root PCI buses. This will prevent > hot unplugging of devices from Windows bas

Re: [PATCH v2] linux-user: syscall: ioctls: support DRM_IOCTL_VERSION

2020-05-11 Thread Laurent Vivier
Le 15/03/2020 à 13:20, cheng...@emindsoft.com.cn a écrit : > From: Chen Gang > > Another DRM_IOCTL_* commands will be done later. > > Signed-off-by: Chen Gang > --- > linux-user/ioctls.h| 2 ++ > linux-user/syscall.c | 62 ++ > linux-user/sysc

[PATCH 2/2] aio-posix: disable fdmon-io_uring when GSource is used

2020-05-11 Thread Stefan Hajnoczi
The glib event loop does not call fdmon_io_uring_wait() so fd handlers waiting to be submitted build up in the list. There is no benefit is using io_uring when the glib GSource is being used, so disable it instead of implementing a more complex fix. This fixes a memory leak where AioHandlers would

[PATCH 0/2] aio-posix: fix fdmon-io_uring memory leak

2020-05-11 Thread Stefan Hajnoczi
This bug was introduced in QEMU 5.0 and causes guests to slow down because AioHandlers are not freed when the fdmon-io_uring file descriptor monitoring implementation is used by the main loop thread's glib event loop. This issue does not apply to IOThread usage of fdmon-io_uring. In practice few d

[PATCH 1/2] aio-posix: don't duplicate fd handler deletion in fdmon_io_uring_destroy()

2020-05-11 Thread Stefan Hajnoczi
The io_uring file descriptor monitoring implementation has an internal list of fd handlers that are pending submission to io_uring. fdmon_io_uring_destroy() deletes all fd handlers on the list. Don't delete fd handlers directly in fdmon_io_uring_destroy() for two reasons: 1. This duplicates the ai

Re: [PATCH v3 05/17] block/io: support int64_t bytes in bdrv_co_do_pwrite_zeroes()

2020-05-11 Thread Eric Blake
On 5/11/20 12:17 PM, Alberto Garcia wrote: On Thu 30 Apr 2020 01:10:21 PM CEST, Vladimir Sementsov-Ogievskiy wrote: compute 'int tail' via % 'int alignment' - safe tail = (offset + bytes) % alignment; both are int64_t, no chance of overflow here? Good question - I know several pla

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-11 Thread Eric Blake
On 5/11/20 6:50 AM, Max Reitz wrote: On 08.05.20 20:03, Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field, present when measuring an existin

[Bug 1877716] Re: Win10 guest unusable after a few minutes

2020-05-11 Thread Anatol Pomozov
Thank you Stefan for looking at this issue. As Alexander and @postfactum mentioned Arch disabled io_uring feature after this bug has been discovered. Here is an Arch Linux issue that tracks it https://bugs.archlinux.org/task/66578 -- You received this bug notification because you are a member of

Re: [PATCH v3 6/9] qemu-img: Add bitmap sub-command

2020-05-11 Thread Eric Blake
On 5/11/20 6:10 AM, Max Reitz wrote: On 08.05.20 20:03, Eric Blake wrote: Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it

Re: [PATCH v4 5/6] i386: Hyper-V VMBus ACPI DSDT entry

2020-05-11 Thread Roman Kagan
On Tue, May 05, 2020 at 03:06:37PM +0200, Igor Mammedov wrote: > On Fri, 24 Apr 2020 15:34:43 +0300 > Jon Doron wrote: > > > Guest OS uses ACPI to discover VMBus presence. Add a corresponding > > entry to DSDT in case VMBus has been enabled. > > > > Experimentally Windows guests were found to r

Re: [PATCH v3 3/9] block: Make it easier to learn which BDS support bitmaps

2020-05-11 Thread Eric Blake
On 5/11/20 4:21 AM, Max Reitz wrote: On 08.05.20 20:03, Eric Blake wrote: Upcoming patches will enhance bitmap support in qemu-img, but in doing so, it turns out to be nice to suppress output when bitmaps make no sense (such as on a qcow2 v2 image). Add a hook to make this easier to query. In

Re: [RFC PATCH 7/8] riscv: Add RV64M instructions description

2020-05-11 Thread Richard Henderson
On 4/30/20 12:21 AM, LIU Zhiwei wrote: > Signed-off-by: LIU Zhiwei > --- > riscv64.risu | 43 +++ > 1 file changed, 43 insertions(+) > > diff --git a/riscv64.risu b/riscv64.risu > index 98141ab..f006dc8 100644 > --- a/riscv64.risu > +++ b/riscv64.risu > @@

  1   2   3   4   5   >