Re: [PATCH 0/1] KVM support for VMD devices

2020-04-22 Thread Christoph Hellwig
On Wed, Apr 22, 2020 at 01:14:44PM -0400, Jon Derrick wrote: > The two patches (Linux & QEMU) add support for passthrough VMD devices > in QEMU/KVM. VMD device 28C0 already supports passthrough natively by > providing the Host Physical Address in a shadow register to the guest > for correct bridge

[PATCH RESEND v6 36/36] multi-process: add configure and usage information

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- MAINTAINERS | 2 + docs/multi-process.rst | 85 + scripts/mpqemu-launcher-perf-mode.py | 92 +

[PATCH RESEND v6 28/36] multi-process: send heartbeat messages to remote

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva In order to detect remote processes which are hung, the proxy periodically sends heartbeat messages to confirm if the remote process is alive Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva --- hw/proxy/qemu-proxy.c

[PATCH RESEND v6 14/36] multi-process: setup a machine object for remote device process

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman remote-machine object sets up various subsystems of the remote device process. Instantiate PCI host bridge object and initialize RAM, IO & PCI memory regions. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva --- MAINTAINERS

[PATCH RESEND v6 26/36] multi-process: add parse_cmdline in remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- MAINTAINERS | 2 ++ remote/Makefile.objs | 1 + remote/remote-main.c | 21 - remote/remote-opts.c | 75 r

[PATCH RESEND v6 24/36] multi-process: Retrieve PCI info from remote process

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Retrieve PCI configuration info about the remote device and configure the Proxy PCI object based on the returned information Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/proxy/qemu-proxy.c| 84 +++

[PATCH RESEND v6 11/36] multi-process: define mpqemu-link object

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Defines mpqemu-link object which forms the communication link between QEMU & emulation program. Adds functions to configure members of mpqemu-link object instance. Adds functions to send and receive messages over the communication channel. Adds GMainLoop to handle events r

[PATCH RESEND v6 17/36] multi-process: introduce proxy object

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Defines a PCI Device proxy object as a parent of TYPE_PCI_DEVICE. PCI Proxy Object registers as a PCI device with QEMU and forwards all PCI accesses to the remote process using the communication channel. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Sig

[PATCH RESEND v6 12/36] multi-process: add functions to synchronize proxy and remote endpoints

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman In some cases, for example MMIO read, QEMU has to wait for the remote to complete a command before proceeding. An eventfd based mechanism is added to synchronize QEMU & remote process. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena U

[PATCH RESEND v6 08/36] multi-process: Add stub functions to facilitate build of multi-process

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Add stub functions that are needed during compile time but not in runtime. To avoid duplicate symbol while linking for monitor_get_fd, put in a separate file. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva --- MAINTAINERS

[PATCH RESEND v6 35/36] multi-process: add the concept description to docs/devel/qemu-multiprocess

2020-04-22 Thread elena . ufimtseva
From: John G Johnson Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 + docs/devel/index.rst | 1 + docs/devel/multi-process.rst | 957 +++ 3 files changed, 959 inser

[PATCH RESEND v6 10/36] multi-process: build system for remote device process

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Modify Makefile to support the building of the remote device process. Implements main() function of remote device process. Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva --- MAINTAINERS | 8 ++ Makefile

[PATCH RESEND v6 02/36] multi-process: Refactor machine_init and exit notifiers

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Relocate machine_int and exit notifiers into common code Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- MAINTAINERS | 1 + Makefile.objs | 1 + include/sysemu/sysemu.h | 2 ++ softmm

[PATCH RESEND v6 32/36] multi-process/mon: stub functions to enable QMP module for remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva QMP module doesn't need some functions to run independently on the remote processes. However, these functions are necessary for compilation. Therefore, these functions are stub'ed out. The stub functions raise an assert if QEMU is built in debug mode (--enable-debug). Signe

[PATCH RESEND v6 34/36] multi-process/mon: Initialize QMP module for remote processes

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- remote/remote-main.c | 13 + remote/remote-opts.c | 11 +++ 2 files changed, 24 insertions(+) diff --git a/remote/remote-main.c b/remote/remote-main.c i

[PATCH RESEND v6 25/36] multi-process: Introduce build flags to separate remote process code

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Introduce SCSI_PROCESS & REMOTE_PROCESS build flags to separate code that applies only to remote processes. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- Makefile.target | 4 rules.mak | 2 +- 2 files change

[PATCH RESEND v6 27/36] multi-process: add support to parse device option

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Enable remote process to parse device command line option Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- remote/remote-opts.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/remote/remote-opts.c b/remote

[PATCH RESEND v6 30/36] multi-process: perform device reset in the remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Perform device reset in the remote process when QEMU performs device reset. This is required to reset the internal state (like registers, etc...) of emulated devices Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/pro

[PATCH RESEND v6 23/36] multi-process: create IOHUB object to handle irq

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman IOHUB object is added to manage PCI IRQs. It uses KVM_IRQFD ioctl to create irqfd to injecting PCI interrupts to the guest. IOHUB object forwards the irqfd to the remote process. Remote process uses this fd to directly send interrupts to the guest, bypassing QEMU. Signed-

[PATCH RESEND v6 20/36] multi-process: Forward PCI config space acceses to the remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva The Proxy Object sends the PCI config space accesses as messages to the remote process over the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- hw/proxy/qemu-proxy.c| 61

[PATCH RESEND v6 29/36] multi-process: handle heartbeat messages in remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva If the remote process is alive, it responds to proxy's heartbeat messages Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva --- remote/remote-main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/remote/remote-main.c

[PATCH RESEND v6 18/36] multi-process: Initialize Proxy Object's communication channel

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Add "socket" object property which initializes the communication channel Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- hw/proxy/qemu-proxy.c | 20 1 file changed, 20 insertions(+) diff --git a/h

[PATCH RESEND v6 15/36] multi-process: setup memory manager for remote device

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman sync_sysmem_msg_t message format is defined. It is used to send file descriptors of the RAM regions to remote device. RAM on the remote device is configured with a set of file descriptors. Old RAM regions are deleted and new regions, each with an fd, is added to the RAM.

[PATCH RESEND v6 16/36] multi-process: remote process initialization

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Adds the handler to process message from QEMU, Initialize remote process main loop, handles SYNC_SYSMEM message by updating its "system_memory" container using shared file descriptors received from QEMU. Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva Signe

[PATCH RESEND v6 33/36] multi-process/mon: enable QMP module support in the remote process

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Build system changes to enable QMP module in the remote process Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- Makefile.objs | 10 ++ Makefile.target | 35 ++

[PATCH RESEND v6 22/36] multi-process: Synchronize remote memory

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Add memory-listener object which is used to keep the view of the RAM in sync between QEMU and remote process. A MemoryListener is registered for system-memory AddressSpace. The listener sends SYNC_SYSMEM message to the remote process when memory listener commits the change

[PATCH RESEND v6 07/36] multi-process: add a command line option for debug file

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Can be used with -d rdebug command options when starting qemu. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Reviewed-by: Stefan Hajnoczi --- include/qemu/log.h | 1 + util/log.c | 2 ++ 2 files changed, 3 inserti

[PATCH RESEND v6 09/36] multi-process: Add config option for multi-process QEMU

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Add a configuration option to separate multi-process code Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Signed-off-by: Elena Ufimtseva --- configure | 11 +++ 1 file changed, 11 insertions(+) diff --git a/configure b/configure index 23b5e9375

[PATCH RESEND v6 21/36] multi-process: PCI BAR read/write handling for proxy & remote endpoints

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Proxy device object implements handler for PCI BAR writes and reads. The handler uses BAR_WRITE/BAR_READ message to communicate to the remote process with the BAR address and value to be written/read. The remote process implements handler for BAR_WRITE/BAR_READ message. S

[PATCH RESEND v6 31/36] multi-process/mon: choose HMP commands based on target

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Add "targets" field to HMP command definition to select the targets which would be supported by each command Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hmp-commands-info.hx | 10 ++ hmp-commands.hx | 20

[PATCH RESEND v6 13/36] multi-process: setup PCI host bridge for remote device

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman PCI host bridge is setup for the remote device process. It is implemented using remote-pcihost object. It is an extension of the PCI host bridge setup by QEMU. Remote-pcihost configures a PCI bus which could be used by the remote PCI device to latch on to. Signed-off-by:

[PATCH RESEND v6 05/36] multi-process: Refactor monitor functions out of vl.c

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Some of the initialization helper functions w.r.t monitor in vl.c are also used by the remote process. Therefore, these functions are refactored into shared files that both QEMU & remote process could use. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signe

[PATCH RESEND v6 06/36] monitor: destaticize HMP commands

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Dr. David Alan Gilbert --- hmp-commands.hx| 4 +- monitor/misc.c | 76 +++--- monitor/monitor-internal.h

[PATCH RESEND v6 19/36] multi-process: Connect Proxy Object with device in the remote process

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Send a message to the remote process to connect PCI device with the corresponding Proxy object in QEMU Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman --- hw/proxy/qemu-proxy.c| 34 +++ incl

[PATCH RESEND v6 01/36] memory: alloc RAM from file at offset

2020-04-22 Thread elena . ufimtseva
From: Jagannathan Raman Allow RAM MemoryRegion to be created from an offset in a file, instead of allocating at offset of 0 by default. This is needed to synchronize RAM between QEMU & remote process. Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson Signed-off-by: Elena Ufimtseva

[PATCH RESEND v6 03/36] command-line: refractor parser code

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Refactor command-line parser code so that it could be used by other processes as well. Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-by: John G Johnson --- MAINTAINERS | 2 + Makefile.objs| 2 + include/qemu-parse.h | 42 +

[PATCH RESEND v6 04/36] multi-process: Refactor chardev functions out of vl.c

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Some of the initialization helper functions w.r.t chardev in vl.c are also used by the remote process. Therefore, these functions are refactored into shared files that both QEMU & remote process could use. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signe

[PATCH RESEND v6 00/36] Initial support for multi-process qemu

2020-04-22 Thread elena . ufimtseva
From: Elena Ufimtseva Hello This is a resend of v6 patchset since we regrettably omitted few comments from v5 review in the previously sent series (see in https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg00828.html). We also run more tests and fixed the build errors that were found in v

[PATCH v2] qemu-sockets: add abstract UNIX domain socket support

2020-04-22 Thread xiaoqiang zhao
unix_connect_saddr now support abstract address type By default qemu does not support abstract UNIX domain socket address. Add this ability to make qemu handy when abstract address is needed. Abstract address is marked by prefixing the address name with a '@'. Signed-off-by: xiaoqiang zhao ---

Re: [PATCH] qemu-sockets: add abstract UNIX domain socket support

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200423023212.20968-1-zxq_yx_...@163.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] qemu-sockets: add abstract UNIX domain socket support Message-id: 20200423023212.20968-1-zxq_yx_...

Re: [PATCH] qemu-sockets: add abstract UNIX domain socket support

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200423023212.20968-1-zxq_yx_...@163.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash expor

Re: [edk2-discuss] Load Option passing. Either bugs or my confusion.

2020-04-22 Thread Hou Qiming
> > > > And when the user provides an EDID one should parse it and set the > default > > resolution to match it. But that's a less important feature. > > It's more complex than you might think, and (to me personally) it seems > to require more time than its importance justifies. > > https://bugzill

[PATCH] qemu-sockets: add abstract UNIX domain socket support

2020-04-22 Thread xiaoqiang zhao
unix_connect_saddr now support abstract address type By default qemu does not support abstract UNIX domain socket address. Add this ability to make qemu handy when abstract address is needed. Abstract address is marked by prefixing the address name with a '@'. Signed-off-by: xiaoqiang zhao ---

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread LIU Zhiwei
On 2020/4/22 12:10, Richard Henderson wrote: On 4/21/20 7:34 PM, LIU Zhiwei wrote: Ping. When I port RISU, I find this bug. I can't get the correct registers from the struct ucontext_t parameter in the signal handler. The RISC-V Linux ABI will need to be extended to handle RVV state. There

[PATCH v3 0/4] Introduce Xilinx ZynqMP CAN controller

2020-04-22 Thread Vikram Garhwal
Example for single CAN: -object can-bus,id=canbus0 \ -global driver=xlnx.zynqmp-can,property=canbus0,value=canbus0 \ -object can-host-socketcan,id=socketcan0,if=vcan0,canbus=canbus0 Example for connecting both CAN: -object can-bus,id=canbus0 -object can-bus,id=canbus1 \

[PATCH v3 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controller

2020-04-22 Thread Vikram Garhwal
Connect CAN0 and CAN1 to ZCU102 board. Signed-off-by: Vikram Garhwal --- hw/arm/xlnx-zynqmp.c | 26 ++ include/hw/arm/xlnx-zynqmp.h | 3 +++ 2 files changed, 29 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index b84d153..e5f0d9f 100644

[PATCH v3 4/4] MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN

2020-04-22 Thread Vikram Garhwal
Add myself as Xilinx CAN maintainer. Signed-off-by: Vikram Garhwal --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8cbc1fa..6223573 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1433,6 +1433,13 @@ F: hw/net/opencores_eth.c Devices -

[PATCH v3 3/4] tests/qtest: Introduce tests for Xilinx ZyqnMP CAN controller

2020-04-22 Thread Vikram Garhwal
Qtest performs five tests on Xlnx-CAN controller: It checks communication between CAN0 and CAN1 via can-bus. Tests CAN in loopback, sleep and snoop mode. Tests CAN filtering for incoming messages. Signed-off-by: Vikram Garhwal --- tests/qtest/Makefile.include | 2 + tes

[PATCH v3 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

2020-04-22 Thread Vikram Garhwal
XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Signed-off-by: Vikram Garhwal --- hw/net/can/Makefile.objs |1 + hw/net/can/xlnx-zynqmp-can.c | 1113 +++

Re: [PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread Andrzej Jakowski
On 4/22/20 10:13 AM, Jon Derrick wrote: > The VMD endpoint provides a real PCIe domain to the guest, including > bridges and endpoints. The IOMMU performs Host Physical Address to Guest > Physical Address translation when assigning downstream endpoint BARs and > when translating MMIO addresses. > >

Re: [PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread Derrick, Jonathan
On Wed, 2020-04-22 at 14:36 -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200422171305.10923-1-jonathan.derr...@intel.com/ > > > > Hi, > > This series failed the asan build test. Please find the testing commands and > their output below. If you have Docker inst

Re: [PATCH] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Anthoine Bourgeois
On Wed, Apr 22, 2020 at 12:46:57PM +0200, Gerd Hoffmann wrote: This fix exchange the modern io bar with the modern memory bar, replacing the msix bar that is never impacted anyway. Well, msix was placed in bar 4 intentionally. That keeps bar 1 (default msix location) free, so we have the optio

[PATCH v2 1/2] virtio-vga: fix virtio-vga bar ordering

2020-04-22 Thread Anthoine Bourgeois
With virtio-vga, pci bar are reordered. Bar #2 is used for compatibility with stdvga. By default, bar #2 is used by virtio modern io bar. This bar is the last one introduce in the virtio pci bar layout and it's crushed by the virtio-vga reordering. So virtio-vga and modern-pio-notify are incompatib

[PATCH v2 2/2] virtio-pci: update virtio pci bar layout documentation

2020-04-22 Thread Anthoine Bourgeois
The modern io bar was never documented. Signed-off-by: Anthoine Bourgeois --- hw/virtio/virtio-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 4cb784389c..d028c17c24 100644 --- a/hw/virtio/virtio-pci.c +++ b/hw/virtio/virtio-pci.c @

Re: [PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200422171305.10923-1-jonathan.derr...@intel.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200422171305.10923-1-jonathan.derr...@intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Alistair Francis
On Wed, Apr 22, 2020 at 12:20 PM Richard Henderson wrote: > > On 4/22/20 11:05 AM, Alistair Francis wrote: > > Just to clarify, this patch is still correct right? > > Yes. That's what I thought. Thanks :) Applied to the RISC-V tree for 5.1. Alistair > > > r~

[PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-22 Thread Eric Blake
We originally refused to allow resize of images with internal snapshots because the v2 image format did not require the tracking of snapshot size, making it impossible to safely revert to a snapshot with a different size than the current view of the image. But the snapshot size tracking was rectif

Re: [PATCH v2 00/14] Miscellaneous error handling fixes

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200422130719.28225-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 00/14] Miscellaneous error handling fixes Message-id: 20200422130719.28225-1-arm...@redhat.com Typ

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson We have a regression. Setting up a build dir with: ../../configure --disable-tools --disable-docs --target-list=sparc-softmmu,sparc64-softmmu make -j30 && make check-acceptance And then running a bisect between HEAD and maste

Re: [PATCH v2 09/36] tcg: Consolidate 3 bits into enum TCGTempKind

2020-04-22 Thread Aleksandar Markovic
сре, 22. апр 2020. у 03:27 Richard Henderson је написао/ла: > > The temp_fixed, temp_global, temp_local bits are all related. > Combine them into a single enumeration. > > Signed-off-by: Richard Henderson > --- > include/tcg/tcg.h | 20 +--- > tcg/optimize.c| 8 +-- > tcg/tcg.c

Re: qemu 4.2.0 audiodev soundhw

2020-04-22 Thread BALATON Zoltan
On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: Hi Jakob, On 4/21/20 12:06 AM, Jakob Bohm wrote: [...] In fact, over the years, I have found it excruciatingly difficult to find valid qemu documentation, as each feature effort tends to leave behind half-updated pages and a bunch of uncoordin

Re: [PATCH v2 24/36] tcg/i386: Use tcg_constant_vec with tcg vec expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/i386/tcg-target.inc.c | 26 +- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c > index 9cb627

Re: [PATCH v2 23/36] tcg: Add tcg_reg_alloc_dup2

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > There are several ways we can expand a vector dup of a 64-bit > element on a 32-bit host. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 88 +++ > 1 file changed, 88 insertions(+) > > diff --git a/tcg/tc

Re: [PATCH v2 22/36] tcg: Increase tcg_out_dupi_vec immediate to int64_t

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > While we don't store more than tcg_target_long in TCGTemp, > we shouldn't be limited to that for code generation. We will > be able to use this for INDEX_op_dup2_vec with 2 constants. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aar

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Eric Blake
On 4/22/20 1:24 PM, Vladimir Sementsov-Ogievskiy wrote: So, I think the simplest way is to add .bdrv_co_pwritev_zeros64 and .bdrv_co_pdiscard64 and update drivers one-by-one. If at some point all drivers updated - drop unused 32bit functions, and then drop "64" suffix from API. If not - we'll li

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-04-22 Thread BALATON Zoltan
On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus Armbruster wrote: The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL.  Passing an argument of the latter kind twice wi

Re: [PATCH v2 21/36] tcg: Use tcg_out_dupi_vec from temp_load

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Having dupi pass though movi is confusing and arguably wrong. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > tcg/aarch64/tcg-target.inc.c | 7 > tcg/i386/tcg-target.inc.c| 63 > tcg/ppc/tcg-ta

[ANNOUNCE] QEMU 5.0.0-rc4 is now available

2020-04-22 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fifth release candidate for the QEMU 5.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-5.0.0-rc4.tar.xz http://downl

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Richard Henderson
On 4/22/20 11:05 AM, Alistair Francis wrote: > Just to clarify, this patch is still correct right? Yes. r~

Re: [PATCH v2 20/36] tcg: Remove movi and dupi opcodes

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > These are now completely covered by mov from a > TYPE_CONST temporary. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/tcg/tcg-opc.h| 3 --- > tcg/aarch64/tcg-target.inc.c | 3 --- > tcg/arm/tcg-target.inc.c | 1 - >

Re: [PATCH v2 19/36] tcg/tci: Add special tci_movi_{i32,i64} opcodes

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > The normal movi opcodes are going away. We need something > for TCI to use internally. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > include/tcg/tcg-opc.h| 8 > tcg/tci.c| 4 ++-- > tcg/tci/tcg-target.inc.c |

Re: [PATCH v2 17/36] tcg/optimize: Adjust TempOptInfo allocation

2020-04-22 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> Do not allocate a large block for indexing. Instead, allocate >> for each temporary as they are seen. >> >> In general, this will use less memory, if we consider that most >> TBs do not touch every target register. This also allows us to >

Re: [PATCH v2 18/36] tcg/optimize: Use tcg_constant_internal with constant folding

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2 0/4] smbus: SPD fixes

2020-04-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200422134815.1584-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v2 0/4] smbus: SPD fixes Message-id: 20200422134815.1584-1-arm...@redhat.com Type: series === TEST SC

Re: [RFC 0/3] 64bit block-layer part I

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
30.03.2020 17:18, Vladimir Sementsov-Ogievskiy wrote: Hi all! There is an idea to make NBD protocol extension to support 64bit write-zero/discard/block-status commands (commands, which doesn't transfer user data). It's needed to increase performance of zeroing large ranges (up to the whole image

[PATCH v21 QEMU 2/5] linux-headers: update to contain virito-balloon free page reporting

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Sync the latest upstream changes for free page reporting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/standard-headers/linux/v

[PATCH v21 QEMU 5/5] virtio-balloon: Provide an interface for free page reporting

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Add support for free page reporting. The idea is to function very similar to how the balloon works in that we basically end up madvising the page as not being used. However we don't really need to bother with any deflate type logic since the page will be faulted back into th

[PATCH v21 QEMU 4/5] virtio-balloon: Implement support for page poison tracking feature

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck We need to make certain to advertise support for page poison tracking if we want to actually get data on if the guest will be poisoning pages. Add a value for tracking the poison value being used if page poisoning is enabled. With this we can determine if we will need to sk

[PATCH v21 QEMU 3/5] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck In an upcoming patch a feature named Free Page Reporting is about to be added. In order to avoid any confusion we should drop the use of the word 'report' when referring to Free Page Hinting. So what this patch does is go through and replace all instances of 'report' with 'h

[PATCH v21 QEMU 1/5] linux-headers: Update to allow renaming of free_page_report_cmd_id

2020-04-22 Thread Alexander Duyck
From: Alexander Duyck Sync to the latest upstream changes for free page hinting. To be replaced by a full linux header sync. Signed-off-by: Alexander Duyck --- include/standard-headers/linux/virtio_balloon.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/incl

[PATCH v21 QEMU 0/5] virtio-balloon: add support for free page reporting

2020-04-22 Thread Alexander Duyck
This series provides an asynchronous means of reporting free guest pages to QEMU through virtio-balloon so that the memory associated with those pages can be dropped and reused by other processes and/or guests on the host. Using this it is possible to avoid unnecessary I/O to disk and greatly impro

Re: [PATCH] linux-user/riscv: fix up struct target_ucontext definition

2020-04-22 Thread Alistair Francis
On Tue, Apr 21, 2020 at 9:10 PM Richard Henderson wrote: > > On 4/21/20 7:34 PM, LIU Zhiwei wrote: > > Ping. > > > > When I port RISU, I find this bug. I can't get the correct registers from > > the > > struct ucontext_t parameter in the signal handler. > > The RISC-V Linux ABI will need to be ex

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
22.04.2020 20:42, Alberto Garcia wrote: On Wed 22 Apr 2020 01:35:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: 17.03.2020 21:16, Alberto Garcia wrote: Two changes are needed in this function: 1) A full discard deallocates a cluster so we can skip the operation if it is already unallocat

Re: [PATCH v2 13/36] tcg: Use tcg_constant_{i32,i64} with tcg int expanders

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > On 4/22/20 9:18 AM, Alex Bennée wrote: >>> void tcg_gen_brcondi_i64(TCGCond cond, TCGv_i64 arg1, int64_t arg2, >>> TCGLabel *l) >>> { >>> -if (cond == TCG_COND_ALWAYS) { >>> +if (TCG_TARGET_REG_BITS == 64) { >>> +tcg_gen_brcond_i64(cond, arg1, tcg_

Re: [PATCH v2 17/36] tcg/optimize: Adjust TempOptInfo allocation

2020-04-22 Thread Alex Bennée
Richard Henderson writes: > Do not allocate a large block for indexing. Instead, allocate > for each temporary as they are seen. > > In general, this will use less memory, if we consider that most > TBs do not touch every target register. This also allows us to > allocate TempOptInfo for new

[PATCH for QEMU] hw/vfio: Add VMD Passthrough Quirk

2020-04-22 Thread Jon Derrick
The VMD endpoint provides a real PCIe domain to the guest, including bridges and endpoints. The IOMMU performs Host Physical Address to Guest Physical Address translation when assigning downstream endpoint BARs and when translating MMIO addresses. This translation is not desired when assigning bri

[PATCH 0/1] KVM support for VMD devices

2020-04-22 Thread Jon Derrick
The two patches (Linux & QEMU) add support for passthrough VMD devices in QEMU/KVM. VMD device 28C0 already supports passthrough natively by providing the Host Physical Address in a shadow register to the guest for correct bridge programming. The QEMU patch emulates the 28C0 mode by creating a sha

Re: [PATCH 2/3] block/io: convert generic io path to use int64_t parameters

2020-04-22 Thread Vladimir Sementsov-Ogievskiy
22.04.2020 18:50, Stefan Hajnoczi wrote: On Mon, Mar 30, 2020 at 05:18:17PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -875,9 +875,9 @@ static bool coroutine_fn bdrv_wait_serialising_requests(BdrvTrackedRequest *self } static int bdrv_check_byte_request(BlockDriverState *bs, int64_t o

[PATCH 1/1] pci: vmd: Use Shadow MEMBAR registers for QEMU/KVM guests

2020-04-22 Thread Jon Derrick
VMD device 28C0 provides native guest passthrough of the VMD endpoint through the use of shadow registers that provide Host Physical Addresses to correctly assign bridge windows. A quirk has been added to QEMU's VFIO quirks to emulate the shadow registers for VMD devices which don't support this mo

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-22 Thread Alistair Francis
On Tue, Apr 21, 2020 at 6:30 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Apr 21, 2020 at 9:34 AM Bin Meng wrote: > > > > Hi Alistair, > > > > On Tue, Apr 21, 2020 at 2:41 AM Alistair Francis > > wrote: > > > > > > On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > > > > > > > Upgrade Open

Re: [PATCH] roms: opensbi: Upgrade from v0.6 to v0.7

2020-04-22 Thread Alistair Francis
On Mon, Apr 20, 2020 at 6:34 PM Bin Meng wrote: > > Hi Alistair, > > On Tue, Apr 21, 2020 at 2:41 AM Alistair Francis wrote: > > > > On Mon, Apr 20, 2020 at 6:25 AM Bin Meng wrote: > > > > > > Upgrade OpenSBI from v0.6 to v0.7 and the pre-built bios images. > > > > > > The v0.7 release includes

Re: [PATCH for-5.0?] target/arm: Fix ID_MMFR4 value on AArch64 'max' CPU

2020-04-22 Thread Philippe Mathieu-Daudé
On Wed, Apr 22, 2020 at 7:41 PM Philippe Mathieu-Daudé wrote: > > On 4/22/20 2:45 PM, Peter Maydell wrote: > > In commit 41a4bf1feab098da4cd the added code to set the CNP > > field in ID_MMFR4 for the AArch64 'max' CPU had a typo > > where it used the wrong variable name, resulting in ID_MMFR4 > >

Re: [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice()

2020-04-22 Thread Alberto Garcia
On Wed 22 Apr 2020 01:35:25 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > 17.03.2020 21:16, Alberto Garcia wrote: >> Two changes are needed in this function: >> >> 1) A full discard deallocates a cluster so we can skip the operation if >> it is already unallocated. With extended L2 entries ho

Re: [PATCH for-5.0?] target/arm: Fix ID_MMFR4 value on AArch64 'max' CPU

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 2:45 PM, Peter Maydell wrote: In commit 41a4bf1feab098da4cd the added code to set the CNP field in ID_MMFR4 for the AArch64 'max' CPU had a typo where it used the wrong variable name, resulting in ID_MMFR4 fields AC2, XNX and LSM being wrong. Fix the typo. Fixes: 41a4bf1feab098da4cd R

Re: [PATCH 1/8] docker.py/build: support -t and -f arguments

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 7:23 PM, Paolo Bonzini wrote: The docker.py command line is subtly different from docker and podman's, in that the tag and Dockerfile are passed via positional arguments. Remove this gratuitous difference and just parse -f and -t. -f was previously used by --extra-files, only keep the

Re: [PATCH 2/8] docker.py/build: support binary files in --extra-files

2020-04-22 Thread Philippe Mathieu-Daudé
On 4/22/20 7:23 PM, Paolo Bonzini wrote: Read the --extra-files in binary mode to avoid encoding errors. Signed-off-by: Paolo Bonzini --- tests/docker/docker.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index a

Re: FYI GitHub pull request / issue tracker lockdown bot

2020-04-22 Thread Paolo Bonzini
On 22/04/20 18:01, Stefan Hajnoczi wrote: > On Fri, Apr 03, 2020 at 03:22:13PM +0100, Daniel P. Berrangé wrote: >> QEMU, like libvirt, has a github.com project which contains automated >> read-only mirrors of QEMU repositories. >> >> https://github.com/qemu/ >> >> An unfortunate side effect of th

[PATCH 5/8] run-coverity-scan: add --no-update-tools option

2020-04-22 Thread Paolo Bonzini
Provide a quick way to skip building the container while we figure out how to get caching right. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/scripts/coverity-scan/run-cove

[PATCH 3/8] run-coverity-scan: get Coverity token and email from special git config section

2020-04-22 Thread Paolo Bonzini
Support a [coverity] section in .git/config. It can be used to retrieve the token and also, if it is different from user.email, the username of the submitter. Signed-off-by: Paolo Bonzini --- scripts/coverity-scan/run-coverity-scan | 20 +--- 1 file changed, 13 insertions(+), 7

  1   2   3   >