Patchew URL:
https://patchew.org/QEMU/20200408003552.58095-1-mansour...@gmail.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ==
Le 31/03/2020 à 00:29, Brice Goglin a écrit :
> Le 31/03/2020 à 00:05, Philippe Mathieu-Daudé a écrit :
>> On 3/30/20 9:07 PM, Brice Goglin wrote:
>>> When the program name is very long, qemu-user may truncate it in
>>> /proc/self/stat. However the truncation must keep the ending ") "
>>> to confor
Patchew URL:
https://patchew.org/QEMU/20200408003552.58095-1-mansour...@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN =
Patchew URL:
https://patchew.org/QEMU/20200408003552.58095-1-mansour...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] When updating the PFLASH file contents, we should check for a
possible failure of blk_pwrite().
I'll update with your feedback.
Cameron Esfahani
di...@apple.com
"We do what we must because we can."
Aperture Science
> On Apr 5, 2020, at 11:51 AM, Roman Bolshakov wrote:
>
> On Mon, Mar 30, 2020 at 05:16:05PM -0700, Cameron Esfahani wrote:
>> Signed-off-by: Cameron Esfahani
>> ---
>> ta
Responses inline
Cameron Esfahani
di...@apple.com
"We do what we must because we can."
Aperture Science
> On Apr 5, 2020, at 10:58 AM, Roman Bolshakov wrote:
>
> On Mon, Mar 30, 2020 at 05:16:04PM -0700, Cameron Esfahani wrote:
>> Signed-off-by: Cameron Esfahani
>> ---
>> target/i386/cpu.h
On Apr 1 11:42, Andrzej Jakowski wrote:
> This patch sets CMBS bit in controller capabilities register when user
> configures NVMe driver with CMB support, so capabilites are correctly reported
> to guest OS.
>
> Signed-off-by: Andrzej Jakowski
> ---
> hw/block/nvme.c | 2 ++
> include/blo
On Tue, Apr 07, 2020 at 08:44:47PM -0700, Richard Henderson wrote:
> On 4/7/20 7:10 PM, David Gibson wrote:
> >> Should we in fact disable ppc64abi32?
> >> I can't see how it could work enough to be useful as-is.
> >
> > Yeah, I think so. Last time we had a problem in this area, I couldn't
> > ev
On 07/04/2020, Maciej S. Szmigiero wrote:
On 07.04.2020 20:56, Roman Kagan wrote:
On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote:
Well I want it to be merged in :-)
Hmm I'm curious why, it has little to offer over virtio.
Anyway the series you've posted seems to be based on a fair
On 4/7/20 7:10 PM, David Gibson wrote:
>> Should we in fact disable ppc64abi32?
>> I can't see how it could work enough to be useful as-is.
>
> Yeah, I think so. Last time we had a problem in this area, I couldn't
> even figure out what ppc64abi32 was supposed to *be*, let alone what
> the use ca
On Fri, Apr 03, 2020 at 05:11:29PM +0200, Greg Kurz wrote:
> On Fri, 3 Apr 2020 16:00:56 +0200
> Cédric Le Goater wrote:
>
> > The Radix tree translation model currently supports process-scoped
> > translation for the PowerNV machine (Hypervisor mode) and for the
> > pSeries machine (Guest mode)
On Fri, Apr 03, 2020 at 04:00:53PM +0200, Cédric Le Goater wrote:
> This is moving code under a new ppc_radix64_xlate() routine shared by
> the MMU Radix page fault handler and the 'get_phys_page_debug' PPC
> callback. The difference being that 'get_phys_page_debug' does not
> generate exceptions.
On Tue, Apr 07, 2020 at 12:20:15PM +0100, Peter Maydell wrote:
> On Tue, 7 Apr 2020 at 12:16, Claudio Fontana wrote:
> >
> > if fdt is required, and the system DTC (libfdt) is not usable,
> > check for the dtc submodule requirements before trying to build it,
> > and error out with a helpful messa
On Mon, Apr 06, 2020 at 08:21:05PM -0700, Richard Henderson wrote:
> The padding that was added in 95cda4c44ee was added to a union,
> and so it had no effect. This fixes misalignment errors detected
> by clang sanitizers for ppc64 and ppc64le.
>
> In addition, only ppc64 allocates space for VSX
Hi all,
Hotplug of vhost-user-blk doesn't not work in qemu master branch and
all previous version.
The action I insert a vhost-user-blk disk is:
(qemu) chardev-add socket,id=spdk_vhost_blk2,path=/vhost-blk.0,reconnect=1
(qemu) device_add
vhost-user-blk-pci,chardev=spdk_vhost_blk2,id=spdk_vhost_bl
On 4/8/2020 2:28 AM, Joao Martins wrote:
On 4/7/20 5:55 PM, Dan Williams wrote:
On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote:
On 4/1/20 4:13 AM, Jingqi Liu wrote:
If the backend file is devdax pmem character device, the alignment
specified by the option 'align=NUM' in the '-object memory
On Mon, Mar 30, 2020 at 10:20:41PM +0530, Kirti Wankhede wrote:
> VFIO_IOMMU_DIRTY_PAGES ioctl performs three operations:
> - Start dirty pages tracking while migration is active
> - Stop dirty pages tracking.
> - Get dirty pages bitmap. Its user space application's responsibility to
> copy conte
On 4/7/2020 11:51 PM, Joao Martins wrote:
On 4/7/20 3:31 PM, Paolo Bonzini wrote:
On 07/04/20 12:59, Joao Martins wrote:
Perhaps, you meant instead:
/sys/dev/char/%d:%d/align
?
Hi Joao,
In my machine with real NVDIMM, the devdax device is as follows:
$ ll /dev/dax0.0
crw---
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
third release candidate for the QEMU 5.0 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-5.0.0-rc2.tar.xz
http://downl
Signed-off-by: Mansour Ahmadi
---
hw/block/pflash_cfi01.c | 6 +-
hw/block/pflash_cfi02.c | 6 +-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
index 24f3bce7ef..31319cfd07 100644
--- a/hw/block/pflash_cfi01.c
+++ b/hw/bl
Ping for comments
On 3/24/2020 1:10 PM, Xu, Tao3 wrote:
Add which features are added or removed in this version.
Signed-off-by: Tao Xu
---
The output is as follows:
qemu-system-x86_64 -cpu help | grep "\["
x86 Cascadelake-Server-v2 Intel Xeon Processor (Cascadelake)
[ARCH_CAPABILITIES]
x86
tags/20200407-xtensa
for you to fetch changes up to fde557ad25ff3370ef1dd0587d299a86e060bb23:
target/xtensa: statically allocate xtensa_insnbufs in DisasContext
(2020-04-07 16:08:11 -0700)
target/xtensa fixes for 5.0:
- fix
On Tue, 7 Apr 2020 at 16:51, Alex Bennée wrote:
>
> The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06
> 12:36:45 +0100)
>
> are available in the Git repositor
It is working now. Tested with 4.1.1, 4.2 and 5rc1.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1859916
Title:
coreaudio not working on MacOS
S
I recently test it again, coreaudio is working on 4.1.1, 4.2 and 5rc1 on
MacOS.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1859916
Title:
coreaudio not working on MacOS
Status in QEMU:
Invali
11:32 Uto, 07.04.2020. Philippe Mathieu-Daudé је
написао/ла:
>
> On 4/7/20 11:23 AM, Philippe Mathieu-Daudé wrote:
> > On 4/7/20 10:35 AM, Peter Maydell wrote:
> >> On Tue, 7 Apr 2020 at 00:55, Philippe Mathieu-Daudé
> >> wrote:
> >>>
> >>> Using the BC1ANY4F instruction with a 24Kf core (MIPS32R
On Tue, 7 Apr 2020 at 16:22, Anthony PERARD wrote:
>
> The following changes since commit 8f0d25c464a1989d606f7b988d07b1147dfcde33:
>
> Merge remote-tracking branch
> 'remotes/philmd-gitlab/tags/acceptance-fixes-20200407' into staging
> (2020-04-07 15:10:11 +0100)
On 4/7/20 12:09 PM, Max Filippov wrote:
> Rather than dynamically allocate, and risk failing to free
> when we longjmp out of the translator, allocate the maximum
> buffer size based on the maximum supported instruction length.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Max Filippov
>
On 4/7/20 12:17 PM, Max Filippov wrote:
> On Tue, Apr 7, 2020 at 12:07 PM Richard Henderson
> wrote:
>>
>> From: Max Filippov
>>
>> Rather than dynamically allocate, and risk failing to free
>> when we longjmp out of the translator, allocate the maximum
>> buffer size from any of the supported cp
If my memory is correct, this problem doesn't need qemu to execute the
code, it only needs it to translate the code. In the original test case
the invalid instructions were actually dead code but still managed to
crash qemu.
I suggest following Yongbok Kim's approach and signalling Reserved
Instr
On Tue, 7 Apr 2020 at 15:26, Kevin Wolf wrote:
>
> The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06
> 12:36:45 +0100)
>
> are available in the Git repository
[adding libvirt list]
On 4/7/20 2:13 PM, Tim Haley wrote:
Hi all,
Have been playing with `virsh backup-begin` of late and think it's an
excellent feature. I've noticed one behavior I'm not sure I understand.
It looks like https://bugzilla.redhat.com/show_bug.cgi?id=1814664 is a
similar des
On Tue, Apr 7, 2020 at 12:07 PM Richard Henderson
wrote:
>
> From: Max Filippov
>
> Rather than dynamically allocate, and risk failing to free
> when we longjmp out of the translator, allocate the maximum
> buffer size from any of the supported cpus.
>
> Signed-off-by: Max Filippov
> [rth: Merge
> Hi,
>
> I'm running the latest (master) of QEMU, though the version doesn't seem
> to matter - I also checked back to v4.2.0, exactly the same issue. And
> this isn't about the VM (guest), if I even just try to run,
>
>> "c:\Program Files\qemu\qemu-system-x86_64.exe" -accel hax
Hi Russell,
at t
Hi all,
Have been playing with `virsh backup-begin` of late and think it's an
excellent feature. I've noticed one behavior I'm not sure I understand.
Am doing pretty straight-forward backup of boot disk:
# cat bx
# cat cx
2aa450cc-6d2e-11ea-8de0-52542e0d008a
Rather than dynamically allocate, and risk failing to free
when we longjmp out of the translator, allocate the maximum
buffer size based on the maximum supported instruction length.
Suggested-by: Richard Henderson
Signed-off-by: Max Filippov
---
target/xtensa/cpu.h | 3 +++
target/xtensa
From: Max Filippov
Rather than dynamically allocate, and risk failing to free
when we longjmp out of the translator, allocate the maximum
buffer size from any of the supported cpus.
Signed-off-by: Max Filippov
[rth: Merged the fixup in Max's reply to his original]
Signed-off-by: Richard Henders
When I reread the thread I see Brian was doing some testing/fuzzing,
that's why he found that out.
I managed to get my old router running. It's BCM5354 (BCM3302 v2.9) running on
Linux 2.4.35.
I used the following code (gnu as compiled but replaced the nop after branch
with the branch instruction
On 07.04.2020 20:56, Roman Kagan wrote:
> On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote:
>> Well I want it to be merged in :-)
>
> Hmm I'm curious why, it has little to offer over virtio.
>
> Anyway the series you've posted seems to be based on a fairly old
> version.
>
> The one in
On Mon, Apr 06, 2020 at 11:20:39AM +0300, Jon Doron wrote:
> Well I want it to be merged in :-)
Hmm I'm curious why, it has little to offer over virtio.
Anyway the series you've posted seems to be based on a fairly old
version.
The one in openvz repo is more recent. It's still in need for
impro
On 4/6/20 10:47 AM, Philippe Mathieu-Daudé wrote:
> Running the coccinelle script produced:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h --include-headers \
> --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
> --keep-comments --smpl-spacing --dir .
> HA
On 07/04/20 20:28, Joao Martins wrote:
> On 4/7/20 5:55 PM, Dan Williams wrote:
>> On Tue, Apr 7, 2020 at 4:01 AM Joao Martins
>> wrote:
>>> On 4/1/20 4:13 AM, Jingqi Liu wrote:
If the backend file is devdax pmem character device, the alignment
specified by the option 'align=NUM' in the
On 4/7/20 5:55 PM, Dan Williams wrote:
> On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote:
>> On 4/1/20 4:13 AM, Jingqi Liu wrote:
>>> If the backend file is devdax pmem character device, the alignment
>>> specified by the option 'align=NUM' in the '-object memory-backend-file'
>>> needs to match
On Tue, Apr 7, 2020 at 7:55 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> 07.04.2020 20:27, Philippe Mathieu-Daudé wrote:
> > On 4/7/20 3:07 PM, Philippe Mathieu-Daudé wrote:
> >> On 4/7/20 3:01 PM, Vladimir Sementsov-Ogievskiy wrote:
> >>> 07.04.2020 14:03, Philippe Mathieu-Daudé wrote:
> On 4/
On Tue, 7 Apr 2020 at 13:37, Max Reitz wrote:
>
> The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06
> 12:36:45 +0100)
>
> are available in the Git repository
07.04.2020 20:27, Philippe Mathieu-Daudé wrote:
On 4/7/20 3:07 PM, Philippe Mathieu-Daudé wrote:
On 4/7/20 3:01 PM, Vladimir Sementsov-Ogievskiy wrote:
07.04.2020 14:03, Philippe Mathieu-Daudé wrote:
On 4/7/20 9:07 AM, Vladimir Sementsov-Ogievskiy wrote:
06.04.2020 20:47, Philippe Mathieu-Dau
07.04.2020 19:27, Kevin Wolf wrote:
Am 07.04.2020 um 16:56 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.04.2020 17:42, Kevin Wolf wrote:
Am 07.04.2020 um 16:22 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.04.2020 15:12, Kevin Wolf wrote:
External callers of blk_co_*() and of the synch
On 4/7/20 3:07 PM, Philippe Mathieu-Daudé wrote:
On 4/7/20 3:01 PM, Vladimir Sementsov-Ogievskiy wrote:
07.04.2020 14:03, Philippe Mathieu-Daudé wrote:
On 4/7/20 9:07 AM, Vladimir Sementsov-Ogievskiy wrote:
06.04.2020 20:47, Philippe Mathieu-Daudé wrote:
The instance_init() calls are not supp
On Tue, Apr 7, 2020 at 1:07 PM Oksana Vohchana wrote:
>
> Adds test for RDMA migration check
>
> Signed-off-by: Oksana Vohchana
> ---
> tests/acceptance/migration.py | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.
On Tue, Apr 7, 2020 at 1:07 PM Oksana Vohchana wrote:
>
> Provides new functions related to the rdma migration test
> Adds functions to check if service RDMA is enabled and gets
> the ip address on the interface where it was configured
>
> Signed-off-by: Oksana Vohchana
> ---
> tests/acceptance/
On Tue, Apr 7, 2020 at 1:05 PM Oksana Vohchana wrote:
>
> In the migration test function _get_free_port works only for localhost,
> but in the case to use migration through an RDMA we need to get a free port
> on the configured network RDMA-interface.
> This patch is the start for another migratio
On 4/7/20 7:07 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> docs/devel/rcu.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On 4/7/20 4:54 PM, David Hildenbrand wrote:
On 07.04.20 16:34, Michael S. Tsirkin wrote:
On Tue, Apr 07, 2020 at 04:17:46PM +0200, Philippe Mathieu-Daudé wrote:
On 4/3/20 12:18 PM, Shameer Kolothum wrote:
Any sub-page size update to ACPI MRs will be lost during
migration, as we use aligned siz
On Tue, Apr 7, 2020 at 4:01 AM Joao Martins wrote:
>
>
>
> On 4/1/20 4:13 AM, Jingqi Liu wrote:
> > If the backend file is devdax pmem character device, the alignment
> > specified by the option 'align=NUM' in the '-object memory-backend-file'
> > needs to match the alignment requirement of the de
Paolo Bonzini writes:
> No attempts to fix or update the text; these are left for the next
> patch in the series.
>
> Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
--
Alex Bennée
On Tue, 7 Apr 2020 at 12:46, Markus Armbruster wrote:
>
> The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20200406' into staging (2020-04-06
> 12:36:45 +0100)
>
> are available in the Git rep
Am 07.04.2020 um 16:56 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 07.04.2020 17:42, Kevin Wolf wrote:
> > Am 07.04.2020 um 16:22 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 07.04.2020 15:12, Kevin Wolf wrote:
> > > > External callers of blk_co_*() and of the synchronous blk_*() functio
On 4/7/20 9:08 AM, Mark Cave-Ayland wrote:
> Given that users such as Howard and https://bugs.launchpad.net/bugs/1870911
> are
> starting to notice, would it be best to set this configure option as the
> default for
> Windows builds for now?
I guess so.
I'm mildly annoyed that Howard's compiler
On 07/04/2020 16:51, Alex Bennée wrote:
> From: Richard Henderson
>
> Without -Werror, the probe may succeed, but then compilation fails
> later when -Werror is added for other reasons. Shows up on windows,
> where the compiler complains about -fPIC.
>
> Signed-off-by: Richard Henderson
> Sig
Provides new functions related to the rdma migration test
Adds functions to check if service RDMA is enabled and gets
the ip address on the interface where it was configured
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 45 +++
1 file changed,
Adds test for RDMA migration check
Signed-off-by: Oksana Vohchana
---
tests/acceptance/migration.py | 12
1 file changed, 12 insertions(+)
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py
index 1c3a684395..99563ae850 100644
--- a/tests/acceptance/migration
In the migration test function _get_free_port works only for localhost,
but in the case to use migration through an RDMA we need to get a free port
on the configured network RDMA-interface.
This patch is the start for another migration option
Signed-off-by: Oksana Vohchana
---
tests/acceptance/m
On 4/7/20 3:31 PM, Paolo Bonzini wrote:
> On 07/04/20 12:59, Joao Martins wrote:
>> Perhaps, you meant instead:
>>
>> /sys/dev/char/%d:%d/align
>>
>> ?
>>
>
> So it works with that change?
Yeah.
Joao
On 07/04/20 17:25, Richard Henderson wrote:
> On 4/7/20 7:07 AM, Paolo Bonzini wrote:
>> +- release operations will appear to happen, with respect to the other
>> + components of the system, after all the LOAD or STORE operations
>> + specified afterwards.
> "specified before", not after for rele
The https://makecode.microbit.org/#editor generates slightly weird
.hex files which work fine on a real microbit but causes QEMU to
choke. The reason is extraneous data after the EOF record which causes
the loader to attempt to write a bigger file than it should to the
"rom". According to the HEX f
From: Richard Henderson
When %gs cannot be used, we use register offset addressing.
This path is almost never used, so it was clearly not tested.
Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
Message-Id: <20200406174803.8192-1-richard.hender...@linaro.org>
S
This series adds a new migration test through RDMA.
To correct uses of migration need to add a new function to work
with RDMA service.
And as a part of migration tests, the series makes small updates to EXEC
migration and to _get_free_port function
V2:
- improves commit message in Acceptance test
From: Richard Henderson
Without -Werror, the probe may succeed, but then compilation fails
later when -Werror is added for other reasons. Shows up on windows,
where the compiler complains about -fPIC.
Signed-off-by: Richard Henderson
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Da
Unfortunately reading /proc/self/maps is still considered the gold
standard for a process finding out about it's own memory layout. As we
will want this data in other contexts soon factor out the code to read
and parse the data. Rather than just blindly copying the existing
sscanf based code we use
From: Denis Plotnikov
./gdbstub.c: In function ‘handle_query_thread_extra’:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
error: ‘cpu_name’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
g_free (*pp);
^
./gdbstub.c:2
From: Richard Henderson
All other calls to normalize*Subnormal detect zero input before
the call -- this is the only outlier. This case can happen with
+0.0 + +0.0 = +0.0 or -0.0 + -0.0 = -0.0, so return a zero of
the correct sign.
Reported-by: Coverity (CID 1421991)
Signed-off-by: Richard Hend
Don't use magic spaces, calculate the justification for the file
field like the kernel does with seq_pad.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-Id: <20200403191150.863-10-alex.ben...@linaro.org>
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 5f1178729
We are not using them and they just get in the way.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20200403191150.863-4-alex.ben...@linaro.org>
diff --git a/tests/tcg/x86_64/system/boot.S b/tests/tcg/x86_64/system/boot.S
index 205cfbd
Dynamically allocating a new structure within the DisasContext can
potentially leak as we can longjmp out of the translation loop (see
test_phys_mem). The proper fix would be to use static allocation
within the DisasContext but as the Xtensa translator imports it's code
from elsewhere I leave that
Searching for memory space can cause problems so lets extend the
CPU_LOG_PAGE output so you can watch init_guest_space fail to
allocate memory. A more involved fix is actually required to make this
function play nicely with the large guard pages the sanitiser likes to
use.
Signed-off-by: Alex Benn
The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200406'
into staging (2020-04-06 12:36:45 +0100)
are available in the Git repository at:
https://github.com/stsquad/qemu.git tags/pull-misc-fixe
It's perfectly possible to have no function symbols in your elf file
and if we do the undefined behaviour sanitizer rightly complains about
us passing NULL to qsort. Check nsyms before we go ahead.
While we are at it lets drop the unchecked return value and cleanup
the fail leg by use of g_autoptr
From: Philippe Mathieu-Daudé
Some GitHub users try to open pull requests against the GitHub
mirror. Unfortunate these get ignored until eventually someone
notices and closes the request.
Enable the 'Repo Lockdown' [*] 3rd party bot which can autorespond
to pull requests with a friendly comment,
Checking TARGET_ABI_BITS is sketchy - we should check for the presence
of the define to be sure. Also clean up the white space while we are
there.
Signed-off-by: Alex Bennée
Reviewed-by: Laurent Vivier
Reviewed-by: Richard Henderson
Message-Id: <20200403191150.863-3-alex.ben...@linaro.org>
dif
On 4/7/20 7:07 AM, Paolo Bonzini wrote:
> +- release operations will appear to happen, with respect to the other
> + components of the system, after all the LOAD or STORE operations
> + specified afterwards.
"specified before", not after for release.
Otherwise,
Reviewed-by: Richard Henderson
Signed-off-by: Anthony PERARD
Acked-by: Paul Durrant
Message-Id: <20200406165043.1447837-1-anthony.per...@citrix.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9d156d73b31e..839959f7e4ac 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -440,
The following changes since commit 8f0d25c464a1989d606f7b988d07b1147dfcde33:
Merge remote-tracking branch
'remotes/philmd-gitlab/tags/acceptance-fixes-20200407' into staging (2020-04-07
15:10:11 +0100)
are available in the Git repository at:
https://xenbits.xen.org/git-http/peop
Since 7f5d9b206d1e ("object-add: don't create return value if
failed"), qmp_object_add() don't write any value in 'ret_data', thus
has random data. Then qobject_unref() fails and abort().
Fix by initialising 'ret_data' properly.
Fixes: 5f07c4d60d09 ("qapi: Flatten object-add")
Signed-off-by: Anth
From: Peter Maydell
The function usbback_packet_complete() currently takes a USBPacket*,
which must be a pointer to the packet field within a struct
usbback_req; the function uses container_of() to get the struct
usbback_req* given the USBPacket*.
This is unnecessarily confusing (and in particul
On 4/7/20 1:20 PM, Peter Maydell wrote:
> On Tue, 7 Apr 2020 at 12:16, Claudio Fontana wrote:
>>
>> if fdt is required, and the system DTC (libfdt) is not usable,
>> check for the dtc submodule requirements before trying to build it,
>> and error out with a helpful message in case the dependencies
-arm-2020040=
> 6' into staging (2020-04-06 12:36:45 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/philmd/qemu.git tags/acceptance-fixes-20200407
>
> for you to fetch changes up to a41f167547ec4e4752795572193d1cbb889c4885:
>
> .travis.yml:
07.04.2020 17:42, Kevin Wolf wrote:
Am 07.04.2020 um 16:22 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.04.2020 15:12, Kevin Wolf wrote:
External callers of blk_co_*() and of the synchronous blk_*() functions
don't currently increase the BlockBackend.in_flight counter, but calls
from blk_ai
On 07.04.20 16:34, Michael S. Tsirkin wrote:
> On Tue, Apr 07, 2020 at 04:17:46PM +0200, Philippe Mathieu-Daudé wrote:
>> On 4/3/20 12:18 PM, Shameer Kolothum wrote:
>>> Any sub-page size update to ACPI MRs will be lost during
>>> migration, as we use aligned size in ram_load_precopy() ->
>>> qemu_
Raise an error when trying to hot-plug/unplug a device through QMP to a device
with disabled hot-plug capability. This makes the device behaviour more
consistent and provides an explanation of the failure in the case of
asynchronous unplug.
Signed-off-by: Julia Suvorova
---
hw/pci/pcie.c | 24 ++
Am 07.04.2020 um 16:22 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 07.04.2020 15:12, Kevin Wolf wrote:
> > External callers of blk_co_*() and of the synchronous blk_*() functions
> > don't currently increase the BlockBackend.in_flight counter, but calls
> > from blk_aio_*() do, so there is an i
On Tue, Apr 07, 2020 at 04:17:46PM +0200, Philippe Mathieu-Daudé wrote:
> On 4/3/20 12:18 PM, Shameer Kolothum wrote:
> > Any sub-page size update to ACPI MRs will be lost during
> > migration, as we use aligned size in ram_load_precopy() ->
> > qemu_ram_resize() path. This will result in inconsist
On 07/04/20 12:59, Joao Martins wrote:
> Perhaps, you meant instead:
>
> /sys/dev/char/%d:%d/align
>
> ?
>
So it works with that change?
Paolo
Move all variants of the flush/pdiscard functions to a single place and
put the blk_co_*() version first because it is called by all other
variants (and will become static in the next patch).
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
Message-Id:
From: Stefan Reiter
All callers of job_txn_apply hold a single job's lock, but different
jobs within a transaction can have different contexts, thus we need to
lock each one individually before applying the callback function.
Similar to job_completed_txn_abort this also requires releasing the
ca
As reported on Launchpad, Azure apparently doesn't accept images for
upload that are not both aligned to 1 MB blocks and have a BAT size that
matches the image size exactly.
As far as I can tell, there is no real reason why we create a BAT that
is one entry longer than necessary for aligned image
External callers of blk_co_*() and of the synchronous blk_*() functions
don't currently increase the BlockBackend.in_flight counter, but calls
from blk_aio_*() do, so there is an inconsistency whether the counter
has been increased or not.
This patch moves the actual operations to static functions
From: Stefan Reiter
All code-paths leading to backup_clean (via job_clean) have the job's
context already acquired. The job's context is guaranteed to be the same
as the one used by backup_top via backup_job_create.
Since the previous logic effectively acquired the lock twice, this
broke cleanup
From: Stefan Reiter
job_cancel_sync requires the job's lock to be held, all other callers
already do this (replication_stop, drive_backup_abort,
blockdev_backup_abort, job_cancel_sync_all, cancel_common).
In this case we're in a BlockDriver handler, so we already have a lock,
just assert that it
Waiting in blk_wait_while_drained() while blk->in_flight is increased
for the current request is wrong because it will cause the drain
operation to deadlock.
This patch makes sure that blk_wait_while_drained() is called with
blk->in_flight increased exactly once for the current request, and that
i
The following changes since commit 53ef8a92eb04ee19640f5aad3bff36cd4a36c250:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200406'
into staging (2020-04-06 12:36:45 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for
1 - 100 of 243 matches
Mail list logo
