Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-12-27 Thread Richard Henderson
On 12/25/19 8:36 PM, LIU Zhiwei wrote: > struct { > >     uint64_t vreg[32 * RV_VLEN_MAX / 64] QEMU_ALIGNED(16); >     target_ulong vxrm; >     target_ulong vxsat; >     target_ulong vl; >     target_ulong vstart; >     target_ulong vtype; >     } vext; > > Is it OK? I don

[PATCH V3] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

2019-12-27 Thread Marek Dolata - mkdol...@us.ibm.com
Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata mailto:mkdol...@us.ibm.com>> --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/gdbstub.c b/

Re: [PATCH v2] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

2019-12-27 Thread Philippe Mathieu-Daudé
Hi Marek, Thanks for Cc'ing the maintainers :) Still the same error occurs: Applying: target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub error: corrupt patch at line 21 Patch failed at 0001 target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

[PATCH v2] hw/i386: Allow building machines without IOMMU

2019-12-27 Thread Philippe Mathieu-Daudé
Commit 6c730e4af9 introduced a stub to build the MicroVM machine without Intel IOMMU suppport. However when configure with --without-default-devices, the build fails: LINKx86_64-softmmu/qemu-system-x86_64 /usr/bin/ld: hw/i386/pc.o: in function `pc_machine_done': hw/i386/pc.c:869: undef

Re: [PATCH] hw/i386/x86-iommu: Add missing stubs

2019-12-27 Thread Philippe Mathieu-Daudé
On 12/22/19 11:31 AM, Paolo Bonzini wrote: On 20/12/19 16:42, Philippe Mathieu-Daudé wrote: In commit 6c730e4af9 we introduced a stub to build the MicroVM machine without Intel IOMMU. This stub is incomplete for the other PC machines. Add the missing stubs. In other words, without this patch y

Re: [PATCH v5 5/6] hppa: Add emulation of Artist graphics

2019-12-27 Thread Helge Deller
On 24.12.19 01:18, Philippe Mathieu-Daudé wrote: > On 12/23/19 6:50 PM, Sven Schnelle wrote: >> Hi Philippe, >> >> On Sun, Dec 22, 2019 at 01:37:48PM +0100, Philippe Mathieu-Daudé wrote:   +    if (vga_interface_type != VGA_NONE) { +    dev = qdev_create(NULL, "artist"); +   

Re: [PATCH] hw/i386/x86-iommu: Add missing stubs

2019-12-27 Thread Wainer dos Santos Moschetta
On 12/20/19 1:42 PM, Philippe Mathieu-Daudé wrote: In commit 6c730e4af9 we introduced a stub to build the MicroVM machine without Intel IOMMU. This stub is incomplete for the other PC machines. Add the missing stubs. Fixes: 6c730e4af9 Reported-by: Travis-CI Signed-off-by: Philippe Mathieu-Daud

[PATCH] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub

2019-12-27 Thread Marek Dolata - mkdol...@us.ibm.com
Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata mailto:mkdol...@us.ibm.com>> --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/gdbstub.c b/

Re: [PATCH] /target/i386: fix gdbstub k_gs_base issue

2019-12-27 Thread Philippe Mathieu-Daudé
Hi Marek, If you look at the other patches, you'll notice no leading slash is used, so please remove it when resending. Maybe you can use "target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub" as patch subject. Please Cc the maintainers. See: https://wiki.qemu.org/Contr

Re: [PATCH 3/5] python/qemu: qmp: Make accept()'s timeout configurable

2019-12-27 Thread Philippe Mathieu-Daudé
On 12/27/19 2:40 PM, Wainer dos Santos Moschetta wrote: Currently the timeout of QEMUMonitorProtocol.accept() is hard-coded to 15 seconds. This added the parameter `timeout` so the value can be configured by the user. Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/qmp.py | 5 +++--

[PATCH] /target/i386: fix gdbstub k_gs_base issue

2019-12-27 Thread Marek Dolata - mkdol...@us.ibm.com
Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata --- target/i386/gdbstub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index a

[PATCH] i.MX: add an emulation for RNGC

2019-12-27 Thread Martin Kaiser
Add an emulation for the RNGC random number generator and the compatible RNGB variant. These peripherals are included (at least) in imx25 and imx35 chipsets. The emulation supports the initial self test, reseeding the prng and reading random numbers. Signed-off-by: Martin Kaiser --- hw/arm/fsl-

[PATCH 5/5] python/qemu: qmp: Remove unnused attributes

2019-12-27 Thread Wainer dos Santos Moschetta
The `error` and `timeout` attributes in QEMUMonitorProtocol are not used, so this delete them. Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/qmp.py | 4 1 file changed, 4 deletions(-) diff --git a/python/qemu/qmp.py b/python/qemu/qmp.py index 6d55f53595..cddb94bb3c 100644 ---

[PATCH 4/5] python/qemu: qmp: Make QEMUMonitorProtocol a context manager

2019-12-27 Thread Wainer dos Santos Moschetta
This implement the __enter__ and __exit__ functions on QEMUMonitorProtocol class so that it can be used on 'with' statement and the resources will be free up on block end: with QEMUMonitorProtocol(socket_path) as qmp: qmp.connect() qmp.command('query-status') Signed-off-by: Wainer dos San

[PATCH 2/5] python/qemu: Delint the qmp module

2019-12-27 Thread Wainer dos Santos Moschetta
This clean up the pylint-3 report on qmp: * Module qemu.qmp python/qemu/qmp.py:1:0: C0111: Missing module docstring (missing-docstring) python/qemu/qmp.py:17:0: C0111: Missing class docstring (missing-docstring) python/qemu/qmp.py:21:0: C0111: Missing class docstring (missing-docstring

[PATCH 0/5] python/qemu: qmp: Fix, delint and improvements

2019-12-27 Thread Wainer dos Santos Moschetta
I started fixing an issue on exception handling which in some places currently use the deprecated (in Python 3.3) `socket.error`. Then I ended up delinting the module code and making some improvements. Git: - Tree: https://github.com/wainersm/qemu - Branch: python_qmp_sockets_error CI: - Travis

[PATCH 3/5] python/qemu: qmp: Make accept()'s timeout configurable

2019-12-27 Thread Wainer dos Santos Moschetta
Currently the timeout of QEMUMonitorProtocol.accept() is hard-coded to 15 seconds. This added the parameter `timeout` so the value can be configured by the user. Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/qmp.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --g

[PATCH 1/5] python/qemu: qmp: Replace socket.error with OSError

2019-12-27 Thread Wainer dos Santos Moschetta
The socket.error is deprecated from Python 3.3, instead it is made a link to OSError. This change replaces the occurences of socket.error with OSError. Signed-off-by: Wainer dos Santos Moschetta --- python/qemu/qmp.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff -

[PATCH 2/2] qcow2: dump QCOW2 metadata

2019-12-27 Thread Andrey Shinkevich
Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about metadata allocations on disk. Introduce '-M'('--dump-meta') key option. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/qcow2-bitmap.c | 53 --- block/qcow2

[PATCH 1/2] qcow2: introduce Qcow2Metadata structure

2019-12-27 Thread Andrey Shinkevich
The preliminary patch to provide an extendable structure for dumping QCOW2 metadata allocations in image. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- qapi/block-core.json | 208 ++- 1 file changed, 207 insertion

[PATCH 0/2] Dump QCOW2 metadata

2019-12-27 Thread Andrey Shinkevich
The information about QCOW2 metadata allocations in an image ELF-file is helpful for finding issues with the image data integrity. Snapshots dump example: $ sudo ./qemu-img check /.../.../harddisk.hdd -M --output=json { "image-end-offset": 24820842496, "total-clusters": 153600, "check