Re: [virtio-dev] Re: guest / host buffer sharing ...

2019-11-26 Thread Gerd Hoffmann
> > I'm not convinced this is useful for audio ... > > > > I basically see two modes of operation which are useful: > > > > (1) send audio data via virtqueue. > > (2) map host audio buffers into the guest address space. > > > > The audio driver api (i.e. alsa) typically allows to mmap() the

Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

2019-11-26 Thread Markus Armbruster
Maxim Levitsky writes: > Signed-off-by: Maxim Levitsky > --- > blockdev-hmp-cmds.c | 97 - > blockdev.c | 95 > 2 files changed, 96 insertions(+), 96 deletions(-) hmp_drive_add() and hmp_drive_del

Re: [PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-26 Thread Yuri Benditovich
On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote: > > Yuri Benditovich writes: > > > If the redirected device has this capability, Windows guest may > > place the device into D2 and expect it to wake when the device > > becomes active, but this will never happen. For example, when > > inte

Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c

2019-11-26 Thread Markus Armbruster
Maxim Levitsky writes: > Signed-off-by: Maxim Levitsky > --- > blockdev-hmp-cmds.c | 97 - > blockdev.c | 95 > 2 files changed, 96 insertions(+), 96 deletions(-) > > diff --git a/blockdev-hmp-cmds

Re: [PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c

2019-11-26 Thread Markus Armbruster
Maxim Levitsky writes: > Signed-off-by: Maxim Levitsky > --- > blockdev-hmp-cmds.c | 52 + > monitor/hmp-cmds.c | 52 - > 2 files changed, 52 insertions(+), 52 deletions(-) > > diff --git a/blockdev-hmp-cmd

Re: [PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-26 Thread Tao Xu
On 11/27/2019 2:44 PM, Markus Armbruster wrote: Tao Xu writes: On 11/26/2019 9:54 PM, Markus Armbruster wrote: Tao Xu writes: Hi Markus, Do you have any comments on this patch and 02/14 05/14 06/14. Thank you! These provide a new QAPI built-in type 'time'. It's like 'uint64' with an im

Re: [PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c

2019-11-26 Thread Markus Armbruster
Maxim Levitsky writes: > Signed-off-by: Maxim Levitsky > --- > blockdev-hmp-cmds.c | 61 + > monitor/hmp-cmds.c | 58 -- > 2 files changed, 61 insertions(+), 58 deletions(-) Licensing issue: blockdev-hmp-cmds.

Re: [PATCH 1/9] monitor: uninline add_init_drive

2019-11-26 Thread Markus Armbruster
Maxim Levitsky writes: > This is only used by hmp_drive_add. > The code is just a bit shorter this way. > > No functional changes > > Signed-off-by: Maxim Levitsky > --- > device-hotplug.c | 33 + > 1 file changed, 13 insertions(+), 20 deletions(-) > > diff --git

Re: [PATCH v6 13/20] ppc/pnv: Clarify how the TIMA is accessed on a multichip system

2019-11-26 Thread Cédric Le Goater
On 27/11/2019 06:23, David Gibson wrote: > On Mon, Nov 25, 2019 at 07:58:13AM +0100, Cédric Le Goater wrote: >> The TIMA region gives access to the thread interrupt context registers >> of a CPU. It is mapped at the same address on all chips and can be >> accessed by any CPU of the system. To ident

Re: [Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread lee
Hi Zhang Chen I use sysbench compare Host、Qemu Native VM(virtio-blk)、Qemu Native VM、Qemu colo disk performance. The result in below attachment. Qemu Native VM(virtio-blk) use -device virtio-blk-pci Qemu colo follow https://wiki.qemu.org/Features/COLO Thanks Lee Zhang Chen 于2019年11月27日周三 上午11:15写道

Re: [PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-26 Thread Markus Armbruster
Tao Xu writes: > On 11/26/2019 9:54 PM, Markus Armbruster wrote: >> Tao Xu writes: >> >>> Hi Markus, >>> >>> Do you have any comments on this patch and 02/14 05/14 06/14. >>> Thank you! >> >> These provide a new QAPI built-in type 'time'. It's like 'uint64' with >> an implied nanoseconds unit,

Re: [PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-26 Thread Markus Armbruster
Yuri Benditovich writes: > If the redirected device has this capability, Windows guest may > place the device into D2 and expect it to wake when the device > becomes active, but this will never happen. For example, when > internal Bluetooth adapter is redirected, keyboards and mice > connected to

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Michael Rolnik
On Wed, Nov 27, 2019 at 1:59 AM Philippe Mathieu-Daudé wrote: > On 11/24/19 6:02 AM, Michael Rolnik wrote: > > Provide function disassembles executed instruction when `-d in_asm` is > > provided > > Maybe "Implement the disassemble_info::print_insn() callback which print > a disassembled instruct

[PATCH V2] throttle-groups: fix memory leak in throttle_group_set_limit:

2019-11-26 Thread pannengyuan
From: PanNengyuan This avoid a memory leak when qom-set is called to set throttle_group limits, here is an easy way to reproduce: 1. run qemu-iotests as follow and check the result with asan: ./check -qcow2 184 Following is the asan output backtrack: Direct leak of 912 byte(s) in 3 objec

Re: [for-5.0 PATCH v2 0/4] spapr: Use less XIVE HW resources in KVM

2019-11-26 Thread David Gibson
On Tue, Nov 26, 2019 at 05:46:12PM +0100, Greg Kurz wrote: > On POWER9 systems, the XICS-on-XIVE and XIVE KVM devices currently > allocate a bunch of VPs in the XIVE HW to accomodate the highest > VCPU id that may be possibly used in a VM. This limits the number > of VMs that can run with an in-ker

Re: [PATCH v6 13/20] ppc/pnv: Clarify how the TIMA is accessed on a multichip system

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:13AM +0100, Cédric Le Goater wrote: > The TIMA region gives access to the thread interrupt context registers > of a CPU. It is mapped at the same address on all chips and can be > accessed by any CPU of the system. To identify the chip from which the > access is being

Re: [PATCH v6 11/20] ppc/xive: Use the XiveFabric and XivePresenter interfaces

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:11AM +0100, Cédric Le Goater wrote: > Now that the machines have handlers implementing the XiveFabric and > XivePresenter interfaces, remove xive_presenter_match() and make use > of the 'match_nvt' handler of the machine. > > Reviewed-by: Greg Kurz > Signed-off-by: C

Re: [PATCH v6 12/20] ppc/xive: Extend the TIMA operation with a XivePresenter parameter

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:12AM +0100, Cédric Le Goater wrote: > The TIMA operations are performed on behalf of the XIVE IVPE sub-engine > (Presenter) on the thread interrupt context registers. The current > operations supported by the model are simple and do not require access > to the controll

Re: [PATCH v6 04/20] ppc/pnv: Loop on the threads of the chip to find a matching NVT

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:04AM +0100, Cédric Le Goater wrote: > CPU_FOREACH() loops on all the CPUs of the machine which is incorrect. > Each XIVE Presenter should scan only the HW threads of the chip it > belongs to. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Greg Kurz > Signed-off-

Re: [PATCH v6 06/20] ppc/pnv: Introduce a pnv_xive_is_cpu_enabled() helper

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:06AM +0100, Cédric Le Goater wrote: > and use this helper to exclude CPUs which are not enabled in the XIVE > controller. > > Signed-off-by: Cédric Le Goater Applied 5..6 to ppc-for-5.0. > --- > include/hw/ppc/pnv.h | 5 + > hw/intc/pnv_xive.c | 19

Re: [PATCH v6 07/20] ppc/pnv: Fix TIMA indirect access

2019-11-26 Thread David Gibson
On Mon, Nov 25, 2019 at 07:58:07AM +0100, Cédric Le Goater wrote: > When the TIMA of a CPU needs to be accessed from the indirect page, > the thread id of the target CPU is first stored in the PC_TCTXT_INDIR0 > register. This thread id is relative to the chip and not to the system. > > Introduce a

Re: [PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-26 Thread Tao Xu
On 11/26/2019 9:54 PM, Markus Armbruster wrote: Tao Xu writes: Hi Markus, Do you have any comments on this patch and 02/14 05/14 06/14. Thank you! These provide a new QAPI built-in type 'time'. It's like 'uint64' with an implied nanoseconds unit, and additional convenience syntax in the op

Network connection with COLO VM

2019-11-26 Thread Daniel Cho
Hello everyone, Could we ssh to colo VM (means PVM & SVM are starting)? SSH will connect to colo VM for a while, but it will disconnect with error *client_loop: send disconnect: Broken pipe* It seems to colo VM could not keep network session. Does it be a known issue? Best Regard, Daniel Cho

Re: [PATCH v3 2/3] spapr: Add NVDIMM device support

2019-11-26 Thread Bharata B Rao
On Fri, Nov 22, 2019 at 10:42 AM David Gibson wrote: > > Ok. A number of queries about this. > > 1) The PAPR spec for ibm,dynamic-memory-v2 says that the first word in > each entry is the number of LMBs, but for NVDIMMs you use the > not-necessarily-equal scm_block_size instead. Does the NVDIMM

Re: [Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread Zhang Chen
Hi Lee, Can you introduce to me the detail test step about disk performance? I want to look into it when I have time. Thanks Zhang Chen On Wed, Nov 27, 2019 at 10:50 AM lee <1754...@bugs.launchpad.net> wrote: > > Hi Zhang Chen , > > I try colo follow https://wiki.qemu.org/Features/COLO. > It wor

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Jason Wang
Hi Jakub: On 2019/11/27 上午4:35, Jakub Kicinski wrote: On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces XDP offloading from virtio_net. It is based on the following work by Jason Wang: https://net

[Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread lee
Hi Zhang Chen , I try colo follow https://wiki.qemu.org/Features/COLO. It work well. But disk performance slow. Only host performance 10%. Can virtio blk supported by current colo? Or is there any other way to improve disk performance. Thanks lee -- You received this bug notification because yo

[Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread lee
Hi Zhang Chen , I try colo follow https://wiki.qemu.org/Features/COLO. It work well. But disk performance slow. Only host performance 10%. Can virtio blk supported by current colo? Or is there any other way to improve disk performance. Thanks Zhang Chen -- You received this bug notification be

Re: [PATCH] throttle-groups: fix memory leak in throttle_group_set_limits

2019-11-26 Thread pannengyuan
Thanks, I think it can be removed, I will send a new version later. On 2019/11/26 17:59, Alberto Garcia wrote: > On Tue 26 Nov 2019 09:17:02 AM CET, pannengy...@huawei.com wrote: >> --- a/block/throttle-groups.c >> +++ b/block/throttle-groups.c >> @@ -912,6 +912,7 @@ static void throttle_group_set

[Bug 1754542] Re: colo: vm crash with segmentation fault

2019-11-26 Thread 李穗恒
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1754542 Title: colo: vm crash with segmentation fault Status in QEMU: Fix Released Bug desc

Re: [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record description

2019-11-26 Thread Xiang Zheng
Hi Igor, Thanks for your review! Since the series of patches are going to be merged, we will address your comments by follow up patches. On 2019/11/15 17:44, Igor Mammedov wrote: > On Mon, 11 Nov 2019 09:40:44 +0800 > Xiang Zheng wrote: > >> From: Dongjiu Geng >> >> Add APEI/GHES detailed des

Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2019-11-26 Thread Xiang Zheng
Hi, On 2019/11/16 0:37, Igor Mammedov wrote: > On Mon, 11 Nov 2019 09:40:47 +0800 > Xiang Zheng wrote: > >> From: Dongjiu Geng >> >> Add a SIGBUS signal handler. In this handler, it checks the SIGBUS type, >> translates the host VA delivered by host to guest PA, then fills this PA >> to guest A

Re: [RFC 0/3] Qemu: virtio-net XDP offload

2019-11-26 Thread Prashant Bhole
On 11/26/19 7:33 PM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191126100914.5150-1-prashantbhole.li...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, y

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/24/19 6:02 AM, Michael Rolnik wrote: Provide function disassembles executed instruction when `-d in_asm` is provided Maybe "Implement the disassemble_info::print_insn() callback which print a disassembled instruction." Signed-off-by: Michael Rolnik --- target/avr/cpu.h | 1

Re: [PATCH v36 00/17] QEMU AVR 8 bit cores

2019-11-26 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > This series of patches adds 8bit AVR cores to QEMU. > All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully > tested yet. > However I was able to execute simple code with functions. e.g fibonacci > calculation. > This series o

Re: [PATCH v36 16/17] target/avr: Add Avocado test

2019-11-26 Thread Philippe Mathieu-Daudé
Hi Michael, On 11/24/19 6:02 AM, Michael Rolnik wrote: The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working Signed-off-by: Michael Ro

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- Michael, hi. It would be very helpful if you include an example in the commit message: - how to start qemu for AVR w

Re: [PATCH v36 04/17] target/avr: Add instruction translation - Registers definition

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/24/19 6:02 AM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target/avr/translate.c | 132 + 1 file changed, 132 insertions(+) create mode 100644 target/avr/translate.c Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu

Re: [PATCH v36 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/24/19 6:02 AM, Michael Rolnik wrote: This includes: - ADD, ADC, ADIW - SBIW, SUB, SUBI, SBC, SBCI - AND, ANDI - OR, ORI, EOR - COM, NEG - INC, DEC - MUL, MULS, MULSU - FMUL, FMULS, FMULSU - DES Signed-off-by: Michael Rolnik --- target/avr/translate.c | 822 ++

Re: [PATCH v36 06/17] target/avr: Add instruction translation - Branch Instructions

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/24/19 6:02 AM, Michael Rolnik wrote: This includes: - RJMP, IJMP, EIJMP, JMP - RCALL, ICALL, EICALL, CALL - RET, RETI - CPSE, CP, CPC, CPI - SBRC, SBRS, SBIC, SBIS - BRBC, BRBS Signed-off-by: Michael Rolnik --- target/avr/translate.c | 549 +

Re: [PATCH v36 12/17] target/avr: Add example board configuration

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/26/19 2:08 AM, Aleksandar Markovic wrote: On Sunday, November 24, 2019, Michael Rolnik > wrote: A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AV

Re: [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic

2019-11-26 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 11/24/19 5:21 PM, Aleksandar Markovic wrote: On Sunday, November 24, 2019, Michael Rolnik > wrote: This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Mi

Re: [RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Jakub Kicinski
On Tue, 26 Nov 2019 19:07:26 +0900, Prashant Bhole wrote: > Note: This RFC has been sent to netdev as well as qemu-devel lists > > This series introduces XDP offloading from virtio_net. It is based on > the following work by Jason Wang: > https://netdevconf.info/0x13/session.html?xdp-offload-with-

[ANNOUNCE] QEMU 4.2.0-rc3 is now available

2019-11-26 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 4.2 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.2.0-rc3.tar.xz http://down

[PATCH-for-4.2? v2 1/2] tests/boot_linux_console: Fetch assets from Debian snapshot archives

2019-11-26 Thread Philippe Mathieu-Daudé
The kernel packaged was fetched from an unstable repository. Use the stable snapshot archive instead. Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- v2: - Rebased - Dropped Alex's Tested-by tag, since commit 2ecde8b2fb got merged since and it changed the tested kernel versi

[PATCH-for-5.0? v2 2/2] Revert "Acceptance test: cancel test if m68k kernel packages goes missing"

2019-11-26 Thread Philippe Mathieu-Daudé
Now than we use the stable snapshot archive, we can remove this check. This reverts commit d2499aca4bac613d837e2720e7bbe3378bc91245. Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/boot_linux_console.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/acc

[PATCH-for-4.2? v2 0/2] tests/acceptance: Fix the m68k/q800 Linux test

2019-11-26 Thread Philippe Mathieu-Daudé
Today someone (William/Beraldo?) complained this test was still failing while fetching the asset. This test already handle the OSError exception, maybe we are missing another one. Regardless, it is easier to refresh my previous patch which use a stable link, so the problem should be fixed. It see

[RFC] exec: flush CPU TB cache when breakpoint address translation fails

2019-11-26 Thread Max Filippov
When a breakpoint is inserted at location for which there's currently no virtual to physical translation no action is taken on CPU TB cache. If a TB for that virtual address already exists but is not visible ATM the breakpoint won't be hit next time an instruction at that address will be executed.

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Tuesday, November 26, 2019, Michael Rolnik wrote: > > > On Tue, Nov 26, 2019 at 9:52 PM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: >> > >> > Provide function disassembles executed instruction when `-d in_asm` is >> >

Re: [PULL 0/5] i386 patches for QEMU 4.2-rc

2019-11-26 Thread Paolo Bonzini
Il mar 26 nov 2019, 23:04 Philippe Mathieu-Daudé ha scritto: > On 11/26/19 10:19 AM, no-re...@patchew.org wrote: > > Patchew URL: > https://patchew.org/QEMU/20191126085936.1689-1-pbonz...@redhat.com/ > > > > This series failed the docker-quick@centos7 build test. Please find the > testing command

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-26 Thread Philippe Mathieu-Daudé
On Tue, Nov 26, 2019 at 11:03 PM Aleksandar Markovic wrote: > On Tuesday, November 26, 2019, Philippe Mathieu-Daudé > wrote: >> >> Hi Aleksandar, >> >> On 11/26/19 9:46 PM, Aleksandar Markovic wrote: >>> >>> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé >>> wrote: The r

Re: [PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-26 Thread Kevin Wolf
Am 26.11.2019 um 22:24 hat Alexander Popov geschrieben: > Hello Kevin, > > Thanks for your review, > > On 21.11.2019 18:03, Kevin Wolf wrote: > > Am 14.11.2019 um 18:25 hat Alexander Popov geschrieben: > >> The commit a718978ed58a from July 2015 introduced the assertion which > >> implies that th

Re: [PULL 0/5] i386 patches for QEMU 4.2-rc

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/26/19 10:19 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20191126085936.1689-1-pbonz...@redhat.com/ This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably repr

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-26 Thread Aleksandar Markovic
On Tuesday, November 26, 2019, Philippe Mathieu-Daudé wrote: > Hi Aleksandar, > > On 11/26/19 9:46 PM, Aleksandar Markovic wrote: > >> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé >> wrote: >> >>> >>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last >>> logical change w

Re: [PULL for 4.2 0/3] a few vm-test fixes

2019-11-26 Thread Peter Maydell
On Tue, 26 Nov 2019 at 12:03, Alex Bennée wrote: > > The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-11-25 15:47:44 +) > > are available in the Git repository at: > > https:/

Re: [PATCH v2 1/1] ide: check DMA transfer size in ide_dma_cb() to prevent qemu DoS from quests

2019-11-26 Thread Alexander Popov
Hello Kevin, Thanks for your review, On 21.11.2019 18:03, Kevin Wolf wrote: > Am 14.11.2019 um 18:25 hat Alexander Popov geschrieben: >> The commit a718978ed58a from July 2015 introduced the assertion which >> implies that the size of successful DMA transfers handled in ide_dma_cb() >> should be

[PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-26 Thread Yuri Benditovich
If the redirected device has this capability, Windows guest may place the device into D2 and expect it to wake when the device becomes active, but this will never happen. For example, when internal Bluetooth adapter is redirected, keyboards and mice connected to it do not work. Setting global prope

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-26 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 11/26/19 9:46 PM, Aleksandar Markovic wrote: On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: The r4k machine was introduced in 2005 (6af0bf9c7) and its last logical change was in 2005 (9542611a6). After we can count 164 maintenance commits (QEMU API changes) w

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-26 Thread Richard Henderson
On 11/23/19 11:56 AM, Marc Zyngier wrote: > HCR_EL2.TID3 mandates that access from EL1 to a long list of id > registers traps to EL2, and QEMU has so far ignored this requirement. > > This breaks (among other things) KVM guests that have PtrAuth enabled, > while the hypervisor doesn't want to expo

Re: [PATCH-for-4.2] hw/mips: Deprecate the r4k machine

2019-11-26 Thread Aleksandar Markovic
On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé wrote: > > The r4k machine was introduced in 2005 (6af0bf9c7) and its last > logical change was in 2005 (9542611a6). After we can count 164 > maintenance commits (QEMU API changes) with the exception of > 1 fix in 2015 (memory leak, commit 3a

Re: [PULL 0/5] i386 patches for QEMU 4.2-rc

2019-11-26 Thread Peter Maydell
On Tue, 26 Nov 2019 at 09:01, Paolo Bonzini wrote: > > The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-11-25 15:47:44 +) > > are available in the Git repository at: > > git:/

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-26 Thread Michael Rolnik
Ah. I think Sarah was ok with reviewer role. On Tue, Nov 26, 2019 at 9:39 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > On Tue, Nov 26, 2019 at 8:06 PM Michael Rolnik wrote: > > > > Aleksandar, > > > > there was an email from Sarah, stating that she does not want to be a > maint

Re: [PATCH v36 04/17] target/avr: Add instruction translation - Registers definition

2019-11-26 Thread Michael Rolnik
On Tue, Nov 26, 2019 at 9:48 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > > > Signed-off-by: Michael Rolnik > > --- > > target/avr/translate.c | 132 + > > 1 file changed, 132 ins

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Michael Rolnik
On Tue, Nov 26, 2019 at 9:52 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > > > Provide function disassembles executed instruction when `-d in_asm` is > > provided > > > > Signed-off-by: Michael Rolnik > > --- > > target/

Re: [PATCH v2] linux-user/strace: Improve strace output for read() and getcwd()

2019-11-26 Thread Aleksandar Markovic
On Sun, Nov 24, 2019 at 12:56 PM Helge Deller wrote: > > The strace functionality in qemu-user lacks the possibility to trace > which real values get returned to pointers in userspace by syscalls. > > For example, the read() and getcwd() syscalls currently only show the > destination address where

Re: [PATCH v2 0/5] hvf: stability fixes for HVF

2019-11-26 Thread Cameron Esfahani via
Let me see if I can add some assertions. Cameron Esfahani di...@apple.com "The cake is a lie." Common wisdom > On Nov 25, 2019, at 2:28 AM, Paolo Bonzini wrote: > > Certainly no doubt about patches 1-4, while for patch 5 I'm wondering if > it's masking another bug; I'd prefer to have also s

Re: [PATCH v2 5/5] hvf: save away type as well as vector so we can reinject them

2019-11-26 Thread Cameron Esfahani via
Our test case was booting many concurrent macOS VMs under heavy system load. I don't know if I could create one to replicate that. Cameron Esfahani di...@apple.com "In the elder days of Art, Builders wrought with greatest care each minute and unseen part; For the gods see everywhere." "The Bu

Re: [PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Markus Armbruster
Eric Blake writes: > On 11/26/19 10:26 AM, Kevin Wolf wrote: > >>> Actually, your patch fails to diagnose: >>> >>> $ qemu-img create -o size=1m,size=2m -f qcow2 x.qcow2 >>> Formatting 'x.qcow2', fmt=qcow2 size=2097152 cluster_size=65536 >>> lazy_refcounts=off refcount_bits=16 >>> >>> so you may w

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- > target/avr/cpu.h | 1 + > target/avr/cpu.c | 2 +- > target/avr/disas.c | 214

Re: [PATCH v36 04/17] target/avr: Add instruction translation - Registers definition

2019-11-26 Thread Aleksandar Markovic
On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > Signed-off-by: Michael Rolnik > --- > target/avr/translate.c | 132 + > 1 file changed, 132 insertions(+) > create mode 100644 target/avr/translate.c > > diff --git a/target/avr/translate.c b/targe

Re: [PULL 0/4] target-arm queue

2019-11-26 Thread Peter Maydell
almer/tags/riscv-for-master-4.2-rc3' > into staging (2019-11-26 12:36:40 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20191126 > > for you to fetch changes up to 6a4ef4e5d1084ce41fafa7d

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-26 Thread Aleksandar Markovic
On Tue, Nov 26, 2019 at 8:06 PM Michael Rolnik wrote: > > Aleksandar, > > there was an email from Sarah, stating that she does not want to be a > maintainer. > But this is for "reviewer" role, not "maintainer". Sarah? > On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic > wrote: >> >> >> >>

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-26 Thread Kevin Wolf
Am 26.11.2019 um 19:19 hat Tony Asleson geschrieben: > On 11/21/19 4:30 AM, Stefan Hajnoczi wrote: > > blkdebug can inject EIO when a specific LBA is accessed. Is that > > enough for what you want to do? Then you can reuse and maybe extend > > blkdebug. > > Not exactly. For SCSI, I would like t

Re: [PATCH v36 17/17] target/avr: Update MAINTAINERS file

2019-11-26 Thread Michael Rolnik
Aleksandar, there was an email from Sarah, stating that she does not want to be a maintainer. On Tue, Nov 26, 2019 at 5:17 AM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Sunday, November 24, 2019, Michael Rolnik wrote: > >> Include AVR maintaners in MAINTAINERS file >> >>

Re: [PULL 0/2] Block patches for 4.2.0-rc3

2019-11-26 Thread Peter Maydell
On Tue, 26 Nov 2019 at 13:29, Max Reitz wrote: > > The following changes since commit 4ecc984210ca1bf508a96a550ec8a93a5f833f6c: > > Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.2-rc3' > into staging (2019-11-26 12:36:40 +) > > are available in the Git repository at:

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-26 Thread Tony Asleson
On 11/21/19 4:30 AM, Stefan Hajnoczi wrote: > blkdebug can inject EIO when a specific LBA is accessed. Is that > enough for what you want to do? Then you can reuse and maybe extend > blkdebug. Not exactly. For SCSI, I would like to be able to return different types of device errors on reads eg.

Re: RFC: New device for zero-copy VM memory access

2019-11-26 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Hi > > On Mon, Nov 4, 2019 at 4:05 PM wrote: > > > > > > > > On 2019-11-04 22:55, Dr. David Alan Gilbert wrote: > > > * ge...@hostfission.com (ge...@hostfission.com) wrote: > > >> > > >> > > >> On 2019-11-03 21:10, ge...@hostfission.com w

Re: [PATCH] pseries: disable migration-test if /dev/kvm cannot be used

2019-11-26 Thread Laurent Vivier
Le 21/11/2019 à 09:30, Juan Quintela a écrit : > Laurent Vivier wrote: >> On 21/11/2019 08:18, Juan Quintela wrote: >>> Laurent Vivier wrote: On ppc64, migration-test only works with kvm_hv, and we already have a check to verify the module is loaded. kvm_hv module can be loade

Re: [PULL 0/8] ppc-for-4.2 queue 20191126

2019-11-26 Thread Peter Maydell
he Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.2-20191126 > > for you to fetch changes up to 59d0533b85158fdbe43bad696d4f50ec29a04c32: > > ppc/spapr_events: fix potential NULL pointer dereference in &g

Re: [for-5.0 PATCH v2 3/4] spapr/xics: Configure number of servers in KVM

2019-11-26 Thread Cédric Le Goater
On 26/11/2019 17:46, Greg Kurz wrote: > The XICS-on-XIVE KVM devices now has an attribute to configure the number > of interrupt servers. This allows to greatly optimize the usage of the VP > space in the XIVE HW, and thus to start a lot more VMs. > > Only set this attribute if available in order

Re: [for-5.0 PATCH v2 4/4] spapr/xive: Configure number of servers in KVM

2019-11-26 Thread Cédric Le Goater
On 26/11/2019 17:46, Greg Kurz wrote: > The XIVE KVM devices now has an attribute to configure the number of > interrupt servers. This allows to greatly optimize the usage of the VP > space in the XIVE HW, and thus to start a lot more VMs. > > Only set this attribute if available in order to suppo

Re: [for-5.0 PATCH v2 2/4] spapr: Pass the maximum number of vCPUs to the KVM interrupt controller

2019-11-26 Thread Cédric Le Goater
On 26/11/2019 17:46, Greg Kurz wrote: > The XIVE and XICS-on-XIVE KVM devices on POWER9 hosts can greatly reduce > their consumption of some scarce HW resources, namely Virtual Presenter > identifiers, if they know the maximum number of vCPUs that may run in the > VM. > > Prepare ground for this b

Re: [PULL 0/1] vmstate-static-checker fix for 4.2

2019-11-26 Thread Peter Maydell
On Mon, 25 Nov 2019 at 22:53, Eduardo Habkost wrote: > > The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-11-25 15:47:44 +) > > are available in the Git repository at: > > git

[for-5.0 PATCH v2 4/4] spapr/xive: Configure number of servers in KVM

2019-11-26 Thread Greg Kurz
The XIVE KVM devices now has an attribute to configure the number of interrupt servers. This allows to greatly optimize the usage of the VP space in the XIVE HW, and thus to start a lot more VMs. Only set this attribute if available in order to support older POWER9 KVM. The XIVE KVM device now re

[for-5.0 PATCH v2 1/4] linux-headers: Update

2019-11-26 Thread Greg Kurz
Update to mainline commit be2eca94d144 ("Merge tag 'for-linus-5.5-1'` of git://github.com/cminyard/linux-ipmi") Signed-off-by: Greg Kurz --- include/standard-headers/linux/ethtool.h |6 ++ include/standard-headers/linux/virtio_ring.h |2 +- linux-headers/asm-arm/kvm.h

[for-5.0 PATCH v2 3/4] spapr/xics: Configure number of servers in KVM

2019-11-26 Thread Greg Kurz
The XICS-on-XIVE KVM devices now has an attribute to configure the number of interrupt servers. This allows to greatly optimize the usage of the VP space in the XIVE HW, and thus to start a lot more VMs. Only set this attribute if available in order to support older POWER9 KVM and pre-POWER9 XICS

[for-5.0 PATCH v2 0/4] spapr: Use less XIVE HW resources in KVM

2019-11-26 Thread Greg Kurz
On POWER9 systems, the XICS-on-XIVE and XIVE KVM devices currently allocate a bunch of VPs in the XIVE HW to accomodate the highest VCPU id that may be possibly used in a VM. This limits the number of VMs that can run with an in-kernel interrupt controller to 63 per POWER9 chip, irrespectively of i

[for-5.0 PATCH v2 2/4] spapr: Pass the maximum number of vCPUs to the KVM interrupt controller

2019-11-26 Thread Greg Kurz
The XIVE and XICS-on-XIVE KVM devices on POWER9 hosts can greatly reduce their consumption of some scarce HW resources, namely Virtual Presenter identifiers, if they know the maximum number of vCPUs that may run in the VM. Prepare ground for this by passing the value down to xics_kvm_connect() and

Re: [PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Eric Blake
On 11/26/19 10:26 AM, Kevin Wolf wrote: Actually, your patch fails to diagnose: $ qemu-img create -o size=1m,size=2m -f qcow2 x.qcow2 Formatting 'x.qcow2', fmt=qcow2 size=2097152 cluster_size=65536 lazy_refcounts=off refcount_bits=16 so you may want to enhance this patch to also catch the case

Re: [PATCH v0 1/2] qdev-properties-system: extend set_pionter for unrealized devices

2019-11-26 Thread Kevin Wolf
Am 26.11.2019 um 07:49 hat Denis Plotnikov geschrieben: > > > On 25.11.2019 18:30, Eduardo Habkost wrote: > > On Fri, Nov 22, 2019 at 11:36:30AM +, Denis Plotnikov wrote: > >> > >> On 18.11.2019 21:54, Eduardo Habkost wrote: > >>> On Sun, Nov 10, 2019 at 10:03:09PM +0300, Denis Plotnikov wrot

Re: [PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Kevin Wolf
Am 26.11.2019 um 16:56 hat Eric Blake geschrieben: > On 11/26/19 9:54 AM, Eric Blake wrote: > > On 11/26/19 9:48 AM, Kevin Wolf wrote: > > > If both the create options (qemu-img create -o ...) and the size > > > parameter were given, the size parameter was silently ignored. Instead, > > > make spec

Re: [PATCH for-5.0 0/4] spapr: Use less XIVE HW resources in KVM

2019-11-26 Thread Greg Kurz
Oops clumsy fingers, please ignore that ... :) On Tue, 26 Nov 2019 16:50:38 +0100 Greg Kurz wrote: > On POWER9 systems, the XICS-on-XIVE and XIVE KVM devices currently > allocate a bunch of VPs in the XIVE HW to accomodate the highest > VCPU id that may be possibly used in a VM. This limits the

Re: [PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Eric Blake
On 11/26/19 9:54 AM, Eric Blake wrote: On 11/26/19 9:48 AM, Kevin Wolf wrote: If both the create options (qemu-img create -o ...) and the size parameter were given, the size parameter was silently ignored. Instead, make specifying two sizes an error. Signed-off-by: Kevin Wolf ---   block.c

[PATCH for-5.0 0/4] spapr: Use less XIVE HW resources in KVM

2019-11-26 Thread Greg Kurz
On POWER9 systems, the XICS-on-XIVE and XIVE KVM devices currently allocate a bunch of VPs in the XIVE HW to accomodate the highest VCPU id that may be possibly used in a VM. This limits the number of VMs that can run with an in-kernel interrupt controller to 63 per POWER9 chip, irrespectively of i

Re: [PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Eric Blake
On 11/26/19 9:48 AM, Kevin Wolf wrote: If both the create options (qemu-img create -o ...) and the size parameter were given, the size parameter was silently ignored. Instead, make specifying two sizes an error. Signed-off-by: Kevin Wolf --- block.c| 10 -- tests/

[PATCH for-5.0 v2 1/3] python: add simplebench.py

2019-11-26 Thread Vladimir Sementsov-Ogievskiy
Add simple benchmark table creator. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/simplebench.py | 128 ++ 1 file changed, 128 insertions(+) create mode 100644 python/simplebench.py diff --git a/python/simplebench.py b/python/simplebench.py new

Re: [PATCH v9 1/3] block: introduce compress filter driver

2019-11-26 Thread Eric Blake
On 11/26/19 8:43 AM, Andrey Shinkevich wrote: Allow writing all the data compressed through the filter driver. The written data will be aligned by the cluster size. Based on the QEMU current implementation, that data can be written to unallocated clusters only. May be used for a backup job. Sugg

[PATCH for-5.0 v2 3/3] python: add example usage of simplebench

2019-11-26 Thread Vladimir Sementsov-Ogievskiy
This example may be used as a template for custom benchmark. It illustrates three things to prepare: - define bench_func - define test environments (columns) - define test cases (rows) And final call of simplebench API. Signed-off-by: Vladimir Sementsov-Ogievskiy --- python/bench-example.py |

[PATCH] block: Error out on image creation with conflicting size options

2019-11-26 Thread Kevin Wolf
If both the create options (qemu-img create -o ...) and the size parameter were given, the size parameter was silently ignored. Instead, make specifying two sizes an error. Signed-off-by: Kevin Wolf --- block.c| 10 -- tests/qemu-iotests/049 | 5 + tests/qemu

[PATCH for-5.0 v2 0/3] benchmark util

2019-11-26 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is simple benchmarking utility, to generate performance comparison tables, like the following: -- - - - backup-1 backup-2 mirror ssd -> ssd 0.43 +- 0.00 4.48 +- 0.06 4.38 +- 0.02 ssd -> hdd 10.60 +- 0.08 10

  1   2   3   >