[PATCH v15 10/12] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2019-11-06 Thread Tao Xu
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[PATCH v15 08/12] numa: Extend CLI to provide memory side cache information

2019-11-06 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Reviewed-by: Daniel Black Signed-off-by: Liu Jingqi Signed-off-by: Tao Xu

[PATCH v15 06/12] numa: Extend CLI to provide memory latency and bandwidth information

2019-11-06 Thread Tao Xu
From: Liu Jingqi Add -numa hmat-lb option to provide System Locality Latency and Bandwidth Information. These memory attributes help to build System Locality Latency and Bandwidth Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Signed-off-by: Liu Jingqi Signed-off-

[PATCH v15 09/12] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2019-11-06 Thread Tao Xu
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and bandw

[PATCH v15 11/12] hmat acpi: Build Memory Side Cache Information Structure(s)

2019-11-06 Thread Tao Xu
From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device forms the memory side cache. The software could use this information to effectively place the data in memory to maximize the performance

[PATCH v15 02/12] util/cutils: Add qemu_strtotime_ns()

2019-11-06 Thread Tao Xu
To convert strings with time suffixes to numbers, support time unit are "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Add test for qemu_strtotime_ns, test the input of basic, time suffixes, float, invaild, trailing and overflow. Signed-off-by: Tao Xu --- Chan

[PATCH v15 03/12] qapi: Add builtin type time

2019-11-06 Thread Tao Xu
Add optional builtin type time, fallback is uint64. This type use qemu_strtotime_ns() for pre-converting time suffix to numbers. Signed-off-by: Tao Xu --- No changes in v15. Changes in v14: - Drop time unit picosecond (Eric) --- include/qapi/visitor-impl.h | 4 include/qapi/visitor.

[PATCH v15 07/12] numa: Calculate hmat latency and bandwidth entry list

2019-11-06 Thread Tao Xu
Compress HMAT latency and bandwidth raw data into uint16_t data, which can be stored in HMAT table. Suggested-by: Igor Mammedov Signed-off-by: Tao Xu --- No changes in v15. Changes in v14: - Convert latency from ns to ps, because ACPI 6.3 HMAT table use ps as minimum unit --- hw/cor

[PATCH v15 04/12] tests: Add test for QAPI builtin type time

2019-11-06 Thread Tao Xu
Add tests for time input such as zero, around limit of precision, signed upper limit, actual upper limit, beyond limits, time suffixes, and etc. Signed-off-by: Tao Xu --- No changes in v15. Changes in v14: - Drop time unit picosecond (Eric) --- tests/test-keyval.c| 122

[PATCH v15 00/12] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

2019-11-06 Thread Tao Xu
This series of patches will build Heterogeneous Memory Attribute Table (HMAT) according to the command line. The ACPI HMAT describes the memory attributes, such as memory side cache attributes and bandwidth and latency details, related to the Memory Proximity Domain. The software is expected to use

[PATCH v15 05/12] numa: Extend CLI to provide initiator information for numa nodes

2019-11-06 Thread Tao Xu
In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory proximity domain

[PATCH v15 01/12] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-06 Thread Tao Xu
Add do_strtomul() to convert string according to different suffixes. Signed-off-by: Tao Xu --- Changes in v15: - Add a new patch to refactor do_strtosz() (Eduardo) --- util/cutils.c | 72 ++- 1 file changed, 42 insertions(+), 30 deletions(-)

Re: guest / host buffer sharing ...

2019-11-06 Thread Gerd Hoffmann
> On 2019-11-06 23:41, Gerd Hoffmann wrote: > > On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote: > > > > (1) The virtio device > > > > = > > > > > > > > Has a single virtio queue, so the guest can send commands to register > > > > and unregister buffers. Buffers a

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-06 Thread Tao Xu
On 11/7/2019 4:53 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: Add tests for time input such as zero, around limit of precision, signed upper limit, actual upper limit, beyond limits, time suffixes, and etc. Signed-off-by: Tao Xu --- [...] +/* Close

Re: [PATCH 0/6] migration/postcopy: enable compress during postcopy

2019-11-06 Thread Wei Yang
On Wed, Nov 06, 2019 at 08:11:44PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> This patch set tries enable compress during postcopy. >> >> postcopy requires to place a whole host page, while migration thread migrate >> memory in target page size. This

Re: [PATCH 5/6] migration/postcopy: enable random order target page arrival

2019-11-06 Thread Wei Yang
On Wed, Nov 06, 2019 at 08:08:28PM +, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> After using number of target page received to track one host page, we >> could have the capability to handle random order target page arrival in >> one host page. >> >> Thi

Re: [Qemu-devel] [PATCH v2 1/2] net: assert that tx packets have nonzero size

2019-11-06 Thread Jason Wang
On 2019/7/22 下午9:24, Oleinik, Alexander wrote: Virtual devices should not try to send zero-sized packets. The caller should check the size prior to calling qemu_sendv_packet_async. Signed-off-by: Alexander Oleinik --- v2: * Improve the comment to explain the rationale for adding the assert

Re: [PATCH] WHPX: support for xcr0

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/mw2pr2101mb1116e938a5be3174ef5ec9b9c0...@mw2pr2101mb1116.namprd21.prod.outlook.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] WHPX: support for xcr0 Type: series Message-id: mw2pr210

Looking for issues/features for my first contribution

2019-11-06 Thread Rajath Shashidhara
Hi all, I am a Computer Science graduate student at The University of Texas at Austin (UT, Austin). I am looking forward to contributing to qemu ! This semester, I am taking a class in Virtualization (https://github.com/vijay03/cs378-f19) and contributing to a virtualization related open-sou

Re: [PATCH v14 04/11] numa: Extend CLI to provide initiator information for numa nodes

2019-11-06 Thread Tao Xu
On 11/7/2019 4:29 AM, Eric Blake wrote: On 10/28/19 2:52 AM, Tao Xu wrote: In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is de

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-06 Thread Guoheyi
On 2019/11/7 1:55, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote: To keep backward compatibility, we add new KVM capability "KVM_CAP_FORWARD_HYPERCALL" to probe whether KVM supports forwarding hypercall to userspace. The capability should be enabled explicitly, for

Re: [RFC v2 02/14] standard-headers: import arm_sdei.h

2019-11-06 Thread Guoheyi
On 2019/11/7 1:52, Cornelia Huck wrote: On Tue, 5 Nov 2019 17:10:44 +0800 Heyi Guo wrote: Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. This is to prepare for qemu SDEI emulation. Signed-off-by: Heyi Guo Cc: Peter Maydell Cc: Dave Martin Cc: Marc Zyngier

Re: [PATCH v14 01/11] util/cutils: Add qemu_strtotime_ns()

2019-11-06 Thread Tao Xu
On 11/7/2019 3:56 AM, Eduardo Habkost wrote: On Mon, Oct 28, 2019 at 03:52:10PM +0800, Tao Xu wrote: To convert strings with time suffixes to numbers, support time unit are "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" for second. Add test for qemu_strtotime_ns, test the

Re: [PATCH] qmp: Reset mon->commands on CHR_EVENT_CLOSED

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191106130309.6737-1-jandr...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #

[PATCH for 4.2 v1 1/1] riscv/virt: Increase flash size

2019-11-06 Thread Alistair Francis
Coreboot developers have requested that they have at least 32MB of flash to load binaries. We currently have 32MB of flash, but it is split in two to allow loading two flash binaries. Let's increase the flash size from 32MB to 64MB to ensure we have a single region that is 32MB. No QEMU release ha

Re: guest / host buffer sharing ...

2019-11-06 Thread Geoffrey McRae
On 2019-11-06 23:41, Gerd Hoffmann wrote: On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote: > (1) The virtio device > = > > Has a single virtio queue, so the guest can send commands to register > and unregister buffers. Buffers are allocated in guest ram. Ea

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 06.11.2019 15:05, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2019 at 08:25:03PM -0400, John Snow wrote: >> >> >> On 7/5/19 10:07 AM, Alexander Popov wrote: >>> This assertion was introduced in the commit a718978ed58a in July 2015. >>> It implies that the size of successful DMA transfers handled

Re: [PATCH v1 3/3] target/microblaze: Plug temp leak around eval_cond_jmp()

2019-11-06 Thread Alistair Francis
On Wed, Nov 6, 2019 at 6:17 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Plug temp leak around eval_cond_jmp(). > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/translate.c | 5 - > 1 file changed, 4 insertions(+), 1

Re: [PULL v2 00/13] Linux user for 4.2 patches

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 13:09, Laurent Vivier wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git reposit

Re: [PATCH v1 2/3] target/microblaze: Plug temp leaks with delay slot setup

2019-11-06 Thread Alistair Francis
On Wed, Nov 6, 2019 at 6:17 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Plug temp leaks with delay slot setup. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/translate.c | 26 ++ > 1 file change

Re: [QEMU-SECURITY] ide: fix assertion in ide_dma_cb() to prevent qemu DoS from quest

2019-11-06 Thread Alexander Popov
On 06.11.2019 15:08, Michael S. Tsirkin wrote: > On Wed, Nov 06, 2019 at 01:17:51PM +0300, Alexander Popov wrote: >> On 27.07.2019 00:09, Alexander Popov wrote: >>> On 26.07.2019 2:25:03 GMT+02:00, John Snow wrote: Oh, this is fun. >>> ... I can worry about a proper fix for 4.2+. >>> >>>

[Bug 1851547] Re: qemu 4 crashes with this parameter attached -usb -device usb-host, hostbus=1, hostaddr=7 \

2019-11-06 Thread Marietto
problem resolved changing this line : -usb -device usb-host,hostbus=1,hostaddr=7 \ with this : -usb -device usb-host,hostbus=1,hostaddr=8 \ it works with qemu 4. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchp

Re: [PATCH v1 1/3] target/microblaze: Plug temp leaks for loads/stores

2019-11-06 Thread Alistair Francis
On Wed, Nov 6, 2019 at 6:14 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Plug TCG temp leaks for loads/stores. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > target/microblaze/translate.c | 30 -- > 1 file cha

[PATCH] WHPX: support for xcr0

2019-11-06 Thread Sunil Muthuswamy
Support for xcr0 to be able to enable xsave/xrstor. This by itself is not sufficient to enable xsave/xrstor. WHPX XSAVE API's also needs to be hooked up. --- target/i386/whp-dispatch.h | 3 ++ target/i386/whpx-all.c | 88 ++ 2 files changed, 91 inse

Re: [PULL v2 00/21] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 22:55, Philippe Mathieu-Daudé wrote: > > Hi Peter, > > This is a X86/MIPS pull, Paolo and Aleksandar are OK I send it: > > https://lists.gnu.org/archive/html/qemu-devel/2019-10/msg04959.html > > Since v1: Fixed the Kconfig bug you reported here: > > https://lists.gnu.org/

Re: [PATCH] global: Squash 'the the'

2019-11-06 Thread David Gibson
On Mon, Nov 04, 2019 at 06:52:02PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > 'the' has a tendency to double up; squash them back down. > > Signed-off-by: Dr. David Alan Gilbert > --- > disas/libvixl/vixl/invalset.h | 2 +- > docs/interop/pr-helper.rs

Re: [PATCH v14 03/11] tests: Add test for QAPI builtin type time

2019-11-06 Thread Eduardo Habkost
On Mon, Oct 28, 2019 at 03:52:12PM +0800, Tao Xu wrote: > Add tests for time input such as zero, around limit of precision, > signed upper limit, actual upper limit, beyond limits, time suffixes, > and etc. > > Signed-off-by: Tao Xu > --- [...] > +/* Close to signed upper limit 0x7fff

Re: [PATCH v14 04/11] numa: Extend CLI to provide initiator information for numa nodes

2019-11-06 Thread Eric Blake
On 10/28/19 2:52 AM, Tao Xu wrote: In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller resp

Re: [PATCH 0/6] migration/postcopy: enable compress during postcopy

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > This patch set tries enable compress during postcopy. > > postcopy requires to place a whole host page, while migration thread migrate > memory in target page size. This makes postcopy need to collect all target > pages in one host page before pl

Re: [PATCH 5/6] migration/postcopy: enable random order target page arrival

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > After using number of target page received to track one host page, we > could have the capability to handle random order target page arrival in > one host page. > > This is a preparation for enabling compress during postcopy. > > Signed-off-by:

Re: [PATCH 4/6] migration/postcopy: set all_zero to true on the first target page

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > For the first target page, all_zero is set to true for this round check. > > After target_pages introduced, we could leverage this variable instead > of checking the address offset. > > Signed-off-by: Wei Yang Yes, OK - I find target_pages bei

Re: [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin the ram device memory region

2019-11-06 Thread Gary R Hook
- Original Message - > From: "Gary R Hook" > To: rhvirt-patc...@redhat.com > Cc: qemu-devel@nongnu.org, "Paolo Bonzini" , > gh...@redhat.com, "Eduardo Habkost" > , "Richard Henderson" > Sent: Tuesday, April 9, 2019 7:08:03 PM > Subject: [RHEL-8.1 virt 2/2] target/i386: sev: Do not pin

Re: [PATCH 3/6] migration/postcopy: count target page number to decide the place_needed

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > In postcopy, it requires to place whole host page instead of target > page. > > Currently, it relies on the page offset to decide whether this is the > last target page. We also can count the target page number during the > iteration. When the nu

Re: [PATCH 2/6] migration/postcopy: wait for decompress thread in precopy

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > Compress is not supported with postcopy, it is safe to wait for > decompress thread just in precopy. > > This is a preparation for later patch. > > Signed-off-by: Wei Yang OK, since your last patch does this for postcopy. Reviewed-by: Dr. Da

Re: [PATCH v14 01/11] util/cutils: Add qemu_strtotime_ns()

2019-11-06 Thread Eduardo Habkost
On Mon, Oct 28, 2019 at 03:52:10PM +0800, Tao Xu wrote: > To convert strings with time suffixes to numbers, support time unit are > "ns" for nanosecond, "us" for microsecond, "ms" for millisecond or "s" > for second. Add test for qemu_strtotime_ns, test the input of basic, > time suffixes, float, i

Re: [PATCH 6/6] migration/postcopy: enable compress during postcopy

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > postcopy requires to place a whole host page, while migration thread > migrate memory in target page size. This makes postcopy need to collect > all target pages in one host page before placing via userfaultfd. > > To enable compress during postc

Re: [PULL 0/1] Seabios 20191106 patches

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191106122524.5537-1-kra...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [PATCH v1 4/4] iotests: add test for virtio-scsi and virtio-blk machine type settings

2019-11-06 Thread Eduardo Habkost
On Wed, Nov 06, 2019 at 11:04:16AM +0100, Max Reitz wrote: > On 06.11.19 10:24, Stefan Hajnoczi wrote: > > On Tue, Nov 05, 2019 at 07:11:05PM +0300, Denis Plotnikov wrote: > >> It tests proper queue size settings for all available machine types. > >> > >> Signed-off-by: Denis Plotnikov > >> --- >

Re: [RFC PATCH 06/18] qemu-storage-daemon: Add --nbd-server option

2019-11-06 Thread Eric Blake
On 11/6/19 6:51 AM, Max Reitz wrote: On 17.10.19 15:01, Kevin Wolf wrote: Add a --nbd-server option to qemu-storage-daemon to start the built-in NBD server right away. It maps the arguments for nbd-server-start to the command line. Well, it doesn’t quite, because nbd-server-start takes a Socke

Re: [PATCH v8 1/3] docs: improve qcow2 spec about extending image header

2019-11-06 Thread Eric Blake
On 10/18/19 9:36 AM, Vladimir Sementsov-Ogievskiy wrote: Maybe: if software doesn't know how to interpret the field, it may be safely ignored unless a corresponding incompatible feature flag bit is set; however, the field should be preserved unchanged when rewriting the image header. + +For

Re: [PULL v2 00/13] Linux user for 4.2 patches

2019-11-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191106130456.6176-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL v2 00/13] Linux user for 4.2 patches Type: series Message-id: 20191106130456.6176-1-laur...@vivier.eu

[Bug 1851547] [NEW] qemu 4 crashes with this parameter attached -usb -device usb-host, hostbus=1, hostaddr=7 \

2019-11-06 Thread Marietto
Public bug reported: Hello. qemu / kvm does not start anymore after upgrading ubuntu from 19.04 to 19.10 and qemu from 3 to 4,as you can see below. what can I do ? root@ziomario-Z390-AORUS-PRO:/home/ziomario/Scrivania/OS-KVM# ./boot-OS- HSP2.sh > qemu-system-x86_64: /build/qemu- UryNDZ/qemu

Re: [PATCH 1/6] migration/postcopy: reduce memset when it is zero page and matches_target_page_size

2019-11-06 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > In this case, page_buffer content would not be used. > > Skip this to save some time. > > Signed-off-by: Wei Yang > --- > migration/ram.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migrat

Re: Feature Recommendations?

2019-11-06 Thread Peter Maydell
On Wed, 6 Nov 2019 at 17:42, Eric Blake wrote: > > On 11/3/19 4:59 AM, Dinah A Baum wrote: > > Hello all, > > > > I am a university student whose Virtualization course has tasked me with > > contributing to an open source, virtualization related project. I have a > > little more than a month to co

Re: [RFC v2 11/14] linux-headers/kvm.h: add capability to forward hypercall

2019-11-06 Thread Cornelia Huck
On Tue, 5 Nov 2019 17:10:53 +0800 Heyi Guo wrote: > To keep backward compatibility, we add new KVM capability > "KVM_CAP_FORWARD_HYPERCALL" to probe whether KVM supports forwarding > hypercall to userspace. > > The capability should be enabled explicitly, for we don't want user > space applicati

Re: [RFC v2 02/14] standard-headers: import arm_sdei.h

2019-11-06 Thread Cornelia Huck
On Tue, 5 Nov 2019 17:10:44 +0800 Heyi Guo wrote: > Import Linux header file include/uapi/linux/arm_sdei.h from kernel v5.4-rc5. > > This is to prepare for qemu SDEI emulation. > > Signed-off-by: Heyi Guo > Cc: Peter Maydell > Cc: Dave Martin > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: Jam

Re: [PULL 0/1] Q800 branch patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 18:07, Laurent Vivier wrote: > > The following changes since commit b7c9a7f353c0e260519bf735ff0d4aa01e72784b: > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into > staging (2019-10-31 15:57:30 +) > > are available in the Git repository at: > >

Re: Feature Recommendations?

2019-11-06 Thread Eric Blake
On 11/3/19 4:59 AM, Dinah A Baum wrote: Hello all, I am a university student whose Virtualization course has tasked me with contributing to an open source, virtualization related project. I have a little more than a month to complete this. I was wondering if you could recommend a feature you'd l

Re: [PATCH v4 06/20] module: check module wasn't already initialized

2019-11-06 Thread Darren Kenny
On Wed, Oct 30, 2019 at 02:49:52PM +, Oleinik, Alexander wrote: From: Alexander Oleinik The virtual-device fuzzer must initialize QOM, prior to running vl:qemu_init, so that it can use the qos_graph to identify the arguments required to initialize a guest for libqos-assisted fuzzing. This c

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-11-06 Thread Eric Blake
On 11/6/19 8:58 AM, Kevin Wolf wrote: Well, but anyway. Just as I didn’t have anything against adding QMP to qemu-nbd, I don’t have anything against adding a new application that kind of fulfills the same purpose. And I think introducing a new application instead of reusing qemu-nbd that focus

Re: [PATCH] numa: Add missing \n to error message

2019-11-06 Thread Laurent Vivier
Le 06/11/2019 à 17:55, Markus Armbruster a écrit : > Greg Kurz writes: > >> On Wed, 6 Nov 2019 14:01:01 +0100 >> Laurent Vivier wrote: >> >>> Le 06/11/2019 à 13:46, Greg Kurz a écrit : If memory allocation fails when using -mem-path, QEMU is supposed to print out a message to indicate

Re: [PATCH v4 13/20] fuzz: add configure flag --enable-fuzzing

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:59PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > Signed-off-by: Alexander Oleinik > --- > configure | 39 +++ > 1 file changed, 39 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP s

Re: [PATCH v4 12/20] libqtest: add in-process qtest.c tx/rx handlers

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:58PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > Signed-off-by: Alexander Oleinik > --- > There's a particularily ugly line here: > qtest_client_set_tx_handler(qts, > (void (*)(QTestState *s, const char*, size_t)) send); Please typedef th

Re: [PATCH] numa: Add missing \n to error message

2019-11-06 Thread Markus Armbruster
Greg Kurz writes: > On Wed, 6 Nov 2019 14:01:01 +0100 > Laurent Vivier wrote: > >> Le 06/11/2019 à 13:46, Greg Kurz a écrit : >> > If memory allocation fails when using -mem-path, QEMU is supposed to print >> > out a message to indicate that fallback to anonymous RAM is deprecated. >> > This >>

Re: [PATCH v4 11/20] libqtest: make qtest_bufwrite send "atomic"

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:57PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > When using qtest "in-process" communication, qtest_sendf directly calls > a function in the server (qtest.c). Combining the contents of the > subsequent socket_sends into the qtest_sendf, makes it so

Re: [Qemu-devel] [PATCH v2 00/11] RFC crypto/luks: encryption key managment using amend interface

2019-11-06 Thread Maxim Levitsky
On Mon, 2019-10-07 at 10:05 +0200, Markus Armbruster wrote: > Maxim Levitsky writes: > > > On Fri, 2019-09-20 at 17:14 -0400, John Snow wrote: > > > > > > On 9/12/19 6:30 PM, Maxim Levitsky wrote: > > > > This patch series is continuation of my work to add encryption > > > > key managment to luk

Re: [PATCH v4 10/20] libqos: move useful qos-test funcs to qos_external

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:56PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > The moved functions are not specific to qos-test and might be useful > elsewhere. For example the virtual-device fuzzer makes use of them for > qos-assisted fuzz-targets. > > Signed-off-by: Alexande

Re: [PATCH v4 07/20] qtest: add in-process incoming command handler

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:53PM +, Oleinik, Alexander wrote: > diff --git a/qtest.c b/qtest.c > index ae7e6d779d..9fbfa0f08f 100644 > --- a/qtest.c > +++ b/qtest.c > @@ -802,3 +802,16 @@ bool qtest_driver(void) > { > return qtest_chr.chr != NULL; > } > + > +void qtest_server_inproc_re

Re: [SeaBIOS] Re: 1.13 release?

2019-11-06 Thread Kevin O'Connor
On Wed, Nov 06, 2019 at 12:12:55PM +0100, Gerd Hoffmann wrote: > On Wed, Oct 16, 2019 at 12:44:12PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > Almost a year since 1.12.0 was tagged (Nov 17th to be exact), > > time to plan the 1.13 release I think ... > > > > How about freeze in a week or two,

[PULL v3 1/3] hw/misc/grlib_ahb_apb_pnp: Avoid crash when writing to PnP registers

2019-11-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Guests can crash QEMU when writting to PnP registers: $ echo 'writeb 0x800ff042 69' | qemu-system-sparc -M leon3_generic -S -bios /etc/magic -qtest stdio [I 1571938309.932255] OPENED [R +0.063474] writeb 0x800ff042 69 Segmentation fault (core dumped) (gdb

[PULL v3 2/3] hw/misc/grlib_ahb_apb_pnp: Fix 8-bit accesses

2019-11-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The Plug & Play region of the AHB/APB bridge can be accessed by various word size, however the implementation is clearly restricted to 32-bit: static uint64_t grlib_apb_pnp_read(void *opaque, hwaddr offset, unsigned size) { APBPnp *apb_pnp = GRLIB_APB_PNP(o

[PULL v3 3/3] global: Squash 'the the'

2019-11-06 Thread Laurent Vivier
From: "Dr. David Alan Gilbert" 'the' has a tendency to double up; squash them back down. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20191104185202.102504-1-dgilb...@redhat.com> [lv: removed disas

Re: [PATCH v4 05/20] libqtest: Add a layer of abstraciton to send/recv

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:52PM +, Oleinik, Alexander wrote: > @@ -360,6 +383,7 @@ void qtest_quit(QTestState *s) > g_free(s); > } > > + > static void socket_send(int fd, const char *buf, size_t size) > { > size_t offset; [...] > diff --git a/tests/libqtest.h b/tests/libqtest.

[PULL v3 0/3] Trivial branch patches

2019-11-06 Thread Laurent Vivier
The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: Merge remote-tracking branch 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 17:59:03 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-pul

QEMU HTML documentation now on qemu.org

2019-11-06 Thread Stefan Hajnoczi
Hi, You can now access the latest QEMU HTML documentation built from qemu.git/master nightly at: https://wiki.qemu.org/docs/qemu-doc.html https://wiki.qemu.org/docs/qemu-qmp-ref.html https://wiki.qemu.org/docs/qemu-ga-ref.html ...as well as interop/ and specs/ Feel free to link to the doc

Re: [Xen-devel] [PULL v2 0/3] Trivial branch patches

2019-11-06 Thread Laurent Vivier
Le 06/11/2019 à 17:05, Peter Maydell a écrit : > On Tue, 5 Nov 2019 at 20:06, Laurent Vivier wrote: >> >> Le 05/11/2019 à 20:20, no-re...@patchew.org a écrit : >>> Patchew URL: >>> https://patchew.org/QEMU/20191105175010.2591-1-laur...@vivier.eu/ >>> >>> >>> >>> Hi, >>> >>> This series seems to h

Re: [PATCH v8 1/3] docs: improve qcow2 spec about extending image header

2019-11-06 Thread Vladimir Sementsov-Ogievskiy
18.10.2019 17:36, Vladimir Sementsov-Ogievskiy wrote: > 18.10.2019 17:00, Eric Blake wrote: >> On 10/18/19 4:47 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Make it more obvious how to add new fields to the version 3 header and >>> how to interpret them. >>> >>> The specification is adjusted so for

Re: [Xen-devel] [PULL v2 0/3] Trivial branch patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 20:06, Laurent Vivier wrote: > > Le 05/11/2019 à 20:20, no-re...@patchew.org a écrit : > > Patchew URL: > > https://patchew.org/QEMU/20191105175010.2591-1-laur...@vivier.eu/ > > > > > > > > Hi, > > > > This series seems to have some coding style problems. See output below fo

Re: [PATCH v2 00/21] iotests: Allow ./check -o data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Hi, > > The cover letter from v1 (explaining the motivation behind this series > and the general structure) is here: > > https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html > > > For v2, I’ve tried to address Maxim’s comme

Re: [PULL 00/11] Block patches

2019-11-06 Thread Peter Maydell
On Tue, 5 Nov 2019 at 15:43, Stefan Hajnoczi wrote: > > The following changes since commit 36609b4fa36f0ac934874371874416f7533a5408: > > Merge remote-tracking branch > 'remotes/palmer/tags/palmer-for-master-4.2-sf1' into staging (2019-11-02 > 17:59:03 +) > > are available in the Git reposi

Re: [PATCH v2 21/21] iotests: Allow check -o data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > The problem with allowing the data_file option is that you want to use a > different data file per image used in the test. Therefore, we need to > allow patterns like -o data_file='$TEST_IMG.data_file'. > > Then, we need to filter it out from

Re: [PATCH v2 20/21] iotests: Disable data_file where it cannot be used

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/007 | 5 +++-- > tests/qemu-iotests/014 | 2 ++ > tests/qemu-iotests/015 | 5 +++-- > tests/qemu-iotests/026 | 5 - > tests/qemu-iotests/029 | 5 +++-- > tests/qemu-iotests/031 | 6 +++---

Re: [PATCH v2 19/21] iotests: Make 198 work with data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > We do not care about the json:{} filenames here, so we can just filter > them out and thus make the test work both with and without external data > files. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/198 | 6 -- > tests/qem

Re: [PATCH v2 18/21] iotests: Make 137 work with data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > When using an external data file, there are no refcounts for data > clusters. We thus have to adjust the corruption test in this patch to > not be based around a data cluster allocation, but the L2 table > allocation (L2 tables are still refcou

Re: [PATCH v2 17/21] iotests: Make 110 work with data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > The only difference is that the json:{} filename of the image looks > different. We actually do not care about that filename in this test, we > are only interested in (1) that there is a json:{} filename, and (2) > whether the backing filename

Re: [PATCH v2 12/21] iotests: Drop IMGOPTS use in 267

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Overwriting IMGOPTS means ignoring all user-supplied options, which is > not what we want. Replace the current IMGOPTS use by a new BACKING_FILE > variable. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/267 | 12 > 1 f

Re: [PATCH v2 16/21] iotests: Make 091 work with data_file

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > The image end offset as reported by qemu-img check is different when > using an external data file; we do not care about its value here, so we > can just filter it. Incidentally, common.rc already has _check_test_img > for us which does exactly

Re: [PATCH v2 14/21] iotests: Use _rm_test_img for deleting test images

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Just rm will not delete external data files. Use _rm_test_img every > time we delete a test image. > > (In the process, clean up the indentation of every _cleanup() this patch > touches.) > > ((Also, use quotes consistently. I am happy to se

Re: logfile issue

2019-11-06 Thread Robert Foley
On Mon, 4 Nov 2019 at 07:13, Alex Bennée wrote: > I wonder if using RCU to swap out the new and old FD would make things a > bit smoother here? You would have to tweak the qemu_log_lock/unlock > functions to preserve the current FD around the lock and call_rcu a > freeing function when a new hand

Re: [PATCH v2 10/21] iotests: Replace IMGOPTS= by -o

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Tests should not overwrite all user-supplied image options, but only add > to it (which will effectively overwrite conflicting values). Accomplish > this by passing options to _make_test_img via -o instead of $IMGOPTS. > > For some tests, ther

Re: [PATCH v2 05/21] iotests: Replace IMGOPTS by _unsupported_imgopts

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Some tests require compat=1.1 and thus set IMGOPTS='compat=1.1' > globally. That is not how it should be done; instead, they should > simply set _unsupported_imgopts to compat=0.10 (compat=1.1 is the > default anyway). > > This makes the tests

Re: [PATCH v2 04/21] iotests: Filter refcount_order in 036

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > This test can run just fine with other values for refcount_bits, so we > should filter the value from qcow2.py's dump-header. In fact, we can > filter everything but the feature bits and header extensions, because > that is what the test is abo

Re: [PATCH v2 03/21] iotests: Add _filter_json_filename

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/common.filter | 24 > 1 file changed, 24 insertions(+) > > diff --git a/tests/qemu-iotests/common.filter > b/tests/qemu-iotests/common.filter > index 9f418b4881..63

Re: [PATCH v3 00/12] linux-user sparc fixes

2019-11-06 Thread Laurent Vivier
Le 06/11/2019 à 15:58, no-re...@patchew.org a écrit : > Patchew URL: > https://patchew.org/QEMU/20191106113318.10226-1-richard.hender...@linaro.org/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [PATCH v3 00/12] lin

Re: [PATCH v2 02/21] iotests/qcow2.py: Split feature fields into bits

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > Print the feature fields as a set of bits so that filtering is easier. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/031.out | 36 +-- > tests/qemu-iotests/036.out | 18 +- > tests/qemu-iotests/039.out | 2

Re: [PATCH v2 01/21] iotests/qcow2.py: Add dump-header-exts

2019-11-06 Thread Maxim Levitsky
On Tue, 2019-10-15 at 16:27 +0200, Max Reitz wrote: > This is useful for tests that want to whitelist fields from dump-header > (with grep) but still print all header extensions. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/qcow2.py | 5 + > 1 file changed, 5 insertions(+) > > di

Re: [RFC PATCH 00/18] Add qemu-storage-daemon

2019-11-06 Thread Max Reitz
On 06.11.19 15:58, Kevin Wolf wrote: > Am 06.11.2019 um 15:37 hat Max Reitz geschrieben: >> On 17.10.19 15:01, Kevin Wolf wrote: >>> This series adds a new tool 'qemu-storage-daemon', which can be used to >>> export and perform operations on block devices. >> >> Looks good to me. >> >> I remember a

Re: [Qemu-devel] [PATCH v2 0/2] Avoid sending zero-size packets

2019-11-06 Thread Stefan Hajnoczi
On Mon, Jul 22, 2019 at 01:24:44PM +, Oleinik, Alexander wrote: > While fuzzing the virtio-net tx vq, I ran into an assertion failure due > to iov_copy offsets larger than the total iov size. Though there is > a check to cover this, it does not execute when !n->has_vnet_hdr. This > patch tries

Re: [PATCH v4 00/20] Add virtual device fuzzing support

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 08:23:57AM -0700, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191030144926.11873-1-alx...@bu.edu/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have D

Re: [PATCH v4 06/20] module: check module wasn't already initialized

2019-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2019 at 02:49:52PM +, Oleinik, Alexander wrote: > From: Alexander Oleinik > > The virtual-device fuzzer must initialize QOM, prior to running > vl:qemu_init, so that it can use the qos_graph to identify the arguments > required to initialize a guest for libqos-assisted fuzzing

  1   2   3   >