From: Kővágó, Zoltán
This way we no longer need vararg functions, improving compile time
error detection. Also now it's possible to check actually what commands
are supported, without needing to manually update ctl_caps.
Signed-off-by: Kővágó, Zoltán
Message-id:
2b08b3773569c5be055d0a0fb2f29f
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
22ab335146acd8099779583edcf6ed46de836bd6.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/ossaudio.c | 288 +--
1 file changed, 104 insertions(+), 184 deletio
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
21fe8f2cf949039c8c40a0352590c593b104917d.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
configure| 5 -
audio/audio_pt_int.h | 22 ---
audio/audio_pt_int.c | 173
audio/p
From: Kővágó, Zoltán
This commit removes the ad-hoc rate-limiting code from noaudio and
wavaudio, and replaces them with a (slightly modified) code from
spiceaudio. This way multiple write calls (for example when the
circular buffer wraps around) do not cause problems.
Signed-off-by: Kővágó, Zo
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
497decab6d0f0fb9529bea63ec7ce0bd7b553038.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/audio_int.h | 7 ---
audio/audio.c | 42 ++
2 files changed, 6
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
4d3356df9ccbffee2f710b93d456443c81e3f011.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/spiceaudio.c | 116 -
1 file changed, 42 insertions(+), 74 deletions
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
2ca925ab551ea832c930fc2db213a9e73d8dab7f.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/dsound_template.h | 47 +++---
audio/dsoundaudio.c | 329 ++--
2 files
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
ac1722a03fb1b530c2081f46585ce7fa80ebef6c.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/sdlaudio.c | 87 +++-
1 file changed, 42 insertions(+), 45 deletions
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
eede77aeb9c17b379948b0b6d2ac10f45d74fa62.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/wavaudio.c | 54
1 file changed, 9 insertions(+), 45 deletions(
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
ab9768e73dfe7b7305bd6a51629846e0d77622a5.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/alsaaudio.c | 308 +-
1 file changed, 83 insertions(+), 225 deletion
From: Kővágó, Zoltán
Usage notes: hw->samples became hw->{mix,conv}_buf->size, except before
initialization (audio_pcm_hw_alloc_resources_*), hw->samples gives the
initial size of the STSampleBuffer. The next commit tries to fix this
inconsistency.
Signed-off-by: Kővágó, Zoltán
Message-id:
a7
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
586a1e66de5cbc6c5234f9ae556d24befb6afada.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/coreaudio.c | 130 --
1 file changed, 69 insertions(+), 61 deletions
From: Kővágó, Zoltán
This will make it possible to skip mixeng with audio playback and
recording, allowing us to free ourselves from the limitations of the
current mixeng (stereo, int64 samples only). In this case, HW and SW
voices will be essentially the same, for every SW voice we will create
From: Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán
Message-id:
10eebdd2e1529c2bd403ef98dd9d346c6d4ca3d1.1568927990.git.dirty.ice...@gmail.com
Signed-off-by: Gerd Hoffmann
---
audio/noaudio.c | 39 +++
1 file changed, 15 insertions(+), 24 deletions(-)
diff
From: Stefan Hajnoczi
Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation")
Signed-off-by: Stefan Hajnoczi
Message-Id: <20190918095335.7646-4-stefa...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
From: Stefan Hajnoczi
Fixes: f0b3d811529 ("audio: -audiodev command line option: documentation")
Signed-off-by: Stefan Hajnoczi
Message-Id: <20190918095335.7646-2-stefa...@redhat.com>
Signed-off-by: Gerd Hoffmann
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
di
The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:
Merge remote-tracking branch 'remotes/cleber/tags/python-next-pull-request'
into staging (2019-09-20 17:28:43 +0100)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/audio-20190924-pull-reques
24 Eylül 2019 Salı tarihinde Thomas Huth <1824...@bugs.launchpad.net>
yazdı:
> Can you find out which commit broke the keyboard for you? (By using "git
> bisect" for example)
>
> ** Information type changed from Private Security to Public
>
> --
> You received this bug notification because you are
Can you find out which commit broke the keyboard for you? (By using "git
bisect" for example)
** Information type changed from Private Security to Public
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs
*** This bug is a duplicate of bug 1842774 ***
https://bugs.launchpad.net/bugs/1842774
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1842916
Title:
[18.04 FEAT] Enha
Patch a0e2251132995b9 is a kernel patch, thus this is certainly not
something we need to track in the upstream QEMU bugtracker.
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bug
On 24/09/2019 06:59, David Gibson wrote:
> TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever
> instantiated, and the only one we're ever likely to want. The
> existence of different classes is just a hang over from when we
> (misguidedly) had separate subtypes for the KVM and non-KV
On 24/09/2019 06:59, David Gibson wrote:
> There are a number of ics_simple_*() functions that aren't actually
> specific to TYPE_XICS_SIMPLE at all, and are equally valid on
> TYPE_XICS_BASE. Rename them to ics_*() accordingly.
>
> Signed-off-by: David Gibson
Reviewed-by: Cédric Le Goater
C
On 24/09/2019 06:59, David Gibson wrote:
> Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and
> realize methods, using the standard technique for having the subtype
> call the supertype's methods before doing its own thing.
>
> But TYPE_XICS_SIMPLE is the only subtype of TYPE_X
On 24/09/2019 06:59, David Gibson wrote:
> Currently ics_reject(), ics_resend() and ics_eoi() indirect through
> class methods. But there's only one implementation of each method,
> the one in TYPE_ICS_SIMPLE. TYPE_ICS_BASE has no implementation, but
> it's never instantiated, and has no other su
On 24/09/2019 06:59, David Gibson wrote:
> The XICS interrupt controller device used to have separate subtypes
> for the KVM and non-KVM variant of the device. That was a bad idea,
> because it leaked information that should be entirely host-side
> implementation specific to the kinda-sorta guest
TYPE_ICS_SIMPLE is the only subtype of TYPE_ICS_BASE that's ever
instantiated, and the only one we're ever likely to want. The
existence of different classes is just a hang over from when we
(misguidedly) had separate subtypes for the KVM and non-KVM version of
the device.
So, collapse the two cl
Currently TYPE_XICS_BASE and TYPE_XICS_SIMPLE have their own reset and
realize methods, using the standard technique for having the subtype
call the supertype's methods before doing its own thing.
But TYPE_XICS_SIMPLE is the only subtype of TYPE_XICS_BASE ever
instantiated, so there's no point hav
On Mon, Sep 23, 2019 at 10:01 PM wrote:
>
> From: Guo Ren
>
> Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we
> need to ignore them. They can not be a part of ppn.
>
> 1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture
>4.4 Sv39: Page-Based 39-bi
From: Guo Ren
Highest 10 bits of PTE are reserved in riscv-privileged, ref: [1], so we
need to ignore them. They can not be a part of ppn.
1: The RISC-V Instruction Set Manual, Volume II: Privileged Architecture
4.4 Sv39: Page-Based 39-bit Virtual-Memory System
4.5 Sv48: Page-Based 48-bit
There are a number of ics_simple_*() functions that aren't actually
specific to TYPE_XICS_SIMPLE at all, and are equally valid on
TYPE_XICS_BASE. Rename them to ics_*() accordingly.
Signed-off-by: David Gibson
---
hw/intc/trace-events | 6 +++---
hw/intc/xics.c| 29 ++-
Currently ics_reject(), ics_resend() and ics_eoi() indirect through
class methods. But there's only one implementation of each method,
the one in TYPE_ICS_SIMPLE. TYPE_ICS_BASE has no implementation, but
it's never instantiated, and has no other subtypes.
So clean up by eliminating the method an
The XICS interrupt controller device used to have separate subtypes
for the KVM and non-KVM variant of the device. That was a bad idea,
because it leaked information that should be entirely host-side
implementation specific to the kinda-sorta guest visible QOM class
names.
We eliminated the KVM s
On 23/09/2019 20.50, Peter Maydell wrote:
> On Mon, 23 Sep 2019 at 19:36, Thomas Huth wrote:
>>
>> On 23/09/2019 20.27, Peter Maydell wrote:
>>> On Mon, 23 Sep 2019 at 18:54, Thomas Huth wrote:
Ok, then what would you suggest to solve the problem that this file has
always to be linked i
Hi Eduardo,
How about this version of patch? Last month this patch is reverted from
pull request. And I submitted this version.
Tao
On 9/5/2019 4:32 PM, Xu, Tao3 wrote:
Add MachineClass::auto_enable_numa field. When it is true, a NUMA node
is expected to be created implicitly.
Acked-by: Dav
On Mon, Sep 23, 2019 at 06:49:12PM +0200, Paolo Bonzini wrote:
> On 23/09/19 18:15, Igor Mammedov wrote:
> > Yep, commit message doesn't fit patch, how about following description:
> > "
> > Currently MemoryRegionSection has 1:1 mapping to KVMSlot.
> > However next patch will allow splitting Memory
> I would start by using the QEMU gdbstub to connect a
> MIPS-aware gdb. Then when the SIGILL arrives you can see
> what instruction the guest program was trying to execute.
Just tried it and found something interesting.
I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was s
> I would start by using the QEMU gdbstub to connect a
> MIPS-aware gdb. Then when the SIGILL arrives you can see
> what instruction the guest program was trying to execute.
Just tried it and found something interesting.
I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was s
> I would start by using the QEMU gdbstub to connect a
> MIPS-aware gdb. Then when the SIGILL arrives you can see
> what instruction the guest program was trying to execute.
Just tried it and found something interesting.
I connected gdb-multiarch to QEMU gdbstub. gdb-multiarch's architecture was s
> From: Tian, Kevin
> Sent: Friday, September 13, 2019 7:00 AM
>
> > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > Sent: Thursday, September 12, 2019 10:41 PM
> >
> > On Tue, 3 Sep 2019 06:57:27 +
> > "Tian, Kevin" wrote:
> >
> > > > From: Alex Williamson [mailto:alex.william.
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, September 20, 2019 9:19 AM
>
> On 2019/9/20 上午6:54, Tian, Kevin wrote:
> >> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> >> Sent: Thursday, September 19, 2019 7:14 PM
> >>
> >> On 19/09/19 09:16, Tian, Kevin wrote:
> > why G
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-cr...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190923134019.8548-1-cr...@redhat.com
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Typ
Beata Michalska writes:
> ARMv8.2 introduced support for Data Cache Clean instructions
> to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence)
> - DV CVADP. Both specify conceptual points in a memory system where all writes
> that are to reach them are considered persiste
> Can you run QEMU with some debugging options:
> qemu-mipsel -d in_asm,exec,cpu,unimp,guest_errors,nochain -D debug.log
> -singlestep test
> and then put the resulting debug.log somewhere we can get it?
> (it'll probably be quite large)
The logging only shows this little information. It seems l
Drop the duplicated definition of cpuid AVX512_VBMI and marco and
rename it as CPUID_7_0_ECX_AVX512_VBMI. And rename CPUID_7_0_ECX_VBMI2
as CPUID_7_0_ECX_AVX512_VBMI2.
Signed-off-by: Tao Xu
---
target/i386/cpu.c | 8
target/i386/cpu.h | 5 ++---
target/i386/hvf/x86_c
Add some comments, clean up comments over 80 chars per line. And there
is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove
the extra enter and spaces.
Drop the duplicated definition of cpuid AVX512_VBMI marco and rename it
as CPUID_7_0_ECX_AVX512_VBMI. And rename CPUID_7_0_ECX_VBMI
Add some comments, clean up comments over 80 chars per line. And there
is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove
the extra enter and spaces.
Acked-by: Stefano Garzarella
Signed-off-by: Tao Xu
---
target/i386/cpu.h | 164 ++
1
On Tue, Sep 24, 2019 at 1:51 AM Alistair Francis wrote:
>
> On Sat, Sep 21, 2019 at 7:19 PM Bin Meng wrote:
> >
> > On Sat, Sep 21, 2019 at 6:12 AM Alistair Francis
> > wrote:
> > >
> > > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote:
> > > >
> > > > On Fri, Sep 20, 2019 at 6:32 AM Alistair
On 2019-09-23 15:12, Markus Armbruster wrote:
"Kővágó, Zoltán" writes:
Add an option to change the channel map used by pulseaudio. If not
specified, falls back to an OSS compatible channel map.
Signed-off-by: Kővágó, Zoltán
---
audio/paaudio.c | 18 ++
qapi/audio.json |
On 2019-09-23 15:08, Markus Armbruster wrote:
"Kővágó, Zoltán" writes:
This will allow us to disable mixeng when we use a decent backend.
Disabling mixeng have a few advantages:
* we no longer convert the audio output from one format to another, when
the underlying audio system would just
On 23/09/19 20:32, Jintack Lim wrote:
> On Mon, Sep 23, 2019 at 4:48 AM Paolo Bonzini wrote:
>>
>> On 23/09/19 12:42, Dr. David Alan Gilbert wrote:
>>>
>>> With those two clues, I guess maybe some dirty pages made by L2 are
>>> not transferred to the destination correctly, but I'm not really sure.
On Mon, Sep 23, 2019 at 06:49:42PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Various parts of the migration code do different things when they're
> in postcopy mode; prior to this patch this has been 'postcopy-active'.
> This patch extends 'in_postcopy' to in
Beata Michalska writes:
> Add an option to trigger memory writeback to sync given memory region
> with the corresponding backing store, case one is available.
> This extends the support for persistent memory, allowing syncing on-demand.
>
> Also, adding verification for msync support on host.
>
Beata Michalska writes:
> ARMv8.2 introduced support for Data Cache Clean instructions
> to PoP (point-of-persistence) - DC CVAP and PoDP (point-of-deep-persistence)
> - DV CVADP. Both specify conceptual points in a memory system where all writes
> that are to reach them are considered persiste
Beata Michalska writes:
> Add probe_read alongside the write probing equivalent.
>
> Signed-off-by: Beata Michalska
Reviewed-by: Alex Bennée
> ---
> include/exec/exec-all.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> in
On Mon, Sep 23, 2019 at 05:10:43PM -0600, Alex Williamson wrote:
> On Mon, 23 Sep 2019 13:43:08 +0200
> Auger Eric wrote:
>
> > On 9/23/19 9:51 AM, Peter Xu wrote:
> > > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote:
> > >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VF
The 'r' variable was accidently shadowed, and because of this
we were always passing 0 to mpath_generic_sense, instead of original
return value, which triggers an abort()
This is an attempt to fix the
https://bugzilla.redhat.com/show_bug.cgi?id=1720047
although there might be other places in the c
On Mon, 23 Sep 2019 13:43:08 +0200
Auger Eric wrote:
> On 9/23/19 9:51 AM, Peter Xu wrote:
> > On Mon, Sep 23, 2019 at 08:55:51AM +0200, Eric Auger wrote:
> >> @@ -1308,9 +1319,9 @@ static int vfio_connect_container(VFIOGroup *group,
> >> AddressSpace *as,
> >>
Fixes the previous TLB_WATCHPOINT patches because we are currently
failing to set cpu->mem_io_pc with the call to cpu_check_watchpoint.
Pass down the retaddr directly because it's readily available.
Fixes: 50b107c5d61
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
accel/tcg
On Mon, 23 Sep 2019 08:55:51 +0200
Eric Auger wrote:
> The container error integer field is currently used to store
> the first error potentially encountered during any
> vfio_listener_region_add() call. However this fails to propagate
> detailed error messages up to the vfio_connect_container ca
All callers pass false to this argument. Remove it and pass the
constant on to tb_invalidate_phys_page_range__locked.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
accel/tcg/translate-all.h | 3 +--
accel/tcg/translate-all.c | 6 ++
exec.c| 4 ++--
With the merge of notdirty handling into store_helper,
the last user of cpu->mem_io_vaddr was removed.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
include/hw/core/cpu.h | 2 --
accel/tcg/cputlb.c| 2 --
hw/core/cpu.c | 1 -
3 files changed, 5 deletions(-)
di
Since 9458a9a1df1a, all readers of the dirty bitmaps wait
for the rcu lock, which means that they wait until the end
of any executing TranslationBlock.
As a consequence, there is no need for the actual access
to happen in between the _prepare and _complete. Therefore,
we can improve things by mer
We will shortly be using these more than once.
Signed-off-by: Richard Henderson
---
accel/tcg/cputlb.c | 110 +++--
1 file changed, 57 insertions(+), 53 deletions(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index e529af6d09..430ba4a69d 100644
There is only one caller, tlb_set_page_with_attrs. We cannot
inline the entire function because the AddressSpaceDispatch
structure is private to exec.c, and cannot easily be moved to
include/exec/memory-internal.h.
Compute is_ram and is_romd once within tlb_set_page_with_attrs.
Fold the number of
Rather than rely on cpu->mem_io_pc, pass retaddr down directly.
Within tb_invalidate_phys_page_range__locked, the is_cpu_write_access
parameter is non-zero exactly when retaddr would be non-zero, so that
is a simple replacement.
Recognize that current_tb_not_found is true only when mem_io_pc
(and
The memory_region_tb_read tracepoint is unreachable, since notdirty
is supposed to apply only to writes. The memory_region_tb_write
tracepoint is mis-named, because notdirty is not only used for TB
invalidation. It is also used for e.g. VGA RAM updates and migration.
Replace memory_region_tb_wri
Pages that we want to track for NOTDIRTY are RAM. We do not
really need to go through the I/O path to handle them.
Acked-by: David Hildenbrand
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/cpu-common.h | 2 --
accel/tcg/cputlb.c| 26 +++
Cleber Rosa writes:
> On Thu, Sep 19, 2019 at 06:10:03PM +0100, Alex Bennée wrote:
>> There is a race here in the clean-up code so lets just accept that
>> sometimes the active task we just looked up might have finished before
>> we got to inspect it.
>>
>> Signed-off-by: Alex Bennée
>> ---
>>
We can use notdirty_write for the write and
return a valid host pointer for this case.
Signed-off-by: Richard Henderson
---
accel/tcg/cputlb.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index 09b0df87c6.
Handle bswap on ram directly in load/store_helper. This fixes a
bug with the previous implementation in that one cannot use the
I/O path for RAM.
Fixes: a26fc6f5152b47f1
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h | 4 ++-
accel/tcg/cputlb.c
This forced inlining can result in missing symbols,
which makes a debugging build harder to follow.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: David Hildenbrand
Reported-by: Peter Maydell
Signed-off-by: Richard Henderson
---
include/qemu/compiler.h | 11 +++
accel/tcg/cputlb.c
Increase the current runtime assert to a compile-time assert.
Signed-off-by: Richard Henderson
---
accel/tcg/cputlb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index b87764..e529af6d09 100644
--- a/accel/tcg/cputlb.c
+++
It does not require going through the whole I/O path
in order to discard a write.
Reviewed-by: David Hildenbrand
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h| 5 -
include/exec/cpu-common.h | 1 -
accel/tcg/cputlb.c| 35 +++--
exec.c
Use this as a compile-time assert that a particular
code path is not reachable.
Signed-off-by: Richard Henderson
---
include/qemu/compiler.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index 20780e722d..6604ccea92 100644
Changes since v3:
* Don't accidentally include the TARGET_PAGE_BITS_VARY patch set. ;-)
* Remove __has_attribute(__always_inline__).
* Use single load/store_memop function instead of separate small wrappers.
* Introduce optimize_away to assert the code folds away as expected.
Patches with
These bits do not need to vary with the actual page size
used by the guest.
Reviewed-by: David Hildenbrand
Reviewed-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/exec/c
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote:
> > if (cmit_fmt_is_mail(pp->fmt)) {
> > - if (pp->from_ident && ident_cmp(pp->from_ident, &ident)) {
> > + if (pp->always_use_in_body_from ||
> > + (pp->from_ident && ident_cmp(pp->from_id
On Fri, 20 Sep 2019 at 23:23, Alistair Francis wrote:
> On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote:
> > I don't think we should mirror what is used on ARM virt board to
> > create 2 flash for sifive_u. For ARM virt, there are 2 flashes because
> > they need distinguish secure and non-secure.
If we try to start QEMU with "-k en-us", qemu prints a message and exits
with:
qemu-system-i386: could not read keymap file: 'en-us'
It's because this function is called way too early, before
qemu_add_data_dir() is called, and so qemu_find_file() fails.
To fix that, move init_keyboard_layout
On Mon, 23 Sep 2019 at 09:07, David Hildenbrand wrote:
>
> Hi Peter,
>
> here is the updated tcg subset of the s390x update (including one more
> test).
>
> The following changes since commit 4300b7c2cd9f3f273804e8cca325842ccb93b1ad:
>
> Merge remote-tracking branch 'remotes/cleber/tags/python-n
On 8/27/19 4:24 AM, Sam Eiderman via Qemu-block wrote:
> From: Sam Eiderman
>
> Relevant devices are:
> * ide-hd (and ide-cd, ide-drive)
> * scsi-hd (and scsi-cd, scsi-disk, scsi-block)
> * virtio-blk-pci
>
> We do not call del_boot_device_lchs() for ide-* since we don't need to -
On 9/23/19 3:05 PM, Eduardo Habkost wrote:
> On Mon, Sep 23, 2019 at 01:19:41PM -0400, John Snow wrote:
>> On 9/23/19 10:50 AM, Cleber Rosa wrote:
> [...]
diff --git a/tests/docker/dockerfiles/debian-xtensa-cross.docker
b/tests/docker/dockerfiles/debian-xtensa-cross.docker
index
On 9/23/19 3:05 PM, Eric Blake wrote:
> Does running this Coccinelle script 2 times in a row add a second
> ERRP_FUNCTION_BEGIN() line? We want it to be idempotent (no changes on
> a second run). (Admittedly, I did not actually test that yet). Also, I
> don't know if this can be tweaked to avoi
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> scripts/coccinelle/auto-propagated-errp.cocci | 82 +++
> 1 file changed, 82 insertions(+)
> create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci
>
> diff -
On Thu, Sep 19, 2019 at 06:10:03PM +0100, Alex Bennée wrote:
> There is a race here in the clean-up code so lets just accept that
> sometimes the active task we just looked up might have finished before
> we got to inspect it.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/docker.py | 32 ++
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> fit_load_fdt forget to zero errp. Fix it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> hw/core/loader-fit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Independent bug fix. Either we take the (fixed) 2-3 (to r
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
A "why" as the commit message body wouldn't hurt.
> include/qapi/error.h | 22 ++
> util/error.c | 6 +++---
> 2 files changed, 25 insertions(+), 3 deletions
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> Here is a proposal of auto propagation for local_err, to not call
> error_propagate on every exit point, when we deal with local_err.
>
> It also fixes two issues:
> 1. Fix issue with error_fatal & error_append_hint: user can'
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Error **errp is almost always OUT-argument: it's assumed to be NULL, or
> pointer to NULL-initialized pointer, or pointer to error_abort or
> error_fatal, for callee to report error.
>
> But very few functions (most of the are error API) i
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Don't shadow Error *err: it's a bad thing. This patch also simplifies
> following Error propagation conversion.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> net/net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> This commit is generated by command
>
> git grep -l 'Error \*\*errp' | while read f; \
> do spatch --sp-file \
> scripts/coccinelle/auto-propagated-errp.cocci --in-place $f; done
>
As mentioned in your cover letter, this fails syntax-che
On 9/23/19 11:12 AM, Vladimir Sementsov-Ogievskiy wrote:
> Here is introduced ERRP_FUNCTION_BEGIN macro, to be used at start of
> any function with errp parameter.
>
> It has three goals:
>
> 1. Fix issue with error_fatal & error_append_hint: user can't see these
> hints, because exit() happens i
Patchew URL: https://patchew.org/QEMU/20190923080712.23951-1-da...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190923080712.23951-1-da...@redhat.com
Subject: [PULL 00/30] s390x/tcg update
Type: series
=== TEST SCRI
On Sat, Sep 21, 2019 at 7:15 PM Bin Meng wrote:
>
> On Sat, Sep 21, 2019 at 6:16 AM Alistair Francis wrote:
> >
> > On Thu, Sep 19, 2019 at 10:15 PM Bin Meng wrote:
> > >
> > > On Fri, Sep 20, 2019 at 6:36 AM Alistair Francis
> > > wrote:
> > > >
> > > > Add the CFI01 PFlash to the RISC-V virt
On 9/23/19 3:49 PM, Cleber Rosa wrote:
> On Thu, Sep 19, 2019 at 06:10:02PM +0100, Alex Bennée wrote:
>> From: John Snow
>>
>> When it was based on docker8 which uses python-minimal, it needed this.
>
> Assuming this docker8 was a typo? I mean, s/docker8/debian8/ ?
>
> - Cleber
>
WHOOPS, ye
Patchew URL: https://patchew.org/QEMU/20190923134019.8548-1-cr...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190923134019.8548-1-cr...@redhat.com
Subject: [PULL 0/7] Python (acceptance tests) queue - 2019-09-23
Typ
On 9/17/19 12:13 PM, Vladimir Sementsov-Ogievskiy wrote:
> Add test, which starts backup to nbd target and restarts nbd server
> during backup.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> tests/qemu-iotests/264| 65 +++
> tests/qemu-iotests/264
On Thu, Sep 19, 2019 at 06:10:02PM +0100, Alex Bennée wrote:
> From: John Snow
>
> When it was based on docker8 which uses python-minimal, it needed this.
Assuming this docker8 was a typo? I mean, s/docker8/debian8/ ?
- Cleber
> It no longer does.
>
> Goodbye, python2.7.
>
> Signed-off-by: J
On Thu, Sep 19, 2019 at 06:10:01PM +0100, Alex Bennée wrote:
> Finger trouble in a previous clean-up inadvertently set
> DEBIAN_PARTIAL_IMAGES instead of DOCKER_PARTIAL_IMAGES. Also fix the
> typo to debian-9-mxe.
>
> Fixes: 44d5a8bf5d2
> Signed-off-by: John Snow
> [AJB: merged fix from Message-I
1 - 100 of 368 matches
Mail list logo
