[Qemu-devel] [PULL v2 13/15] linux-user: Add support for FDFLUSH ioctl

2019-09-10 Thread Laurent Vivier
From: Yunqiang Su FDFLUSH is used for flushing buffers of floppy drives. Support in QEMU is needed because some of Debian packages use this ioctl while running post-build tests. One such example is 'tar' package. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic Reviewed-by: Lauren

[Qemu-devel] [PULL v2 11/15] linux-user: Add support for RNDRESEEDCRNG ioctl

2019-09-10 Thread Laurent Vivier
From: Aleksandar Markovic RNDRESEEDCRNG is a newer ioctl (added in kernel 4.17), and an "ifdef" guard is used for that reason in this patch. Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier Message-Id: <1567601968-26946-3-git-send-email-aleksandar.marko...@rt-rk.com> Signed-off-b

[Qemu-devel] [PULL v2 03/15] linux-user: erroneous fd_trans_unregister call

2019-09-10 Thread Laurent Vivier
From: Shu-Chun Weng timer_getoverrun returns the "overrun count" for the timer, which is not a file descriptor and thus should not call fd_trans_unregister on it. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier Message-Id: <20190819185348.221825-1-...@google.com> Signed-off-by: Lauren

[Qemu-devel] [PULL v2 09/15] target/xtensa: linux-user: add call0 ABI support

2019-09-10 Thread Laurent Vivier
From: Max Filippov Xtensa binaries built for call0 ABI don't rotate register window on function calls and returns. Invocation of signal handlers from the kernel is therefore different in windowed and call0 ABIs. There's currently no way to determine xtensa ELF binary ABI from the binary itself. A

[Qemu-devel] [PULL v2 04/15] linux-user: fail and report on bad dfilter specs

2019-09-10 Thread Laurent Vivier
From: Alex Bennée Just passing NULL means we end up ignoring the bad dfilter spec instead of reporting it and exiting as we should. Signed-off-by: Alex Bennée Reviewed-by: Laurent Vivier Message-Id: <20190830143648.2967-1-alex.ben...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/m

[Qemu-devel] [PULL v2 05/15] linux-user: add memfd_create

2019-09-10 Thread Laurent Vivier
From: Shu-Chun Weng Add support for the memfd_create syscall. If the host does not have the libc wrapper, translate to a direct syscall with NC-macro. Buglink: https://bugs.launchpad.net/qemu/+bug/1734792 Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier Message-Id: <20190819180947.1807

[Qemu-devel] [PULL v2 02/15] linux-user: Add AT_HWCAP2 for aarch64-linux-user

2019-09-10 Thread Laurent Vivier
From: Richard Henderson Add the HWCAP2_* bits from kernel version v5.3-rc3. Enable the bits corresponding to ARMv8.5-CondM and ARMv8.5-FRINT. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-Id: <20190809171156.3476-1-richard.hender...@linaro.org> Signed-off-by: Laurent Vivi

[Qemu-devel] [PATCH v2 12/17] RISC-V: add vector extension fixed point instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 37 + target/riscv/insn32.decode | 37 + target/riscv/insn_trans/trans_rvv.inc.c | 37 + target/riscv/vector_helper.c| 3388 +++ 4 files changed, 3

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Message-id: 20190910163600.19971-1-laur...@vivier.eu Ty

[Qemu-devel] [PULL v2 00/15] Linux user for 4.2 patches

2019-09-10 Thread Laurent Vivier
The following changes since commit 89ea03a7dc83ca36b670ba7f787802791fcb04b1: Merge remote-tracking branch 'remotes/huth-gitlab/tags/m68k-pull-2019-09-07' into staging (2019-09-09 09:48:34 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-4.2

[Qemu-devel] [PATCH v2 16/17] RISC-V: add vector extension mask instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 16 + target/riscv/insn32.decode | 17 + target/riscv/insn_trans/trans_rvv.inc.c | 27 ++ target/riscv/vector_helper.c| 635 4 files changed, 695

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread Laurent Vivier
Hi, I'm going to resend with fixed author email. Thanks, Laurent Le 11/09/2019 à 06:36, no-re...@patchew.org a écrit : > Patchew URL: > https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ > > > > Hi, > > This series seems to have some coding style problems. See output below f

[Qemu-devel] [PATCH v2 11/17] RISC-V: add vector extension integer instructions part4, mul/div/merge

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 41 + target/riscv/insn32.decode | 41 + target/riscv/insn_trans/trans_rvv.inc.c | 41 + target/riscv/vector_helper.c| 2838 +++ 4 files changed, 2

[Qemu-devel] [PATCH v2 15/17] RISC-V: add vector extension reduction instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 17 + target/riscv/insn32.decode | 17 + target/riscv/insn_trans/trans_rvv.inc.c | 17 + target/riscv/vector_helper.c| 1275 +++ 4 files changed, 1

[Qemu-devel] [PATCH v2 10/17] RISC-V: add vector extension integer instructions part3, cmp/min/max

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 29 + target/riscv/insn32.decode | 29 + target/riscv/insn_trans/trans_rvv.inc.c | 29 + target/riscv/vector_helper.c| 2280 +++ 4 files changed, 2

[Qemu-devel] [PATCH v2 13/17] RISC-V: add vector extension float instruction part1, add/sub/mul/div

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 37 + target/riscv/insn32.decode | 37 + target/riscv/insn_trans/trans_rvv.inc.c | 37 + target/riscv/vector_helper.c| 2645 +++ 4 files changed, 2

[Qemu-devel] [PATCH v2 14/17] RISC-V: add vector extension float instructions part2, sqrt/cmp/cvt/others

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 40 + target/riscv/insn32.decode | 40 + target/riscv/insn_trans/trans_rvv.inc.c | 54 + target/riscv/vector_helper.c| 2962 +++ 4 files changed, 3

[Qemu-devel] [PATCH v2 08/17] RISC-V: add vector extension integer instructions part1, add/sub/adc/sbc

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 36 + target/riscv/insn32.decode | 35 + target/riscv/insn_trans/trans_rvv.inc.c | 49 + target/riscv/vector_helper.c| 2335 +++ 4 files changed, 2

[Qemu-devel] [PATCH v2 09/17] RISC-V: add vector extension integer instructions part2, bit/shift

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 25 + target/riscv/insn32.decode | 25 + target/riscv/insn_trans/trans_rvv.inc.c | 25 + target/riscv/vector_helper.c| 1477 +++ 4 files changed, 1

[Qemu-devel] [PATCH v2 06/17] RISC-V: add vector extension fault-only-first implementation

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- linux-user/riscv/cpu_loop.c | 7 + target/riscv/cpu_helper.c | 7 + target/riscv/helper.h | 7 + target/riscv/insn32.decode | 7 + target/riscv/insn_trans/trans_rvv.inc.c | 7 + tar

[Qemu-devel] [PATCH v2 17/17] RISC-V: add vector extension premutation instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 15 + target/riscv/insn32.decode | 16 + target/riscv/insn_trans/trans_rvv.inc.c | 15 + target/riscv/vector_helper.c| 1068 +++ 4 files changed, 1

[Qemu-devel] [PATCH v2 04/17] RISC-V: add vector extension configure instruction

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/Makefile.objs | 2 +- target/riscv/helper.h | 3 + target/riscv/insn32.decode | 5 ++ target/riscv/insn_trans/trans_rvv.inc.c | 46 target/riscv/translate.c

[Qemu-devel] [PATCH v2 05/17] RISC-V: add vector extension load and store instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 37 + target/riscv/insn32.decode | 46 + target/riscv/insn_trans/trans_rvv.inc.c | 70 + target/riscv/vector_helper.c| 2638 +++ 4 files changed, 2

[Qemu-devel] [PATCH v2 03/17] RISC-V: support vector extension csr

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/cpu_bits.h | 15 target/riscv/csr.c | 65 ++--- 2 files changed, 76 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 11f97

[Qemu-devel] [PATCH v2 07/17] RISC-V: add vector extension atomic instructions

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/helper.h | 18 + target/riscv/insn32.decode | 21 + target/riscv/insn_trans/trans_rvv.inc.c | 36 + target/riscv/vector_helper.c| 1467 +++ 4 files changed, 1

[Qemu-devel] [PATCH v2 02/17] RISC-V: turn on vector extension from command line by cfg.ext_v Property

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c | 6 +- target/riscv/cpu.h | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index f8d07bd..9f93ce7 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -109,

[Qemu-devel] [PATCH v2 00/17] RISC-V: support vector extension

2019-09-10 Thread liuzhiwei
Features: * support specification riscv-v-spec-0.7.1(https://content.riscv.org/wp-content/uploads/2019/06/17.40-Vector_RISCV-20190611-Vectors.pdf). * support basic vector extension. * support Zvlsseg.

[Qemu-devel] [PATCH v2 01/17] RISC-V: add vfp field in CPURISCVState

2019-09-10 Thread liuzhiwei
From: LIU Zhiwei Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h | 28 1 file changed, 28 insertions(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 0adb307..c992b1d 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -93,9 +93,37 @@ typedef

Re: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16

Re: [Qemu-devel] [PATCH v6 23/42] blockdev: Use CAF in external_snapshot_prepare()

2019-09-10 Thread Max Reitz
On 10.09.19 17:02, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> This allows us to differentiate between filters and nodes with COW >> backing files: Filters cannot be used as overlays at all (for this >> function). >> >> Signed-off-by: Max Reitz >> Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH v6 22/42] block: Fix bdrv_get_allocated_file_size's fallback

2019-09-10 Thread Max Reitz
On 10.09.19 16:52, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> If the driver does not implement bdrv_get_allocated_file_size(), we >> should fall back to cumulating the allocated size of all non-COW >> children instead of just bs->file. >> >> Suggested-by: Vladimir Seme

Re: [Qemu-devel] [PATCH v3] target-arm: Make the counter tick relative to cntfrq

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190911034302.29108-1-and...@aj.id.au/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH v13 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-10 Thread Aravinda Prasad
On Monday 09 September 2019 08:49 PM, Greg Kurz wrote: > On Mon, 09 Sep 2019 12:54:53 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >> value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Message-id: 20190910163600.19971-1-laur...@vivier.eu Ty

Re: [Qemu-devel] [PATCH v1 3/3] hw/ppc/pnv_homer: add PowerNV homer device model

2019-09-10 Thread Balamuruhan S
On Wed, Sep 11, 2019 at 10:34:05AM +1000, David Gibson wrote: > On Tue, Sep 10, 2019 at 12:40:19PM +0530, Balamuruhan S wrote: > > add PnvHOMER device model to emulate homer memory access > > Please use PnvHomer as the identifier instead. I'm guessing that > messes with the usual capitalization o

Re: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16

[Qemu-devel] [PATCH 6/7] spapr: Stop providing RTAS blob

2019-09-10 Thread David Gibson
From: Alexey Kardashevskiy SLOF implements one itself so let's remove it from QEMU. It is one less image and simpler setup as the RTAS blob never stays in its initial place anyway as the guest OS always decides where to put it. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --

[Qemu-devel] [PATCH 2/7] spapr: Move handling of special NVLink numa node from reset to init

2019-09-10 Thread David Gibson
The number of NUMA nodes in the system is fixed from the command line. Therefore, there's no need to recalculate it at reset time, and we can determine the special gpu_numa_id value used for NVLink2 devices at init time. This simplifies the reset path a bit which will make further improvements eas

[Qemu-devel] [PATCH 7/7] spapr: Perform machine reset in a more sensible order

2019-09-10 Thread David Gibson
We've made several changes in the past to the machine reset order to fix specific problems. However, we've ended up with an order that doesn't make a lot of logical sense. This is an attempt to rectify this. First we reset global CAS options, since that should depend on nothing else. Then we re

[Qemu-devel] [PATCH 4/7] spapr: Skip leading zeroes from memory@ DT node names

2019-09-10 Thread David Gibson
From: Alexey Kardashevskiy The device tree build by QEMU at the machine reset time is used by SLOF to build its internal device tree but the node names are not preserved exactly so when QEMU provides a device tree update in response to H_CAS, it might become tricky to match a node from the update

[Qemu-devel] [PATCH 3/7] spapr: Fixes a leak in CAS

2019-09-10 Thread David Gibson
From: Alexey Kardashevskiy Add a missing g_free(fdt) if the resulting tree is bigger than the space allocated by SLOF. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index e

[Qemu-devel] [PATCH 0/7] spapr: CAS and reset cleanup preliminaries

2019-09-10 Thread David Gibson
PAPR defines a feature negotiation protocol between host and guest called ibm,client-architecture-support or CAS. When invoked by the guest this can either result in updated device tree information being given to the guest to indicate the new configuration, or it can trigger a reboot (called a CAS

[Qemu-devel] [PATCH 5/7] spapr: Do not put empty properties for -kernel/-initrd/-append

2019-09-10 Thread David Gibson
From: Alexey Kardashevskiy We are going to use spapr_build_fdt() for the boot time FDT and as an update for SLOF during handling of H_CAS. SLOF will apply all properties from the QEMU's FDT which is usually ok unless there are properties changed by grub or guest kernel. The properties are: bootar

[Qemu-devel] [PATCH 1/7] spapr: Simplify handling of pre ISA 3.0 guest workaround handling

2019-09-10 Thread David Gibson
Certain old guest versions don't understand the radix MMU introduced with POWER ISA 3.0, but incorrectly select it if presented with the option at CAS time. We workaround this in qemu by explicitly excluding the radix (and other ISA 3.0 linked) options if the guest doesn't explicitly note support

Re: [Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190911014353.5926-1-richard.hender...@linaro.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

[Qemu-devel] [PATCH v3] target-arm: Make the counter tick relative to cntfrq

2019-09-10 Thread Andrew Jeffery
Allow machines to configure CNTFRQ via a property if the ARM core supports the generic timer. This is necessary on e.g. the ASPEED AST2600 SoC where the generic timer clock is run at 800MHz or above. CNTFRQ is a read-as-written co-processor register; the property sets the register's initial value

[Qemu-devel] [PATCH v2 3/3] tests/migration:fix unreachable path in stress test

2019-09-10 Thread Mao Zhongyi
if stress function always return 0, the path 'if (stress(ramsizeGB, ncpus) < 0)' is nerver unreachable, so fix it to allow the test failed. Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.com Signed-off-by: Mao Zhongyi --- tests/migration/stress.c | 5 ++--- 1 file changed, 2 ins

[Qemu-devel] [PATCH v2 0/3] some fix in tests/migration

2019-09-10 Thread Mao Zhongyi
This patchset mainly fixes memory leak, typo and return value of stress function in stress test. v2->v1: - use g_autofree to release memory automatically instead of free(). [Alex Bennée] Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.c

[Qemu-devel] [PATCH v2 1/3] tests/migration: mem leak fix

2019-09-10 Thread Mao Zhongyi
‘data’ has the possibility of memory leaks, so use the glic macros g_autofree recommended by CODING_STYLE.rst to automatically release the memory that returned from g_malloc(). Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.com Cc: alex.ben...@linaro.org Signed-off-by: Mao Zhongyi

[Qemu-devel] [PATCH v2 2/3] tests/migration: fix a typo in comment

2019-09-10 Thread Mao Zhongyi
Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.com Signed-off-by: Mao Zhongyi Reviewed-by: Alex Bennée --- tests/migration/stress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/migration/stress.c b/tests/migration/stress.c index 6cbb2d49d3..19a6eff5f

[Qemu-devel] [PATCH 1/2] Python libs: close console sockets before shutting down the VMs

2019-09-10 Thread Cleber Rosa
Currently, the console socket on QEMUMachine is closed after the QMP command to gracefully exit QEMU is executed. Because of a possible deadlock (QEMU waiting for the socket to become writable) let's close the console socket earlier. Reference: <20190607034214.gb22...@habkost.net> Reference: http

[Qemu-devel] [PATCH 2/2] Python libs: enable machine type auto selection

2019-09-10 Thread Cleber Rosa
The arm and aarch64 targets are noteworthy because they don't have a default machine type. This introduces and opt-in option to users of the qemu.machine.QEMUMachine Python class, in which a default machine type will be set when a number of conditions are met. The motivation for this feature is t

[Qemu-devel] [PATCH 0/2] Acceptance tests: arm/aarch64 host and target enablers

2019-09-10 Thread Cleber Rosa
The acceptance tests have been running primarily on x86_64 hosts, and some tests will fail when run under non-x86 hosts or targets. This series addresses issues that enables running the acceptance tests under aarch64 hosts, and on other hosts using arm and aarch64 targets. Cleber Rosa (2): Pyth

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Message-id: 20190910163600.19971-1-laur...@vivier.eu Ty

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2019-09-10 Thread Rafael David Tinoco
In comment #14, please disregard the second half of the issue, related to: 0xaabd4100 <+16>: cbz w1, 0xaabd4108 0xaabd4104 <+20>: ret 0xaabd4108 <+24>: ldaxr w1, [x0] 0xaabd410c <+28>: orr w1, w1, #0x1 => 0xaabd4110 <+32>

[Qemu-devel] qemu_futex_wait() lockups in ARM64: 2 possible issues

2019-09-10 Thread Rafael David Tinoco
Paolo, While debugging hungs in ARM64 while doing a simple: qemu-img convert -f qcow2 -O qcow2 file.qcow2 output.qcow2 I might have found 2 issues which I'd like you to review, if possible. ISSUE #1 I've caught the following stack trace after an HUNG in qemu-img convert: (gdb) bt #0

Re: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16

Re: [Qemu-devel] [PATCH] spapr/irq: Only claim VALID interrupts at the KVM level

2019-09-10 Thread David Gibson
On Tue, Sep 10, 2019 at 08:13:26AM +0200, Cédric Le Goater wrote: > A typical pseries VM with 16 vCPUs, one disk, one network adapater > uses less than 100 interrupts but the whole IRQ number space of the > QEMU machine is allocated at reset time and it is 8K wide. This is > wasting considerably th

[Qemu-devel] [PATCH 3/3] cputlb: Introduce TLB_BSWAP

2019-09-10 Thread Richard Henderson
Handle bswap on ram directly in load/store_helper. This fixes a bug with the previous implementation in that one cannot use the I/O path for RAM. Fixes: a26fc6f5152b47f1 Signed-off-by: Richard Henderson --- include/exec/cpu-all.h | 2 + accel/tcg/cputlb.c | 118 ---

[Qemu-devel] [PATCH 1/3] cputlb: Disable __always_inline__ without optimization

2019-09-10 Thread Richard Henderson
This forced inlining can result in missing symbols, which makes a debugging build harder to follow. Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel

[Qemu-devel] [PATCH 2/3] cputlb: Replace switches in load/store_helper with callback

2019-09-10 Thread Richard Henderson
Add a function parameter to perform the actual load/store to ram. With optimization, this results in identical code. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 157 +++-- 1 file changed, 81 insertions(+), 76 deletions(-) diff --git a/accel/

[Qemu-devel] [PATCH 0/3] cputlb: Adjust tlb bswap implementation

2019-09-10 Thread Richard Henderson
The version that Tony came up with, and I reviewed, doesn't actually work when applied to RAM. It only worked for i/o memory. This was the root cause for https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg00036.html I tried a couple of different approaches in load/store_helper, but this i

Re: [Qemu-devel] [PATCH 1/3] tests/migration: mem leak fix

2019-09-10 Thread maozy
On 9/11/19 2:52 AM, Alex Bennée wrote: Mao Zhongyi writes: Cc: arm...@redhat.com Cc: laur...@vivier.eu Cc: tony.ngu...@bt.com Signed-off-by: Mao Zhongyi --- tests/migration/stress.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/migration/stress.c b/tests/migration/stress.c

Re: [Qemu-devel] [PATCH v2 0/7] block/curl: Fix hang and potential crash

2019-09-10 Thread John Snow
On 9/10/19 8:41 AM, Max Reitz wrote: > Hi, > > As reported in https://bugzilla.redhat.com/show_bug.cgi?id=1740193, our > curl block driver can spontaneously hang. This becomes visible e.g. > when reading compressed qcow2 images: > > $ qemu-img convert -p -O raw -n \ > https://download.cirro

Re: [Qemu-devel] [Qemu-block] [PATCH v2 3/7] curl: Check completion in curl_multi_do()

2019-09-10 Thread John Snow
On 9/10/19 12:11 PM, Maxim Levitsky wrote: > On Tue, 2019-09-10 at 14:41 +0200, Max Reitz wrote: >> While it is more likely that transfers complete after some file >> descriptor has data ready to read, we probably should not rely on it. >> Better be safe than sorry and call curl_multi_check_comp

Re: [Qemu-devel] [PATCH v1 3/3] hw/ppc/pnv_homer: add PowerNV homer device model

2019-09-10 Thread David Gibson
On Tue, Sep 10, 2019 at 12:40:19PM +0530, Balamuruhan S wrote: > add PnvHOMER device model to emulate homer memory access Please use PnvHomer as the identifier instead. I'm guessing that messes with the usual capitalization of HOMER, but my experience with spapr is that matching qemu capitalizati

[Qemu-devel] [PATCH 4/4] tests/acceptance/cpu_queries.py: minor optmizations

2019-09-10 Thread Cleber Rosa
This avoids the second loop over the cpus, and reuses some of the variables. Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py index 9cd6

[Qemu-devel] [PATCH 3/4] tests/acceptance/cpu_queries.py: add machine tag

2019-09-10 Thread Cleber Rosa
This is for informational / filtering purposes only, that is, allows one to run all tests with machine model "none". Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.p

[Qemu-devel] [PATCH 1/4] tests/acceptance/cpu_queries.py: cleanups

2019-09-10 Thread Cleber Rosa
Simple cleanups for debugging code that is not being used. Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py index e71edec39f..a9ac3d692e 100644 --- a/tests/accept

[Qemu-devel] [PATCH 0/4] Acceptance tests: cpu_queries.py improvements

2019-09-10 Thread Cleber Rosa
The cpu_queries.py test is currently x86_64 specific, so this sets a 'arch' tag to make sure the correct target binary is used by default. Also, a few minor cleanups and optimizations. Cleber Rosa (4): tests/acceptance/cpu_queries.py: cleanups tests/acceptance/cpu_queries.py: tag test as x86_

[Qemu-devel] [PATCH 2/4] tests/acceptance/cpu_queries.py: tag test as x86_64 specific

2019-09-10 Thread Cleber Rosa
This is an usability improvement, and prevents the test from being automatically run with some not supported targets (say on an ppc64le or aarch64 host). Actually, the x86_64 tagging is a little white lie, because in theory, at least parts of the test, such as the query-cpu-model-expansion query,

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Message-id: 20190910163600.19971-1-laur...@vivier.eu Ty

Re: [Qemu-devel] [PATCH v1 2/4] elf: move elf.h to elf/elf.h and split out types

2019-09-10 Thread David Gibson
On Tue, Sep 10, 2019 at 08:34:06PM +0100, Alex Bennée wrote: > Most of the users of elf.h just want the standard Elf definitions. The > couple that want more than that want an expansion based on ELF_CLASS > which can be used for size agnostic code. The later is moved into > elf/elf-types.inc.h to m

Re: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910193347.16000-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine Message-id: 20190910193347.16

[Qemu-devel] [PATCH 3/3] audio: paaudio: ability to specify stream name

2019-09-10 Thread Kővágó, Zoltán
This can be used to identify stream in tools like pavucontrol when one creates multiple -audiodevs or runs multiple qemu instances. Signed-off-by: Kővágó, Zoltán --- audio/paaudio.c | 4 ++-- qapi/audio.json | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/audio/paaudio

[Qemu-devel] [PATCH 1/3] audio: fix parameter dereference before NULL check

2019-09-10 Thread Kővágó, Zoltán
This should fix Coverity issues CID 1405305 and 1405301. Signed-off-by: Kővágó, Zoltán --- audio/audio_template.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 2562bf5f00..cc4b53b5d7 100644 --- a/audio/audio_templ

[Qemu-devel] [PATCH 0/3] Audio: misc fixes for "Audio 20190821 patches", part two

2019-09-10 Thread Kővágó, Zoltán
Hi, This series contains some random fixes for the "Audio 20190821 patches": a coverity bugfix and pulseaudio connection/stream names fix. Since there wasn't a clear consensus about naming the pa streams, I've split it into two commits: the first time just uses the audiodev id unconditionally, wh

[Qemu-devel] [PATCH 2/3] audio: paaudio: fix connection and stream name

2019-09-10 Thread Kővágó, Zoltán
Connection name was previously erroneously set to the server socket path, while connection names were simply "qemu". After this patch, the connection name will be the vm name (falling back to "qemu" if not specified), while stream names will be the audiodev's id. Signed-off-by: Kővágó, Zoltán --

Re: [Qemu-devel] [PATCH 0/3] some fix in tests/migration

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910120927.1669283-1-maozhon...@cmss.chinamobile.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 0/3] some fix in tests/migration Message-id: 20190910120927.1669283-1-m

[Qemu-devel] [Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2019-09-10 Thread Rafael David Tinoco
QEMU BUG: #1 Alright, one of the issues is (according to comment #14): """ Meaning that code is waiting for a futex inside kernel. (gdb) print rcu_call_ready_event $4 = {value = 4294967295, initialized = true} The QemuEvent "rcu_call_ready_event->value" is set to INT_MAX and I don't know why ye

Re: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910063724.28470-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/16] qapi: Schema language cleanups & doc improvements Message-id: 20190910063724.

Re: [Qemu-devel] [PATCH v1 4/4] elf: move ELF_ARCH definition to elf-arch.h

2019-09-10 Thread Aleksandar Markovic
10.09.2019. 21.34, "Alex Bennée" је написао/ла: > > This is preparatory for plugins which will want to report the > architecture to plugins. Move the ELF_ARCH definition out of the > loader and into its own header. > > Signed-off-by: Alex Bennée > --- ELF_ARCH is and has been used exclusively lo

Re: [Qemu-devel] [PATCH v2 2/7] curl: Keep *socket until the end of curl_sock_cb()

2019-09-10 Thread John Snow
On 9/10/19 8:41 AM, Max Reitz wrote: > This does not really change anything, but it makes the code a bit easier > to follow once we use @socket as the opaque pointer for > aio_set_fd_handler(). > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v1 4/4] elf: move ELF_ARCH definition to elf-arch.h

2019-09-10 Thread Aleksandar Markovic
10.09.2019. 21.34, "Alex Bennée" је написао/ла: > > This is preparatory for plugins which will want to report the > architecture to plugins. Move the ELF_ARCH definition out of the > loader and into its own header. > > Signed-off-by: Alex Bennée > -- Hi, Alex. I advice some caution here . For e

Re: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910163600.19971-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/15] Linux user for 4.2 patches Message-id: 20190910163600.19971-1-laur...@vivier.eu Ty

Re: [Qemu-devel] [PATCH 0/3] proper locking on bitmap add/remove paths

2019-09-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190910162724.79574-1-vsement...@virtuozzo.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

[Qemu-devel] Subject: Re: [PATCH] hw/block/nvme

2019-09-10 Thread Toe Dev
Hey, While reviewing I noticed maybe we need to update the spec revision. In: nvme_class_init(...) current code pc->revision=2 change to: pc->revision=3 However not really important I think.. Just for consistency. When I done reviewing, should it be patched too, How?

Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Cleber Rosa
On Tue, Sep 10, 2019 at 04:43:00PM -0300, Eduardo Habkost wrote: > On Tue, Sep 10, 2019 at 08:29:24AM -0400, Cleber Rosa wrote: > > On Tue, Sep 10, 2019 at 09:41:20AM +0100, Daniel P. Berrangé wrote: > > > On Tue, Sep 03, 2019 at 08:52:18PM -0400, Cleber Rosa wrote: > > > > The LinuxInitrd.test_wit

Re: [Qemu-devel] [PATCH v4 3/4] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-10 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Tuesday, September 10, 2019 6:15 PM > To: qemu-devel > Cc: Zhang, Chen ; Jason Wang > ; Wen Congyang ; > Xie Changlong ; kw...@redhat.com; > mre...@redhat.com > Subject: [PATCH v4 3/4] net/filter.c: Add Options to insert filters anywhere

Re: [Qemu-devel] [PATCH] BootLinuxConsoleTest: Test the Quadra 800

2019-09-10 Thread Philippe Mathieu-Daudé
On 9/10/19 7:07 PM, Cleber Rosa wrote: > On Tue, Sep 10, 2019 at 06:34:30PM +0200, Philippe Mathieu-Daudé wrote: >> This test boots a Linux kernel on a Quadra 800 board >> and verify the serial is working. >> >> Example: >> >> $ avocado --show=app,console run -t machine:q800 >> tests/acceptance/

Re: [Qemu-devel] [PATCH v1 1/4] target/ppc: fix signal delivery for ppc64abi32

2019-09-10 Thread Alex Bennée
Alex Bennée writes: > We were incorrectly setting NIP resulting in a segfault. This fixes > linux-test for this ABI. Oops, that was at the bottom of my tree for fixing ppc64abi32 which showed up broken when testing/next enabled the TCG tests for it. > > Signed-off-by: Alex Bennée > --- > li

Re: [Qemu-devel] [RFC PATCH 03/20] vl: Add "sgx-epc" option to expose SGX EPC sections to guest

2019-09-10 Thread Sean Christopherson
On Fri, Sep 06, 2019 at 09:49:44PM +, Larry Dewey wrote: > I was playing with the new objects, etc, and found if the user > specifies -sgx-epc, and a memory device, but does not specify -cpu > host, +sgx, the vm runs without any warnings, while obviously not doing > anything to the memory. Perh

[Qemu-devel] [PATCH v11 1/9] esp: add pseudo-DMA as used by Macintosh

2019-09-10 Thread Laurent Vivier
There is no DMA in Quadra 800, so the CPU reads/writes the data from the PDMA register (offset 0x100, ESP_PDMA in hw/m68k/q800.c) and copies them to/from the memory. There is a nice assembly loop in the kernel to do that, see linux/drivers/scsi/mac_esp.c:MAC_ESP_PDMA_LOOP(). The start of the tran

Re: [Qemu-devel] [PATCH] Fedora images: use URLs from stable "archives.fedoraproject.org"

2019-09-10 Thread Eduardo Habkost
On Tue, Sep 10, 2019 at 08:29:24AM -0400, Cleber Rosa wrote: > On Tue, Sep 10, 2019 at 09:41:20AM +0100, Daniel P. Berrangé wrote: > > On Tue, Sep 03, 2019 at 08:52:18PM -0400, Cleber Rosa wrote: > > > The LinuxInitrd.test_with_2gib_file_should_work_with_linux_v4_16 test, > > > from tests/acceptanc

[Qemu-devel] [PATCH v11 6/9] hw/m68k: add Nubus support

2019-09-10 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- MAINTAINERS | 2 + hw/Kconfig | 1 + hw/Makefile.objs| 1 + hw/m68k/Kconfig

Re: [Qemu-devel] [PATCH] spapr/irq: Only claim VALID interrupts at the KVM level

2019-09-10 Thread Greg Kurz
On Tue, 10 Sep 2019 08:13:26 +0200 Cédric Le Goater wrote: > A typical pseries VM with 16 vCPUs, one disk, one network adapater > uses less than 100 interrupts but the whole IRQ number space of the > QEMU machine is allocated at reset time and it is 8K wide. This is > wasting considerably the glo

[Qemu-devel] [PATCH v11 0/9] hw/m68k: add Apple Machintosh Quadra 800 machine

2019-09-10 Thread Laurent Vivier
I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer, with: ... -M q800 \ -serial non

[Qemu-devel] [PATCH v11 3/9] hw/m68k: add via support

2019-09-10 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- MAINTAINERS | 6 + default-configs/m68k-softmmu.mak | 1 + hw/m68k/Kconfig | 4 + hw/misc/Kconfig | 4

[Qemu-devel] [PATCH v11 8/9] hw/m68k: add a dummy SWIM floppy controller

2019-09-10 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau --- MAINTAINERS | 2 + hw/block/Kconfig| 3 + hw/block/Makefile.objs | 1 + hw/block/swim.c | 487 +++

[Qemu-devel] [PATCH v11 4/9] hw/m68k: implement ADB bus support for via

2019-09-10 Thread Laurent Vivier
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier Reviewed-by: Hervé Poussineau Reviewed-by: Thomas Huth --- hw/misc/Kconfig | 1 + hw/misc/mac_via.c | 198 +- include/hw/misc/mac_via.h | 7

  1   2   3   4   5   >