Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-09-02 Thread Christian Borntraeger
On 02.09.19 15:49, Igor Mammedov wrote: > On Fri, 30 Aug 2019 18:19:29 +0200 > Christian Borntraeger wrote: > >> On 30.08.19 11:41, Igor Mammedov wrote: >>> On Thu, 29 Aug 2019 14:41:13 +0200 >>> Christian Borntraeger wrote: >>> On 29.08.19 14:31, Igor Mammedov wrote: > On Thu,

Re: [Qemu-devel] [PATCH v8 01/13] vfio: KABI for migration interface

2019-09-02 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, August 31, 2019 12:33 AM > > On Fri, 30 Aug 2019 08:06:32 + > "Tian, Kevin" wrote: > > > > From: Tian, Kevin > > > Sent: Friday, August 30, 2019 3:26 PM > > > > > [...] > > > > How does QEMU handle the fact that IO

[Qemu-devel] [PATCH 5/6] tests/libqtest: Move global_test wrapper function into a separate header

2019-09-02 Thread Thomas Huth
We want libqtest.h to become completely independen from global_qtest (so that the wrapper functions are not used by accident anymore). As a first step, move the wrapper functions into a separate header file. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- tests/libqtest-single.h

[Qemu-devel] [PATCH 3/6] tests/libqos: Replace clock_step with qtest_clock_step in virtio code

2019-09-02 Thread Thomas Huth
Library functions should not rely on functions that require global_qtest (since they might get used in tests that deal with multiple states). Commit 1999a70a05ad603d ("Make generic virtio code independent from global_qtest") already tried to clean the libqos virtio code, but I missed to replace the

[Qemu-devel] [PATCH 4/6] tests: Remove unnecessary global_qtest references

2019-09-02 Thread Thomas Huth
We are going to remove global_qtest from the main libqtest library soon, so tests that do not urgently need global_qtest anymore should be cleaned from the unnecessary references. Signed-off-by: Thomas Huth --- tests/ahci-test.c| 1 - tests/bios-tables-test.c | 1 - tests/ivshmem-test.c

[Qemu-devel] [PATCH 6/6] tests/libqtest: Use libqtest-single.h in tests that require global_qtest

2019-09-02 Thread Thomas Huth
Tests that require global_qtest or the related wrapper functions now use the libqtest-single.h header that is dedicated for everything related to global_qtest. The core libqtest.c and libqtest.h files are now completely indepedent from global_qtest, so that the core library is now not depending on

[Qemu-devel] [PATCH 2/6] tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest

2019-09-02 Thread Thomas Huth
libqos library functions should never depend on functions (like memread(), memwrite() or clock_step()) that require global_qtest to be set, since library functions might get used in qtests that track multiple states, too. Thus let's replace the global_qtest-related functions with their independent

[Qemu-devel] [PATCH 0/6] Make the core libqtest library independe from global_qtest

2019-09-02 Thread Thomas Huth
global_qtest and the related wrapper functions often caused trouble in the past - if they are used somewhere in the libqtest or libqos library code, it's hard to write tests that properly track multiple test states (like migration tests). This patch series finally gets rid of the remaining global_

[Qemu-devel] [PATCH 1/6] tests/migration: Do not use functions anymore that rely on global_qtest

2019-09-02 Thread Thomas Huth
The migration tests deal with multiple test states, so we really should not use functions here that rely on the single global_qtest variable. Switch from qtest_start() to qtest_init() to make sure that global_qtest is not set anymore. This also revealed a regression in the migrate() function: It ha

Re: [Qemu-devel] [PATCH v8 01/13] vfio: KABI for migration interface

2019-09-02 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Saturday, August 31, 2019 12:15 AM > > On Fri, 30 Aug 2019 07:25:59 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Thursday, August 29, 2019 4:51 AM > > > > > > On Tue,

Re: [Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-02 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Tuesday, September 3, 2019 2:51 AM > To: Zhang, Chen > Cc: qemu-devel ; Jason Wang > ; Wen Congyang ; > Xie Changlong > Subject: Re: [PATCH v2 2/3] net/filter.c: Add Options to insert filters > anywhere in the filter list > > On Mon, 2

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-02 Thread Christian Schoenebeck via Qemu-devel
On Montag, 2. September 2019 17:34:32 CEST Greg Kurz wrote: > On Sun, 01 Sep 2019 21:28:45 +0200 > > Christian Schoenebeck wrote: > > On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote: > > > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) > > > > > > no-re...@patchew.org wrote: > > > > Patch

Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-02 Thread Christian Schoenebeck via Qemu-devel
On Montag, 2. September 2019 13:49:34 CEST Greg Kurz wrote: > On Sun, 01 Sep 2019 20:56:16 +0200 > > Christian Schoenebeck wrote: > > On Freitag, 30. August 2019 14:22:38 CEST Greg Kurz wrote: > > > Some more comments below. > > > > [snip] > > > > > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c >

Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation

2019-09-02 Thread Lukas Straub
On Mon, 2 Sep 2019 12:17:43 + "Zhang, Chen" wrote: > Hi Lukas, > > Please address Markus's comments change this patch's name in next version. > And I wrote some comments behind, please check it. > Firstly, Please remove all the trailing whitespace in this patch. > > > > -Original Messa

Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-02 Thread Christian Schoenebeck via Qemu-devel
On Montag, 2. September 2019 12:16:26 CEST Greg Kurz wrote: > > > > @@ -571,22 +572,109 @@ static void coroutine_fn virtfs_reset(V9fsPDU > > > > *pdu) > > > > > > > > P9_STAT_MODE_NAMED_PIPE | \ > > > > P9_STAT_MODE_SOCKET) > > >

[Qemu-devel] [PATCH v6 4/4] qemu-iotests: adding LUKS cleanup for non-UTF8 secret error

2019-09-02 Thread Daniel Henrique Barboza
This patch adds a new test file, 257, to exercise the case where qemu-img fails to complete for the LUKS format when a non-UTF8 secret is used. Signed-off-by: Daniel Henrique Barboza --- tests/qemu-iotests/259 | 67 ++ tests/qemu-iotests/259.out | 11 +

[Qemu-devel] [PATCH v6 2/4] block.c: adding bdrv_delete_file

2019-09-02 Thread Daniel Henrique Barboza
Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file can be used in a way similar of the existing bdrv_create_file to to clean up a created file. The logic is also similar to what is already done in bdrv_create_file: a qemu_coroutine is created if needed, a specialized function bdrv_del

[Qemu-devel] [PATCH v6 3/4] crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails

2019-09-02 Thread Daniel Henrique Barboza
When using a non-UTF8 secret to create a volume using qemu-img, the following error happens: $ qemu-img create -f luks --object secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o key-secret=vol_1_encrypt0 /var/tmp/pool_target/vol_1 10240K Formatting '/var/tmp/pool_target/vol_1

[Qemu-devel] [PATCH v6 1/4] block: introducing 'bdrv_co_delete_file' interface

2019-09-02 Thread Daniel Henrique Barboza
Adding to Block Drivers the capability of being able to clean up its created files can be useful in certain situations. For the LUKS driver, for instance, a failure in one of its authentication steps can leave files in the host that weren't there before. This patch adds the 'bdrv_co_delete_file' i

[Qemu-devel] [PATCH v6 0/4] delete created files when block_crypto_co_create_opts_luks fails

2019-09-02 Thread Daniel Henrique Barboza
Changes from previous version 5 [1] suggested by John Snow: - patch 2: return ENOMEDIUM with !drv, return negative error codes in bdrv_delete_file - patch 3: clarify the meaning of returning ENOENT in the comment [1] https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg01173.html Daniel Henr

Re: [Qemu-devel] Is network backend netmap worth keeping?

2019-09-02 Thread Giuseppe Lettieri
Hi all, I have been thinking of the submodule suggestion and I have also prepared a patch for it (attached). However, I am not sure about what we want to achieve with it. In particular, I am not sure that the option is useful for end users. The problem is that netmap, unlike capstone and slir

[Qemu-devel] [PATCH v2 4/5] iotests: Restrict nbd Python tests to nbd

2019-09-02 Thread Max Reitz
We have two Python unittest-style tests that test NBD. As such, they should specify supported_protocols=['nbd'] so they are skipped when the user wants to test some other protocol. Furthermore, we should restrict their choice of formats to 'raw'. The idea of a protocol/format combination is to u

[Qemu-devel] [PATCH v2 2/5] iotests: Add supported protocols to execute_test()

2019-09-02 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 84438e837c..b26271187c 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.

[Qemu-devel] [PATCH v2 5/5] iotests: Test blockdev-create for vpc

2019-09-02 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/266 | 153 + tests/qemu-iotests/266.out | 137 + tests/qemu-iotests/group | 1 + 3 files changed, 291 insertions(+) create mode 100755 tests/qemu-iotests/266 create mode 1

[Qemu-devel] [PATCH v2 3/5] iotests: Restrict file Python tests to file

2019-09-02 Thread Max Reitz
Most of our Python unittest-style tests only support the file protocol. You can run them with any other protocol, but the test will simply ignore your choice and use file anyway. We should let them signal that they require the file protocol so they are skipped when you want to test some other prot

[Qemu-devel] [PATCH v2 0/5] vpc: Return 0 from vpc_co_create() on success

2019-09-02 Thread Max Reitz
(v2 for “block: Let blockdev-create return 0 on success”) Jobs are expected to return 0 on success, so this extends to .bdrv_co_create(). After some inspection, it turns out that vpc is the only block driver that may return a positive value instead (to indicate success). Fix that. Without this

[Qemu-devel] [PATCH v2 1/5] vpc: Return 0 from vpc_co_create() on success

2019-09-02 Thread Max Reitz
blockdev_create_run() directly uses .bdrv_co_create()'s return value as the job's return value. Jobs must return 0 on success, not just any nonnegative value. Therefore, using blockdev-create for VPC images may currently fail as the vpc driver may return a positive integer. Because there is no p

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-02 Thread Laszlo Ersek
On 09/02/19 10:45, Igor Mammedov wrote: > On Fri, 30 Aug 2019 20:46:14 +0200 > Laszlo Ersek wrote: > >> On 08/30/19 16:48, Igor Mammedov wrote: >> >>> (01) On boot firmware maps and initializes SMI handler at default SMBASE >>> (3) >>> (using dedicated SMRAM at 3 would allow us to a

Re: [Qemu-devel] [PATCH 1/1] linux-user: Handle /proc/self/exe in syscall execve

2019-09-02 Thread Laurent Vivier
Le 02/09/2019 à 19:36, Olivier Dion a écrit : > > On 2019-08-23T12:58:43-0400, Laurent Vivier wrote: > >> Le 07/08/2019 à 15:54, d...@linutronix.de a écrit : >>> From: Olivier Dion >>> >>> If not handled, QEMU will execve itself instead of the emulated >>> process. This could result in potenti

Re: [Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-02 Thread Lukas Straub
On Mon, 2 Sep 2019 11:43:57 + "Zhang, Chen" wrote: > > -Original Message- > > From: Lukas Straub > > Sent: Friday, August 23, 2019 2:21 PM > > To: Zhang, Chen > > Cc: qemu-devel ; Jason Wang > > ; Wen Congyang ; > > Xie Changlong > > Subject: Re: [PATCH v2 2/3] net/filter.c: Add Op

Re: [Qemu-devel] [PATCH v5 3/4] crypto.c: cleanup created file when block_crypto_co_create_opts_luks fails

2019-09-02 Thread Daniel Henrique Barboza
On 8/28/19 11:10 PM, John Snow wrote: On 8/7/19 10:21 AM, Daniel Henrique Barboza wrote: When using a non-UTF8 secret to create a volume using qemu-img, the following error happens: $ qemu-img create -f luks --object secret,id=vol_1_encrypt0,file=vol_resize_pool.vol_1.secret.qzVQrI -o key

Re: [Qemu-devel] [PATCH v5 2/4] block.c: adding bdrv_delete_file

2019-09-02 Thread Daniel Henrique Barboza
On 8/28/19 11:07 PM, John Snow wrote: On 8/7/19 10:21 AM, Daniel Henrique Barboza wrote: Using the new 'bdrv_co_delete_file' interface, bdrv_delete_file can be used in a way similar of the existing bdrv_create_file to to clean up a created file. The logic is also similar to what is already

Re: [Qemu-devel] [PATCH 1/1] linux-user: Handle /proc/self/exe in syscall execve

2019-09-02 Thread Olivier Dion
On 2019-08-23T12:58:43-0400, Laurent Vivier wrote: > Le 07/08/2019 à 15:54, d...@linutronix.de a écrit : > > From: Olivier Dion > > > > If not handled, QEMU will execve itself instead of the emulated > > process. This could result in potential security risk. > > > Could you explain what you

Re: [Qemu-devel] [PATCH] migration: Do not re-read the clock on pre_save in case of paused guest

2019-09-02 Thread Marcelo Tosatti
Looks good. Reviewed-by: Marcelo Tosatti On Thu, Aug 29, 2019 at 06:18:42PM -0300, Eduardo Habkost wrote: > CCing Marcelo, who wrote kvm_update_clock() and > kvmclock_pre_save(). > > On Thu, Aug 29, 2019 at 06:07:11PM -0300, Maxiwell S. Garcia wrote: > > The clock move makes the guest knows abo

Re: [Qemu-devel] [PATCH v9 13/13] block/backup: use backup-top instead of write notifiers

2019-09-02 Thread Max Reitz
On 29.08.19 16:55, Vladimir Sementsov-Ogievskiy wrote: > 28.08.2019 22:50, Max Reitz wrote: >> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >>> Drop write notifiers and use filter node instead. >>> >>> = Changes = >>> >>> 1. add filter-node-name argument for backup qmp api. We have to do

[Qemu-devel] [PATCH] hw/misc: Mark most objects as "common" code to speed up compilation a litte bit

2019-09-02 Thread Thomas Huth
Most of the code in hw/misc/ does not directly depend on CPU-specific code. Mark it as "common" so that the code can be shared between e.g. qemu-system-arm and qemu-system-aarch64, or between the various mips flavours, instead of recompiling it for each and every target again and again. Signed-off

Re: [Qemu-devel] [PATCH v9 07/13] iotests: prepare 124 and 257 bitmap querying for backup-top filter

2019-09-02 Thread Max Reitz
On 29.08.19 15:22, Vladimir Sementsov-Ogievskiy wrote: > 28.08.2019 19:40, Max Reitz wrote: >> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: [...] >>> + >>> +def get_bitmap(self, bitmaps, node_name, name, recording=None): >>> +""" >>> +get a specific bitmap from the o

Re: [Qemu-devel] [PATCH v9 03/13] block/backup: introduce BlockCopyState

2019-09-02 Thread Max Reitz
On 29.08.19 12:52, Vladimir Sementsov-Ogievskiy wrote: > Thanks for reviewing! > > 28.08.2019 18:59, Max Reitz wrote: >> On 26.08.19 18:13, Vladimir Sementsov-Ogievskiy wrote: >>> Split copying code part from backup to "block-copy", including separate >>> state structure and function renaming. Thi

Re: [Qemu-devel] Uncaught target signal 11 (Segmentation Faullt)

2019-09-02 Thread Aleksandar Markovic
02.09.2019. 06.17, "Libo Zhou" је написао/ла: > > I am trying to run a simple MIPS program with QEMU user mode. > > > > Host: Ubuntu 18.04 LTS on x86_64 > QEMU config: ../configure --target-list=mips-linux-user > > Cross Compiler: sudo apt install gcc-mips-linux-gnu > > > My test.c is simple: int

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-02 Thread Greg Kurz
On Sun, 01 Sep 2019 21:28:45 +0200 Christian Schoenebeck wrote: > On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote: > > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) > > > > no-re...@patchew.org wrote: > > > Patchew URL: > > > https://patchew.org/QEMU/cover.1566503584.git.qemu_...@crudeby

[Qemu-devel] [PATCH V2] block/vhdx: add check for truncated image files

2019-09-02 Thread Peter Lieven
qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable at open and report all errors during bdrv_co_check. Signed-off-by: Peter Lieven --- V2: - add error reporting [Kevin] - use bdrv_getlength instead of bdrv_get_allocated_fil

Re: [Qemu-devel] [PATCH v6 39/42] iotests: Add filter commit test cases

2019-09-02 Thread Max Reitz
On 31.08.19 14:35, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:14, Max Reitz wrote: >> This patch adds some tests on how commit copes with filter nodes. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/040 | 177 + >> tests/qemu-iotests

Re: [Qemu-devel] [PATCH v6 39/42] iotests: Add filter commit test cases

2019-09-02 Thread Max Reitz
On 31.08.19 13:41, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:14, Max Reitz wrote: >> This patch adds some tests on how commit copes with filter nodes. >> >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/040 | 177 + >> tests/qemu-iotests

Re: [Qemu-devel] [PATCH v23 00/22] Add RX archtecture support

2019-09-02 Thread Philippe Mathieu-Daudé
Hi Igor, kindly ping :) On 8/21/19 12:28 PM, Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 8/17/19 9:36 AM, Yoshinori Sato wrote: >> Hello. >> This patch series is added Renesas RX target emulation. >> >> Changes for v22. >> Added some include. >> >> Changes for v21. >> rebase latest master. >>

Re: [Qemu-devel] [PATCH v6 27/42] commit: Deal with filters

2019-09-02 Thread Max Reitz
On 31.08.19 12:44, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> This includes some permission limiting (for example, we only need to >> take the RESIZE permission if the base is smaller than the top). >> >> Signed-off-by: Max Reitz >> --- >> block/block-backend.c |

Re: [Qemu-devel] [PATCH v2 1/3] tests/tcg: use EXTRA_CFLAGS everywhere

2019-09-02 Thread Alex Bennée
Paolo Bonzini writes: > For i386 specifically, this allows using the host GCC > to compile the i386 tests. But, it should really be > done for all targets, unless we want to pass $(EXTRA_CFLAGS) > directly as part of $(CC). > > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée > --- >

Re: [Qemu-devel] [PATCH] x86: do not advertise die-id in query-hotpluggbale-cpus if '-smp dies' is not set

2019-09-02 Thread Eduardo Habkost
On Mon, Sep 02, 2019 at 08:02:22AM -0400, Igor Mammedov wrote: > Commit 176d2cda0 (i386/cpu: Consolidate die-id validity in smp context) added > new 'die-id' topology property to CPUs and exposed it via QMP command > query-hotpluggable-cpus, which broke -device/device_add cpu-foo for existing > use

Re: [Qemu-devel] [PATCH v6 25/42] mirror: Deal with filters

2019-09-02 Thread Max Reitz
On 31.08.19 11:57, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> This includes some permission limiting (for example, we only need to >> take the RESIZE permission for active commits where the base is smaller >> than the top). >> >> Signed-off-by: Max Reitz >> --- >>

Re: [Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-09-02 Thread Kevin Wolf
Am 02.09.2019 um 16:17 hat Peter Lieven geschrieben: > Am 02.09.19 um 15:46 schrieb Kevin Wolf: > > Am 02.09.2019 um 15:15 hat Peter Lieven geschrieben: > > > Am 02.09.19 um 15:07 schrieb Kevin Wolf: > > > > Am 29.08.2019 um 15:36 hat Peter Lieven geschrieben: > > > > > qemu is currently not able t

Re: [Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-09-02 Thread Peter Lieven
Am 02.09.19 um 15:46 schrieb Kevin Wolf: Am 02.09.2019 um 15:15 hat Peter Lieven geschrieben: Am 02.09.19 um 15:07 schrieb Kevin Wolf: Am 29.08.2019 um 15:36 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks

[Qemu-devel] [PATCH v30 4/8] target/avr: Add instruction translation

2019-09-02 Thread Michael Rolnik
This includes: - TCG translations for each instruction Signed-off-by: Michael Rolnik --- target/avr/translate.c | 2888 1 file changed, 2888 insertions(+) create mode 100644 target/avr/translate.c diff --git a/target/avr/translate.c b/target/avr/transla

Re: [Qemu-devel] [PATCH] pr-manager: Fix invalid g_free() crash bug

2019-09-02 Thread Kevin Wolf
Am 22.08.2019 um 15:38 hat Markus Armbruster geschrieben: > pr_manager_worker() passes its @opaque argument to g_free(). Wrong; > it points to pr_manager_worker()'s automatic @data. Broken when > commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix > by deleting the g_free(). >

[Qemu-devel] [PATCH v30 5/8] target/avr: Add limited support for USART and 16 bit timer peripherals

2019-09-02 Thread Michael Rolnik
From: Sarah Harris These were designed to facilitate testing but should provide enough function to be useful in other contexts. Only a subset of the functions of each peripheral is implemented, mainly due to the lack of a standard way to handle electrical connections (like GPIO pins). Signed-o

[Qemu-devel] [PATCH v30 1/8] target/avr: Add outward facing interfaces and core CPU logic

2019-09-02 Thread Michael Rolnik
This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Signed-off-by: Michael Rolnik Acked-by: Igor Mammedov --- gdb-xml/avr-cpu.xml| 49 target/avr/cpu-param.h | 37 +++ target/avr/cpu-qom.h | 54 target/avr/cpu.c |

[Qemu-devel] [PATCH v30 8/8] target/avr: Add tests

2019-09-02 Thread Michael Rolnik
1. Avocado test The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working 2. Boot serial test Prinit out 'T' through seri

[Qemu-devel] [PATCH v30 7/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

2019-09-02 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 6 +++ arch_init.c | 2 + configure | 93 ++--- default-configs/avr-softmmu.mak | 5 ++ include/disas/dis-asm.h | 6 +++ include/sysemu/arch_init.h

[Qemu-devel] [PATCH v30 6/8] target/avr: Add example board configuration

2019-09-02 Thread Michael Rolnik
A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is not a real board NOTE: it's used for CPU testing Signed-off-by: Michael Rol

[Qemu-devel] [PATCH v30 0/8] QEMU AVR 8 bit cores

2019-09-02 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v30 2/8] target/avr: Add instruction helpers

2019-09-02 Thread Michael Rolnik
Stubs for unimplemented instructions and helpers for instructions that need to interact with QEMU. SPM and WDR are unimplemented because they require emulation of complex peripherals. The implementation of SLEEP is very limited due to the lack of peripherals to generate wake interrupts. Memory a

[Qemu-devel] [PATCH v30 3/8] target/avr: Add instruction decoding

2019-09-02 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik --- target/avr/insn.decode | 175 + 1 file changed, 175 insertions(+) create mode 100644 target/avr/insn.decode diff --git a/target/a

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: do not allow memory-less/cpu-less NUMA node

2019-09-02 Thread Greg Kurz
On Mon, 2 Sep 2019 16:27:18 +1000 David Gibson wrote: > On Fri, Aug 30, 2019 at 07:45:43PM +0200, Greg Kurz wrote: > > On Fri, 30 Aug 2019 17:34:13 +0100 > > Daniel P. Berrangé wrote: > > > > > On Fri, Aug 30, 2019 at 06:13:45PM +0200, Laurent Vivier wrote: > > > > When we hotplug a CPU on memo

Re: [Qemu-devel] [qemu-s390x] [PATCH for-4.2 v5 1/2] kvm: s390: split too big memory section on several memslots

2019-09-02 Thread Igor Mammedov
On Fri, 30 Aug 2019 18:19:29 +0200 Christian Borntraeger wrote: > On 30.08.19 11:41, Igor Mammedov wrote: > > On Thu, 29 Aug 2019 14:41:13 +0200 > > Christian Borntraeger wrote: > > > >> On 29.08.19 14:31, Igor Mammedov wrote: > >>> On Thu, 29 Aug 2019 14:07:44 +0200 > >>> Christian Borntra

Re: [Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-09-02 Thread Kevin Wolf
Am 02.09.2019 um 15:15 hat Peter Lieven geschrieben: > Am 02.09.19 um 15:07 schrieb Kevin Wolf: > > Am 29.08.2019 um 15:36 hat Peter Lieven geschrieben: > > > qemu is currently not able to detect truncated vhdx image files. > > > Add a basic check if all allocated blocks are reachable to vhdx_co_ch

Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-09-02 Thread Cornelia Huck
On Thu, 29 Aug 2019 18:50:27 +0200 Sergio Lopez wrote: > Implement the modern (v2) personality, according to the VirtIO 1.0 > specification. > > Support for v2 among guests is not as widespread as it'd be > desirable. While the Linux driver has had it for a while, support is > missing, at least,

Re: [Qemu-devel] [PATCH 0/2] block: Let blockdev-create return 0 on success

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 20:47 hat Max Reitz geschrieben: > Jobs are expected to return 0 on success. .bdrv_co_create() on the > other hand is a block layer function, and as such returns a > non-negative value on success. I don't agree that >= 0 is the block layer way. The block layer uses 0/-errno for t

Re: [Qemu-devel] [PATCH 0/2] block/file-posix: Reduce xfsctl() use

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 15:03 hat Max Reitz geschrieben: > Hi, > > As suggested by Paolo, this series drops xfsctl() calls where we have > working fallocate() alternatives. (And thus replaces “block/file-posix: > Fix xfs_write_zeroes()”.) > > Unfortunately, we also use xfsctl() to inquire the request a

Re: [Qemu-devel] git.qemu.org gitweb misrenders on git/ URLs

2019-09-02 Thread Jeff Cody
On Mon, Sep 2, 2019 at 5:25 AM Stefan Hajnoczi wrote: > > On Thu, Aug 29, 2019 at 06:13:34PM +0200, Andrea Bolognani wrote: > > On Thu, 2019-08-29 at 16:48 +0100, Stefan Hajnoczi wrote: > > > Hi Jeff, > > > Philippe noticed that the git HTTPS clone URL > > > https://git.qemu.org/git/libslirp.git r

Re: [Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-09-02 Thread Peter Lieven
Am 02.09.19 um 15:07 schrieb Kevin Wolf: Am 29.08.2019 um 15:36 hat Peter Lieven geschrieben: qemu is currently not able to detect truncated vhdx image files. Add a basic check if all allocated blocks are reachable to vhdx_co_check. Signed-off-by: Jan-Hendrik Frintrop Signed-off-by: Peter Liev

Re: [Qemu-devel] [PATCH] block/vhdx: add check for truncated image files

2019-09-02 Thread Kevin Wolf
Am 29.08.2019 um 15:36 hat Peter Lieven geschrieben: > qemu is currently not able to detect truncated vhdx image files. > Add a basic check if all allocated blocks are reachable to vhdx_co_check. > > Signed-off-by: Jan-Hendrik Frintrop > Signed-off-by: Peter Lieven > --- > block/vhdx.c | 19 +++

Re: [Qemu-devel] [PATCH v3] job: drop job_drain

2019-09-02 Thread Kevin Wolf
Am 29.08.2019 um 11:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > In job_finish_sync job_enter should be enough for a job to make some > progress and draining is a wrong tool for it. So use job_enter directly > here and drop job_drain with all related staff not used more. > > Suggested-by: Ke

Re: [Qemu-devel] [PATCH v2 3/3] Update Documentation

2019-09-02 Thread Zhang, Chen
Hi Lukas, Please address Markus's comments change this patch's name in next version. And I wrote some comments behind, please check it. Firstly, Please remove all the trailing whitespace in this patch. > -Original Message- > From: Lukas Straub > Sent: Friday, August 16, 2019 2:49 AM > T

Re: [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 23.08.2019 um 11:22 hat Vladimir Sementsov-Ogievskiy geschrieben: > 14.08.2019 13:07, Vladimir Sementsov-Ogievskiy wrote: > > To get rid of implicit filters related workarounds in future let's > > deprecate them now. > > Interesting, could we deprecate implicit filter without deprecation of > u

[Qemu-devel] [RFC] vhost-user simulation extension

2019-09-02 Thread Johannes Berg
Hi all, First of all, I'm not sure if QEMU actually maintains the master copy of this document and it isn't like virtio? It *looks* like it does, given that the updates are "do something" rather than "sync to some version", but please let me know if I need to send this elsewhere. Secondly, I'm no

[Qemu-devel] [RFC] docs: vhost-user: add in-band kick/call messages

2019-09-02 Thread Johannes Berg
From: Johannes Berg For good reason, vhost-user is currently built asynchronously, that way better performance can be obtained. However, for certain use cases such as simulation, this is problematic. Consider an event-based simulation in which both the device and CPU have are scheduled according

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qapi: deprecate implicit filters

2019-09-02 Thread Kevin Wolf
Am 30.08.2019 um 20:11 hat John Snow geschrieben: > > > On 8/30/19 6:07 AM, Christophe de Dinechin wrote: > > Without having looked at the code much, I think I would > > > > 1. extend the existing QAPI error to support warnings, deprecations and > >info messages. The first problem I see is t

[Qemu-devel] [PATCH] x86: do not advertise die-id in query-hotpluggbale-cpus if '-smp dies' is not set

2019-09-02 Thread Igor Mammedov
Commit 176d2cda0 (i386/cpu: Consolidate die-id validity in smp context) added new 'die-id' topology property to CPUs and exposed it via QMP command query-hotpluggable-cpus, which broke -device/device_add cpu-foo for existing users that do not support die-id/dies yet. That's would be fine if it happ

Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-02 Thread Greg Kurz
On Sun, 01 Sep 2019 20:56:16 +0200 Christian Schoenebeck wrote: > On Freitag, 30. August 2019 14:22:38 CEST Greg Kurz wrote: > > Some more comments below. > [snip] > > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > > > index 8cc65c2c67..c96ea51116 100644 > > > --- a/hw/9pfs/9p.c > > > +++ b/hw/9pfs

Re: [Qemu-devel] [PATCH v2 2/3] net/filter.c: Add Options to insert filters anywhere in the filter list

2019-09-02 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Friday, August 23, 2019 2:21 PM > To: Zhang, Chen > Cc: qemu-devel ; Jason Wang > ; Wen Congyang ; > Xie Changlong > Subject: Re: [PATCH v2 2/3] net/filter.c: Add Options to insert filters > anywhere in the filter list > > On Fri, 23 A

Re: [Qemu-devel] Uncaught target signal 11 (Segmentation Faullt)

2019-09-02 Thread Libo Zhou
Adding some useful information, enabling strace gives me the following messages. It looks like the segmentation fault is ultimately caused by missing ld.so.nohwcap and ld.so.preload? $ ./qemu-mips -L /usr/mips-linux-gnu -strace test 10255 brk(NULL) = 0x00412000 10255 mmap2(NULL,8192,PROT_READ|

Re: [Qemu-devel] [PATCH] ppc/pnv: fix "bmc" node name in DT

2019-09-02 Thread David Gibson
On Mon, Sep 02, 2019 at 11:29:32AM +0200, Cédric Le Goater wrote: > Fixes the dtc output : > > ERROR (node_name_chars): //bmc: Bad character '/' in node name > Warning (avoid_unnecessary_addr_size): /bmc: unnecessary > #address-cells/#size-cells without "ranges" or child "reg" property > > Signe

[Qemu-devel] [PULL 11/12] tests: fix modules-test with no default machine

2019-09-02 Thread Alex Bennée
From: Marc-André Lureau Fixes: eb062cfa733 ("tests: add module loading test") Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20190827140241.20818-2-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée diff --git a/tests/modules-test.c b/tests/modules-test.c index a8

[Qemu-devel] [PULL 12/12] tests/docker: upgrade docker.py to python3

2019-09-02 Thread Alex Bennée
The recent podman changes (9459f754134bb) imported enum which is part of the python3 standard library but only available as an external library for python2. This causes problems on the fairly restricted environment such as shippable. Lets bite the bullet and make the script a fully python3 one. To

[Qemu-devel] [PULL 10/12] build-sys: build ui-spice-app as a module

2019-09-02 Thread Alex Bennée
From: Marc-André Lureau This reverts commit 45db1ac157 ("modules-test: ui-spice-app is not built as module") and fixes commit d8aec9d9f1 ("display: add -display spice-app launching a Spice client"). Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20190827140241.20818-1-m

[Qemu-devel] [PULL 04/12] contrib/gitdm: Add arm...@pond.sub.org to group-map-redhat

2019-09-02 Thread Alex Bennée
From: Markus Armbruster Just to get the (few) accidental uses of my private e-mail address attributed correctly. Signed-off-by: Markus Armbruster Message-Id: <20190822122350.29852-3-arm...@redhat.com> Signed-off-by: Alex Bennée diff --git a/contrib/gitdm/group-map-redhat b/contrib/gitdm/group

[Qemu-devel] [PULL 05/12] mailmap: Reorder by sections

2019-09-02 Thread Alex Bennée
From: Philippe Mathieu-Daudé Our mailmap currently has 4 sections somehow documented. Reorder few entries not related to "addresses from the original git import" into the 3rd section, and add a comment to describe it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Messa

[Qemu-devel] [PULL 03/12] contrib/gitdm: filetype interface is not in order, fix

2019-09-02 Thread Alex Bennée
From: Markus Armbruster gitm prints the rather cryptic message "interface not found, appended to the last order". This is because filetypes.txt has filetype interface, but neglects to mention it in order. Fix that. Fixes: 2f28271d807edfcdc47a280c06999dd866dcae10 Signed-off-by: Markus Armbruste

[Qemu-devel] [PULL 06/12] mailmap: Update philmd email address

2019-09-02 Thread Alex Bennée
From: Philippe Mathieu-Daudé Use the email address where I spend most of my time. Suggested-by: Daniel P. Berrangé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <20190822230916.576-3-phi...@redhat.com> Signed-off-by: Alex Bennée diff --git a/.mailmap b/.

[Qemu-devel] [PULL 08/12] .mailmap/aliases: add some further commentary

2019-09-02 Thread Alex Bennée
The two files are not interchangeable but a change to one *might* require a change to the other so lets flag that up with an explanation of what both files are trying to achieve. While we are at it document the many forms .mailmap can take in the header. Signed-off-by: Alex Bennée Reviewed-by: Al

[Qemu-devel] [PULL 09/12] contrib/gitdm: Add RT-RK to the domain-map

2019-09-02 Thread Alex Bennée
From: Philippe Mathieu-Daudé This company has at least 7 contributors, add a domain-map entry. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20190822231231.1306-1-phi...@redhat.com> Reviewed-by: Aleksandar Markovic Signed-off-by: Alex Bennée diff --git a/contrib/gitdm/domain-map b/contr

[Qemu-devel] [PULL 00/12] fixes for gdbstub, gitdm and testing

2019-09-02 Thread Alex Bennée
The following changes since commit 23919ddfd56135cad3cb468a8f54d5a595f024f4: Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190827' into staging (2019-08-27 15:52:36 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-gdbstub-gitdm-tes

[Qemu-devel] [PULL 02/12] gdbstub: Fix handler for 'F' packet

2019-09-02 Thread Alex Bennée
From: Sandra Loosemore Handling of the 'F' packet has been broken since commit 4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use the new packet parsing infrastructure. Per the GDB RSP specification https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html the

[Qemu-devel] [PULL 07/12] mailmap: Add many entries to improve 'git shortlog' statistics

2019-09-02 Thread Alex Bennée
From: Philippe Mathieu-Daudé All of these emails have a least 1 commit with utf8/latin1 encoding issue, or one with no author name. When there are multiple commits, keep the author name the most used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Aleksandar Markovic Message-Id: <201908222

[Qemu-devel] [PULL 01/12] gdbstub: Fix handling of '!' packet with new infra

2019-09-02 Thread Alex Bennée
From: Ramiro Polla Since the '!' packet is not handled by the new infrastructure, gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser value, which would lead to an unsupported packet ("$#00") being sent, which could confuse the gdb client. This also has a side-effect of speedi

Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn'

2019-09-02 Thread Greg Kurz
On Sun, 01 Sep 2019 20:40:34 +0200 Christian Schoenebeck wrote: > On Donnerstag, 29. August 2019 18:55:28 CEST Greg Kurz wrote: > > > diff --git a/fsdev/qemu-fsdev-opts.c b/fsdev/qemu-fsdev-opts.c > > > index 7c31af..07a18c6e48 100644 > > > --- a/fsdev/qemu-fsdev-opts.c > > > +++ b/fsdev/qemu

Re: [Qemu-devel] [PATCH v2 1/2] accel/tcg: adding integration with linux perf

2019-09-02 Thread Stefan Hajnoczi
On Fri, Aug 30, 2019 at 09:19:02AM -0300, vandersonmr wrote: > This commit adds support to Linux Perf in order > to be able to analyze qemu jitted code and > also to able to see the TBs PC in it. > > When using "-perf" qemu creates a jitdump file in > the current working directory. The file format

Re: [Qemu-devel] [PATCH 2/2] tests: fix modules-test with no default machine

2019-09-02 Thread Alex Bennée
Peter Maydell writes: > On Tue, 27 Aug 2019 at 15:46, Thomas Huth wrote: >> >> On 27/08/2019 16.02, Marc-André Lureau wrote: >> > Fixes: eb062cfa733 ("tests: add module loading test") >> > Signed-off-by: Marc-André Lureau >> > --- >> > tests/modules-test.c | 4 +++- >> > 1 file changed, 3 in

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

2019-09-02 Thread liuzhiwei
On 2019/8/29 上午2:54, Richard Henderson wrote: On 8/27/19 7:36 PM, liuzhiwei wrote: Change-Id: I3cf891bc400713b95f47ecca82b1bf773f3dcb25 Signed-off-by: liuzhiwei --- fpu/softfloat.c | 119 + include/fpu/softfloat.h | 4 + linux-user/riscv/cpu_l

Re: [Qemu-devel] [PATCH v2 0/2] Integrating qemu to Linux Perf

2019-09-02 Thread Stefan Hajnoczi
On Fri, Aug 30, 2019 at 09:19:01AM -0300, vandersonmr wrote: > This patch is part of Google Summer of Code (GSoC) 2019. > More about the project can be found in: > https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality > > This adds --perf command-line option to dump Linux Perf > jitdump fi

Re: [Qemu-devel] [Bug 1842038] [NEW] qemu 4.0/4.1 segfault on live migrate with virtio-scsi iothread

2019-09-02 Thread Stefan Hajnoczi
On Fri, Aug 30, 2019 at 08:44:35AM -, Dmitriy wrote: > Public bug reported: Thanks for reporting this. There have been fixes for virtio-scsi with iothreads lately, but QEMU 4.1.0 is fairly recent so it should have most of them. Can you try qemu.git/master? > > [root@kvm-nvme5 qemu]# uname

Re: [Qemu-devel] [PATCH v2] virtio-mmio: implement modern (v2) personality (virtio-1)

2019-09-02 Thread Stefan Hajnoczi
On Thu, Aug 29, 2019 at 06:50:27PM +0200, Sergio Lopez wrote: > case VIRTIO_MMIO_QUEUE_PFN: > +if (!proxy->legacy) { > +qemu_log_mask(LOG_GUEST_ERROR, > +"%s: read from legacy register (0x%lx) in non-legacy mode\n", > +__func__, offset); Ple

  1   2   >