[Qemu-devel] [GIT PULL for qemu-pseries] spapr: Render full FDT on ibm, client-architecture-support

2019-08-26 Thread Alexey Kardashevskiy
The following changes since commit d6bb8b27204eaa58f1da948b65454e3a598ab2a4: pseries: Update SLOF firmware image (2019-08-27 16:47:04 +1000) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20190827 for you to fetch changes up to da9960a5aaa25d27c9798c3d94

[Qemu-devel] [Bug 1839428] Re: qemu core dumped when repeat "system_reset" multiple times during guest boot

2019-08-26 Thread Xujun Ma
I found the commit that introduced this regression. commit 57830a499f7c815bb0cb325c94a3d8c910d13cfa (HEAD) Author: Denis Plotnikov Date: Fri Feb 15 16:03:25 2019 +0300 block: don't set the same context Adds a fast path on aio context setting preventing unnecessary context setting

Re: [Qemu-devel] [PATCH 13/25] audio: remove hw->samples, buffer_size_in/out pcm_ops

2019-08-26 Thread Gerd Hoffmann
On Sun, Aug 25, 2019 at 08:46:15PM +0200, Kővágó, Zoltán wrote: > This patch removes the samples member from HWVoiceIn and HWVoiceOut. > Backends can specify buffer size via the newly added buffer_size_in and > buffer_size_out functions in audio_pcm_ops. They are optional, if not > defined qemu wi

Re: [Qemu-devel] [PATCH 01/25] audio: api for mixeng code free backends

2019-08-26 Thread Gerd Hoffmann
More verbose commit message would be nice here. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

2019-08-26 Thread Gerd Hoffmann
On Mon, Aug 26, 2019 at 09:59:04PM +0200, Kővágó, Zoltán wrote: > This can be used to identify stream in tools like pavucontrol when one > creates multiple -audiodevs or runs multiple qemu instances. Hmm, can we create an useful name automatically, without yet another config option? Useful choice

Re: [Qemu-devel] [PATCH v2 3/4] audio: paaudio: fix client name

2019-08-26 Thread Gerd Hoffmann
On Mon, Aug 26, 2019 at 09:59:03PM +0200, Kővágó, Zoltán wrote: > pa_context_new expects a client name, not a server socket path. > > Signed-off-by: Kővágó, Zoltán > Reviewed-by: Maxim Levitsky > --- > audio/paaudio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/aud

Re: [Qemu-devel] [PATCH 06/13] target/openrisc: Add VR2 and AVR special processor registers

2019-08-26 Thread Richard Henderson
On 8/26/19 9:36 PM, Stafford Horne wrote: >> /* Fields from here on are preserved across CPU reset. */ >> uint32_t vr; /* Version register */ >> +uint32_t vr2; /* Version register 2 */ >> +uint32_t avr; /* Architecture version register */ > >

[Qemu-devel] [QEMU-PPC] [PATCH V4] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter

2019-08-26 Thread Suraj Jitindar Singh
The ibm,get_system_parameter rtas call is used by the guest to retrieve data relating to certain parameters of the system. The SPLPAR characteristics option (token 20) is used to determine characteristics of the environment in which the lpar will run. It may be useful for a guest to know the numbe

Re: [Qemu-devel] [PATCH 00/13] target/openrisc updates

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:32PM -0700, Richard Henderson wrote: > The first three fix an MTTCG race on cpu_R[0], now that > we do code generation in parallel. > > Then some updates to the SPRs, cpuid checks for existing > float insns, adding the new v1.3 instructions. > > I've run this through

Re: [Qemu-devel] [PATCH 12/13] target/openrisc: Implement l.adrp

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:44PM -0700, Richard Henderson wrote: > This was added to the 1.3 spec. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 13/13] target/openrisc: Update cpu "any" to v1.3

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:45PM -0700, Richard Henderson wrote: > Now that the two updates from v3.1 are implemented, > update the "any" cpu to enable it. It should say 1.3 not 3.1 above. > Signed-off-by: Richard Henderson Other than that. Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 11/13] target/openrisc: Implement move to/from FPCSR

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:43PM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 10/13] target/openrisc: Implement unordered fp comparisons

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:42PM -0700, Richard Henderson wrote: > These were added to the 1.3 spec. For OF32S, validate AVR. > But OF64A32 is itself new to 1.3 so no extra check needed. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 09/13] target/openrisc: Add support for ORFPX64A32

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:41PM -0700, Richard Henderson wrote: > This is hardware support for double-precision floating-point > using pairs of 32-bit registers. Fix a latent bug in the > heretofore unused helper_itofd. Include the bit for cpu "any". > > Signed-off-by: Richard Henderson Rev

Re: [Qemu-devel] [PATCH 07/13] target/openrisc: Fix lf.ftoi.s

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:39PM -0700, Richard Henderson wrote: > The specification of this insn is round-to-zero. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne > --- > target/openrisc/fpu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [Qemu-devel] [PATCH 08/13] target/openrisc: Check CPUCFG_OF32S for float insns

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:40PM -0700, Richard Henderson wrote: > Make sure the OF32S insns are enabled before allowing execution. > Include the missing bit for cpu "any". > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

[Qemu-devel] [Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2019-08-26 Thread Richard Henderson
The float test failure is part of a larger problem for target/powerpc in which all float routines are implemented incorrectly. They are all implemented as double operations with rounding to float as a second step. Which not only produces incorrect exceptions, as in this case, but incorrect numeri

Re: [Qemu-devel] [PATCH 04/13] target/openrisc: Make VR and PPC read-only

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:36PM -0700, Richard Henderson wrote: > These SPRs are read-only. The writes can simply be ignored, > as we already do for other read-only (or missing) registers. > There is no reason to mask the value in env->vr. > > Signed-off-by: Richard Henderson Reviewed-by: St

Re: [Qemu-devel] [PATCH 06/13] target/openrisc: Add VR2 and AVR special processor registers

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:38PM -0700, Richard Henderson wrote: > Update the CPUCFG bits to arch v1.3. > Include support for AVRP for cpu "any". > > Signed-off-by: Richard Henderson > --- > target/openrisc/cpu.h| 11 +++ > target/openrisc/cpu.c| 8 ++-- > target/o

Re: [Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, IMMCFGR to cpu init

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:37PM -0700, Richard Henderson wrote: > These registers are read-only and implementation specific. > Initiailize VR for the first time; take the OR1200 values > from the verilog source. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne > --- > targe

Re: [Qemu-devel] [PATCH 02/13] target/openrisc: Replace cpu register array with a function

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:34PM -0700, Richard Henderson wrote: > The writes to cpu_R[0] are now a race across threads, now that we > do code generation in parallel. Stage the change by introducing > a function to return the temp for R0. > > Signed-off-by: Richard Henderson Reviewed-by: Staf

Re: [Qemu-devel] [PATCH 03/13] target/openrisc: Cache R0 in DisasContext

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:35PM -0700, Richard Henderson wrote: > Finish the race condition fix from the previous patch. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 01/13] target/openrisc: Add DisasContext parameter to check_r0_write

2019-08-26 Thread Stafford Horne
On Mon, Aug 26, 2019 at 05:07:33PM -0700, Richard Henderson wrote: > We will need this context in the next patch. > > Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne

Re: [Qemu-devel] [PATCH 1/1] target/ppc: Fix do_float_check_status vs inexact

2019-08-26 Thread David Gibson
On Mon, Aug 26, 2019 at 09:54:34AM -0700, Richard Henderson wrote: > The underflow and inexact exceptions are not mutually exclusive. > Check for both of them. Tidy the reset of FPSCR[FI]. > > Fixes: https://bugs.launchpad.net/bugs/1841442 > Reported-by: Paul Clarke > Signed-off-by: Richard Hend

Re: [Qemu-devel] [PATCH] target/ppc: Set float_tininess_before_rounding at cpu reset

2019-08-26 Thread David Gibson
On Mon, Aug 26, 2019 at 07:00:13PM -0700, Richard Henderson wrote: > As defined in Power 3.0 section 4.4.4 "Underflow Exception", > a tiny result is detected before rounding. > > Fixes: https://bugs.launchpad.net/qemu/+bug/1841491 > Reported-by: Paul Clarke > Signed-off-by: Richard Henderson Ap

Re: [Qemu-devel] [PATCH] pseries: Fix compat_pvr on reset

2019-08-26 Thread David Gibson
On Mon, Aug 26, 2019 at 11:08:12AM +0200, Laurent Vivier wrote: > If we a migrate P8 machine to a P9 machine, the migration fails on > destination with: > > error while loading state for instance 0x1 of device 'cpu' > load of migration failed: Operation not permitted > > This is caused becaus

[Qemu-devel] [Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2019-08-26 Thread Paul Clarke
Responding to the patch https://lists.nongnu.org/archive/html/qemu- ppc/2019-08/msg00404.html, it seems to work for "double", but not for "float". Test case attached. ** Attachment added: "float testcase" https://bugs.launchpad.net/qemu/+bug/1841491/+attachment/5284810/+files/test-ffma.c --

[Qemu-devel] [Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2019-08-26 Thread Paul Clarke
** Attachment added: "2nd file of float testcase" https://bugs.launchpad.net/qemu/+bug/1841491/+attachment/5284821/+files/ffma.c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841491 Title: flo

Re: [Qemu-devel] [PATCH] target/ppc: Set float_tininess_before_rounding at cpu reset

2019-08-26 Thread Paul Clarke
On 8/26/19 9:00 PM, Richard Henderson wrote: > As defined in Power 3.0 section 4.4.4 "Underflow Exception", > a tiny result is detected before rounding. Responded in the bug: https://bugs.launchpad.net/qemu/+bug/1841491/comments/3 In my testing, this works for "double", but not "float". > Fixes:

[Qemu-devel] [PATCH v6 2/3] aspeed: add a GPIO controller to the SoC

2019-08-26 Thread Rashmica Gupta
Signed-off-by: Rashmica Gupta Reviewed-by: Cédric Le Goater --- include/hw/arm/aspeed_soc.h | 3 +++ hw/arm/aspeed_soc.c | 17 + 2 files changed, 20 insertions(+) diff --git a/include/hw/arm/aspeed_soc.h b/include/hw/arm/aspeed_soc.h index cef605ad6b..fa04abddd8 100644

[Qemu-devel] [PATCH v6 1/3] hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500

2019-08-26 Thread Rashmica Gupta
GPIO pins are arranged in groups of 8 pins labeled A,B,..,Y,Z,AA,AB,AC. (Note that the ast2400 controller only goes up to group AB). A set has four groups (except set AC which only has one) and is referred to by the groups it is composed of (eg ABCD,EFGH,...,YZAAAB). Each set is accessed and contro

[Qemu-devel] [PATCH v6 3/3] hw/gpio: Add in AST2600 specific implementation

2019-08-26 Thread Rashmica Gupta
The AST2600 has the same sets of 3.6v gpios as the AST2400 plus an addtional two sets of 1.8V gpios. Signed-off-by: Rashmica Gupta Reviewed-by: Cédric Le Goater --- hw/gpio/aspeed_gpio.c | 142 -- 1 file changed, 137 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v6 0/3] Add Aspeed GPIO controller model

2019-08-26 Thread Rashmica Gupta
v6: - fixed bug in get/set pin - added error checking that Cédric suggested v5: - integrated AspeedGPIOController fields into AspeedGPIOClass - separated ast2600_3_6v and ast2600_1_8v into two classes v4: - proper interupt handling thanks to Andrew - switch statements for reading and writing sugg

Re: [Qemu-devel] [Virtio-fs] [PATCH v2 1/2] virtio: add vhost-user-fs base device

2019-08-26 Thread piaojun
On 2019/8/24 1:56, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The virtio-fs virtio device provides shared file system access using > the FUSE protocol carried ovew virtio. typo? ovew->over > The actual file server is implemented in an external vhost-user-fs devi

[Qemu-devel] [PATCH] target/ppc: Set float_tininess_before_rounding at cpu reset

2019-08-26 Thread Richard Henderson
As defined in Power 3.0 section 4.4.4 "Underflow Exception", a tiny result is detected before rounding. Fixes: https://bugs.launchpad.net/qemu/+bug/1841491 Reported-by: Paul Clarke Signed-off-by: Richard Henderson --- target/ppc/translate_init.inc.c | 4 1 file changed, 4 insertions(+) di

Re: [Qemu-devel] [PATCH qemu] spapr: Render full FDT on ibm, client-architecture-support

2019-08-26 Thread Alexey Kardashevskiy
On 26/08/2019 17:44, David Gibson wrote: On Mon, Aug 26, 2019 at 02:31:26PM +1000, Alexey Kardashevskiy wrote: The ibm,client-architecture-support call is a way for the guest to negotiate capabilities with a hypervisor. It is implemented as: - the guest calls SLOF via client interface; - SLOF

Re: [Qemu-devel] [PATCH v4 0/3] Add Aspeed GPIO controller model

2019-08-26 Thread Rashmica Gupta
On Fri, 2019-08-16 at 18:21 +0200, Cédric Le Goater wrote: > On 16/08/2019 09:32, Rashmica Gupta wrote: > > v5: > > - integrated AspeedGPIOController fields into AspeedGPIOClass > > - separated ast2600_3_6v and ast2600_1_8v into two classes > > Rashmica, > > This looks much nicer ! > > Please

Re: [Qemu-devel] [POC Seabios PATCH] seabios: use isolated SMM address space for relocation

2019-08-26 Thread Boris Ostrovsky
On 8/26/19 9:57 AM, Igor Mammedov wrote: > >> I most likely don't understand how this is supposed to work but aren't >> we here successfully reading SMRAM from non-SMM context, something we >> are not supposed to be able to do? > We are aren't reading SMRAM at 0x3 base directly, > "RAM" marked

[Qemu-devel] [Bug 1841491] Re: floating point emulation can fail to set FE_UNDERFLOW

2019-08-26 Thread Paul Clarke
** Attachment added: "2nd file of testcase" https://bugs.launchpad.net/qemu/+bug/1841491/+attachment/5284809/+files/fma.c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1841491 Title: floating po

[Qemu-devel] [Bug 1841491] [NEW] floating point emulation can fail to set FE_UNDERFLOW

2019-08-26 Thread Paul Clarke
Public bug reported: Floating point emulation can fail to set FE_UNDERFLOW in some circumstances. This shows up often in glibc's "math" tests. A similar test is attached. This is similar to bug #1841442, but not the same problem, and I don't think the fix will be in the same code. On ppc64le nat

[Qemu-devel] [PATCH v3 1/2] block: posix: Always allocate the first block

2019-08-26 Thread Nir Soffer
When creating an image with preallocation "off" or "falloc", the first block of the image is typically not allocated. When using Gluster storage backed by XFS filesystem, reading this block using direct I/O succeeds regardless of request length, fooling alignment detection. In this case we fallbac

[Qemu-devel] [PATCH v3 2/2] iotests: Test allocate_first_block() with O_DIRECT

2019-08-26 Thread Nir Soffer
Using block_resize we can test allocate_first_block() with file descriptor opened with O_DIRECT, ensuring that it works for any size larger than 4096 bytes. Testing smaller sizes is tricky as the result depends on the filesystem used for testing. For example on NFS any size will work since O_DIREC

[Qemu-devel] [PATCH v3 0/2] Optimize alignment probing

2019-08-26 Thread Nir Soffer
When probing unallocated area on remote XFS filesystem we cannot detect request alignment and we fallback to safe value which may not be optimal. Avoid this fallback by always allocating the first block when creating a new image or resizing empty image. Tested with all formats: for fmt in raw

Re: [Qemu-devel] [PATCH v2] configure: more resilient Python version capture

2019-08-26 Thread Tony Nguyen
On Mon, Aug 26, 2019 at 11:58:32AM -0400, Cleber Rosa wrote: > The current approach to capture the Python version is fragile, as it > was demonstrated by a very specific build of Python 3 on Fedora 29 > that, under non-interactive shells would print multiline version > information. > > The (badly)

[Qemu-devel] [PATCH 13/13] target/openrisc: Update cpu "any" to v1.3

2019-08-26 Thread Richard Henderson
Now that the two updates from v3.1 are implemented, update the "any" cpu to enable it. Signed-off-by: Richard Henderson --- target/openrisc/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c index f96a69e278..506aec6bfb 100644

[Qemu-devel] [PATCH 11/13] target/openrisc: Implement move to/from FPCSR

2019-08-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/openrisc/cpu.h| 2 ++ target/openrisc/cpu.c| 1 + target/openrisc/fpu_helper.c | 13 + target/openrisc/machine.c| 11 +++ target/openrisc/sys_helper.c | 18 -- 5 files changed, 39 insertions(+),

[Qemu-devel] [PATCH 09/13] target/openrisc: Add support for ORFPX64A32

2019-08-26 Thread Richard Henderson
This is hardware support for double-precision floating-point using pairs of 32-bit registers. Fix a latent bug in the heretofore unused helper_itofd. Include the bit for cpu "any". Signed-off-by: Richard Henderson --- linux-user/openrisc/target_elf.h | 2 +- target/openrisc/helper.h

[Qemu-devel] [PATCH 06/13] target/openrisc: Add VR2 and AVR special processor registers

2019-08-26 Thread Richard Henderson
Update the CPUCFG bits to arch v1.3. Include support for AVRP for cpu "any". Signed-off-by: Richard Henderson --- target/openrisc/cpu.h| 11 +++ target/openrisc/cpu.c| 8 ++-- target/openrisc/sys_helper.c | 6 ++ 3 files changed, 19 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH 07/13] target/openrisc: Fix lf.ftoi.s

2019-08-26 Thread Richard Henderson
The specification of this insn is round-to-zero. Signed-off-by: Richard Henderson --- target/openrisc/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c index b9d2ebbb8c..4cc5b297c5 100644 --- a/target/open

[Qemu-devel] [PATCH 10/13] target/openrisc: Implement unordered fp comparisons

2019-08-26 Thread Richard Henderson
These were added to the 1.3 spec. For OF32S, validate AVR. But OF64A32 is itself new to 1.3 so no extra check needed. Signed-off-by: Richard Henderson --- target/openrisc/helper.h | 4 ++ target/openrisc/disas.c | 24 ++ target/openrisc/fpu_helper.c | 20 + target/open

[Qemu-devel] [PATCH 08/13] target/openrisc: Check CPUCFG_OF32S for float insns

2019-08-26 Thread Richard Henderson
Make sure the OF32S insns are enabled before allowing execution. Include the missing bit for cpu "any". Signed-off-by: Richard Henderson --- target/openrisc/cpu.c | 2 +- target/openrisc/translate.c | 84 - 2 files changed, 36 insertions(+), 50 deletion

[Qemu-devel] [PATCH 02/13] target/openrisc: Replace cpu register array with a function

2019-08-26 Thread Richard Henderson
The writes to cpu_R[0] are now a race across threads, now that we do code generation in parallel. Stage the change by introducing a function to return the temp for R0. Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 213 1 file changed, 11

[Qemu-devel] [PATCH 01/13] target/openrisc: Add DisasContext parameter to check_r0_write

2019-08-26 Thread Richard Henderson
We will need this context in the next patch. Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 96 +++-- 1 file changed, 49 insertions(+), 47 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 4360ce4045..ed

[Qemu-devel] [PATCH 12/13] target/openrisc: Implement l.adrp

2019-08-26 Thread Richard Henderson
This was added to the 1.3 spec. Signed-off-by: Richard Henderson --- target/openrisc/disas.c | 1 + target/openrisc/translate.c | 13 + target/openrisc/insns.decode | 2 ++ 3 files changed, 16 insertions(+) diff --git a/target/openrisc/disas.c b/target/openrisc/disas.c index

[Qemu-devel] [PATCH 03/13] target/openrisc: Cache R0 in DisasContext

2019-08-26 Thread Richard Henderson
Finish the race condition fix from the previous patch. Signed-off-by: Richard Henderson --- target/openrisc/translate.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 3812dc4427..37e8098023

[Qemu-devel] [PATCH 05/13] target/openrisc: Move VR, UPR, DMMCFGR, IMMCFGR to cpu init

2019-08-26 Thread Richard Henderson
These registers are read-only and implementation specific. Initiailize VR for the first time; take the OR1200 values from the verilog source. Signed-off-by: Richard Henderson --- target/openrisc/cpu.h| 8 target/openrisc/cpu.c| 23 --- target/openris

[Qemu-devel] [PATCH 04/13] target/openrisc: Make VR and PPC read-only

2019-08-26 Thread Richard Henderson
These SPRs are read-only. The writes can simply be ignored, as we already do for other read-only (or missing) registers. There is no reason to mask the value in env->vr. Signed-off-by: Richard Henderson --- target/openrisc/cpu.h| 3 --- target/openrisc/sys_helper.c | 10 +- 2 f

[Qemu-devel] [PATCH 00/13] target/openrisc updates

2019-08-26 Thread Richard Henderson
The first three fix an MTTCG race on cpu_R[0], now that we do code generation in parallel. Then some updates to the SPRs, cpuid checks for existing float insns, adding the new v1.3 instructions. I've run this through the gcc testsuite as make check-gcc \ RUNTESTFLAGS='--target_board=or1k-qemu/-m

Re: [Qemu-devel] [PATCH 0/2] riscv: Fix "-L" not working for bios image search path

2019-08-26 Thread Palmer Dabbelt
On Fri, 16 Aug 2019 06:09:34 PDT (-0700), bmeng...@gmail.com wrote: Currently when QEMU is given a bios image with only a file name and its file path passed in "-L", it still reports file not found. This series fixes the issue. This is especially helpful for creating distro QEMU packages. Bin

Re: [Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-26 Thread Richard Henderson
On 8/26/19 1:38 PM, Peter Maydell wrote: >> + IT1011 ... imm:5 &ci cond=%it_cond > > This is correct (same behaviour as the old decoder, but > it looks a bit odd here because it's not the same as > the fields defined by the architecture (in particular the > 'cond' fie

Re: [Qemu-devel] [PATCH v2 0/4] Audio: misc fixes for "Audio 20190821 patches"

2019-08-26 Thread Maxim Levitsky
On Mon, 2019-08-26 at 21:59 +0200, Kővágó, Zoltán wrote: > Hi, > > This is the second iteration of my "random fixes" patchset. Compared to > v1, this has a new patch, fixing the memory error caused by an invalid > malloc. > > Regards, > Zoltan > > Kővágó, Zoltán (4): > audio: fix invalid mall

Re: [Qemu-devel] [PATCH v5 00/30] riscv: sifive_u: Improve the emulation fidelity of sifive_u machine

2019-08-26 Thread Alistair Francis
On Fri, Aug 23, 2019 at 10:08 PM Bin Meng wrote: > > Hi Alistair, > > On Sat, Aug 24, 2019 at 1:29 AM Alistair Francis wrote: > > > > On Thu, Aug 22, 2019 at 10:15 PM Bin Meng wrote: > > > > > > As of today, the QEMU 'sifive_u' machine is a special target that does > > > not boot the upstream Op

Re: [Qemu-devel] [PATCH v5 12/30] riscv: sifive_e: Drop sifive_mmio_emulate()

2019-08-26 Thread Alistair Francis
On Thu, 2019-08-22 at 22:10 -0700, Bin Meng wrote: > Use create_unimplemented_device() instead. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: > - drop patch "riscv: sifive: Move

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-08-26 Thread Josh Kunz via Qemu-devel
On Wed, Aug 21, 2019 at 2:28 AM Laurent Vivier wrote: > Le 19/08/2019 à 23:46, Josh Kunz via Qemu-devel a écrit : > > Hi all, > > > > I have also experienced issues with SIGRTMIN + 1, and am interested in > > moving this patch forwards. Anything I can do here to help? Would the > > maintainers pr

Re: [Qemu-devel] [PATCH 2/3] audio: paaudio: fix client name

2019-08-26 Thread Maxim Levitsky
On Mon, 2019-08-26 at 21:28 +0200, Zoltán Kővágó wrote: > On 2019-08-26 10:21, Maxim Levitsky wrote: > > On Mon, 2019-08-26 at 02:29 +0200, Kővágó, Zoltán wrote: > > > pa_context_new expects a client name, not a server socket path. > > > > > > Signed-off-by: Kővágó, Zoltán > > > --- > > > audio/

Re: [Qemu-devel] [PATCH 1/1] target/ppc: Fix do_float_check_status vs inexact

2019-08-26 Thread Paul Clarke
On 8/26/19 11:54 AM, Richard Henderson wrote: > The underflow and inexact exceptions are not mutually exclusive. > Check for both of them. Tidy the reset of FPSCR[FI]. > > Fixes: https://bugs.launchpad.net/bugs/1841442 > Reported-by: Paul Clarke > Signed-off-by: Richard Henderson Tested-by: Pa

Re: [Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > diff --git a/target/arm/t16.decode b/target/arm/t16.decode > index 98d60952a1..4ecbabd364 100644 > --- a/target/arm/t16.decode > +++ b/target/arm/t16.decode > @@ -210,20 +210,33 @@ REVSH

Re: [Qemu-devel] [PATCH 16/25] audio: add mixeng option (documentation)

2019-08-26 Thread Zoltán Kővágó
On 2019-08-26 15:35, Eric Blake wrote: > On 8/25/19 1:46 PM, Kővágó, Zoltán wrote: >> This will allow us to disable mixeng when we use a decent backend. >> >> Disabling mixeng have a few advantages: >> * we no longer convert the audio output from one format to another, when >> the underlying audi

[Qemu-devel] [PATCH v2 3/4] audio: paaudio: fix client name

2019-08-26 Thread Kővágó, Zoltán
pa_context_new expects a client name, not a server socket path. Signed-off-by: Kővágó, Zoltán Reviewed-by: Maxim Levitsky --- audio/paaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index bfef9acaad..777b8e4718 100644 --- a/audio/paa

[Qemu-devel] [PATCH v2 1/4] audio: fix invalid malloc size in audio_create_pdos

2019-08-26 Thread Kővágó, Zoltán
The code used sizeof(AudiodevAlsaPerDirectionOptions) instead of the appropriate per direction options for the audio backend. If the size of the actual audiodev's per direction options are larger than alsa's, it could cause a buffer overflow. However, alsa has three fields in per direction option

[Qemu-devel] [PATCH v2 4/4] audio: paaudio: ability to specify stream name

2019-08-26 Thread Kővágó, Zoltán
This can be used to identify stream in tools like pavucontrol when one creates multiple -audiodevs or runs multiple qemu instances. Signed-off-by: Kővágó, Zoltán Reviewed-by: Maxim Levitsky --- qapi/audio.json | 6 ++ audio/paaudio.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH v2 2/4] audio: omitting audiodev= parameter is only deprecated

2019-08-26 Thread Kővágó, Zoltán
Unfortunately, changes introduced in af2041ed2d "audio: audiodev= parameters no longer optional when -audiodev present" breaks backward compatibility. This patch changes the error into a deprecation warning. Signed-off-by: Kővágó, Zoltán --- qemu-deprecated.texi | 7 +++ audio/audio.c

[Qemu-devel] [PATCH v2 0/4] Audio: misc fixes for "Audio 20190821 patches"

2019-08-26 Thread Kővágó, Zoltán
Hi, This is the second iteration of my "random fixes" patchset. Compared to v1, this has a new patch, fixing the memory error caused by an invalid malloc. Regards, Zoltan Kővágó, Zoltán (4): audio: fix invalid malloc size in audio_create_pdos audio: omitting audiodev= parameter is only depr

[Qemu-devel] [PATCH v3] target/xtensa: linux-user: add call0 ABI support

2019-08-26 Thread Max Filippov
Xtensa binaries built for call0 ABI don't rotate register window on function calls and returns. Invocation of signal handlers from the kernel is therefore different in windowed and call0 ABIs. There's currently no way to determine xtensa ELF binary ABI from the binary itself. Add handler for the -x

Re: [Qemu-devel] [PATCH v2 61/68] target/arm: Convert T16, Conditional branches, Supervisor call

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 26 +++--- > target/arm/t16.decode | 12 > 2 files changed, 15 insertions(+), 23 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v2] target/xtensa: linux-user: add call0 ABI support

2019-08-26 Thread Max Filippov
On Mon, Aug 26, 2019 at 11:17 AM Max Filippov wrote: > > Xtensa binaries built for call0 ABI don't rotate register window on > function calls and returns. Invocation of signal handlers from the > kernel is therefore different in windowed and call0 ABIs. > There's currently no way to determine xten

Re: [Qemu-devel] [PATCH 0/2] tests/acceptance: Update MIPS Malta ssh test

2019-08-26 Thread Aleksandar Markovic
ping 22.08.2019. 19.59, "Aleksandar Markovic" је написао/ла: > > > 22.08.2019. 05.15, "Aleksandar Markovic" је написао/ла: > > > > > > 21.08.2019. 23.00, "Eduardo Habkost" је написао/ла: > > > > > > On Wed, Aug 21, 2019 at 10:27:11PM +0200, Aleksandar Markovic wrote: > > > > 02.08.2019. 17.37,

Re: [Qemu-devel] [PATCH v8 00/13] Add migration support for VFIO device

2019-08-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1566845753-18993-1-git-send-email-kwankh...@nvidia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1566845753-18993-1-git-send-email-kwankh...@nvidia.com Subject: [Qemu-devel]

Re: [Qemu-devel] [PATCH v2 60/68] target/arm: Convert T16, push and pop

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 83 ++ > target/arm/t16.decode | 10 + > 2 files changed, 22 insertions(+), 71 deletions(-) Reviewed-by: Peter Maydell than

Re: [Qemu-devel] [PATCH v2 59/68] target/arm: Split gen_nop_hint

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Now that there all callers pass a constant value, split the switch > statement into the individual trans_* functions. s/there//. Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 2/3] audio: paaudio: fix client name

2019-08-26 Thread Zoltán Kővágó
On 2019-08-26 10:21, Maxim Levitsky wrote: > On Mon, 2019-08-26 at 02:29 +0200, Kővágó, Zoltán wrote: >> pa_context_new expects a client name, not a server socket path. >> >> Signed-off-by: Kővágó, Zoltán >> --- >> audio/paaudio.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> dif

Re: [Qemu-devel] [PATCH v2 58/68] target/arm: Convert T16, nop hints

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 3 +-- > target/arm/t16.decode | 17 + > 2 files changed, 18 insertions(+), 2 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v8 10/13] vfio: Add load state functions to SaveVMHandlers

2019-08-26 Thread Kirti Wankhede
Sequence during _RESUMING device state: While data for this device is available, repeat below steps: a. read data_offset from where user application should write data. b. write data of data_size to migration region from data_offset. c. write data_size which indicates vendor driver that data is wri

Re: [Qemu-devel] [PATCH v2 57/68] target/arm: Convert T16, Reverse bytes

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 18 +++--- > target/arm/t16.decode | 9 + > 2 files changed, 12 insertions(+), 15 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

[Qemu-devel] [PATCH v8 08/13] vfio: Register SaveVMHandlers for VFIO device

2019-08-26 Thread Kirti Wankhede
Define flags to be used as delimeter in migration file stream. Added .save_setup and .save_cleanup functions. Mapped & unmapped migration region from these functions at source during saving or pre-copy phase. Set VFIO device state depending on VM's state. During live migration, VM is running when .

[Qemu-devel] [PATCH v8 07/13] vfio: Add migration state change notifier

2019-08-26 Thread Kirti Wankhede
Added migration state change notifier to get notification on migration state change. These states are translated to VFIO device state and conveyed to vendor driver. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/migration.c | 28 hw/vfio/tr

Re: [Qemu-devel] [PATCH v2 56/68] target/arm: Convert T16, Change processor state

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 85 -- > target/arm/t16.decode | 12 ++ > 2 files changed, 52 insertions(+), 45 deletions(-) > > diff --git a/target/arm/trans

[Qemu-devel] [PATCH v8 05/13] vfio: Add migration region initialization and finalize function

2019-08-26 Thread Kirti Wankhede
- Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this patch series. - VFIO device supports migration or not is decided based of migration region query. If migration region query is successful and migration region initialization is successful then migration is supported

[Qemu-devel] [PATCH v8 11/13] vfio: Add function to get dirty page list

2019-08-26 Thread Kirti Wankhede
Dirty page tracking (.log_sync) is part of RAM copying state, where vendor driver provides the bitmap of pages which are dirtied by vendor driver through migration region and as part of RAM copy, those pages gets copied to file stream. To get dirty page bitmap: - write start address, page_size and

[Qemu-devel] [PATCH v8 04/13] vfio: Add save and load functions for VFIO PCI devices

2019-08-26 Thread Kirti Wankhede
These functions save and restore PCI device specific data - config space of PCI device. Tested save and restore with MSI and MSIX type. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 168 ++ include/hw/vfio/vfio-com

[Qemu-devel] [PATCH v8 09/13] vfio: Add save state functions to SaveVMHandlers

2019-08-26 Thread Kirti Wankhede
Added .save_live_pending, .save_live_iterate and .save_live_complete_precopy functions. These functions handles pre-copy and stop-and-copy phase. In _SAVING|_RUNNING device state or pre-copy phase: - read pending_bytes. If pending_bytes > 0, go through below steps. - read data_offset - indicates k

[Qemu-devel] [PATCH v8 12/13] vfio: Add vfio_listener_log_sync to mark dirty pages

2019-08-26 Thread Kirti Wankhede
vfio_listener_log_sync gets list of dirty pages from vendor driver and mark those pages dirty when in _SAVING state. Return early for the RAM block section of mapped MMIO region. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/common.c | 35 +++ 1

[Qemu-devel] [PATCH v8 02/13] vfio: Add function to unmap VFIO region

2019-08-26 Thread Kirti Wankhede
This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck --- hw/vfio/common.c | 20 hw/vfio/

[Qemu-devel] [PATCH v8 06/13] vfio: Add VM state change handler to know state of VM

2019-08-26 Thread Kirti Wankhede
VM state change handler gets called on change in VM's state. This is used to set VFIO device state to _RUNNING. VM state change handler, migration state change handler and log_sync listener are called asynchronously, which sometimes lead to data corruption in migration region. Initialised mutex tha

[Qemu-devel] [PATCH v8 03/13] vfio: Add vfio_get_object callback to VFIODeviceOps

2019-08-26 Thread Kirti Wankhede
Hook vfio_get_object callback for PCI devices. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Suggested-by: Cornelia Huck Reviewed-by: Cornelia Huck --- hw/vfio/pci.c | 8 include/hw/vfio/vfio-common.h | 1 + 2 files changed, 9 insertions(+) diff --git a/hw/vfio/

[Qemu-devel] [PATCH v8 13/13] vfio: Make vfio-pci device migration capable.

2019-08-26 Thread Kirti Wankhede
Call vfio_migration_probe() and vfio_migration_finalize() functions for vfio-pci device to enable migration for vfio PCI device. Removed vfio_pci_vmstate structure. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia --- hw/vfio/pci.c | 15 +-- 1 file changed, 9 insertions(+), 6 dele

[Qemu-devel] [PATCH v8 01/13] vfio: KABI for migration interface

2019-08-26 Thread Kirti Wankhede
- Defined MIGRATION region type and sub-type. - Used 3 bits to define VFIO device states. Bit 0 => _RUNNING Bit 1 => _SAVING Bit 2 => _RESUMING Combination of these bits defines VFIO device's state during migration _STOPPED => All bits 0 indicates VFIO device stopped. _RUNNI

[Qemu-devel] [PATCH v8 00/13] Add migration support for VFIO device

2019-08-26 Thread Kirti Wankhede
Add migration support for VFIO device This Patch set include patches as below: - Define KABI for VFIO device for migration support. - Added save and restore functions for PCI configuration space - Generic migration functionality for VFIO device. * This patch set adds functionality only for PCI d

[Qemu-devel] [Bug 1839060] Re: HDA device non functional in Windows 10 1903

2019-08-26 Thread Idar Lund
Created Windows feedback as instructed by Andre: https://aka.ms/AA5wlk7 Please upvote this to get attention by Microsoft. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1839060 Title: HDA device non

Re: [Qemu-devel] [PATCH v2 55/68] target/arm: Convert T16, extract

2019-08-26 Thread Peter Maydell
On Mon, 19 Aug 2019 at 22:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 14 +- > target/arm/t16.decode | 10 ++ > 2 files changed, 11 insertions(+), 13 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

  1   2   3   >