[Qemu-devel] [PULL 04/11] target/mips: Style improvements in translate.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-12-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/translate.c | 773 +++

[Qemu-devel] [PULL 06/11] target/mips: Style improvements in mips_fulong2e.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-14-git-send-email-aleksandar.marko...@rt-rk.com> --- hw/mips/mips_fulong2e.c | 96

[Qemu-devel] [PULL 10/11] target/mips: tests/tcg: Add optional printing of more detailed failure info

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic There is a need for printing input and output data for failure cases, for debugging purpose. This is achieved by this patch, and only if a preprocessor constant is manually set to 1. (Assumption is that the need for such printout is relatively rare.) Signed-off-by: Alek

[Qemu-devel] [PULL 09/11] target/mips: Style improvements in mips_mipssim.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-17-git-send-email-aleksandar.marko...@rt-rk.com> --- hw/mips/mips_mipssim.c | 19 --- 1 fi

Re: [Qemu-devel] [PATCH v3 6/8] iotests: Test driver whitelisting in 093

2019-08-19 Thread Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote: > null-aio may not be whitelisted. Skip all test cases that require it. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/093 | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tests/qemu-iotests/093 b/tests/qemu-io

Re: [Qemu-devel] [PATCH v3 2/8] iotests: Prefer null-co over null-aio

2019-08-19 Thread Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote: > We use null-co basically everywhere in the iotests. Unless we want to > test null-aio specifically, we should use it instead (for consistency). > > Signed-off-by: Max Reitz > Reviewed-by: John Snow > --- > tests/qemu-iotests/093 | 7 +++ > tests/qemu

[Qemu-devel] [PULL 08/11] target/mips: Style improvements in mips_malta.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-16-git-send-email-aleksandar.marko...@rt-rk.com> --- hw/mips/mips_malta.c | 216 ++

[Qemu-devel] [PULL 02/11] target/mips: Style improvements in cpu.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1566216496-17375-8-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cpu.c | 17 +++-- 1 file

[Qemu-devel] [PULL 07/11] target/mips: Style improvements in mips_int.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-15-git-send-email-aleksandar.marko...@rt-rk.com> --- hw/mips/mips_int.c | 3 ++- 1 file changed, 2 inserti

[Qemu-devel] [PULL 01/11] target/mips: Style improvements in cp0_timer.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1566216496-17375-7-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/cp0_timer.c | 42

[Qemu-devel] [PULL 00/11] MIPS queue for August 20th, 2019

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic The following changes since commit 50d69ee0d82378c7c21f482492dacfe0916b4863: Merge remote-tracking branch 'remotes/stsquad/tags/pull-softfloat-headers-190819-1' into staging (2019-08-19 15:58:01 +0100) are available in the git repository at: https://github.com/A

[Qemu-devel] [PULL 03/11] target/mips: Style improvements in machine.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1566216496-17375-10-git-send-email-aleksandar.marko...@rt-rk.com> --- target/mips/machine.c | 4 ++-- 1 file changed,

[Qemu-devel] [PULL 05/11] target/mips: Style improvements in cps.c

2019-08-19 Thread Aleksandar Markovic
From: Aleksandar Markovic Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Rikalo Message-Id: <1566216496-17375-13-git-send-email-aleksandar.marko...@rt-rk.com> --- hw/mips/cps.c | 6 -- 1 file changed, 4 insertion

Re: [Qemu-devel] [PATCH v2 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Peter Xu
On Tue, Aug 20, 2019 at 02:35:15PM +0800, Peter Xu wrote: > On Tue, Aug 20, 2019 at 08:24:12AM +0200, Paolo Bonzini wrote: > > On 20/08/19 07:16, Peter Xu wrote: > > > It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO > > > interface. The kernel interface only allows to unregister

Re: [Qemu-devel] [PATCH v3 1/8] iotests: Add -display none to the qemu options

2019-08-19 Thread Thomas Huth
On 8/19/19 10:18 PM, Max Reitz wrote: > Without this argument, qemu will print an angry message about not being > able to connect to a display server if $DISPLAY is not set. For me, > that breaks iotests.supported_formats() because it thus only sees > ["Could", "not", "connect"] as the supported f

Re: [Qemu-devel] [PATCH v2 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Peter Xu
On Tue, Aug 20, 2019 at 08:24:12AM +0200, Paolo Bonzini wrote: > On 20/08/19 07:16, Peter Xu wrote: > > It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO > > interface. The kernel interface only allows to unregister an mmio > > device with exactly the zone size when registered, or

Re: [Qemu-devel] Machine specific option ROMs

2019-08-19 Thread Gerd Hoffmann
Hi, > > For example in qemu 1.5 the nic roms got EFI support and there is a > > compat property which switches the pc-i440fx-1.4 (and older) machine > > types to the non-efi versions. Grep for pxe-e1000.rom to find the code. Note that roms with a pci firmware standard header[1] can be chained

Re: [Qemu-devel] [PATCH v2 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Paolo Bonzini
On 20/08/19 07:16, Peter Xu wrote: > It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO > interface. The kernel interface only allows to unregister an mmio > device with exactly the zone size when registered, or any smaller zone > that is included in the device mmio zone. It does n

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-19 Thread Paolo Bonzini
On 20/08/19 07:22, Peter Xu wrote: > On Mon, Aug 12, 2019 at 09:45:27AM +0200, Peter Xu wrote: >> This is a RFC series. >> >> The VT-d code has some defects, one of them is that we cannot detect >> the misuse of vIOMMU and vfio-pci early enough. >> >> For example, logically this is not allowed: >>

[Qemu-devel] [PATCH v3 00/15] target/arm/kvm: enable SVE in guests

2019-08-19 Thread Zhang, Lei
Hi Andrew, I have tested your patch on kernel- 5.2.7 + QEMU (4.0.94 + patch). This patch series works fine for my tests when use qemu-system-aarch64 directly. But I can't startup kvm when I use virsh[1]. Command I executed. # virsh start test1 The error message is [internal error: CPU features

Re: [Qemu-devel] [PATCH RFC 0/4] intel_iommu: Do sanity check of vfio-pci earlier

2019-08-19 Thread Peter Xu
On Mon, Aug 12, 2019 at 09:45:27AM +0200, Peter Xu wrote: > This is a RFC series. > > The VT-d code has some defects, one of them is that we cannot detect > the misuse of vIOMMU and vfio-pci early enough. > > For example, logically this is not allowed: > > -device intel-iommu,caching-mode=off

[Qemu-devel] [PATCH v2 1/2] memory: Inherit has_coalesced_range from the same old FlatRange

2019-08-19 Thread Peter Xu
The previous has_coalesced_range counter has a problem in that it only works for additions of coalesced mmio ranges but not deletions. The reason is that has_coalesced_range information can be lost when the FlatView updates the topology again when the updated region is not covering the coalesced r

[Qemu-devel] [PATCH v2 0/2] memory: Fix up coalesced_io_del not working for KVM

2019-08-19 Thread Peter Xu
v2: - simply migrate has_coalesced_range in patch 1, while I added comments in the code because that can be a bit unobvious [Paolo] v1 is here: https://lists.gnu.org/archive/html/qemu-devel/2019-08/msg03293.html Peter Xu (2): memory: Inherit has_coalesced_range from the same old FlatRange

[Qemu-devel] [PATCH v2 2/2] memory: Split zones when do coalesced_io_del()

2019-08-19 Thread Peter Xu
It is a workaround of current KVM's KVM_UNREGISTER_COALESCED_MMIO interface. The kernel interface only allows to unregister an mmio device with exactly the zone size when registered, or any smaller zone that is included in the device mmio zone. It does not support the userspace to specify a very

Re: [Qemu-devel] [PATCH 1/2] memory: Replace has_coalesced_range with add/del flags

2019-08-19 Thread Peter Xu
On Mon, Aug 19, 2019 at 04:30:45PM +0200, Paolo Bonzini wrote: > On 17/08/19 11:32, Peter Xu wrote: > > The previous has_coalesced_range counter has a problem in that it only > > works for additions of coalesced mmio ranges but not deletions. The > > reason is that has_coalesced_range information

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Peng Tao
On 2019/8/20 00:04, Stefan Hajnoczi wrote: I am delighted to announce the release of virtio-fs v0.3, a shared file system that lets virtual machines access a directory tree on the host. This release is based on QEMU 4.1.0 and Linux 5.3-rc3. Good news! As virtio-fs is maturing and stabilizing,

Re: [Qemu-devel] [kata-dev] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread Xu Wang
Thanks all the contributors, looking forward to having a product virtio-fs deployment shortly. > On Aug 20, 2019, at 12:04 AM, Stefan Hajnoczi wrote: > > I am delighted to announce the release of virtio-fs v0.3, a shared file > system that lets virtual machines access a directory tree on the ho

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Edgar E. Iglesias
On Mon, 19 Aug. 2019, 23:01 Richard Henderson, wrote: > On 8/19/19 11:29 AM, Paolo Bonzini wrote: > > On 19/08/19 20:28, Paolo Bonzini wrote: > >> On 16/08/19 12:12, Thomas Huth wrote: > >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the > >>> filter of the qemu-s390x list

Re: [Qemu-devel] [PATCH v2] ppc: conform to processor User's Manual for xscvdpspn

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 12:43:21PM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > The POWER8 and POWER9 User's Manuals specify the implementation > behavior for what the ISA leaves "undefined" behavior for the > xscvdpspn and xscvdpsp instructions. This patch corrects the QEMU > imple

Re: [Qemu-devel] [PATCH] ppc: Fix emulated INFINITY and NAN conversions

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 01:57:42PM -0700, Richard Henderson wrote: > On 8/19/19 12:19 PM, Paul A. Clarke wrote: > > From: "Paul A. Clarke" > > > > helper_todouble() was not properly converting INFINITY from 32 bit > > float to 64 bit double. > > > > (Normalized operand conversion is unchanged, o

Re: [Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread David Gibson
On Mon, Aug 19, 2019 at 04:42:16PM -0500, Paul A. Clarke wrote: > From: "Paul A. Clarke" > > helper_todouble() was not properly converting any denormalized 32 bit > float to 64 bit double. > > Fix-suggested-by: Richard Henderson > Signed-off-by: Paul A. Clarke > > v2: > - Splitting patch "ppc

Re: [Qemu-devel] RISCV: when will the CLIC be ready?

2019-08-19 Thread Bin Meng
On Tue, Aug 20, 2019 at 3:09 AM Alistair Francis wrote: > > On Mon, Aug 19, 2019 at 6:44 AM liuzhiwei wrote: > > > > > > On 2019/8/17 上午1:29, Alistair Francis wrote: > > > On Thu, Aug 15, 2019 at 8:39 PM liuzhiwei wrote: > > >> Hi, Palmer > > >> > > >> When Michael Clark still was the maintainer

[Qemu-devel] [Bug 1819289] Re: Windows 95 and Windows 98 will not install or run

2019-08-19 Thread Brad Parker
Just FYI that was the second bisect I had to do, the first time it produced an even more unrelated commit, so I assumed I must have done something wrong... apparently that is still the case. After trying the "working" commit outside of the Docker container, it now does not work... so I'm at a loss

Re: [Qemu-devel] [Virtio-fs] [ANNOUNCE] virtio-fs v0.3 release

2019-08-19 Thread piaojun
A big step for virtio-fs! Jun On 2019/8/20 0:04, Stefan Hajnoczi wrote: > I am delighted to announce the release of virtio-fs v0.3, a shared file > system that lets virtual machines access a directory tree on the host. > This release is based on QEMU 4.1.0 and Linux 5.3-rc3. > > For more informa

Re: [Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread Aleksandar Markovic
20.08.2019. 00.32, "Paul A. Clarke" је написао/ла: > > From: "Paul A. Clarke" > > helper_todouble() was not properly converting any denormalized 32 bit > float to 64 bit double. > > Fix-suggested-by: Richard Henderson > Signed-off-by: Paul A. Clarke > > v2: > - Splitting patch "ppc: Three float

Re: [Qemu-devel] Machine specific option ROMs

2019-08-19 Thread BALATON Zoltan
On Mon, 19 Aug 2019, Gerd Hoffmann wrote: > On Mon, Aug 19, 2019 at 02:38:09AM +0200, BALATON Zoltan wrote: >> I know about the possibility to set the option ROM of a PCIDevice with the >> romfile property (that we can set on command line or in a device's init >> method) but is there a way to set i

[Qemu-devel] [Bug 1840719] Re: win98se floppy fails to boot with isapc machine

2019-08-19 Thread Philippe Mathieu-Daudé
Bisected following note from http://gunkies.org/wiki/I386-softmmu: the isapc configuration no longer works... So legacy systems must resort to Qemu 0.9.0 or Qemu 0.10.0 I get: fd646122418ecefcde228d43821d07da79dd99bb is the first bad commit commit fd646122418ecefcde228d43821d07da79dd99bb Author:

[Qemu-devel] [Bug 1840719] [NEW] win98se floppy fails to boot with isapc machine

2019-08-19 Thread Philippe Mathieu-Daudé
Public bug reported: QEMU emulator version 4.1.50 (commit 50d69ee0d) floppy image from: https://winworldpc.com/download/417d71c2-ae18-c39a-11c3-a4e284a2c3a5 $ qemu-system-i386 -M isapc -fda Windows\ 98\ Second\ Edition\ Boot.img SeaBIOS (version rel-1.12.1-0...) Booting from Floppy... Boot faile

Re: [Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree

2019-08-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190819213755.26175-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2 00/68] target/arm: Convert aa32 base isa to decodetree Mess

[Qemu-devel] [PATCH v2] ppc: Fix emulated single to double denormalized conversions

2019-08-19 Thread Paul A. Clarke
From: "Paul A. Clarke" helper_todouble() was not properly converting any denormalized 32 bit float to 64 bit double. Fix-suggested-by: Richard Henderson Signed-off-by: Paul A. Clarke v2: - Splitting patch "ppc: Three floating point fixes"; this is just one part. - Original suggested "fix" was

[Qemu-devel] [PATCH v2 68/68] target/arm: Inline gen_bx_im into callers

2019-08-19 Thread Richard Henderson
There are only two remaining uses of gen_bx_im. In each case, we know the destination mode -- not changing in the case of gen_jmp or changing in the case of trans_BLX_i. Use this to simplify the surrounding code. For trans_BLX_i, use gen_jmp for the actual branch. For gen_jmp, use gen_set_pc_im

[Qemu-devel] [PATCH v2 67/68] target/arm: Clean up disas_thumb_insn

2019-08-19 Thread Richard Henderson
Now that everything is converted, remove the rest of the legacy decode. Signed-off-by: Richard Henderson --- target/arm/translate.c | 27 ++- 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index f8997a8424..b

[Qemu-devel] [PATCH v2 66/68] target/arm: Convert T16, long branches

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 89 +++--- target/arm/t16.decode | 3 ++ 2 files changed, 43 insertions(+), 49 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 51b14d409f..f8997a8424 100644 --- a/t

[Qemu-devel] [PATCH v2 65/68] target/arm: Convert T16, Unconditional branch

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 9 ++--- target/arm/t16.decode | 6 ++ 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 1882057402..51b14d409f 100644 --- a/target/arm/translate.c +++ b/targe

[Qemu-devel] [PATCH v2 58/68] target/arm: Convert T16, nop hints

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 3 +-- target/arm/t16.decode | 17 + 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 176cba2992..67f0202d29 100644 --- a/target/arm/translate.c +++

[Qemu-devel] [PATCH v2 63/68] target/arm: Convert T16, shift immediate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 ++ target/arm/t16.decode | 8 2 files changed, 10 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index dc670c9724..dc3c9049cd 100644 --- a/target/arm/

[Qemu-devel] [PATCH v2 53/68] target/arm: Convert T16 add, compare, move (two high registers)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 49 ++ target/arm/t16.decode | 10 + 2 files changed, 12 insertions(+), 47 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 60bfc943a3..e639059a5a 100644

[Qemu-devel] [PATCH v2 62/68] target/arm: Convert T16, Miscellaneous 16-bit instructions

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 109 - target/arm/t16.decode | 31 2 files changed, 54 insertions(+), 86 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 941266df14..dc670c9724 100

[Qemu-devel] [PATCH v2 52/68] target/arm: Convert T16 branch and exchange

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 64 +++--- target/arm/t16.decode | 10 +++ 2 files changed, 33 insertions(+), 41 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 3a3b113822..60bfc943a3 100644 --

[Qemu-devel] [PATCH v2 61/68] target/arm: Convert T16, Conditional branches, Supervisor call

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 +++--- target/arm/t16.decode | 12 2 files changed, 15 insertions(+), 23 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 5f876290ba..941266df14 100644 --- a/target/

[Qemu-devel] [PATCH v2 51/68] target/arm: Convert T16 one low register and immediate

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 44 ++ target/arm/t16.decode | 11 +++ 2 files changed, 13 insertions(+), 42 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 6f30415371..3a3b113822 10064

[Qemu-devel] [PATCH v2 57/68] target/arm: Convert T16, Reverse bytes

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 18 +++--- target/arm/t16.decode | 9 + 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 368f0ab147..176cba2992 100644 --- a/target/arm/transla

[Qemu-devel] [PATCH v2 50/68] target/arm: Convert T16 add/sub (3 low, 2 low and imm)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 26 ++ target/arm/t16.decode | 16 2 files changed, 18 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d417958b23..6f30415371 100644 --- a/tar

[Qemu-devel] [PATCH v2 47/68] target/arm: Convert T16 load/store (immediate offset)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 94 +++--- target/arm/t16.decode | 33 +++ 2 files changed, 38 insertions(+), 89 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index e19961fb6c..24537fc107 1

Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1

2019-08-19 Thread Josh Kunz via Qemu-devel
Hi all, I have also experienced issues with SIGRTMIN + 1, and am interested in moving this patch forwards. Anything I can do here to help? Would the maintainers prefer myself or Marli re-submit the patch? The Go issue here seems particularly sticky. Even if we update the Go runtime, users may try

[Qemu-devel] [PATCH v2 48/68] target/arm: Convert T16 add pc/sp (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 12 +--- target/arm/t16.decode | 7 +++ 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 24537fc107..2640f50fcf 100644 --- a/target/arm/translate.c +++

[Qemu-devel] [PATCH v2 42/68] target/arm: Simplify disas_thumb2_insn

2019-08-19 Thread Richard Henderson
Fold away all of the cases that now just goto illegal_op, because all of their internal bits are now in decodetree. Signed-off-by: Richard Henderson --- target/arm/translate.c | 79 ++ 1 file changed, 3 insertions(+), 76 deletions(-) diff --git a/target/a

[Qemu-devel] [PATCH v2 60/68] target/arm: Convert T16, push and pop

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 83 ++ target/arm/t16.decode | 10 + 2 files changed, 22 insertions(+), 71 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9e0345adf7..5f876290ba 100644 ---

[Qemu-devel] [PATCH v2 64/68] target/arm: Convert T16, load (literal)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 42 ++ target/arm/t16.decode | 4 2 files changed, 6 insertions(+), 40 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index dc3c9049cd..1882057402 100644 --- a/

[Qemu-devel] [PATCH v2 43/68] target/arm: Simplify disas_arm_insn

2019-08-19 Thread Richard Henderson
Fold away all of the cases that now just goto illegal_op, because all of their internal bits are now in decodetree. Signed-off-by: Richard Henderson --- target/arm/translate.c | 69 ++ 1 file changed, 16 insertions(+), 53 deletions(-) diff --git a/target/

[Qemu-devel] [PATCH v2 38/68] target/arm: Convert Unallocated memory hint

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 target/arm/a32-uncond.decode | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index a30a9bb4e0..9ec6b25c03 100644 --- a/target/arm/translate.

[Qemu-devel] [PATCH v2 59/68] target/arm: Split gen_nop_hint

2019-08-19 Thread Richard Henderson
Now that there all callers pass a constant value, split the switch statement into the individual trans_* functions. Signed-off-by: Richard Henderson --- target/arm/translate.c | 67 +++--- 1 file changed, 24 insertions(+), 43 deletions(-) diff --git a/target/

[Qemu-devel] [PATCH v2 56/68] target/arm: Convert T16, Change processor state

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 85 -- target/arm/t16.decode | 12 ++ 2 files changed, 52 insertions(+), 45 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 414c562fb3..368f0ab147 100644 ---

[Qemu-devel] [PATCH v2 44/68] target/arm: Add skeleton for T16 decodetree

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 6 ++ target/arm/Makefile.objs | 6 ++ target/arm/t16.decode| 20 3 files changed, 32 insertions(+) create mode 100644 target/arm/t16.decode diff --git a/target/arm/translate.c b/target/arm/transl

[Qemu-devel] [PATCH v2 37/68] target/arm: Convert PLI, PLD, PLDW

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 37 +++- target/arm/a32-uncond.decode | 10 ++ 2 files changed, 30 insertions(+), 17 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 46e88d1d17..a30a9bb4e0

[Qemu-devel] [PATCH v2 54/68] target/arm: Convert T16 adjust sp (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 15 ++- target/arm/t16.decode | 9 + 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index e639059a5a..cac3893386 100644 --- a/target/arm/translate.

[Qemu-devel] [PATCH v2 34/68] target/arm: Convert Clear-Exclusive, Barriers

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 122 +++ target/arm/a32-uncond.decode | 10 +++ target/arm/t32.decode| 10 +++ 3 files changed, 73 insertions(+), 69 deletions(-) diff --git a/target/arm/translate.c b/target/arm/transla

[Qemu-devel] [PATCH v2 55/68] target/arm: Convert T16, extract

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 14 +- target/arm/t16.decode | 10 ++ 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index cac3893386..414c562fb3 100644 --- a/target/arm/translate.

[Qemu-devel] [PATCH v2 36/68] target/arm: Convert SETEND

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 22 +- target/arm/a32-uncond.decode | 4 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 928205d993..46e88d1d17 100644 --- a/target/a

[Qemu-devel] [PATCH v2 46/68] target/arm: Convert T16 load/store (register offset)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 51 ++ target/arm/t16.decode | 15 + 2 files changed, 17 insertions(+), 49 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c5769bd42..e19961fb6c 100

[Qemu-devel] [PATCH v2 26/68] target/arm: Convert MOVW, MOVT

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 89 -- target/arm/a32.decode | 6 +++ target/arm/t32.decode | 9 + 3 files changed, 48 insertions(+), 56 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7

[Qemu-devel] [PATCH v2 35/68] target/arm: Convert CPS (privileged)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 87 +++- target/arm/a32-uncond.decode | 3 ++ target/arm/t32.decode| 3 ++ 3 files changed, 42 insertions(+), 51 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c

[Qemu-devel] [PATCH v2 49/68] target/arm: Convert T16 load/store multiple

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 48 -- target/arm/t16.decode | 8 +++ 2 files changed, 17 insertions(+), 39 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 2640f50fcf..d417958b23 100644 --

[Qemu-devel] [PATCH v2 41/68] target/arm: Convert TT

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 87 +- target/arm/t32.decode | 5 ++- 2 files changed, 31 insertions(+), 61 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9a8864e8ff..d1078ca1ec 100644 --- a/

[Qemu-devel] [PATCH v2 45/68] target/arm: Convert T16 data-processing (two low regs)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 152 ++--- target/arm/t16.decode | 36 ++ 2 files changed, 43 insertions(+), 145 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 90d608a2d2..7c5769bd42 1006

[Qemu-devel] [PATCH v2 25/68] target/arm: Convert Signed multiply, signed and unsigned divide

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 463 ++--- target/arm/a32.decode | 22 ++ target/arm/t32.decode | 18 ++ 3 files changed, 247 insertions(+), 256 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d

[Qemu-devel] [PATCH v2 33/68] target/arm: Convert RFE and SRS

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 150 ++- target/arm/a32-uncond.decode | 8 ++ target/arm/t32.decode| 12 +++ 3 files changed, 81 insertions(+), 89 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translat

[Qemu-devel] [PATCH v2 40/68] target/arm: Convert SG

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 51 -- target/arm/t32.decode | 5 - 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 7c05e7006e..9a8864e8ff 100644 ---

[Qemu-devel] [PATCH v2 32/68] target/arm: Convert SVC

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 19 +-- target/arm/a32.decode | 4 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 6b7b3df685..b6d8b7be8c 100644 --- a/target/arm/translate.c

[Qemu-devel] [PATCH v2 19/68] target/arm: Convert T32 ADDW/SUBW

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 24 +--- target/arm/a32.decode | 1 + target/arm/t32.decode | 19 +++ 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index cb6296d

[Qemu-devel] [PATCH v2 39/68] target/arm: Convert Table Branch

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 57 +- target/arm/t32.decode | 8 +- 2 files changed, 41 insertions(+), 24 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 9ec6b25c03..7c05e7006e 100644 ---

[Qemu-devel] [PATCH v2 24/68] target/arm: Convert Packing, unpacking, saturation, and reversal

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 541 ++--- target/arm/a32.decode | 32 +++ target/arm/t32.decode | 37 ++- 3 files changed, 300 insertions(+), 310 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index

[Qemu-devel] [PATCH v2 31/68] target/arm: Convert B, BL, BLX (immediate)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 133 +++ target/arm/a32-uncond.decode | 8 +++ target/arm/a32.decode| 8 +++ target/arm/t32.decode| 81 - 4 files changed, 123 insertions(+), 107 deletions(

[Qemu-devel] [PATCH v2 17/68] target/arm: Convert ERET

2019-08-19 Thread Richard Henderson
Pass the T5 encoding of SUBS PC, LR, #IMM through the normal SUBS path to make it clear exactly what's happening -- we hit ALUExceptionReturn along that path. Signed-off-by: Richard Henderson --- target/arm/translate.c | 58 ++ target/arm/a32.decode | 2

[Qemu-devel] [PATCH v2 30/68] target/arm: Diagnose base == pc for LDM/STM

2019-08-19 Thread Richard Henderson
We have been using store_reg and not store_reg_for_load when writing back a loaded value into the base register. At first glance this is incorrect when base == pc, however that case is UNPREDICTABLE. Signed-off-by: Richard Henderson --- target/arm/translate.c | 9 + 1 file changed, 9 in

[Qemu-devel] [PATCH v2 27/68] target/arm: Convert LDM, STM

2019-08-19 Thread Richard Henderson
This includes a minor bug fix to LDM (user), which requires bit 21 to be 0, which means no writeback. Signed-off-by: Richard Henderson --- target/arm/translate.c | 426 ++--- target/arm/a32.decode | 6 + target/arm/t32.decode | 10 + 3 files changed, 241

[Qemu-devel] [PATCH v2 16/68] target/arm: Convert CLZ

2019-08-19 Thread Richard Henderson
Document our choice about the T32 CONSTRAINED UNPREDICTABLE behaviour. This matches the undocumented choice made by the legacy decoder. Signed-off-by: Richard Henderson --- target/arm/translate.c | 31 +++ target/arm/a32.decode | 4 target/arm/t32.decode | 5

[Qemu-devel] [PATCH v2 23/68] target/arm: Convert Parallel addition and subtraction

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 229 - target/arm/a32.decode | 44 target/arm/t32.decode | 44 3 files changed, 200 insertions(+), 117 deletions(-) diff --git a/target/arm/translate.c b/target/arm/transla

[Qemu-devel] [PATCH v2 28/68] target/arm: Diagnose writeback register in list for LDM for v7

2019-08-19 Thread Richard Henderson
Prior to v7, for the A32 encoding, this operation wrote an UNKNOWN value back to the base register. Starting in v7 this is UNPREDICTABLE. Signed-off-by: Richard Henderson --- target/arm/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target/arm/translate.c b/target/arm/t

[Qemu-devel] [PATCH v2 29/68] target/arm: Diagnose too few registers in list for LDM/STM

2019-08-19 Thread Richard Henderson
This has been a TODO item for quite a while. The minimum bit count for A32 and T16 is 1, and for T32 is 2. Signed-off-by: Richard Henderson --- target/arm/translate.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/target/ar

[Qemu-devel] [PATCH v2 13/68] target/arm: Convert MRS/MSR (banked, register)

2019-08-19 Thread Richard Henderson
The m-profile and a-profile, decodings overlap. Only return false for the case of wrong profile; handle UNDEFINED for permission failure directly. This ensures that we don't accidentally pass an insn that applies to the wrong profile. Signed-off-by: Richard Henderson --- target/arm/translate.c

[Qemu-devel] [PATCH v2 22/68] target/arm: Convert USAD8, USADA8, SBFX, UBFX, BFC, BFI, UDF

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 200 + target/arm/a32.decode | 20 + target/arm/t32.decode | 19 3 files changed, 143 insertions(+), 96 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c ind

[Qemu-devel] [PATCH v2 18/68] target/arm: Convert the rest of A32 Miscelaneous instructions

2019-08-19 Thread Richard Henderson
This fixes an exiting bug with the T5 encoding of SUBS PC, LR, #IMM, in that it may be executed from user mode as with any other encoding of SUBS, not as ERET. Signed-off-by: Richard Henderson --- target/arm/translate.c | 119 + target/arm/a32.decode |

[Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 797 ++--- target/arm/a32.decode | 120 +++ target/arm/t32.decode | 141 3 files changed, 615 insertions(+), 443 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translat

[Qemu-devel] [PATCH v2 12/68] target/arm: Convert MSR (immediate) and hints

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 60 +- target/arm/a32.decode | 25 ++ target/arm/t32.decode | 17 3 files changed, 84 insertions(+), 18 deletions(-) diff --git a/target/arm/translate.c b/target/a

[Qemu-devel] [PATCH v2 15/68] target/arm: Convert BX, BXJ, BLX (register)

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 78 -- target/arm/a32.decode | 7 target/arm/t32.decode | 2 ++ 3 files changed, 47 insertions(+), 40 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index f39

[Qemu-devel] [PATCH v2 21/68] target/arm: Convert Synchronization primitives

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 560 ++--- target/arm/a32.decode | 48 target/arm/t32.decode | 46 3 files changed, 396 insertions(+), 258 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c ind

[Qemu-devel] [PATCH v2 14/68] target/arm: Convert Cyclic Redundancy Check

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 121 +++-- target/arm/a32.decode | 9 +++ target/arm/t32.decode | 7 +++ 3 files changed, 72 insertions(+), 65 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 0

[Qemu-devel] [PATCH v2 11/68] target/arm: Simplify op_smlawx for SMLAW*

2019-08-19 Thread Richard Henderson
By shifting the 16-bit input left by 16, we can align the desired portion of the 48-bit product and use tcg_gen_muls2_i32. Signed-off-by: Richard Henderson --- target/arm/translate.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/arm/translate.c b/tar

[Qemu-devel] [PATCH v2 08/68] target/arm: Convert Saturating addition and subtraction

2019-08-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 75 +++--- target/arm/a32.decode | 10 ++ target/arm/t32.decode | 9 + 3 files changed, 67 insertions(+), 27 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c inde

  1   2   3   4   >