Re: [Qemu-devel] [RFC PATCH] numa: add auto_enable_numa to fix broken check in spapr

2019-08-04 Thread David Gibson
On Mon, Aug 05, 2019 at 11:37:14AM +0800, Tao Xu wrote: > On 8/5/2019 10:58 AM, David Gibson wrote: > > On Mon, Aug 05, 2019 at 08:56:40AM +0800, Tao Xu wrote: > > > On 8/2/2019 2:55 PM, David Gibson wrote: > > > > On Thu, Aug 01, 2019 at 03:52:58PM +0800, Tao Xu wrote: > > > > > Introduce MachineC

Re: [Qemu-devel] [Qemu-riscv] [PATCH] riscv: sifive_e: Correct various SoC IP block sizes

2019-08-04 Thread Bin Meng
On Mon, Aug 5, 2019 at 2:14 PM Chih-Min Chao wrote: > > > > On Sat, Aug 3, 2019 at 8:27 AM Bin Meng wrote: >> >> Some of the SoC IP block sizes are wrong. Correct them according >> to the FE310 manual. >> >> Signed-off-by: Bin Meng >> --- >> >> hw/riscv/sifive_e.c | 6 +++--- >> 1 file changed,

Re: [Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH

2019-08-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190805053146.32326-1-richardw.y...@linux.intel.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bi

Re: [Qemu-devel] [PATCH-4.2 v2 4/5] target/riscv: Update the Hypervisor CSRs to v0.4

2019-08-04 Thread Chih-Min Chao
On Wed, Jul 31, 2019 at 7:40 AM Alistair Francis wrote: > Update the Hypervisor CSR addresses to match the v0.4 spec. > > Signed-off-by: Alistair Francis > --- > target/riscv/cpu_bits.h | 35 ++- > 1 file changed, 18 insertions(+), 17 deletions(-) > > diff --git

Re: [Qemu-devel] [Qemu-riscv] [PATCH] riscv: sifive_e: Correct various SoC IP block sizes

2019-08-04 Thread Chih-Min Chao
On Sat, Aug 3, 2019 at 8:27 AM Bin Meng wrote: > Some of the SoC IP block sizes are wrong. Correct them according > to the FE310 manual. > > Signed-off-by: Bin Meng > --- > > hw/riscv/sifive_e.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/riscv/sifive_e.c b

Re: [Qemu-devel] How to configure QEMU to support APIC virtualization

2019-08-04 Thread Li Qiang
ddm 于2019年8月5日周一 下午1:20写道: > Hi, > > As i know, KVM is based on passthrough host cpu to implement > full-virtualiztion, > if host cpu doesn't support this feature, it's impossible to turn on this > feature by KVM. > Wheher there are another ways in QEMU to emulate this feature,such as > emulate i

[Qemu-devel] [PATCH v2] ivshmem-server: Clean up shmem on shutdown

2019-08-04 Thread Jan Kiszka
From: Jan Kiszka So far, the server leaves the posix shared memory object behind when terminating, requiring the user to explicitly remove it in order to start a new instance. Signed-off-by: Jan Kiszka --- Changes in v2: - respect use_shm_open - also clean up in ivshmem_server_start error pa

[Qemu-devel] [PATCH v3] migration/postcopy: use mis->bh instead of allocating a QEMUBH

2019-08-04 Thread Wei Yang
For migration incoming side, it either quit in precopy or postcopy. It is safe to use the mis->bh for both instead of allocating a dedicated QEMUBH for postcopy. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- v3: rebase on latest upstream v2: fix a typo in change log --- migra

Re: [Qemu-devel] How to configure QEMU to support APIC virtualization

2019-08-04 Thread ddm
Hi, As i know, KVM is based on passthrough host cpu to implement full-virtualiztion, if host cpu doesn't support this feature, it's impossible to turn on this feature by KVM. Wheher there are another ways in QEMU to emulate this feature,such as emulate it based on pure software, not rely on

[Qemu-devel] [PATCH v3] spapr: quantify error messages regarding capability settings

2019-08-04 Thread Daniel Black
Its not immediately obvious how cap-X=Y setting need to be applied to the command line so, for spapr capability hints, this has been clarified to: ..try appending -machine cap-X=Y The wrong value messages have been left as is, as the user has found the right location. Warning messages have bee

Re: [Qemu-devel] How to configure QEMU to support APIC virtualization

2019-08-04 Thread Li Qiang
ddm 于2019年8月5日周一 上午11:55写道: > Hi guys, > > > I have tried via modprobe kvmintel enable_apicv=Y to adjust KVM > parameter, but it doesn't effect, and > cat /sys/module/kvm_intel/parameters/enable_apicv always return "N". > I don't know how to configure KVM or QEMU to support APIC virtualizaion >

Re: [Qemu-devel] [PATCH] libqos: Account for the ctrl queue in virtio-net

2019-08-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190805032400.8054-1-alx...@bu.edu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash make docker

[Qemu-devel] How to configure QEMU to support APIC virtualization

2019-08-04 Thread ddm
Hi guys, I have tried via modprobe kvmintel enable_apicv=Y to adjust KVM parameter, but it doesn't effect, and cat /sys/module/kvm_intel/parameters/enable_apicv always return "N". I don't know how to configure KVM or QEMU to support APIC virtualizaion feature? My host infos are as follows

Re: [Qemu-devel] [RFC PATCH] numa: add auto_enable_numa to fix broken check in spapr

2019-08-04 Thread Tao Xu
On 8/5/2019 10:58 AM, David Gibson wrote: On Mon, Aug 05, 2019 at 08:56:40AM +0800, Tao Xu wrote: On 8/2/2019 2:55 PM, David Gibson wrote: On Thu, Aug 01, 2019 at 03:52:58PM +0800, Tao Xu wrote: Introduce MachineClass::auto_enable_numa for one implicit NUMA node, and enable it to fix broken ch

[Qemu-devel] [PATCH v2] vhost-vsock: report QMP event when set running

2019-08-04 Thread Ning Bo
If a program in host communicates with a vsock device in guest via 'vsock://', but the device is not ready, the 'connect' syscall will block and then timeout after 2 second default.(the timeout is defined in kernel: #define VSOCK_DEFAULT_CONNECT_TIMEOUT (2 * HZ)). We can avoid this case if qemu rep

[Qemu-devel] [PATCH] libqos: Account for the ctrl queue in virtio-net

2019-08-04 Thread Oleinik, Alexander
The number of queues is 2n+1, where n == 1 when multiqueue is disabled Signed-off-by: Alexander Oleinik --- I split this commit out of the fuzz patch-series. tests/libqos/virtio-net.c | 1 + tests/libqos/virtio-net.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/l

[Qemu-devel] [PATCH] qtest: Rename qtest.c:qtest_init()

2019-08-04 Thread Oleinik, Alexander
Both the qtest client, libqtest.c, and server, qtest.c, used the same name for initialization functions which can cause confusion. Signed-off-by: Alexander Oleinik --- Thank you, Thomas Huth for the suggestion. include/sysemu/qtest.h | 2 +- qtest.c| 3 +-- vl.c

Re: [Qemu-devel] [RFC PATCH] numa: add auto_enable_numa to fix broken check in spapr

2019-08-04 Thread David Gibson
On Mon, Aug 05, 2019 at 08:56:40AM +0800, Tao Xu wrote: > On 8/2/2019 2:55 PM, David Gibson wrote: > > On Thu, Aug 01, 2019 at 03:52:58PM +0800, Tao Xu wrote: > > > Introduce MachineClass::auto_enable_numa for one implicit NUMA node, > > > and enable it to fix broken check in spapr_validate_node_me

Re: [Qemu-devel] [Virtio-fs] [PATCH 0/4] virtiofsd: multithreading preparation part 3

2019-08-04 Thread piaojun
Hi Stefan, >From my test, 9p has better bandwidth than virtio as below: --- 9p Test: # mount -t 9p -o trans=virtio,version=9p2000.L,rw,nodev,msize=10,access=client 9pshare /mnt/9pshare # fio -direct=1 -time_based -iodepth=1 -rw=randwrite -ioengine=libaio -bs=1M -size=1G -numjob=1 -run

Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()

2019-08-04 Thread Wei Yang
On Thu, Jul 11, 2019 at 04:08:16PM +0800, Wei Yang wrote: >PostcopyState is already set to ADVISE at the beginning of >loadvm_postcopy_handle_advise(). > >Remove the redundant set. Ping~ > >Signed-off-by: Wei Yang >--- > migration/savevm.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/

Re: [Qemu-devel] [PATCH v3] migration: always initial ram_counters for a new migration

2019-08-04 Thread Wei Yang
On Mon, Aug 05, 2019 at 09:16:24AM +0800, Ivan Ren wrote: >On Mon, Aug 5, 2019 at 8:34 AM Wei Yang wrote: >> >> On Fri, Aug 02, 2019 at 06:18:41PM +0800, Ivan Ren wrote: >> >From: Ivan Ren >> > >> >This patch fix a multifd migration bug in migration speed calculation, this >> >problem can be repr

Re: [Qemu-devel] [PATCH v3] migration: always initial ram_counters for a new migration

2019-08-04 Thread Ivan Ren
On Mon, Aug 5, 2019 at 8:34 AM Wei Yang wrote: > > On Fri, Aug 02, 2019 at 06:18:41PM +0800, Ivan Ren wrote: > >From: Ivan Ren > > > >This patch fix a multifd migration bug in migration speed calculation, this > >problem can be reproduced as follows: > >1. start a vm and give a heavy memory write

[Qemu-devel] [Bug 1838913] Re: Single-step exceptions incorrectly routed to EL1 when ELD is EL2 (TDE = 1) (qemu version 3.1)

2019-08-04 Thread Elouan Appéré
** Summary changed: - Single-step exceptions incorrectly generated and incorrectly routed to EL1 when ELD is EL2 (TDE = 1) (qemu version 3.1) + Single-step exceptions incorrectly routed to EL1 when ELD is EL2 (TDE = 1) (qemu version 3.1) ** Description changed: Hi, I've been encounterin

Re: [Qemu-devel] [RFC PATCH] numa: add auto_enable_numa to fix broken check in spapr

2019-08-04 Thread Tao Xu
On 8/2/2019 2:55 PM, David Gibson wrote: On Thu, Aug 01, 2019 at 03:52:58PM +0800, Tao Xu wrote: Introduce MachineClass::auto_enable_numa for one implicit NUMA node, and enable it to fix broken check in spapr_validate_node_memory(), when spapr_populate_memory() creates a implicit node and info t

Re: [Qemu-devel] [PATCH v3] migration: always initial ram_counters for a new migration

2019-08-04 Thread Wei Yang
On Fri, Aug 02, 2019 at 06:18:41PM +0800, Ivan Ren wrote: >From: Ivan Ren > >This patch fix a multifd migration bug in migration speed calculation, this >problem can be reproduced as follows: >1. start a vm and give a heavy memory write stress to prevent the vm be > successfully migrated to dest

[Qemu-devel] [PATCH v2] hmp: Remove migration capabilities from "info migrate"

2019-08-04 Thread Wei Yang
With the growth of migration capabilities, it is not proper to display them in "info migrate". Users are recommended to use "info migrate_capabiltiies" to list them. Signed-off-by: Wei Yang Suggested-by: Dr. David Alan Gilbert --- v2: * remove capabilities from "info migrate" --- monitor/hmp

[Qemu-devel] [Bug 1838913] [NEW] Single-step exceptions incorrectly generated and incorrectly routed to EL1 when ELD is EL2 (TDE = 1) (qemu version 3.1)

2019-08-04 Thread Elouan Appéré
Public bug reported: Hi, I've been encountering issues with QEMU 3.1 when trying to single-step EL1 code, with ELD = EL2 (MDCR_EL2.TDE = 1). I could test with latest commit in a few hours, if you want. EL1 is Aarch64. These happen as soon as MDSCR_EL1.SS is set to 1 and ERET is executed: 1) Si

[Qemu-devel] [Bug 1830821] Re: Expose ARCH_CAP_MDS_NO in guest

2019-08-04 Thread Rafael David Tinoco
*** This bug is a duplicate of bug 1828495 *** https://bugs.launchpad.net/bugs/1828495 Commit: https://bugs.launchpad.net/intel/+bug/1828495/comments/42 Addresses exactly this bug fix. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH v3 00/14] Multiple simultaneous audio backends

2019-08-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1564925486.git.dirty.ice...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 00/14] Multiple simultaneous audio backends Message-id: cover.156492

[Qemu-devel] [PATCH v3 04/14] audio: add audiodev properties to frontends

2019-08-04 Thread Kővágó, Zoltán
Finally add audiodev= options to audio frontends so users can specify which backend to use when multiple backends exist. Not specifying an audiodev= option currently causes the first audiodev to be used, this is fixed in the next commit. Example usage: -audiodev pa,id=foo -device AC97,audiodev=fo

[Qemu-devel] [PATCH v3 05/14] paaudio: prepare for multiple audiodev

2019-08-04 Thread Kővágó, Zoltán
Have a pool of refcounted connections per server, so if the user creates multiple audiodevs to the same pa server, it will use a single connection. (It will still create different streams, so the user can manage those streams separately in pulseaudio.) Signed-off-by: Kővágó, Zoltán --- audio/pa

[Qemu-devel] [PATCH v3 10/14] audio: do not run each backend in audio_run

2019-08-04 Thread Kővágó, Zoltán
audio_run is called manually by alsa and oss backends when polling. In this case only the requesting backend should be run, not all of them. Signed-off-by: Kővágó, Zoltán Reviewed-by: Marc-André Lureau --- audio/audio_int.h | 2 +- audio/alsaaudio.c | 7 +-- audio/audio.c | 14 +--

[Qemu-devel] [PATCH v3 09/14] audio: remove audio_MIN, audio_MAX

2019-08-04 Thread Kővágó, Zoltán
There's already a MIN and MAX macro in include/qemu/osdep.h, use them instead. Signed-off-by: Kővágó, Zoltán Reviewed-by: Marc-André Lureau --- audio/audio.h | 17 - audio/alsaaudio.c | 6 +++--- audio/audio.c | 20 ++-- audio/cor

[Qemu-devel] [PATCH v3 13/14] audio: use size_t where makes sense

2019-08-04 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.h | 4 +- audio/audio_int.h | 26 +++ audio/audio_template.h | 14 ++-- audio/mixeng.h | 9 +-- audio/rate_template.h | 2 +- include/sysemu/replay.h | 4 +- audio/alsaaudio.c | 26 +++ audio/audio.

[Qemu-devel] [PATCH v3 12/14] audio: remove read and write pcm_ops

2019-08-04 Thread Kővágó, Zoltán
They just called audio_pcm_sw_read/write anyway, so it makes no sense to have them too. (The noaudio's read is the only exception, but it should work with the generic code too.) Signed-off-by: Kővágó, Zoltán --- audio/audio_int.h | 5 - audio/alsaaudio.c | 12 audio/audio.

[Qemu-devel] [PATCH v3 08/14] paaudio: properly disconnect streams in fini_*

2019-08-04 Thread Kővágó, Zoltán
Currently this needs a workaround due to bug #247 in pulseaudio. Signed-off-by: Kővágó, Zoltán Reviewed-by: Marc-André Lureau --- audio/paaudio.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 24d98b344a..1d

[Qemu-devel] [PATCH v3 06/14] audio: audiodev= parameters no longer optional when -audiodev present

2019-08-04 Thread Kővágó, Zoltán
This means you should probably stop using -soundhw (as it doesn't allow you to specify any options) and add the device manually with -device. The exception is pcspk, it's currently not possible to manually add it. To use it with audiodev, use something like this: -audiodev id=foo,... -global i

[Qemu-devel] [PATCH v3 11/14] paaudio: fix playback glitches

2019-08-04 Thread Kővágó, Zoltán
Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up to the emulated system when does it generate the samples. Buffering the samples and sending them from a background t

[Qemu-devel] [PATCH v3 14/14] audio: fix memory leak reported by ASAN

2019-08-04 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- audio/audio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/audio/audio.c b/audio/audio.c index d3c639211d..ebe49f3ca1 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1343,6 +1343,12 @@ static void free_audio_state(AudioState *s) qapi_free

[Qemu-devel] [PATCH v3 07/14] paaudio: do not move stream when sink/source name is specified

2019-08-04 Thread Kővágó, Zoltán
Unless we disable stream moving, pulseaudio can easily move the stream on connect, effectively ignoring the source/sink specified by the user. Signed-off-by: Kővágó, Zoltán Reviewed-by: Marc-André Lureau --- audio/paaudio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/audio/paaudio.

[Qemu-devel] [PATCH v3 02/14] audio: basic support for multi backend audio

2019-08-04 Thread Kővágó, Zoltán
Audio functions no longer access glob_audio_state, instead they get an AudioState as a parameter. This is required in order to support multiple backends. glob_audio_state is also gone, and replaced with a tailq so we can store more than one states. Signed-off-by: Kővágó, Zoltán --- Notes:

[Qemu-devel] [PATCH v3 01/14] audio: reduce glob_audio_state usage

2019-08-04 Thread Kővágó, Zoltán
Remove glob_audio_state from functions, where possible without breaking the API. This means that most static functions in audio.c now take an AudioState pointer instead of implicitly using glob_audio_state. Also included a pointer in SWVoice*, HWVoice* structs, so that functions dealing them can

[Qemu-devel] [PATCH v3 00/14] Multiple simultaneous audio backends

2019-08-04 Thread Kővágó, Zoltán
Hello, This is the v3 of my audio patches. audiodev argument of wavcapture hmp is now mandatory. Regards, Zoltan Kővágó, Zoltán (14): audio: reduce glob_audio_state usage audio: basic support for multi backend audio audio: add audiodev property to vnc and wav_capture audio: add audiode

[Qemu-devel] [PATCH v3 03/14] audio: add audiodev property to vnc and wav_capture

2019-08-04 Thread Kővágó, Zoltán
Signed-off-by: Kővágó, Zoltán --- Notes: Changes from v2: * audiodev parameter for wavcapture is now mandatory. * removed some unnecessary qdict_haskey calls from hmp_wavcapture ui/vnc.h| 2 ++ monitor/misc.c | 22 +++--- ui/vnc.c| 15 +

Re: [Qemu-devel] [FOR 4.1 PATCH] riscv: roms: Fix make rules for building sifive_u bios

2019-08-04 Thread Bin Meng
Hi Alistair/Palmer, On Sat, Aug 3, 2019 at 2:08 PM Bin Meng wrote: > > Currently the make rules are wrongly using qemu/virt opensbi image > for sifive_u machine. Correct it. > > Signed-off-by: Bin Meng > > --- > > roms/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Would yo

Re: [Qemu-devel] [PATCH v2] virtiofsd: fix compile error if 'F_OFD_GETLK' not defined

2019-08-04 Thread piaojun
Hi Daniel and Dave, On 2019/8/2 19:10, Daniel P. Berrangé wrote: > On Fri, Aug 02, 2019 at 11:53:52AM +0100, Dr. David Alan Gilbert wrote: >> * piaojun (piao...@huawei.com) wrote: >>> Use F_GETLK for fcntl when F_OFD_GETLK not defined, such as kernel 3.10. >>> >>> Signed-off-by: Jun Piao >> >> >>