On Tue, Mar 05, 2019 at 16:56:43 +0100, Andrea Bolognani wrote:
> On Tue, 2019-03-05 at 15:38 +0100, Gerd Hoffmann wrote:
[...]
> So I agree neither scenario is exactly perfect, but I still think
> adding non-transitional alias devices would overall be more
> user-friendly.
I don't think it make
On 3/6/19 7:51 AM, Markus Armbruster wrote:
> BALATON Zoltan writes:
>> On Tue, 5 Mar 2019, Philippe Mathieu-Daudé wrote:
>>> On 2/26/19 8:34 PM, Markus Armbruster wrote:
Machine "sam460ex" maps its flash memory at address 0xFFF0. When
no image is supplied, its size is 1MiB (0x1
Thanks a lot for your advice.
Maybe there are two methods to add this option:
1) Firstly, add a vhost-user protocol feature to tell Qemu if hide the
disconnects from the guest. Here we just need the backend such as dpdk
vhostuser to support this option and the feature.
2) Secondly, add a VM XML
BALATON Zoltan writes:
> Hello,
>
> On Tue, 5 Mar 2019, Philippe Mathieu-Daudé wrote:
>> On 2/26/19 8:34 PM, Markus Armbruster wrote:
>>> Machine "sam460ex" maps its flash memory at address 0xFFF0. When
>>> no image is supplied, its size is 1MiB (0x10), and 512KiB of ROM
>>> get mapped o
On Tuesday, March 5, 2019, Philippe Mathieu-Daudé wrote:
> Hi Markus,
>
> this is a rework of your 'mips_malta: Clean up definition of flash memory
> size somewhat' patch:
> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07177.html
>
> Regards,
>
> Phil.
Philippe,
Could you summarize
On 05/03/2019 23.51, Marc-André Lureau wrote:
> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/vhost-user-test.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 4cd0a97f13..9364227ba4 100644
> --- a/tests
Laszlo Ersek writes:
> On 03/04/19 18:50, Markus Armbruster wrote:
>
>> Alright, we can call object_get_class(dev_obj)->unparent(dev_obj).
>>
>> Final complication: if I call just that, the device's reference counter
>> goes down to zero in the middle of device_unparent(), and we use after
>> fr
On 2019/3/5 下午7:21, Peter Maydell wrote:
On Tue, 5 Mar 2019 at 07:12, Jason Wang wrote:
The following changes since commit b6179aaff961627fcb59d7b234297966b81ac726:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20190304'
into staging (2019-03-04 16:50:41 +)
are avai
On Wed, Mar 06, 2019 at 12:48:59AM +0100, BALATON Zoltan wrote:
> On Tue, 5 Mar 2019, Gerd Hoffmann wrote:
> > On Mon, Mar 04, 2019 at 03:58:00PM +0100, BALATON Zoltan wrote:
> > > Hello,
> > >
> > > I'm trying to implement hardware cursor for ati-vga before submitting the
> > > last version of it
The H_CALL H_PAGE_INIT can be used to zero or copy a page of guest
memory. Enable the in-kernel H_PAGE_INIT handler.
The in-kernel handler takes half the time to complete compared to
handling the H_CALL in userspace.
Signed-off-by: Suraj Jitindar Singh
---
hw/ppc/spapr.c | 3 +++
target/p
Philippe Mathieu-Daudé writes:
> On 3/5/19 6:25 PM, Peter Maydell wrote:
>> On Tue, 5 Mar 2019 at 17:21, Philippe Mathieu-Daudé
>> wrote:
>>> But I'd recommend changing/fixing the sector size during the next dev
>>> cycle, so we have more time for testing.
>>
>> Nobody in the upstream dev comm
Eric Blake writes:
> On 3/5/19 12:15 PM, Dr. David Alan Gilbert (git) wrote:
>> From: Juan Quintela
>>
>> It will be used to store the uri parameters. We want this only for
>> tcp, so we don't set it for other uris. We need it to know what port
>> is migration running.
>>
>> Reviewed-by: Dr. Da
Patchew URL: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190306031221.GA53@03612eec87fc
Subject: [Qemu-devel] [PATCH v3 0/10] qemu-binfmt-conf.sh
=== TEST
Rename CPUS to TARGETS, and support QEMU_TARGETS environment variable.
This does not break backward compatibility, because it is just a placeholder.
Consistently with 'path', 'suffix', 'persistent' and 'credential',
provide an environment variable to set the list of target architectures.
The suppo
Reduce indentation to better use available space.
Add list of supported environment variables and their default values.
Signed-off-by: Unai Martinez-Corral
---
scripts/qemu-binfmt-conf.sh | 61 -
1 file changed, 33 insertions(+), 28 deletions(-)
diff --git a
Reorder how the options are presented to the user. Move 'systemd'
and 'debian' to the end, so that the latter is close to the additional
comments and example commands about it. Make the order in the prototype
consistent with the list where each option is explained.
Signed-off-by: Unai Martinez-Cor
This is a partial implementation.
Allows to remove a single or a list of already registered binfmt
interpreters. If is a list, it must be comma-separated.
Valid values are those in qemu_target_list. If is 'ALL', all
the existing 'qemu-*' interpreters are removed.
This is partial because 'debian
Allow to set 'path' or 'suffix' through environment variables,
consistently with 'persistent' and 'credential'.
Signed-off-by: Unai Martinez-Corral
---
scripts/qemu-binfmt-conf.sh | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qem
This breaks brackward compatibility.
Option '--systemd CPU' allows to register binfmt interpreters for a
single target architecture or for 'ALL' (of them). This patch
generalizes the approach to support it in any mode (default, '--debian'
or '--systemd'). To do so, option 'systemd' is changed to b
This breaks backward compatibility.
Options 'qemu-path' and 'qemu-suffix' have the 'qemu-' prefix, which is
not present in other option names ('debian', 'systemd', 'persistent',
'credential'...). In order to keep consistency, the prefix is removed.
Signed-off-by: Unai Martinez-Corral
---
script
Allow to set options '--persistent' and/or '--credential' through
environment variables. If not defined, defaults are used ('no').
Anyway, command-line arguments have priority over environment variables.
Signed-off-by: Unai Martinez-Corral
---
scripts/qemu-binfmt-conf.sh | 18 +++---
This patch breaks backward compatibility.
Both '--persistent' and '--credential' default to 'no'. Hence, '-p no'
or '-c no' are reduntant. Overall, accepting an argument might be
misleading because options are, indeed, boolean. This patch makes both
options boolean in getopt, so if any of them is
Spaces are added before '; then', for consistency.
All the tests are prefixed with 'x', in order to avoid risky comparisons
(i.e. a user deliberately trying to provoke a syntax error).
Signed-off-by: Unai Martinez-Corral
---
scripts/qemu-binfmt-conf.sh | 14 +++---
1 file changed, 7 ins
On Tue, Mar 05, 2019 at 04:10:20PM +, Peter Maydell wrote:
> On Tue, 26 Feb 2019 at 04:53, David Gibson
> wrote:
> >
> > From: Greg Kurz
>
>
> Hi -- Coverity points out a possible overflow here (CID 1399145):
>
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 00eb3b643c..b92deee
On Thu, Feb 28, 2019 at 05:04:37PM -0300, Maxiwell S. Garcia wrote:
> This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest
> to collect host information. It is disabled by default to avoid unwanted
> information leakage. To enable it, use:
>
> ‘-M pseries,host-serial={passthrough
Spaces are added before '; then', for consistency.
All the tests are prefixed with 'x', in order to avoid risky comparisons
(i.e. a user deliberately trying to provoke a syntax error).
Signed-off-by: Unai Martinez-Corral
---
scripts/qemu-binfmt-conf.sh | 14 +++---
1 file changed, 7 ins
Hi,
This series reworks qemu-binfmt-conf.sh:
* Argument from option '--systemd' is generalized to , and it is
accepted for any mode (default, debian or systemd). It can be a single target
arch or a list of them. Valid separators are space, tab, newline and comma.
Keywords 'ALL' and 'NONE'
ed48c59875b6 "virtio-balloon: Safely handle BALLOON_PAGE_SIZE < host
page size" introduced a new temporary data structure which tracks 4kiB
chunks which have been inserted into the balloon by the guest but
don't yet form a full host page which we can discard.
Unfortunately, I had a thinko and allo
A rework to the virtio-balloon driver was recently merged as
f6deb6d..ee1cd00. This series addresses several minor issues in the
new code.
Changes since RFC:
* Add a fix for the g_malloc/free mismatch reported by Coverity
* Remove the not-really-useful hint-on-deflate flag
David Gibson (3):
This fixes a balloon bug with a nasty consequence - potentially
corrupting guest memory - but which is extremely unlikely to be
triggered in practice.
The balloon always works in 4kiB units, but the host could have a
larger page size on certain platforms. Since ed48c59 "virtio-balloon:
Safely han
Prior to f6deb6d9 "virtio-balloon: Remove unnecessary MADV_WILLNEED on
deflate", the balloon device issued an madvise() MADV_WILLNEED on
pages removed from the balloon. That would hint to the host kernel
that the pages were likely to be needed by the guest in the near
future.
It's unclear if this
On Tue, Mar 05, 2019 at 07:14:09PM -0500, Michael S. Tsirkin wrote:
> On Wed, Mar 06, 2019 at 10:35:12AM +1100, David Gibson wrote:
> > On Tue, Mar 05, 2019 at 09:41:34AM -0500, Michael S. Tsirkin wrote:
> > > On Tue, Mar 05, 2019 at 04:03:00PM +1100, David Gibson wrote:
> > > > On Mon, Mar 04, 201
On 03/05/2019 10:50 PM, Dr. David Alan Gilbert wrote:
* Wei Wang (wei.w.w...@intel.com) wrote:
The new feature enables the virtio-balloon device to receive hints of
guest free pages from the free page vq.
A notifier is registered to the migration precopy notifier chain. The
notifier calls free_
Patchew URL:
https://patchew.org/QEMU/20190305172139.32662-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190305172139.32662-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v3 00/1
Patchew URL:
https://patchew.org/QEMU/20190305172139.32662-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190305172139.32662-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v3 00/1
On 3/5/19 8:28 AM, Philippe Mathieu-Daudé wrote:
> Markus Armbruster (1):
> mips_malta: Clean up definition of flash memory size somewhat
>
> Philippe Mathieu-Daudé (4):
> hw/mips/malta: Fix the DEBUG_BOARD_INIT code
> hw/mips/malta: Remove fl_sectors variable (used one single time)
> hw/m
On 3/5/19 8:28 AM, Philippe Mathieu-Daudé wrote:
> +
> +if (blk_getlength(pflash_blk) != FLASH_SIZE) {
> +error_report("Malta CoreLV card expects a bios of 4MB");
> +exit(1);
> +}
Indentation is off, somehow. Tabs or extra spaces?
r~
On 2019/3/5 21:09, Gerd Hoffmann wrote:
> vnc aborts display update jobs on video mode switches and page flips.
> That can cause vnc update stalls in case an unfinished vnc job gets
> aborted. The vnc client will never receive the requested update then.
> Fix that by copying the state from job_upd
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Don't hard-code the QEMU version number into conf.py. Instead
> we either pass it to sphinx-build on the command line, or
> (if doing a standalone Sphinx run in a readthedocs.org setup)
> extract it from the VERSION file.
>
> Signed-off-by: Peter Maydell
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Add support to our configure and makefile machinery for building
> our rST docs into HTML files.
>
> Building the documentation now requires that sphinx-build is
> available; this seems better than allowing half the docs to
> be built if it is not present
On 3/5/19 9:21 AM, Peter Maydell wrote:
> sphinx-build complains about using :option: to mark up option
> flags that it doesn't know about (because they were not defined
> using the "option::" directive):
> docs/pr-manager.rst:68: WARNING: unknown option: -d
>
> Suppress these warnings. This way w
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Convert the memory API documentation from plain text
> to restructured text format.
>
> This is a very minimal conversion: all I had to change
> was to mark up the ASCII art parts as Sphinx expects
> for 'literal blocks', and fix up the bulleted lists
> (S
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Commit the initial Sphinx conf.py and skeleton index.rst as
> generated with sphinx-quickstart. We'll update these to
> add QEMU-specific tweaks in subsequent commits.
>
> Signed-off-by: Peter Maydell
> Acked-by: Aleksandar Markovic
> Message-id: 2019022
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Sphinx defaults to including all the rST source files
> in the HTML build and making each HTML page link to the
> source file. Disable that.
>
> Signed-off-by: Peter Maydell
> Reviewed-by: Alex Bennée
> Acked-by: Aleksandar Markovic
> Message-id: 201902
On 3/5/19 9:21 AM, Peter Maydell wrote:
> We don't yet have any custom static files, so disable this
> config file setting to avoid a warning from sphinx about
> not being able to find the directory.
>
> Signed-off-by: Peter Maydell
> Reviewed-by: Alex Bennée
> Acked-by: Aleksandar Markovic
> M
On 3/5/19 9:21 AM, Peter Maydell wrote:
> + if test -d .git; then \
As mentioned somewhere else this week, test -e, since .git may be a file.
Otherwise,
Reviewed-by: Richard Henderson
r~
On 3/5/19 9:21 AM, Peter Maydell wrote:
> Add a MAINTAINERS entry for Sphinx documentation infrastructure:
> this doesn't cover actual content, only the machinery we use to
> build the docs.
>
> Signed-off-by: Peter Maydell
> ---
> MAINTAINERS | 6 ++
> 1 file changed, 6 insertions(+)
Revie
On 3/5/19 9:21 AM, Peter Maydell wrote:
> sphinx-build complains:
>
> docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation.
> docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation.
> docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line;
> unexpected unindent.
> docs/cpu-hotp
On Mon, Mar 04, 2019 at 01:26:27PM +0300, Andrew Randrianasulu wrote:
> В сообщении от Monday 04 March 2019 05:51:27 BALATON Zoltan написал(а):
> > On Mon, 4 Mar 2019, Andrew Randrianasulu wrote:
> > > From: Amit Singh Tomar
> > >
> > > Original commit message:
> > > This patch adds an emulation m
hi Alex
we still have some opens as below. could you kindly help review on that? :)
Thanks
Yan
On Mon, Feb 25, 2019 at 10:22:56AM +0800, Zhao Yan wrote:
> On Thu, Feb 21, 2019 at 01:40:51PM -0700, Alex Williamson wrote:
> > Hi Yan,
> >
> > Thanks for working on this!
> >
> > On Tue, 19 Feb 2019
On Wed, Mar 06, 2019 at 10:35:12AM +1100, David Gibson wrote:
> On Tue, Mar 05, 2019 at 09:41:34AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Mar 05, 2019 at 04:03:00PM +1100, David Gibson wrote:
> > > On Mon, Mar 04, 2019 at 09:29:24PM -0500, Michael S. Tsirkin wrote:
> > > > On Tue, Mar 05, 201
On 3/5/19 6:43 PM, John Snow wrote:
++ This series relies on [Qemu-devel] [PATCH v3 0/7] bitmaps: add
inconsistent bit, you can apply it on top of those patches, or you can
use my github staging branch as a basis:
https://github.com/jnsnow/qemu/tree/bitmaps
> This series aims to enable block
On 3/1/19 2:15 PM, John Snow wrote:
> Allow QEMU to read in bitmaps that have the in-use bit set, for the
> purposes of allowing users to delete those bitmaps.
>
> This is chosen in preference to a hard error on load to minimize
> impact for a non-critical error, but to force the user or manage
On Tue, Mar 05, 2019 at 12:02:30PM -0500, Michael S. Tsirkin wrote:
> On Tue, Mar 05, 2019 at 05:10:42PM +0100, David Hildenbrand wrote:
> > On 05.03.19 17:03, Michael S. Tsirkin wrote:
> > > On Tue, Mar 05, 2019 at 03:15:38PM +0100, David Hildenbrand wrote:
> > >> On 05.03.19 06:11, David Gibson w
On Tue, Mar 05, 2019 at 09:41:34AM -0500, Michael S. Tsirkin wrote:
> On Tue, Mar 05, 2019 at 04:03:00PM +1100, David Gibson wrote:
> > On Mon, Mar 04, 2019 at 09:29:24PM -0500, Michael S. Tsirkin wrote:
> > > On Tue, Mar 05, 2019 at 11:52:08AM +1100, David Gibson wrote:
> > > > On Thu, Feb 28, 201
On Tue, Mar 05, 2019 at 04:06:54PM +, Peter Maydell wrote:
> On Fri, 22 Feb 2019 at 02:41, Michael S. Tsirkin wrote:
> >
> > From: David Gibson
> >
> > The virtio-balloon always works in units of 4kiB (BALLOON_PAGE_SIZE), but
> > we can only actually discard memory in units of the host page s
On Tue, Mar 05, 2019 at 03:15:38PM +0100, David Hildenbrand wrote:
> On 05.03.19 06:11, David Gibson wrote:
> > Prior to f6deb6d9 "virtio-balloon: Remove unnecessary MADV_WILLNEED on
> > deflate", the balloon device issued an madvise() MADV_WILLNEED on
> > pages removed from the balloon. That woul
Test that we can actually resize qcow2 images with persistent bitmaps
correctly. Throw some other goofy stuff at the test while we're at it,
like adding bitmaps of different granularities and at different times.
Signed-off-by: John Snow
---
tests/qemu-iotests/246 | 114 ++
tests/
On Tue, 5 Mar 2019, Gerd Hoffmann wrote:
On Mon, Mar 04, 2019 at 03:58:00PM +0100, BALATON Zoltan wrote:
Hello,
I'm trying to implement hardware cursor for ati-vga before submitting the
last version of it before the freeze.
Use dpy_cursor_define().
I've done that but it's not working very w
Usually, we only write out bitmaps when we're about to close out the file,
so we always remove the bitmaps after to make it easier to determine the
source of truth for migration purposes.
However, there may be times we want to flush bitmap data more aggressively,
like after a truncate event where
We tend to remove bitmaps when we flush them to disk, but it's not appropriate
in all cases. let the reopen mechanism use the lighter weight flush instead of
the heavier store.
Signed-off-by: John Snow
---
block/qcow2-bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/b
This series aims to enable block resizes when persistent bitmaps are
in use. The basic approach here is to recognize that we now load all
persistent bitmaps in memory, and so we can rely on in-memory resizes
and then flush the changed metadata back to disk.
One part that is potentially now quite s
If we were to allow resizes, the length check that happens when we load
bitmap headers from disk when we read or store bitmaps would begin to
fail:
Imagine the circumstance where we've resized bitmaps in memory, but they still
have the old values on-disk. The lengths will no longer match bdrv_getl
Since we now load all bitmaps into memory anyway, we can just truncate them
in-memory and then flush them back to disk. Just in case, we will still check
and enforce that this shortcut is valid -- i.e. that any bitmap described
on-disk is indeed in-memory and can be modified.
If there are any inco
Add a vhost-user input backend example, based on virtio-input-host
device. It takes an evdev path as argument, and can be associated with
a vhost-user-input device via a UNIX socket:
$ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock
$ qemu ... -chardev socket,id=vuic,path=/tmp/vui.sock
-
Ask vhost user input backend the list of virtio_input_config.
Signed-off-by: Marc-André Lureau
Reviewed-by: Gerd Hoffmann
---
contrib/libvhost-user/libvhost-user.h | 1 +
include/hw/virtio/vhost-backend.h | 4 ++
hw/virtio/vhost-user.c| 60 +++
docs
Create a vhost-user-backend object that holds a connection to a
vhost-user backend and can be referenced from virtio devices that
support it. See later patches for input & gpu usage.
Signed-off-by: Marc-André Lureau
---
include/sysemu/vhost-user-backend.h | 57
backends/vhost-user.c
Simplify the creation of FD sources for other users. This is just
convenience to avoid duplicating similar code elsewhere.
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user-glib.h | 3 +++
contrib/libvhost-user/libvhost-user-glib.c | 11 ++-
2 files changed, 9 ins
Add a new virtio-input device, which connects to a vhost-user
backend.
vhost-user-input is similar to virtio-input-host, it is wrapped by
vhost-user-input-pci. Instead of reading configuration directly from
an input device / evdev, it reads it over vhost-user protocol with
INPUT_GET_CONFIG message
Since commit 2566378d6d13bf4d28c7770bdbda5f7682594bbe, libvhost-user
no longer panics on disconnect (rc == 0), and instead silently ignores
an invalid VHOST_USER_NONE message.
Without extra work from the API user, this will simply busy-loop on
HUP events. The obvious thing to do is to exit(0) inst
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
hw/virtio/vhost-user.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 0164060b2b..3b09c40578 100644
--- a/hw/virtio/vhost-user.c
++
vhost-user-input will make use of this function to undo some queue pop
in case the virtio queue does not have enough room.
Signed-off-by: Marc-André Lureau
---
contrib/libvhost-user/libvhost-user.h | 14 ++
contrib/libvhost-user/libvhost-user.c | 16
2 files changed,
Split vhost_user_read(), so only header can be read with
vhost_user_read_header().
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
---
hw/virtio/vhost-user.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/hw/virtio/vhost-user.c
Take a VhostUserState* that can be pre-allocated, and initialize it
with the associated chardev.
Signed-off-by: Marc-André Lureau
Reviewed-by: Tiwei Bie
---
include/hw/virtio/vhost-user-blk.h | 2 +-
include/hw/virtio/vhost-user-scsi.h | 2 +-
include/hw/virtio/vhost-user.h | 2 +-
bac
As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
review, let's define a common set of backend conventions to help with
management layer implementation, and interoperability.
Signed-off-by: Marc-André Lureau
Reviewed-by: Daniel P. Berrangé
---
MAINTAINERS | 1
Now that the VhostUserMsg.request field is used for both master &
slave requests, since commit d84599f56c820d8c1ac9928a76500dcdfbbf194d:
contrib/libvhost-user/libvhost-user.c:953:20: error: implicit conversion from
enumeration type 'enum VhostUserSlaveRequest' to different enumeration type
'Vhos
Hi,
This series is based on previously discussed "[PATCH v4 00/29]
vhost-user for input & GPU" and "vhost-user: define conventions for
vhost-user backends" work. The GPU part is left off for now.
This series introduces a "vhost-user-backend": an helper object to be
used by vhost-user devices to e
Spotted by ASAN.
Signed-off-by: Marc-André Lureau
---
tests/vhost-user-test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
index 4cd0a97f13..9364227ba4 100644
--- a/tests/vhost-user-test.c
+++ b/tests/vhost-user-test.c
@@ -588,6 +588,7
Hello,
On Tue, 5 Mar 2019, Philippe Mathieu-Daudé wrote:
On 2/26/19 8:34 PM, Markus Armbruster wrote:
Machine "sam460ex" maps its flash memory at address 0xFFF0. When
no image is supplied, its size is 1MiB (0x10), and 512KiB of ROM
get mapped on top of its second half. Else, it's the
On 3/4/19 11:43 AM, Peter Maydell wrote:
On Mon, 4 Mar 2019 at 15:47, Stefan Berger wrote:
The 1st patch in this series fixes a bug in the TPM TIS emulator that
skipped a locality when resetting the seize flag when a higher locality
seized access from a lower locality. The 2nd patch converts de
From: Liam Merwick
This patch is rev 37b55d67c0 from master.
In tpm_tis_mmio_write() if the requesting locality is seizing
access, any seizure by a lower locality is cancelled. However the
loop doing the seizure had an off-by-one error and the locality
immediately preceding the requesting local
Hi Murilo,
On Tue, Mar 05, 2019 at 04:39:38PM -0300, Murilo Opsfelder Araujo wrote:
> Hi, Maxiwell.
>
> On Thu, Feb 28, 2019 at 05:04:37PM -0300, Maxiwell S. Garcia wrote:
> > This adds a handler for ibm,get-vpd RTAS calls, allowing pseries guest
> > to collect host information. It is disabled by
On 3/5/19 6:25 PM, Peter Maydell wrote:
> On Tue, 5 Mar 2019 at 17:21, Philippe Mathieu-Daudé wrote:
>> But I'd recommend changing/fixing the sector size during the next dev
>> cycle, so we have more time for testing.
>
> Nobody in the upstream dev community is using or testing this board.
Well
On 3/5/19 9:38 AM, Mark Cave-Ayland wrote:
> It's really that this is a stepping stone to patch 7 where you end up with
> this:
>
> static inline int vsrh_offset(int i)
> {
> return offsetof(CPUPPCState, vsr[i].VsrD(0));
> }
>
> static inline int vsrl_offset(int i)
> {
> return offsetof(
On 3/5/19 9:16 AM, Mark Cave-Ayland wrote:
> Really though I don't feel too strongly about this, so would you like me to
> rename it avr_full_offset() to match the existing vsr_full_offset()?
I do think matching the names makes things clearer.
r~
On Tue, 5 Mar 2019 at 17:07, Markus Armbruster wrote:
>
> The following changes since commit 0984a157c1c053394adbf64ed7de97f1aebe6a2d:
>
> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
> staging (2019-03-05 09:33:20 +)
>
> are available in the Git repository at:
On 03/05/19 16:33, Markus Armbruster wrote:
> You neglected to cc: the maintainers of hw/block, I fixed that for you.
>
> Alex Bennée writes:
>
>> It looks like there was going to be code to check we had some sort of
>> alignment so lets replace it with an actual check. This is a bit more
>> use
Hi Laszlo,
On 12/10/18 5:02 PM, Laszlo Ersek wrote:
> On 12/07/18 18:03, Philippe Mathieu-Daudé wrote:
>> Since af1f60a4022, the fw_cfg field is always created in machvirt_init().
>> There is no need to null check it.
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> hw/arm/virt.c | 4
>
On Wed, Feb 27, 2019 at 11:30:05AM +0100, Marc-André Lureau wrote:
> Hi,
>
> This series is based on previously discussed "[PATCH v4 00/29]
> vhost-user for input & GPU" and "vhost-user: define conventions for
> vhost-user backends" work. The GPU part is left off for now.
>
> This series introduc
On 3/5/19 9:08 PM, Eric Blake wrote:
> On 3/5/19 1:45 PM, Thomas Huth wrote:
>
>>> If there are special instructions for what to do with
>>> build trees over the transition to kconfig, the pullreq
>>> cover letter would be a good place to mention them :-)
>>
>> I think you've got to do a "make dis
2019/3/5 17:57, Eric Blake:
> I don't have a strong preference between the two forms - so this is your
> chance to assert your creative liberty. But I don't know enough about
> binfmt_misc to know if the newline matters. I'm just reviewing on the
> basis of shell portability, and hope that other re
On 3/5/19 1:45 PM, Thomas Huth wrote:
If there are special instructions for what to do with
build trees over the transition to kconfig, the pullreq
cover letter would be a good place to mention them :-)
I think you've got to do a "make distclean" inbetween... that's the old
problem when a defa
Code was assigning DFIFO, but didn't return the value to users.
Signed-off-by: Sven Schnelle
---
hw/scsi/lsi53c895a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index 7d66d1a870..3783779da6 100644
--- a/hw/scsi/lsi53c895a.c
+++
This makes the code easier to read - no functional change.
Signed-off-by: Sven Schnelle
Reviewed-by: Philippe Mathieu-Daudé
---
hw/scsi/lsi53c895a.c | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/ls
On 3/5/19 1:36 PM, Unai Martinez Corral wrote:
2019/3/5 17:57, Eric Blake:
You are correct that 'printf -1' is likely to fail, 'printf -- -1' is
portable but unusual, and 'printf %s\\n -1' is identical to the common
(but non-portable) behavior of 'echo -1'. Is the newline important?
In this ca
This makes the code easier to read - no functional change.
Signed-off-by: Sven Schnelle
Reviewed-by: Philippe Mathieu-Daudé
---
hw/scsi/lsi53c895a.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
inde
Instead of using the open-coded versions, use the helper already
present as this makes the code easier to read and less error-prone.
Signed-off-by: Sven Schnelle
Reviewed-by: Philippe Mathieu-Daudé
---
hw/scsi/lsi53c895a.c | 24
1 file changed, 4 insertions(+), 20 delet
Hi,
this series contains a few cosmetic cleanups and one small bugfix for the
LSI53C895 emulation.
Regards
Sven
Sven Schnelle (5):
lsi: use ldn_le_p()/stn_le_p()
lsi: use enum type for s->waiting
lsi: use enum type for s->msg_action
lsi: use SCSI phase names instead of numbers in trace
This makes trace logs much easier to read, especially for
people who are not fluent in SCSI.
Signed-off-by: Sven Schnelle
Reviewed-by: Philippe Mathieu-Daudé
---
hw/scsi/lsi53c895a.c | 31 +++
hw/scsi/trace-events | 6 +++---
2 files changed, 26 insertions(+), 11 de
On 3/5/19 1:32 PM, Unai Martinez Corral wrote:
Signed-off-by: Unai Martinez-Corral
Welcome to the qemu community, and I hope you find your experience with
your first patch pleasant.
Long subject line, I'd trim ' (no arg)'. The commit body itself should
go into the "why" the patch is useful
1 - 100 of 342 matches
Mail list logo
