Re: [Qemu-devel] [PATCH 05/16] hw/devices: Move Blizzard declarations into a new header

2019-01-06 Thread Philippe Mathieu-Daudé
On 1/7/19 7:39 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS | 1 + >> hw/arm/nseries.c | 1 + >> hw/display/blizzard.c | 2 +- >> include/hw/devices.h |

Re: [Qemu-devel] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition

2019-01-06 Thread Philippe Mathieu-Daudé
On 1/7/19 7:32 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Introduced in 64b40bc54a9, this definition is no more used since >> a0b753dfd39. Remove it. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> include/hw/devices.h | 1 - >> 1 file changed, 1 deletion

Re: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-06 Thread Nick Hudson
On 06/01/2019 22:56, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/d19529f5-841e-ea06-fe7d-86ccfd528...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: The files being touched have lots of coding style probl

Re: [Qemu-devel] [PATCH 15/16] hw/devices: Move SMSC 91C111 declaration into a new header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > This commit finally deletes "hw/devices.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/gumstix.c | 2 +- > hw/arm/integratorcp.c | 2 +- > hw/arm/mainstone.c | 2 +- > hw/arm/realview.c | 2 +-

Re: [Qemu-devel] [PATCH 13/16] hw/net/ne2000-isa: Add guards to the header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/net/ne2000-isa.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/hw/net/ne2000-isa.h b/include/hw/net/ne2000-isa.h > index ff2bed9c95..527337c454 100644 > --- a/in

Re: [Qemu-devel] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/kzm.c | 2 +- > hw/arm/mps2.c| 2 +- > hw/arm/realview.c| 1 + > hw/arm/vexpress.c| 2 +- > hw/net/lan9118.c | 2 +- > include/hw/devices.

Re: [Qemu-devel] [PATCH 11/16] typedefs: Remove PS2State

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > PS2State is only used in "hw/input/ps2.h", there is no > need to expose it via "qemu/typedefs.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/input/ps2.h | 2 ++ > include/qemu/typedefs.h | 1 - > 2 files changed, 2 insertion

Re: [Qemu-devel] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Since uWireSlave is only used in this new header, there is no > need to expose it via "qemu/typedefs.h". > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > hw/arm/nseries.c| 2 +- > hw

Re: [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f571b29077..03872552ee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -640,6 +640,7 @@

Re: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2019-01-06 Thread Laurent Vivier
Le 07/01/2019 à 06:50, Tom Deseyn a écrit : > Hi Laurent, > > Can you please take a look at the updated patch? Should I add braces for > code-style? Yes, new code must follow code-style. Older is only updated when we modify it for something else. Thanks, Laurent

Re: [Qemu-devel] [PATCH 06/16] hw/devices: Move CBus declarations into a new header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS| 1 + > hw/arm/nseries.c | 1 + > hw/misc/cbus.c | 2 +- > include/hw/devices.h | 14 -- > include/hw/misc/cbus.h | 31

Re: [Qemu-devel] [PATCH 00/10] spapr: introduce the 'dual' interrupt mode XICS/XIVE

2019-01-06 Thread Cédric Le Goater
On 1/7/19 5:48 AM, David Gibson wrote: > On Wed, Jan 02, 2019 at 06:57:33AM +0100, Cédric Le Goater wrote: >> Hello, >> >> This series adds a new sPAPR IRQ backend called 'dual' which supports >> both interrupt mode, the XIVE native exploitation mode and the legacy >> compatibility mode (XICS). >>

Re: [Qemu-devel] [PATCH 01/16] hw/arm/aspeed: Use TYPE_TMP105/TYPE_PCA9552 instead of hardcoded string

2019-01-06 Thread Cédric Le Goater
On 1/4/19 6:58 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/arm/aspeed.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index 515898

Re: [Qemu-devel] [PATCH 05/16] hw/devices: Move Blizzard declarations into a new header

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > hw/arm/nseries.c | 1 + > hw/display/blizzard.c | 2 +- > include/hw/devices.h | 7 --- > include/hw/display/blizzard.h |

Re: [Qemu-devel] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition

2019-01-06 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Introduced in 64b40bc54a9, this definition is no more used since > a0b753dfd39. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/devices.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/devices.h b/i

Re: [Qemu-devel] [PATCH v3] Add getsockopt for settable SOL_IPV6 options

2019-01-06 Thread Tom Deseyn
Hi Laurent, Can you please take a look at the updated patch? Should I add braces for code-style? Thanks, Tom On Fri, Dec 14, 2018 at 4:43 PM wrote: > From: Tom Deseyn > > Thank you for reviewing Laurant. > Sorry for missing history, I'm not used to sending patches via mail. > I got an email

Re: [Qemu-devel] [PATCH 00/10] spapr: introduce the 'dual' interrupt mode XICS/XIVE

2019-01-06 Thread David Gibson
On Wed, Jan 02, 2019 at 06:57:33AM +0100, Cédric Le Goater wrote: > Hello, > > This series adds a new sPAPR IRQ backend called 'dual' which supports > both interrupt mode, the XIVE native exploitation mode and the legacy > compatibility mode (XICS). > > The machine operates with the legacy mode b

Re: [Qemu-devel] [PATCH 08/10] ppc/xics: allow ICSState to have an offset 0

2019-01-06 Thread David Gibson
On Thu, Jan 03, 2019 at 06:45:25PM +0100, Cédric Le Goater wrote: > On 1/3/19 5:33 AM, David Gibson wrote: > > On Wed, Jan 02, 2019 at 06:57:41AM +0100, Cédric Le Goater wrote: > >> commit 15ed653fa49a ("ppc/xics: An ICS with offset 0 is assumed to be > >> uninitialized") introduced an extra check

Re: [Qemu-devel] Why one virtio-pci device has two different DeviceState?

2019-01-06 Thread Jintack Lim
On Sat, Jan 5, 2019 at 10:42 AM Peter Maydell wrote: > > On Fri, 4 Jan 2019 at 20:23, Jintack Lim wrote: > > I was wondering why one virtio-pci device has two different > > DeviceState? - one directly from VirtIOPCIProxy and the other from > > VirtIO such as VirtIONet. As an example, they are den

Re: [Qemu-devel] [PATCH v2] spapr: return from post_load method when RTC import fails

2019-01-06 Thread David Gibson
On Fri, Jan 04, 2019 at 02:30:50PM +0100, Cédric Le Goater wrote: > The error value can be squashed by the section handling radix migration. > Simply bail out if an error occurs when the RTC offset is imported. > > This fixes the Coverity issue CID 1398591. > > Fixes: d39c90f5f3ae ("spapr: Fix mi

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-06 Thread David Gibson
On Fri, Jan 04, 2019 at 07:12:08PM +0100, Philippe Mathieu-Daudé wrote: > Many functions have documentation before the implementation in > cutils.c. Since we expect documentation around the prototype > declaration in headers, move the comments in cutils.h. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v2 1/3] util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"

2019-01-06 Thread David Gibson
On Fri, Jan 04, 2019 at 07:12:06PM +0100, Philippe Mathieu-Daudé wrote: > The size_to_str() function doesn't need to be in a generic header. > > It makes also sens to find this function in the same header than > the opposite string to size functions: qemu_strtosz*(). > Note than this function is a

Re: [Qemu-devel] [PATCH v2 2/3] util/cutils: Move ctype macros to "cutils.h"

2019-01-06 Thread David Gibson
On Fri, Jan 04, 2019 at 07:12:07PM +0100, Philippe Mathieu-Daudé wrote: > Introduced in cd390083ad1, these macros don't need to be in > a generic header. > Add documentation to justify their use. > > Reviewed-by: Stefano Garzarella > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: David Gibs

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-06 Thread Ying Fang
ping On 2018/12/29 14:33, Ying Fang wrote: > Hi. > Recently one of our customer complained about the I/O performance of QEMU > emulated host cdrom device. > I did some investigation on it and there was still some point I could not > figure out. So I had to ask for your help. > > Here is the app

Re: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-06 Thread BALATON Zoltan
On Sun, 6 Jan 2019, Nick Hudson wrote: noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The default location for

Re: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/d19529f5-841e-ea06-fe7d-86ccfd528...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kerne

[Qemu-devel] [PATCH 3/3] target/arm: Use vector minmax expanders for aarch32

2019-01-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 33b1860148..f3f172f384 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c

[Qemu-devel] [PATCH 2/3] target/arm: Use vector minmax expanders for aarch64

2019-01-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2d6f8c1b4f..bef21ada71 100644 --- a/target/arm/translate-a64.c ++

Re: [Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-06 Thread Richard Henderson
On 1/7/19 8:20 AM, Bruno Haible wrote: > No, it is not fixed: even with this patch the program that fetches the > fpcr still prints 600e8000, and the various program crashes > still occur. Are you sure you rebuilt properly? The fpcr prints 680e8000 here. r~

[Qemu-devel] [PATCH 0/3] target/arm: Vector expansion improvments.

2019-01-06 Thread Richard Henderson
Based-on: <20190104223116.14037-1-richard.hender...@linaro.org> which is queued in my tcg-next branch. Patch 1 removes some conditionals that were added to the generic expander. The other two make use of the new min/max vector expanders. r~ Richard Henderson (3): target/arm: Rely on optimiz

[Qemu-devel] [PATCH 1/3] target/arm: Rely on optimization within tcg_gen_gvec_or

2019-01-06 Thread Richard Henderson
Since we're now handling a == b generically, we no longer need to do it by hand within target/arm/. Reviewed-by: David Gibson Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 6 +- target/arm/translate-sve.c | 6 +- target/arm/translate.c | 12 +++- 3 file

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-06 Thread Bruno Haible
No, it is not fixed: even with this patch the program that fetches the fpcr still prints 600e8000, and the various program crashes still occur. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/17

[Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-06 Thread Nick Hudson
noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The default location for the uboot file is 32MiB above bottom o

Re: [Qemu-devel] How to add a new target architecture

2019-01-06 Thread Richard Henderson
On 1/6/19 11:11 PM, Yoshinori Sato wrote: > Hello. > I written Renesas RX port. > It is works to boot linux kernel of minimal configuration. > > I'd like to merge this into the qmeu release and I need some > advice on how to proceed. > I tried reading wiki.qemu.org, but I could not find useful > i

Re: [Qemu-devel] [RFC PATCH] stm32f103: Add initial skeleton of STM32 F103 SoC

2019-01-06 Thread Priit Laes
On Thu, Jan 03, 2019 at 01:33:08PM -0800, Alistair Francis wrote: > On Wed, Dec 26, 2018 at 11:08 AM Priit Laes wrote: > > > > Initial barebone SoC implementation for STM32F103 > > with "Blue Pill" board source for testing. > > > > Code is based on both nrf51/microbit and stm32f205. > > > > Althou

[Qemu-devel] How to add a new target architecture

2019-01-06 Thread Yoshinori Sato
Hello. I written Renesas RX port. It is works to boot linux kernel of minimal configuration. I'd like to merge this into the qmeu release and I need some advice on how to proceed. I tried reading wiki.qemu.org, but I could not find useful information about adding subsystems. git repository is bel

Re: [Qemu-devel] [PATCH v1 0/3] Upstream more RISC-V fork patches

2019-01-06 Thread Richard Henderson
On 1/5/19 9:23 AM, Alistair Francis wrote: > This is one of the big patches that the RISC-V fork has that we don't. > After this it should be straight forward to upstream the remaining > patches. > > Michael Clark (3): > RISC-V: Implement modular CSR helper interface > RISC-V: Implement atomic

Re: [Qemu-devel] [PULL 3/3] tests: vm: auto_install OpenBSD

2019-01-06 Thread Carlo Arenas
On Sat, Jan 5, 2019 at 9:39 PM Fam Zheng wrote: > +self.ssh_root("shutdown -p now") could use `halt -p` as a more direct/obvious/effective command

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-06 Thread Richard Henderson
Should be fixed by: http://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg00726.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1701835 Title: floating-point operation bugs in qemu-alpha

Re: [Qemu-devel] [PATCH v2] osdep: Make MIN/MAX evaluate arguments only once

2019-01-06 Thread Richard Henderson
On 1/6/19 11:38 AM, Eric Blake wrote: > +/* > + * Automatic type deduction, to be used as: > + * QEMU_TYPEOF(expr) name = expr; > + */ > +#if QEMU_GNUC_PREREQ(4, 9) > +# define QEMU_TYPEOF(a) __auto_type > +#else > +# define QEMU_TYPEOF(a) typeof(a) > +#endif What's wrong with always using typeof?