[Qemu-devel] [PULL 3/3] tests: vm: auto_install OpenBSD

2019-01-05 Thread Fam Zheng
From: Fam Zheng Upgrade OpenBSD to 6.4 using auto_install. Especially, drop SDL1, include SDL2. Also do the build in $HOME since both /var/tmp and /tmp are tmpfs with limited capacities. Signed-off-by: Fam Zheng Message-Id: <20181031025712.18602-1-f...@redhat.com> Signed-off-by: Fam Zheng --

[Qemu-devel] [PULL 1/3] block/nvme: optimize the performance of nvme driver based on vfio-pci

2019-01-05 Thread Fam Zheng
From: Li Feng When the IO size is larger than 2 pages, we move the the pointer one by one in the pagelist, this is inefficient. This is a simple benchmark result: Before: $ qemu-io -c 'write 0 1G' nvme://:00:04.0/1 wrote 1073741824/1073741824 bytes at offset 0 1 GiB, 1 ops; 0:00:02.41 (424

[Qemu-devel] [PULL 2/3] docker: Use a stable snapshot for Debian Sid

2019-01-05 Thread Fam Zheng
From: Philippe Mathieu-Daudé The Debian Sid repository is not garanteed to be stable, as his 'unstable' name suggest :) To allow quick testing, Debian maintainers might push packages various time a day. Sometime package dependencies might break, which is annoying when using this repository for s

[Qemu-devel] [PULL 0/3] Block and testing patches

2019-01-05 Thread Fam Zheng
The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea: Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into staging (2018-12-22 11:25:31 +) are available in the git repository at: https://f...@github.com/famz/qemu tags/block-and-testing-pull-re

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-05 Thread Bruno Haible
The fpcr value seen in a process running in a VM comes from the Linux kernel, file linux/arch/alpha/kernel/process.c, function flush_thread(): /* Arrange for each exec'ed process to start off with a clean slate with respect to the FPU. This is all exceptions disabled. */

[Qemu-devel] [PATCH v2] osdep: Make MIN/MAX evaluate arguments only once

2019-01-05 Thread Eric Blake
Add the macro QEMU_TYPEOF() to access __auto_type in new enough compilers, while falling back to typeof on older compilers (the fallback doesn't handle variable length arrays, but we don't use those; it also expands to more text). Then use that macro to make MIN/MAX only evaluate their argument on

[Qemu-devel] [PATCH] target/alpha: Fix user-only initialization of fpcr

2019-01-05 Thread Richard Henderson
When the representation of fpcr was changed, the user-only initialization was not updated to match. Oops. Fixes: f3d3aad4a92 Fixes: https://bugs.launchpad.net/bugs/1701835 Reported-by: Bruno Haible Signed-off-by: Richard Henderson --- target/alpha/cpu.c | 6 +++--- 1 file changed, 3 insertions

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-05 Thread Stefan Ring
https://download.majix.org/dec/alpha_arch_ref.pdf The bits are defined in 4.7.8 Floating-Point Control Register (FPCR). 59/58 zero is chopped rounding. This does not seem like a good default. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-05 Thread Bruno Haible
Under qemu-system-alpha I get 680e8000 as well. Under qemu-alpha (versions 2.8.1, 2.9.0, 2.10.0, 2.11.0, 2.12.0, 3.1.0) I get 600e8000, i.e. bit 59 is unset. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bug

[Qemu-devel] [Bug 1701835] Re: floating-point operation bugs in qemu-alpha

2019-01-05 Thread Stefan Ring
Run this: #include #include double get_fpcr() { double x; asm ("mf_fpcr %0": "=f" (x)); return x; } int main() { double fpcr = get_fpcr(); unsigned long l; memcpy(&l, &fpcr, 8); printf("%016lx\n", l); return 0; } Under qemu-system-alpha I get 680e8000.

[Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-05 Thread David Kozub
Hi, Can QEMU emulate an OPAL disk? The only relevant thing I found is a post from 2017 about TPM that mentions OPAL: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04586.html specifically this bit: Well, at some point somebody's going to want us to implement this, but... they can d

[Qemu-devel] [Bug 1810603] [NEW] QEMU QCow Images crow dramatically

2019-01-05 Thread Eric Blake
On 1/5/19 9:32 AM, Lenny Helpline wrote: > > You can reproduce this bug as follow: > 1) create an initial disk image > 2) create a linked clone > 3) create a snapshot of the linked clone > 4) revert the snapshot every X minutes / hours Needs more details to reproduce. What is the exact command

Re: [Qemu-devel] [Bug 1810603] [NEW] QEMU QCow Images crow dramatically

2019-01-05 Thread Eric Blake
On 1/5/19 9:32 AM, Lenny Helpline wrote: > > You can reproduce this bug as follow: > 1) create an initial disk image > 2) create a linked clone > 3) create a snapshot of the linked clone > 4) revert the snapshot every X minutes / hours Needs more details to reproduce. What is the exact command

Re: [Qemu-devel] Why one virtio-pci device has two different DeviceState?

2019-01-05 Thread Peter Maydell
On Fri, 4 Jan 2019 at 20:23, Jintack Lim wrote: > I was wondering why one virtio-pci device has two different > DeviceState? - one directly from VirtIOPCIProxy and the other from > VirtIO such as VirtIONet. As an example, they are denoted as > qdev and vdev respectively in virtio_net_pci_realize()

[Qemu-devel] [Bug 1810603] [NEW] QEMU QCow Images crow dramatically

2019-01-05 Thread Lenny Helpline
Public bug reported: I've recently migrated our VM infrastructure (~200 guest on 15 hosts) from vbox to Qemu (using KVM / libvirt). We have a master image (QEMU QCow v3) from which we spawn multiple instances (linked clones). All guests are being revert once per hour for security reasons. About 2

Re: [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include

2019-01-05 Thread Peter Maydell
On Thu, 27 Dec 2018 at 06:35, Yang Zhong wrote: > > Only keep same boards definitions as i386-softmmu.mak in > x86_64-softmmu.mak. > > Signed-off-by: Yang Zhong > --- > default-configs/x86_64-softmmu.mak | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/default-config

[Qemu-devel] [PATCH] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

2019-01-05 Thread Stefan Hajnoczi
From: Steffen Görtz Recent microbit firmwares panic if the TWI magnetometer/accelerometer devices are not detected during startup. We don't implement TWI (I2C) so let's stub out these devices just to let the firmware boot. Signed-off-by: Stefan Hajnoczi Based-on: <20190103091119.9367-1-stefa..

Re: [Qemu-devel] [RFC PATCH] osdep: Make MIN/MAX evaluate arguments only once

2019-01-05 Thread Eric Blake
On 1/5/19 7:48 AM, Eric Blake wrote: > I'm fine keeping the name MIN/MAX for the common use, but we'd need a > second pair, maybe named MIN_CONST/MAX_CONST, for use in contexts that > require a constant (there, both arguments are evaluated twice because it > is the naive implementation, but that i

[Qemu-devel] [PULL 6/8] nbd/client: More consistent error messages

2019-01-05 Thread Eric Blake
Consolidate on using decimal (not hex), on outputting the option reply name (not just value), and a consistent comma between clauses, when the client reports protocol discrepancies from the server. While it won't affect normal operation, it makes debugging additions easier. Signed-off-by: Eric Bl

[Qemu-devel] [PULL 5/8] nbd: Document timeline of various features

2019-01-05 Thread Eric Blake
It can be useful to figure out which NBD protocol features are exposed by a server, as well as what features a client will take advantage of if available, for a given qemu release. It's not always precise to base features on version numbers (thanks to downstream backports), but any documentation i

[Qemu-devel] [PULL 4/8] qemu-nbd: Use program name in error messages

2019-01-05 Thread Eric Blake
This changes output from: $ qemu-nbd nosuch Failed to blk_new_open 'nosuch': Could not open 'nosuch': No such file or directory to something more consistent with qemu-img and qemu: $ qemu-nbd nosuch qemu-nbd: Failed to blk_new_open 'nosuch': Could not open 'nosuch': No such file or directory

[Qemu-devel] [PULL 3/8] block/nbd-client: use traces instead of noisy error_report_err

2019-01-05 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Reduce extra noise of nbd-client, change 083 correspondingly. In various commits (be41c100 in 2.10, f140e300 in 2.11, 78a33ab in 2.12), we added spots where qemu as an NBD client would report problems communicating with the server to stderr, because there was n

[Qemu-devel] [PULL 7/8] qemu-nbd: Fail earlier for -c/-d on non-linux

2019-01-05 Thread Eric Blake
Connecting to a /dev/nbdN device is a Linux-specific action. We were already masking -c and -d from 'qemu-nbd --help' on non-linux. However, while -d fails with a sensible error message, it took hunting through a couple of files to prove that. What's more, the code for -c doesn't fail until after

[Qemu-devel] [PULL 1/8] nbd: publish _lookup functions

2019-01-05 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy These functions are used for formatting pretty trace points. We are going to add some in block/nbd-client, so, let's publish all these functions at once. Note, that nbd_reply_type_lookup is already published, and constants, "named" by these functions live in inc

[Qemu-devel] [PULL 8/8] nbd/client: Drop pointless buf variable

2019-01-05 Thread Eric Blake
There's no need to read into a temporary buffer (oversized since commit 7d3123e1) followed by a byteswap into a uint64_t to check for a magic number via memcmp(), when the code immediately below demonstrates reading into the uint64_t then byteswapping in place and checking for a magic number via in

[Qemu-devel] [PULL 2/8] nbd/client: Trace all server option error messages

2019-01-05 Thread Eric Blake
Not all servers send free-form text alongside option error replies, but for servers that do (such as qemu), we pass the server's message as a hint alongside our own error reporting. However, it would also be useful to trace such server messages, since we can't guarantee how the hint may be consume

[Qemu-devel] [PULL 0/8] NBD patches through 2019-01-05

2019-01-05 Thread Eric Blake
The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea: Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into staging (2018-12-22 11:25:31 +) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-01-05 for

Re: [Qemu-devel] [PATCH v2 08/22] nbd/client: Drop pointless buf variable

2019-01-05 Thread Eric Blake
On 12/15/18 7:53 AM, Eric Blake wrote: > There's no need to read into a temporary buffer (oversized > since commit 7d3123e1) followed by a byteswap into a uint64_t > to check for a magic number via memcmp(), when the code > immediately below demonstrates reading into the uint64_t then > byteswappin

Re: [Qemu-devel] [RFC PATCH] osdep: Make MIN/MAX evaluate arguments only once

2019-01-05 Thread Eric Blake
On 1/4/19 6:23 PM, Zoltán Kővágó wrote: > Hi, > > I have a similar patch in my queue[1] > Sorry for not noticing that thread. >> #ifndef MIN >> -#define MIN(a, b) (((a) < (b)) ? (a) : (b)) The old version is at least named in ALL_CAPS, to warn the user that it is a macro and may have side ef

[Qemu-devel] [Bug 1810433] Re: aarch64-linux-user master: inconsistent pwrite behaviour

2019-01-05 Thread Matwey V. Kornilov
I've also check qemu-arm with the same test code. Surprisingly, I see correct result: pwrite ret = 0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1810433 Title: aarch64-linux-user master: inconsi

[Qemu-devel] [Bug 1810590] [NEW] Record/replay example does not work

2019-01-05 Thread Andreas Gustafsson
Public bug reported: Trying the record part of the record/replay example at https://github.com/qemu/qemu/blob/master/docs/replay.txt qemu immediately hangs with no guest output displayed. This is with qemu from today's git (e59dbbac0364344a3ad84c3497a98c56003d3fb8). To reproduce: wget https:/

[Qemu-devel] [PATCH] qemu-iotests: add test case for dmg

2019-01-05 Thread yuchenlin
Recently, some bugs in dmg file have been fixed. To prevent reading dmg is broken someday in the future, add a simple test which ensures the conversion from dmg to raw should not hang or face any I/O error. Signed-off-by: yuchenlin --- tests/qemu-iotests/236| 53