On 08/09/2018 06:00 PM, Peter Maydell wrote:
> We now require Linux-kernel-style multiline comments:
> /*
> * line one
> * line two
> */
>
> Enforce this in checkpatch.pl, by backporting the relevant
> parts of the Linux kernel's checkpatch.pl. (The only changes
> needed are tha
On 08/10/2018 02:45 PM, Paolo Bonzini wrote:
> On 10/08/2018 11:10, Peter Maydell wrote:
>>> So my proposal, which is actually consistent with what QEMU is doing, is
>>> the following:
>>>
>>> 1) the first line of a file should always be "/*", otherwise warn
>>>
>>> 2) a comment that starts with "/
Max Reitz writes:
> On 2018-08-10 08:28, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>>> Spotted by ASAN:
>>>
>>> =
>>> ==5378==ERROR: LeakSanitizer: detected memory leaks
>>>
>>> Direct leak of 65536 byte(s) in 1 obje
Eric Blake writes:
> On 08/10/2018 09:31 AM, Markus Armbruster wrote:
>
+ *
+ * [Numbers:]
>>>
>>> Worth also calling out:
>>>
>>> [Objects:]
>>>object = begin-object [ member *( value-separator member ) ]
>>> end-object
>>>
>>>member = string name-separa
Eric Blake writes:
> On 08/10/2018 09:18 AM, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>>> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
utf8_string() tests only double quoted strings. Cover single quoted
strings, too: store the strings to test without quotes, then wrap the
On August 13, 2018 4:39:35 AM EEST, Max Reitz wrote:
>On 2018-08-10 14:00, Alberto Garcia wrote:
>> On Fri 10 Aug 2018 08:26:44 AM CEST, Leonid Bloch wrote:
>>> The upper limit on the L2 cache size is increased from 1 MB to 32
>MB.
>>> This is done in order to allow default full coverage with t
On 08/10/2018 01:23 PM, Mark Cave-Ayland wrote:
> Valgrind reports that when loading a non-ELF kernel, kernel_top may be used
> uninitialised when checking for an initrd.
>
> Since there are no known non-ELF kernels for SPARC64 then we can simply
> initialise kernel_top to 0 and then skip the init
On Tue, Aug 07, 2018 at 11:29:48AM +0200, Roman Kapl wrote:
> Add support for DBCR (debug control register) based debugging as used on
> BookE ppc. So far supports only branch and single-step events, but these are
> the important ones. GDB in Linux guest can now do single-stepping.
>
> Signed-off-
Applied to ppc-for-3.1.
https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg01317.html
** Changed in: qemu
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bug
This commit https://lists.gnu.org/archive/html/qemu-
devel/2018-08/msg01281.html from ~bharata-rao, fixes the issue.
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.lau
If we know we've already locked the bytes, don't do it again; similarly
don't unlock a byte if we haven't locked it. This doesn't change the
behavior, but fixes a corner case explained below.
Libvirt had an error handling bug that an image can get its (ownership,
file mode, SELinux) permissions ch
Signed-off-by: Max Reitz
---
tests/qemu-iotests/151 | 56 ++
tests/qemu-iotests/151.out | 4 +--
2 files changed, 58 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/151 b/tests/qemu-iotests/151
index fe53b9f446..e5515c2d37 100755
--- a/tests
This patch adds a .bdrv_co_block_status() implementation for the mirror
block job that reports an area as allocated iff source and target are
in sync. This allows putting a copy-on-read node on top of a mirror
node which automatically copies all data read from the source to the
target.
To make th
mirror_co_perform() is the sole user of that function, and it looks a
bit weird now. This patch inlines it into mirror_co_perform().
Signed-off-by: Max Reitz
---
block/mirror.c | 53 ++
1 file changed, 23 insertions(+), 30 deletions(-)
diff --git
Calling qemu_co_queue_restart_all() with a held AioContext looks a bit
strange. There is no reason why we would hold the context any longer
(as this coroutine is not going to perform any further operations that
would necessitate it), so release it before restarting the waiting
requests.
Signed-of
This function inlines mirror_read_complete() and mirror_write_complete()
into mirror_co_read() (which is thus renamed to mirror_co_copy()). In
addition, freeing of the I/O vector is removed from
mirror_iteration_done() and put into an own function mirror_free_qiov()
(which is called by mirror_co_c
Signed-off-by: Max Reitz
---
block/mirror.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 85b08086cc..6330269156 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -196,7 +196,6 @@ static void coroutine_fn mirror_write_com
Eventually, we want to inline mirror_write_complete() fully into
mirror_co_perform(). This patch does the inlining, but we cannot remove
the function yet, as it is still required by mirror_co_read().
Signed-off-by: Max Reitz
---
block/mirror.c | 12 +++-
1 file changed, 11 insertions(+)
We only need the I/O vector for data copying operations, so we do not
need to put it into the MirrorOp structure and can keep it locally in
mirror_co_read().
Signed-off-by: Max Reitz
---
block/mirror.c | 43 +--
1 file changed, 25 insertions(+), 18 deletio
Signed-off-by: Max Reitz
---
block/mirror.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 89452ad371..df8e0242dc 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -364,17 +364,14 @@ static void coroutine_fn mi
By moving the mirror_align_for_copy() call from mirror_co_read() to
mirror_perform(), we can drop bytes_handled from MirrorOp.
mirror_align_for_copy() takes a uint64_t * for @bytes, so this commit
changes mirror_perform()'s @bytes parameter to uint64_t, too; but it
still asserts that its value doe
By pulling this function out of mirror_co_read(), the latter becomes
simpler. This is important so the following patches can make it more
complicated again.
Signed-off-by: Max Reitz
---
block/mirror.c | 44
1 file changed, 24 insertions(+), 20 deleti
While very simple now, this function will be fattened in future patches.
Signed-off-by: Max Reitz
---
block/mirror.c | 48 +---
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index f05404e557..89452ad371
Signed-off-by: Max Reitz
---
block/mirror.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index df8e0242dc..85b08086cc 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -374,16 +374,13 @@ static int coroutine_fn mirror_co_
This series is based on v2 of my "block: Deal with filters" series:
Based-on: <20180809223117.7846-1-mre...@redhat.com>
The bulk of this series (14 of the patches here, in fact) makes more of
the coroutined mirror I started with my active mirror series. For this,
mirror_perform() is translated
Remove mirror_perform()'s return value, instead aligning the @offset and
@bytes it receives. We needed the return value for two reasons:
(1) So that "offset += io_bytes" would result in an aligned offset, and
(2) so that io_bytes_acct is kind of aligned (the tail is aligned, but
the head is n
Signed-off-by: Max Reitz
---
block/mirror.c | 54 +-
1 file changed, 36 insertions(+), 18 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index c28b6159d5..34cb8293b2 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -305,42 +305,60 @@
Currently, we never test whether we can read from the source while
mirroring (that means, whether we can read from the mirror BDS). Add
such a test to 156 because it fits well.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/156 | 7 +++
tests/qemu-iotests/156.out | 3 +++
2 files chang
mirror_wait_for_any_operation() calls qemu_co_queue_wait(), which is a
coroutine_fn (technically it is a macro which resolves to a
coroutine_fn). Therefore, this function needs to be a coroutine_fn as
well.
This patch makes it and all of its callers coroutine_fns.
Signed-off-by: Max Reitz
---
On Fri, Aug 10, 2018 at 11:27:55AM +0100, Mark Cave-Ayland wrote:
> Here are a couple of patches to switch the fw_cfg initialisation for
> the Mac Old World and New World machines over to use qdev rather than
> using the legacy fw_cfg_init_mem() function.
>
> Signed-off-by: Mark Cave-Ayland
Appl
On Fri, Aug 10, 2018 at 10:00:26AM +0200, Cédric Le Goater wrote:
> It should save us some CPU cycles as these routines perform a lot of
> checks.
I don't think any of these is particularly fastpath, but sure, applied
to ppc-for-3.1.
>
> Signed-off-by: Cédric Le Goater
> ---
> hw/ppc/spapr_pci
On Fri, Aug 10, 2018 at 01:04:18PM +0100, Mark Cave-Ayland wrote:
> Instead initialise the device via qdev to allow us to set device properties
> directly as required.
>
> Signed-off-by: Mark Cave-Ayland
Applied to ppc-for-3.1, thanks.
> ---
> hw/ppc/prep.c | 13 +++--
> 1 file changed
On Sat, Aug 11, 2018 at 12:46:45AM +0200, Hervé Poussineau wrote:
> 40p machine type should be used instead.
>
> Signed-off-by: Hervé Poussineau
> ---
> qemu-deprecated.texi | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 9920a8
On Fri, Aug 10, 2018 at 09:57:13AM -0300, Eduardo Habkost wrote:
> On Fri, Aug 10, 2018 at 01:40:27PM +0100, Mark Cave-Ayland wrote:
> > For the older machines (such as Mac and SPARC) the DT nodes representing
> > bootdevices for disk nodes are irregular for mainly historical reasons.
> >
> > Sinc
Hello Dave, Juan and all,
It is useful to get the dirty page rates in guest to evaluate the guest
loads
so that we can make a decide to live migrate it or not. So I think we can
add a on-demand qmp for showing the dirty page rates.
I found someone has done this work in here:
-->https://github.com
On Fri, 08/10 14:14, Kevin Wolf wrote:
> Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben:
> > If we know we've already locked the bytes, don't do it again; similarly
> > don't unlock a byte if we haven't locked it. This doesn't change the
> > behavior, but fixes a corner case explained below.
> >
On Fri, Aug 10, 2018 at 09:47:49AM +0200, Cédric Le Goater wrote:
> On 08/10/2018 02:46 AM, David Gibson wrote:
> > On Mon, Jul 30, 2018 at 04:11:33PM +0200, Cédric Le Goater wrote:
> >> This proposal moves all the related IRQ routines of the sPAPR machine
> >> behind a sPAPR IRQ backend interface
On 2018-08-10 14:00, Alberto Garcia wrote:
> On Fri 10 Aug 2018 08:26:44 AM CEST, Leonid Bloch wrote:
>> The upper limit on the L2 cache size is increased from 1 MB to 32 MB.
>> This is done in order to allow default full coverage with the L2 cache
>> for images of up to 256 GB in size (was 8 GB).
Signed-off-by: Leonid Bloch
---
docs/qcow2-cache.txt | 20 +---
qemu-options.hx | 9 ++---
2 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
index 8a09a5cc5f..2326db01b9 100644
--- a/docs/qcow2-cache.txt
+++ b/do
The default cache-clean-interval is set to 10 minutes, in order to lower
the overhead of the qcow2 caches (before the default was 0, i.e.
disabled).
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c| 2 +-
block/qcow2.h| 1 +
docs/qcow2-cache.txt | 4 ++--
The upper limit on the L2 cache size is increased from 1 MB to 32 MB.
This is done in order to allow default full coverage with the L2 cache
for images of up to 256 GB in size (was 8 GB). Note, that only the
needed amount to cover the full image is allocated. The value which is
changed here is just
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 2 +-
block/qcow2.h | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index ec9e6238a0..67cc82f0b9 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -830,7 +830,7
The caches are now recalculated upon image resizing. This is done
because the new default behavior of assigning L2 cache relatively to
the image size, implies that the cache will be adapted accordingly
after an image resize.
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow
Sufficient L2 cache can noticeably improve the performance when using
large images with frequent I/O.
Previously, unless 'cache-size' was specified and was large enough, the
L2 cache was set to a certain size without taking the virtual image size
into account.
Now, the L2 cache assignment is awar
This series makes the qcow2 L2 cache assignment aware of the image size,
with the intention for it to cover the entire image. The importance of
this change is in noticeable performance improvement, especially with
heavy random I/O. The memory overhead is not big in most cases, as only
1 MB of cache
Signed-off-by: Leonid Bloch
Reviewed-by: Alberto Garcia
---
block/qcow2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index f885afa0ed..ffb4a9e4a1 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1324,7 +1324,7 @@ static int coroutine_f
The refcount cache size does not need to be set to its minimum value in
read_cache_sizes(), as it is set to at least its minimum value in
qcow2_update_options_prepare().
Signed-off-by: Leonid Bloch
---
block/qcow2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/block/q
On Thu, 2 Aug 2018 15:56:47 -0600
Sandra Loosemore wrote:
> On 05/18/2018 03:35 PM, Sandra Loosemore wrote:
> > On 05/18/2018 02:19 PM, Julian Brown wrote:
> >> On Fri, 18 May 2018 21:52:04 +0200
> >> Marek Vasut wrote:
> >>
> >>> On 05/18/2018 09:23 PM, Julian Brown wrote:
> This pat
This patch (by Sandra Loosemore, mildly rebased) adds support for
semihosting for Nios II bare-metal emulation.
Signed-off-by: Julian Brown
Signed-off-by: Sandra Loosemore
---
qemu-options.hx| 8 +-
target/nios2/Makefile.objs | 2 +-
target/nios2/cpu.h | 4 +-
target/n
This patch adds support for a generic MMU-less Nios II board that can
be used e.g. for bare-metal compiler testing. Nios II booting is also
tweaked so that bare-metal binaries start executing in RAM starting at
0x, rather than an alias at 0xc000, which allows features
such as unwinding
This is the fourth version of the patch series previously posted here:
http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg04571.html
The contents of the patches are largely the same apart from some linting
from the checkpatch.pl script. I've also rebased and re-tested with
Sandra's new li
On 08/12/2018 01:45 PM, Laurent Vivier wrote:
> Le 12/06/2018 à 02:51, Richard Henderson a écrit :
>> Defines a unified structure for implementation and strace.
>> Supplies a generator script to build the declarations and
>> the lookup function.
>>
>> Signed-off-by: Richard Henderson
>> ---
>> li
Le 12/06/2018 à 02:51, Richard Henderson a écrit :
> Defines a unified structure for implementation and strace.
> Supplies a generator script to build the declarations and
> the lookup function.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/syscall.h | 178 +++
>
On Sun, Aug 12, 2018 at 6:17 AM Paolo Bonzini wrote:
> On 12/08/2018 05:07, Andrew Oates via Qemu-devel wrote:
> > Currently call gates are always treated as 32-bit gates. In IA-32e mode
> > (either compatibility or 64-bit submode), system segment descriptors are
> > always 64-bit. Treating the
I have a patch for that, it was designed to run NVMe for MacOS guests
and implements at least the bare minimum of the spec. I'll try to polish
it up and upstream it as soon as I have time.
** Patch added: "0001-Enough-GetLogCmd-for-macOS.patch"
https://bugs.launchpad.net/qemu/+bug/1777235/+att
After configuring QEMU on my Sun I got this message:
"Host OS SunOS support is not currently maintained.
The QEMU project intends to remove support for this host OS in
a future release if nobody volunteers to maintain it and to
provide a build host for our continuous integration setup.
configure
On 11/08/2018 21:07, Remy NOEL wrote:
> On 08/07/2018 05:09 PM, Dr. David Alan Gilbert wrote:
>
>> * Peter Maydell (peter.mayd...@linaro.org) wrote:
>>> On 7 August 2018 at 15:57, Dr. David Alan Gilbert
>>> wrote:
* Gerd Hoffmann (kra...@redhat.com) wrote:
> On Fri, Jul 20, 2018 at 10:19
On 08/08/2018 14:03, Markus Armbruster wrote:
> +if (cp >= 0xD800 && cp <= 0xDBFF && !leading_surrogate
> +&& ptr[1] == '\\' && ptr[2] == 'u') {
> +ptr += 2;
> +leading_surrogate = cp;
> +goto hex;
> +
On 06/08/2018 08:53, Markus Armbruster wrote:
> 13 of 13 C99 library function pairs taking ... or a va_list parameter
> are called FOO() and vFOO(). In QEMU, we sometimes call the one
> taking a va_list FOOv() instead. Bad taste. libqtest.h uses both
> spellings. Normalize it to the standard sp
On 08/12/18 09:11, Marcel Apfelbaum wrote:
> On 08/07/2018 06:59 PM, Laszlo Ersek wrote:
>> First, under the label "shpc_error", we call pci_bridge_exitfn(), which
>> seems to clean up everything (checking individually for each thing to
>> clean up). Given this, I wonder why we introduced the "slo
On 08/12/2018 11:39 AM, Yuval Shaia wrote:
On Sat, Aug 11, 2018 at 07:47:49PM +0300, Marcel Apfelbaum wrote:
Hi,
On 08/06/2018 11:51 AM, Thomas Huth wrote:
On 07/28/2018 05:50 AM, Rebecca Cran wrote:
On 7/25/18 5:14 AM, Thomas Huth wrote:
Note that the error has been reported to happen o
On 12/08/2018 05:07, Andrew Oates via Qemu-devel wrote:
> Currently call gates are always treated as 32-bit gates. In IA-32e mode
> (either compatibility or 64-bit submode), system segment descriptors are
> always 64-bit. Treating them as 32-bit has the expected unfortunate
> effect: only the low
Hi all,
I have been trying to boot linux on the 40p machine with qemu-system-ppc
for quite some time, with no success. I have managed to get into the BIOS,
but not further than that.
Assuming it is in possible to boot Linux on the 40p machine, is there a
qemu command line (and Linux kernel confi
Le 12/08/2018 à 17:44, Aleksandar Markovic a écrit :
> ping
Where can we find the kernel source for nanoMIPS to be able to compare
the QEMU syscall numbers definition?
Thanks,
Laurent
ping
From: Aleksandar Markovic
Sent: Monday, August 6, 2018 7:00:29 PM
To: qemu-devel@nongnu.org
Cc: peter.mayd...@linaro.org; laur...@vivier.eu; riku.voi...@iki.fi;
philippe.mathieu.da...@gmail.com; aurel...@aurel32.net;
richard.hender...@linaro.org; Al
On 12 August 2018 at 17:23, Laurent Vivier wrote:
> Le 12/08/2018 à 17:44, Aleksandar Markovic a écrit :
>> ping
>
> Where can we find the kernel source for nanoMIPS to be able to compare
> the QEMU syscall numbers definition?
I think we shouldn't take the linux-user code into QEMU until
the kern
On Sat, Aug 11, 2018 at 07:47:49PM +0300, Marcel Apfelbaum wrote:
> Hi,
>
> On 08/06/2018 11:51 AM, Thomas Huth wrote:
> > On 07/28/2018 05:50 AM, Rebecca Cran wrote:
> > > On 7/25/18 5:14 AM, Thomas Huth wrote:
> > >
> > > > Note that the error has been reported to happen on FreeBSD - so I doubt
On Sat, Aug 11, 2018 at 08:15:34PM +0300, Marcel Apfelbaum wrote:
> No need to include linux/types.h, is empty anyway.
>
> Suggested-by: Thomas Huth
> Signed-off-by: Marcel Apfelbaum
> ---
> hw/rdma/vmw/pvrdma_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd
Hi Laszlo,
On 08/07/2018 06:59 PM, Laszlo Ersek wrote:
On 08/07/18 14:19, Laszlo Ersek wrote:
On 08/07/18 09:04, Jing Liu wrote:
Add hint to firmware (e.g. SeaBIOS) to reserve addtional
IO/MEM/PREF spaces for legacy pci-pci bridge, to enable
some pci devices hotplugging whose IO/MEM/PREF space
69 matches
Mail list logo
