From: Junyan He
Because we need to make sure the pmem kind memory data is synced
after migration, we choose to call pmem_persist() when the migration
finish. This will make sure the data of pmem is safe and will not
lose if power is off.
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
Re
From: Junyan He
The nvdimm kind memory does not support post copy now.
We disable post copy if we have nvdimm memory and print some
log hint to user.
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Igor Mammedov
---
migration/ram.c | 9 +
1 file changed, 9 insertio
From: Junyan He
Add a pair of configure options --{enable,disable}-libpmem to control
whether QEMU is compiled with PMDK libpmem [1].
QEMU may write to the host persistent memory (e.g. in vNVDIMM label
emulation and live migration), so it must take the proper operations
to ensure the persistence
From: Junyan He
Guest writes to vNVDIMM labels are intercepted and performed on the
backend by QEMU. When the backend is a real persistent memort, QEMU
needs to take proper operations to ensure its write persistence on the
persistent memory. Otherwise, a host power failure may result in the
loss
From: Junyan He
QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and live
migration.
If the backend is on the persistent memory, QEMU needs to take proper
operations to
ensure its writes persistent on the persistent memory. Otherwise, a host power
failure
may result in the loss t
From: Junyan He
When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it
needs to know whether the backend storage is a real persistent memory,
in order to decide whether special operations should be performed to
ensure the data persistence.
This boolean option 'pmem' allows users to s
From: Junyan He
We need to use these flags in other files rather than just in exec.c,
For example, RAM_SHARED should be used when create a ram block from file.
We expose them the exec/memory.h
Signed-off-by: Junyan He
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Igor Mammedov
---
exec.c
From: Junyan He
As more flag parameters besides the existing 'share' are going to be
added to following functions
memory_region_init_ram_from_file
qemu_ram_alloc_from_fd
qemu_ram_alloc_from_file
let's switch them to use the 'flags' parameters so as to ease future
flag additions.
The existing 'sh
On Tue, Jul 17, 2018 at 07:38:32AM +0200, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
> > There is no need for per-command need_resume granularity, it should
> > resume after running an non-oob command on oob-disabled monitor.
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > moni
Marc-André Lureau writes:
> json_parser_parse_err() may return something else than a QDict, in
> which case we loose the object. Let's keep track of the original
> object to avoid leaks.
Should this leak fix go into 3.0?
> When an error occurs, "qdict" contains the response, but we still
> chec
I'v successfully compiled the previous patch on Fedora 27, but it seems to
be failing on RHEL, You can apply this patch instead which avoids using the
versionhelpers header:
---
qga/commands-win32.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qga/commands-win32.c b/qga/command
Marc-André Lureau writes:
> There is no need for per-command need_resume granularity, it should
> resume after running an non-oob command on oob-disabled monitor.
>
> Signed-off-by: Marc-André Lureau
> ---
> monitor.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1459626
Title:
emacs (gtk3
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1459622
Title:
firefox han
On 07/16/2018 06:53 PM, Philippe Mathieu-Daudé wrote:
Hi Guenter,
On 07/15/2018 07:06 PM, Guenter Roeck wrote:
Add basic support for BCM283x CPRMAN. Provide support for reading and
writing CPRMAN registers and initialize registers with sensible default
values. During runtime retain any written
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> This test doesn't even build QEMU, it just builds and runs all the
> unit tests. Intended to make checking unit tests on all docker images
> easier.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> When a check fails we currently just report why we failed. This is not
> totally helpful to people who want to boot-strap a new image. Add a
> --hint option which we can pass down to give a bit more information.
>
> Signed-off-by: Alex Bennée
Reviewed
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> Rename DOCKER_INTERMEDIATE_IMAGES to DOCKER_PARTIAL_IMAGES and add the
> incomplete cross compiler images that can build tests but can't build
> QEMU itself. We also add debian, debian-bootstrap and the tricode
> images to the list.
>
> Signed-off-by: A
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> Not all our images are able to run the tests. Rather than use features
> we can just check for the existence and run-ability of gtester. If the
> image has been setup for binfmt_misc it will be able to run anyway.
>
> Signed-off-by: Alex Bennée
> ---
>
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> Not all docker images can run the check step. Let's move everything
> into a common helper so we don't need to replicate checks in the
> future.
>
> Signed-off-by: Alex Bennée
>
> ---
> v2
> - add "move" to Let's everything in commit message
> ---
>
On 07/13/2018 10:27 AM, Alex Bennée wrote:
>
> Alex Bennée writes:
>
>> From: Philippe Mathieu-Daudé
>>
>> Signed-off-by: Philippe Mathieu-Daudé
>> Signed-off-by: Alex Bennée
>> ---
>> .shippable.yml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/.shippable.yml b/.shippable.ym
On 07/15/2018 11:00 PM, Fam Zheng wrote:
> The images are big. Add a rule to clean up easily.
Thanks :)
>
> Suggested-by: Philippe Mathieu-Daudé
> Signed-off-by: Fam Zheng
> ---
> tests/vm/Makefile.include | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/
Signed-off-by: Philippe Mathieu-Daudé
---
tests/vm/basevm.py | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 715e433142..7575c36f0b 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -183,12 +183,15 @@ class BaseVM(obj
Signed-off-by: Philippe Mathieu-Daudé
---
tests/vm/basevm.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 1f4ad04c32..715e433142 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -233,7 +233,7 @@ def main(vmcls):
Signed-off-by: Philippe Mathieu-Daudé
---
4 is random (but more than 1).
---
tests/vm/basevm.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 7575c36f0b..50785a64df 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -182,6 +182,8 @@ c
On 07/13/2018 09:17 AM, Alex Bennée wrote:
> This allows some tests that just want to configure QEMU's source tree
> to do so.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
> ---
> tests/docker/common.rc | 7 ++-
> 1 file changed, 6
Signed-off-by: Philippe Mathieu-Daudé
---
tests/vm/basevm.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 04089cd545..1f4ad04c32 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -70,7 +70,6 @@ class BaseVM(object):
Hi Fam,
Few patches I added while testing the VM tests without KVM access.
I doubt many people want to suffer using TCG for VM testing, but
it was handy to debug/support aarch64 VM tests.
Also this could be a useful TCG stress test...?
Regards,
Phil.
Philippe Mathieu-Daudé (5):
tests/vm: Ext
Signed-off-by: Philippe Mathieu-Daudé
---
tests/vm/basevm.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 3643117816..04089cd545 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -33,6 +33,11 @@ SSH_KEY = open(os
- Call autogen once in the same layer of the git repository clone,
- Disable build warnings (they are not relevant for QEMU),
- Call ldconfig once installed.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-amd64.docker | 8 ++--
1 file changed, 6 insertions(+), 2 de
Signed-off-by: Philippe Mathieu-Daudé
---
To avoid some problem with Docker permissions on NUMA systems,
the libnuma-dev package is deliberately not installed (yet).
---
.../dockerfiles/debian-host-cross.docker | 37 ++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff -
This image is badly named and not amd64 specific.
Use `dpkg --print-architecture` to get the host architecture.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/docker/dockerfiles/debian-amd64.docker | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/docker/dockerfil
Signed-off-by: Philippe Mathieu-Daudé
---
.shippable.yml | 4 ++--
tests/docker/Makefile.include| 2 +-
.../{debian-amd64.docker => debian-host-cross.docker}| 9 ++---
3 files changed, 9 insertions(+), 6 deletions(-)
r
Sorry I don't have a better name for this image,
it is meant to cross-build for the same architecture
than the host.
Due to the bad name, explicitely tagged the last 2
patches as 'RFC'.
Tested on x86_64 and aarch64, should also work on
s390x and ppc64le (per the Docker doc).
If they are voluntee
Hi Guenter,
On 07/15/2018 07:06 PM, Guenter Roeck wrote:
> Add basic support for BCM283x CPRMAN. Provide support for reading and
> writing CPRMAN registers and initialize registers with sensible default
> values. During runtime retain any written values.
>
> Basic CPRMAN support is necessary and
Cc'ing ANTField folks who might have the specs.
On 07/16/2018 07:23 PM, Guenter Roeck wrote:
> Writes in PIO mode have two requirements:
>
> - A data interrupt must be generated after a write command has been
> issued to indicate that the chip is ready to receive data.
> - A block interrupt mus
On 7/16/2018 10:59 PM, Paolo Bonzini wrote:
On 10/07/2018 10:57, Jingqi Liu wrote:
Enable a few new cpu features including UMONITOR, UMWAIT, TPAUSE,
MOVDIRI and MOVDIR64B.
UMONITOR, UMWAIT, and TPAUSE are a set of user wait instructions.
MOVDIRI moves doubleword or quadword from register to mem
On 07/15/2018 11:10 PM, Fam Zheng wrote:
> On Sun, 07/15 22:34, Philippe Mathieu-Daudé wrote:
>> On 07/11/2018 10:28 PM, Fam Zheng wrote:
>>> This one does docker testing in the VM. It is intended to replace the
>>> native docker testing on patchew testers.
>>>
>>> Signed-off-by: Fam Zheng
>>> ---
Fix has been committed as 1d3d1b23e1c8f52ec431ddaa8deea1322bc25cbf
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1781280
Title:
QEMU ignores
On 07/16/2018 12:53 PM, Laurent Vivier wrote:
> When we try to use some targets on ppc64, it can happen the target
> doesn't support the host page size to align ELF load sections and
> fails with:
>
> ELF load command alignment not page-aligned
>
> Since commit a70daba3771 ("linux-user: Tell gu
That's:
commit bed9bcfa3275a9cfee82846a9f521c4858a9739a
Author: Paolo Bonzini
Date: Wed Jun 6 15:09:51 2018 -0400
ide: push end_transfer_func out of start_transfer callback, rename callback
Now that end_transfer_func is a tail call in ahci_start_transfer,
formalize the fact th
Writes in PIO mode have two requirements:
- A data interrupt must be generated after a write command has been
issued to indicate that the chip is ready to receive data.
- A block interrupt must be generated after each block to indicate
that the chip is ready to receive the next data block.
Re
On Mon, Jul 16, 2018 at 03:07:13PM +0100, Peter Maydell wrote:
> On 16 July 2018 at 14:51, Guenter Roeck wrote:
> > In this context, I can't get mmc to work with ToT Linux on raspi3.
> >
> > / # mount /dev/mmcblk0 /mnt
> > [ 47.099074] sdhost-bcm2835 3f202000.mmc: timeout waiting for hardware
>
When the result of bcdsub is equal to zero, the result sign may be
set to negative in some cases, and this does not follow the Power ISA
specifications as to decimal integer arithmetic instructions.
Signed-off-by: Yasmin Beatriz
---
target/ppc/int_helper.c | 3 +++
1 file changed, 3 insertions(+
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> QEMU currently crashes when e.g. doing something like this:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'xlnx,zynqmp'}}" \
> "{'execute': 'human-monitor-command', " \
> "'argume
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> Valgrind reports an error here:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'arm11mpcore_priv'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments': {'command-line':
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> From: Paolo Bonzini
>
> aux_create_slave() calls qdev_init_nofail() which in turn "realizes"
> the corresponding object. This is unlike qdev_create(), and it is wrong
> because qdev_init_nofail() must not be called from an instance_init
> func
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> Running QEMU with valgrind indicates a problem here:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'a9mpcore_priv'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments':
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> Valgrind complains:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'stm32f205-soc'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments': {'command-line': 'info qtree'}}"
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> QEMU currently crashes when introspecting the "iotkit" device and
> runnint "info qtree" afterwards, e.g. when running QEMU like this:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> There is a memory management problem when introspecting the a15mpcore_priv
> device. It can be seen with valgrind when running QEMU like this:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'ty
On Mon, Jul 16, 2018 at 5:59 AM, Thomas Huth wrote:
> A lot of functions are initializing an object and attach it immediately
> afterwards to the system bus. Provide a common function for this, which
> also uses object_initialize_child() to make sure that the reference
> counter is correctly initi
From: Paolo Bonzini
The file descriptor for /sys/power/state was never closed. Reported
by Coverity.
Signed-off-by: Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Michael Roth
---
qga/commands-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/commands-posix.c
The following changes since commit 102ad0a80f5110483efd06877c29c4236be267f9:
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2018-07-16' into
staging (2018-07-16 15:34:38 +0100)
are available in the git repository at:
git://github.com/mdroth/qemu.git tags/qga-pull-2018-07-16-tag
From: Marc-André Lureau
'driver' is leaked when the loop is not broken.
Leak introduced by commit 743c71d03c20d64f2bae5fba6f26cdf5e4b1bda6,
spotted by ASAN.
Signed-off-by: Marc-André Lureau
Reviewed-by: Laszlo Ersek
Signed-off-by: Michael Roth
---
qga/commands-posix.c | 1 +
1 file changed,
Quoting Paolo Bonzini (2018-07-15 11:21:56)
> The file descriptor for /sys/power/state was never closed. Reported
> by Coverity.
>
> Signed-off-by: Paolo Bonzini
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 i
On Mon, May 14, 2018 at 06:19:12PM +0100, Daniel P. Berrangé wrote:
> The multiboot code parses the initrd_filename twice, first to count how
> many entries there are, and second to process each entry. This changes
> the first loop to store the parse module names in a list, and the second
> loop ca
On Mon, May 14, 2018 at 06:19:13PM +0100, Daniel P. Berrangé wrote:
> No callers of get_opt_value() pass in a NULL for the "value" parameter,
> so the check is redundant.
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Eduardo Habkost
Queueing on x86-next.
--
Eduardo
On Mon, May 14, 2018 at 06:19:11PM +0100, Daniel P. Berrangé wrote:
> The logic for parsing the multiboot initrd modules was messed up in
>
> commit 950c4e6c94b15cd0d8b638917a8dbf458e6a
> Author: Daniel P. Berrangé
> Date: Mon Apr 16 12:17:43 2018 +0100
>
> opts: don't silently t
On Sat, Jul 14, 2018 at 03:30:00PM +0300, Viktor Prutyanov wrote:
> This patch adds field with content of KERNEL_GS_BASE MSR to QEMU note in
> ELF dump.
>
> On Windows, if all vCPUs are running usermode tasks at the time the dump is
> created, this can be helpful in the discovery of guest system s
On Mon, Jul 16, 2018 at 02:59:32PM +0200, Thomas Huth wrote:
> Valgrind complains:
>
> echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \
> "'arguments':{'typename':'stm32f205-soc'}}" \
> "{'execute': 'human-monitor-command', " \
> "'arguments': {'command-line': 'info
On Mon, 16 Jul 2018, Peter Maydell wrote:
On 16 July 2018 at 20:47, BALATON Zoltan wrote:
Commit 3556c233d 5 years ago added an option to disable QOM debugging,
noting that it can have high performance cost but left the default to on.
Change the default to off and only enable it when debugging
On Mon, Jul 16, 2018 at 02:59:18PM +0200, Thomas Huth wrote:
> A lot of code is using the object_initialize() function followed by a call
> to object_property_add_child() to add the newly initialized object as a child
> of the current object. Both functions increase the reference counter of the
> n
On 16 July 2018 at 21:26, BALATON Zoltan wrote:
> I could list sm501 in the sam460ex section thus formally taking
> sub-maintainership but this would only go as far that I'll get cc-d on
> changes and try to review them. I still can't (and don't want to) maintain
> my own tree and send pull reques
On 16 July 2018 at 20:47, BALATON Zoltan wrote:
> Commit 3556c233d 5 years ago added an option to disable QOM debugging,
> noting that it can have high performance cost but left the default to on.
> Change the default to off and only enable it when debugging is requested
> to avoid the performance
On Mon, 16 Jul 2018, David Gibson wrote:
On Sun, Jul 15, 2018 at 11:29:56AM +0200, BALATON Zoltan wrote:
So before sending more patches I'd like to clear who can review and merge
patches for sm501 in the future and what is the maintainership of this
device?
The unfortunate answer is that there
Quoting Sameeh Jubran (2018-06-24 07:45:40)
> From: Sameeh Jubran
>
> The defrag.exe tool which is used for executing the fstrim command
> on Windows doesn't support retrim for OSes lower than Win8. This
> commit handles this case and returns a suitable error.
>
> Output of fstrim before this co
Quoting Sameeh Jubran (2018-06-26 10:10:38)
> From: Sameeh Jubran
>
> The call to SetupDiGetDeviceRegistryProperty might fail because the
> value doesn't exist in the registry, in this case we shouldn't exit from
> the loop but instead continue to look for other available values in the
> registry
Commit 3556c233d 5 years ago added an option to disable QOM debugging,
noting that it can have high performance cost but left the default to on.
Change the default to off and only enable it when debugging is requested
to avoid the performance penalty for those compiling without debug options.
Sign
When we try to use some targets on ppc64, it can happen the target
doesn't support the host page size to align ELF load sections and
fails with:
ELF load command alignment not page-aligned
Since commit a70daba3771 ("linux-user: Tell guest about big host
page sizes") the host page size is used t
On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote:
[...]
> > +enum CacheType {
> > +DCACHE,
>
> I just noticed this clashes on mips host:
[...]
> In file included from /usr/include/mips-linux-gnu/sys/cachectl.h:26:0,
> from /tmp/qemu-test/src/tcg/mips/tcg-
The bisect is done and this is the result:
5bd5c27c7d284d01477c5cc022ce22438c46bf9f is the first new commit
commit 5bd5c27c7d284d01477c5cc022ce22438c46bf9f
Author: Gerd Hoffmann
Date: Fri Apr 27 13:55:28 2018 +0200
qxl: fix local renderer crash
Make sure we only ask the spice loca
On Mon, Jul 16, 2018 at 09:09:13AM +0200, Thomas Huth wrote:
> On 13.07.2018 23:26, Eduardo Habkost wrote:
> > On Fri, Jul 13, 2018 at 10:27:31AM +0200, Thomas Huth wrote:
> >> When trying to "device_add bcm2837" on a machine that is not suitable for
> >> this device, you can quickly crash QEMU aft
QEMU options have a single dash (but also work as double dash for
convenience and compatibility). Most options are listed with single
dash in command line help but some were listed with two dashes.
Normalize these to have the same format as the others.
Left --preconfig as that is mentioned as doub
* Xiao Guangrong (guangrong.x...@gmail.com) wrote:
>
>
> On 06/14/2018 12:25 AM, Dr. David Alan Gilbert wrote:
> }
> > > static void migration_bitmap_sync(RAMState *rs)
> > > @@ -1412,6 +1441,9 @@ static void flush_compressed_data(RAMState *rs)
> > > qemu_mutex_lock(&comp_param[idx].
On 07/16/2018 11:01 AM, Denis Plotnikov wrote:
> Ping!
>
I never saw a reply to Stefan's question on July 2nd, did you reply
off-list?
--js
> On 29.06.2018 15:40, Denis Plotnikov wrote:
>> There are cases when a request to a block driver state shouldn't have
>> appeared producing dangerous r
* Xiao Guangrong (guangrong.x...@gmail.com) wrote:
>
>
> On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote:
> > * Xiao Guangrong (guangrong.x...@gmail.com) wrote:
> > >
> > > Hi Peter,
> > >
> > > Sorry for the delay as i was busy on other things.
> > >
> > > On 06/19/2018 03:30 PM, Peter X
On Mon, Jul 16, 2018 at 7:47 PM Daniel P. Berrange
wrote:
> On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> > The value argument can be NULL, for example, in hw/i386/multiboot.c
> > in the load_multiboot function get_opt_value is explicitly called
> > with NULL as the second argum
On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote:
> The value argument can be NULL, for example, in hw/i386/multiboot.c
> in the load_multiboot function get_opt_value is explicitly called
> with NULL as the second argument.
>
> The problem was introduced in commit 950c4e6c94b1 ("opts:
Hi
On Mon, Jul 16, 2018 at 7:03 PM, Daniel P. Berrangé wrote:
> On Mon, Jul 16, 2018 at 06:57:48PM +0200, Marc-André Lureau wrote:
>> Hi
>>
>> On Wed, Jul 4, 2018 at 2:08 PM, Daniel P. Berrangé
>> wrote:
>> > On Wed, Jul 04, 2018 at 01:53:03PM +0200, Paolo Bonzini wrote:
>> >> On 04/07/2018 13:
The value argument can be NULL, for example, in hw/i386/multiboot.c
in the load_multiboot function get_opt_value is explicitly called
with NULL as the second argument.
The problem was introduced in commit 950c4e6c94b1 ("opts: don't
silently truncate long option values"). This change fixes the
prob
** Description changed:
[Impact]
- * backport upstream fix to avoid double unmounts (e.g. bind mounts)
-hanging the freeze action.
+ * backport upstream fix to avoid double unmounts (e.g. bind mounts)
+ hanging the freeze action.
[Test Case]
* Prepare a guest
$ uvt-s
I meant the option --enable-opengl and, for old versions, --enable-gtk-
gl. I know it is required to use virtual machines using Intel GVT-g with
dma-buf, and is a option strangely absent from QEMU configuration from
Ubuntu's build. Without it, virgl fails too, making virt-manager have an
option tha
From: "Dr. David Alan Gilbert"
Check calls to qemu_get_virtqueue_element for NULL and pass
up the chain.
Signed-off-by: Dr. David Alan Gilbert
---
hw/block/virtio-blk.c | 4
hw/char/virtio-serial-bus.c | 4
hw/scsi/virtio-scsi.c | 4
3 files changed, 12 insertions(+)
From: "Dr. David Alan Gilbert"
One day I'll figure out how to convert the
virtio load path and qemu_get_virtqeueue_element into
vmstate, but until then clean up some of the error paths.
Dave
Dr. David Alan Gilbert (4):
scsi/migration: Allow bus load request to fail
virtio: Check qemu_get_vi
From: "Dr. David Alan Gilbert"
Make it return NULL rather than assert.
Signed-off-by: Dr. David Alan Gilbert
---
hw/virtio/virtio.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index d4e4d98b59..aedd390240 100644
---
From: "Dr. David Alan Gilbert"
Allow the load_request method on a bus to fail and error
the migration cleanly.
Signed-off-by: Dr. David Alan Gilbert
---
hw/scsi/scsi-bus.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index 5905f6bf29..34a29c2
From: "Dr. David Alan Gilbert"
Rather than asserting, check values and return NULL
on failure.
Signed-off-by: Dr. David Alan Gilbert
---
hw/scsi/virtio-scsi.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
inde
Peter Xu writes:
> Based-on: <20180703085358.13941-1-arm...@redhat.com>
Now in master.
> This work is based on Markus's latest out-of-band fixes:
> "[PATCH v2 00/32] ] qmp: Fixes and cleanups around OOB commands"
>
> Major stuff: some cleanups that were previously suggested by Markus or
> Eri
On Mon, Jul 16, 2018 at 06:57:48PM +0200, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jul 4, 2018 at 2:08 PM, Daniel P. Berrangé
> wrote:
> > On Wed, Jul 04, 2018 at 01:53:03PM +0200, Paolo Bonzini wrote:
> >> On 04/07/2018 13:11, Daniel P. Berrangé wrote:
> >> > The vhostuser network backend requ
Hi
On Wed, Jul 4, 2018 at 2:08 PM, Daniel P. Berrangé wrote:
> On Wed, Jul 04, 2018 at 01:53:03PM +0200, Paolo Bonzini wrote:
>> On 04/07/2018 13:11, Daniel P. Berrangé wrote:
>> > The vhostuser network backend requires the chardev it is using to have
>> > the FD passing feature. It checks this u
In get_page_addr_code(), we were incorrectly looking in the victim
TLB for an entry which matched the target address for reads, not
for code accesses. This meant that we could hit on a victim TLB
entry that indicated that the address was readable but not
executable, and incorrectly bypass the call
From: Thomas Huth
These devices are currently causing some problems when a user is trying
to hot-plug or introspect them during runtime. Since these devices can
not be instantiated by the user at all (they need to be wired up in code
instead), we should mark them with user_creatable = false anywa
From: Guenter Roeck
RX and TX interrupt bits were reversed, resulting in an endless sequence
of serial interupts in the emulated system and the following repeated
error message when booting Linux.
serial8250: too much work for irq61
This results in a boot failure most of the time.
Qemu command
From: Andrew Jeffery
The AST2500 SoC family changes the runtime behaviour of the hardware
strapping register (SCU70) to write-1-set/write-1-clear, with
write-1-clear implemented on the "read-only" SoC revision register
(SCU7C). For the the AST2400, the hardware strapping is
runtime-configured wit
The GICD_ITARGETSR implementation still has some 11MPCore behaviour
that we were incorrectly using in our GICv1 and GICv2 implementations
for the case where the interrupt number is less than GIC_INTERNAL.
The desired behaviour here is:
* for 11MPCore: RAZ/WI for irqs 0..28; read a number matching
In commit 4b1a3e1e34ad97 we added a check for whether the TLB entry
we had following a tlb_fill had the INVALID bit set. This could
happen in some circumstances because a stale or wrong TLB entry was
pulled out of the victim cache. However, after commit
68fea038553039e (which prevents stale entri
From: Richard Henderson
'I' was being double-incremented; correctly within the inner loop
and incorrectly within the outer loop.
Signed-off-by: Richard Henderson
Reviewed-by: Laurent Desnogues
Reviewed-by: Alex Bennée
Tested-by: Alex Bennée
Message-id: 20180711103957.3040-1-richard.hender...
aydell/qemu-arm.git
tags/pull-target-arm-20180716
for you to fetch changes up to 3474c98a2a2afcefa7c665f02ad2bed2a43ab0f7:
accel/tcg: Assert that tlb fill gave us a valid TLB entry (2018-07-16
17:26:01 +0100)
target-arm queue:
* ac
In gic_deactivate_irq() the interrupt number comes from the guest
(on a write to the GICC_DIR register), so we need to sanity check
that it isn't out of range before we use it as an array index.
Handle this in a similar manner to the check we do in
gic_complete_irq() for the GICC_EOI register.
The
1 - 100 of 266 matches
Mail list logo
