From: Jia He
In case the STE's config is "Bypass" we currently don't set the
IOMMUTLBEntry perm flags and the access does not succeed. Also
if the config is 0b0xx (Aborted/Reserved), decode_ste and
smmuv3_decode_config currently returns -EINVAL and we don't enter
the expected code path: we record
On 07-06-2018 12:56, Richard Henderson wrote:
On 06/07/2018 06:27 AM, Davidson Francis wrote:
Dear all,
Currently Qemu supports only 2 cores when SMP enabled for or1k architecure, so
I would like to know if there is a quick way to increase the number of cores by
changing a few lines of code or
On Thu, Jun 07, 2018 at 01:40:22PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > There was a regression reported by Eric Auger before with OOB:
> >
> > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html
> >
> > The fix is 951702f39c ("monitor: bind dispatch bh to ioha
Philippe Mathieu-Daudé writes:
> Use error_report() + exit() instead of error_setg(&error_fatal),
> as suggested by the "qapi/error.h" documentation:
>
>Please don't error_setg(&error_fatal, ...), use error_report() and
>exit(), because that's more obvious.
>
> This fixes CID 1352173:
>
On Fri, Jun 08, 2018 at 07:38:11AM +0200, Markus Armbruster wrote:
[...]
> > +/*
> > + * This should never be called before configure_accelerator() since
> > + * only until then could we know whether qtest was enabled or not.
>
> Uh, we know it after then, not until then. What about
>
>/*
David Gibson writes:
> On Fri, Jun 08, 2018 at 12:54:36AM -0300, Philippe Mathieu-Daudé wrote:
>> Hi David,
>>
>> On 06/08/2018 12:03 AM, David Gibson wrote:
>> > On Thu, Jun 07, 2018 at 11:46:43AM -0300, Philippe Mathieu-Daudé wrote:
>> >> Use abort() instead of error_setg(&error_abort),
>> >>
From: Prasad J Pandit
While reassembling incoming fragmented datagrams, 'm_cat' routine
extends the 'mbuf' buffer, if it has insufficient room. It computes
a wrong buffer size, which leads to overwriting adjacent heap buffer
area. Correct this size computation in m_cat.
Reported-by: ZDI Disclosu
Move check to where it actually is useful, and reduce scope of 'len'
variable along the way.
Signed-off-by: Samuel Thibault
Reviewed-by: Philippe Mathieu-Daudé
---
slirp/socket.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/slirp/socket.c b/slirp/socket.c
i
The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
staging (2018-06-01 14:58:53 +0100)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.git tags/samuel-thibau
The change missed the 2.12 deadline.
Signed-off-by: Samuel Thibault
Reviewed-by: Eric Blake
---
qapi/net.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/net.json b/qapi/net.json
index 32681a1af7..6b7d93cb59 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -161,7 +
From: Prasad J Pandit
Coding style changes to the m_inc routine and minor refactoring.
Reported-by: ZDI Disclosures
Signed-off-by: Prasad J Pandit
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff
Signed-off-by: Samuel Thibault
Acked-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..4c73c16fee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1675,6 +1675,7 @@ S: Maintained
F: slirp/
F: net/slirp.c
F: include/ne
John Snow writes:
> On 06/07/2018 10:46 AM, Philippe Mathieu-Daudé wrote:
>> Use assert() instead of error_setg(&error_abort),
>> as suggested by the "qapi/error.h" documentation:
>>
>> Please don't error_setg(&error_fatal, ...), use error_report() and
>> exit(), because that's more obvi
Signed-off-by: Fam Zheng
---
block/block-backend.c | 36 ++
include/sysemu/block-backend.h | 4
2 files changed, 40 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index e20a204bee..36d928e13d 100644
--- a/block/block-backen
This makes the mirror job to try offloaded copy. If it fails, error
action will not be taken yet, instead the failed cluster and all the
subsequent ones will fall back to bounce buffer.
Signed-off-by: Fam Zheng
---
block/mirror.c | 71 +-
block/tra
BlkRwCo fields are multi-purposed. @offset is sometimes used to pass the
'req' number for blk_ioctl and blk_aio_ioctl; @iobuf is sometimes the
pointer for QEMUIOVector @qiov sometimes the ioctl @buf. This is not as
clean as it can be. As the coming copy range emulation wants to add
more differentia
This avoids the wasteful cluster allocation in qcow2 before actually
trying an unsupported copy range call, for example.
Signed-off-by: Fam Zheng
---
block.c | 12
block/file-posix.c| 9 +
block/io.c| 3 +++
block/iscsi.c
Similar to bdrv_co_block_status_from_backing we add the two passthrough
callbacks for copy_range. This will be used by the block driver filters
so that they can support copy offloading.
Signed-off-by: Fam Zheng
---
block/io.c| 24
include/block/block_int.
EINTR should be checked against errno, not ret. While fixing the bug,
collecting the branches with a switch block.
Signed-off-by: Fam Zheng
---
block/file-posix.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
in
This is the third part of copy offloading work. The first patches are fixes and
improvements in preparation for enabling mirror job. The last patch does a
similar change to the backup patch: it inserts a blk_aio_copy_range call before
the usual bounce buffer code in mirror_iteration.
Fam Zheng (6)
Marking as fixed, according to comment #13
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1636217
Title:
qemu-kvm 2.7 does not boot kvm VMs wi
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" writes:
>>
>> > * Markus Armbruster (arm...@redhat.com) wrote:
>> >> Peter Xu writes:
>> >>
>> >> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
>> >> > wro
On 06.06.2018 15:14, Samuel Thibault wrote:
> Ping? I'm not sure who I am supposed to get a review from, or if I have
> to have one at all?
>
> Samuel
>
> Samuel Thibault, le jeu. 31 mai 2018 21:48:43 +0200, a ecrit:
>> Signed-off-by: Samuel Thibault
>> ---
>> MAINTAINERS | 1 +
>> 1 file chang
On 07.06.2018 23:08, Philippe Mathieu-Daudé wrote:
> Remove the 'stair-step output' on stdio.
>
> This partially reverts commit 12fb0ac05, which was correct
> on the mailing list but got corrupted by the maintainer :p
>
> Introduced-by: 3b876140-c035-dd39-75d0-d54c48128...@redhat.com
> Reported-b
On Fri, Jun 08, 2018 at 12:22:38AM +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, Jun 4, 2018 at 10:58 AM, Gerd Hoffmann wrote:
> >> +#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci"
> >
> > Patch $subject mismatch.
> >
> >> +struct VHostUserInput {
> >> +VirtIOInput
Igor Mammedov writes:
> On Thu, 07 Jun 2018 14:22:34 +0200
> Markus Armbruster wrote:
>
>> Peter Xu writes:
>>
>> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
>> > wrote:
>> >> From: "Dr. David Alan Gilbert"
>> >>
>> >> Allow a bunch of the info commands to be
On 08.06.2018 00:31, Ross Zwisler wrote:
> This commit:
>
> commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0")
>
> updated the name used to create the q35 machine, which in turn changed the
> SSDT table which is generated when we run "make check":
>
> acpi-test: Warning! SSDT mi
Peter Xu writes:
> Instead, use a dynamic function to detect which clock we'll use. The
> problem is that the old code will let monitor initialization depend on
> configure_accelerator() (that's where qtest_enabled() start to take
> effect). After this change, we don't have such a dependency an
On 08.06.2018 00:31, Ross Zwisler wrote:
> Normally this might not be worth fixing, but several of these are strings
> which are displayed to users.
>
> Signed-off-by: Ross Zwisler
> ---
> hw/core/machine.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/core/m
Eric Blake writes:
> On 06/07/2018 10:23 AM, Anton Nefedov wrote:
If we introduce BlockdevDriver as a discriminator as Markus suggests
above, we need some way to define its value.
I guess one would be to check blk->bs->drv->format_name but it won't
always work; often it's even
On 08.06.2018 01:09, Michael S. Tsirkin wrote:
> On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote:
>> Currently if "make check" detects a mismatch in the ASL generated during
>> testing, we print an error such as:
>>
>> acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.ds
Dear all:
I just switched from graphic/media field to virtualization at the end of the
last year,
so I am sorry that though I have already try my best but I still feel a little
dizzy
about your previous discussion about NVDimm via block layer:)
In today's qemu, we use the SaveVMHandlers function
On Thu, Jun 07, 2018 at 01:53:01PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > Previously we cleanup the queues when we got CLOSED event. It was used
>
> we clean up
>
> > to make sure we won't leftover replies/events of a old client to a new
>
> we won't send leftover replies/ev
On Fri, Jun 08, 2018 at 12:54:36AM -0300, Philippe Mathieu-Daudé wrote:
> Hi David,
>
> On 06/08/2018 12:03 AM, David Gibson wrote:
> > On Thu, Jun 07, 2018 at 11:46:43AM -0300, Philippe Mathieu-Daudé wrote:
> >> Use abort() instead of error_setg(&error_abort),
> >> as suggested by the "qapi/error
On Thu, Jun 07, 2018 at 06:52:17PM +0200, David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug() to make plug/unplug code
> look symmetrical.
>
> Acked-by: Igor Mammedov
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 12 +++-
> 1 f
On Thu, Jun 07, 2018 at 06:52:15PM +0200, David Hildenbrand wrote:
> We'll be handling unplug of e.g. CPUs and PCDIMMs via the general
> hotplug handler soon, so let's add that handler function.
>
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 6 ++
>
On Thu, Jun 07, 2018 at 06:52:12PM +0200, David Hildenbrand wrote:
> The node property can always be queried and the value has already been
> verified in pc_dimm_realize().
>
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 9 +
> 1 file changed, 1 in
On Thu, Jun 07, 2018 at 06:52:14PM +0200, David Hildenbrand wrote:
> Let's introduce and use local error variables in the hotplug handler
> functions.
>
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 29 -
> 1 file changed, 20 in
On Thu, Jun 07, 2018 at 06:52:13PM +0200, David Hildenbrand wrote:
> Let's clean the hotplug handler up by moving everything into
> spapr_memory_plug().
>
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 23 ++-
> 1 file changed, 10 insert
On Thu, Jun 07, 2018 at 06:52:16PM +0200, David Hildenbrand wrote:
> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/
> unplug memory devices (which a pc-dimm is) later.
>
> Signed-off-by: David Hildenbrand
Acked-by: David Gibson
> ---
> hw/ppc/spapr.c | 18 +++
Fix typo in d622cb5879c. Meanwhile move these variables close to each
other. monitor_qapi_event_state can be declared static, add that.
Reported-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
monitor.c | 7 +++
1 file change
Introduce a new global big lock for mon_fdsets. Take it where needed.
The monitor_fdset_get_fd() handling is a bit tricky: now we need to call
qemu_mutex_unlock() which might pollute errno, so we need to make sure
the correct errno be passed up to the callers. To make things simpler,
we let moni
Before this patch, monitor fd helpers might be called even earlier than
monitor_init_globals(). This can be problematic.
After previous work, now monitor_init_globals() does not depend on
accelerator initialization any more. Call it earlier (before CLI
parsing; that's where the monitor APIs migh
Add some explicit comments for both Readline and cpu_set/cpu_get helpers
that they do not need the mon_lock protection.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
monitor.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --gi
v10:
- collect r-bs
- comment/renice the function monitor_get_clock(), add some commit
message [Stefan, Markus]
v9:
- two more patches to implement Markus's idea to init monitor earlier
(which are patch 5 & 6)
- touch up patch 7 to init the fdset lock in monitor_init_globals()
v8:
- some word
The out_lock is protecting a few Monitor fields. In the future the
monitor code will start to run in multiple threads. We are going to
turn it into a bigger lock to protect not only the out buffer but also
most of the rest.
Since at it, rearrange the Monitor struct a bit.
Reviewed-by: Stefan Ha
Instead, use a dynamic function to detect which clock we'll use. The
problem is that the old code will let monitor initialization depend on
configure_accelerator() (that's where qtest_enabled() start to take
effect). After this change, we don't have such a dependency any more.
We just need to mak
Hi David,
On 06/08/2018 12:03 AM, David Gibson wrote:
> On Thu, Jun 07, 2018 at 11:46:43AM -0300, Philippe Mathieu-Daudé wrote:
>> Use abort() instead of error_setg(&error_abort),
>> as suggested by the "qapi/error.h" documentation:
>>
>> Please don't error_setg(&error_fatal, ...), use error_r
On Thu, Jun 07, 2018 at 04:32:54PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > Instead, use a dynamic function to detect which clock we'll use. The
> > problem is that the old code will let monitor initialization depends on
> > qtest_enabled(). After this change, we don't have such
mon->fds were protected by BQL. Now protect it by mon_lock so that it
can even be used in monitor iothread.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Peter Xu
---
monitor.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --g
Hi Peter,
On 01/09/2018 11:01 AM, Peter Maydell wrote:
> Since omap_mmc is still using the legacy SD card API, the SD
> card created by sd_init() is not plugged into any bus. This
> means that the controller has to reset it manually.
>
> Failing to do this mostly didn't affect the guest since the
On Fri, Jun 08, 2018 at 05:49:26AM +0300, Michael S. Tsirkin wrote:
> On Fri, Jun 08, 2018 at 10:34:25AM +0800, Peter Xu wrote:
> > On Fri, Jun 08, 2018 at 04:58:21AM +0300, Michael S. Tsirkin wrote:
> > > On Fri, Jun 08, 2018 at 09:37:23AM +0800, Peter Xu wrote:
> > > > > > Asked since I see this
On Wed, Jun 06, 2018 at 09:33:53AM +0200, Cédric Le Goater wrote:
> POWER9 introduced a new variant of the eieio instruction using bit 6
> as a hint to tell the CPU it is a store-forwarding barrier.
>
> The usage of this eieio extension was recently added in Linux 4.17
> which activated the "suppo
On Thu, Jun 07, 2018 at 11:46:43AM -0300, Philippe Mathieu-Daudé wrote:
> Use abort() instead of error_setg(&error_abort),
> as suggested by the "qapi/error.h" documentation:
>
> Please don't error_setg(&error_fatal, ...), use error_report() and
> exit(), because that's more obvious.
>
On Thu, Jun 07, 2018 at 11:46:45AM -0300, Philippe Mathieu-Daudé wrote:
> Use error_report() + exit() instead of error_setg(&error_fatal),
> as suggested by the "qapi/error.h" documentation:
>
>Please don't error_setg(&error_fatal, ...), use error_report() and
>exit(), because that's more
THese leaks are found by ASAN with CPU hot-add and hot-del actions,
such as:
==14127==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4096 byte(s) in 1 object(s) allocated from:
#0 0x7fc321cb6ec0 in posix_memalign
(/usr/local/gcc-6-4/lib64/libasan.so.3+0xc7ec0)
#1 0xf756b9 in q
On Fri, Jun 08, 2018 at 10:34:25AM +0800, Peter Xu wrote:
> On Fri, Jun 08, 2018 at 04:58:21AM +0300, Michael S. Tsirkin wrote:
> > On Fri, Jun 08, 2018 at 09:37:23AM +0800, Peter Xu wrote:
> > > > > Asked since I see this in virtio spec (v1.0, though I guess it won't
> > > > > change) in chapter "
From: Junyan He
Because we need to make sure the pmem kind memory data is synced
after migration, we choose to call pmem_persist() when the migration
finish. This will make sure the data of pmem is safe and will not
lose if power is off.
Signed-off-by: Junyan He
---
include/qemu/pmem.h | 1 +
On Fri, Jun 08, 2018 at 04:58:21AM +0300, Michael S. Tsirkin wrote:
> On Fri, Jun 08, 2018 at 09:37:23AM +0800, Peter Xu wrote:
> > > > Asked since I see this in virtio spec (v1.0, though I guess it won't
> > > > change) in chapter "2.2.1 Driver Requirements: Feature Bits":
> > > >
> > > > "The dr
On Thu, Jun 07, 2018 at 07:59:22PM +0800, Wei Wang wrote:
> On 06/07/2018 02:32 PM, Peter Xu wrote:
> > On Thu, Jun 07, 2018 at 01:24:29PM +0800, Wei Wang wrote:
> > > On 06/06/2018 07:02 PM, Peter Xu wrote:
> > > > On Wed, Jun 06, 2018 at 06:04:23PM +0800, Wei Wang wrote:
> > > > > On 06/06/2018 0
On Thu, Jun 07, 2018 at 06:17:47PM +0100, Mark Cave-Ayland wrote:
> Whilst performing a random migration test for the Mac machines I noticed
> a regression (patch 1) which prevented the loadvm from completing
> successfully. A big thank you to Peter and David on IRC who pointed me
> in the right di
On Thu, Jun 07, 2018 at 06:17:49PM +0100, Mark Cave-Ayland wrote:
> Examining the migration stream it can be seen that the mos6522 device state is
> being stored separately rather than as part of the CUDA device which is
> incorrect (and likely to cause issues if another mos6522 device is added to
On Thu, Jun 07, 2018 at 05:59:52PM +0100, Mark Cave-Ayland wrote:
> Here are some trivial Mac fixes taken from various working branches in my
> local git repository. Since they should need minimal review it seems
> worthwhile to send them separately.
>
> Signed-off-by: Mark Cave-Ayland
Applied t
On Fri, Jun 08, 2018 at 09:37:23AM +0800, Peter Xu wrote:
[...]
> > > Asked since I see this in virtio spec (v1.0, though I guess it won't
> > > change) in chapter "2.2.1 Driver Requirements: Feature Bits":
> > >
> > > "The driver MUST NOT accept a feature which the device did not offer"
> > >
On Fri, Jun 08, 2018 at 09:37:23AM +0800, Peter Xu wrote:
> > > Asked since I see this in virtio spec (v1.0, though I guess it won't
> > > change) in chapter "2.2.1 Driver Requirements: Feature Bits":
> > >
> > > "The driver MUST NOT accept a feature which the device did not offer"
> > >
> > > Th
On Thu, Jun 07, 2018 at 08:01:42PM +0800, Wei Wang wrote:
> On 06/07/2018 02:58 PM, Peter Xu wrote:
> > On Thu, Jun 07, 2018 at 01:29:22PM +0800, Wei Wang wrote:
> > > > > > [...]
> > > > > > > +static const VMStateDescription
> > > > > > > vmstate_virtio_balloon_free_page_report = {
> > > > > > >
Hi Eric
On 6/8/2018 1:06 AM, Auger Eric Wrote:
> Hi Jia,
>
> On 06/07/2018 03:38 PM, Jia He wrote:
>> There is an exception when I passes iommu.passthrough=1 to guest's
>> kernel boot parameter(host QDF2400 kernel 4.17, guest kernel 4.14).
>> The guest will be hang when booting up.
>>
>> When gue
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180608000540.276617-1-...@redhat.com
Subject: [Qemu-devel] [PATCH] kvm: support -realtime cpu-pm=on|off
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
With this flag, kvm allows guest to control host CPU power state. This
increases latency for other processes using same host CPU in an
unpredictable way, but if decreases idle entry/exit times for the
running VCPU.
Follow-up patches will expose this capability to guest
(using mwait leaf).
Based
On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote:
> This commit:
>
> commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0")
>
> updated the name used to create the q35 machine, which in turn changed the
> SSDT table which is generated when we run "make check":
>
> acpi-t
On Thu, Jun 07, 2018 at 04:31:08PM -0600, Ross Zwisler wrote:
> Currently if "make check" detects a mismatch in the ASL generated during
> testing, we print an error such as:
>
> acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl,
> aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-
Replace the "nvdimm-cap" option which took numeric arguments such as "2"
with a more user friendly "nvdimm-persistence" option which takes symbolic
arguments "cpu" or "mem-ctrl".
Signed-off-by: Ross Zwisler
Suggested-by: Michael S. Tsirkin
Suggested-by: Dan Williams
---
docs/nvdimm.txt
With a fully built QEMU I currently see the following with "git status":
Untracked files:
(use "git add ..." to include in what will be committed)
qapi/qapi-commands-job.c
qapi/qapi-commands-job.h
qapi/qapi-events-job.c
qapi/qapi-events-job.h
qapi/qap
Hi
On Mon, Jun 4, 2018 at 11:36 AM, Daniel P. Berrangé wrote:
> On Fri, Jun 01, 2018 at 06:27:41PM +0200, Marc-André Lureau wrote:
>> Create a vhost-user-backend object that holds a connection to a
>> vhost-user backend and can be referenced from virtio devices that
>> support it. See later patch
This commit:
commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0")
updated the name used to create the q35 machine, which in turn changed the
SSDT table which is generated when we run "make check":
acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl,
aml:/tmp/aml-T
Currently if "make check" detects a mismatch in the ASL generated during
testing, we print an error such as:
acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl,
aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-DTWVJZ.dsl,
aml:tests/acpi-test-data/q35/SSDT.dimmpxm].
but the testi
Normally this might not be worth fixing, but several of these are strings
which are displayed to users.
Signed-off-by: Ross Zwisler
---
hw/core/machine.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 617e5f8d75..a21269fa39 1
Hi
On Mon, Jun 4, 2018 at 10:58 AM, Gerd Hoffmann wrote:
>> +#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci"
>
> Patch $subject mismatch.
>
>> +struct VHostUserInput {
>> +VirtIOInput parent_obj;
>> +
>> +VhostUserBackend *vhost;
>> +};
>
>
On Thu, Jun 07, 2018 at 05:47:03PM +0200, David Hildenbrand wrote:
> We can currently hit two asserts. Let's fix those.
>
> Patch nr. 1 is a result from:
> "[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers"
>
> We treat right now any alignment > 1GB as a violation, as it would
On Wed, Jun 06, 2018 at 07:06:27PM +0200, Max Reitz wrote:
> On 2018-06-06 17:09, Michael S. Tsirkin wrote:
> > On Wed, Jun 06, 2018 at 04:51:39PM +0200, Max Reitz wrote:
> >> On 2018-06-06 16:31, Dr. David Alan Gilbert wrote:
> >>> * Max Reitz (mre...@redhat.com) wrote:
> On 2018-06-06 14:00,
On Thu, Jun 07, 2018 at 08:25:40AM +0200, Markus Armbruster wrote:
> This series is RFC because:
>
> * It clashes with parts of Max's "[PATCH 00/13] block: Try to create
> well typed json:{} filenames". I missed that one until too late,
> sorry.
>
> - I stole "[PATCH 06/13] block: Add bloc
On Thu, Jun 07, 2018 at 12:54:33PM +0200, Andrea Bolognani wrote:
> On Thu, 2018-06-07 at 11:36 +0100, Daniel P. Berrangé wrote:
> > On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones wrote:
> > > Another problem which Laszlo mentioned is the varstore isn't portable
> > > between UEFI imp
On Thu, Jun 07, 2018 at 11:36:20AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 07, 2018 at 11:32:18AM +0100, Richard W.M. Jones wrote:
> > On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote:
> > > Something that I haven't seen mentioned in the thread - and this
> > > looks like as
On 06/07/2018 05:17 PM, Peter Maydell wrote:
> On 7 June 2018 at 20:18, Philippe Mathieu-Daudé wrote:
>> You forgot patch 5 "vmstate: Remove VMSTATE_TIMER_PTR_TEST" :)
>
> It's a generic macro that might have utility in future,
> and it fits into a slot in the matrix of possible VMSTATE
> macros,
Remove the 'stair-step output' on stdio.
This partially reverts commit 12fb0ac05, which was correct
on the mailing list but got corrupted by the maintainer :p
Introduced-by: 3b876140-c035-dd39-75d0-d54c48128...@redhat.com
Reported-by: BALATON Zoltan
Suggested-by: Thomas Huth
Tested-by: Laurent
Public bug reported:
After upgrading Windows 10 guest to version 1803, guests VM runs slower
and there is high host CPU load even when guest is almost idle. Did not
happened with windows 10 up to version 1709.
See my 1st report here:
https://askubuntu.com/questions/1033985/kvm-high-host-cpu-load-
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Message-id: 20180606205629.66987-1-...@google.com
Subject: [Qemu-devel] [PATCH] Improve file-backed RAM
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
Hi,
> > I could be wrong, but I feel like it's significantly less likely
> > that a random QEMU binary won't like a random EFI ROM than it is
> > for a random EFI ROM to not like a random EFI NVRAM.
>
> True, but it's not that rare to find SeaBIOS+qemu version problems;
Hmm? Any recent exampl
Le 12/05/2018 à 07:02, Richard Henderson a écrit :
> [ Ho, hum. I didn't clear out my scratch directory before sending v1.0. ]
>
> FYI, I've only tested this with linux-user-test-0.3 and
> our qemu coldfire testing kernel.
>
>
> r~
>
>
> Richard Henderson (9):
> target/m68k: Use DISAS_NORET
On 7 June 2018 at 20:18, Philippe Mathieu-Daudé wrote:
> You forgot patch 5 "vmstate: Remove VMSTATE_TIMER_PTR_TEST" :)
It's a generic macro that might have utility in future,
and it fits into a slot in the matrix of possible VMSTATE
macros, so I wouldn't bother. (It's kind of irritating that we
Le 07/06/2018 à 20:56, no-re...@patchew.org a écrit :
...
> === OUTPUT BEGIN ===
> Checking PATCH 1/4: linux-user/alpha: Fix epoll syscalls...
> ERROR: code indent should never use tabs
> #22: FILE: linux-user/alpha/syscall_nr.h:346:
> +#define TARGET_NR_epoll_create^I^I407$
>
> ERROR: code indent
Le 07/06/2018 à 20:48, Richard Henderson a écrit :
> Signed-off-by: Richard Henderson
> ---
> linux-user/sparc64/syscall_nr.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/sparc64/syscall_nr.h b/linux-user/sparc64/syscall_nr.h
> index 9391645598..0b91b89
Le 07/06/2018 à 20:48, Richard Henderson a écrit :
> Signed-off-by: Richard Henderson
> ---
> linux-user/microblaze/syscall_nr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/microblaze/syscall_nr.h
> b/linux-user/microblaze/syscall_nr.h
> index 0704449bae.
Le 07/06/2018 à 20:48, Richard Henderson a écrit :
> Signed-off-by: Richard Henderson
> ---
> linux-user/hppa/syscall_nr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/hppa/syscall_nr.h b/linux-user/hppa/syscall_nr.h
> index 55bdf71d50..9c1d0a195d 100644
>
Le 07/06/2018 à 20:48, Richard Henderson a écrit :
> These were named incorrectly, going so far as to invade strace.list.
>
> Signed-off-by: Richard Henderson
> ---
> linux-user/alpha/syscall_nr.h | 6 +++---
> linux-user/strace.list| 9 -
> 2 files changed, 3 insertions(+), 12 d
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180607184844.30126-1-richard.hender...@linaro.org
Subject: [Qemu-devel] [PATCH 0/4] linux-user: syscall number fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
to
On 06/07/18 12:51, Andrea Bolognani wrote:
> On Thu, 2018-06-07 at 11:32 +0100, Richard W.M. Jones wrote:
>> On Thu, Jun 07, 2018 at 12:02:29PM +0200, Andrea Bolognani wrote:
>>> Something that I haven't seen mentioned in the thread - and this
>>> looks like as good a point as any to jump in - is t
On 06/07/2018 03:48 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
04 since '09: 8dfbe4e839e.
Reviewed-by: Philippe Mathieu-Daudé
> ---
> linux-user/microblaze/syscall_nr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/microblaze/syscall
On 7 June 2018 at 18:17, Mark Cave-Ayland wrote:
> The timers are configured in the mos6522 init function and therefore will
> always exist, so the function can never return false.
>
> Peter also pointed out that this is the only remaining user of
> VMSTATE_TIMER_PTR_TEST in the codebase, so we mi
On 06/07/2018 03:48 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
mknodat is not at 8ee78dece0d.
Reviewed-by: Philippe Mathieu-Daudé
> ---
> linux-user/hppa/syscall_nr.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/hppa/syscall_nr.h b/
1 - 100 of 423 matches
Mail list logo
