Re: [Qemu-devel] [Qemu-arm] [PATCH v2 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR

On 2018/5/22 17:13, Peter Maydell wrote: > On 8 April 2018 at 02:50, Shannon Zhao wrote: >> On 2018/4/6 17:36, Peter Maydell wrote: >>> On reflection, I think I'd aim for 2.13 for this, since: >>> * it's not a regression >>> * it doesn't actually affect any of our boards, because >>>none o

Re: [Qemu-devel] [PATCH 14/27] iommu: Add IOMMU index concept to IOMMU API

On Wed, May 23, 2018 at 12:47:16PM +0100, Peter Maydell wrote: > On 23 May 2018 at 02:06, Peter Xu wrote: > > On Tue, May 22, 2018 at 12:11:38PM +0100, Peter Maydell wrote: > >> On 22 May 2018 at 12:02, Peter Xu wrote: > >> > On Tue, May 22, 2018 at 09:40:44AM +0100, Peter Maydell wrote: > > >>

Re: [Qemu-devel] [PATCH v2] Remove unwanted crlf conversion in serial

Patryk Olszewski writes: > This patch fixes bug in serial that made it almost impossible for guest > to communicate with devices through host's serial. Well, "almost impossible" for some applications. Text works fine. But I get what you mean. > OPOST flag in c_oflag enables output processing

Re: [Qemu-devel] [PATCH] block: fix QEMU crash with scsi-hd and drive_del

On 23/05/2018 16:46, Greg Kurz wrote: > Maybe change bdrv_root_unref_child() to ensure we don't call > bdrv_close() with pending I/O requests ? > > void bdrv_root_unref_child(BdrvChild *child) > { > BlockDriverState *child_bs; > > child_bs = child->bs; > +bdrv_drained_begin(child

Re: [Qemu-devel] [PATCH] ppc: move at24c to its own CONFIG_ symbol

On 22/05/2018 21:17, Paolo Bonzini wrote: > AT24c EEPROM is currently gated by CONFIG_I2C, and as such it is > being included in all emulators that use I2C, even if they do not > really need it. Separate it and, since it was added for the e500 > machines, add it to qemu-system-ppc and qemu-system-

Re: [Qemu-devel] [PATCH v3 00/19] reverse debugging

> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > On Wed, May 23, 2018 at 2:28 PM, Pavel Dovgalyuk wrote: > >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > >> On Wed, May 23, 2018 at 7:49 AM, Pavel Dovgalyuk > >> wrote: > >> > GDB remote protocol supports reverse debugging of the

[Qemu-devel] [PATCH] prep: fix keyboard for the 40p machine

Commit 72d3d8f052 "hw/isa/superio: Add a keyboard/mouse controller (8042)" added an 8042 keyboard device to the PC87312 superio device to replace that being used by the prep machine. Unfortunately this commit didn't do the same for the 40p machine which broke the keyboard by registering two 8042 k

Re: [Qemu-devel] [PATCH v2] Remove unwanted crlf conversion in serial

On 23.05.2018 21:50, Patryk Olszewski wrote: > This patch fixes bug in serial that made it almost impossible for guest > to communicate with devices through host's serial. > > OPOST flag in c_oflag enables output processing letting other flags in > c_oflag take effect. Usually in c_oflag ONLCR fla

[Qemu-devel] [Bug 1722074] Re: warning: host doesn't support requested feature: CPUID.01H:ECX.vmx

Hi, this is not a show stopper at all. It is just a warning and it is fine. It is a trade-off between the "ease to use nested virt" vs "this warning". For example on an intel chip you'd get: qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.8001H:ECX.svm And that as

[Qemu-devel] [Bug 1722074] Re: warning: host doesn't support requested feature: CPUID.01H:ECX.vmx

And sorry for the status update noise, one can clearly see that I start to fail once I have to use my mouse :-) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1722074 Title: warning: host doesn't su

[Qemu-devel] [Bug 1722074] Re: warning: host doesn't support requested feature: CPUID.01H:ECX.vmx

** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Changed in: qemu Status: New => Incomplete ** Changed in: qemu Status: Incomplete => Opinion ** Changed in: qemu Status: Opinion => Invalid ** Changed in: qemu (Ubuntu) Status: New => Incom

[Qemu-devel] [PATCH v4 1/2] qemu-error: introduce {error|warn}_report_once

There are many error_report()s that can be used in frequently called functions, especially on IO paths. That can be unideal in that malicious guest can try to trigger the error tons of time which might use up the log space on the host (e.g., libvirt can capture the stderr of QEMU and put it persis

Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180524043952.11245-1-pet...@redhat.com Subject: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$

[Qemu-devel] [PATCH v4 0/2] error-report: introduce {error|warn}_report_once

v4: - patch 2: pick r-b from Philippe - patch 1: replace all __* variables into *_ [Eric] - patch 1: enhance the commit message of patch 1, mention return code of macros [Markus] v3: - reindent in patch 2, dump more things [Philippe] v2: - for patch 1: replace tabs, add trivial comment [Markus]

[Qemu-devel] [PATCH v4 2/2] intel-iommu: start to use error_report_once

Replace existing trace_vtd_err() with error_report_once() then stderr will capture something if any of the error happens, meanwhile we don't suffer from any DDOS. Then remove the trace point. Since at it, provide more information where proper (now we can pass parameters into the report function).

[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets

Similar to previous patch, but introduce a new global big lock for mon_fdsets. Take it where needed. The monitor_fdset_get_fd() handling is a bit tricky: now we need to call qemu_mutex_unlock() which might pollute errno, so we need to make sure the correct errno be passed up to the callers. To m

[Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs

Add some explicit comment for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index d6c3c08932..f01589f945 100644

[Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe

v7: - let monitor_fdset_get_fd() return -errno, touch up qemu_open() to translate that into errno. [Markus] - touch up comment for Monitor.rs - rebase, and torture the code a bit with qtest. v6: - add/drop some r-bs - address all the comments from Markus - rebase, and run some simple qtests to

[Qemu-devel] [PATCH v7 2/4] monitor: protect mon->fds with mon_lock

mon->fds were protected by BQL. Now protect it by mon_lock so that it can even be used in monitor iothread. Reviewed-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- monitor.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock

The out_lock is protecting a few Monitor fields. In the future the monitor code will start to run in multiple threads. We are going to turn it into a bigger lock to protect not only the out buffer but also all the rest. Since at it, rearrange the Monitor struct a bit. Reviewed-by: Stefan Hajnoc

Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs

On Wed, May 23, 2018 at 05:15:26PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, May 23, 2018 at 10:29:37AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > On Thu, May 17, 2018 at 02:46:36PM +0200, Markus Armbruster wrote: > >> >> Peter Xu writes: > >> >>

Re: [Qemu-devel] [PATCH v3] monitor: let cur_mon be per-thread

On Wed, May 23, 2018 at 03:13:07PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Wed, May 23, 2018 at 10:23:22AM +0200, Markus Armbruster wrote: > >> Peter Xu writes: > >> > >> > In the future the monitor iothread may be accessing the cur_mon as > >> > well (via monitor_qmp_dispat

Re: [Qemu-devel] [PATCH] tests: Allow GTESTER_OPTIONS variable expansion from command line

On 05/23/2018 03:33 PM, Thomas Huth wrote: > On 23.05.2018 13:57, Philippe Mathieu-Daudé wrote: >> The gtester utility offers the "-p=TESTPATH" option to >> "only run test cases matching TESTPATH". We already use >> a $GTESTER_OPTIONS variable. >> Use make variable expansion to allow qtest path ma

Re: [Qemu-devel] [PATCH v2 2/2] intel-iommu: start to use error_report_once

On 05/22/2018 10:19 PM, Peter Xu wrote: > On Tue, May 22, 2018 at 06:09:46PM -0300, Philippe Mathieu-Daudé wrote: >> Hi Peter, >> >> On 05/22/2018 12:56 AM, Peter Xu wrote: >>> Replace existing trace_vtd_err() with error_report_once() then stderr >>> will capture something if any of the error happe

Re: [Qemu-devel] [PATCH v2 1/2] qemu-error: introduce {error|warn}_report_once

On Wed, May 23, 2018 at 10:47:29AM -0500, Eric Blake wrote: > On 05/21/2018 10:56 PM, Peter Xu wrote: > > I stole the printk_once() macro. > > > > I always wanted to be able to print some error directly if there is a > > buffer to dump, however we can't use error_report() where the code path > > c

Re: [Qemu-devel] [PATCH v4 9/9] intel-iommu: rework the page walk logic

On Wed, May 23, 2018 at 05:33:34PM +0300, Michael S. Tsirkin wrote: > On Fri, May 18, 2018 at 03:25:17PM +0800, Peter Xu wrote: > > SECURITY IMPLICATION: this patch will fix a potential small window that > > the DMA page table might be incomplete or invalid when the guest sends > > domain/context i

Re: [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state

On Thu, May 24, 2018 at 07:21:01AM +0800, Tiwei Bie wrote: > On Wed, May 23, 2018 at 06:43:29PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 23, 2018 at 06:36:05PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 23, 2018 at 04:44:51PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 12,

Re: [Qemu-devel] [PULL 00/46] Block layer patches

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180523131155.12359-1-kw...@redhat.com Subject: [Qemu-devel] [PULL 00/46] Block layer patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

[Qemu-devel] [PULL v1 2/4] tpm: extend TPM TIS with state migration support

Extend the TPM TIS interface with state migration support. We need to synchronize with the backend thread to make sure that a command being processed by the external TPM emulator has completed and its response been received. Signed-off-by: Stefan Berger Reviewed-by: Dr. David Alan Gilbert Revie

[Qemu-devel] [PULL v1 4/4] test: Add test cases that use the external swtpm with CRB interface

Add a test program for testing the CRB with the external swtpm. The 1st test case extends a PCR and reads back the value and compares it against an expected return packet. The 2nd test case repeats the 1st test case and then migrates the external swtpm's state along with the VM state to a destina

[Qemu-devel] [PULL v1 1/4] tpm: extend TPM emulator with state migration support

Extend the TPM emulator backend device with state migration support. The external TPM emulator 'swtpm' provides a protocol over its control channel to retrieve its state blobs. We implement functions for getting and setting the different state blobs. In case the setting of the state blobs fails, w

[Qemu-devel] [PULL v1 0/4] Merge tpm 2018/05/23

This series of patches adds TPM emulator state migration support and a test case for testing (local) migration. Stefan The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-

[Qemu-devel] [PULL v1 3/4] docs: tpm: add VM save/restore example and troubleshooting guide

Extend the docs related to TPM with specs related to VM save and restore and a troubleshooting guide for TPM migration. Signed-off-by: Stefan Berger Reviewed-by: Dr. David Alan Gilbert --- docs/specs/tpm.txt | 106 + 1 file changed, 106 insert

Re: [Qemu-devel] [PATCH v2 35/40] job: Add JOB_STATUS_CHANGE QMP event

On 05/18/2018 09:21 AM, Kevin Wolf wrote: > This adds a QMP event that is emitted whenever a job transitions from > one status to another. > > Signed-off-by: Kevin Wolf That's a lot of events, and a lot are redundant to what we already transmitted under block jobs; it also has the effect of ma

Re: [Qemu-devel] [PATCH v2 36/40] job: Add lifecycle QMP commands

On 05/18/2018 09:21 AM, Kevin Wolf wrote: > +{ 'command': 'job-complete', 'data': { 'id': 'str' } } Do we have to name it this? I've always disliked how "complete" is used as both a verb and an adjective in our code (hence why I used such bizarre phrasings like "concluded" in my jobs patches) ..

Re: [Qemu-devel] [PATCH v1 05/30] RISC-V: Allow setting and clearing multiple irqs

On Tue, May 22, 2018 at 5:14 PM, Michael Clark wrote: > Change the API of riscv_set_local_interrupt to take a > write mask and value to allow setting and clearing of > multiple local interrupts atomically in a single call. > Rename the new function to riscv_cpu_update_mip. > > Cc: Sagar Karandikar

Re: [Qemu-devel] [PATCH v2 31/40] job: Add job_is_ready()

On 05/18/2018 09:21 AM, Kevin Wolf wrote: > Instead of having a 'bool ready' in BlockJob, add a function that > derives its value from the job status. > > At the same time, this fixes the behaviour to match what the QAPI > documentation promises for query-block-job: 'true if the job may be > com

[Qemu-devel] [Bug 1722074] Re: warning: host doesn't support requested feature: CPUID.01H:ECX.vmx

Also reproducible $ qemu-system-x86_64 --version QEMU emulator version 2.11.1(Debian 1:2.11+dfsg-1ubuntu7.2) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers $ uname -a Linux ryzen 4.16.11-041611-generic #201805221331 SMP Tue May 22 17:34:25 UTC 2018 x86_64 x86_64 x86_64 GNU

Re: [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state

On Wed, May 23, 2018 at 06:43:29PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2018 at 06:36:05PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 23, 2018 at 04:44:51PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 12, 2018 at 11:12:28PM +0800, Tiwei Bie wrote: > > > > When multi queue

Re: [Qemu-devel] [PATCH v2 21/40] job: Convert block_job_cancel_async() to Job

On 05/18/2018 09:20 AM, Kevin Wolf wrote: > block_job_cancel_async() did two things that were still block job > specific: > > * Setting job->force. This field makes sense on the Job level, so we can > just move it. While at it, rename it to job->force_cancel to make its > purpose more obviou

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v3 3/6] vhost-user: support receiving file descriptors in slave_read

On Thu, May 24, 2018 at 12:25:23AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2018 at 11:12:29PM +0800, Tiwei Bie wrote: > > Signed-off-by: Tiwei Bie > > > Thinking about it, I think we should add a protocol > feature for this. This way remote can find out whether > it's safe to send thi

Re: [Qemu-devel] [PATCH v4 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU

On Wed, May 23, 2018 at 3:47 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Conditionalize setting of PVR11_USE_MMU on the use_mmu > CPU property, otherwise we may incorrectly advertise an > MMU via PVR when the core in fact has none. > > Signed-off-by: Edgar E. Iglesias Reviewed-

[Qemu-devel] [PATCH v4 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU

From: "Edgar E. Iglesias" Conditionalize setting of PVR11_USE_MMU on the use_mmu CPU property, otherwise we may incorrectly advertise an MMU via PVR when the core in fact has none. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[Qemu-devel] [PATCH v4 00/38] target-microblaze: Add support for Extended Addressing

From: "Edgar E. Iglesias" This series adds support for Extended Addressing to our MicroBlaze models. It adds both the non-MMU load/store EA and the extended MMU addressing. There are several ways to implement this but since there are further 64-bit extensions in the pipe, I've chosen to convert

Re: [Qemu-devel] [PATCH v1 02/30] RISC-V: Improve page table walker spec compliance

Hi Phil, Alastair, Richard, et al... Apologies if I'm slow to respond to your other review emails. I'm going to go through all of them and address each of them one by one. Currently, I want to either get some MMU tests from the verification team or separately write tests for the newly added comme

Re: [Qemu-devel] [PATCH v2 17/40] job: Move BlockJobCreateFlags to Job

On 05/18/2018 09:20 AM, Kevin Wolf wrote: > +job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE); > +job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS); Job API might be a good chance to say "No, this is the default behavior for this API." I don't know how possible this is, but could we

[Qemu-devel] [Bug 1614521] Re: -display accepts "none[a-z, 0-9]*" instead of 'none'

Fixed in: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=2c9498c3e44cd5574 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1614521 Title: -d

Re: [Qemu-devel] [PATCH v3 3/6] vhost-user: support receiving file descriptors in slave_read

On Thu, Apr 12, 2018 at 11:12:29PM +0800, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie Thinking about it, I think we should add a protocol feature for this. This way remote can find out whether it's safe to send this data to us. > --- > hw/virtio/vhost-user.c | 41 ++

Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses

Hi, On 05/23/2018 10:52 PM, Laszlo Ersek wrote: > On 05/23/18 22:40, Auger Eric wrote: >> On 05/23/2018 07:45 PM, Laszlo Ersek wrote: > >>> Regarding the second patch, I do believe we need "more sophistication" >>> there. For example, I guess it could be possible to distinguish "-cpu >>> cortex-a

Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses

On 05/23/18 22:40, Auger Eric wrote: > On 05/23/2018 07:45 PM, Laszlo Ersek wrote: >> Regarding the second patch, I do believe we need "more sophistication" >> there. For example, I guess it could be possible to distinguish "-cpu >> cortex-a15" from "-cpu cortex-a57" somehow, and stick with the lo

Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses

Hi Laszlo, On 05/23/2018 07:45 PM, Laszlo Ersek wrote: > Hi Eric, > > On 05/23/18 18:03, Eric Auger wrote: >> Current Machvirt PCI host controller's ECAM region is 16MB large. >> This limits the number of PCIe buses to 16. >> >> PC/Q35 machines have a 256MB region allowing up to 256 buses. >> Thi

Re: [Qemu-devel] [Qemu-block] [PATCH 1/8] parallels: Switch to byte-based calls

On 05/23/2018 04:09 PM, Eric Blake wrote: > On 05/23/2018 02:19 PM, John Snow wrote: >> >> >> On 04/25/2018 02:32 PM, Eric Blake wrote: >>> We are gradually moving away from sector-based interfaces, towards >>> byte-based.  Make the change for the last few sector-based calls >>> into the block la

Re: [Qemu-devel] [Qemu-block] [PATCH 1/8] parallels: Switch to byte-based calls

On 05/23/2018 02:19 PM, John Snow wrote: On 04/25/2018 02:32 PM, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based. Make the change for the last few sector-based calls into the block layer from the parallels driver. Ideally, the parallels driver

[Qemu-devel] [PATCH v2] Remove unwanted crlf conversion in serial

This patch fixes bug in serial that made it almost impossible for guest to communicate with devices through host's serial. OPOST flag in c_oflag enables output processing letting other flags in c_oflag take effect. Usually in c_oflag ONLCR flag is also set, which causes crlf to be sent in place of

Re: [Qemu-devel] [PULL 41/46] job: Add JOB_STATUS_CHANGE QMP event

On 05/23/2018 08:11 AM, Kevin Wolf wrote: This adds a QMP event that is emitted whenever a job transitions from one status to another. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- + +## +# @JOB_STATUS_CHANGE: +# +# Emitted when a job transitions to a different status. +# +# @id: Th

Re: [Qemu-devel] [Qemu-block] [PATCH 1/8] parallels: Switch to byte-based calls

On 04/25/2018 02:32 PM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Make the change for the last few sector-based calls > into the block layer from the parallels driver. > > Ideally, the parallels driver should switch to doing everything

Re: [Qemu-devel] [PATCH v3 1/5] nbd/server: fix trace

On 05/23/2018 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: Return code = 1 doesn't mean that we parsed base:allocation. Move trace point to appropriate place. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) @@ -76

Re: [Qemu-devel] Questions about vNVDIMM on qemu/KVM

On Tue, May 22, 2018 at 10:08 PM, Yasunori Goto wrote: > Hello, > > I'm investigating status of vNVDIMM on qemu/KVM, > and I have some questions about it. I'm glad if anyone answer them. > > In my understanding, qemu/KVM has a feature to show NFIT for guest, > and it will be still updated about pl

Re: [Qemu-devel] [PATCH] tests: Allow GTESTER_OPTIONS variable expansion from command line

On 23.05.2018 13:57, Philippe Mathieu-Daudé wrote: > The gtester utility offers the "-p=TESTPATH" option to > "only run test cases matching TESTPATH". We already use > a $GTESTER_OPTIONS variable. > Use make variable expansion to allow qtest path matching > from command line: > > $ time make ch

Re: [Qemu-devel] [PATCH v5 02/10] raw: Check byte range uniformly

On 05/22/2018 10:04 PM, Fam Zheng wrote: We don't verify the request range against s->size in the I/O callbacks except for raw_co_pwritev. This is wrong (especially for raw_co_pwrite_zeroes and raw_co_pdiscard), so fix them. I'd also mention ... Signed-off-by: Fam Zheng --- block/raw-form

Re: [Qemu-devel] [PATCH RFCv2 0/4] virtio-mem: paravirtualized memory

On 23.05.2018 20:24, David Hildenbrand wrote: > This is the Linux driver side of virtio-mem. Compared to the QEMU side, > it is in a pretty complete and clean state. > > virtio-mem is a paravirtualized mechanism of adding/removing memory to/from > a VM. We can do this on a 4MB granularity right no

Re: [Qemu-devel] AIO error case

On 05/23/2018 02:25 PM, Nishanth Aravamudan wrote: > On Wed, May 23, 2018 at 10:53 AM, John Snow > wrote: >> >> >> >> On 05/22/2018 06:01 PM, Nishanth Aravamudan via Qemu-devel wrote: >> > Hi! >> > >> >> Hi! CCing qemu-bl...@nongnu.org ; >>

Re: [Qemu-devel] AIO error case

On Wed, May 23, 2018 at 10:53 AM, John Snow wrote: > > > > On 05/22/2018 06:01 PM, Nishanth Aravamudan via Qemu-devel wrote: > > Hi! > > > > Hi! CCing qemu-bl...@nongnu.org; > > > I'm tracking an error case in the native AIO path, and was wondering if > > there was a latent (albeit possibly hard t

Re: [Qemu-devel] [PATCH v10 2/5] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D

Hi Eduardo, Please see my comments below. > -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, May 22, 2018 8:54 AM > To: Moger, Babu > Cc: m...@redhat.com; marcel.apfelb...@gmail.com; pbonz...@redhat.com; > r...@twiddle.net; mtosa...@redhat.com; qemu

Re: [Qemu-devel] [PATCH v3 07/19] migration: introduce icount field for snapshots

On 05/23/2018 01:50 AM, Pavel Dovgalyuk wrote: Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for rewinding the recorded execution to the specific moment of the time. E.g.,

Re: [Qemu-devel] [PATCH v3 1/2] qemu-error: introduce {error|warn}_report_once

On 05/22/2018 10:18 PM, Peter Xu wrote: I stole the printk_once() macro. I always wanted to be able to print some error directly if there is a buffer to dump, however we can't use error_report() where the code path can be triggered by DDOS attack. To avoid that, we can introduce a print-once-li

Re: [Qemu-devel] AIO error case

On 05/22/2018 06:01 PM, Nishanth Aravamudan via Qemu-devel wrote: > Hi! > Hi! CCing qemu-bl...@nongnu.org; > I'm tracking an error case in the native AIO path, and was wondering if > there was a latent (albeit possibly hard to hit) bug. Specifically > util/async.c::aio_get_linux_aio: > > #ifd

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

On 05/23/2018 11:48 AM, Patryk Olszewski wrote: This patch is here to help fix years old bug of lf being replaced with crlf in serial, which is super problematic in binary transmissions, making communication with devices through serial from guest almost impossible. Setting OPOST flag in c_oflag

Re: [Qemu-devel] [PATCH v3 2/3] ipmi: Use proper struct reference for KCS vmstate

On 05/18/2018 10:45 AM, Marc-André Lureau wrote: Hi Corey On Wed, Apr 25, 2018 at 5:27 PM, wrote: From: Corey Minyard The vmstate for isa_ipmi_kcs was referencing into the kcs structure, instead create a kcs structure separate and use that. There were also some issues in the state transfer

Re: [Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses

Hi Eric, On 05/23/18 18:03, Eric Auger wrote: > Current Machvirt PCI host controller's ECAM region is 16MB large. > This limits the number of PCIe buses to 16. > > PC/Q35 machines have a 256MB region allowing up to 256 buses. > This series tries to bridge the gap. > > It declares a new ECAM region

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

I've tried bisecting a few times, but since my reproducer wasn't reliable enough, I didn't identify the issue. (I see a bisect reported on qemu ML which seems like a bogus result, similar to mine). In my case, after the "hang", Windows 10 resets the ahci device after 2 minutes and it continues on

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/2018 02:11 PM, Zihan Yang wrote: Hi all, Thanks for all your comments and suggestions, I wasn't expecting so many professional reviewers. Some of the things you mentioned are beyond my knowledge right now. Please correct me if I'm wrong below. The original purpose was just to supp

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/2] vfio-ccw: add force unlimited prefetch property

On 05/23/2018 06:59 PM, Cornelia Huck wrote: On Wed, 23 May 2018 18:23:44 +0200 Halil Pasic wrote: On 05/23/2018 04:46 PM, Cornelia Huck wrote: +if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) { +if (!(vcdev->force_orb_pfch)) { +warn_report("vfio-ccw requires PFCH flag

Re: [Qemu-devel] [PATCH 2/2] sheepdog: remove huge BSS object

On 05/22/2018 10:43 PM, Fam Zheng wrote: > On Tue, 05/22 22:10, Paolo Bonzini wrote: >> block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss >> section. Replace it with a heap-allocated block, and make it smaller too >> since only the inode header is actually being used. >> >

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/18 19:11, Marcel Apfelbaum wrote: > On 05/23/2018 10:32 AM, Laszlo Ersek wrote: >> On 05/23/18 01:40, Michael S. Tsirkin wrote: >>> On Wed, May 23, 2018 at 12:42:09AM +0200, Laszlo Ersek wrote: If we figure out a placement strategy or an easy to consume representation of these d

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/2018 03:28 PM, Laszlo Ersek wrote: On 05/23/18 13:11, Zihan Yang wrote: Hi all, The original purpose was just to support multiple segments in Intel Q35 archtecure for PCIe topology, which makes bus number a less scarce resource. The patches are very primitive and many things are left

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/2018 10:32 AM, Laszlo Ersek wrote: On 05/23/18 01:40, Michael S. Tsirkin wrote: On Wed, May 23, 2018 at 12:42:09AM +0200, Laszlo Ersek wrote: Hold on, On 05/22/18 21:51, Laszlo Ersek wrote: It had taken years until the edk2 core gained a universal PciHostBridgeDxe driver with a we

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

Hi Alex, On 05/23/2018 12:17 AM, Alex Williamson wrote: On Tue, 22 May 2018 21:51:47 +0200 Laszlo Ersek wrote: On 05/22/18 21:01, Marcel Apfelbaum wrote: Hi Laszlo, On 05/22/2018 12:52 PM, Laszlo Ersek wrote: On 05/21/18 13:53, Marcel Apfelbaum wrote: On 05/20/2018 10:28 AM, Zihan Yang wr

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/2] vfio-ccw: add force unlimited prefetch property

On Wed, 23 May 2018 18:23:44 +0200 Halil Pasic wrote: > On 05/23/2018 04:46 PM, Cornelia Huck wrote: > +if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) { > +if (!(vcdev->force_orb_pfch)) { > +warn_report("vfio-ccw requires PFCH flag set"); > +s

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On 05/23/2018 05:25 PM, Michael S. Tsirkin wrote: On Tue, May 22, 2018 at 10:28:56PM -0600, Alex Williamson wrote: On Wed, 23 May 2018 02:38:52 +0300 "Michael S. Tsirkin" wrote: On Tue, May 22, 2018 at 03:47:41PM -0600, Alex Williamson wrote: On Wed, 23 May 2018 00:44:22 +0300 "Michael S.

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

W dniu 23.05.2018 o 18:40, Markus Armbruster pisze: > Patryk writes: > >> W dniu 22.05.2018 o 15:07, Peter Maydell pisze: >>> On 22 May 2018 at 12:53, Markus Armbruster wrote: Patryk Olszewski writes: > Signed-off-by: Patryk Olszewski > --- > chardev/char-serial.c | 2 +-

Re: [Qemu-devel] [PATCH] Remove unwanted crlf conversion in serial

Patryk writes: > W dniu 22.05.2018 o 15:07, Peter Maydell pisze: >> On 22 May 2018 at 12:53, Markus Armbruster wrote: >>> Patryk Olszewski writes: >>> Signed-off-by: Patryk Olszewski --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] storing machine data in qcow images?

Eduardo Habkost writes: > On Wed, May 23, 2018 at 01:19:46PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, May 21, 2018 at 07:44:40PM +0100, Daniel P. Berrangé wrote: >> >> On Mon, May 21, 2018 at 03:29:28PM -0300, Eduardo Habkost wrote: >> >> > On Sat, May 19, 2018

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/2] vfio-ccw: add force unlimited prefetch property

On 05/23/2018 04:46 PM, Cornelia Huck wrote: +if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) { +if (!(vcdev->force_orb_pfch)) { +warn_report("vfio-ccw requires PFCH flag set"); +sch_gen_unit_exception(sch); +css_inject_io_interrupt(sch); +

Re: [Qemu-devel] [PATCH v2 0/2] sheepdog: remove huge BSS object

On Wed, May 23, 2018 at 06:07:19PM +0200, Paolo Bonzini wrote: > block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss > section. Since it doesn't really have to be static, we can just use a > heap allocated block. We can actually make it smaller too. :) > > Patch 1 is a rel

Re: [Qemu-devel] [PATCH v10 2/5] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D

> -Original Message- > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Tuesday, May 22, 2018 9:04 AM > To: Moger, Babu > Cc: Duran, Leo ; m...@redhat.com; > marcel.apfelb...@gmail.com; pbonz...@redhat.com; r...@twiddle.net; > mtosa...@redhat.com; qemu-devel@nongnu.org; k...@vge

[Qemu-devel] [PATCH v2 0/2] sheepdog: remove huge BSS object

block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss section. Since it doesn't really have to be static, we can just use a heap allocated block. We can actually make it smaller too. :) Patch 1 is a related cleanup since we're touching that area of the code. Paolo v1->v2:

[Qemu-devel] [PATCH 1/2] sheepdog: cleanup repeated expression

The expression "SD_INODE_SIZE - sizeof(inode.data_vdi_id)" already has a macro defined for the same value (though with a nicer definition using offsetof). Replace it. Reviewed-by: Fam Zheng Reviewed-by: Jeff Cody Signed-off-by: Paolo Bonzini --- block/sheepdog.c | 6 +++--- 1 file changed, 3 i

[Qemu-devel] [PATCH 2/2] sheepdog: remove huge BSS object

block/sheepdog.o has a 4M static variable that is 90% of QEMU's whole .bss section. Replace it with a heap-allocated block, and make it smaller too since only the inode header is actually being used. bss size goes down from 4464280 to 269976. Signed-off-by: Paolo Bonzini --- block/sheepdog.c |

[Qemu-devel] [RFC 0/2] ARM virt: Support up to 256 PCIe buses

Current Machvirt PCI host controller's ECAM region is 16MB large. This limits the number of PCIe buses to 16. PC/Q35 machines have a 256MB region allowing up to 256 buses. This series tries to bridge the gap. It declares a new ECAM region located beyond 256GB, of size 256MB (just after the hypoth

[Qemu-devel] [RFC 1/2] hw/arm/virt: Add a new 256MB ECAM region

This patch defines a new ECAM region located after the 256GB limit. The virt machine state is augmented with a new highmem_ecam field which guards the usage of this new ECAM region instead of the legacy 16MB one. With the highmem ECAM region, up to 256 PCIe buses can be used. Signed-off-by: Eric

[Qemu-devel] [RFC 2/2] hw/arm/virt: Add virt-3.0 machine type

Add virt-3.0 machine type. This machine type supports highmem 256MB ECAM by default. This feature is disabled for earlier machine types and if highmem is off. Signed-off-by: Eric Auger --- hw/arm/virt.c | 27 --- include/hw/arm/virt.h | 1 + 2 files changed, 25

Re: [Qemu-devel] [PATCH v3 00/19] reverse debugging

On Wed, May 23, 2018 at 2:28 PM, Pavel Dovgalyuk wrote: >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >> On Wed, May 23, 2018 at 7:49 AM, Pavel Dovgalyuk >> wrote: >> > GDB remote protocol supports reverse debugging of the targets. >> > It includes 'reverse step' and 'reverse continue'

Re: [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

Eduardo Habkost writes: > On Wed, May 23, 2018 at 11:17:55AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> > On Mon, May 21, 2018 at 04:46:36PM -0300, Daniel Henrique Barboza wrote: > [...] >> >> Since no objection was made back then, this logic was put into >> >> query-target >

Re: [Qemu-devel] [PATCH v2 1/2] qemu-error: introduce {error|warn}_report_once

On 05/21/2018 10:56 PM, Peter Xu wrote: I stole the printk_once() macro. I always wanted to be able to print some error directly if there is a buffer to dump, however we can't use error_report() where the code path can be triggered by DDOS attack. To avoid that, we can introduce a print-once-li

Re: [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state

On Wed, May 23, 2018 at 06:36:05PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2018 at 04:44:51PM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 12, 2018 at 11:12:28PM +0800, Tiwei Bie wrote: > > > When multi queue is enabled e.g. for a virtio-net device, > > > each queue pair will have a

Re: [Qemu-devel] [PATCH 3/4] nbd/client: Support requests of additional block sizing info

On 05/22/2018 10:33 AM, Vladimir Sementsov-Ogievskiy wrote: 02.05.2018 00:13, Eric Blake wrote: The NBD spec is clarifying [1] that a server may want to advertise different limits for READ/WRITE (in our case, 32M) than for TRIM/ZERO (in our case, nearly 4G).  Implement the client side support fo

Re: [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state

On Wed, May 23, 2018 at 04:44:51PM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 12, 2018 at 11:12:28PM +0800, Tiwei Bie wrote: > > When multi queue is enabled e.g. for a virtio-net device, > > each queue pair will have a vhost_dev, and the only thing > > shared between vhost devs currently is the

Re: [Qemu-devel] [PATCH 1/2] sheepdog: cleanup repeated expression

On Tue, May 22, 2018 at 10:10:55PM +0200, Paolo Bonzini wrote: > The expression "SD_INODE_SIZE - sizeof(inode.data_vdi_id)" already has a macro > defined for the same value (though with a nicer definition using offsetof). > Replace it. > > Signed-off-by: Paolo Bonzini > --- > block/sheepdog.c |

Re: [Qemu-devel] [RFC 3/3] acpi-build: allocate mcfg for multiple host bridges

On Wed, 23 May 2018 17:25:32 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 22, 2018 at 10:28:56PM -0600, Alex Williamson wrote: > > On Wed, 23 May 2018 02:38:52 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, May 22, 2018 at 03:47:41PM -0600, Alex Williamson wrote: > > > > On Wed,

  1   2   3   >