Coverity doesn't like the tests under fail label (report CID 1385847).
Reset the fields so the clean up order is more apparent.
Signed-off-by: Fam Zheng
---
block/nvme.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/nvme.c b/block/nvme.c
index 6f71122bf5..8239b920c8 100644
---
On Fri, 05/18 19:01, Peter Maydell wrote:
> On 1 March 2018 at 07:54, Fam Zheng wrote:
> > From: Paolo Bonzini
> >
> > 1) string not null terminated in sysfs_find_group_file
> >
> > 2) NULL pointer dereference and dead local variable in nvme_init.
> >
> > Signed-off-by: Paolo Bonzini
> > Signed-
On Fri, May 18, 2018 at 02:27:00PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Thu, May 17, 2018 at 03:03:02PM +0200, Markus Armbruster wrote:
> >
> > [...]
> >
> >> > @@ -2502,7 +2525,9 @@ int monitor_fdset_get_fd(int64_t fdset_id, int
> >> > flags)
> >> > MonFdset *mon_fds
On Fri, 05/18 16:22, Alex Bennée wrote:
> If the user doesn't specify a TARGET_LIST they get the current
> configuration but with spaces and hilarity ensues. This adds some make
> magic to turn the TARGET_LIST back into a comma separated list.
>
> Signed-off-by: Alex Bennée
> ---
> tests/docker/
Ping for review, thanks
Sent: Thursday, May 10, 2018 at 10:08 AM
From: junyan...@gmx.com
To: qemu-devel@nongnu.org
Cc: "Haozhong Zhang" ,
xiaoguangrong.e...@gmail.com, crosthwaite.pe...@gmail.com,
m...@redhat.com, dgilb...@redhat.com, ehabk...@redhat.com,
quint...@redhat.co
On Fri, 05/18 11:34, Alistair Francis wrote:
> Avocado is not trivial to setup on non-Fedora systems. To simplfying
> future testing add a docker test image that runs Avocado tests.
>
> Signed-off-by: Alistair Francis
> ---
> v2:
> - Add a seperate fedora-avocado Docker image
> - Move the avoca
On 2018年05月17日 23:08, Michael S. Tsirkin wrote:
On Thu, May 17, 2018 at 09:54:40AM -0500, Brijesh Singh wrote:
Hi Michael and Jason,
Looks like this patch was not included in any of your pull request hence it
didn't made into 2.12. Can you please include this patch in your next pull
request?
On 2018年05月16日 00:26, Thomas Huth wrote:
"vlan" will be dropped in 2.13, not in 2.12. And while we're at it,
use the better wording "dropped in" instead of "removed with" (also
for the "dump" removal).
Reported-by: Stefan Hajnoczi
Reported-by: Eric Blake
Signed-off-by: Thomas Huth
---
qap
I think I was hit with very same bug.
I did bisect with 2.11.0 as good point and 2.12.0 as bad point.
configure was
setarch
i486 ./configure --prefix=/usr --disable-gtk --enable-virglrenderer
--enable-sdl --with-sdlabi=2.0 --audio-drv-list=alsa,oss
--host-cc=/opt/gcc49/bin/gcc --enable-openg
On 19 May 2018 at 5:19PM, Thomas Huth wrote:
On Sat, 19 May 2018 16:03:02 +0200
Christian Zigotzky wrote:
Unfortunately mouse and keyboard doesn't work in the virtual machine.
I guess with the ppce500 machine, you've also got to specify them
manually, too. You've got two options, virtio and
On Wed, May 16, 2018 at 12:55 AM, Dr. David Alan Gilbert <
dgilb...@redhat.com> wrote:
> * Zhang Chen (zhangc...@gmail.com) wrote:
> > We should not load PVM's state directly into SVM, because there maybe
> some
> > errors happen when SVM is receving data, which will break SVM.
> >
> > We need to
On Tue, May 15, 2018 at 10:44 PM, Dr. David Alan Gilbert <
dgilb...@redhat.com> wrote:
> * Zhang Chen (zhangc...@gmail.com) wrote:
> > During the time of VM's running, PVM may dirty some pages, we will
> transfer
> > PVM's dirty pages to SVM and store them into SVM's RAM cache at next
> checkpoint
On Thu, May 17, 2018 at 4:19 PM, Markus Armbruster
wrote:
> Zhang Chen writes:
>
> > On Tue, May 15, 2018 at 10:29 PM, Markus Armbruster
> > wrote:
> >
> >> Zhang Chen writes:
> >>
> >> > From: zhanghailiang
> >> >
> >> > If some errors happen during VM's COLO FT stage, it's important to
> >>
Thank you for quick reply,
Yes, I've tried, after that, the register works as expected, but even so, if I
enable the interrupts right after, I still receive interrupts from the same IRQ,
but maybe there is something wrong with my code.
Regards,
Davidson Francis.
2018-05-19 23:54 GMT-03:00 Staffo
On 20 May 2018 at 08:00, Wolfram Sang wrote:
> Replace the ERR macro with error_report() because fprintf is deprecated.
> This also fixes the prefix printed out twice.
>
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Wolfram Sang
> ---
> hw/nvram/eeprom_at24c.c | 17 ++---
>
Public bug reported:
When -spice is added to the commandline, QEMU_AUDIO_DRV=alsa is not
respected and I receive no audio from the guest using the alsa driver.
When -spice options are omitted, audio works as usual.
I want to channel mouse and keyboard events to the guest using spice
(with looking
Currently only q35 host bridge us allocated space in MCFG table. To put pxb host
into sepratate pci domain, each of them should have its own configuration space
int MCFG table
Signed-off-by: Zihan Yang
---
hw/i386/acpi-build.c | 83 +++-
1 file cha
Currently only q35 host bridge is allocated an item in MCFG table, all pxb
host bridges stay within pci domain 0. This series of patches put each pxb
host bridge in separate pci domain, allocating a new MCFG table item for it.
The pxb host does not have an mch in it, as q35 host already has one. A
QLIST will place the original q35 host bridge at the end of list because it is
added first. Replace it with QTAILQ to make q35 at the first of queue, which
makes it convinient and compatible when there are pxb hosts other than q35 hosts
Signed-off-by: Zihan Yang
---
hw/pci/pci.c | 9
To put each pxb into separate pci domain, we need to reserve enough MCFG space
for each pxb host in the main memory. First try to put them under 4G, before
pci_hole_start, if there are too many hosts, try to put them into main memory
above 4G, before pci_hole64_start. We should check if there is en
The value for "rom-size" is used as a divisor, so it must not be 0 or it
will segfault. A size of 0 wouldn't make sense anyhow.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Wolfram Sang
---
hw/nvram/eeprom_at24c.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/hw/nvram/eeprom_at
0 as "rom-size" will lead to an error message. Let's use the size of a
small 24c01 which has 128 byte.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Wolfram Sang
---
hw/nvram/eeprom_at24c.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/nvram/eeprom_at24c.c b/hw
I used this driver as a template for a custom one. While hacking on my own, I
noticed some problems in this driver, too. This series fixes the first set of
them, related to the "rom-size" parameter. It fixes a segfault.
I think the first patch is clearly suitable for stable. I think the second one
Replace the ERR macro with error_report() because fprintf is deprecated.
This also fixes the prefix printed out twice.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Wolfram Sang
---
hw/nvram/eeprom_at24c.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git
24 matches
Mail list logo
