[Qemu-devel] [Bug 1771948] [NEW] aarch64 msr CNTFRQ_EL0

Public bug reported: Hello, I'm running qemu 2.12 on a raspberry pi 3 with the command: qemu-system-aarch64 -M raspi3 -serial stdio -kernel executable.bin On my start file (right in the beginning with the highest EL), the following instructions: ldr x0 , =1920 msr CNTFRQ_EL0, x0 and qemu

Re: [Qemu-devel] [PATCH 1/2] qapi: allow flat unions with empty branches

Eric Blake writes: > On 05/17/2018 03:05 AM, Markus Armbruster wrote: QAPI language design alternatives: 1. Having unions cover all discriminator values explicitly is useful. > 2. Having unions repeat all the discriminator values explicitly is not

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 12:04:04AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > > > I rewrote some of the patches in V3. Major chan

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 12:08:01AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > > > I rewrote some of the patches in V3. Major chan

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Thu, May 17, 2018 at 03:49:05PM -0400, Jintack Lim wrote: > On Thu, May 17, 2018 at 4:59 AM, Peter Xu wrote: > > (Hello, Jintack, Feel free to test this branch again against your scp > > error case when you got free time) > > Hi Peter, > > > > > I rewrote some of the patches in V3. Major ch

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Fri, May 18, 2018 at 02:26:59PM +0800, Peter Xu wrote: [...] > I'll temporarily consider putting it at the last patch of series if no > one jumps out and tells me another more correct way. Also I'll > possibly make bold to append your suggested-by too to further claim

Re: [Qemu-devel] [PATCH v3 12/12] intel-iommu: new sync_shadow_page_table

On Fri, May 18, 2018 at 12:06:14AM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 04:59:27PM +0800, Peter Xu wrote: > > Firstly, introduce the sync_shadow_page_table() helper to resync the > > whole shadow page table of an IOMMU address space. Meanwhile, when we > > receive domain inva

Re: [Qemu-devel] [PATCH v2 09/10] intel-iommu: don't unmap all for shadow page table

On Thu, May 17, 2018 at 07:23:33PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > IOMMU replay was carried out before in many use cases, e.g., context > > cache invalidations, domain flushes. We used this mechanism to sync the > > shadow page table by firstly

Re: [Qemu-devel] [PATCH v2 06/10] intel-iommu: pass in address space when page walk

On Thu, May 17, 2018 at 04:32:55PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > We pass in the VTDAddressSpace to replace the aw bits when doing page > > walk. The VTDAddressSpace contains the aw bits information, meanwhile > > we'll need to do something mo

Re: [Qemu-devel] [PATCH v2 05/10] intel-iommu: introduce vtd_page_walk_info

On Thu, May 17, 2018 at 04:32:58PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > During the recursive page walking of IOVA page tables, some stack > > variables are constant variables and never changed during the whole page > > walking procedure. Isolate the

Re: [Qemu-devel] [PATCH v2 04/10] intel-iommu: only do page walk for MAP notifiers

On Thu, May 17, 2018 at 03:39:50PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > For UNMAP-only IOMMU notifiers, we don't really need to walk the page > s/really// ;-) Ok. > > tables. Fasten that procedure by skipping the page table walk. That > > should

Re: [Qemu-devel] [PATCH v2 03/10] intel-iommu: add iommu lock

On Thu, May 17, 2018 at 04:32:52PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > Add a per-iommu big lock to protect IOMMU status. Currently the only > > thing to be protected is the IOTLB/context cache, since that can be > > accessed even without BQL, e.g.,

Re: [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

On 05/17/2018 06:34 PM, Richard Henderson wrote: > On 05/17/2018 02:24 PM, Alex Bennée wrote: >> >> Richard Henderson writes: >> >>> On 05/17/2018 10:46 AM, Alex Bennée wrote: Broken since I updated to 18.04 Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.target |

Re: [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64

On 05/17/2018 05:30 PM, Richard Henderson wrote: > On 05/17/2018 10:47 AM, Alex Bennée wrote: >> This runs through the usual float to float conversions and crucially >> also runs with ARM Alternative Half Precision Format. >> >> Signed-off-by: Alex Bennée >> [rth: tweak vcvtb.f16.f32/vctb.f32.f16

Re: [Qemu-devel] [PATCH v2 01/10] intel-iommu: send PSI always even if across PDEs

On Thu, May 17, 2018 at 04:42:54PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > During IOVA page table walking, there is a special case when the PSI > > covers one whole PDE (Page Directory Entry, which contains 512 Page > > Table Entries) or more. In the p

Re: [Qemu-devel] [PATCH 4/9] target/riscv: Introduce cpu_riscv_get_fcsr

On 05/17/2018 07:46 PM, Michael Clark wrote: > > > On Fri, May 11, 2018 at 3:52 PM, Richard Henderson > mailto:richard.hender...@linaro.org>> wrote: > > Cc: Michael Clark mailto:m...@sifive.com>> > Cc: Palmer Dabbelt mailto:pal...@sifive.com>> > Cc: Sagar Karandikar

Re: [Qemu-devel] [PATCH] RISC-V: make it possible to alter default reset vector

On Tue, May 8, 2018 at 9:08 AM, Antony Pavlov wrote: > The RISC-V Instruction Set Manual, Volume II: > Privileged Architecture, Version 1.10 states > that upon reset the pc is set to > an implementation-defined reset vector > (see chapter 3.3 Reset). > > This patch makes it possible to alter defa

Re: [Qemu-devel] [PATCH 4/9] target/riscv: Introduce cpu_riscv_get_fcsr

On Fri, May 11, 2018 at 3:52 PM, Richard Henderson < richard.hender...@linaro.org> wrote: > Cc: Michael Clark > Cc: Palmer Dabbelt > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson > I'm not against this change but it conflicts with changes in the riscv repo.

Re: [Qemu-devel] [PATCH 5/9] target/riscv: Honor CPU_DUMP_FPU

On Sun, May 13, 2018 at 12:52 PM, Philippe Mathieu-Daudé wrote: > On 05/11/2018 12:52 AM, Richard Henderson wrote: > > Cc: Michael Clark > > Cc: Palmer Dabbelt > > Cc: Sagar Karandikar > > Cc: Bastian Koppelmann > > Signed-off-by: Richard Henderson > > Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH v3 4/7] hw/riscv/sifive_u: Set the soc device tree node as a simple-bus

On Tue, May 15, 2018 at 12:07 PM, Alistair Francis wrote: > To allow Linux to ennumerate devices on the /soc/ node set it as a > "simple-bus". > > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/sifive_u.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH v3 2/7] hw/riscv/sifive_e: Create a SiFive E SoC object

On Tue, May 15, 2018 at 12:07 PM, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Reviewed-by: Michael Clark > --- > hw/riscv/sifive_e.c | 97 +++-- > include/hw/riscv/sifive_e.h | 16 +- > 2 files changed, 86 insertions(+), 27 deletio

Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()

On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov wrote: > cpu_init() was removed since 2.12, so drop the define that is now unused. > > Signed-off-by: Igor Mammedov > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Michael Clark --- > v2: > * refine commit message (Eric Blake ) > --- > t

Re: [Qemu-devel] [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform capabilities

> -Original Message- > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > Ross Zwisler > Sent: Thursday, May 17, 2018 12:00 AM > Subject: [qemu PATCH v2 3/4] nvdimm, acpi: support NFIT platform > capabilities > > Add a machine command line option to allow the us

[Qemu-devel] [PULL v2 09/28] target/arm: convert conversion helpers to fpst/ahp_flag

From: Alex Bennée Instead of passing env and leaving it up to the helper to get the right fpstatus we pass it explicitly. There was already a get_fpstatus helper for neon for the 32 bit code. We also add an get_ahp_flag() for passing the state of the alternative FP16 format flag. This leaves scop

[Qemu-devel] [PULL v2 00/28] softfloat patch roundup

g (2018-05-17 11:59:50 +0100) are available in the Git repository at: git://github.com/rth7680/qemu.git pull-fpu-20180517 for you to fetch changes up to 377ed92679a2a5f838bc0a095112ea5020720fff: fpu/softfloat: Define floatN_silence_nan in terms of parts_silence_nan (2018-05-17 15:2

[Qemu-devel] [PATCH 1/2] Add generic Nios II board.

This patch adds support for a generic MMU-less Nios II board that can be used e.g. for bare-metal compiler testing. Nios II booting is also tweaked so that bare-metal binaries start executing in RAM starting at 0x, rather than an alias at 0xc000, which allows features such as unwindin

[Qemu-devel] [PATCH 0/2] Nios II generic board config and semihosting support

These patches add support for a generic MMU-less Nios II board and add semihosting support for Nios II, the latter based on the m68k semihosting implementation. These are useful for testing "bare metal" Nios II toolchains, given appropriate startup code. I've tested our internal builds successfu

[Qemu-devel] [PATCH 2/2] Add Nios II semihosting support.

This patch (by Sandra Loosemore, mildly rebased) adds support for semihosting for Nios II bare-metal emulation. Signed-off-by: Julian Brown --- qemu-options.hx| 8 +- target/nios2/Makefile.objs | 2 +- target/nios2/cpu.h | 4 +- target/nios2/helper.c | 11 ++ tar

Re: [Qemu-devel] [PULL 09/28] target/arm: convert conversion helpers to fpst/ahp_flag

On 05/17/2018 03:16 AM, Peter Maydell wrote: > On 16 May 2018 at 16:52, Richard Henderson > wrote: >> diff --git a/target/arm/translate.c b/target/arm/translate.c >> index 731cf327a1..613598d090 100644 >> --- a/target/arm/translate.c >> +++ b/target/arm/translate.c > > Just noticed, but in the 3

Re: [Qemu-devel] [PULL 1/3] usb-mtp: Add some NULL checks for issues pointed out by coverity

Peter Maydell writes: > On 7 May 2018 at 10:44, Gerd Hoffmann wrote: >> From: Bandan Das >> >> CID 1390578: In usb_mtp_write_metadata, parent can never be NULL but >> just in case, add an assert >> CID 1390592: Check for o->format only if o !=NULL >> CID 1390604: Check s->data_out != NULL in us

Re: [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

On 05/17/2018 02:24 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 05/17/2018 10:46 AM, Alex Bennée wrote: >>> Broken since I updated to 18.04 >>> >>> Signed-off-by: Alex Bennée >>> --- >>> tests/tcg/arm/Makefile.target | 8 >>> 1 file changed, 8 insertions(+) >> >> Meh.

Re: [Qemu-devel] [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target

Richard Henderson writes: > On 05/17/2018 10:47 AM, Alex Bennée wrote: >> Nothing much here yet. >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/aarch64/Makefile.target | 5 + >> 1 file changed, 5 insertions(+) >> create mode 100644 tests/tcg/aarch64/Makefile.target >> >> diff --git

Re: [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

Richard Henderson writes: > On 05/17/2018 10:46 AM, Alex Bennée wrote: >> Broken since I updated to 18.04 >> >> Signed-off-by: Alex Bennée >> --- >> tests/tcg/arm/Makefile.target | 8 >> 1 file changed, 8 insertions(+) > > Meh. Most of these fail for hosts with 64k pages. > So, sure,

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > (Hello, Jintack, Feel free to test this branch again against your scp > error case when you got free time) > > I rewrote some of the patches in V3. Major changes: > > - Dropped mergable interval tree, instead introduced IOVA tree, whic

Re: [Qemu-devel] [PATCH v3 12/12] intel-iommu: new sync_shadow_page_table

On Thu, May 17, 2018 at 04:59:27PM +0800, Peter Xu wrote: > Firstly, introduce the sync_shadow_page_table() helper to resync the > whole shadow page table of an IOMMU address space. Meanwhile, when we > receive domain invalidation or similar requests (for example, context > entry invalidations, gl

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Thu, May 17, 2018 at 04:59:15PM +0800, Peter Xu wrote: > (Hello, Jintack, Feel free to test this branch again against your scp > error case when you got free time) > > I rewrote some of the patches in V3. Major changes: > > - Dropped mergable interval tree, instead introduced IOVA tree, whic

Re: [Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

On Thu, May 17, 2018 at 04:59:16PM +0800, Peter Xu wrote: > During IOVA page table walking, there is a special case when the PSI > covers one whole PDE (Page Directory Entry, which contains 512 Page > Table Entries) or more. In the past, we skip that entry and we don't > notify the IOMMU notifiers

Re: [Qemu-devel] [PATCH v3 35/38] target-microblaze: Convert env_btarget to i64

On 05/17/2018 11:03 AM, Edgar E. Iglesias wrote: > On Thu, May 17, 2018 at 10:34:38AM -0700, Richard Henderson wrote: >> On 05/16/2018 11:51 AM, Edgar E. Iglesias wrote: >>> From: "Edgar E. Iglesias" >>> >>> Convert env_btarget to i64. >>> No functional change. >>> >>> Signed-off-by: Edgar E. Igle

Re: [Qemu-devel] [PATCH v4 46/49] tests/tcg/Makefile: update to be called from Makefile.target

On 05/17/2018 10:47 AM, Alex Bennée wrote: > This make is now invoked from each individual target make with the > appropriate CC and EXTRA_CFLAGS set for each guest. It then includes > additional Makefile.targets from: > > - tests/tcg/multiarch (always) > - tests/tcg/$(TARGET_BASE_ARCH) (if av

Re: [Qemu-devel] [PATCH v4 39/49] tests/tcg/alpha: add Alpha specific tests

On 05/17/2018 10:47 AM, Alex Bennée wrote: > These tests did use their own crt.o stub however that is a little > stone age so we drop crt.S and just statically link to the cross > compilers libraries. > > Signed-off-by: Alex Bennée > > --- > v4 > - drop crt.s > - drop skipping of threadtest

Re: [Qemu-devel] [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64

On 05/17/2018 10:47 AM, Alex Bennée wrote: > This runs through the usual float to float conversions and crucially > also runs with ARM Alternative Half Precision Format. > > Signed-off-by: Alex Bennée > [rth: tweak vcvtb.f16.f32/vctb.f32.f16 code and regen] > Signed-off-by: Richard Henderson >

Re: [Qemu-devel] [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target

On 05/17/2018 10:47 AM, Alex Bennée wrote: > Nothing much here yet. > > Signed-off-by: Alex Bennée > --- > tests/tcg/aarch64/Makefile.target | 5 + > 1 file changed, 5 insertions(+) > create mode 100644 tests/tcg/aarch64/Makefile.target > > diff --git a/tests/tcg/aarch64/Makefile.target >

Re: [Qemu-devel] [PATCH v4 30/49] tests/tcg: enable building for AArch64

On 05/17/2018 10:46 AM, Alex Bennée wrote: > We only have compilers for the (default) little endian variants. > > Signed-off-by: Alex Bennée > > --- > v4 > - update MAINTAINERS > --- > MAINTAINERS| 1 + > tests/tcg/aarch64/Makefile.include | 8 > 2 files chang

Re: [Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

On 05/17/2018 10:46 AM, Alex Bennée wrote: > Broken since I updated to 18.04 > > Signed-off-by: Alex Bennée > --- > tests/tcg/arm/Makefile.target | 8 > 1 file changed, 8 insertions(+) Meh. Most of these fail for hosts with 64k pages. So, sure, disable this one, but I don't think that

Re: [Qemu-devel] [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test

On 05/17/2018 10:46 AM, Alex Bennée wrote: > We need to rename the source file to a .S so we can do a single-line > assemble and link invocation. We also specify the additional CFLAGS > for the compile as it's a non-standard ARM binary. > > Signed-off-by: Alex Bennée > [rth: force fpu configurati

Re: [Qemu-devel] [PATCH v4 20/49] tests/tcg/i386: fix test-i386

Eric Blake writes: > On 05/17/2018 12:46 PM, Alex Bennée wrote: >> The test-i386 test case is a little special as it includes assembler >> files. Add the additional compile magic to assemble these bits and >> link them to the final binary. > > The patch says "add"... > >> >> Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v4 22/49] tests/tcg/i386: disable i386 version of test-i386-ssse

On 05/17/2018 10:46 AM, Alex Bennée wrote: > It doesn't build for i386 easily and we probably need a better more > methodical test for SSE et all in QEMU. > > Signed-off-by: Alex Bennée > --- > tests/tcg/i386/Makefile.target | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 00/12] intel-iommu: nested vIOMMU, cleanups, bug fixes

On Thu, May 17, 2018 at 4:59 AM, Peter Xu wrote: > (Hello, Jintack, Feel free to test this branch again against your scp > error case when you got free time) Hi Peter, > > I rewrote some of the patches in V3. Major changes: > > - Dropped mergable interval tree, instead introduced IOVA tree, wh

Re: [Qemu-devel] [PATCH v3 15/22] target/arm: Add ARM_FEATURE_V7VE for v7 Virtualization Extensions

On Apr 17 16:00, Peter Maydell wrote: > On 17 April 2018 at 15:23, Aaron Lindsay wrote: > > On Apr 12 18:17, Peter Maydell wrote: > >> What's the difference between this and ARM_FEATURE_EL2 ? > > > > I use ARM_FEATURE_V7VE in a later patch to guard against implementing > > PMOVSSET on v7 machines

[Qemu-devel] [PATCH v7 3/3] qmp.c: system_wakeup: runstate and wake-up support check

The qmp/hmp command 'system_wakeup' is simply a direct call to 'qemu_system_wakeup_request' from vl.c. This function verifies if runstate is SUSPENDED and if the wake up reason is valid before proceeding. However, no error or warning is thrown if any of those pre-requirements isn't met. There is no

[Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target

When issuing the qmp/hmp 'system_wakeup' command, what happens in a nutshell is: - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason and notify the event - in the main_loop, all vcpus are paused, a system reset is issued, all subscribers of wakeup_notifiers receives a notific

[Qemu-devel] [PATCH v7 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions

This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP command. Reported-by: Balamuruhan S Signed-o

[Qemu-devel] [PATCH v7 0/3] wakeup-from-suspend and system_wakeup changes

This is the follow-up version of the series: [PATCH v6 0/2] qmp: 'wakeup-suspend-support' in query-target With an extra patch that was standalone: [PATCH v3 1/1] qmp.c: system_wakeup: adding RUN_STATE_SUSPENDED check before proceeding Changes from v6 version: - patch 1: * renamed the method

Re: [Qemu-devel] [PATCH v4 20/49] tests/tcg/i386: fix test-i386

On 05/17/2018 12:46 PM, Alex Bennée wrote: The test-i386 test case is a little special as it includes assembler files. Add the additional compile magic to assemble these bits and link them to the final binary. The patch says "add"... Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Revi

[Qemu-devel] [PATCH v4 13/49] tests/tcg/multiarch: Build fix for linux-test

From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Revi

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

On Thu, May 17, 2018 at 08:57:04PM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 02:34:28PM -0300, Eduardo Habkost wrote: > > On Wed, May 16, 2018 at 05:26:40PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > > > > On Sat, May 1

[Qemu-devel] [PATCH v4 25/49] tests/tcg/i386/test-i386: fix printf format

Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/i386/test-i386.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c index caef4da176..a29b41e764 100644 --- a/t

[Qemu-devel] [PATCH v4 36/49] tests/tcg: enable building for s390x

This doesn't add any additional tests but enables building the multiarch tests for s390x. Signed-off-by: Alex Bennée Acked-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/s390x/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) crea

[Qemu-devel] [PATCH v4 45/49] tests/tcg: enable building for RISCV64

As before, using Debian SID compilers. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 1 + tests/docker/dockerfiles/debian-riscv64-cross.docker | 12 tests/tcg/riscv/Makefile.include | 10 ++ 3 files changed, 23 ins

Re: [Qemu-devel] [PATCH v3 31/38] target-microblaze: Simplify address computation using tcg_gen_addi_i32()

On 05/16/2018 03:51 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Simplify address computation using tcg_gen_addi_i32(). > tcg_gen_addi_i32() already optimizes the case when the > immediate is zero. > > No functional change. > > Suggested-by: Richard Henderson > Reviewed-by: Ric

Re: [Qemu-devel] [PATCH v3 35/38] target-microblaze: Convert env_btarget to i64

On Thu, May 17, 2018 at 10:34:38AM -0700, Richard Henderson wrote: > On 05/16/2018 11:51 AM, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Convert env_btarget to i64. > > No functional change. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > I thought you were going to dro

[Qemu-devel] [PATCH v4 33/49] tests/tcg: move MIPS specific tests into subdir

These only need to be built for MIPS guests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/README | 11 --- tests/tcg/mips/README | 7 +++ tests/tcg/{ => mips}/hello-mips.c | 0 3 files

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: clean up notify

On 05/17/2018 05:26 PM, Cornelia Huck wrote: On Wed, 16 May 2018 15:27:57 +0200 Halil Pasic wrote: Coverity recently started complaining about virtio_ccw_notify(). Turns out, there is a couple of things that can be cleaned up. Let's clean! Changes look good to me. I wanted to come up wi

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/2] vfio-ccw: add force unlimited prefetch property

On 05/17/2018 04:21 PM, Cornelia Huck wrote: How about force-orb-pfch or force-orb-pbit (PoP name) for the property and with underscores for the variable. My idea was (starting from your force_pfch) to spell out that we are fiddling with that orb bit. force-orb-pfch looks reasonable to me. C

[Qemu-devel] [PATCH v4 27/49] tests/tcg: enable building for ARM

This allows us to use the docker cross compiler image to build these tests. Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.include | 8 1 file changed, 8 insertions(+) create mode 100644 tests/tcg/arm/Makefile.include diff --git a/tests/tcg/arm/Makefile.include b/tests/tcg/arm/

[Qemu-devel] [PATCH v4 47/49] Makefile.target: add (clean-/build-)guest-tests targets

Now all the build infrastructure is in place we can build tests for each guest that we support. That support mainly depends on having cross compilers installed or docker setup. To keep all the logic for that together we put the rules in tests/tcg/Makefile.include and include it from the main Makefi

Re: [Qemu-devel] [PATCH v3 09/38] target-microblaze: Conditionalize setting of PVR11_USE_MMU

On Thu, May 17, 2018 at 10:26:00AM -0700, Richard Henderson wrote: > On 05/16/2018 11:51 AM, Edgar E. Iglesias wrote: > > -env->pvr.regs[11] = PVR11_USE_MMU | (16 << 17); > > +env->pvr.regs[11] = cpu->cfg.use_mmu ? PVR11_USE_MMU : 0 | > > +16 << 17; > > I believe th

[Qemu-devel] [PATCH v4 23/49] tests/tcg/x86_64: add Makefile.target

The sources for x86_64 are shared in the i386 directory which will be included thanks to TARGET_BASE_ARCH. However not all sources build so we need to filter out the ones we can't build in the 64 bit world. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathie

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

On Thu, May 17, 2018 at 02:34:28PM -0300, Eduardo Habkost wrote: > On Wed, May 16, 2018 at 05:26:40PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > > > On Sat, May 12, 2018 at 01:12:59AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 1

Re: [Qemu-devel] [PATCH] xen_pt: Present the size of 64 bit BARs correctly

On Mon, May 14, 2018 at 10:57:46AM +0100, Ross Lagerwall wrote: > The full size of the BAR is stored in the lower PCIIORegion.size. The > upper PCIIORegion.size is 0. Calculate the size of the upper half > correctly from the lower half otherwise the size read by the guest will > be incorrect. > >

[Qemu-devel] [PATCH v4 41/49] tests/tcg: enable building for m68k

As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-m68k-cross.docker | 12 tests/tcg/m68k/Makefile.inc

Re: [Qemu-devel] [PATCH v4 03/49] configure: add support for --cross-cc-FOO

On 05/17/2018 10:46 AM, Alex Bennée wrote: > +if ! do_compiler $target_compiler -o $TMPE $TMPC -static ; then > +# For host systems we might get away with building without -static > +if ! do_compiler $target_compiler -o $TMPE $TMPC ; then > +target_compiler="" > +

[Qemu-devel] [PATCH v4 43/49] tests/tcg: enable building for sparc64

As before, using Debian SID compilers. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include| 1 + tests/docker/dockerfiles/debian-sparc64-cross.docker | 12 tests/tcg/sparc64/Makefile.include | 2 ++ 3 files changed, 15 insertions(

[Qemu-devel] [PATCH v4 24/49] tests/tcg/i386/test-i386: use modern vector_size attributes

The compiler complains about the old __mode__ style attributes. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/i386/test-i386.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v4 20/49] tests/tcg/i386: fix test-i386

The test-i386 test case is a little special as it includes assembler files. Add the additional compile magic to assemble these bits and link them to the final binary. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Revie

[Qemu-devel] [PATCH v4 35/49] tests/tcg/mips: include common mips hello-mips

Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.target | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 tests/tcg/mips/Makefile.target diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target new file mode 100644 index 00..71f0c2dd

[Qemu-devel] [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test

Broken since I updated to 18.04 Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.target | 8 1 file changed, 8 insertions(+) diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target index 1ef5d79fe3..9d2b551732 100644 --- a/tests/tcg/arm/Makefile.target +++ b/tes

[Qemu-devel] [PATCH v4 21/49] tests/tcg/i386: add runner for test-i386-fprem

The runner needs to compare against a reference run. We also only run this test when SPEED=slow as it takes a while. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 11 +++ tests/tcg/i386/test-i386-fprem.c | 12 +--- 2 files changed, 20 insertions(+), 3 deletion

[Qemu-devel] [PATCH v4 38/49] tests/tcg: enable building for Alpha

We can't use our normal Debian based compilers as Alpha isn't an officially supported architecture. However it is available as a port and fortunately cross compilers for all these targets are included in Debian Sid, the perpetual rolling/unstable/testing version of Debian. Signed-off-by: Alex Benn

[Qemu-devel] [PATCH v4 44/49] tests/tcg: enable building for mips64

As before, using Debian SID compilers. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-mips64-cross.docker | 12 tests/tcg/mips/Makefile.include | 3 +++ 3 files changed, 16 insertions(+)

[Qemu-devel] [PATCH v4 19/49] tests/tcg/i386: Build fix for hello-i386

From: Fam Zheng We have -Werror=missing-prototype, add a dummy prototype to avoid that warning. Signed-off-by: Fam Zheng Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson --- tests/tcg/i386/hello-i386.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/i386/hello-i386.c b/t

[Qemu-devel] [PATCH v4 40/49] tests/tcg: enable building for HPPA

Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 1 + tests/docker/dockerfiles/debian-hppa-cross.docker | 12 tests/tcg/hppa/Makefile.include | 2 ++ 3 files

[Qemu-devel] [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test

We need to rename the source file to a .S so we can do a single-line assemble and link invocation. We also specify the additional CFLAGS for the compile as it's a non-standard ARM binary. Signed-off-by: Alex Bennée [rth: force fpu configuration] Signed-off-by: Richard Henderson Reviewed-by: Phil

[Qemu-devel] [PATCH v4 48/49] tests/Makefile.include: add [build|clean|check]-tcg targets

This will ensure all linux-user targets build their guest test programs and ensure check-tcg will run the respective tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - use -include instead of complex macro stuff - also include TA

[Qemu-devel] [PATCH v4 17/49] docker: Add fedora-i386-cross image

From: Fam Zheng It has some basic *-devel.i686 packages to be used with "gcc -m32" as a 32 bit cross build environment. Signed-off-by: Fam Zheng [AJB: add glibc-static] Signed-off-by: Alex Bennée Tested-by: Philippe Mathieu-Daudé --- v2 - include static glibc package as well --- tests/dock

[Qemu-devel] [PATCH v4 34/49] tests/tcg: enable building for MIPS

This doesn't add any additional tests but enables building the multiarch tests for MIPS using docker cross compilers. We don't have a cross compiler for mips64 big endian though. Signed-off-by: Alex Bennée --- tests/tcg/mips/Makefile.include | 17 + 1 file changed, 17 insertions(

[Qemu-devel] [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM)

To get a clean run of check-tcg these tests are currently skipped: - test-mmap -p for i386, hppa, m68k - hello-mips for mips - linux-test for sparc For ARM/aarch64 - fcvt doesn't compare against reference (awaiting fixes in mainline) Signed-off-by: Alex Bennée --- v4 - document broke

[Qemu-devel] [PATCH v4 39/49] tests/tcg/alpha: add Alpha specific tests

These tests did use their own crt.o stub however that is a little stone age so we drop crt.S and just statically link to the cross compilers libraries. Signed-off-by: Alex Bennée --- v4 - drop crt.s - drop skipping of threadtest - drop write() hack, include unistd.h --- tests/tcg/alpha/Ma

[Qemu-devel] [PATCH v4 18/49] tests/tcg: enable building for i386

While you can construct a compile command that does work using the x86_64 host compiler that most people use this is flakey. Different distros handle this is different ways so we default to using a known good i386 compiler via docker. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PATCH v4 22/49] tests/tcg/i386: disable i386 version of test-i386-ssse

It doesn't build for i386 easily and we probably need a better more methodical test for SSE et all in QEMU. Signed-off-by: Alex Bennée --- tests/tcg/i386/Makefile.target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.t

[Qemu-devel] [PATCH v4 30/49] tests/tcg: enable building for AArch64

We only have compilers for the (default) little endian variants. Signed-off-by: Alex Bennée --- v4 - update MAINTAINERS --- MAINTAINERS| 1 + tests/tcg/aarch64/Makefile.include | 8 2 files changed, 9 insertions(+) create mode 100644 tests/tcg/aarch64/Makefil

[Qemu-devel] [PATCH v4 37/49] tests/tcg: enable building for ppc64

Currently this just enables building the multiarch tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/tcg/ppc64le/Makefile.include | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/tcg/ppc64le/Makefile.include diff

[Qemu-devel] [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir

These only need to be built for ARM guests. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - do VPATH manipulation in tests/tcg/arm/Makefile.target - merge with fix hello-arm

[Qemu-devel] [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target

Nothing much here yet. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 5 + 1 file changed, 5 insertions(+) create mode 100644 tests/tcg/aarch64/Makefile.target diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target new file mode 100644 index

[Qemu-devel] [PATCH v4 10/49] docker: allow "cc" command to run in user context

Signed-off-by: Alex Bennée Reviewed-by: Fam Zheng Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 59bce9f19a..37bfa98005 100755 --- a/t

[Qemu-devel] [PATCH v4 16/49] tests/tcg: move i386 specific tests into subdir

These only need to be built for i386 guests. This includes a stub tests/tcg/i386/Makfile.target which absorbs some of what was in tests/tcg/Makefile. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard H

[Qemu-devel] [PATCH v4 15/49] tests/tcg/multiarch: move most output to stdout

The default test run outputs to stdout so it can be re-directed. Errors are still reported to stderr. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v4 - remove space in fprintf () to keep checkpatch happy

[Qemu-devel] [PATCH v4 14/49] tests/tcg/multiarch: enable additional linux-test tests

Un-comment the remaining tests. I removed the itimer value tests because I'm fairly sure a re-arming timer will always have a different value in it when you grab it. I've also fixed up the clone thread flags as QEMU will only allow a clone to use flags which match glibc. However the test is still

[Qemu-devel] [PATCH v4 11/49] docker: Makefile.include introduce DOCKER_SCRIPT

Define this in one place to make it easy to re-use. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- tests/docker/Makefile.include | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index

[Qemu-devel] [PATCH v4 08/49] docker: Add "cc" subcommand

Signed-off-by: Fam Zheng [AJB: add if args.paths check] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- v2 - add if args.paths check to avoid iterating null argument --- tests/docker/docker.py | 25 + 1 file changed

  1   2   3   4   >