Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-20 Thread Pavel Dovgalyuk
> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] > On Tue, Feb 20, 2018 at 9:46 AM, Pavel Dovgalyuk wrote: > > > > Updated the branch on github. > > You may try it. > > At 8a482834780a131e7747c1c3c1931379ed0beedc ARM initrd record runs, > but replay is getting stuck at: > > [ 12.120424]

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Jeff Cody
On Tue, Feb 20, 2018 at 06:43:22PM +, Peter Maydell wrote: > I just noticed that we seem to have acquired another git > submodule that isn't pointing to a qemu.org git url: > > [submodule "roms/seabios-hppa"] > path = roms/seabios-hppa > url = git://github.com/hdeller/seabios-h

[Qemu-devel] intel-iommu and vhost: Do we need 'device-iotlb' and 'ats'?

2018-02-20 Thread Jintack Lim
Hi, I'm using vhost with the virtual intel-iommu, and this page[1] shows the QEMU command line example. qemu-system-x86_64 -M q35,accel=kvm,kernel-irqchip=split -m 2G \ -device intel-iommu,intremap=on,device-iotlb=on \ -device ioh3420,id=pcie.1,chassis=1 \

Re: [Qemu-devel] [RFC PATCH qemu] qmp: Add qom-list-properties to list QOM object properties

2018-02-20 Thread Alexey Kardashevskiy
On 19/01/18 16:09, Alexey Kardashevskiy wrote: > There is already 'device-list-properties' which does most of the job, > however it does not handle everything returned by qom-list-types such > as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE. > > This adds a new qom-list-p

[Qemu-devel] [PATCH] virtio-gpu-3d: add support for second capability set (v2)

2018-02-20 Thread Dave Airlie
From: Dave Airlie Due to a kernel bug we can never increase the size of capability set 1, so introduce a new capability set in parallel, old userspace will continue to use the old set, new userspace will start using the new one when it detects a fixed kernel. v2: don't use a define from virglren

Re: [Qemu-devel] Call for GSoC & Outreachy 2018 mentors & project ideas

2018-02-20 Thread Alistair Francis
On Tue, Feb 20, 2018 at 3:13 AM, Paolo Bonzini wrote: > On 20/02/2018 11:36, Stefan Hajnoczi wrote: >> === Multi-CPU cluster support for GDB server in QEMU === >> >> There are many examples in modern computing where multiple CPU >> clusters are grouped together in a single SoC. This is common in t

Re: [Qemu-devel] [PATCH] hw/acpi-build: build SRAT memory affinity structures for NVDIMM

2018-02-20 Thread Dan Williams
On Tue, Feb 20, 2018 at 6:10 AM, Igor Mammedov wrote: > On Sat, 17 Feb 2018 14:31:35 +0800 > Haozhong Zhang wrote: > >> ACPI 6.2A Table 5-129 "SPA Range Structure" requires the proximity >> domain of a NVDIMM SPA range must match with corresponding entry in >> SRAT table. >> >> The address ranges

[Qemu-devel] [PATCH] configure: fix sanitizers' test program to mend ASan detection

2018-02-20 Thread Emilio G. Cota
Commit 218bb57 ("build-sys: check static linking of UBSAN", 2018-02-13) adds a small test program to check whether ubsan works even when configuring with --static. This added program is used to detect all sanitizers, which breaks ASan's detection since the compilation fails with -fsanitize=address,

Re: [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

2018-02-20 Thread Thomas Huth
On 20.02.2018 23:35, Eric Blake wrote: > On 02/20/2018 11:40 AM, Thomas Huth wrote: >> "-net dump" has been marked as deprecated since QEMU v2.10, since it >> only works with the deprecated 'vlan' parameter (or hubs). Network >> dumping should be done with "-object filter-dump" nowadays instead. >>

Re: [Qemu-devel] [PATCH v2 8/8] qemu-doc: Make "-net" less prominent

2018-02-20 Thread Thomas Huth
On 20.02.2018 19:37, Paolo Bonzini wrote: > On 20/02/2018 18:40, Thomas Huth wrote: >> "-net" is clearly a legacy option. Yet we still use it in almost all >> examples in the qemu documentation, and many other spots in the network >> chapter. We should make it less prominent that users are not lure

Re: [Qemu-devel] [RFC PATCH v6 00/20] replay additions

2018-02-20 Thread Ciro Santilli
On Tue, Feb 20, 2018 at 9:46 AM, Pavel Dovgalyuk wrote: >> From: Ciro Santilli [mailto:ciro.santi...@gmail.com] >> On Mon, Feb 19, 2018 at 8:02 AM, Pavel Dovgalyuk wrote: >> >> From: Pavel Dovgalyuk [mailto:dovga...@ispras.ru] >> >> > From: Peter Maydell [mailto:peter.mayd...@linaro.org] >> >> >

Re: [Qemu-devel] [PATCH] Fix ast2500 protection register emulation

2018-02-20 Thread Andrew Jeffery
On Tue, 20 Feb 2018, at 23:56, Hugo Landau wrote: > Some register blocks of the ast2500 are protected by protection key > registers which require the right magic value to be written to those > registers to allow those registers to be mutated. > > Register manuals indicate that writing the correct

[Qemu-devel] [PATCH v4 5/5] usb-mtp: Advertise SendObjectInfo for write support

2018-02-20 Thread Bandan Das
This patch implements a dummy ObjectInfo structure so that it's easy to typecast the incoming data. If the metadata is valid, write_pending is set. Also, the incoming filename is utf-16, so, instead of depending on external libraries, just implement a simple function to get the filename Signed-off

[Qemu-devel] [PATCH v4 3/5] usb-mtp: Support delete of mtp objects

2018-02-20 Thread Bandan Das
Write of existing objects by the initiator is acheived by making a temporary buffer with the new changes, deleting the old file and then writing a new file with the same name. Also, add a "readonly" property which needs to be set to false for deletion to work. Signed-off-by: Bandan Das --- hw/u

[Qemu-devel] [PATCH v4 0/5] Initial write support for MTP objects

2018-02-20 Thread Bandan Das
v4: 4/5: Remove getumask and set default permissions to 0644 5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1 Test compilation on freebsd v3: 3/5: Add a property that sets r/w to on/off (default:off) Restructure ifdefs 4/5: Sort the response codes 5/5: Use ac

[Qemu-devel] [PATCH v4 1/5] usb-mtp: Add one more argument when building results

2018-02-20 Thread Bandan Das
The response to a SendObjectInfo consists of the storageid, parent obejct handle and the handle reserved for the new incoming object Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --g

[Qemu-devel] [PATCH v4 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-20 Thread Bandan Das
Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive write data based on a previous SendObjectInfo operation by the init

[Qemu-devel] [PATCH v4 2/5] usb-mtp: print parent path in IN_IGNORED trace fn

2018-02-20 Thread Bandan Das
Fix a possible null dereference when deleting a folder and its contents. An ignored event might be received for its contents after the parent folder is deleted which will return a null object. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(

Re: [Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

2018-02-20 Thread Eric Blake
On 02/20/2018 11:40 AM, Thomas Huth wrote: "-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter (or hubs). Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the deprecati

Re: [Qemu-devel] [PATCH v2 2/8] net: List available netdevs with "-netdev help"

2018-02-20 Thread Eric Blake
On 02/20/2018 11:40 AM, Thomas Huth wrote: Other options like "-chardev" or "-device" feature a nice help text with the available devices when being called with "help" or "?". Since it is quite useful, especially if you want to see which network backends have been compiled into the QEMU binary, l

[Qemu-devel] [PATCH 0/2] qcow2: minor compression improvements

2018-02-20 Thread Eric Blake
I noticed these while reviewing Berto's proposed change to the qcow2 spec on how compression works. Eric Blake (2): qcow2: Prefer byte-based calls into bs->file qcow2: Avoid memory over-allocation on compressed images block/qcow2-cluster.c | 17 + block/qcow2-refcount.c | 6

[Qemu-devel] [PATCH 1/2] qcow2: Prefer byte-based calls into bs->file

2018-02-20 Thread Eric Blake
We had only three sector-based stragglers left; convert them to use our preferred byte-based accesses. Signed-off-by: Eric Blake --- block/qcow2-cluster.c | 5 ++--- block/qcow2-refcount.c | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c b/block/q

[Qemu-devel] [PATCH 2/2] qcow2: Avoid memory over-allocation on compressed images

2018-02-20 Thread Eric Blake
When reading a compressed image, we were allocating s->cluster_data to 32*cluster_size + 512 (possibly over 64 megabytes, for an image with 2M clusters). Let's check out the history: Back when qcow2 was first written, we used s->cluster_data for everything, including copy_sectors() and encryption

Re: [Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 04:03 PM, Eric Blake wrote: boundary. Technically, it might be possible, but qemu does NOT do that (again, looking at qcow2_alloc_bytes() - we loop if free_in_cluster < size) - so we may want to be explicit about this point to prevent OTHER implementations from creating a compres

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Paolo Bonzini wrote: I don't mind either way and don't expect to change this u-boot source too much in the future so if you just copy it to the qemu repo without mirroring my repo that's fine as well. (If any change will be needed I can submit patches for it like for other QE

Re: [Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 01:40 PM, Eric Blake wrote: On 02/20/2018 11:01 AM, Alberto Garcia wrote: tl:dr; I think we need a v3 with even more clarification. I'm also making an additional observationn: Due to the pigeonhole principle and the fact that the compression stream adds metadata, we KNOW tha

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 19:43, Peter Maydell wrote: > I just noticed that we seem to have acquired another git > submodule that isn't pointing to a qemu.org git url: > > [submodule "roms/seabios-hppa"] > path = roms/seabios-hppa > url = git://github.com/hdeller/seabios-hppa.git > > Jeff, co

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 22:41, BALATON Zoltan wrote: > On Tue, 20 Feb 2018, Peter Maydell wrote: >> I just noticed that we seem to have acquired another git >> submodule that isn't pointing to a qemu.org git url: >> >> [submodule "roms/seabios-hppa"] >>    path = roms/seabios-hppa >>    url = git://g

Re: [Qemu-devel] [PATCH 2/2] pc-bios: Added u-boot-sam460 firmware binary

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Daniel P. Berrangé wrote: On Tue, Feb 20, 2018 at 06:57:43PM +0100, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- Makefile | 2 +- pc-bios/u-boot-sam460-20100605.bin | Bin 0 -> 524288 bytes 2 files changed, 1 insertion(+), 1 deletion(

Re: [Qemu-devel] [Qemu-block] Limiting coroutine stack usage

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 18:04, Peter Lieven wrote: > Hi, > > I remember we discussed a long time ago to limit the stack usage of all > functions that are executed in a coroutine > context to a very low value to be able to safely limit the coroutine > stack size as well. IIRC the only issue was that hw/ide/

Re: [Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread BALATON Zoltan
On Tue, 20 Feb 2018, Peter Maydell wrote: I just noticed that we seem to have acquired another git submodule that isn't pointing to a qemu.org git url: [submodule "roms/seabios-hppa"] path = roms/seabios-hppa url = git://github.com/hdeller/seabios-hppa.git And there's also [subm

Re: [Qemu-devel] [PULL 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-20 Thread Bandan Das
Eric Blake writes: > On 02/20/2018 09:28 AM, Gerd Hoffmann wrote: >> From: Bandan Das >> >> Allow write operations on behalf of the initiator. The >> precursor to write is the sending of the write metadata >> that consists of the ObjectInfo dataset. This patch introduces >> a flag that is set wh

[Qemu-devel] [PATCH] fpu/softfloat: use hardware sqrt if we can (EXPERIMENT!)

2018-02-20 Thread Alex Bennée
This is an attempt to save some of the cost of sqrt by using the inbuilt support of the host hardware. The idea is assuming we start with a valid input we can use the hardware. If any tininess issues occur this will trip and FPU exception where: - we turn off cpu->use_host_fpu - mask the FPU e

Re: [Qemu-devel] [PULL 4/5] usb-mtp: Introduce write support for MTP objects

2018-02-20 Thread Eric Blake
On 02/20/2018 09:28 AM, Gerd Hoffmann wrote: From: Bandan Das Allow write operations on behalf of the initiator. The precursor to write is the sending of the write metadata that consists of the ObjectInfo dataset. This patch introduces a flag that is set when the responder is ready to receive w

Re: [Qemu-devel] [PATCH 0/2] Firmware blob and git submodule for Sam460ex

2018-02-20 Thread Emilio G. Cota
On Tue, Feb 20, 2018 at 18:31:17 +, Peter Maydell wrote: > On 20 February 2018 at 18:10, BALATON Zoltan wrote: > > I've created a git repo for the Sam460ex u-boot sources and this adds > > that as a submodule and a separate patch to add the binary built from > > these sources. Feel free to kee

[Qemu-devel] [PATCH v8] ui/cocoa.m: Add ability for user to specify mouse ungrab key

2018-02-20 Thread John Arbuckle
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. This combination may not be very fun for the user to have to enter, so we now enable the user to specify their own key(s) as the ungrab key(s). The list of keys that can be used is found in the file qapi/ui.json under QKey

Re: [Qemu-devel] [PATCH v2] specs/qcow2: Fix documentation of the compressed cluster descriptor

2018-02-20 Thread Eric Blake
On 02/20/2018 11:01 AM, Alberto Garcia wrote: tl:dr; I think we need a v3 with even more clarification. The documentation claims that the cluster descriptor contains the number of sectors used to store the compressed data, but what it actually contains is the number of sectors *minus one*. Th

[Qemu-devel] [PATCH v1 1/3] s390x/sclp: proper support of larger send and receive masks

2018-02-20 Thread Claudio Imbrenda
The architecture allows the guests to ask for masks up to 1021 bytes in length. Part was fixed in 67915de9f0383ccf4ab8c42dd02aa18dcd79b411 ("s390x/event-facility: variable-length event masks"), but some issues were still remaining, in particular regarding the handling of selective reads. This patc

[Qemu-devel] [PATCH v1 2/3] s390x/sclp: clean up sclp masks

2018-02-20 Thread Claudio Imbrenda
Clean up SCLP masks: introduce an sccb_mask_t to be used for SCLP event masks instead of just unsigned int or uint32_t. This will allow later to extend the mask with more ease. Signed-off-by: Claudio Imbrenda --- hw/char/sclpconsole-lm.c | 4 ++-- hw/char/sclpconsole.c | 4

[Qemu-devel] Moving seabios-hppa git submodule to use a qemu.org mirror

2018-02-20 Thread Peter Maydell
I just noticed that we seem to have acquired another git submodule that isn't pointing to a qemu.org git url: [submodule "roms/seabios-hppa"] path = roms/seabios-hppa url = git://github.com/hdeller/seabios-hppa.git Jeff, could we set up so we can mirror this repo on qemu.org? Then

[Qemu-devel] [PATCHv2 11/11] macio: remove macio_init() function

2018-02-20 Thread Mark Cave-Ayland
Move the remaining comment into macio.c for reference, then remove the macio_init() function and instantiate the macio devices for both Old World and New World machines via qdev_init_nofail() directly. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 11 +++ hw/ppc/mac_newworl

Re: [Qemu-devel] [PATCHv2 01/11] macio: embed DBDMA device directly within macio

2018-02-20 Thread Philippe Mathieu-Daudé
On 02/20/2018 03:41 PM, Mark Cave-Ayland wrote: > The current recommendation is to embed subdevices directly within their > container > device, so do this for the DBDMA device. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/misc/macio/macio.c | 13 +++-

[Qemu-devel] [PATCHv2 10/11] macio: move setting of CUDA timebase frequency to macio_common_realize()

2018-02-20 Thread Mark Cave-Ayland
This removes the last of the functionality from macio_init() in preparation for its subsequent removal. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/misc/macio/macio.c b/hw/misc/macio/macio.c index e5288f1

[Qemu-devel] [PATCH v1 3/3] s390x/sclp: extend SCLP event masks to 64 bits

2018-02-20 Thread Claudio Imbrenda
Extend the SCLP event masks to 64 bits. This will make us future proof against future extensions of the architecture. Notice that using any of the new bits results in a state that cannot be migrated to an older version. Signed-off-by: Claudio Imbrenda --- hw/s390x/event-facility.c | 43

[Qemu-devel] [PATCHv2 04/11] heathrow: convert to trace-events

2018-02-20 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/intc/heathrow_pic.c | 32 +++- hw/intc/trace-events | 5 + 2 files changed, 16 insertions(+), 21 deletions(-) diff --git a/hw/intc/heathrow_pic.c b/hw/intc/heathrow_pic.c index 7bf44e0d86..5fd2b33a12 100644 --- a/hw/intc/h

[Qemu-devel] [PATCHv2 09/11] mac_newworld: use object link to pass OpenPIC object to macio

2018-02-20 Thread Mark Cave-Ayland
Also switch macio_newworld_realize() over to use it rather than using the pic_mem memory region directly. Now that both Old World and New World macio devices no longer make use of the pic_mem memory region directly, we can remove it. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c

[Qemu-devel] [PATCHv2 03/11] heathrow: QOMify heathrow PIC

2018-02-20 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/intc/heathrow_pic.c | 126 +++-- include/hw/intc/heathrow_pic.h | 49 2 files changed, 119 insertions(+), 56 deletions(-) create mode 100644 include/hw/intc/heathrow_pic.h diff --git a/hw/intc/h

[Qemu-devel] [PATCH v1 0/3] s390x/sclp: 64 bit event masks

2018-02-20 Thread Claudio Imbrenda
Until 67915de9f0383ccf4a ("s390x/event-facility: variable-length event masks") we only supported 32bit sclp event masks, even though the archiecture allows the guests to set up sclp event masks up to 1021 bytes in length. With that patch the behaviour was almost compliant, but some issues were stil

[Qemu-devel] [PATCHv2 07/11] mac_oldworld: use object link to pass heathrow PIC object to macio

2018-02-20 Thread Mark Cave-Ayland
Also switch macio_oldworld_realize() over to use it rather than using the pic_mem memory region directly. Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson --- hw/misc/macio/macio.c | 14 ++ hw/ppc/mac_oldworld.c | 8 +--- include/hw/misc/macio/macio.h

[Qemu-devel] [PATCHv2 06/11] macio: move macio related structures and defines into separate macio.h file

2018-02-20 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: David Gibson --- hw/misc/macio/macio.c | 43 + hw/ppc/mac.h | 3 -- hw/ppc/mac_newworld.c | 1 + hw/ppc/mac_oldworld.c | 1 + include/hw/misc/macio/macio.h | 75 ++

[Qemu-devel] [PATCHv2 05/11] heathrow: change heathrow_pic_init() to return the heathrow device

2018-02-20 Thread Mark Cave-Ayland
This enables the device to be made available during the setup of the Old World machine. In order to pass back the previous set of IRQs we temporarily introduce a new pic_irqs parameter until it can be removed. An additional benefit of this change is that it is also possible to remove the pic_mem p

[Qemu-devel] [PATCHv2 08/11] openpic: move OpenPIC state and related definitions to openpic.h

2018-02-20 Thread Mark Cave-Ayland
This is to faciliate access to OpenPICState when wiring up the PIC to the macio controller. Signed-off-by: Mark Cave-Ayland --- hw/intc/openpic.c| 157 -- include/hw/ppc/openpic.h | 160 ++- 2 files c

[Qemu-devel] [PATCHv2 00/11] macio: remove legacy macio_init() function

2018-02-20 Thread Mark Cave-Ayland
This patchset eliminates the legacy macio_init() function used to setup the ESCC and PIC memory regions and instead allows the macio device to be instantiated directly via qdev, wiring up the ESCC internally using sysbus MMIO memory regions and the PIC via QOM object links. The biggest surprise in

[Qemu-devel] [PATCHv2 01/11] macio: embed DBDMA device directly within macio

2018-02-20 Thread Mark Cave-Ayland
The current recommendation is to embed subdevices directly within their container device, so do this for the DBDMA device. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/macio.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/misc/macio/macio.c b/hw/misc/

[Qemu-devel] [PATCHv2 02/11] macio: move ESCC device within the macio device

2018-02-20 Thread Mark Cave-Ayland
Now that the ESCC device is instantiated directly via qdev, move it to within the macio device and wire up the IRQs and memory regions using the sysbus API. This enables to remove the now-obsolete escc_mem parameter to the macio_init() function. (Note this patch also contains small touch-ups to t

Re: [Qemu-devel] [PATCH v2 7/8] net: Add a new convenience option "--nic" to configure default/on-board NICs

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 18:40, Thomas Huth wrote: > The legacy "-net" option can be quite confusing for the users since most > people do not expect to get a "vlan" hub between their emulated guest > hardware and the host backend. But so far, we are also not able to get > rid of "-net" completely, since it is

Re: [Qemu-devel] [PATCH v2 8/8] qemu-doc: Make "-net" less prominent

2018-02-20 Thread Paolo Bonzini
On 20/02/2018 18:40, Thomas Huth wrote: > "-net" is clearly a legacy option. Yet we still use it in almost all > examples in the qemu documentation, and many other spots in the network > chapter. We should make it less prominent that users are not lured into > using it so often anymore. So instead

Re: [Qemu-devel] [PATCH 0/2] Firmware blob and git submodule for Sam460ex

2018-02-20 Thread Peter Maydell
On 20 February 2018 at 18:10, BALATON Zoltan wrote: > I've created a git repo for the Sam460ex u-boot sources and this adds > that as a submodule and a separate patch to add the binary built from > these sources. Feel free to keep this as two patches, squash them into > one patch or take the git r

Re: [Qemu-devel] [PATCH 2/2] pc-bios: Added u-boot-sam460 firmware binary

2018-02-20 Thread Daniel P . Berrangé
On Tue, Feb 20, 2018 at 06:57:43PM +0100, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > Makefile | 2 +- > pc-bios/u-boot-sam460-20100605.bin | Bin 0 -> 524288 bytes > 2 files changed, 1 insertion(+), 1 deletion(-) > create mode 100755 pc-bios/u-boot-

Re: [Qemu-devel] [PATCH 10/19] include/hw/or-irq.h: Add missing include guard

2018-02-20 Thread Philippe Mathieu-Daudé
On 02/20/2018 03:03 PM, Peter Maydell wrote: > The or-irq.h header file is missing the customary guard against > multiple inclusion, which means compilation fails if it gets > included twice. Fix the omission. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- > includ

Re: [Qemu-devel] [Qemu-arm] [PATCH 11/19] qdev: Add new qdev_init_gpio_in_named_with_opaque()

2018-02-20 Thread Philippe Mathieu-Daudé
On 02/20/2018 03:03 PM, Peter Maydell wrote: > The function qdev_init_gpio_in_named() passes the DeviceState pointer > as the opaque data pointor for the irq handler function. Usually > this is what you want, but in some cases it would be helpful to use > some other data pointer. > > Add a new fu

Re: [Qemu-devel] [Qemu-arm] [PATCH 09/19] hw/misc/unimp: Move struct to header file

2018-02-20 Thread Philippe Mathieu-Daudé
On 02/20/2018 03:03 PM, Peter Maydell wrote: > Move the definition of the struct for the unimplemented-device > from unimp.c to unimp.h, so that users can embed the struct > in their own device structs if they prefer. > > Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé > --- >

[Qemu-devel] [PATCH 1/2] roms: Added git submodule for u-boot-sam460 (firmware for sam460ex)

2018-02-20 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- .gitmodules | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitmodules b/.gitmodules index 7a8282d..b76fb45 100644 --- a/.gitmodules +++ b/.gitmodules @@ -43,3 +43,6 @@ [submodule "roms/seabios-hppa"] path = roms/seabios-hppa url = git://

[Qemu-devel] [PATCH 0/2] Firmware blob and git submodule for Sam460ex

2018-02-20 Thread BALATON Zoltan
I've created a git repo for the Sam460ex u-boot sources and this adds that as a submodule and a separate patch to add the binary built from these sources. Feel free to keep this as two patches, squash them into one patch or take the git repo and commit the content under the QEMU repo and use that a

[Qemu-devel] [PATCH 19/19] mps2-an505: New board model: MPS2 with AN505 Cortex-M33 FPGA image

2018-02-20 Thread Peter Maydell
Define a new board model for the MPS2 with an AN505 FPGA image containing a Cortex-M33. Since the FPGA images for TrustZone cores (AN505, and the similar AN519 for Cortex-M23) have a significantly different layout of devices to the non-TrustZone images, we use a new source file rather than shoehorn

[Qemu-devel] [PATCH 18/19] hw/arm/iotkit: Model Arm IOT Kit

2018-02-20 Thread Peter Maydell
Model the Arm IoT Kit documented in http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ecm0601256/index.html The Arm IoT Kit is a subsystem which includes a CPU and some devices, and is intended be extended by adding extra devices to form a complete system. It is used in the MPS2 board's

[Qemu-devel] [PATCH 03/19] hw/arm/armv7m: Honour CPU's address space for image loads

2018-02-20 Thread Peter Maydell
Instead of loading guest images to the system address space, use the CPU's address space. This is important if we're trying to load the file to memory or via an alias memory region that is provided by an SoC object and thus not mapped into the system address space. Signed-off-by: Peter Maydell R

[Qemu-devel] [PATCH 15/19] hw/misc/iotkit-secctl: Arm IoT Kit security controller initial skeleton

2018-02-20 Thread Peter Maydell
The Arm IoT Kit includes a "security controller" which is largely a collection of registers for controlling the PPCs and other bits of glue in the system. This commit provides the initial skeleton of the device, implementing just the ID registers, and a couple of read-only read-as-zero registers.

[Qemu-devel] [PATCH 02/19] hw/arm/boot: Honour CPU's address space for image loads

2018-02-20 Thread Peter Maydell
Instead of loading kernels, device trees, and the like to the system address space, use the CPU's address space. This is important if we're trying to load the file to memory or via an alias memory region that is provided by an SoC object and thus not mapped into the system address space. Signed-of

[Qemu-devel] [PATCH 04/19] target/arm: Define an IDAU interface

2018-02-20 Thread Peter Maydell
In v8M, the Implementation Defined Attribution Unit (IDAU) is a small piece of hardware typically implemented in the SoC which provides board or SoC specific security attribution information for each address that the CPU performs MPU/SAU checks on. For QEMU, we model this with a QOM interface which

[Qemu-devel] [PATCH 16/19] hw/misc/iotkit-secctl: Add handling for PPCs

2018-02-20 Thread Peter Maydell
The IoTKit Security Controller includes various registers that expose to software the controls for the Peripheral Protection Controllers in the system. Implement these. Signed-off-by: Peter Maydell --- include/hw/misc/iotkit-secctl.h | 64 +- hw/misc/iotkit-secctl.c | 270 ++

[Qemu-devel] [PATCH 06/19] target/arm: Define init-svtor property for the reset secure VTOR value

2018-02-20 Thread Peter Maydell
The Cortex-M33 allows the system to specify the reset value of the secure Vector Table Offset Register (VTOR) by asserting config signals. In particular, guest images for the MPS2 AN505 board rely on the MPS2's initial VTOR being correct for that board. Implement a QEMU property so board and SoC co

[Qemu-devel] [PATCH 14/19] hw/misc/tz-ppc: Model TrustZone peripheral protection controller

2018-02-20 Thread Peter Maydell
Add a model of the TrustZone peripheral protection controller (PPC), which is used to gate transactions to non-TZ-aware peripherals so that secure software can configure them to not be accessible to non-secure software. Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs | 2 + in

[Qemu-devel] [PATCH 07/19] armv7m: Forward init-svtor property to CPU object

2018-02-20 Thread Peter Maydell
Create an "init-svtor" property on the armv7m container object which we can forward to the CPU object. Signed-off-by: Peter Maydell --- include/hw/arm/armv7m.h | 2 ++ hw/arm/armv7m.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/include/hw/arm/armv7m.h b/include/hw/arm/armv

[Qemu-devel] [PATCH 01/19] loader: Add new load_ramdisk_as()

2018-02-20 Thread Peter Maydell
Add a function load_ramdisk_as() which behaves like the existing load_ramdisk() but allows the caller to specify the AddressSpace to use. This matches the pattern we have already for various other loader functions. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- include/hw/

[Qemu-devel] [PATCH 17/19] hw/misc/iotkit-secctl: Add remaining simple registers

2018-02-20 Thread Peter Maydell
Add remaining easy registers to iotkit-secctl: * NSCCFG just routes its two bits out to external GPIO lines * BRGINSTAT/BRGINTCLR/BRGINTEN can be dummies, because QEMU's bus fabric can never report errors Signed-off-by: Peter Maydell --- include/hw/misc/iotkit-secctl.h | 4 hw/misc/io

[Qemu-devel] [PATCH 12/19] hw/core/split-irq: Device that splits IRQ lines

2018-02-20 Thread Peter Maydell
In some board or SoC models it is necessary to split a qemu_irq line so that one input can feed multiple outputs. We currently have qemu_irq_split() for this, but that has several deficiencies: * it can only handle splitting a line into two * it unavoidably leaks memory, so it can't be used i

[Qemu-devel] [PATCH 09/19] hw/misc/unimp: Move struct to header file

2018-02-20 Thread Peter Maydell
Move the definition of the struct for the unimplemented-device from unimp.c to unimp.h, so that users can embed the struct in their own device structs if they prefer. Signed-off-by: Peter Maydell --- include/hw/misc/unimp.h | 10 ++ hw/misc/unimp.c | 10 -- 2 files change

[Qemu-devel] [PATCH 05/19] armv7m: Forward idau property to CPU object

2018-02-20 Thread Peter Maydell
Create an "idau" property on the armv7m container object which we can forward to the CPU object. Annoyingly, we can't use object_property_add_alias() because the CPU object we want to forward to doesn't exist until the armv7m container is realized. Signed-off-by: Peter Maydell --- include/hw/arm

[Qemu-devel] [PATCH 08/19] target/arm: Add Cortex-M33

2018-02-20 Thread Peter Maydell
Add a Cortex-M33 definition. The M33 is an M profile CPU which implements the ARM v8M architecture, including the M profile Security Extension. Signed-off-by: Peter Maydell --- target/arm/cpu.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/target/arm/cpu.c

[Qemu-devel] [PATCH 00/19] Add Cortex-M33 and mps2-an505 board model

2018-02-20 Thread Peter Maydell
This patchset enables the Cortex-M33 v8M CPU type and adds a board model for it: the AN505 FPGA image for the MPS2+ devboard. The AN505 uses and extends the "IoT Kit", which is a reference subsystem that includes the CPU and some devices, and is intended to be extended further to build a complete d

[Qemu-devel] [PATCH 11/19] qdev: Add new qdev_init_gpio_in_named_with_opaque()

2018-02-20 Thread Peter Maydell
The function qdev_init_gpio_in_named() passes the DeviceState pointer as the opaque data pointor for the irq handler function. Usually this is what you want, but in some cases it would be helpful to use some other data pointer. Add a new function qdev_init_gpio_in_named_with_opaque() which allows

[Qemu-devel] [PATCH 13/19] hw/misc/mps2-fpgaio: FPGA control block for MPS2 AN505

2018-02-20 Thread Peter Maydell
The MPS2 AN505 FPGA image includes a "FPGA control block" which is a small set of registers handling LEDs, buttons and some counters. Signed-off-by: Peter Maydell --- hw/misc/Makefile.objs | 1 + include/hw/misc/mps2-fpgaio.h | 43 ++ hw/misc/mps2-fpgaio.c | 176

[Qemu-devel] [PATCH 10/19] include/hw/or-irq.h: Add missing include guard

2018-02-20 Thread Peter Maydell
The or-irq.h header file is missing the customary guard against multiple inclusion, which means compilation fails if it gets included twice. Fix the omission. Signed-off-by: Peter Maydell --- include/hw/or-irq.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/or-irq.h b/inclu

Re: [Qemu-devel] [PATCH] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes

2018-02-20 Thread Stefan Hajnoczi
On Tue, Feb 20, 2018 at 3:12 PM, Peter Lieven wrote: > Am 15.02.2018 um 18:27 schrieb Stefan Hajnoczi: >> >> On Thu, Feb 15, 2018 at 03:24:54PM +0100, Peter Lieven wrote: >>> >>> Am 15.02.2018 um 12:15 schrieb Stefan Hajnoczi: The libiscsi iscsi_task_mgmt_async() API documentation says:

Re: [Qemu-devel] [PATCH 2/5] tests: more thorough test of ds1338

2018-02-20 Thread Michael Davidsaver
On 02/18/2018 11:39 PM, Thomas Huth wrote: > On 19.02.2018 05:03, Michael Davidsaver wrote: >> Test current time and set+get round trip. >> >> The set+get test is repeated 4 times. These cases are >> spread across a single day in an attempt to trigger some potential >> issues regardless of the tim

[Qemu-devel] [PATCH v2 8/8] qemu-doc: Make "-net" less prominent

2018-02-20 Thread Thomas Huth
"-net" is clearly a legacy option. Yet we still use it in almost all examples in the qemu documentation, and many other spots in the network chapter. We should make it less prominent that users are not lured into using it so often anymore. So instead of starting the network chapter with "-net nic"

[Qemu-devel] [PATCH v2 4/8] net: Make net_client_init() static

2018-02-20 Thread Thomas Huth
The function is only used within net.c, so there's no need that this is a global function. While we're at it, also remove the unused prototype compute_mcast_idx() (the function has been removed in commit d9caeb09b107e91122d10ba4a08a). Reviewed-by: Paolo Bonzini Signed-off-by: Thomas Huth --- i

[Qemu-devel] [PATCH v2 5/8] net: Remove the deprecated way of dumping network packets

2018-02-20 Thread Thomas Huth
"-net dump" has been marked as deprecated since QEMU v2.10, since it only works with the deprecated 'vlan' parameter (or hubs). Network dumping should be done with "-object filter-dump" nowadays instead. Since nobody complained so far about the deprecation message, let's finally get rid of "-net du

[Qemu-devel] [PATCH v2 7/8] net: Add a new convenience option "--nic" to configure default/on-board NICs

2018-02-20 Thread Thomas Huth
The legacy "-net" option can be quite confusing for the users since most people do not expect to get a "vlan" hub between their emulated guest hardware and the host backend. But so far, we are also not able to get rid of "-net" completely, since it is the only way to configure on-board NICs that ca

[Qemu-devel] [PATCH v2 1/8] net: Move error reporting from net_init_client/netdev to the calling site

2018-02-20 Thread Thomas Huth
It looks strange that net_init_client() and net_init_netdev() both take an "Error **errp" parameter, but then do the error reporting with "error_report_err(local_err)" on their own. Let's move the error reporting to the calling site instead to simplify this code a little bit. Reviewed-by: Eric Bla

[Qemu-devel] [PATCH v2 6/8] net: Remove the deprecated 'host_net_add' and 'host_net_remove' HMP commands

2018-02-20 Thread Thomas Huth
They are deprecated since QEMU v2.10, and so far nobody complained that these commands are still necessary for any reason - and since you can use 'netdev_add' and 'netdev_remove' instead, there also should not be any real reason. Since they are also standing in the way for the upcoming 'vlan' clean

[Qemu-devel] [PATCH v2 3/8] net: Only show vhost-user in the help text if CONFIG_POSIX is defined

2018-02-20 Thread Thomas Huth
According to net/Makefile.objs we only link in the vhost-user code if CONFIG_POSIX has been set. So the help screen should also only show this information if CONFIG_POSIX has been defined. Reviewed-by: Paolo Bonzini Signed-off-by: Thomas Huth --- qemu-options.hx | 2 ++ 1 file changed, 2 insert

[Qemu-devel] [PATCH v2 2/8] net: List available netdevs with "-netdev help"

2018-02-20 Thread Thomas Huth
Other options like "-chardev" or "-device" feature a nice help text with the available devices when being called with "help" or "?". Since it is quite useful, especially if you want to see which network backends have been compiled into the QEMU binary, let's provide such a help text for "-netdev",

[Qemu-devel] [PATCH v2 0/8] Improvements and clean-ups related to -net

2018-02-20 Thread Thomas Huth
"-net" is a legacy option that often causes confusion and misconfigurations for the users, since most people are not aware of the underlying "vlan" (i.e. hub) concept that is used for this parameter. The prefered way of configuring your network stack is to use "--netdev" instead, which gives you a

[Qemu-devel] [PATCH v5 1/4] linux-user: Move CPU type name selection to a function

2018-02-20 Thread Laurent Vivier
Instead of a sequence of "#if ... #endif" move the selection to a function in linux-user/*/target_elf.h We can't add them in linux-user/*/target_cpu.h because we will need to include "elf.h" to use ELF flags with eflags, and including "elf.h" in "target_cpu.h" introduces some conflicts in elfload.

[Qemu-devel] [PATCH v5 2/4] linux-user: introduce functions to detect CPU type

2018-02-20 Thread Laurent Vivier
From: YunQiang Su Add a function to return ELF e_flags and use it to select the CPU model. Signed-off-by: YunQiang Su [lv: split the patch and some cleanup in get_elf_eflags()] Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson --- Notes: v4: add YunQiang Su's Signed-off-by

[Qemu-devel] [PATCH v5 3/4] linux-user, m68k: select CPU according to ELF header values

2018-02-20 Thread Laurent Vivier
M680x0 doesn't support the same set of instructions as ColdFire, so we can't use "any" CPU type to execute m68020 instructions. We select CPU type ("m68040" or "any" for ColdFire) according to the ELF header. If we can't, we use by default the value used until now: "any". Signed-off-by: Laurent Vi

[Qemu-devel] [PATCH v5 0/4] linux-user: select CPU type according ELF header values

2018-02-20 Thread Laurent Vivier
This idea has been suggested to me before by Philippe Mathieu-Daudé, and recently YunQiang Su has proposed a patch to manage the MIPS r6 case. Based on this, this series tries to clean-up the original patch, and introduces the use for m68k architecture and port the patch from YunQiang Su. v5: Use

[Qemu-devel] [PATCH v5 4/4] linux-user: MIPS set cpu to r6 CPU if binary is R6

2018-02-20 Thread Laurent Vivier
From: YunQiang Su So here we need to detect the version of binaries and set cpu_model for it. Signed-off-by: YunQiang Su [lv: original patch modified to move code into cpu_get_model()] Signed-off-by: Laurent Vivier --- Notes: v5: Use EF_MIPS_ARCH mask to read MIPS architecture flags

  1   2   3   >