[Qemu-devel] [PATCH] PPC: e500: Fix duplicate kernel load and device tree overlap

2018-01-29 Thread David Engraf
This patch fixes an incorrect behavior when the -kernel argument has been specified without -bios. In this case the kernel was loaded twice. At address 32M as a raw image and afterwards by load_elf/load_uimage at the corresponding load address. In this case the region for the device tree and the ra

[Qemu-devel] [Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

2018-01-29 Thread Fam Zheng
QEMU ignores the CHS numbers in VMDK images. From the report, it seems VirtualBox uses it. So like what you've discovered, for QEMU the right thing to do for such a guest would be setting the correct values explicitly from the command line, rather than let it decide (guess). I have no idea about

Re: [Qemu-devel] [PATCH v5 2/2] qemu-img: Document --force-share / -U

2018-01-29 Thread Fam Zheng
On Tue, Jan 30, 2018 at 12:01 AM, Max Reitz wrote: > On 2017-12-26 03:52, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> Reviewed-by: Stefan Hajnoczi >> Reviewed-by: Kashyap Chamarthy >> Signed-off-by: Kevin Wolf >> --- >> qemu-img.texi | 9 + >> 1 file changed, 9 insertions(+) >> >>

[Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

2018-01-29 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..ec7e2f5d1e 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -86,6 +86,13 @@ exclusive with the @var{-O} parameters. It

[Qemu-devel] [PATCH v6 0/2] qemu-img: Document --force-share / -U

2018-01-29 Thread Fam Zheng
v6: Tweak wording ("concurrent writers"). [Max] Fam Zheng (2): qemu-img.texi: Clean up parameter list qemu-img: Document --force-share / -U qemu-img.texi | 73 +-- 1 file changed, 46 insertions(+), 27 deletions(-) -- 2.14.3

[Qemu-devel] [PATCH v6 1/2] qemu-img.texi: Clean up parameter list

2018-01-29 Thread Fam Zheng
Split options out of the "@table @var" section and create a "@table @option", then use whitespaces and blank lines consistently. Suggested-by: Kevin Wolf Signed-off-by: Fam Zheng --- qemu-img.texi | 66 +++ 1 file changed, 39 insertions(+)

Re: [Qemu-devel] [PULL 00/13] Migration PULL request

2018-01-29 Thread Juan Quintela
/tags/pull-nbd-2018-01-26' into staging (2018-01-26 >> 17:29:14 +0000) >> >> are available in the Git repository at: >> >> git://github.com/juanquintela/qemu.git tags/migration/20180129 >> >>

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-29 Thread Fam Zheng
On Mon, Jan 29, 2018 at 11:49 PM, Kevin Wolf wrote: > Am 24.01.2018 um 05:42 hat Fam Zheng geschrieben: >> The descriptor block in the image, which includes the CID to verify, has been >> invalid since the reference image was added. Since commit 9877860e7bd we >> report >> this error earlier than

[Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

2018-01-29 Thread Fam Zheng
This reverts commit 76bf133c4 which updated the reference output, and fixed the reference image, because the code path we want to exercise is actually the invalid image size. The descriptor block in the image, which includes the CID to verify, has been invalid since the reference image was added.

Re: [Qemu-devel] [QEMU-PPC] [PATCH V5 2/7] target/ppc/spapr_caps: Add macro to generate spapr_caps migration vmstate

2018-01-29 Thread Suraj Jitindar Singh
On Mon, 2018-01-29 at 14:03 +1100, Alexey Kardashevskiy wrote: > On 29/01/18 10:43, Suraj Jitindar Singh wrote: > > On Fri, 2018-01-19 at 16:18 +1100, Alexey Kardashevskiy wrote: > > > On 19/01/18 16:00, Suraj Jitindar Singh wrote: > > > > The vmstate description and the contained needed function f

Re: [Qemu-devel] [RFC PATCH v5 00/24] replay additions

2018-01-29 Thread Pavel Dovgalyuk
Ping? Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Tuesday, January 23, 2018 11:53 AM > To: qemu-devel@nongnu.org > Cc: kw...@redhat.com; peter.mayd...@linaro.org; boost.li...@gmail.com; > quint...@redhat.com; > jasow...@redhat.c

Re: [Qemu-devel] [PATCH V4 00/16] COLO: integrate colo frame with block replication and COLO proxy

2018-01-29 Thread Zhang Chen
Hi~ All~ No news for a long time, this is the last part to make COLO running in upstream. Any comments for this series? Thanks Zhang Chen On Fri, Jan 19, 2018 at 1:44 PM, Zhang Chen wrote: > From: Zhang Chen > > Hi~ > > COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror,

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-29 Thread Dong Jia Shi
Halil Pasic writes: --text follows this line-- Hi Halil, --text follows this line-- AS you may noticed, Conny replied to this thread on my mail. Some of her comments there could answer your questions. If that applies, I will just say "See Conny's mail" in the following, and you can reply to that m

[Qemu-devel] [PATCH] hw/audio/sb16.c: Convert file to new logging API

2018-01-29 Thread John Arbuckle
Use the qemu_log_mask() function to log messages. Signed-off-by: John Arbuckle --- hw/audio/sb16.c | 221 1 file changed, 112 insertions(+), 109 deletions(-) diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c index 6ab2f6f89a..bdb79aeafa 1006

Re: [Qemu-devel] [PATCH qemu v5 1/2] vfio/common: Add 'p2p' property to enable DMA mapping of MMIO regions

2018-01-29 Thread Alex Williamson
On Tue, 30 Jan 2018 14:55:26 +1100 Alexey Kardashevskiy wrote: > At the moment we map all RAM memory regions for possible DMA including > MMIO regions of passed through device as this might be used for P2P PCI. > However if DMA map fails for whatever reason, we fail and exit QEMU. > Since P2P is

[Qemu-devel] [PULL v5 00/43] hppa-softmmu

2018-01-29 Thread Richard Henderson
Changes since v4: * Fix format warnings for 32-bit host. r~ The following changes since commit 30d9fefe1aca1e92c785214aa9201fd7c2287d56: Merge remote-tracking branch 'remotes/kraxel/tags/input-20180129-v2-pull-request' into staging (2018-01-29 15:52:27 +) are available

[Qemu-devel] [PULL v5 39/43] hw/hppa: Implement DINO system board

2018-01-29 Thread Richard Henderson
From: Helge Deller Now that we have the prerequisites in target/hppa/, implement the hardware for a PA7100LC. This also enables build for hppa-softmmu. Signed-off-by: Helge Deller [rth: Since it is all new code, squashed all branch development withing hw/hppa/ to a single patch.] Signed-off-by

Re: [Qemu-devel] [PATCH] vfio/pci: Add option to disable GeForce quirks

2018-01-29 Thread Alex Williamson
On Tue, 30 Jan 2018 00:46:38 -0300 Philippe Mathieu-Daudé wrote: > Hi Alex, > > On 01/29/2018 05:23 PM, Alex Williamson wrote: > > These quirks are necessary for GeForce, but not for Quadro/GRID/Tesla > > assignment. Leaving them enabled is fully functional and provides the > > most compatibili

Re: [Qemu-devel] [PATCH] Only print unknown command message in debug mode

2018-01-29 Thread Programmingkid
> On Jan 29, 2018, at 11:17 PM, Philippe Mathieu-Daudé wrote: > > Hi John, > > On 01/30/2018 12:58 AM, John Arbuckle wrote: >> After using QEMU with the sb16 sound card I would see all these messages >> about some numbered command not being understood. It became annoying after a >> while to a

Re: [Qemu-devel] [PATCH] Only print unknown command message in debug mode

2018-01-29 Thread Philippe Mathieu-Daudé
Hi John, On 01/30/2018 12:58 AM, John Arbuckle wrote: > After using QEMU with the sb16 sound card I would see all these messages > about some numbered command not being understood. It became annoying after a > while to always see this message, so this patch changes things so that the > message

[Qemu-devel] [PATCH] Only print unknown command message in debug mode

2018-01-29 Thread John Arbuckle
After using QEMU with the sb16 sound card I would see all these messages about some numbered command not being understood. It became annoying after a while to always see this message, so this patch changes things so that the message is only printed when DEBUG is defined. Signed-off-by: John Ar

[Qemu-devel] [PATCH qemu v5 1/2] vfio/common: Add 'p2p' property to enable DMA mapping of MMIO regions

2018-01-29 Thread Alexey Kardashevskiy
At the moment we map all RAM memory regions for possible DMA including MMIO regions of passed through device as this might be used for P2P PCI. However if DMA map fails for whatever reason, we fail and exit QEMU. Since P2P is not widely used and tested, it makes sense to exclude MMIO regions from D

[Qemu-devel] [PATCH qemu v5 0/2] vfio-pci: Allow mmap of MSIX BAR

2018-01-29 Thread Alexey Kardashevskiy
This is to enable MSIX BAR mapping to the guest and by the same time avoid failing on p2p DMA mappings. This attempt makes a try to separate p2p handling from msix. This is based on sha1 a6506a9 Suraj Jitindar Singh "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS". Please comment. Thank

[Qemu-devel] [PATCH qemu v5 2/2] RFC: vfio-pci: Allow mmap of MSIX BAR

2018-01-29 Thread Alexey Kardashevskiy
This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability which tells that a region with MSIX data can be mapped entirely, i.e. the VFIO PCI driver won't prevent MSIX vectors area from being mapped. With this change, all BARs are mapped in a single chunk and MSIX vectors are emulated o

Re: [Qemu-devel] [PATCH] vfio/pci: Add option to disable GeForce quirks

2018-01-29 Thread Philippe Mathieu-Daudé
Hi Alex, On 01/29/2018 05:23 PM, Alex Williamson wrote: > These quirks are necessary for GeForce, but not for Quadro/GRID/Tesla > assignment. Leaving them enabled is fully functional and provides the > most compatibility, but due to the unique NVIDIA MSI ACK behavior[1], > it also introduces late

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-29 Thread Dong Jia Shi
* Dong Jia Shi [2018-01-30 11:37:43 +0800]: Damn.. Please just ignore the above mail. It's not the right draft. > Halil Pasic writes: > > Hi Halil, > > As you may noticed, Conny replied to this thread on my mail. Some of her > comments there could answer your questions. If that applies, I wil

Re: [Qemu-devel] [RFC PATCH 0/3] vfio: ccw: basic channel path event handling

2018-01-29 Thread Dong Jia Shi
Halil Pasic writes: Hi Halil, As you may noticed, Conny replied to this thread on my mail. Some of her comments there could answer your questions. If that applies, I will just say "See Conny's mail" in the following, and you can reply to that mail, so we can consolidate further discussion. >>>

Re: [Qemu-devel] [PATCH] char-pty: fix glib assert

2018-01-29 Thread Peter Xu
On Mon, Jan 29, 2018 at 05:40:11PM +0100, Laurent Vivier wrote: > On 29/01/2018 17:17, Juan Quintela wrote: > > I am having this assert over and over: > > > > (process:30804): GLib-CRITICAL **: g_source_unref: assertion 'source != > > NULL' failed > > > > gdb points to the line changed on this p

Re: [Qemu-devel] [RFC v1] block/NVMe: introduce a new vhost NVMe host device to QEMU

2018-01-29 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, January 29, 2018 11:29 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; Harris, James R ; Busch, > Keith ; f...@redhat.com; pbonz...@redhat.com; > m...@redhat.com > Subject: Re: [RFC v1] block/NV

[Qemu-devel] [PULL v2 2/6] tpm: fix alignment issues

2018-01-29 Thread Stefan Berger
From: Marc-André Lureau The new tpm-crb-test fails on sparc host: TEST: tests/tpm-crb-test... (pid=230409) /i386/tpm-crb/test: Broken pipe FAIL GTester: last random seed: R02S29cea50247fe1efa59ee885a26d51a85 (pid=230423) FAIL: tests/tpm-crb-test and generates a new clang sanitizer runtime war

[Qemu-devel] [PULL v2 1/6] tpm: Set the flags of the CMD_INIT command to 0

2018-01-29 Thread Stefan Berger
The flags of the CMD_INIT control channel command were not initialized properly. Fix this and set to 0. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_emulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/tpm/tpm_emulator.c b/hw/tpm/tpm

[Qemu-devel] [PULL v2 5/6] tpm: report backend request error

2018-01-29 Thread Stefan Berger
From: Marc-André Lureau Use an Error** for request to let the caller handle error reporting. This will also allow to inform the frontend of a backend error. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- backends/tpm.c | 9 +++

[Qemu-devel] [PULL v2 6/6] tpm: add CRB device

2018-01-29 Thread Stefan Berger
From: Marc-André Lureau tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and CRB model at run time, but

[Qemu-devel] [PULL v2 4/6] tpm: replace GThreadPool with AIO threadpool

2018-01-29 Thread Stefan Berger
From: Marc-André Lureau The TPM backend uses a GThreadPool to handle IO in a seperate thread. However, GThreadPool isn't integrated with Qemu main loops, making it unnecessarily complicated to deal with. Qemu has a AIO threadpool, that is better integrated with loops and various IO functions, pr

[Qemu-devel] [PULL v2 0/6] Merge tpm 2018/01/26

2018-01-29 Thread Stefan Berger
The patches in this pull request fix a bug in the initialization of a variable, adapt the cancel path used by the passthrough device to the sysfs path of more recent versions of the Linux kernel, and do some other cleanups preparing for support of migration. Finally, we add the CRB interface emulat

[Qemu-devel] [PULL v2 3/6] tpm: lookup cancel path under tpm device class

2018-01-29 Thread Stefan Berger
From: Marc-André Lureau Since Linux commit 313d21eeab9282e, tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger Signed-off-by: Stefan Berger --- hw/t

Re: [Qemu-devel] [PATCH 0/7] tests: virtio-9p: test request cancellation

2018-01-29 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 12:38:30AM +0100, Greg Kurz wrote: > This series does several changes to virtio-9p-test in order to be able > to test request cancellation (flush in 9p wording): > > patches 1-2: preparatory work, basically doing things in the test code, > rather that in the co

Re: [Qemu-devel] [PATCH 5/7] tests: virtio-9p: add WRITE operation test

2018-01-29 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 12:39:23AM +0100, Greg Kurz wrote: > +/* size[4] Twrite tag[2] fid[4] offset[8] count[4] data[count] */ > +static P9Req *v9fs_twrite(QVirtIO9P *v9p, uint32_t fid, uint64_t offset, > + uint32_t count, const void *data, uint16_t tag) > +{ > +P9Req

[Qemu-devel] [PATCH 3/4] multiboot: make tests work with clang

2018-01-29 Thread Anatol Pomozov
* clang 3.8 enables SSE even for 32bit code. Generate code for pentium CPU to make sure no new instructions are used. * add memset() implementation. Clang implements array zeroing in print_num() via memset() function call. Signed-off-by: Anatol Pomozov --- tests/multiboot/Makefile| 2

[Qemu-devel] [PATCH 4/4] multiboot: Make elf64 loading functionality compatible with GRUB

2018-01-29 Thread Anatol Pomozov
GRUB is a reference multiboot implementation and supports loading elf64 binaries. Make QEMU to work similar was as GRUB. --- hw/i386/multiboot.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 79b89e4fee..676ac7c48d 100644 --- a/hw/i386/multi

[Qemu-devel] [PATCH 2/4] multiboot: load elf sections and section headers

2018-01-29 Thread Anatol Pomozov
Multiboot may load section headers and all sections (even those that are not part of any segment) to target memory. Tested with an ELF application that uses data from strings table section. Signed-off-by: Anatol Pomozov --- hw/core/loader.c | 8 +-- hw/i386/multiboot.c

[Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-01-29 Thread Anatol Pomozov
Using C structs makes the code more readable and prevents type conversion errors. Borrow multiboot1 header from GRUB project. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 124 + hw/i386/multiboot_header.h | 254

Re: [Qemu-devel] [PATCH v1 06/21] RISC-V FPU Support

2018-01-29 Thread Jim Wilson
On Wed, Jan 24, 2018 at 3:47 PM, Richard Henderson wrote: > On 01/24/2018 10:58 AM, Jim Wilson wrote: >> Although, looking at this again, I see another statement in a >> different place that says: >> >> Except when otherwise stated, if the result of a floating-point operation is >> NaN, it is the

Re: [Qemu-devel] [RFC v3 05/14] blockjobs: add block_job_dismiss

2018-01-29 Thread John Snow
On 01/29/2018 12:38 PM, Kevin Wolf wrote: > Am 27.01.2018 um 03:05 hat John Snow geschrieben: >> For jobs that have reached their terminal state, prior to having their >> last reference put down (meaning jobs that have completed successfully, >> unsuccessfully, or have been canceled), allow the u

Re: [Qemu-devel] [PATCH v7 9/9] iotest 134: test cluster-misaligned encrypted write

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > COW (even empty/zero) areas require encryption too > > Signed-off-by: Anton Nefedov > Reviewed-by: Eric Blake > --- > tests/qemu-iotests/134 | 9 + > tests/qemu-iotests/134.out | 10 ++ > 2 files changed, 19 insertions(+) Reviewe

Re: [Qemu-devel] [PATCH v7 8/9] qcow2: skip writing zero buffers to empty COW areas

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > If COW areas of the newly allocated clusters are zeroes on the backing image, > efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole > cluster instead of writing explicit zero buffers later in perform_cow(). > > iotest 060: > wri

[Qemu-devel] [PATCH] vfio/pci: Add option to disable GeForce quirks

2018-01-29 Thread Alex Williamson
These quirks are necessary for GeForce, but not for Quadro/GRID/Tesla assignment. Leaving them enabled is fully functional and provides the most compatibility, but due to the unique NVIDIA MSI ACK behavior[1], it also introduces latency in re-triggering the MSI interrupt. This overhead is typical

Re: [Qemu-devel] [RFC 0/4] Allow custom socket option in socket_listen and socket_connect

2018-01-29 Thread no-reply
Hi, This series failed docker-quick@centos6 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 1517253224-14361-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC 0

Re: [Qemu-devel] [PATCH v7 00/20] add byte-based block_status driver callbacks

2018-01-29 Thread Eric Blake
ping On 01/05/2018 04:57 PM, Eric Blake wrote: > There are patches floating around to add NBD_CMD_BLOCK_STATUS, > but NBD wants to report status on byte granularity (even if the > reporting will probably be naturally aligned to sectors or even > much higher levels). I've therefore started the tas

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-01-29 Thread Kevin Wolf
Am 29.01.2018 um 19:21 hat Anatol Pomozov geschrieben: > Hi > > On Mon, Jan 15, 2018 at 6:49 AM, Kevin Wolf wrote: > > Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben: > >> Using C structs makes the code more readable and prevents type conversion > >> errors. > >> > >> Borrow multiboot1 hea

Re: [Qemu-devel] [PATCH v7 7/9] qcow2: move is_zero() up

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > To be used in the following commit without a forward declaration. > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia > --- > block/qcow2.c | 35 +-- > 1 file changed, 17 insertions(+), 18 deletions(-) Revie

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

2018-01-29 Thread Justin Terry (VM) via Qemu-devel
Hi All, Is there any additional feedback I can address here to help out the process? Please let me know. Thanks again, Justin > -Original Message- > From: Justin Terry (VM) > Sent: Monday, January 22, 2018 1:08 PM > To: qemu-devel@nongnu.org > Cc: pbonz...@redhat.com; crosthwaite.pe...@

Re: [Qemu-devel] [PATCH v7 6/9] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > Support the flag if the underlying BDS supports it > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia > --- > block/blkdebug.c | 3 ++- > block/blkverify.c | 2 +- > block/mirror.c | 2 +- > block/raw-format.c | 3 ++- > 4 files cha

Re: [Qemu-devel] [RFC v3 03/14] blockjobs: add state transition table

2018-01-29 Thread Kevin Wolf
Am 29.01.2018 um 20:07 hat John Snow geschrieben: > > > On 01/29/2018 12:17 PM, Kevin Wolf wrote: > > Am 27.01.2018 um 03:05 hat John Snow geschrieben: > >> The state transition table has mostly been implied. We're about to make > >> it a bit more complex, so let's make the STM explicit instead.

Re: [Qemu-devel] [PATCH v7 5/9] file-posix: support BDRV_REQ_ALLOCATE

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > Current write_zeroes implementation is good enough to satisfy this flag too > > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia > --- > block/file-posix.c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Max Reitz signature

Re: [Qemu-devel] [PATCH v7 4/9] block: treat BDRV_REQ_ALLOCATE as serialising

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > The idea is that ALLOCATE requests may overlap with other requests. > Reuse the existing block layer infrastructure for serialising requests. > Use the following approach: > - mark ALLOCATE serialising, so subsequent requests to the area wait > - ALLO

Re: [Qemu-devel] [PATCH v7 3/9] block: introduce BDRV_REQ_ALLOCATE flag

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > The flag is supposed to indicate that the region of the disk image has > to be sufficiently allocated so it reads as zeroes. > > The call with the flag set must return -ENOTSUP if allocation cannot > be done efficiently. > This has to be made sure of by

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

2018-01-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129033133.31288-1-f...@redhat.com Subject: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --o

Re: [Qemu-devel] [PATCH v7 1/9] mirror: inherit supported write/zero flags

2018-01-29 Thread Eric Blake
On 01/29/2018 01:21 PM, Max Reitz wrote: > On 2018-01-18 18:48, Anton Nefedov wrote: >> Signed-off-by: Anton Nefedov >> Reviewed-by: Eric Blake >> Reviewed-by: Alberto Garcia >> --- >> block/mirror.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/block/mirror.c b/block/mirror.

Re: [Qemu-devel] [PATCH v7 2/9] blkverify: set supported write/zero flags

2018-01-29 Thread Max Reitz
On 2018-01-18 18:49, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > Reviewed-by: Alberto Garcia > --- > block/blkverify.c | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v4 1/5] tpm: fix alignment issues

2018-01-29 Thread Stefan Berger
On 01/29/2018 01:33 PM, Marc-André Lureau wrote: The new tpm-crb-test fails on sparc host: TEST: tests/tpm-crb-test... (pid=230409) /i386/tpm-crb/test: Broken pipe FAIL GTester: last random seed: R02S29cea50247fe1efa59ee885a26d51a85 (pid=230423) FAIL: tests/tpm-crb-test and generates a new c

Re: [Qemu-devel] [PATCH v7 1/9] mirror: inherit supported write/zero flags

2018-01-29 Thread Max Reitz
On 2018-01-18 18:48, Anton Nefedov wrote: > Signed-off-by: Anton Nefedov > Reviewed-by: Eric Blake > Reviewed-by: Alberto Garcia > --- > block/mirror.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/block/mirror.c b/block/mirror.c > index c9badc1..d18ec65 100644 > --- a/block/mi

Re: [Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

2018-01-29 Thread Anatol Pomozov
Hi On Mon, Jan 15, 2018 at 7:41 AM, Kevin Wolf wrote: > Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben: >> Multiboot may load section headers and all sections (even those that are >> not part of any segment) to target memory. >> >> Tested with an ELF application that uses data from strings

[Qemu-devel] [RFC 2/4] qemu-socket: Allow custom socket options in socket_connect

2018-01-29 Thread Zihan Yang
Currently, socket_connect doesn't allow custom socket options, which is inconvenient when the caller wants a different kind of socket from that the socket_connect provides. This patch allows custom config in socket_connect by providing an extra parameter. Existing functions can just pass a NULL poi

[Qemu-devel] [RFC 3/4] net/socket: change net_socket_listen_init to use functions in include/qemu/sockets.h

2018-01-29 Thread Zihan Yang
Some functions in net/socket.c still uses bind/connect/listen directly. Change it to use functions in include/qemu/sockets.h Signed-off-by: Zihan Yang --- net/socket.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/net/socket.c b/n

[Qemu-devel] [RFC 1/4] qemu-socket: Allow custom socket option in socket_listen

2018-01-29 Thread Zihan Yang
Currently, socket_listen does not allow caller to set custom socket options, which is inconvenient when the caller wants a non-blocking socket or wants to set TCP_NODELAY. Therefore, two new structs are added and an extra parameter is provided to socket_listen. Existing functions are unaffected by

[Qemu-devel] [RFC 0/4] Allow custom socket option in socket_listen and socket_connect

2018-01-29 Thread Zihan Yang
socket_listen and socket_connect do not allow custom socket option. This would be inconvenient if the caller wants a non-blocking socket, or wants to set TCP_NODELAY or other options. This series of patches add specific config structures, QemuSocketConfig, which contains QemuSocketOption. All the

[Qemu-devel] [RFC 4/4] net/socket: change net_socket_connect_init to use functions in sockets.h

2018-01-29 Thread Zihan Yang
net_socket_connect_init still uses parse_host_port() and connect() directly. Convert it into functions in include/qemu/sockets.h Signed-off-by: Zihan Yang --- net/socket.c | 52 +++- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/n

Re: [Qemu-devel] [PATCH v3 00/22] re-factor softfloat and add fp16 functions

2018-01-29 Thread Richard Henderson
On 01/28/2018 12:41 PM, Emilio G. Cota wrote: > On Thu, Jan 25, 2018 at 12:59:56 +, Alex Bennée wrote: >> Howard Spoelstra writes: > (snip) >>> Recent tcg optimisations had improved processor and floating point >>> performance considerably, but that gain seems to be more than lost for >>> the

Re: [Qemu-devel] [RFC v3 03/14] blockjobs: add state transition table

2018-01-29 Thread John Snow
On 01/29/2018 12:17 PM, Kevin Wolf wrote: > Am 27.01.2018 um 03:05 hat John Snow geschrieben: >> The state transition table has mostly been implied. We're about to make >> it a bit more complex, so let's make the STM explicit instead. >> >> Perform state transitions with a function that for now j

Re: [Qemu-devel] [PULL 00/13] Migration PULL request

2018-01-29 Thread Peter Maydell
> are available in the Git repository at: > > git://github.com/juanquintela/qemu.git tags/migration/20180129 > > for you to fetch changes up to 4b6bb0a77761b8a906a540e927c7a9dde99bc10f: > > tests: Adjust sleeps for migration test (2018-01-29 12:10:22 +0100) > > ---

Re: [Qemu-devel] [PATCH v2] block: maintain persistent disabled bitmaps

2018-01-29 Thread Max Reitz
On 2018-01-22 11:41, Vladimir Sementsov-Ogievskiy wrote: > To maintain load/store disabled bitmap there is new approach: > > - deprecate @autoload flag of block-dirty-bitmap-add, make it ignored > - store enabled bitmaps as "auto" to qcow2 > - store disabled bitmaps without "auto" flag to qcow2

[Qemu-devel] [PATCH v4 3/5] tpm: replace GThreadPool with AIO threadpool

2018-01-29 Thread Marc-André Lureau
The TPM backend uses a GThreadPool to handle IO in a seperate thread. However, GThreadPool isn't integrated with Qemu main loops, making it unnecessarily complicated to deal with. Qemu has a AIO threadpool, that is better integrated with loops and various IO functions, provides completion BH by de

[Qemu-devel] [PATCH v4 2/5] tpm: lookup cancel path under tpm device class

2018-01-29 Thread Marc-André Lureau
Since Linux commit 313d21eeab9282e, tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau --- hw/tpm/tpm_passthrough.c | 34 ++ 1 file changed, 22 ins

Re: [Qemu-devel] [PATCH 2/4] multiboot: load any machine type of ELF

2018-01-29 Thread Anatol Pomozov
Hi On Mon, Jan 15, 2018 at 6:52 AM, Kevin Wolf wrote: > Am 16.10.2017 um 20:38 hat Anatol Pomozov geschrieben: >> Hi >> >> On Mon, Oct 16, 2017 at 1:27 AM, Kevin Wolf wrote: >> > Am 14.10.2017 um 15:41 hat Peter Maydell geschrieben: >> >> On 14 October 2017 at 00:21, Eduardo Habkost wrote: >> >

[Qemu-devel] [PATCH v4 1/5] tpm: fix alignment issues

2018-01-29 Thread Marc-André Lureau
The new tpm-crb-test fails on sparc host: TEST: tests/tpm-crb-test... (pid=230409) /i386/tpm-crb/test: Broken pipe FAIL GTester: last random seed: R02S29cea50247fe1efa59ee885a26d51a85 (pid=230423) FAIL: tests/tpm-crb-test and generates a new clang sanitizer runtime warning: /home/petmay01/lina

Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD)

2018-01-29 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180129174132.108925-1-brijesh.si...@amd.com Subject: [Qemu-devel] [PATCH v6 00/23] x86:

[Qemu-devel] [PATCH v4 4/5] tpm: report backend request error

2018-01-29 Thread Marc-André Lureau
Use an Error** for request to let the caller handle error reporting. This will also allow to inform the frontend of a backend error. Signed-off-by: Marc-André Lureau --- include/sysemu/tpm.h | 2 +- include/sysemu/tpm_backend.h | 3 ++- backends/tpm.c | 9 +++-- hw/

[Qemu-devel] [PATCH v4 5/5] tpm: add CRB device

2018-01-29 Thread Marc-André Lureau
tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and CRB model at run time, but given that CRB is a simpl

Re: [Qemu-devel] [RFC PATCH 00/10] x-blockdev-create for qcow2

2018-01-29 Thread Max Reitz
On 2018-01-11 20:52, Kevin Wolf wrote: > This series implements a minimal QMP command that allows to create an > image format on a given block node. The interface is still going to > change to some kind of an async command (possibly a block job), so I > prefixed x- for now. > > At this point, I'm

[Qemu-devel] [PATCH v4 0/5] tpm: CRB device and cleanups

2018-01-29 Thread Marc-André Lureau
This series fixes alignment issues, cleans up a bit the TPM IO thread handling, allows to report backend error to hw/frontend, and implements the CRB device. It is a resend of '[PATCH v2 0/5] tpm: CRB device and cleanups', '[PATCH v3] tpm: add CRB device', and '[PATCH] tpm: fix alignment issues' c

Re: [Qemu-devel] [PATCH v3 5/5] target/arm: Add SVE state to TB->FLAGS

2018-01-29 Thread Richard Henderson
On 01/29/2018 10:01 AM, Peter Maydell wrote: > On 23 January 2018 at 03:53, Richard Henderson > wrote: >> Add both SVE exception state and vector length. >> >> Signed-off-by: Richard Henderson > >> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c >> index 10eef870fe..4c1eca70

Re: [Qemu-devel] [RFC PATCH 05/10] qcow2: Use BlockdevRef in qcow2_create2()

2018-01-29 Thread Kevin Wolf
Am 29.01.2018 um 18:30 hat Max Reitz geschrieben: > On 2018-01-11 20:52, Kevin Wolf wrote: > > Instead of passing a separate BlockDriverState* into qcow2_create2(), > > make use of the BlockdevRef that is included in BlockdevCreateOptions. > > > > Signed-off-by: Kevin Wolf > > --- > > include/bl

Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD)

2018-01-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129174132.108925-1-brijesh.si...@amd.com Subject: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD) === TEST SCRIPT BEGIN === #!/bin/bash BASE=b

Re: [Qemu-devel] [RFC PATCH 04/10] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-01-29 Thread Kevin Wolf
Am 29.01.2018 um 18:12 hat Max Reitz geschrieben: > On 2018-01-11 20:52, Kevin Wolf wrote: > > All of the simple options are now passed to qcow2_create2() in a > > BlockdevCreateOptions object. Still missing: node-name and the > > encryption options. > > > > Signed-off-by: Kevin Wolf > > --- > >

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-29 Thread Max Reitz
On 2018-01-29 19:06, Kevin Wolf wrote: > Am 29.01.2018 um 17:57 hat Max Reitz geschrieben: >> On 2018-01-11 20:52, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> qapi/block-core.json | 33 - >>> 1 file changed, 32 insertions(+), 1 deletion(-) >>> >>> d

Re: [Qemu-devel] SDL2 UI behavior of switching views

2018-01-29 Thread BALATON Zoltan
On Mon, 29 Jan 2018, Gerd Hoffmann wrote: On Sun, Jan 28, 2018 at 06:43:44PM +0300, Anatoly Trosinenko wrote: When QEMU is run with GTK UI, it changes what is drawn on its single window when I press Ctrl-Alt-{1,2,3,4}. But when I use SDL2 UI, it opens multiple windows: a separate window per each

Re: [Qemu-devel] [PATCH v3 5/5] target/arm: Add SVE state to TB->FLAGS

2018-01-29 Thread Peter Maydell
On 23 January 2018 at 03:53, Richard Henderson wrote: > Add both SVE exception state and vector length. > > Signed-off-by: Richard Henderson > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 10eef870fe..4c1eca7062 100644 > --- a/target/arm/translate-a64.c > +++ b/tar

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2018-01-29 Thread Anatol Pomozov
Hi On Mon, Jan 15, 2018 at 6:49 AM, Kevin Wolf wrote: > Am 13.10.2017 um 01:54 hat Anatol Pomozov geschrieben: >> Using C structs makes the code more readable and prevents type conversion >> errors. >> >> Borrow multiboot1 header from GRUB project. >> >> Signed-off-by: Anatol Pomozov >> --- >>

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

2018-01-29 Thread Stefan Berger
On 01/29/2018 12:51 PM, Marc-Andre Lureau wrote: Hi On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger wrote: On 01/29/2018 07:32 AM, Marc-André Lureau wrote: The new tpm-crb-test fails on sparc host: TEST: tests/tpm-crb-test... (pid=230409) /i386/tpm-crb/test: Broken pipe FAIL GTester: last

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

2018-01-29 Thread Stefan Berger
On 01/29/2018 01:02 PM, Marc-Andre Lureau wrote: Hi On Mon, Jan 29, 2018 at 6:57 PM, Stefan Berger wrote: On 01/29/2018 12:51 PM, Marc-Andre Lureau wrote: Hi On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger wrote: On 01/29/2018 07:32 AM, Marc-André Lureau wrote: The new tpm-crb-test fails o

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-29 Thread Gerd Hoffmann
Hi, > > In order to use this feature, we need to create a gles context. > > This series add an option (`-display sdl,gles=on`) in the SDL display to > > create that context. > > Humble ping. > I didn't get any comment on this series. Well, display configuration is going to be rewritten, and w

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

2018-01-29 Thread Marc-Andre Lureau
Hi On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger wrote: > On 01/29/2018 07:32 AM, Marc-André Lureau wrote: >> >> The new tpm-crb-test fails on sparc host: >> >> TEST: tests/tpm-crb-test... (pid=230409) >>/i386/tpm-crb/test: >> Broken pipe >> FAIL >> GTester: last random seed: R02S29cea50247f

Re: [Qemu-devel] [RFC PATCH 04/10] qcow2: Pass BlockdevCreateOptions to qcow2_create2()

2018-01-29 Thread Max Reitz
On 2018-01-29 19:10, Kevin Wolf wrote: > Am 29.01.2018 um 18:12 hat Max Reitz geschrieben: >> On 2018-01-11 20:52, Kevin Wolf wrote: >>> All of the simple options are now passed to qcow2_create2() in a >>> BlockdevCreateOptions object. Still missing: node-name and the >>> encryption options. >>> >>

Re: [Qemu-devel] [PATCH v3 4/5] target/arm: Add ZCR_ELx

2018-01-29 Thread Peter Maydell
On 23 January 2018 at 03:53, Richard Henderson wrote: > Define ZCR_EL[1-3]. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 5 ++ > target/arm/helper.c | 131 > > 2 files changed, 136 insertions(+) > Apart from the issue

Re: [Qemu-devel] [PATCH] tpm: fix alignment issues

2018-01-29 Thread Marc-Andre Lureau
Hi On Mon, Jan 29, 2018 at 6:57 PM, Stefan Berger wrote: > On 01/29/2018 12:51 PM, Marc-Andre Lureau wrote: >> >> Hi >> >> On Mon, Jan 29, 2018 at 6:41 PM, Stefan Berger >> wrote: >>> >>> On 01/29/2018 07:32 AM, Marc-André Lureau wrote: The new tpm-crb-test fails on sparc host: >>

Re: [Qemu-devel] [PATCH v3 0/5] coroutine-lock: polymorphic CoQueue

2018-01-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180125175949.7780-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/5] coroutine-lock: polymorphic CoQueue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

[Qemu-devel] [PATCH v6 15/23] sev: add command to encrypt guest memory region

2018-01-29 Thread Brijesh Singh
The KVM_SEV_LAUNCH_UPDATE_DATA command is used to encrypt a guest memory region using the VM Encryption Key created using LAUNCH_START. Signed-off-by: Brijesh Singh --- accel/kvm/kvm-all.c| 2 ++ accel/kvm/sev.c| 49 + accel/kvm/trace-

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

2018-01-29 Thread Kevin Wolf
Am 29.01.2018 um 17:57 hat Max Reitz geschrieben: > On 2018-01-11 20:52, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > qapi/block-core.json | 33 - > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-core.json b/qapi/b

Re: [Qemu-devel] [RFC v3 01/14] blockjobs: add manual property

2018-01-29 Thread John Snow
On 01/29/2018 12:46 PM, Kevin Wolf wrote: > Am 29.01.2018 um 18:34 hat John Snow geschrieben: >> On 01/29/2018 11:59 AM, Kevin Wolf wrote: >>> Am 27.01.2018 um 03:05 hat John Snow geschrieben: This property will be used to opt-in to the new BlockJobs workflow that allows a tighter, more

  1   2   3   4   >