Re: [Qemu-devel] [PATCH] Add ability for user to specify mouse ungrab key

2017-12-11 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20171210195931.26042-1-programmingk...@gmail.com Subject: [Qemu-devel] [PATCH] Add ability for user to specify mou

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-12-11 Thread Shannon Zhao
On 2017/12/12 14:54, Yang Zhong wrote: >> 2) what effect it has on boot time in Shannon's case. > Hello Shannon, > > It's hard for me to reproduce your commands in my x86 enviornment, as a > compare test, > would you please help me use above two TEMP patches to verify VM bootup > time ag

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-11 Thread Alexey Kardashevskiy
On 12/12/17 17:06, Alexey Kardashevskiy wrote: > On 12/12/17 16:54, Alex Williamson wrote: >> On Tue, 12 Dec 2017 16:21:31 +1100 >> Alexey Kardashevskiy wrote: >> >>> This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability >>> which tells that a region with MSIX data can be mapped en

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-12-11 Thread Yang Zhong
On Mon, Dec 11, 2017 at 05:31:43PM +0100, Paolo Bonzini wrote: > On 07/12/2017 16:06, Yang Zhong wrote: > > Which show trim cost time less than 1ms and call_rcu_thread() do 10 times > > batch free, the trim also 10 times. > > > > I also did below changes: > > delta=1000, and > > next

[Qemu-devel] [PATCH] MAINTAINERS: replace the unavailable email address

2017-12-11 Thread Shannon Zhao
From: Zhaoshenglong Since I'm not working as an assignee in Linaro, replace the Linaro email address with my personal one. Signed-off-by: Zhaoshenglong --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0255113..45e2e20 100644 --

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-11 Thread Alexey Kardashevskiy
On 12/12/17 16:54, Alex Williamson wrote: > On Tue, 12 Dec 2017 16:21:31 +1100 > Alexey Kardashevskiy wrote: > >> This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability >> which tells that a region with MSIX data can be mapped entirely, i.e. >> the VFIO PCI driver won't prevent MSI

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

2017-12-11 Thread Juan Melgarejo Ludeña
A year has passed since last update by Nathan Shearer, but status is labeled 'incomplete'. Please check if it's solved with wine 3.0 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/902413 Title: qemu

Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board

2017-12-11 Thread Shannon Zhao
On 2017/12/8 23:02, Peter Maydell wrote: > Currently we only provide one non-secure UART on the virt > board. This is OK for most purposes, but there are some > use cases where having a second UART would be useful (like > bare-metal testing where you don't really want to have to > probe and set u

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-11 Thread Alex Williamson
On Tue, 12 Dec 2017 16:21:31 +1100 Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > This adds a

Re: [Qemu-devel] [PATCH 3/3] hw/arm/virt-acpi-build: Add second UART to ACPI tables

2017-12-11 Thread Shannon Zhao
On 2017/12/8 23:02, Peter Maydell wrote: > Add the second UART to the ACPI tables. > > Signed-off-by: Peter Maydell > --- > Pure guesswork, as I don't have a UEFI setup to hand and > am not familiar with ACPI table formats either... > --- > hw/arm/virt-acpi-build.c | 5 + > 1 file changed,

Re: [Qemu-devel] [PATCH] sparc: Make sure we mmap at SHMLBA alignment

2017-12-11 Thread Richard Henderson
On 12/08/2017 08:57 AM, Peter Maydell wrote: > SPARC Linux has an oddity that it insists that mmap() > of MAP_FIXED memory must be at an alignment defined by > SHMLBA, which is more aligned than the page size > (typically, SHMLBA alignment is to 16K, and pages are 8K). > This is a relic of ancient

Re: [Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-12-11 Thread Alex Williamson
On Tue, 12 Dec 2017 16:18:53 +1100 Alexey Kardashevskiy wrote: > In order to enable TCE operations support in KVM, we have to inform > the KVM about VFIO groups being attached to specific LIOBNs. The KVM > already knows about VFIO groups, the only bit missing is which > in-kernel TCE table (the o

Re: [Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-11 Thread Alexey Kardashevskiy
On 12/12/17 16:21, Alexey Kardashevskiy wrote: > This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability > which tells that a region with MSIX data can be mapped entirely, i.e. > the VFIO PCI driver won't prevent MSIX vectors area from being mapped. > > This adds a "msix-no-mmap" pro

[Qemu-devel] [PATCH V4] pci: removed the is_express field since a uniform interface was inserted

2017-12-11 Thread Yoni Bettan
* according to Eduardo Habkost's commit fd3b02c8896d597dd8b9e053dec579cf0386aee1 * since all PCIEs now implement INTERFACE_PCIE_DEVICE we don't need this field anymore * Devices that where only INTERFACE_PCIE_DEVICE (is_express == 1) or

[Qemu-devel] [PATCH qemu] RFC: vfio-pci: Allow mmap of MSIX BAR

2017-12-11 Thread Alexey Kardashevskiy
This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability which tells that a region with MSIX data can be mapped entirely, i.e. the VFIO PCI driver won't prevent MSIX vectors area from being mapped. This adds a "msix-no-mmap" property to the vfio-pci device, it is "true" by default and

[Qemu-devel] [PATCH qemu] RFC: spapr/iommu: Enable in-kernel TCE acceleration via VFIO KVM device

2017-12-11 Thread Alexey Kardashevskiy
In order to enable TCE operations support in KVM, we have to inform the KVM about VFIO groups being attached to specific LIOBNs. The KVM already knows about VFIO groups, the only bit missing is which in-kernel TCE table (the one with user visible TCEs) should update the attached broups. There is an

[Qemu-devel] [PATCH qemu v2] vfio-pci: Remove unused fields from VFIOMSIXInfo

2017-12-11 Thread Alexey Kardashevskiy
When support for multiple mappings per a region were added, this was left behind, let's finish and remove unused bits. Fixes: db0da029a185 "vfio: Generalize region support" Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * updated commit log --- hw/vfio/pci.h | 2 -- 1 file changed, 2 dele

[Qemu-devel] [PATCH qemu v2] vfio/spapr: Allow fallback to SPAPR TCE IOMMU v1

2017-12-11 Thread Alexey Kardashevskiy
The vfio_iommu_spapr_tce driver advertises kernel's support for v1 and v2 IOMMU support, however it is not always possible to use the requested IOMMU type. For example, a pseries host platform does not support dynamic DMA windows so v2 cannot initialize and QEMU fails to start. This adds a fallbac

Re: [Qemu-devel] [PATCH] display: check irq handler index before access

2017-12-11 Thread P J P
+-- On Mon, 11 Dec 2017, Peter Maydell wrote --+ | It would be more sensible to just mask off the top bits of | 'level' before starting the loop, rather than checking every | time around the loop: |level &= MAKE_64BIT_MASK(0, TC6493XB_GPIOS); Sent a revised patch v1. Thank you. -- Prasad J Pan

[Qemu-devel] [PATCH v1] display: limit irq handler index to TC6393XB_GPIOS

2017-12-11 Thread P J P
From: Prasad J Pandit The ctz32() routine could return value greater than TC6393XB_GPIOS=16. This could lead to an OOB array access. Mask 'level' to avoid it. Reported-by: Moguofang Signed-off-by: Prasad J Pandit --- hw/display/tc6393xb.c | 1 + 1 file changed, 1 insertion(+) Update: mask 'l

[Qemu-devel] [PATCH v2] target/i386: add clflushopt to "Skylake-Server" cpu model

2017-12-11 Thread Haozhong Zhang
CPUID_7_0_EBX_CLFLUSHOPT is missed in current "Skylake-Server" cpu model. Add it to "Skylake-Server" cpu model on pc-i440fx-2.11 and pc-q35-2.11. Keep it disabled in "Skylake-Server" cpu model on older machine types. Signed-off-by: Haozhong Zhang --- v1 can be found at https://lists.nongnu.org

Re: [Qemu-devel] [PATCH] x86/cpu: Enable new SSE/AVX/AVX512 cpu features

2017-12-11 Thread Yang Zhong
On Mon, Dec 11, 2017 at 05:17:15PM +0100, Paolo Bonzini wrote: > On 22/11/2017 08:27, Yang Zhong wrote: > > Intel IceLake cpu has added new cpu features,AVX512_VBMI2/GFNI/ > > VAES/VPCLMULQDQ/AVX512_VNNI/AVX512_BITALG. Those new cpu features > > need expose to guest VM. > > > > The bit definition:

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Xu
On Mon, Dec 11, 2017 at 08:55:56PM +, Peter Maydell wrote: > On 11 December 2017 at 19:42, Emilio G. Cota wrote: > > On Mon, Dec 11, 2017 at 17:32:48 +, Peter Maydell wrote: > >> Thanks. I think I have come down on the side of putting this into > >> 2.11, so rolling an rc5 today, and delay

[Qemu-devel] [PATCH v1 1/2] i386: Add Intel Processor Trace feature support

2017-12-11 Thread Luwei Kang
From: Chao Peng Expose Intel Processor Trace feature to guest. Signed-off-by: Chao Peng Signed-off-by: Luwei Kang --- target/i386/cpu.c | 19 ++- target/i386/cpu.h | 1 + target/i386/kvm.c | 23 +++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --

[Qemu-devel] [PATCH v1 2/2] i386: Add support to get/set/migrate Intel Processor Trace feature

2017-12-11 Thread Luwei Kang
From: Chao Peng Add Intel Processor Trace related definition. It also add corresponding part to kvm_get/set_msr and vmstate. Signed-off-by: Chao Peng Signed-off-by: Luwei Kang --- target/i386/cpu.h | 22 ++ target/i386/kvm.c | 51 +++

Re: [Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-12-11 Thread Chao Gao
On Mon, Dec 11, 2017 at 06:07:48PM +, Anthony PERARD wrote: >On Fri, Nov 17, 2017 at 02:24:25PM +0800, Chao Gao wrote: >> According to VT-d spec Interrupt Remapping and Interrupt Posting -> >> Interrupt Remapping -> Interrupt Request Formats On Intel 64 >> Platforms, fields of MSI data register

Re: [Qemu-devel] [PATCH v6 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application

2017-12-11 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, December 11, 2017 10:33 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re:

Re: [Qemu-devel] [PATCH v13 00/12] Add ARMv8 RAS virtualization support in QEMU

2017-12-11 Thread gengdongjiu
On 2017/12/11 21:32, Igor Mammedov wrote: >> Hi maintainer, >> >> This patch set seems pending about one month, could you help review for >> them? Thanks. > I'm going to look at ACPI side of it this week. Igor, thank you very much in advance. > >

Re: [Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-12-11 Thread Chao Gao
On Mon, Dec 11, 2017 at 05:59:08PM +, Anthony PERARD wrote: >On Fri, Nov 17, 2017 at 02:24:24PM +0800, Chao Gao wrote: >> Previously, some fields (reserved or unalterable) are filtered by >> Qemu. This fields are useless for the legacy interrupt format. >> However, these fields are may meaningf

Re: [Qemu-devel] [PATCH v6 3/4] contrib/libvhost-user: enable virtio config space messages

2017-12-11 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, December 11, 2017 10:00 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re:

Re: [Qemu-devel] [PATCH v6 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-12-11 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Monday, December 11, 2017 9:39 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; m...@redhat.com; > marcandre.lur...@redhat.com; fel...@nutanix.com; Harris, James R > > Subject: Re:

[Qemu-devel] [PATCH v4] qemu-img: Document --force-share / -U

2017-12-11 Thread Fam Zheng
Signed-off-by: Fam Zheng --- v4: "images". [Kevin] v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi

Re: [Qemu-devel] [PATCH] blockjob: kick jobs on set-speed

2017-12-11 Thread Jeff Cody
On Mon, Dec 11, 2017 at 06:46:09PM -0500, John Snow wrote: > If users set an unreasonably low speed (like one byte per second), the > calculated delay may exceed many hours. While we like to punish users > for asking for stupid things, we do also like to allow users to correct > their wicked ways.

Re: [Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 20:46, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Iterate through an address space calling a function for each > section. The iteration is done in order. > > Signed-off-by: Dr. David Alan Gilbert It seems to me that you can achieve the same effect b

[Qemu-devel] [PATCH] blockjob: kick jobs on set-speed

2017-12-11 Thread John Snow
If users set an unreasonably low speed (like one byte per second), the calculated delay may exceed many hours. While we like to punish users for asking for stupid things, we do also like to allow users to correct their wicked ways. When a user provides a new speed, kick the job to allow it to reca

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH v2 0/3] tests for CCW IDA

2017-12-11 Thread Halil Pasic
On 12/07/2017 12:53 PM, Cornelia Huck wrote: > On Thu, 7 Dec 2017 10:01:35 +0100 > Thomas Huth wrote: > >> On 07.12.2017 07:38, Thomas Huth wrote: >>> On 08.11.2017 17:54, Halil Pasic wrote: I've keept the title althogh the scope shifted a bit: it's more about introducing ccw-testde

[Qemu-devel] [PATCH v2 5/5] s390-ccw: interactive boot menu for scsi

2017-12-11 Thread Collin L. Walling
Interactive boot menu for scsi. This follows the same procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Please choose: Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 9

[Qemu-devel] [PATCH v2 2/5] s390-ccw: ipl structs for eckd cdl/ldl

2017-12-11 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Also introduce structs for IPL stages 1 and 1b and for disk geometry. Signed-o

[Qemu-devel] [PATCH v2 4/5] s390-ccw: interactive boot menu for eckd dasd

2017-12-11 Thread Collin L. Walling
When the boot menu options are present and the guest's disk has been configured by the zipl tool, then the user will be presented with an interactive boot menu with labeled entries. An example of what the menu might look like: zIPL v1.37.1-build-20170714 interactive boot menu. 0. default

[Qemu-devel] [PATCH v2 1/5] s390-ccw: update libc

2017-12-11 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit atoi Added non-C standard function: itostr Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch Frank

[Qemu-devel] [PATCH v2 3/5] s390-ccw: parse and set boot menu options

2017-12-11 Thread Collin L. Walling
Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml: Where X represents some positive integer representing milliseconds. A loadparm other

[Qemu-devel] [PATCH v2 0/5] Interactive Boot Menu for DASD and SCSI Guests on s390x

2017-12-11 Thread Collin L. Walling
Thanks for your patience. I've been bouncing back-and-forth between different designs. Lots-o-changes this version. Please call me out if I missed anything from the previous round of review. --- [v2] --- libc - fixed up atoi and itostr and moved them to the new lib.c file - documenta

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Emilio G. Cota
On Fri, Dec 08, 2017 at 11:55:48 +0100, Paolo Bonzini wrote: > So I'm a bit underwhelmed by this experiment. Other opinions? I am on the same boat. Most use cases in this patchset are arguably adding more complexity because they substitute already very simple code (e.g. "lock; do_something; unloc

Re: [Qemu-devel] [PATCH for-2.12 2/2] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2017-12-11 Thread Peter Maydell
On 7 December 2017 at 18:02, Thomas Huth wrote: > These options likely do not work as expected as soon as the user > tries to use more than one network interface at once. The parameters > have been marked as deprecated since QEMU v2.6, so users had plenty > of time to move their scripts to the new

Re: [Qemu-devel] [PATCH 5/5] thread-pool: convert to use lock guards

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 11:23, Stefan Hajnoczi wrote: >> >> In other words, I don't see what 'QEMU_WITH_LOCK_GUARD() {}' buys us >> over '{ QEMU_LOCK_GUARD() }'. > The QEMU_WITH_LOCK_GUARD() {} syntax is nice because it's similar to > if/while/for statements. > > However, { QEMU_LOCK_GUARD() } doesn't hide

Re: [Qemu-devel] [PATCH for-2.12 2/2] net: Remove the deprecated -tftp, -bootp, -redir and -smb options

2017-12-11 Thread Samuel Thibault
Thomas Huth, on jeu. 07 déc. 2017 19:02:35 +0100, wrote: > These options likely do not work as expected as soon as the user > tries to use more than one network interface at once. The parameters > have been marked as deprecated since QEMU v2.6, so users had plenty > of time to move their scripts to

Re: [Qemu-devel] [PATCH for-2.12 1/2] net: Remove the legacy "-net channel" parameter

2017-12-11 Thread Samuel Thibault
Thomas Huth, on jeu. 07 déc. 2017 19:02:34 +0100, wrote: > It has never been documented, so hardly anybody knows about this > parameter, and it is marked as deprecated since QEMU v2.6. > Time to let it go now. > > Signed-off-by: Thomas Huth Reviewed-by: Samuel Thibault > --- > include/net/sli

Re: [Qemu-devel] [RFC PATCH 0/5] Scoped locks using attribute((cleanup))

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 15:11, Eric Blake wrote: > I don't know if there is a way to make gcc insert stack-unwind > directives that are honored across longjmp (I know C++ does it for > exceptions; so there may be a way, and I just don't know it). Probably -fexceptions. Paolo > Conversely, I do know that p

[Qemu-devel] [PATCH 08/13] imx_fec: Add support for multiple Tx DMA rings

2017-12-11 Thread Andrey Smirnov
More recent version of the IP block support more than one Tx DMA ring, so add the code implementing that feature. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andre

[Qemu-devel] [PATCH 11/13] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file

2017-12-11 Thread Andrey Smirnov
Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset 0x614, so to avoid getting aborts when accessing those on QEMU, extend the register file to cover FSL_IMX25_FEC_SIZE(16K) of address space instead of just 1K. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qe

[Qemu-devel] [PATCH 12/13] sdhci: Add i.MX specific subtype of SDHCI

2017-12-11 Thread Andrey Smirnov
IP block found on several generations of i.MX family does not use vanilla SDHCI implementation and it comes with a number of quirks. Introduce i.MX SDHCI subtype of SDHCI block to add code necessary to support unmodified Linux guest driver. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-

[Qemu-devel] [PATCH 09/13] imx_fec: Use correct length for packet size

2017-12-11 Thread Andrey Smirnov
Use 'frame_size' instead of 'len' when calling qemu_send_packet(), failing to do so results in malformed packets send in case when that packed is fragmented into multiple DMA transactions. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.

[Qemu-devel] [PATCH 10/13] imx_fec: Fix a typo in imx_enet_receive()

2017-12-11 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index

[Qemu-devel] [PATCH 13/13] sdhci: Implement write method of ACMD12ERRSTS register

2017-12-11 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/sd/sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c

[Qemu-devel] [PATCH 07/13] imx_fec: Emulate SHIFT16 in ENETx_RACC

2017-12-11 Thread Andrey Smirnov
Needed to support latest Linux kernel driver which relies on that functionality. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c

[Qemu-devel] [PATCH 06/13] imx_fec: Use MIN instead of explicit ternary operator

2017-12-11 Thread Andrey Smirnov
Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Andrey Smirnov --- hw/net/imx_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ne

[Qemu-devel] [PATCH 05/13] imx_fec: Use ENET_FTRL to determine truncation length

2017-12-11 Thread Andrey Smirnov
Frame truncation length, TRUNC_FL, is determined by the contents of ENET_FTRL register, so convert the code to use it instead of a hardcoded constant. To avoid the case where TRUNC_FL is greater that ENET_MAX_FRAME_SIZE, increase the value of the latter to its theoretical maximum of 16K. Cc: Pete

[Qemu-devel] [PATCH 03/13] imx_fec: Change queue flushing heuristics

2017-12-11 Thread Andrey Smirnov
In current implementation, packet queue flushing logic seem to suffer from a deadlock like scenario if a packet is received by the interface before before Rx ring is initialized by Guest's driver. Consider the following sequence of events: 1. A QEMU instance is started against a TAP device

[Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes

2017-12-11 Thread Andrey Smirnov
Hi everyone, This patchset is a spin-off from original i.MX7 support submission found here [1], containing all of the patchest that are more or less agreed upon and are ready (hopefully!) for inclusion. Changes since [1]: - Rx buffer in FEC was moved from stack to heap to allow

[Qemu-devel] [PATCH 02/13] imx_fec: Refactor imx_eth_enable_rx()

2017-12-11 Thread Andrey Smirnov
Refactor imx_eth_enable_rx() to have more meaningfull variable name than 'tmp' and to reduce number of logical negations done. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-devel@nongnu.org Cc: qemu-...@nongnu.org Cc: yurov...@gmail.com Reviewed-by: Peter Maydell Signed-

[Qemu-devel] [PATCH 01/13] imx_fec: Do not link to netdev

2017-12-11 Thread Andrey Smirnov
Binding to a particular netdev doesn't seem to belong to this layer and should probably be done as a part of board or SoC specific code. Convert all of the users of this IP block to use qdev_set_nic_properties() instead. Cc: Peter Maydell Cc: Jason Wang Cc: Philippe Mathieu-Daudé Cc: qemu-deve

Re: [Qemu-devel] [PATCH-2.12 v2 2/3] xilinx_spips: Set all of the reset values

2017-12-11 Thread francisco iglesias
On 11 December 2017 at 18:27, Alistair Francis wrote: > On Wed, Dec 6, 2017 at 3:39 PM, francisco iglesias > wrote: > > Hi Alistair, > > > > On 6 December 2017 at 23:22, Alistair Francis < > alistair.fran...@xilinx.com> > > wrote: > >> > >> Following the ZynqMP register spec let's ensure that al

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 19:42, Emilio G. Cota wrote: > On Mon, Dec 11, 2017 at 17:32:48 +, Peter Maydell wrote: >> Thanks. I think I have come down on the side of putting this into >> 2.11, so rolling an rc5 today, and delaying the final release >> a day to Wednesday. > > Glad to see it's in -r

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread David Hildenbrand
On 11.12.2017 18:17, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:29 +0100 > David Hildenbrand wrote: > >> This makes it clearer, which device is used for which accelerator. >> >> Signed-off-by: David Hildenbrand >> --- >> hw/intc/s390_flic.c | 9 +++-- >> hw/intc/s390_flic_kv

Re: [Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread David Hildenbrand
On 11.12.2017 19:01, Cornelia Huck wrote: > On Mon, 11 Dec 2017 14:47:34 +0100 > David Hildenbrand wrote: > >> Use s390_cpu_virt_mem_write() so we can actually revert what we did >> (re-inject the dequeued IO interrupt). >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/helper.h

[Qemu-devel] [PATCH v3 7/8] vhost: Remove old vhost_set_memory etc

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Remove the old update mechanism, vhost_set_memory, and the functions it uses and the memory_changed flags we no longer use. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 254 -- include/hw/virtio

[Qemu-devel] [PATCH v3 8/8] vhost: Move mem_sections maintenance into commit/update routines

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the maintenance of mem_sections into the vhost_update_mem routines, this removes the need for the vhost_region_add/del callbacks. Suggested-by: Igor Mammedov (and mostly written by Igor!) Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 58 +

[Qemu-devel] [PATCH v3 6/8] vhost: Compare and copy updated region data into device state

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Compare the temporary region data with the original, and if it's different update the original in the device state. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 2 ++ hw/virtio/vhost.c | 19 +-- 2 files changed, 19 inse

[Qemu-devel] [PATCH v3 4/8] vhost: New memory update functions

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" vhost_update_mem will replace the existing update mechanism. They make use of the Flatview we have now to make the update simpler. This commit just adds the basic structure. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/vhost.c | 51

[Qemu-devel] [PATCH v3 2/8] vhost: Move log_dirty check

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Move the log_dirty check into vhost_section. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/trace-events | 3 +++ hw/virtio/vhost.c | 20 +--- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/hw/virtio/trace-events b/hw/v

[Qemu-devel] [PATCH v3 5/8] vhost: update_mem_cb implementation

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add the meat of update_mem_cb; this is called for each region, to add a region to our temporary list. Our temporary list is in order we look to see if this region can be merged with the current head of list. Signed-off-by: Dr. David Alan Gilbert --- hw/virtio/tr

[Qemu-devel] [PATCH v3 3/8] vhost: Simplify ring verification checks

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" vhost_verify_ring_mappings() were used to verify that rings are still accessible and related memory hasn't been moved after flatview is updated. It was doing checks by mapping ring's GPA+len and checking that HVA hadn't changed with new memory map. To avoid maybe e

[Qemu-devel] [PATCH v3 0/8] Rework vhost memory region updates

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This patch set reworks the way the vhost code handles changes in physical address space layout that came from a discussion with Igor. Its intention is to simplify a lot of the update code, and to make it easier for the postcopy+shared code to do the hugepage

[Qemu-devel] [PATCH v3 1/8] memory: address_space_iterate

2017-12-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Iterate through an address space calling a function for each section. The iteration is done in order. Signed-off-by: Dr. David Alan Gilbert --- include/exec/memory.h | 23 +++ memory.c | 22 ++ 2 files changed

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Emilio G. Cota
On Mon, Dec 11, 2017 at 17:32:48 +, Peter Maydell wrote: > Thanks. I think I have come down on the side of putting this into > 2.11, so rolling an rc5 today, and delaying the final release > a day to Wednesday. Glad to see it's in -rc5 -- thanks for fixing this so quickly! Again, apologies fo

Re: [Qemu-devel] [PATCH v4 4/4] ivshmem: Disable irqfd on device reset

2017-12-11 Thread Markus Armbruster
Ladi Prosek writes: > The effects of ivshmem_enable_irqfd() was not undone on device reset. > > This manifested as: > ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed. > > when irqfd was enabled before reset and then enabled again after reset, making > ivshmem_enable_irqf

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread John Snow
On 12/11/2017 06:15 AM, Kevin Wolf wrote: > Am 09.12.2017 um 01:57 hat John Snow geschrieben: >> Here's an idea of what this API might look like without revealing >> explicit merge/split primitives. >> >> A new bitmap property that lets us set retention: >> >> :: block-dirty-bitmap-set-retention

[Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc5 is now available

2017-12-11 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the sixth release candidate for the QEMU 2.11 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.11.0-rc5.tar.xz http://dow

Re: [Qemu-devel] [PATCH for 2.11 0/2] QEMU crashes with CD device without media

2017-12-11 Thread John Snow
On 12/11/2017 05:24 AM, Denis V. Lunev wrote: > On 11/28/2017 03:10 PM, Denis V. Lunev wrote: >> There are 2 cases I have spotted so far: >> 1) IDE ATAPI read processing. Actually this was reported from field >> 2) QEMU IO hmp command (found during evaluation of (1)) >> >> SCSI code checks during

Re: [Qemu-devel] [PATCH v3 3/3] msi: Handle remappable format interrupt request

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:25PM +0800, Chao Gao wrote: > According to VT-d spec Interrupt Remapping and Interrupt Posting -> > Interrupt Remapping -> Interrupt Request Formats On Intel 64 > Platforms, fields of MSI data register have changed. This patch > avoids wrongly regarding a remappable fo

Re: [Qemu-devel] [PATCH v1 for-2-12 09/15] s390x/tcg: implement TEST PENDING INTERRUPTION

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:34 +0100 David Hildenbrand wrote: > Use s390_cpu_virt_mem_write() so we can actually revert what we did > (re-inject the dequeued IO interrupt). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 1 + > target/s390x/insn-data.def | 1 + > targ

Re: [Qemu-devel] [PATCH v3 2/3] xen/pt: Pass the whole msi addr/data to Xen

2017-12-11 Thread Anthony PERARD
On Fri, Nov 17, 2017 at 02:24:24PM +0800, Chao Gao wrote: > Previously, some fields (reserved or unalterable) are filtered by > Qemu. This fields are useless for the legacy interrupt format. > However, these fields are may meaningful (for intel platform) > for the interrupt of remapping format. It

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread John Snow
On 12/11/2017 12:17 PM, Max Reitz wrote: > On 2017-12-09 02:36, John Snow wrote: >> >> >> On 11/30/2017 08:23 AM, Max Reitz wrote: >>> On 2017-11-30 04:18, Fam Zheng wrote: On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/103 | 2 ++ >>

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Peter Maydell
On 11 December 2017 at 17:00, Richard Henderson wrote: > On 12/11/2017 07:42 AM, Peter Maydell wrote: >> The refactoring of commit 296e5a0a6c3935 has a nasty bug: >> it accidentally dropped the generation of code to raise >> the UNDEF exception when disas_thumb2_insn() returns nonzero. >> This mea

Re: [Qemu-devel] [PATCH-2.12 v2 2/3] xilinx_spips: Set all of the reset values

2017-12-11 Thread Alistair Francis
On Wed, Dec 6, 2017 at 3:39 PM, francisco iglesias wrote: > Hi Alistair, > > On 6 December 2017 at 23:22, Alistair Francis > wrote: >> >> Following the ZynqMP register spec let's ensure that all reset values >> are set. >> >> Signed-off-by: Alistair Francis >> --- >> V2: >> - Don't bother doubl

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 12:05 PM, Max Reitz wrote: > On 2017-12-11 17:47, John Snow wrote: >> On 12/11/2017 11:31 AM, Max Reitz wrote: >>> On 2017-12-08 18:09, John Snow wrote: On 12/08/2017 09:30 AM, Max Reitz wrote: > On 2017-12-05 01:48, John Snow wrote: >> >> I would say that a bitmap

Re: [Qemu-devel] [PATCH v1 for-2-12 04/15] s390x/flic: simplify flic initialization

2017-12-11 Thread Cornelia Huck
On Mon, 11 Dec 2017 14:47:29 +0100 David Hildenbrand wrote: > This makes it clearer, which device is used for which accelerator. > > Signed-off-by: David Hildenbrand > --- > hw/intc/s390_flic.c | 9 +++-- > hw/intc/s390_flic_kvm.c | 12 > include/hw/s390x/s390_f

Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

2017-12-11 Thread Max Reitz
On 2017-12-09 02:36, John Snow wrote: > > > On 11/30/2017 08:23 AM, Max Reitz wrote: >> On 2017-11-30 04:18, Fam Zheng wrote: >>> On Thu, 11/23 03:08, Max Reitz wrote: Signed-off-by: Max Reitz --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
Thank you Paolo, "Signed-off-by: George Kennedy" George On 12/11/2017 11:55 AM, Paolo Bonzini wrote: On 11/12/2017 17:45, George Kennedy wrote: The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread Max Reitz
On 2017-12-11 17:47, John Snow wrote: > > > On 12/11/2017 11:31 AM, Max Reitz wrote: >> On 2017-12-08 18:09, John Snow wrote: >>> >>> >>> On 12/08/2017 09:30 AM, Max Reitz wrote: On 2017-12-05 01:48, John Snow wrote: > > > On 12/04/2017 05:21 PM, Max Reitz wrote: >> On 2017-1

Re: [Qemu-devel] [PATCH for-2.11?] target/arm: Generate UNDEF for 32-bit Thumb2 insns

2017-12-11 Thread Richard Henderson
On 12/11/2017 07:42 AM, Peter Maydell wrote: > The refactoring of commit 296e5a0a6c3935 has a nasty bug: > it accidentally dropped the generation of code to raise > the UNDEF exception when disas_thumb2_insn() returns nonzero. > This means that 32-bit Thumb2 instruction patterns that > ought to UND

Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-12-11 Thread Anthony PERARD
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. > > Changes: > * use keycodedb to generate qcode to linux input

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:45, George Kennedy wrote: > The LSI 53c895a code does not handle the PPR Extended Message. Add > support to handle PPR Extended Message like SDTR and WDTR are handled. > That is, to skip past the message bytes and ignore the message. > > --- >  hw/scsi/lsi53c895a.c | 4 >  1 f

Re: [Qemu-devel] [PATCH] configure: Fix curses probe for older ncurses

2017-12-11 Thread Peter Maydell
On 26 November 2017 at 21:13, Brad Smith wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. > > Signed-off-by: Brad Smith > > > diff --git a/configure b/configure > index 0c6e7572

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
> atomic_mb_set can be a little faster on x86, so: > > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index dfba5ebd29..4452cd9856 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -528,12 +528,10 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, > >

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread Paolo Bonzini
On 11/12/2017 17:44, David Hildenbrand wrote: >> -void cpu_stop_current(void) >> -{ >> -if (current_cpu) { >> -qemu_cpu_stop(current_cpu, true); >> -} >> -} > Btw. this does not compile as this is used also in vl.c > Doh, then I'm applying your patch untouched. Paolo

Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev-backup: enable non-root nodes for backup

2017-12-11 Thread John Snow
On 12/11/2017 11:31 AM, Max Reitz wrote: > On 2017-12-08 18:09, John Snow wrote: >> >> >> On 12/08/2017 09:30 AM, Max Reitz wrote: >>> On 2017-12-05 01:48, John Snow wrote: On 12/04/2017 05:21 PM, Max Reitz wrote: > On 2017-12-04 23:15, John Snow wrote: >> >> >> On

[Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> -void cpu_stop_current(void) > -{ > -if (current_cpu) { > -qemu_cpu_stop(current_cpu, true); > -} > -} Btw. this does not compile as this is used also in vl.c > - > int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int vm_stop(RunStat

Re: [Qemu-devel] [PATCH v1] cpus: make pause_all_cpus() play with SMP on single threaded TCG

2017-12-11 Thread David Hildenbrand
> int vm_stop(RunState state) > { > if (qemu_in_vcpu_thread()) { > @@ -1818,7 +1809,8 @@ int vm_stop(RunState state) > * FIXME: should not return to device code in case > * vm_stop() has been requested. > */ > -cpu_stop_current(); > +qemu_cpu_st

  1   2   3   >